[issue6081] str.format_from_mapping()
Eric Smith added the comment: I'll work on cleaning this up for 3.2. Any comments on the name of the method? -- ___ Python tracker <http://bugs.python.org/issue6081> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9584] Allow curly braces in fnmatch
Eric Smith added the comment: I'm not sure it has to be consistent with the shell to be useful, as long as the behavior is documented and we possibly add a note explaining the differences from the shell. But I agree that a discussion on python-ideas would be helpful. -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue9584> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9601] ftplib should accept 250 on MKD
Eric Smith added the comment: Since this is a feature request, it could only be added to 3.2, not the other versions. -- nosy: +eric.smith type: behavior -> feature request versions: -Python 2.5, Python 2.6, Python 2.7, Python 3.1, Python 3.3 ___ Python tracker <http://bugs.python.org/issue9601> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9625] argparse: Problem with defaults for variable nargs
Changes by Eric Smith : -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue9625> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8595] Explain the default timeout in http-client-related libraries
Eric Smith added the comment: On 8/19/2010 9:14 AM, Antoine Pitrou wrote: > Why not provide {httplib,urllib}.{set,get}defaulttimeout() instead? Yes, I'm assuming that's how _HTTP_DEFAULT_TIMEOUT would be set and queried. -- ___ Python tracker <http://bugs.python.org/issue8595> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9694] argparse: Default Help Message Lists Required Args As Optional
Eric Smith added the comment: It looks to me like reqarg is marked as required, since it's not in brackets. Or am I missing something? -- nosy: +bethard, eric.smith ___ Python tracker <http://bugs.python.org/issue9694> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9694] argparse: Default Help Message Lists Required Args As Optional
Eric Smith added the comment: Duh. Sorry about that. Also applies to 3.2. -- versions: +Python 3.2 ___ Python tracker <http://bugs.python.org/issue9694> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9694] argparse: Default Help Message Lists Required Args As Optional
Eric Smith added the comment: Or "parameters:"? -- ___ Python tracker <http://bugs.python.org/issue9694> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9695] Return from generators in Python 3.2
Changes by Eric Smith : -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue9695> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9694] argparse: Default Help Message Lists Required Args As Optional
Eric Smith added the comment: If you add a positional parameter by adding: parser.add_argument('foo') then the output becomes: $ python argparse-help-says-required-args-are-optional.py -h usage: issue9649.py [-h] --reqarg REQARG [--optarg OPTARG] foo Do something positional arguments: foo optional arguments: -h, --helpshow this help message and exit --reqarg REQARG, -r REQARG This is required --optarg OPTARG, -o OPTARG This is optional $ So whatever replaces "optional arguments:" needs to read well with "positional arguments:". Maybe just plain "options:" is good enough, but I think a word to replace "optional" (leaving "arguments:") would be better. I just don't have any useful suggestion :) -- ___ Python tracker <http://bugs.python.org/issue9694> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9723] pipes.quote() needs to be documented
Eric Smith added the comment: I think you mean pipe.quote in your message, not pipe.call. The subject looks correct. I'm not sure pipes is the best place for this, but I agree it should probably be documented in older versions. It seems to me we've had this discussion before about quoting command lines, how it applies differently between Windows and various shells, and which functions to expose. But having said that, I can't find a previous issue that discusses it. Not the least of my concerns is that pipes says it's available on Unix systems, despite the fact that I have it on a Windows machine. And I might need the functionality of passing a bash command from a Windows machine to a Unix machine, so we definitely need this cross platform. -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue9723> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9743] __call__.__call__ chain cause crash when long enough
Eric Smith added the comment: I can duplicate this as a segmentation fault under 2.7 on Mac OS, but not under Windows 2.6 (ActiveState). What platform are you using, and what output do you see? -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue9743> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9743] __call__.__call__ chain cause crash when long enough
Eric Smith added the comment: Amaury: Good point. The Windows version is failing, too. A print statement at the end doesn't get executed. -- ___ Python tracker <http://bugs.python.org/issue9743> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9780] fill character cannot be '{'
Eric Smith added the comment: Sorry to respond late. The reason for this is that the parsing of the string (as delimited by "{" and "}") happens before the results are then interpreted as format specifiers. There's no way around it, short of the parser understanding every object's formatting language, which is of course not possible. It could be special cased for string, int, and float format specifiers, but that doesn't make much sense. I think the doc change is good. -- ___ Python tracker <http://bugs.python.org/issue9780> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9805] Documentation on old-style formatting of dicts is overly restrictive
Changes by Eric Smith : -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue9805> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9807] deriving configuration information for different builds with the same prefix
Changes by Eric Smith : -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue9807> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9805] Documentation on old-style formatting of dicts is overly restrictive
Eric Smith added the comment: I think this might be a dupe of issue 1467929. -- ___ Python tracker <http://bugs.python.org/issue9805> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7994] object.__format__ should reject format strings
Eric Smith added the comment: Manually merged to py3k in r84790. I'll leave this open until I create the 3.3 issue to change it to a DeprecationWarning. -- keywords: -needs review versions: -Python 3.3 ___ Python tracker <http://bugs.python.org/issue7994> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9855] Complex number slicing neither works nor causes an error on immediate use
Eric Smith added the comment: The precedence doesn't work the way you think it does. Your example with the intermediate variable is the same as: >>> ((0+1j)*(0+1j)).imag 0.0 >>> ((0+1j)*(0+1j)).real -1.0 Note the extra level of parens so that .imag and .real are applied to the result of the multiplication. -- nosy: +eric.smith resolution: -> invalid stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.org/issue9855> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9856] Change object.__format__(s) where s is non-empty to a DeprecationWarning
New submission from Eric Smith : In 3.3 the existing PendingDeprecationWarning needs to become a DeprecationWarning. In 3.4 it will become an error. I'll change 3.3 after 3.2 is released. See issue 7994 for the original PendingDeprecationWarning discussion. -- assignee: eric.smith components: Interpreter Core keywords: easy messages: 116413 nosy: eric.smith priority: normal severity: normal status: open title: Change object.__format__(s) where s is non-empty to a DeprecationWarning type: behavior versions: Python 3.3 ___ Python tracker <http://bugs.python.org/issue9856> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7994] object.__format__ should reject format strings
Eric Smith added the comment: See issue 9856 for changing this to a DeprecationWarning in 3.3. -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue7994> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9873] Allow bytes in some APIs that use string literals internally
Changes by Eric Smith : -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue9873> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9869] long_subtype_new segfault in pure-Python code
Changes by Eric Smith : -- nosy: +eric.smith versions: -Python 2.5 ___ Python tracker <http://bugs.python.org/issue9869> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1724822] provide a shlex.split alternative for Windows shell syntax
Eric Smith added the comment: Raymond Chen's blog today discusses CommandLineToArgvW, which is apparently an API that can parse command lines. It's not clear to me if this is actually called by the MSFT CRT: http://blogs.msdn.com/b/oldnewthing/archive/2010/09/17/10063629.aspx Here's the documentation for it: http://msdn.microsoft.com/en-us/library/bb776391%28VS.85%29.aspx I don't know if we could call this directly (or via ctypes), or if we could emulate it based on the documentation, which doesn't seem very complete. -- ___ Python tracker <http://bugs.python.org/issue1724822> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1735509] Newer reply format for imap commands in imaplib.py
Eric Smith added the comment: I'm not sure what "fetch command does not contain literal" means. If the OP can clarify, I'd be interested in this issue. -- nosy: +eric.smith status: pending -> open ___ Python tracker <http://bugs.python.org/issue1735509> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1724822] provide a shlex.split alternative for Windows shell syntax
Eric Smith added the comment: Now that I think about this some more, we wouldn't want to call this API. I'd rather this hypothetical function be available on non-Windows platforms, so we'd have to implement the semantics of CommandLineToArgvW or whichever CRT we decide to match. -- ___ Python tracker <http://bugs.python.org/issue1724822> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9869] long_subtype_new segfault in pure-Python code
Eric Smith added the comment: There are plenty of tests that check implementation specific internal behaviors. I don't think the presence of test alone would mean that it can't be changed. -- ___ Python tracker <http://bugs.python.org/issue9869> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9908] os.stat() fails on bytes paths under Windows 7
Changes by Eric Smith : -- nosy: +eric.smith, jaraco ___ Python tracker <http://bugs.python.org/issue9908> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9915] speeding up sorting with a key
Changes by Eric Smith : -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue9915> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9932] List of sets initialization behavior problems
Eric Smith added the comment: This is well defined in Python and will not change. -- nosy: +eric.smith resolution: -> rejected stage: -> committed/rejected status: open -> closed type: -> feature request ___ Python tracker <http://bugs.python.org/issue9932> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9418] Move _formatter_* methods from string type into _string module
Eric Smith added the comment: My only concern with this is that it would cause other implementations to do the same thing. I assume it's not hard for them, but it is work. I know that IronPython implemented the _formatter_* methods so that they could use string.py as-is. But that's a small concern, I think this is a good idea in general. I agree it should be its own C module _string. -- ___ Python tracker <http://bugs.python.org/issue9418> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9418] Move _formatter_* methods from string type into _string module
Eric Smith added the comment: Now that I start this, I see that it's complicated by the fact that the functions actually being wrapped are in stringlib/string_format.h. That's because in 2.x they compile as both unicode and str. Before the _string module is created, the code should really be moved out of stringlib (possibly into _string). But that's a much more involved task. I guess it depends if we want to have a bytes version of format(). If we do, it's best to leave the code in stringlib so it can be shared between the implementations. If we never want that, it can be removed from stringlib and put somewhere else, removing the ability to call it both ways. I'll have to give that some thought. -- ___ Python tracker <http://bugs.python.org/issue9418> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9418] Move _formatter_* methods from string type into _string module
Eric Smith added the comment: The more I think about this, the more sense it makes to leave the module in unicodeobject.c. Certainly all the code it's likely to ever contain would already be in unicodeobject.c. While I agree there's some conceptual clarity to be had by having the code in a new Modules/_stringmodule.c (and indeed, that's the first place I'd go if I were looking for it), I think that practically it might make sense to leave it in unicodeobject.c. On the other hand, there are no modules defined in Objects/*.c, so this is clearly an unusual and unexpected practice. Maybe a first step would be to commit Georg's patch as-is. Later I'll get rid of stringlib (at least for format()), then at that point rethink where any module should live. I note that Georg's code doesn't need any tests because the affected code in string.py is already tested and will fail if the module is moved. -- ___ Python tracker <http://bugs.python.org/issue9418> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9980] str(float) failure
Eric Smith added the comment: >From their web page, it looks like PyScripter only runs on Windows, so I >assume these results are generated there. I won't be able to test on Windows until tonight. Kiriakos: Does this only happen within PyScripter, or does it also happen when you use the python.exe using the same pythonxx.dll? -- ___ Python tracker <http://bugs.python.org/issue9980> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9980] str(float) failure
Eric Smith added the comment: It's interesting to note that '9' is ascii 57, and ':' is 58. It's like the code is incrementing the wrong digit. If it's related to that, that indeed sounds like a compiler optimization bug to me, but of course I'm just guessing. And I'm not sure that conclusion matches the rest of the known facts. -- ___ Python tracker <http://bugs.python.org/issue9980> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9980] str(float) failure
Eric Smith added the comment: I agree that in an ideal world there would not be a dependency on global flags. There's no doubt a performance issue with doing so, although someone would have to measure that. It may well be swamped by the memory allocation, etc. that is going on at the same time and so won't matter. Mark will no doubt know this better than I do, but I also assume that there's an issue with thread safety when changing such global state. -- ___ Python tracker <http://bugs.python.org/issue9980> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8913] Document that datetime.__format__ is datetime.strftime
Eric Smith added the comment: I'm okay with that. Grepping Lib shows that date/datetime/time and Decimal are the only types that implement __format__. Decimal largely implements the same language as float. -- ___ Python tracker <http://bugs.python.org/issue8913> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10021] Format parser is too permissive
Eric Smith added the comment: Right. It seemed like a hassle to have the str.format parser try to figure out what a valid identifier is, so it just passes it through. I don't see this as any different from: >>> class X: ...def __getattribute__(self, a): return 'foo' ... >>> getattr(X(), '$#@') 'foo' -- ___ Python tracker <http://bugs.python.org/issue10021> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10021] Format parser is too permissive
Eric Smith added the comment: Ah, but I don't need to in order to comply with the PEP! -- ___ Python tracker <http://bugs.python.org/issue10021> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10021] Format parser is too permissive
Eric Smith added the comment: I agree it should be documented as a CPython specific behavior. I should also add a CPython specific test for it, modeled on your code (if one doesn't already exist). I'll look into it. -- ___ Python tracker <http://bugs.python.org/issue10021> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10021] Format parser is too permissive
Eric Smith added the comment: I agree that it being an implementation detail is not a good thing. I think we should just document the current CPython behavior as the language standard: once parsed, any string after a dot is passed to getattr. I can't see why we should pay the penalty of validating it as an identifier when the behavior is well defined and matches my getattr example in msg 117965. -- ___ Python tracker <http://bugs.python.org/issue10021> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10043] UnboundLocalError with local variable set by setattr, caused by code run later
Eric Smith added the comment: When python sees the assignment "name = None", it assumes that 'name' is a local variable. This happens before any code is executed. It then sees that you're printing 'name' before it is assigned to, which is an error. It does not take into account the dynamic creation of the module level variable. -- nosy: +eric.smith resolution: -> invalid status: open -> closed ___ Python tracker <http://bugs.python.org/issue10043> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10043] UnboundLocalError with local variable set by setattr, caused by code run later
Eric Smith added the comment: It's a well documented behavior. Surely you ran across this link while researching your problem? http://docs.python.org/reference/executionmodel.html#naming-and-binding The paragraph beginning "The following constructs bind names ..." describes why setattr does not create a binding, although I'll grant that it doesn't mention setattr by name. The paragraph beginning "If a name binding operation occurs anywhere within a code block ..." explains why the assignment affects code that occurs before the binding. If you'd like to improve the docs, please suggest a patch. Also note that you're not creating a local variable with setattr, you're creating a module level (sometimes called global) variable. Perhaps that's part of the misunderstanding? You might want to look into the global (on nonlocal) statement, unless there's some particular reason the name you're creating needs to be dynamically computed. -- assignee: -> d...@python components: +Documentation -Interpreter Core nosy: +d...@python resolution: invalid -> stage: -> needs patch status: closed -> open versions: +Python 3.2 -Python 2.6 ___ Python tracker <http://bugs.python.org/issue10043> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10041] socket.makefile(mode = 'r').readline() silently removes carriage return
Eric Smith added the comment: Isn't this just the normal universal newline handling? When you open it in binary mode you see all of the characters, but in text mode (the absence of "b") you get normalized newlines (that is, they're converted to "\n"). -- components: -2to3 (2.x to 3.0 conversion tool) nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue10041> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10044] small int optimization
Changes by Eric Smith : -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue10044> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10044] small int optimization
Eric Smith added the comment: In the bad old days of 386 segment:offset memory architectures this was a problem. You could have overlapping segments but pointers inside an object were always in the same segment, so the segment selectors never had to be inspected. Pointers to different objects could indeed have the same offset and would compare equal. We should follow the standard here: no comparisons between pointers to different arrays (basically). -- ___ Python tracker <http://bugs.python.org/issue10044> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10052] Python/dtoa.c:158: #error "Failed to find an exact-width 32-bit integer type" (FreeBSD 4.11 + gcc 2.95.4)
Changes by Eric Smith : -- nosy: +eric.smith, mark.dickinson ___ Python tracker <http://bugs.python.org/issue10052> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10083] locale.currency() uses different formatting than system locale for negative values
Eric Smith added the comment: I don't have a copy of Vista or 7 handy to check with. Could you tell me what locale.localeconv() returns on a non-working system and on a working system (preferably Windows XP)? -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue10083> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10083] locale.currency() uses different formatting than system locale for negative values
Changes by Eric Smith : -- components: +Library (Lib) ___ Python tracker <http://bugs.python.org/issue10083> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10083] locale.currency() uses different formatting than system locale for negative values
Eric Smith added the comment: So it looks like locale.currency() is doing the right thing, given the values returned by locale.localeconv(). These values are copied from C's localeconv(), so the problem must be there. I don't see how we can do anything about it on the Python side, unfortunately. -- ___ Python tracker <http://bugs.python.org/issue10083> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10083] locale.currency() uses different formatting than system locale for negative values
Changes by Eric Smith : -- resolution: -> invalid stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.org/issue10083> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10135] Format specifier 'n' not working
Eric Smith added the comment: How are you setting the Slovenian locale? Could please let me know what this prints: import locale locale.localeconv() Also, could you let me know what: locale.format('%.3f', 2.45) prints? Both of these would be when the Slovenian locale is selected. Thanks. -- ___ Python tracker <http://bugs.python.org/issue10135> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10135] Format specifier 'n' not working
Eric Smith added the comment: Oops, I meant "locale.format('%.3f', 2.76)", although of course the number shouldn't matter. -- ___ Python tracker <http://bugs.python.org/issue10135> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10135] Format specifier 'n' not working
Eric Smith added the comment: It looks like the float.__format__ code is correctly using the value of decimal_point = '.'. It also agrees with locale.format(). How are you setting the locale? The problem appears to be either how you are setting the locale or the contents of the locale, not in the formatting code. -- ___ Python tracker <http://bugs.python.org/issue10135> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10135] Format specifier 'n' not working
Changes by Eric Smith : -- resolution: -> invalid status: open -> closed ___ Python tracker <http://bugs.python.org/issue10135> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10135] Format specifier 'n' not working
Changes by Eric Smith : Removed file: http://bugs.python.org/file19265/unnamed ___ Python tracker <http://bugs.python.org/issue10135> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10135] Format specifier 'n' not working
Changes by Eric Smith : Removed file: http://bugs.python.org/file19266/unnamed ___ Python tracker <http://bugs.python.org/issue10135> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10135] Format specifier 'n' not working
Changes by Eric Smith : Removed file: http://bugs.python.org/file19269/unnamed ___ Python tracker <http://bugs.python.org/issue10135> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10135] Format specifier 'n' not working
Changes by Eric Smith : -- stage: -> committed/rejected ___ Python tracker <http://bugs.python.org/issue10135> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10163] 7/200 and 7%200 show weird results
Eric Smith added the comment: Which version of python? Could you run this from the command line and paste the complete session, including the version info that python prints on startup? -- nosy: +eric.smith, mark.dickinson ___ Python tracker <http://bugs.python.org/issue10163> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10206] python program starting with unmatched quote spews spaces to stdout
Eric Smith added the comment: This is caused by r85814. I've got a fix, as soon as I get it in a presentable state I'll post it. -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue10206> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10206] python program starting with unmatched quote spews spaces to stdout
Eric Smith added the comment: This patch fixes the issue, and makes print_error_text slightly more understandable (and efficient to boot, not that it matters). But I'm not convinced it's the correct solution. I think the real error might be the computation "offset" in the caller. I'm still looking at it. -- assignee: -> eric.smith components: +Interpreter Core keywords: +patch stage: needs patch -> patch review Added file: http://bugs.python.org/file19396/issue10206.diff ___ Python tracker <http://bugs.python.org/issue10206> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10206] python program starting with unmatched quote spews spaces to stdout
Eric Smith added the comment: Now that I think about it some more, I think my patch (although it fixes this issue and passes all tests) doesn't do what the original code does in the presence of multiple newlines. I'm going to rework it some more. I'll have another patch shortly. -- ___ Python tracker <http://bugs.python.org/issue10206> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10206] python program starting with unmatched quote spews spaces to stdout
Eric Smith added the comment: I think Benjamin fixed this in r85904. I'm going to verify and add some tests. -- priority: critical -> normal stage: patch review -> unit test needed ___ Python tracker <http://bugs.python.org/issue10206> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10206] python program starting with unmatched quote spews spaces to stdout
Changes by Eric Smith : Removed file: http://bugs.python.org/file19396/issue10206.diff ___ Python tracker <http://bugs.python.org/issue10206> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10288] Remove deprecated C "character" handling macros ISUPPER() etc
Eric Smith added the comment: +1 I agree on removing the lowercase versions. It's sort of handy having them around to prevent accidental uses. But the same could be said for other similar macros/functions. Plus they wouldn't work if the isXXX symbols were really functions, not macros (not that I know if that's even allowed by the standard). The patch looks okay to me, although I didn't actually compile and run the tests. You'll find out soon enough! The issue number in the NEWS entry needs to be fixed, of course. Thanks for doing this, Dave. -- ___ Python tracker <http://bugs.python.org/issue10288> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6081] str.format_from_mapping()
Eric Smith added the comment: Updated patch which adds tests and minimal docs. Named changed to format_map. I'll commit this before 3.2b1 unless I hear a complaint. -- keywords: +easy, needs review resolution: -> accepted Added file: http://bugs.python.org/file19482/issue6081-1.diff ___ Python tracker <http://bugs.python.org/issue6081> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6081] str.format_map()
Changes by Eric Smith : -- title: str.format_from_mapping() -> str.format_map() ___ Python tracker <http://bugs.python.org/issue6081> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6081] str.format_map()
Eric Smith added the comment: Committed to 3.2 in r86170. -- stage: patch review -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.org/issue6081> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10322] sys.argv and quoted arguments on command line
Eric Smith added the comment: I don't see this behavior on MacOS: $ ./argtest arg1 arg2 "this should be a single argument" 2.6.1 (r261:67515, Feb 11 2010, 15:47:53) [GCC 4.2.1 (Apple Inc. build 5646)] ['./argtest', 'arg1', 'arg2', 'this should be a single argument'] This splitting is done by the shell (Unix-like systems) or by the C runtime (Windows), not by Python. What OS are you running? -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue10322> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10318] "make altinstall" installs many files with incorrect shebangs
Eric Smith added the comment: Is there any reason for the test files to have a shebang line at all? I think those should be removed, which would cut the problem in half. Also, given "-m", I'm not sure any of the files in the stdlib should have a shebang line. Is there really an expectation that these should be run directly? Is anyone really running UserString.py as a script in order to run its tests? -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue10318> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10322] sys.argv and quoted arguments on command line
Eric Smith added the comment: The python version works for me also on a Fedora box with 3.2 and 2.7. What shell are you using? Did you compile this python yourself, or did it come with your distro? -- ___ Python tracker <http://bugs.python.org/issue10322> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10322] sys.argv and quoted arguments on command line
Changes by Eric Smith : -- components: -None resolution: -> invalid stage: -> committed/rejected ___ Python tracker <http://bugs.python.org/issue10322> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10288] Remove deprecated C "character" handling macros ISUPPER() etc
Eric Smith added the comment: I'd 'svnmerge block' them, just in case anyone decides to manually merge (which I doubt will happen, but you never know). -- ___ Python tracker <http://bugs.python.org/issue10288> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10252] Fix resource warnings in distutils
Eric Smith added the comment: Is it really true that 3.x's distutils is source compatible with 2.3? For 3.x I'd like to see the with statement used. -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue10252> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10354] tempfile.template is broken
Eric Smith added the comment: The patch looks good to me, but it needs a test. -- nosy: +eric.smith stage: -> unit test needed ___ Python tracker <http://bugs.python.org/issue10354> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10354] tempfile.template is broken
Eric Smith added the comment: I sort of agree with David. The global "template" is a bad name and a bad design. And since it doesn't work I don't think anything would be lost by modifying the code to ignore it; document that it's unused and deprecated; and remove it in a future version. -- ___ Python tracker <http://bugs.python.org/issue10354> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10379] locale.format() input regression
Changes by Eric Smith : -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue10379> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10379] locale.format() input regression
Eric Smith added the comment: I agree the documentation isn't terribly clear on what a "%char specifier" or "whole format string" is. FWIW, this is also a 3.1 and greater issue. -- versions: +Python 3.1, Python 3.2 ___ Python tracker <http://bugs.python.org/issue10379> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10379] locale.format() input regression
Changes by Eric Smith : -- assignee: -> d...@python components: +Documentation nosy: +d...@python ___ Python tracker <http://bugs.python.org/issue10379> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10395] os.path.commonprefix broken by design
Eric Smith added the comment: Indeed, that behavior seems completely useless. I've verified that it works the same in 2.5.1. -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue10395> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10395] os.path.commonprefix broken by design
Eric Smith added the comment: Although there are test cases in test_genericpath that verify this behavior, so apparently it's intentional. -- ___ Python tracker <http://bugs.python.org/issue10395> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10401] Globals / builtins cache
Changes by Eric Smith : -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue10401> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11378] os.path.join when second argument starts with '/' (linux/unix)
Eric Smith added the comment: I appreciate that you're unconvinced of its usefulness, but you can be assured that some of us do find it a useful and desirable behavior. And Python isn't the only system that works this way, emacs does the same thing when you enter filenames. -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue11378> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11382] some posix module functions unnecessarily release the GIL
Changes by Eric Smith : -- components: +Interpreter Core nosy: +eric.smith, pitrou ___ Python tracker <http://bugs.python.org/issue11382> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10833] Replace %.100s by %s in PyErr_Format(): the arbitrary limit of 500 bytes is outdated
Eric Smith added the comment: I don't feel strongly one way or the other about it. I was just relaying the reason I heard when I asked the question about why it's done the way it is. I suggest mentioning that you're going to commit this change on python-dev, since this seems like an issue that people might care about without knowing about its existence in the bug tracker. -- ___ Python tracker <http://bugs.python.org/issue10833> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11396] add format handler to bytes object
Eric Smith added the comment: There have been a number of discussions about this, but no concrete proposal. The last one I recall was to add a __bformat__ method, but I couldn't find the email trail just now. See also issue 3982. -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue11396> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11396] add format handler to bytes object
Eric Smith added the comment: I found part of the discussion I was looking for: http://mail.python.org/pipermail/python-dev/2010-July/102252.html -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue11396> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11072] Add MLSD command support to ftplib
Eric Smith added the comment: I agree that the callback isn't needed, and it reflects the older coding style of much of the library (such as in retrlines). Instead, I'd make this a generator, yielding each of the dicts. (Actually in some ideal rewrite of ftplib, the whole callback "feature" used by retrlines would go away except as a compatibility feature, and internally everything would use generators instead of callbacks.) Aren't you modifying the state on the server (via "OPTS MLST"), and then if you make a subsequent call without specifying "facts" you'll be using the value of "facts" from the previous call to MLSD? I don't think that's desirable, but short of calling "OPTS MLST" every time (possibly with the results of an initial FEAT) there's no way around it. Just today I saw a filename with "; " in the name. I think you want to use .partition(' ') isolate the facts from the filename, and add a test with such a filename. I don't like the "isdigit" test. Shouldn't this decision be left to the caller? What if a fact happens to look like an integer some of the time, but not always? Maybe "unique" is a hex string. I don't think you'd want it converted to an int on the occasions where it was all decimal digits, but a string otherwise. Also look at your "modify" facts. Those are not very useful as ints. I don't think you should invent a pseudo-fact "name", in case the standard ever uses that. I'd prefer if you yielded tuples of (filename, fact-dict). MLSD_DATA has newlines in it, so you get "\r\n\n" sequences in your test data. If a fact=value string does not have an '=', you silently ignore it. I'd rather this raise an exception and not pass silently. It's not compliant. You should have a test for this. It's possible for a value to have an '=' in it, so you don't want to use .split('='), you should use .partition('='). You should add such a fact to the test data. Thanks for working on this. It will be a great addition to ftplib. -- ___ Python tracker <http://bugs.python.org/issue11072> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11072] Add MLSD command support to ftplib
Eric Smith added the comment: I'll give this a proper review in the next day or so (busy at PyCon). Despite the fact that I typically hate changing values returned by the server, I agree on case-folding the fact names to lowercase upon reading them. The RFC clearly states they're case insensitive: "Fact names are case-insensitive. Size, size, SIZE, and SiZe are the same fact." You should have the facts in MLSD_DATA be mixed case, to ensure they're being lowercased correctly. I agree that there's nothing that can be done in the case where no facts are specified: the spec clearly says just use the values we've previously set. Caller beware. -- ___ Python tracker <http://bugs.python.org/issue11072> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11072] Add MLSD command support to ftplib
Eric Smith added the comment: So it is. I told you I hadn't done a proper review! I was mainly trying to say I agree with lowercasing. I'll shut up until I can read the whole patch. -- ___ Python tracker <http://bugs.python.org/issue11072> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9584] Allow curly brace expansion
Eric Smith added the comment: I removed the unused import (mostly as a simple test of mercurial, it's my first commit there). -- ___ Python tracker <http://bugs.python.org/issue9584> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9856] Change object.__format__(s) where s is non-empty to a TypeError
Eric Smith added the comment: Next step is to make it a TypeError in 3.4. -- priority: normal -> release blocker title: Change object.__format__(s) where s is non-empty to a DeprecationWarning -> Change object.__format__(s) where s is non-empty to a TypeError versions: +Python 3.4 -Python 3.3 ___ Python tracker <http://bugs.python.org/issue9856> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9856] Change object.__format__(s) where s is non-empty to a TypeError
Changes by Eric Smith : -- priority: release blocker -> deferred blocker ___ Python tracker <http://bugs.python.org/issue9856> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11505] string.py increased test coverage
Changes by Eric Smith : -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue11505> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11607] Apllication crashes when saving file
Eric Smith added the comment: You're going to need to supply more information. What application? Can you post the source code? What does "crashes" mean? Is it giving a Python traceback? If so, please supply it. Thanks. -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue11607> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9584] Allow curly brace expansion
Eric Smith added the comment: Yes, we recently switched to Mercurial. See http://docs.python.org/devguide/faq.html You shouldn't need to change your patches just because of the switch from svn. -- ___ Python tracker <http://bugs.python.org/issue9584> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7833] Bdist_wininst installers fail to load extensions built with Issue4120 patch
Changes by Eric Smith : -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue7833> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11641] raw_input() -> input() security issue
Changes by Eric Smith : -- resolution: -> invalid status: open -> closed type: security -> ___ Python tracker <http://bugs.python.org/issue11641> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11644] 2to3 example.py is not a Python 2.x file
Eric Smith added the comment: Plus, it's recommended to move to 2.6 or 2.7 before trying to port to 3.x. -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue11644> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com