[issue35573] is_HDN is returns false positive and false negative value for two test cases respectively

2018-12-23 Thread Divya Rani 


Change by Divya Rani :


--
components: Library (Lib)
nosy: Divya Rani
priority: normal
severity: normal
status: open
title: is_HDN is returns false positive and false negative value for two test 
cases respectively
type: behavior
versions: Python 3.6

___
Python tracker 
<https://bugs.python.org/issue35573>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35573] is_HDN is returns false positive and false negative value for two test cases respectively

2018-12-23 Thread Divya Rani 


Divya Rani  added the comment:

import cookiejar

cookiejar.is_HDN("foo!bar.com")
Output:
True

cookiejar.is_HDN("woo.com.")

Output:
False

Test cases taken from:
1. 
https://github.com/google/guava/blob/581ba1436ebaa54a7f5d0f1db8cc4da0ca72127e/android/guava-tests/test/com/google/common/net/InternetDomainNameTest.java#L81
2.
https://github.com/google/guava/blob/581ba1436ebaa54a7f5d0f1db8cc4da0ca72127e/android/guava-tests/test/com/google/common/net/InternetDomainNameTest.java#L65

--
nosy:  -xtreak

___
Python tracker 
<https://bugs.python.org/issue35573>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35576] function splitextTest does not return expected value

2018-12-23 Thread Divya Rani 


New submission from Divya Rani :

1. For input ".blah." output is "." 
2. For input "..." output is "..." 

results produced by the function are wrong according to the test suite provided 
by guava.
1. 
https://github.com/google/guava/blob/1e072a7922a0b3f7b45b9f53405a233834175177/guava-tests/test/com/google/common/io/FilesTest.java#L644
2.
https://github.com/google/guava/blob/1e072a7922a0b3f7b45b9f53405a233834175177/guava-tests/test/com/google/common/io/FilesTest.java#L628

--
components: Library (Lib)
messages: 332407
nosy: Divya Rani
priority: normal
severity: normal
status: open
title: function splitextTest does not return expected value
type: behavior
versions: Python 3.6

___
Python tracker 
<https://bugs.python.org/issue35576>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35573] is_HDN is returns false positive and false negative value for two test cases respectively

2018-12-23 Thread Divya Rani 


Divya Rani  added the comment:

The function link is here: 
https://github.com/python/cpython/blob/e42b705188271da108de42b55d9344642170aa2b/Lib/http/cookiejar.py#L521

The function returned true for "foo!bar.com" which is false positive and the 
test case is taken from the list of invalid domain names present in Guava test 
suite 
https://github.com/google/guava/blob/581ba1436ebaa54a7f5d0f1db8cc4da0ca72127e/android/guava-tests/test/com/google/common/net/InternetDomainNameTest.java#L81

Domain names with dots at the end are fully qualified domain names. (reference:
1.https://stackoverflow.com/questions/19480767/domain-names-with-dots-at-the-end#answer-19498025
2. https://en.wikipedia.org/wiki/Fully_qualified_domain_name#Syntax
)
the function returned false for "woo.com." which is a false negative.
The test case is again taken from list of valid domain names provided by guava 
test suite 
(https://github.com/google/guava/blob/581ba1436ebaa54a7f5d0f1db8cc4da0ca72127e/android/guava-tests/test/com/google/common/net/InternetDomainNameTest.java#L65)

--
nosy:  -xtreak

___
Python tracker 
<https://bugs.python.org/issue35573>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com