[issue45944] Avoid calling isatty() for most open() calls

[Collin Anderson]

Change by Collin Anderson :


--
components: IO
nosy: collinanderson
priority: normal
severity: normal
status: open
title: Avoid calling isatty() for most open() calls
type: performance
versions: Python 3.10, Python 3.11, Python 3.6, Python 3.7, Python 3.8, Python 
3.9

___
Python tracker 
<https://bugs.python.org/issue45944>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45944] Avoid calling isatty() for most open() calls

[Collin Anderson]

Change by Collin Anderson :


--
keywords: +patch
pull_requests: +28096
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/29870

___
Python tracker 
<https://bugs.python.org/issue45944>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45944] Avoid calling isatty() for most open() calls

[Collin Anderson]

New submission from Collin Anderson :

isatty() is a system call on linux. Most open()s are files, and we're already 
getting the size of the file. If it has a size, then we know it's not a atty, 
and can avoid calling it.

--

___
Python tracker 
<https://bugs.python.org/issue45944>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34510] Add add HTTPConnection.settimeout()

[Collin Anderson]

Change by Collin Anderson :


--
components: Library (Lib)
nosy: collinanderson
priority: normal
pull_requests: 8422
severity: normal
status: open
title: Add add HTTPConnection.settimeout()
type: enhancement

___
Python tracker 
<https://bugs.python.org/issue34510>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23038] #python.web irc channel is dead

[Collin Anderson]

New submission from Collin Anderson:

Can we remove references to #python.web? I assume it was a flourishing channel 
at some point.

https://docs.python.org/3/howto/webservers.html#other-notable-frameworks

--
assignee: docs@python
components: Documentation
messages: 232550
nosy: collinanderson, docs@python
priority: normal
severity: normal
status: open
title: #python.web irc channel is dead
versions: Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5, Python 3.6

___
Python tracker 
<http://bugs.python.org/issue23038>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25228] Regression in cookie parsing with brackets and quotes

[Collin Anderson]

Collin Anderson added the comment:

The issue I'm currently running into, is that although browsers correctly 
ignore invalid Set-Cookie values, they allow 'any CHAR except CTLs or ";"' in 
cookie values set via document.cookie.

So, if you say document.cookie = 'key=va"lue; path=/', the browser will happily 
pass 'key=va"lue;' to the server on future requests.

So, I like the behavior of this patch, which skips over these invalid cookies 
and continues parsing. I've cleaned the patch up a little, but it should be the 
same logically.

--
nosy: +collinanderson
Added file: http://bugs.python.org/file41889/cookie-bracket-quotes.diff

___
Python tracker 
<http://bugs.python.org/issue25228>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25228] Regression in cookie parsing with brackets and quotes

[Collin Anderson]

Collin Anderson added the comment:

It should be safe to hard split on semicolon. `name="some;value"` is not valid, 
even though it's quoted. I think raw double quotes, commas, semicolons and 
backslashes are _always_ invalid characters in cookie values.

>From https://tools.ietf.org/html/rfc6265:

{{{
 cookie-value  = *cookie-octet / ( DQUOTE *cookie-octet DQUOTE )
 cookie-octet  = %x21 / %x23-2B / %x2D-3A / %x3C-5B / %x5D-7E
   ; US-ASCII characters excluding CTLs,
   ; whitespace DQUOTE, comma, semicolon,
   ; and backslash
}}}

--

___
Python tracker 
<http://bugs.python.org/issue25228>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com