[issue12961] unlabelled balls in boxes
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue12961> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13238] Add shell command helpers to shutil module
Chris Rebert added the comment: Is format() really the best choice here, considering that {}s already have a meaning in the shell? -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue13238> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10364] IDLE: make .py default added extension on save
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue10364> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13535] Improved two's complement arithmetic support: to_signed() and to_unsigned()
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue13535> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13658] Extra clause in class grammar documentation
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue13658> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12857] Expose called function on frame object
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue12857> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12760] Add create mode to open()
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue12760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9922] subprocess.getstatusoutput can fail with utf8 UnicodeDecodeError
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue9922> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12029] ABC registration of Exceptions
Chris Rebert added the comment: Scouting around the CPython codebase a bit, I speculate that the cause of this behavior is that PyErr_GivenExceptionMatches() in errors.c uses PyType_IsSubtype() [which simply walks a class's __mro__ checking for pointer equality] rather than PyObject_IsSubclass()/PyObject_IsInstance() [which are smart enough to consult __subclasscheck__()/__instancecheck__() if they exist]. Of course, the more important issue here is whether this behavior is intended or not. I surmise python-dev needs to have a discussion about it? -- ___ Python tracker <http://bugs.python.org/issue12029> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11377] Deprecate platform.popen()
Chris Rebert added the comment: Slight tangent: Regarding os.popen()'s [documentation] status, there's a bug for that: http://bugs.python.org/issue9382 -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue11377> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12029] ABC registration of Exceptions
Chris Rebert added the comment: Surveying the docs, the current behavior *is* /technically/ correct (in a suspiciously precise way) according to the Language Reference: http://docs.python.org/dev/reference/compound_stmts.html#grammar-token-try_stmt : "For an except clause with an expression [...] the clause matches the exception if the resulting object is 'compatible' with the exception. An object is compatible with an exception if it is the class or a base class of the exception object" (which exactly describes what PyType_IsSubtype() checks for) The Tutorial is by contrast much more vague: http://docs.python.org/dev/tutorial/errors.html#handling-exceptions : "if [the raised exception's] type matches the exception named after the except keyword, the except clause is executed, and then execution continues after the try statement." No definition of what it means for the types to "match" seems to be given. -- ___ Python tracker <http://bugs.python.org/issue12029> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12192] Doc that collection mutation methods return item or None
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue12192> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6490] os.popen documentation in 2.6 is probably wrong
Chris Rebert added the comment: Per msg129958, attached is my stab at a patch to replace most uses of os.popen() with the subprocess module. The test suite passes on my Mac, but the patch does touch some specific-to-other-platform code, so further testing is obviously needed. This is my first non-docs patch, please be gentle. :) [Those patches were to subprocess' docs though!] Stuff still using os.popen() that the patch doesn't fix: - multiprocessing - platform.popen() [which is itself deprecated] - subprocess.check_output() - Lib/test/test_poll.py - Lib/test/test_select.py - Lib/distutils/tests/test_cygwinccompiler.py Also, I suppose Issue 9382 should be marked as a dupe of this one? -- nosy: +cvrebert Added file: http://bugs.python.org/file22188/mostly_replace_os_popen.patch ___ Python tracker <http://bugs.python.org/issue6490> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3177] implement os.startfile on posix and MacOSX
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue3177> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1170] shlex have problems with parsing unicode
Changes by Chris Rebert : -- nosy: -cvrebert ___ Python tracker <http://bugs.python.org/issue1170> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7950] subprocess.Popen documentation should contain a good warning about the security implications when using shell=True
Chris Rebert added the comment: Adjusted patch per R. David's comment. I obviously think it should be a full red warning box (that's how it is in my patch), but my opinion clearly isn't an outside one. Also, Ping/Bump on finally getting this applied. -- Added file: http://bugs.python.org/file18670/subprocess.rst.diff ___ Python tracker <http://bugs.python.org/issue7950> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7950] subprocess.Popen documentation should contain a good warning about the security implications when using shell=True
Chris Rebert added the comment: "the above Note" mentioned in those last two lines demonstrates shlex.split() and correct tokenization. -- ___ Python tracker <http://bugs.python.org/issue7950> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11926] help("keywords") returns incomplete list of keywords
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue11926> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12029] ABC registration of Exceptions
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue12029> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12067] Doc: remove errors about mixed-type comparisons.
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue12067> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Chris Rebert added the comment: Working on a more concise new draft... -- ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Chris Rebert added the comment: Okay; new, hopefully better, draft. Feedback? -- versions: -Python 3.1 Added file: http://bugs.python.org/file16094/subprocess.rst.patch ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Chris Rebert added the comment: Gonna have to disagree about the raw_input(), because the escaping involved would complicate the example and could be distracting/confusing. Rest of Brian's suggestions taken into account. -- Added file: http://bugs.python.org/file16095/subprocess.rst.patch ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Changes by Chris Rebert : Removed file: http://bugs.python.org/file14770/subprocess.rst.patch ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Changes by Chris Rebert : Removed file: http://bugs.python.org/file16094/subprocess.rst.patch ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Chris Rebert added the comment: Well, the same basic example is used for cohesiveness, but the issue/pitfall being highlighted in each note is distinct. But you have a point about shlex being pointed out twice, so here's a version with that redundancy excised. -- Added file: http://bugs.python.org/file16098/subprocess.rst.patch ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Chris Rebert added the comment: Counterpatch incorporating R. David Murray's succinctness improvements while retaining correct positioning of the first note, managing to incorporate the 3rd note not present in Mr. Murray's, and including more precise wording to address the problem Eric Smith pointed out. -- Added file: http://bugs.python.org/file16101/subprocess.rst.patch ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Changes by Chris Rebert : Removed file: http://bugs.python.org/file15033/subprocess.rst.patch ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Changes by Chris Rebert : Removed file: http://bugs.python.org/file16095/subprocess.rst.patch ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Chris Rebert added the comment: This version takes Murray's most recent draft, applies some minor tweaks from my prior patch, and has the "python -c" etc. changed to "echo '$MONEY'" so the sh -c comment is completely unambiguous (and it's a simpler example generally). Whether the subprocess.Popen() call should be demonstrated in the code snippet remains an open issue. -- Added file: http://bugs.python.org/file16108/subprocess.rst.patch ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Changes by Chris Rebert : Removed file: http://bugs.python.org/file16101/subprocess.rst.patch ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Changes by Chris Rebert : Added file: http://bugs.python.org/file16109/subprocess.rst.patch ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Changes by Chris Rebert : Removed file: http://bugs.python.org/file16108/subprocess.rst.patch ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Chris Rebert added the comment: Okay, now if this could just get dev review... -- Added file: http://bugs.python.org/file16128/subprocess.rst.patch ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Changes by Chris Rebert : Removed file: http://bugs.python.org/file16109/subprocess.rst.patch ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Chris Rebert added the comment: Thanks to all for the copious feedback & suggestions, and R. David Murray for his superior docs writing skills! -- ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6760] patch to subprocess docs to better explain Popen's 'args' argument
Chris Rebert added the comment: One problem with the 3.x versions: the raw_input() should be input(). -- ___ Python tracker <http://bugs.python.org/issue6760> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5250] Document __instancecheck__ and __subclasscheck__
Changes by Chris Rebert : -- nosy: +cvrebert versions: +Python 2.6, Python 2.7, Python 3.2 ___ Python tracker <http://bugs.python.org/issue5250> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5250] Document __instancecheck__ and __subclasscheck__
Chris Rebert added the comment: Here's a draft of an updated version of the "Data model" docs reflecting the changes in the PEP. -- keywords: +patch type: -> feature request Added file: http://bugs.python.org/file16891/datamodel.rst.diff ___ Python tracker <http://bugs.python.org/issue5250> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5250] Document __instancecheck__ and __subclasscheck__
Changes by Chris Rebert : Added file: http://bugs.python.org/file16893/datamodel.rst.diff ___ Python tracker <http://bugs.python.org/issue5250> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5250] Document __instancecheck__ and __subclasscheck__
Chris Rebert added the comment: This might need to be reopened. There's a verb missing from he following sentence of the patch: "This is consistent with the lookup of special methods that called on instances, only that in this case the instance is itself a class." Secondly, and more importantly, the issubclass() and isinstance() docs don't mention the new special methods in question. -- ___ Python tracker <http://bugs.python.org/issue5250> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5250] Document __instancecheck__ and __subclasscheck__
Chris Rebert added the comment: One last triviality: Could the mention of __subclasscheck__() in http://docs.python.org/dev/library/abc.html#abc.ABCMeta.__subclasshook__ get linked to the newly-added docs? -- ___ Python tracker <http://bugs.python.org/issue5250> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13997] Add open_ascii() builtin
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue13997> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13997] Add open_ascii() builtin
Chris Rebert added the comment: @Bendersky: Unlike open()'s other arguments, that one wouldn't be orthogonal though. It would be possible to write e.g.: f = open(fname, encoding="big5", errors="replace", ascii_only=True) which seems disturbing, IMO. It would be nicer to rule out such impossible combinations categorically. -- ___ Python tracker <http://bugs.python.org/issue13997> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14015] surrogateescape largely missing from documentation
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue14015> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13866] {urllib, urllib.parse}.urlencode should not use quote_plus
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue13866> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13703] Hash collision security issue
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue13703> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14186] Link to PEP 3107 in "def" part of Language Reference
New submission from Chris Rebert : The part of the Language Reference concerning the `def` statement (http://docs.python.org/dev/reference/compound_stmts.htm#function-definitions ) should include a See Also link to PEP 3107 "Function Annotations". -- assignee: docs@python components: Documentation messages: 154851 nosy: cvrebert, docs@python priority: normal severity: normal status: open title: Link to PEP 3107 in "def" part of Language Reference versions: Python 3.3 ___ Python tracker <http://bugs.python.org/issue14186> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14187] add "annotation" entry to Glossary
New submission from Chris Rebert : The Glossary should include an entry for "annotation" and/or "function annotation" regarding the language feature introduced by PEP 3107. -- assignee: docs@python components: Documentation messages: 154852 nosy: cvrebert, docs@python priority: normal severity: normal status: open title: add "annotation" entry to Glossary versions: Python 3.3 ___ Python tracker <http://bugs.python.org/issue14187> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13703] Hash collision security issue
Chris Rebert added the comment: The Design and History FAQ (will) need a minor corresponding update: http://docs.python.org/dev/faq/design.html#how-are-dictionaries-implemented -- ___ Python tracker <http://bugs.python.org/issue13703> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14186] Link to PEP 3107 in "def" part of Language Reference
Chris Rebert added the comment: My suggestion was a seealso to parallel those in the "The with Statement" and "Class definitions" sections of the same page. -- ___ Python tracker <http://bugs.python.org/issue14186> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14187] add "annotation" entry to Glossary
Chris Rebert added the comment: Well, I thought the Glossary was a somewhat useful document in and of itself ("What's conceptual term 'X' mean? Hmm... I'll check the Glossary!") and so should include all terms which aren't module-specific. But I won't push hard if no one else sees value in adding this entry. -- ___ Python tracker <http://bugs.python.org/issue14187> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14187] add "annotation" entry to Glossary
Chris Rebert added the comment: Also, it would be a nice place to point out for those coming from Java or similar that the Java-esque concept of annotations has little to do with Python's function annotations, and that in Python their uses are typically served using decorators instead. -- ___ Python tracker <http://bugs.python.org/issue14187> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14187] add "annotation" entry to Glossary
Chris Rebert added the comment: Strawman entry wording: An annotation is an arbitrary metadata value associated with a function parameter or return value. The syntax for function annotations is explained in [Function definitions][http://docs.python.org/dev/reference/compound_stmts.html#function-definitions]. Annotations may be accessed via the [__annotations__][http://docs.python.org/dev/reference/datamodel.html#the-standard-type-hierarchy : Callable types -> User-defined functions -> Special attributes] special attribute of a function object. Python itself does not assign any particular meaning to function annotations; they are intended to be interpreted by third-party libraries or tools. Annotations were added to Python by [PEP 3107 "Function Annotations"][http://www.python.org/dev/peps/pep-3107/], which describes some of their possible uses. Some other languages (e.g. Java, C#) also have a concept of "annotations", but it is distinct from the Python concept; the purpose of these "annotations" is served in Python using [decorators]["decorator" entry in Glossary] instead. -- ___ Python tracker <http://bugs.python.org/issue14187> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14257] minor error in glossary wording regarding __hash__
New submission from Chris Rebert : The entry for "dictionary" reads in part: [...] The keys can be any object with __hash__() function and __eq__() methods. [...] __hash__() is a method, not a function (well, it's a "hash function" in the computer science sense, but it's still confusing even if that reading is what was intended; I think delegating the hashing part of the explanation to __hash__()'s docs is fine). Remove the word "function" from said sentence. -- assignee: docs@python components: Documentation messages: 155427 nosy: cvrebert, docs@python priority: normal severity: normal status: open title: minor error in glossary wording regarding __hash__ versions: Python 3.3 ___ Python tracker <http://bugs.python.org/issue14257> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14257] minor error in glossary wording regarding __hash__
Chris Rebert added the comment: I regret to inform you that those changes made the sentence in question ungrammatical. Removing the word "method" will make it grammatical again (as originally suggested). -- resolution: fixed -> status: closed -> open ___ Python tracker <http://bugs.python.org/issue14257> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14298] account for dict randomization in Design & History FAQ
New submission from Chris Rebert : The randomization introduced by the fix for issue 13703 means that the example string hash values given in http://docs.python.org/dev/faq/design.html#how-are-dictionaries-implemented are liable to become more difficult to reproduce (in fact, the example already currently implicitly assumes a 32-bit build). Either the phrasing should be changed to emphasize that these are *possible* values the strings *might* hash to, or no concrete hash values should be given at all. -- assignee: docs@python components: Documentation messages: 155714 nosy: cvrebert, docs@python priority: normal severity: normal status: open title: account for dict randomization in Design & History FAQ versions: Python 3.4 ___ Python tracker <http://bugs.python.org/issue14298> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13997] Clearly explain the bare minimum Python 3 users should know about Unicode
Chris Rebert added the comment: Links to the "rambling Unicode thread"s for posterity and convenience: Gets into several issues, among them, Unicode: http://mail.python.org/pipermail/python-ideas/2012-February/013665.html Unicode-specific offshoot of the above: http://mail.python.org/pipermail/python-ideas/2012-February/013825.html -- ___ Python tracker <http://bugs.python.org/issue13997> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3177] Add shutil.open
Chris Rebert added the comment: > The alternative is to call Popen(['xdg-open', etc.]) and check if we get > ENOENT, but I don’t know if this would be non-ambiguous (for example, do we > get ENOENT if xdg-open exists but not the file?). It's unambiguous. Python itself never opens the target file, it just passes the filepath string along to the xdg-open command. If Popen raises EnvironmentError, then xdg-open could not be executed. If the target file is nonexistent, then xdg-open will exit with status 2 (see aforelinked manpage). Entirely different error mechanisms. > A related question: what to do when we’re not on Windows nor Mac and xdg-open > doesn’t exist? Raise NotImplemented? Seems reasonable to me. So, the failure cases are: (1) Platform doesn't support this feature -> raise NotImplemented (2) Target file doesn't exist (3) Target file is inaccessible (4) No application is associated with the file type in question OS X and xdg-open report (2) and (4), does Windows? OS X reports (3) indirectly/vaguely [generic exit status 1 w/ possibly unstable error message]; don't know what Windows and xdg-open do here. -- ___ Python tracker <http://bugs.python.org/issue3177> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7839] Popen should raise ValueError if pass a string when shell=False or a list when shell=True
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue7839> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3177] Add shutil.open
Chris Rebert added the comment: >> (2) Target file doesn't exist >> (4) No application is associated with the file type in question > I think that instead of mapping error codes to custom exceptions, which is > fragile and not trivial to maintain, we should just catch stderr and raise > something like OSError(stderr) It runs counter to the goal of a cross-platform API if *all* the errors are platform-specific. I grant that a generic API cannot wrap *every* possible error, but (2) and (4) are amongst the most common+obvious failure modes and are (FWICT) explicitly reported by all 3 native interfaces. If we don't consolidate them, we'll basically be condemning non-trivial users to copying (or writing themselves, probably inferiorly) a chunk of boilerplate recipe code, and if we're fine with that, then why bother having (this in) the std lib at all? I don't think the handling code for them would be particularly fragile/onerous; we're talking a mere ~2 constants per platform, all tied to pretty-unlikely-to-change native interfaces. For context, here would be (AFAICT; I only have a Mac ATM) the constants in question: Windows: function return value: ERROR_FILE_NOT_FOUND, ERROR_PATH_NOT_FOUND SE_ERR_NOASSOC xdg-open (*nix): exit code: 2 3 Mac OS X: exit code 1 w/ stderr output: "The file XXX does not exist." "No application knows how to open XXX." -- ___ Python tracker <http://bugs.python.org/issue3177> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7839] Popen should raise ValueError if pass a string when shell=False or a list when shell=True
Chris Rebert added the comment: > The reason I'm not a fan is the fact that, with "shell=True", you can use the > *executable* argument to Popen to select a non-default shell. At that point, > passing a list can make sense, even if it isn't useful for the default shell. Modulo Windows, at that point, why not just run the shell explicitly (i.e. shell=False, args=['my_sh', ...])? Also, a '-c' argument will be forcibly prepended to the passed-in `args` in your case, which may frustrate such use-cases. > For the other way around, passing a string with "shell=False" can be a > straightforward way to launch GUI applications from a script. And they may need to eventually pass it (an) argument(s), and when that happens, cue confusion! There's a reason the `subprocess` docs feature the not-strictly-necessary clause "[a str `args` w/ shell=False] will only work if the program is being given no arguments". The distinction regularly trips/tripped users up. -- ___ Python tracker <http://bugs.python.org/issue7839> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14481] trivial formatting error in subprocess docs
New submission from Chris Rebert : The final line under "17.1.4.2. Replacing shell pipeline" (http://docs.python.org/dev/library/subprocess.html#replacing-shell-pipeline ) isn't formatted as code (e.g. monospaced); it should be. -- assignee: docs@python components: Documentation messages: 157401 nosy: cvrebert, docs@python priority: normal severity: normal status: open title: trivial formatting error in subprocess docs versions: Python 3.3 ___ Python tracker <http://bugs.python.org/issue14481> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14544] Limit "global" keyword name conflicts in language spec to those enforced by CPython
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue14544> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22674] RFE: Add signal.strsignal(): string describing a signal
Change by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <https://bugs.python.org/issue22674> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10581] Review and document string format accepted in numeric data type constructors
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue10581> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18163] Add a 'key' attribute to KeyError
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue18163> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18166] 'value' attribute for ValueError
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue18166> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18162] Add index attribute to IndexError
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue18162> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18170] define built-in exceptions in Python code
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue18170> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18335] Add textwrap.dedent, .indent, as str methods.
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue18335> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18406] unicodedata.itergraphemes / str.itergraphemes / str.graphemes
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue18406> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18369] X509 cert class for ssl module
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue18369> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18264] enum.IntEnum is not compatible with JSON serialisation
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue18264> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18436] Add mapping of symbol to function to operator module
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue18436> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3177] Add shutil.open
Chris Rebert added the comment: Here's a quick stab at 2/3rds of an implementation, and some docs. -- Added file: http://bugs.python.org/file25310/shutil_open.py ___ Python tracker <http://bugs.python.org/issue3177> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3177] Add shutil.open
Chris Rebert added the comment: > # or os.name == 'mac' ??? Nope, that refers to retro Mac OS 9 (and probably lower). Mac OS X is 'posix' for os.name purposes. -- ___ Python tracker <http://bugs.python.org/issue3177> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3177] Add shutil.open
Chris Rebert added the comment: `operation` seems questionable. IMO, the verbs seem stronger / more important than mere optional suggestions (particularly "open" vs. "edit" for files with read-only viewers), and only Windows supports them (so anyone requiring that feature might as well just use startfile() directly). By virtue of this function being cross-platform, we're kinda limited to just supporting the lowest common denominator. Hobs, can you explain `gui`? Also, does startfile() raise exceptions for either of the basic error conditions ("no such file" and "no associated application")? If not, I believe using the lower-level ShellExecute (http://msdn.microsoft.com/en-us/library/windows/desktop/bb762153%28v=vs.85%29.aspx ) or similar Windows API function would allow us to report such errors, as the other platform implementations currently do. -- ___ Python tracker <http://bugs.python.org/issue3177> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14616] subprocess docs should mention pipes.quote/shlex.quote
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue14616> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3177] Add shutil.open
Chris Rebert added the comment: No, it isn't. Changing the `IOError(errno.ENOENT, "...`s to `FileNotFoundError("...`s would half fix it. The other half, the `OSError(errno.ENOSYS)`s, has a FIXME for what's the right error to raise in that case ("no application associated with files of this type"). I have no idea myself. None of the new PEP 3151 errors apply. Nor did any of the errnos strictly speaking AFAICT; ENOSYS was the closest approximation I could find. Thoughts? Custom error class? Different errno? Something else? -- ___ Python tracker <http://bugs.python.org/issue3177> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3177] Add shutil.open
Chris Rebert added the comment: >> ENOSYS was the closest approximation I could find. Thoughts? Custom >> error class? Different errno? Something else? > > Why not ValueError? Because the value they provided was perfectly valid (the file/directory *did* exist), so the caller's request was reasonable. It's the system(/ its (lack of) configuration) that failed the caller in finding an opener application. The "fix" after encountering the exception is to add an association to the system configuration (and/or install a new application), not to pass a different path to the function. IMO, it feels like an EnvironmentError or RuntimeError of some sort; hence the current use of OSError. (Or NotImplementedError, but we're already using that exception to indicate a different failure condition, so that's out.) -- ___ Python tracker <http://bugs.python.org/issue3177> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3177] Add shutil.open
Chris Rebert added the comment: Hobs, why is exit code 4 of xdg-open (which the manpage describes as the extremely generic "The action failed.") interpreted as FileNotFoundError in your new version? -- ___ Python tracker <http://bugs.python.org/issue3177> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3177] Add shutil.open
Chris Rebert added the comment: Also: The FileNotFoundErrors quote the path twice: Python 2.7.1 (r271:86832, Jul 31 2011, 19:30:53) >>> path = "/foo/bar" >>> print "Path '%s' may not exist" % repr(path) Path ''/foo/bar'' may not exist The ValueError error message isn't grammatically correct and doesn't account for the possibility that the path is a directory (consider the case of a Unix system where the GUI file manager has been uninstalled; directories would then fail to open). May I suggest my original message?: "No application is associated with files/directories of the given type" -- ___ Python tracker <http://bugs.python.org/issue3177> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3177] Add shutil.open
Chris Rebert added the comment: The xdg-open source code (http://cgit.freedesktop.org/xdg/xdg-utils/tree/scripts/xdg-open ) shows that exit code 4 is used whenever an invocation of another opener script (e.g. kde-open, gnome-open) fails for any reason besides said script not being installed. So I'm not so sure we can jump to the conclusion that 4 automatically means FileNotFound. -- ___ Python tracker <http://bugs.python.org/issue3177> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3177] Add shutil.open
Chris Rebert added the comment: >> The semantics of "associated application" change considerably from >> operating system to operating system. As an example, >> ``os.startfile("a.py")`` will usually run `a.py` in the Python >> interpreter, while ``xdg-open a.py`` it will usually open the source >> code in an editor on Linux. > > Outch. I think the behavior should be more similar than that, i.e. that the > function should use startfile with the edit action on Windows. It's a universal problem on all 3 platforms. Given a script file argument, a generic "open" (as opposed to "edit") procedure will either run the script or open it in an editor, depending entirely upon the user's system configuration. Same thing happens when double-clicking a script in the file manager, which is IMO what we're trying to emulate here. It sounds like some people want a generic "(text) edit" procedure, which IMO is different enough to warrant a separate bug since there are different/more design issues to tackle (e.g. if someone edit()s an image file (or a file of uncertain type) on Unix, what application is opened, and how is that determined?). And no peeking at Mercurial's code; it's under GPLv2, whereas Python is under BSD/MIT-like licensing, making them incompatible. -- ___ Python tracker <http://bugs.python.org/issue3177> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3177] Add shutil.open
Changes by Chris Rebert : Added file: http://bugs.python.org/file25332/shutil_open.patch ___ Python tracker <http://bugs.python.org/issue3177> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9530] integer undefined behaviors
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue9530> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13968] Support recursive globs
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue13968> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10427] 24:00 Hour in DateTime
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue10427> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14187] add "annotation" entry to Glossary
Chris Rebert added the comment: Any reactions to the strawman wording for the entry? -- ___ Python tracker <http://bugs.python.org/issue14187> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14187] add "annotation" entry to Glossary
Chris Rebert added the comment: Here's an actual patch. -- keywords: +patch Added file: http://bugs.python.org/file25544/func_annotation.patch ___ Python tracker <http://bugs.python.org/issue14187> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14187] add "function annotation" entry to Glossary
Chris Rebert added the comment: Right, I can see how the 3rd paragraph has become tangential given the refined scope of the entry. What do people think about a separate entry: "annotation" Can refer to either a `function annotation` or some uses of `decorator`s. ? -- ___ Python tracker <http://bugs.python.org/issue14187> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14187] add "function annotation" entry to Glossary
Changes by Chris Rebert : Added file: http://bugs.python.org/file25568/function_annotation_v2.patch ___ Python tracker <http://bugs.python.org/issue14187> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14616] subprocess docs should mention pipes.quote/shlex.quote
Chris Rebert added the comment: Patch to mention shlex.quote() in the `subprocess` module's "Frequently Used Arguments" Warning box. Could perhaps be a separate Note, but that could be clutter-y. -- keywords: +patch Added file: http://bugs.python.org/file25570/subprocess_shlex_quote.patch ___ Python tracker <http://bugs.python.org/issue14616> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7839] Popen should raise ValueError if pass a string when shell=False or a list when shell=True
Chris Rebert added the comment: Re: Nick's comments: Besides `close_fds`, what other Popen parameters currently have suboptimal defaults? -- ___ Python tracker <http://bugs.python.org/issue7839> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14674] Add link to RFC 4627 from json documentation
Chris Rebert added the comment: Draft docs patch. More cross-referencing. Analysis of deviations from RFC based on previous docs & the RFC. Don't know if there are relevant, more precise implementation limitations that need to be mentioned. If backported to 2.x, will need to cover encodings slightly more. -- keywords: +patch nosy: +cvrebert Added file: http://bugs.python.org/file25591/json.rst.patch ___ Python tracker <http://bugs.python.org/issue14674> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14805] Support display of both __cause__ and __context__
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue14805> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14757] INCA: Inline Caching meets Quickening in Python 3.3
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker <http://bugs.python.org/issue14757> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14674] Add link to RFC 4627 from json documentation
Changes by Chris Rebert : Added file: http://bugs.python.org/file25592/json.rst.patch ___ Python tracker <http://bugs.python.org/issue14674> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14674] Add link to RFC 4627 from json documentation
Chris Rebert added the comment: New revision per Éric's Rietveld feedback. Sidenote: Is there any way to get notified of these reviews? I only saw it because I happened to click the "review" link on a lark. -- Added file: http://bugs.python.org/file25594/json.rst.patch ___ Python tracker <http://bugs.python.org/issue14674> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com