[issue17299] Test cPickle with real files
Aman Shah added the comment: Created a small patch for python 2.7 using file test_pickle.py . -- nosy: +Aman.Shah Added file: http://bugs.python.org/file29266/patch ___ Python tracker <http://bugs.python.org/issue17299> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17299] Test cPickle with real files
Aman Shah added the comment: Fixed the patch by removing TESTFN from tearDown. -- Added file: http://bugs.python.org/file29267/patch ___ Python tracker <http://bugs.python.org/issue17299> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17299] Test cPickle with real files
Aman Shah added the comment: I had put in the renaming because "ioclass" is not defined in the class itself, only in the subclasses. So, instantiating it and using dumps/loads would be meaningless and would raise an error. Which is similar to the behavior of an abstract class. Also, the "if(self.f):" part can be improved as you said and I looked at the patch for other similar mistakes. But, it's an isolated mistake (at lines 33 and 74) and so maybe it can be fixed during the merge itself? -- ___ Python tracker <http://bugs.python.org/issue17299> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17299] Test cPickle with real files
Aman Shah added the comment: I have updated the patch for test_cpickle.py . Also, I would like to help out in creating mixins for the 3 but, it would be helpful if you can explain it in a bit more detail. What is the problem in using the existing pickletester.py?? -- Added file: http://bugs.python.org/file29356/test_cpickle_patch ___ Python tracker <http://bugs.python.org/issue17299> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17296] Cannot unpickle classes derived from 'Exception'
Aman Shah added the comment: Fixed the patch for 2.7 -- nosy: +Aman.Shah Added file: http://bugs.python.org/file29373/issue_17296.patch ___ Python tracker <http://bugs.python.org/issue17296> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17296] Cannot unpickle classes derived from 'Exception'
Aman Shah added the comment: I think it works with the other test also now. Have also included the failed test mentioned by Tres in the patch since it wasn't present in the python2.7 test suite. -- Added file: http://bugs.python.org/file29381/issue_17296v2.patch ___ Python tracker <http://bugs.python.org/issue17296> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17299] Test cPickle with real files
Aman Shah added the comment: Version 3. -- keywords: +patch Added file: http://bugs.python.org/file29383/issue17299v3.patch ___ Python tracker <http://bugs.python.org/issue17299> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17402] In mmap doc examples map() is shadowed
Aman Shah added the comment: Corrected map -> mymap. -- keywords: +patch nosy: +Aman.Shah Added file: http://bugs.python.org/file29386/issue17402.patch ___ Python tracker <http://bugs.python.org/issue17402> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com