date:20220314

[issue46246] importlib.metadata.DeprecatedList appears to be missing slots

2022-03-14 Thread Jason R. Coombs



Change by Jason R. Coombs :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47009] Streamline list.append for the common case

2022-03-14 Thread Inada Naoki



Inada Naoki  added the comment:

Hmm. Would you measure benefit from inlining and skipping incref/decref 
separately?

If benefit of inlining is very small, making _PyList_AppendTakeRef() as regular 
internal API looks better to me.

--
nosy: +methane

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47007] [doc] str docs are inconsistent with special method lookup

2022-03-14 Thread Vedran Čačić


Vedran Čačić  added the comment:

You mean `type(object).__str__(object)` instead of `type(object).__str__()`, 
obviously.

--
nosy: +veky

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40280] Consider supporting emscripten/webassembly as a build target

2022-03-14 Thread Christian Heimes



Change by Christian Heimes :


--
pull_requests: +29963
pull_request: https://github.com/python/cpython/pull/31865

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35228] Index search in CHM help crashes viewer

2022-03-14 Thread Inada Naoki



Inada Naoki  added the comment:

I know chm is handy. But Microsoft abandoned it already.
I think we should stop providing chm.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47010] Implement zero copy writes in SelectorSocketTransport in asyncio

2022-03-14 Thread Kumar Aditya



New submission from Kumar Aditya :

Currently, _SelectorSocketTransport transport creates a copy of the data before 
sending which in case of large amount of data, can create multiple giga bytes 
copies of data before sending.

Script demonstrating current behavior:

-

import asyncio
import memory_profiler

@memory_profiler.profile
async def handle_echo(reader: asyncio.StreamReader, writer: 
asyncio.StreamWriter):
data = b'x' * 1024 * 1024 * 1000 # 1000 MiB payload
writer.write(data)
await writer.drain()
writer.close()

async def main():
server = await asyncio.start_server(
handle_echo, '127.0.0.1', )

addrs = ', '.join(str(sock.getsockname()) for sock in server.sockets)
print(f'Serving on {addrs}')

async with server:
asyncio.create_task(server.start_serving())
reader, writer = await asyncio.open_connection('127.0.0.1', )
while True:
data = await reader.read(1024 * 1024 * 100)
if not data:
break

asyncio.run(main())
-

Memory profile result:

Filename: test.py

Line #Mem usageIncrement  Occurrences   Line Contents
=
 4 17.7 MiB 17.7 MiB   1   @memory_profiler.profile
 5 async def handle_echo(reader: 
asyncio.StreamReader, writer: asyncio.StreamWriter):
 6   1017.8 MiB   1000.1 MiB   1   data = b'x' * 1024 * 1024 * 
1000 # 1000 MiB payload
 7   2015.3 MiB997.5 MiB   1   writer.write(data)
 8   2015.3 MiB   -988.1 MiB   2   await writer.drain()
 9   1027.1 MiB   -988.1 MiB   1   writer.close()



To make it zero copy, python's buffer protocol can be used and use memory views 
of data to save RAM. The writelines method currently joins all the data before 
sending whereas it can use `socket.sendmsg` to make it more memory efficient.


Links:

- writelines - 
https://github.com/python/cpython/blob/2153daf0a02a598ed5df93f2f224c1ab2a2cca0d/Lib/asyncio/transports.py#L116

- socket.sendmsg - 
https://docs.python.org/3/library/socket.html#socket.socket.sendmsg

- memory_profiler -
https://pypi.org/project/memory-profiler/

--
components: asyncio
messages: 415124
nosy: asvetlov, gvanrossum, kumaraditya303, yselivanov
priority: normal
severity: normal
status: open
title: Implement zero copy writes in SelectorSocketTransport in asyncio
type: resource usage
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46906] Add PyFloat_(Pack|Unpack)(2|4|8) to the public C API

2022-03-14 Thread STINNER Victor



Change by STINNER Victor :


--
pull_requests: +29964
pull_request: https://github.com/python/cpython/pull/31866

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47011] Cloned turtle pen is not cleared completely

2022-03-14 Thread Learn Coding



New submission from Learn Coding :

When calling clear() method on a cloned turtle, some painted lines still remain 
on the screen.

--
components: Library (Lib)
files: testturtle.py
messages: 415125
nosy: learncoding
priority: normal
severity: normal
status: open
title: Cloned turtle pen is not cleared completely
versions: Python 3.10
Added file: https://bugs.python.org/file50673/testturtle.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47011] Cloned turtle pen is not cleared completely

2022-03-14 Thread Learn Coding



Learn Coding  added the comment:

Tested on Windows 10

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47009] Streamline list.append for the common case

2022-03-14 Thread Dennis Sweeney



Dennis Sweeney  added the comment:

The attached _PyList_AppendTakeRef.diff has the ceval.c, but this 
implementation:

int
_PyList_AppendTakeRef(PyListObject *self, PyObject *newitem)
{
assert(self != NULL && newitem != NULL);
assert(PyList_Check(self));
Py_ssize_t len = PyList_GET_SIZE(self);
Py_ssize_t allocated = self->allocated;
assert((size_t)len + 1 < PY_SSIZE_T_MAX);
if (allocated > len) {
PyList_SET_ITEM(self, len, newitem);
Py_SET_SIZE(self, len + 1);
return 0;
}
if (list_resize(self, len + 1) < 0) {
Py_DECREF(newitem);
return -1;
}
PyList_SET_ITEM(self, len, newitem);
return 0;
}

Results:

| Benchmark   | main  | PR 31864  | 
_PyList_AppendTakeRef.diff |
|-|:-:|:-:|:--:|
| listcomp 100| 1.61 us   | 1.33 us: 1.21x faster | 1.55 us: 1.04x 
faster  |
| append 100  | 2.11 us   | 1.82 us: 1.15x faster | 2.05 us: 1.03x 
faster  |
| listcomp 1000   | 12.6 us   | 9.83 us: 1.28x faster | 11.9 us: 1.06x 
faster  |
| append 1000 | 18.1 us   | 15.3 us: 1.18x faster | 17.6 us: 1.03x 
faster  |
| listcomp 1  | 121 us| 93.2 us: 1.29x faster | 114 us: 1.06x 
faster   |
| append 1| 175 us| 150 us: 1.17x faster  | 172 us: 1.02x 
faster   |
| listcomp 10 | 1.17 ms   | 923 us: 1.26x faster  | 1.15 ms: 1.02x 
faster  |
| append 10   | 1.70 ms   | 1.49 ms: 1.14x faster | not significant 
   |
| Geometric mean  | (ref) | 1.21x faster  | 1.03x faster
   |

--
Added file: https://bugs.python.org/file50674/_PyList_AppendTakeRef.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43253] asyncio open_connection fails when a socket is explicitly closed

2022-03-14 Thread Maximilian Hils

Maximilian Hils added the comment:

asvetlov: Sorry if I articulated myself badly, but I do think this is a valid
bug. It's unfortunately hard to provide a better repro (I tried), but we are
hitting this regularly when mitmproxy is accepting connections under heavy
load. We're just calling `asyncio.start_server(handler, "127.0.0.1", 8080)` in
mitmproxy and never interact with the underlying socket object.

Here are some observations that are true for all crashes:

- The socket fileno is -1 when it crashes.
- `_call_connection_lost` is called by `_ProactorBasePipeTransport.close`,
which is called by `_ProactorBasePipeTransport.__del__` [1]
- There are no previous calls to `_call_connection_lost`.
- Windows only, loopback connections in our case.
- Wireshark shows that client and server are first happily exchanging packets.
At some point the client sends a FIN, which the Python server ACKs immediately.
A few seconds later the Python server sends a FIN back.

An obvious fix without understanding the root cause would be to check fileno in
https://github.com/python/cpython/blob/d929aa70e2a324ea48fed221c3257f929be05115/Lib/asyncio/proactor_events.py#L161.
I'm not too familar with proactor to assess if that is a good idea. Sorry for
not being able to provide more details.

1 2 >

1 - 100 of 141 matches

Mail list logo