[issue43082] descriptor howto: typo in "Definition and introduction"

[diegoe]

Change by diegoe :


--
keywords: +patch
pull_requests: +23208
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/24394

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43082] descriptor howto: typo in "Definition and introduction"

[Raymond Hettinger]

Change by Raymond Hettinger :


--
assignee: docs@python -> rhettinger
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43080] pprint for dataclass instances

[Raymond Hettinger]

Raymond Hettinger  added the comment:

Since a dataclass can do anything a regular class can do, it is probably too 
general to have a special case for pprint.

--
assignee:  -> eric.smith
nosy: +eric.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34321] mmap.mmap() should not necessarily clone the file descriptor

[Christian Heimes]

Christian Heimes  added the comment:

This issue came up in another discussion. I have given it some thought. 
mmap.mmap() dups the FD because its close() and __exit__() methods close(2) the 
fd. The size() and resize() methods use the fd to determine the size of the 
underlying file or to resize the file.

The easiest way to solve the issue while avoind footguns, is an option to not 
track the fd at all, e.g. "trackfd" with default "True". mmap(..., 
trackfd=False) would neither dup the fd nor store the fd in its internal 
struct. In untracked fd case, size() and resize() would no longer work. That's 
totally fine for mappings without PROT_WRITE.

It's safe to close the fd after mmap call, see 
https://man7.org/linux/man-pages/man2/mmap.2.html

> After the mmap() call has returned, the file descriptor, fd, can
> be closed immediately without invalidating the mapping.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43080] pprint for dataclass instances

[Lewis Gaul]

Lewis Gaul  added the comment:

> a dataclass can do anything a regular class can do

Agreed, but isn't that also true of any subclasses of currently supported 
types? In particular 'UserDict', 'UserList' and 'UserString', which all have 
explicit support in pprint and are intended for "easier subclassing" according 
to the docs.

I'm also not sure why it would be a reason for not giving it pprint handling 
(in the case where there's no user-defined __repr__). Is there any harm in 
doing so? 

I'd consider dataclasses one of the primary choices for storing data in modern 
Python (e.g. for converting to/from JSON/YAML), and may well be used for 
storing nested data, which can be very hard to read without some mechanism for 
pretty-printing.

Indeed, the dataclasses.asdict() function recurses into dataclass fields. This 
gives the option of pprint(dataclasses.asdict(my_dataclass)), but at the cost 
of losing the class names and any custom reprs.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43083] Minor errors related to error handling in _sqlite3 module

[Serhiy Storchaka]

New submission from Serhiy Storchaka :

There are few minor errors in the _sqlite3:

* In two places the result of PyList_Append() is not checked.
* The lastrowid field of pysqlite_Cursor can contain a reference to destroyed 
object when GIL is released for calling sqlite3_last_insert_rowid().
* Exception after PyDict_DelItem() in 
pysqlite_connection_create_collation_impl() is not cleared before calling 
_pysqlite_seterror() (and there is always an exception set if callable is 
None). Unlikely it can cause problems, but it is better to be explicit.

--
components: Extension Modules
messages: 386015
nosy: berker.peksag, ghaering, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Minor errors related to error handling in _sqlite3 module
versions: Python 3.10, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43083] Minor errors related to error handling in _sqlite3 module

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +23209
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/24395

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 42b1806af90b86ec393ca7da14e99ce95ec6c53b by Serhiy Storchaka in 
branch 'master':
bpo-43030: Fixed a compiler warning in Py_UNICODE_ISSPACE with signed wchar_t 
(GH-24350)
https://github.com/python/cpython/commit/42b1806af90b86ec393ca7da14e99ce95ec6c53b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 4.0 -> 5.0
pull_requests: +23210
pull_request: https://github.com/python/cpython/pull/24396

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

[miss-islington]

Change by miss-islington :


--
pull_requests: +23211
pull_request: https://github.com/python/cpython/pull/24397

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43080] pprint for dataclass instances

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

For all other classes we check that there is no user defined __repr__. But it 
is difficult to check this for dataclass or namedtuple because there is no base 
class for dataclasses or namedtuples which provides standard __repr__ 
implementation. All __repr__ for dataclasses and namedtuples are generated.

See issue7434.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43080] pprint for dataclass instances

[Eric V. Smith]

Eric V. Smith  added the comment:

Adding an attribute on the __repr__ (and other methods?) signifying that they 
were generated would let us distinguish them.

Say, checking getattr(__repr__, '__is_generated__', False), or similar.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

[miss-islington]

miss-islington  added the comment:


New changeset 995a6c015024f050b99ba8f9837dfc6b82d83f7d by Miss Islington (bot) 
in branch '3.9':
bpo-43030: Fixed a compiler warning in Py_UNICODE_ISSPACE with signed wchar_t 
(GH-24350)
https://github.com/python/cpython/commit/995a6c015024f050b99ba8f9837dfc6b82d83f7d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43080] pprint for dataclass instances

[Lewis Gaul]

Lewis Gaul  added the comment:

@Serhiy - Yes, I noted that problem in the PR. Thanks for pointing me to that 
issue, I agree it would be good to make pprint properly extensible (my current 
solution is to maintain a fork of the pprint module with dataclass support 
added).

Eric's suggestion would work, I wasn't sure if it would be considered an 'ok' 
thing to do, but if so then could be an easy enough way to support dataclasses 
(and namedtuples potentially)?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43084] curses.window.enclose() should return bool

[Serhiy Storchaka]

New submission from Serhiy Storchaka :

curses.window.enclose() is the only curses wrapper which returns 0/1 while the 
original function is declared returning bool. 
https://linux.die.net/man/3/wenclose

--
components: Extension Modules
messages: 386021
nosy: serhiy.storchaka
priority: normal
severity: normal
status: open
title: curses.window.enclose() should return bool
type: enhancement
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 229ef39bcc14ee7838968dfda51d045304e5cf39 by Miss Islington (bot) 
in branch '3.8':
bpo-43030: Fixed a compiler warning in Py_UNICODE_ISSPACE with signed wchar_t 
(GH-24350) (GH-24397)
https://github.com/python/cpython/commit/229ef39bcc14ee7838968dfda51d045304e5cf39


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43030] signed/unsigned mismatch in Py_UNICODE_ISSPACE macro

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
components: +C API -Extension Modules
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43080] pprint for dataclass instances

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Good idea Eric, it should work.

But it can make the code of pprint potentially less flexible. Currently it uses 
a mapping which maps __repr__ to corresponding pprint implementation. Only 
exception is for dicts, for historical reasons. It potentially can allow to 
make pprint more general and support arbitrary types by registering some 
handlers. Since there is no standard implementation of __repr__ for namedtuples 
and dataclasses we cannot use them as keys, and need to hardcode checks for 
namedtuple and dataclass (and any other generated classes).

It is a minor objection. Perhaps practicality should beat purity in this case.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43016] Improve tests for curses

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset d64fd4bb5bb4fd2e3277f39d3ad99b5a8d193e1b by Serhiy Storchaka in 
branch 'master':
bpo-43016: Rewrite tests for curses (GH-24312)
https://github.com/python/cpython/commit/d64fd4bb5bb4fd2e3277f39d3ad99b5a8d193e1b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43084] curses.window.enclose() should return bool

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +23212
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/24398

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43016] Improve tests for curses

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +23213
pull_request: https://github.com/python/cpython/pull/24399

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43083] Minor errors related to error handling in _sqlite3 module

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 3.0 -> 4.0
pull_requests: +23214
pull_request: https://github.com/python/cpython/pull/24400

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43083] Minor errors related to error handling in _sqlite3 module

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 9073180db521dc83e6216ff0da1479d00167f643 by Serhiy Storchaka in 
branch 'master':
bpo-43083: Fix error handling in _sqlite3 (GH-24395)
https://github.com/python/cpython/commit/9073180db521dc83e6216ff0da1479d00167f643


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43083] Minor errors related to error handling in _sqlite3 module

[miss-islington]

miss-islington  added the comment:


New changeset 8a833a6f94d8c2baa6aa38abd9fc699881a5b0e1 by Miss Islington (bot) 
in branch '3.9':
bpo-43083: Fix error handling in _sqlite3 (GH-24395)
https://github.com/python/cpython/commit/8a833a6f94d8c2baa6aa38abd9fc699881a5b0e1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43083] Minor errors related to error handling in _sqlite3 module

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43016] Improve tests for curses

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset e9d4960d15c5282904cf26e469ce7cee39f634f7 by Serhiy Storchaka in 
branch '3.9':
[3.9] bpo-43016: Rewrite tests for curses (GH-24312). (GH-24399)
https://github.com/python/cpython/commit/e9d4960d15c5282904cf26e469ce7cee39f634f7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43085] Loosening | and |= operator type checking restriction

[Siyavash]

New submission from Siyavash :

| and |= operators work only if the operands are of 'dict' type. This means 
that they can't be used with some of the user defined mapping objects.

The case that especially caught my attention was 'SignalDict' type in decimal 
standard library. While 'SignalDict' has got an update method like 'dict', it 
can not be updated with |= operator. The following code results in a TypeError:

decimal.getcontext().traps |= {decimal.DivisionByZero:False}

--
components: Regular Expressions
messages: 386028
nosy: Siy_V, brandtbucher, ezio.melotti, mrabarnett, steven.daprano
priority: normal
severity: normal
status: open
title: Loosening | and |= operator type checking restriction
type: enhancement
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43085] Loosening | and |= operator type checking restriction

[Siyavash]

Change by Siyavash :


--
nosy:  -Siy_V, ezio.melotti

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43016] Improve tests for curses

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +23215
pull_request: https://github.com/python/cpython/pull/24401

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43016] Improve tests for curses

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 7ca947e93bff2b9d78312dc8ed8e0a2b7d25d3f3 by Serhiy Storchaka in 
branch '3.8':
[3.8] bpo-43016: Rewrite tests for curses (GH-24312). (GH-24399) (GH-24401)
https://github.com/python/cpython/commit/7ca947e93bff2b9d78312dc8ed8e0a2b7d25d3f3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43016] Improve tests for curses

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12669] test_curses skipped on buildbots

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> out of date
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43085] Loosening | and |= operator type checking restriction

[Raymond Hettinger]

Raymond Hettinger  added the comment:

The operators | and |= always call __or__() and __ior__().  Support for these 
methods is optional.  Some mapping classes support both methods, some only 
support __or__, and some support neither one.

Adding support is done is done on a case by case basis.  SignalDict could be 
updated if needed.

To make it easier for user defined classes, two new collections.ABCs could be 
added, MappingWithOr and MutableMappingWithIor.  That is similar to what we had 
done in Python 2.7 with UserDict and IterableUserDict.

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41604] [curses.panel] Failed panel.set_userptr will decrement refcount of original userptr

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 3243e8a4b4b4cf321f9b28335d565742a34b1976 by Anonymous Maarten in 
branch 'master':
bpo-41604: Don't decrement the reference count of the previous user_ptr when 
set_panel_usertpr fails (GH-21933)
https://github.com/python/cpython/commit/3243e8a4b4b4cf321f9b28335d565742a34b1976


--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43086] Excess data in not handled properly in binascii.a2b_base64()

[Idan Moral]

New submission from Idan Moral :

Currently, when providing binascii.a2b_base64() base-64 input with excess data 
after the padding ('='/'=='), the excess data is ignored.

Example:

import binascii
binascii.a2b_base64(b'aGVsbG8=')   # b'hello' (valid)
binascii.a2b_base64(b'aGVsbG8==')  # b'hello' (ignoring data)
binascii.a2b_base64(b'aGVsbG8=python') # b'hello' (ignoring data)


Note: MANY libraries (such as the all-time favorite `base64`) use this function 
as their decoder.


Why is it problematic:
* User input can contain additional data after base64 data, which can lead to 
unintended behavior in products.
* Well-crafted user input can be used to bypass conditions in code (example in 
the referenced tweet).
* Can be used to target vulnerable libraries and bypass authentication 
mechanism such as JWT (potentially).


The logic behind my fix PR on GitHub:
* Before deciding to finish the function (after knowing the fact that we passed 
the data padding),
  we should check if there's no more data after the padding.
* If excess data exists, we should raise an error, free the allocated writer, 
and return null.
* Else, everything's fine, and we can proceed to the function's end as 
previously.


Though not publicly disclosed, this behavior can lead to security issues in 
heavily-used projects.
Preventing this behavior sounds more beneficial than harmful, since there's no 
known good usage for this behavior.

>From what I read, the python implementation in not so close (when speaking 
>about this case of course) to the base64 RFC.
(link: https://tools.ietf.org/html/rfc4648#section-3.3)


Thanks to Ori Damari (twitter: https://twitter.com/0xrepnz) for bringing this 
behavior up,
and thanks to Ryan Mast (twitter: https://twitter.com/rmast), and many of the 
other great guys for discussing the problem in the comments.

Link to the tweet: https://twitter.com/0xrepnz/status/1355295649915404291

--

Idan Moral
Twitter: https://twitter.com/idan_moral
GitHub: https://github.com/idan22moral

--
components: Library (Lib)
messages: 386032
nosy: idan22moral
priority: normal
severity: normal
status: open
title: Excess data in not handled properly in binascii.a2b_base64()
type: security
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43080] pprint for dataclass instances

[Raymond Hettinger]

Raymond Hettinger  added the comment:

At some point, we need a modern redesign alternative to pprint.  It could have 
its own __pprint__ method to communicate how it wants to be pretty printed.

Until then, I think the existing pprint module should only grow custom support 
for classes that have a mostly consistent structure and usage pattern.  
SimpleNamespace, for example, made sense for a custom pprint handler because it 
is so dict like and is almost never customized.

IMO, dataclasses are a bridge too far.  Having pprint() guess what a dataclass 
intends is not far from try to guess what an arbitrary class intends.  This is 
skating on thin ice.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43086] Excess data in not handled properly in binascii.a2b_base64()

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch
nosy: +python-dev
nosy_count: 1.0 -> 2.0
pull_requests: +23216
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/24402

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43080] pprint for dataclass instances

[Eric V. Smith]

Eric V. Smith  added the comment:

I agree that we need a better pprint. I think it would be easier to create 
something new rather than try and morph the existing pprint, but maybe I lack 
enough imagination. I'd prefer to use functools.singledispatch instead of a 
__pprint__ method, but it doesn't really make a lot of difference. PEP 443 
(singledispatch) does use pprint as a motivating example.

I tend to agree with Raymond that we don't want to guess what a dataclass class 
intends as its usage. After all, we deliberately made it easy to add a custom 
__repr__ (one not generated by dataclasses.dataclass).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43086] Excess data in not handled properly in binascii.a2b_base64()

[Eric V. Smith]

Change by Eric V. Smith :


--
nosy: +eric.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41604] [curses.panel] Failed panel.set_userptr will decrement refcount of original userptr

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +23218
pull_request: https://github.com/python/cpython/pull/24403

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27067] Improve curses tests

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Continued in issue42789 and issue43016.

--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43016] Improve tests for curses

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Failures on buildbots:
https://buildbot.python.org/all/#/builders/506/builds/765

==
ERROR: test_output_character (test.test_curses.TestCurses)
--
Traceback (most recent call last):
  File 
"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_curses.py", line 
249, in test_output_character
stdscr.addch('\u20ac')
OverflowError: byte doesn't fit in chtype
==
FAIL: test_background (test.test_curses.TestCurses)
--
Traceback (most recent call last):
  File 
"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_curses.py", line 
474, in test_background
self.assertEqual(win.getbkgd(), 0)
AssertionError: 32 != 0
--

--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43087] ctypes documentation error

[Mark Tolonen]

New submission from Mark Tolonen :

At the following documentation link:

https://docs.python.org/3/library/ctypes.html#incomplete-types

The last example should have byte strings:

>>> c1 = cell()
>>> c1.name = b"foo"
>>> c2 = cell()
>>> c2.name = b"bar"

--
messages: 386037
nosy: metolone
priority: normal
severity: normal
status: open
title: ctypes documentation error

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43087] ctypes documentation error

[Mark Tolonen]

Change by Mark Tolonen :


--
assignee:  -> docs@python
components: +Documentation, ctypes
nosy: +docs@python
versions: +Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43087] ctypes documentation error

[Zackery Spytz]

Change by Zackery Spytz :


--
keywords: +patch
nosy: +ZackerySpytz
nosy_count: 2.0 -> 3.0
pull_requests: +23219
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/24404

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43087] ctypes documentation error

[Zackery Spytz]

Zackery Spytz  added the comment:

Thank you for the report.

--
versions: +Python 3.10, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43016] Improve tests for curses

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +23220
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/24405

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41604] [curses.panel] Failed panel.set_userptr will decrement refcount of original userptr

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 3c8d6934436e20163be802f5239c5b4e4925eeec by Serhiy Storchaka in 
branch '3.9':
[3.9] bpo-41604: Don't decrement the reference count of the previous user_ptr 
when set_panel_usertpr fails (GH-21933). (GH-24403)
https://github.com/python/cpython/commit/3c8d6934436e20163be802f5239c5b4e4925eeec


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41604] [curses.panel] Failed panel.set_userptr will decrement refcount of original userptr

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 2.0 -> 3.0
pull_requests: +23221
pull_request: https://github.com/python/cpython/pull/24406

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24275] lookdict_* give up too soon

[Hristo Venev]

Hristo Venev  added the comment:

I've attached a patch that should also contain a test.

I also ran some benchmarks on dict creation/inserts. I couldn't notice any 
difference in performance.

--
Added file: 
https://bugs.python.org/file49782/0001-Don-t-downgrade-unicode-only-dicts-to-mixed-on-non-u.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41604] [curses.panel] Failed panel.set_userptr will decrement refcount of original userptr

[miss-islington]

miss-islington  added the comment:


New changeset 931263baab62b1c3fa7647e45ec6ee6ef4409e7c by Miss Islington (bot) 
in branch '3.8':
[3.9] bpo-41604: Don't decrement the reference count of the previous user_ptr 
when set_panel_usertpr fails (GH-21933). (GH-24403)
https://github.com/python/cpython/commit/931263baab62b1c3fa7647e45ec6ee6ef4409e7c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41604] [curses.panel] Failed panel.set_userptr will decrement refcount of original userptr

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43016] Improve tests for curses

[miss-islington]

Change by miss-islington :


--
pull_requests: +23223
pull_request: https://github.com/python/cpython/pull/24408

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43016] Improve tests for curses

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 2.0 -> 3.0
pull_requests: +23222
pull_request: https://github.com/python/cpython/pull/24407

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43016] Improve tests for curses

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset a1e9a1e120a11c563e166c15721169184c802f8b by Serhiy Storchaka in 
branch 'master':
bpo-43016: Fix test_curses on platform without cursesw (GH-24405)
https://github.com/python/cpython/commit/a1e9a1e120a11c563e166c15721169184c802f8b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43088] Regression in math.hypot

[Charles Karney]

New submission from Charles Karney :

It would be nice if math.hypot had the property

If
  0 < y1 < y2
then
  math.hypot(x, y1) <= math.hypot(x, y2)

This is not the case in python3 with

  x  = 0.6102683302836215
  y1 = 0.7906090004346522
  y2 = y1 + 1e-16

python2's implementation of math.hypot is OK with these inputs.

--
components: Library (Lib)
files: hypot_bug.py
messages: 386043
nosy: cffk
priority: normal
severity: normal
status: open
title: Regression in math.hypot
type: behavior
versions: Python 3.9
Added file: https://bugs.python.org/file49783/hypot_bug.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42986] pegen parser: Crash on SyntaxError with f-string on Windows

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 40901518167c66abc1ebc5b71c5b86d733cfa154 by Pablo Galindo in 
branch 'master':
bpo-42986: Fix parser crash when reporting syntax errors in f-string with 
newlines (GH-24279)
https://github.com/python/cpython/commit/40901518167c66abc1ebc5b71c5b86d733cfa154


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43017] Improve error message in the parser when using un-parenthesised tuples in comprehensions

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 835f14ff8eec10b3d96f821a1eb46a986e00c690 by Pablo Galindo in 
branch 'master':
bpo-43017: Improve error message for unparenthesised tuples in comprehensions 
(GH24314)
https://github.com/python/cpython/commit/835f14ff8eec10b3d96f821a1eb46a986e00c690


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43017] Improve error message in the parser when using un-parenthesised tuples in comprehensions

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42927] Inline cache for slots

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset a776da90b8f2a1342f4f9bfd23a62cea9a0497c6 by Pablo Galindo in 
branch 'master':
bpo-42927: Update the What's new entry for LOAD_ATTR optimizations (GH-24383)
https://github.com/python/cpython/commit/a776da90b8f2a1342f4f9bfd23a62cea9a0497c6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43088] Regression in math.hypot

[Raymond Hettinger]

Raymond Hettinger  added the comment:

Thanks for the report.  This is fixed in Python 3.10 where your script outputs: 
  [1.1102230246251565e-16, 1.1102230246251565e-16]

There isn't much that can be done about it for Python 3.9.

--
assignee:  -> rhettinger
nosy: +rhettinger
resolution:  -> out of date
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43088] Regression in math.hypot

[Tim Peters]

Tim Peters  added the comment:

I agree this doesn't occur in 3.10, but think Raymond pasted wrong outputs. 
Here:

Python 3.10.0a4+ (heads/master:64fc105b2d, Jan 28 2021, 15:31:11)
[MSC v.1928 64 bit (AMD64)] on win32
>>> x  = 0.6102683302836215
>>> y1 = 0.7906090004346522
>>> y2 = y1 + 1e-16
>>> from math import hypot
>>> hypot(x, y1)
0.998744224772008
>>> hypot(x, y2)
0.9987442247720081

Those both appear to be the results "as if" computed to infinite precision and 
then correctly rounded back to Python's float precision.

--
nosy: +tim.peters

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42986] pegen parser: Crash on SyntaxError with f-string on Windows

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43088] Regression in math.hypot

[Charles Karney]

Charles Karney  added the comment:

Many thanks!  Was the 3.9 version of hypot introduced in 3.0?  I'm fixing my 
code to call sqrt(x**2 + y**2) if necessary and I'd like to know what range of 
versions this version should apply for.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43088] Regression in math.hypot

[Raymond Hettinger]

Raymond Hettinger  added the comment:

>  I'd like to know what range of versions this version should apply for.

Only 3.8 and 3.9.

Prior to that, we used the C compiler's hypot() which tended to be very good 
but was implementation dependent, only covered the two argument case, and made 
no particular guarantees about accuracy, commutativity, or monotonicity.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31212] datetime: min date (0001-01-01 00:00:00) can't be converted to local timestamp

[Chris Jerdonek]

Change by Chris Jerdonek :


--
nosy: +chris.jerdonek

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24275] lookdict_* give up too soon

[Inada Naoki]

Change by Inada Naoki :


--
nosy: +methane

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43088] Regression in math.hypot

[Charles Karney]

Charles Karney  added the comment:

Thanks for the info.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43089] The optional argument to random.Random() is called "x" not "seed"

[Борис Верховский]

New submission from Борис Верховский :

The documentation https://docs.python.org/3/library/random.html#random.Random 
says:

> class random.Random([seed])¶

But in reality the parameter is called "x" not "seed" (CPython 3.9):

>>> import random
>>> random.Random(seed=0)
Traceback (most recent call last):
  File "", line 1, in 
TypeError: __init__() got an unexpected keyword argument 'seed'
>>> random.Random(x=0)


Same goes for random.SystemRandom

It would be better to rename "x" to "seed" but that's not backwards compatible.

--
components: Library (Lib)
messages: 386052
nosy: boris
priority: normal
pull_requests: 23224
severity: normal
status: open
title: The optional argument to random.Random() is called "x" not "seed"
type: enhancement
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

[Ned Deily]

Ned Deily  added the comment:


New changeset 49926cf2bcc8b44d9b8f148d81979ada191dd9d5 by Ronald Oussoren in 
branch 'master':
bpo-42504: Ensure that get_config_var('MACOSX_DEPLOYMENT_TARGET') is a string 
(GH-24341)
https://github.com/python/cpython/commit/49926cf2bcc8b44d9b8f148d81979ada191dd9d5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

[miss-islington]

Change by miss-islington :


--
pull_requests: +23225
pull_request: https://github.com/python/cpython/pull/24410

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42504] Failure to build with MACOSX_DEPLOYMENT_TARGET=11 on Big Sur

[Ned Deily]

Ned Deily  added the comment:


New changeset d6675fee1aac1af87dc31c411d04a5bfc1f39079 by Miss Islington (bot) 
in branch '3.9':
bpo-42504: Ensure that get_config_var('MACOSX_DEPLOYMENT_TARGET') is a string 
(GH-24341) (GH-24410)
https://github.com/python/cpython/commit/d6675fee1aac1af87dc31c411d04a5bfc1f39079


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43052] _dyld_shared_cache_contains_path needs SYSTEM_VERSION_COMPAT=0

[Ned Deily]

Ned Deily  added the comment:

> This can be observed by using the python 3.9.1 universal2 installer and using 
> it on
> x86_64 Big Sur or with Rossetta 2 on arm64 Big Sur.

When not manually setting SYSTEM_VERSION_COMPAT=1,  I cannot reproduce this 
behavior on current Big Sur (11.1) systems, either x86_64 or arm64 systems, 
either with the 3.9.1 python.org universal2 installer (which was built on Big 
Sur with deployment target of 10.9) or by building on 11.1 with 
MACOSX_DEPLOYMENT_TARGET=10.15:

$ ./configure MACOSX_DEPLOYMENT_TARGET=10.15
$ make
$ ./python -m sysconfig | grep DEPLOYMENT_TARGET
CONFIG_ARGS = "'MACOSX_DEPLOYMENT_TARGET=10.15'"
MACOSX_DEPLOYMENT_TARGET = "10.15"
$ ./python -c "from ctypes.util import find_library; 
print(find_library('AppKit'))"
/System/Library/Frameworks/AppKit.framework/AppKit
$ sw_vers
ProductName:macOS
ProductVersion: 11.1
BuildVersion:   20C69
$ uname -a
Darwin vana.local 20.2.0 Darwin Kernel Version 20.2.0: Wed Dec  2 20:39:59 PST 
2020; root:xnu-7195.60.75~1/RELEASE_X86_64 x86_64

===
$ arch
arm64
$ arch -arm64 /usr/local/bin/python3.9 -c 'import sys;print(sys.version)'
3.9.1 (v3.9.1:1e5d33e9b9, Dec  7 2020, 12:44:01)
[Clang 12.0.0 (clang-1200.0.32.27)]
$ arch -arm64 /usr/local/bin/python3.9 -c "from ctypes.util import 
find_library; print(find_library('AppKit'))"
/System/Library/Frameworks/AppKit.framework/AppKit
$ arch -x86_64 /usr/local/bin/python3.9 -c "from ctypes.util import 
find_library; print(find_library('AppKit'))"
/System/Library/Frameworks/AppKit.framework/AppKit

So, I believe that, while this is an issue when building Python on macOS 10.15 
and executing on macOS 11, it is not a problem for the current python.org 
universal2 installers. Am I missing something?

Further, I believe this issue is essentially a duplicate of Issue42619 which 
has a draft (work-in-progress) PR to address this in a different way.  We 
should consider consolidating these issues.

Note that legacy 10.9+ x86_64-only installers *will* see the find_library() 
failure because they are built on macOS 10.9. A fix for Issue42619 would solve 
that problem for future "legacy" installers built on 10.9 (although we intend 
to no longer produce such installers for Python 3.10.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42688] ctypes memory error on Apple Silicon with external libffi

[Ned Deily]

Ned Deily  added the comment:


New changeset 7e729978fa08a360cbf936dc215ba7dd25a06a08 by Miss Islington (bot) 
in branch '3.9':
bpo-42688: Fix ffi alloc/free when using external libffi on macos (GH-23868) 
(GH-23888)
https://github.com/python/cpython/commit/7e729978fa08a360cbf936dc215ba7dd25a06a08


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43052] _dyld_shared_cache_contains_path needs SYSTEM_VERSION_COMPAT=0

[Isuru Fernando]

Isuru Fernando  added the comment:

You are right. I think I may have accidentally used the wrong SDK. Explictly 
setting `SYSTEM_VERSION_COMPAT=1` is unsupported then?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43089] The optional argument to random.Random() is called "x" not "seed"

[శ్రీనివాస్ రెడ్డి తాటిపర్తి]

Srinivas  Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) 
 added the comment:

I think this was discussed before. If my memory serves me right, Guido kept 'x' 
as is for backward compatibility reasons. Agreed that was a mistake.

--
nosy: +thatiparthy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43016] Improve tests for curses

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 304f9d2622fa4fd0833d60d31ddf7321a6a8141b by Miss Islington (bot) 
in branch '3.9':
bpo-43016: Fix test_curses on platform without cursesw (GH-24405) (GH-24407)
https://github.com/python/cpython/commit/304f9d2622fa4fd0833d60d31ddf7321a6a8141b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43016] Improve tests for curses

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset aab84a58063e68cb7ff5f7b8d96c431200d0e340 by Miss Islington (bot) 
in branch '3.8':
bpo-43016: Fix test_curses on platform without cursesw (GH-24405) (GH-24408)
https://github.com/python/cpython/commit/aab84a58063e68cb7ff5f7b8d96c431200d0e340


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com