[issue11192] test_socket error on AIX

2018-09-13 Thread Michael Felt


Change by Michael Felt :


--
pull_requests: +8686

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34656] memory exhaustion in Modules/_pickle.c:1393

2018-09-13 Thread Karthikeyan Singaravelan


Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34605] Avoid master/slave terminology

2018-09-13 Thread Giampaolo Rodola'


Change by Giampaolo Rodola' :


--
nosy: +giampaolo.rodola

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34658] subprocess with preexec_fn when fork() fails could corrupt PyErr state

2018-09-13 Thread Gregory P. Smith


Change by Gregory P. Smith :


--
stage:  -> patch review
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34658] subprocess with preexec_fn when fork() fails could corrupt PyErr state

2018-09-13 Thread Gregory P. Smith


New submission from Gregory P. Smith :

Found in the stdlib test suite while testing the fix for bpo-6721: When 
subprocess is called with a preexec_fn and os.register_at_fork has been used 
and the fork() system call fails, the Python error state is set before the 
"after fork in parent process" function calls that were registered were called. 
 So they'd call back into Python code with a pending unreturned exception set.

boom.  SystemError (or assertion failure in pydebug builds).

--
assignee: gregory.p.smith
messages: 325238
nosy: gregory.p.smith
priority: normal
severity: normal
status: open
title: subprocess with preexec_fn when fork() fails could corrupt PyErr state
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34658] subprocess with preexec_fn when fork() fails could corrupt PyErr state

2018-09-13 Thread Gregory P. Smith


Change by Gregory P. Smith :


--
keywords: +patch
pull_requests: +8687

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34658] subprocess with preexec_fn when fork() fails could corrupt PyErr state

2018-09-13 Thread Gregory P. Smith


Change by Gregory P. Smith :


--
components: +Extension Modules

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34658] subprocess with preexec_fn when fork() fails could corrupt PyErr state

2018-09-13 Thread miss-islington


miss-islington  added the comment:


New changeset a20b6adb5a5880fd22c099961eb9f9787739cefe by Miss Islington (bot) 
(Gregory P. Smith) in branch 'master':
bpo-34658: Fix rare subprocess prexec_fn fork error. (GH-9255)
https://github.com/python/cpython/commit/a20b6adb5a5880fd22c099961eb9f9787739cefe


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34658] subprocess with preexec_fn when fork() fails could corrupt PyErr state

2018-09-13 Thread miss-islington


Change by miss-islington :


--
pull_requests: +8688

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34639] PYTHONCOERCECLOCALE is ignored when using -E or -I option

2018-09-13 Thread Nick Coghlan


Nick Coghlan  added the comment:

Respecting -E and -I isn't a problem per se - the problem is moving the 
_Py_CoerceLegacyLocale call to a point that's incredibly late in the startup 
process *just* to get it to respect those flags.

I don't actually mind if you reinstate the extra pass through the command line 
arguments just to check for -E and -I early enough for it to affect a properly 
located call to _Py_CoerceLegacyLocale, I just don't think it's necessary to do 
so.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34605] Avoid master/slave terminology

2018-09-13 Thread Gabriel Marko


Gabriel Marko  added the comment:

The discussion under GH PRs is now censored. What will be the next level?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34589] Py_Initialize() and Py_Main() should not enable C locale coercion

2018-09-13 Thread Nick Coghlan


Nick Coghlan  added the comment:

Reviewing the way things are now, I don't think it's worth rearranging this yet 
again for 3.7 - instead, I'll just put it back the way I intended it to be (and 
the way the PEP describes) for 3.8.

The issue is that Victor had good reasons for moving the handling of the 
"PYTHONCOERCECLOCALE=warn" case to be after the low level C stdio streams were 
properly initialised, and retaining that aspect of the changes while still 
moving the C locale coercion back to the beginning of the program means 
changing the signature of _Py_CoerceLegacyLocale to return a stateless static 
string to be printed to stderr later.

--
priority: release blocker -> normal
versions:  -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34659] Inconsistency between functools.reduce & itertools.accumulate

2018-09-13 Thread Azat Ishmukhametovich Ibrakov


New submission from Azat Ishmukhametovich Ibrakov :

Why there is an optional `initial` parameter for `functools.reduce` function, 
but there is no such for `itertools.accumulate`, when they both are doing kind 
of similar things except that `itertools.accumulate` yields intermediate 
results and `functools.reduce` only the final one?

--
components: Library (Lib)
messages: 325243
nosy: lycantropos
priority: normal
severity: normal
status: open
title: Inconsistency between functools.reduce & itertools.accumulate
type: enhancement
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34639] PYTHONCOERCECLOCALE is ignored when using -E or -I option

2018-09-13 Thread Nick Coghlan


Nick Coghlan  added the comment:

For the PYTHONCOERCECLOCALE=warn case, it turns out that my preferred approach 
to implementing bpo-34589 also naturally ends up respecting -I and -E for that 
(i.e. supplying -I or -E will suppressed the warning).

However, my upcoming PR for that also reinstates and expands on my original 
comment that explained why it was valuable to support "PYTHONCOERCECLOCALE=0 
python3 -E ..." and "PYTHONCOERCECLOCALE=0 python3 -I ...": so you can readily 
reproduce the way that locale coercion behaves on a platform *without* a 
suitable target locale (e.g. CentOS 7), even if your current platform actually 
does have such a locale available (e.g. Fedora).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34659] Inconsistency between functools.reduce & itertools.accumulate

2018-09-13 Thread R. David Murray


R. David Murray  added the comment:

Presumably because conceptually an 'initial value' would be like adding an 
additional element on to the front of the iterable being passed as an argument, 
and itertools is all about operating on iterables.  I'm not saying such an 
argument could not be added, but the API is cleaner without it.

--
nosy: +r.david.murray
versions: +Python 3.8 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34589] Py_Initialize() and Py_Main() should not enable C locale coercion

2018-09-13 Thread Nick Coghlan


Nick Coghlan  added the comment:

The actual functional error is that the following will currently give different 
outputs on Fedora and CentOS 7, whereas in the original PEP 538 implementation 
it would always print "C", even if locale coercion would otherwise normally 
work on your current platform:

LC_CTYPE=C PYTHONCOERCECLOCALE=0 python3 -E -c 'import os; 
print(os.env["LC_CTYPE"])'


As per the comment that was deleted in 
https://github.com/python/cpython/commit/9454060e84a669dde63824d9e2fcaf295e34f687#diff-8c018c3ada66d06c8e101e47a313c2c7,
 that was an intentional behaviour to allow developers testing scripts that are 
invoked using -E and -I to pretend that their local C.UTF-8 locale didn't exist 
when trying to reproducing behaviour otherwise seen only when locale coercion 
fails due to the lack of a suitable coercion target.

I'm working on an alternate PR that restores that aspect of the original 
behaviour, while preserving all the other improvements you made (such as 
ensuring that emitting the warning gets delayed until after the C level stderr 
is properly initialised)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34605] Avoid master/slave terminology

2018-09-13 Thread Mariatta Wijaya


Mariatta Wijaya  added the comment:

No further discussion needed. This issue has been closed and resolved. Thanks 
Victor for the PRs.

--
nosy: +Mariatta

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34587] test_socket: testCongestion() hangs on my Fedora 28

2018-09-13 Thread Nick Coghlan


Nick Coghlan  added the comment:

Same problem here. However, checking the test code, it seems that what's 
happening is that even though the sending socket has been put into non-blocking 
mode, self.cli.sendto in the _testCongestion helper method invoked by the 
ThreadableTest base class [1] has *not* thrown OSError, and hence the finally 
clause setting the event has *not* been triggered, and hence the test is 
hanging.

Neither socket.py nor test_socket.py have changed recently though, so it seems 
to me that this is either a recent Fedora bug (where the socket is blocking 
when it shouldn't), or else a Fedora change that has uncovered a latent defect 
in the socket module code.

[1] https://github.com/python/cpython/blob/master/Lib/test/test_socket.py#L228

--
nosy: +ncoghlan, petr.viktorin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34657] pyconfig.h macro "timezone" name clashes with user source are likely

2018-09-13 Thread Ned Deily


Change by Ned Deily :


--
components: +Windows -Build
nosy: +paul.moore, steve.dower, tim.golden, zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34657] pyconfig.h macro "timezone" name clashes with user source are likely

2018-09-13 Thread Zachary Ware


Zachary Ware  added the comment:

This is a duplicate of bpo-24643.

--
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> VS 2015 pyconfig.h #define timezone _timezone conflicts with 
timeb.h

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24643] VS 2015 pyconfig.h #define timezone _timezone conflicts with timeb.h

2018-09-13 Thread Zachary Ware


Zachary Ware  added the comment:

This was just reported again in bpo-34657.  We should go ahead and define 
_Py_timezone et al., which I will try to do today if nobody beats me to it :)

--
priority: normal -> high
versions: +Python 3.7, Python 3.8 -Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34597] Python needs to check existence of functions at runtime for targeting older macOS platforms

2018-09-13 Thread Ned Deily


Ned Deily  added the comment:

While, as Ronald notes, it would be nice to fully support weak linking so that 
building Python on macOS 10.n with a deployment target for 10.m where m < n so 
that an application with an embedded or bundled Python can run on 10.m through 
10.n systems, in the mean time there is a simple and safe alternative that has 
been used for years: build the Python on 10.m (or use a ready-built Python 
built on 10.m or lower).  That's what we do for the macOS Pythons provided by 
python.org installers, e.g. the installer variants that claim 10.9+ support are 
actually built on 10.9.  If you need an app bundle with an embedded Python, 
py2app can greatly simplify the process of constructing one.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7713] implement ability to disable automatic search path additions

2018-09-13 Thread Carol Willing


Carol Willing  added the comment:

Closing as the release has reached EOL.

--
nosy: +willingc
resolution:  -> out of date
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34585] Don't use AC_RUN_IFELSE to determine float endian

2018-09-13 Thread Ned Deily


Change by Ned Deily :


--
nosy: +mark.dickinson, tim.peters

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34583] os.stat() wrongfully returns False for symlink on Windows 10 v1803

2018-09-13 Thread Ned Deily


Change by Ned Deily :


--
components: +Windows -Library (Lib)
nosy: +paul.moore, steve.dower, tim.golden, zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34582] VSTS builds should use new YAML syntax and pools

2018-09-13 Thread Ned Deily


Change by Ned Deily :


--
nosy: +steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34597] Python needs to check existence of functions at runtime for targeting older macOS platforms

2018-09-13 Thread Zorg


Zorg  added the comment:

https://bugs.python.org/issue31359 has a better details about this issue.

I personally believe it's safer to link against a newer SDK and deal with the 
trouble of finding out what to strip out, which will be opted into implications 
or code paths that linking a binary against a newer SDK may provide.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24643] VS 2015 pyconfig.h #define timezone _timezone conflicts with timeb.h

2018-09-13 Thread Steve Dower


Steve Dower  added the comment:

I'd still rather put the redefinitions in our files that need it, and leave end 
users untouched.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34589] Py_Initialize() and Py_Main() should not enable C locale coercion

2018-09-13 Thread Nick Coghlan


Change by Nick Coghlan :


--
pull_requests: +8689

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34578] Pipenv lock : ModuleNotFoundError: No module named '_ctypes'

2018-09-13 Thread Ned Deily


Ned Deily  added the comment:

Since you are using pipenv and it is not part of the Python standard library, 
you should check the pipenv issue tracker and documentation and, if necessary, 
ask there:

https://github.com/pypa/pipenv/issues

--
nosy: +ned.deily
resolution:  -> third party
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34589] Py_Initialize() and Py_Main() should not enable C locale coercion

2018-09-13 Thread Nick Coghlan


Nick Coghlan  added the comment:

Alternate PR is up at https://github.com/python/cpython/pull/9257

There's one setting that remains in CoreConfig: "warn_on_c_locale", which 
_Py_UnixMain also uses to decide whether or not to actually emit the passed in 
locale coercion warning.

The coercion warning information itself moves out of CoreConfig, and into the 
private _PyMain helper struct.

The signature of _Py_CoerceLegacyLocale changed to both return an integer 
indicating whether or not coercion took place, as well as supporting two output 
variables that allow the display of the coercion warning message to be deferred 
(or skipped entirely).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31577] crash in os.utime() in case of a bad ns argument

2018-09-13 Thread Ned Deily


Ned Deily  added the comment:

Thanks, Serihy.  Can we either close this now or remove 3.7 and "release 
blocker"?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34603] ctypes on Windows: error calling C function that returns a struct containing 3 bools

2018-09-13 Thread Vladimir Matveev


Change by Vladimir Matveev :


--
keywords: +patch
pull_requests: +8690
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34597] Python needs to check existence of functions at runtime for targeting older macOS platforms

2018-09-13 Thread Ned Deily


Ned Deily  added the comment:

> https://bugs.python.org/issue31359 has a better details about this issue.

Yea, the approach there is again dealing with using a newer SDK to build for an 
older system.

> I personally believe it's safer to link against a newer SDK and deal with the 
> trouble of finding out what to strip out, which will be opted into 
> implications or code paths that linking a binary against a newer SDK may 
> provide.

Why do you believe that is safer?  Apple goes to great lengths to provide 
compatibility for existing applications to keep running on newer systems.  
That's not to say that eventually certain APIs are deprecated and removed but 
Python itself makes fairly minimal demands on macOS, i.e. it pretty much does 
not use anything other than basic libc-style system calls.  The one obvious 
disadvantage is that Python apps can't take advantage of newly introduced 
system calls (introduced after 10.m) when running on those newer systems.  I 
honestly don't recall any case dating back to 10.5 or so where there have been 
any reported problems with running a 10.m Python on a 10.n system (as best as I 
can recall!).  On the other hand, trying to support weak linking and backward 
compatibility requires more code and significant increase in ongoing testing.  
It would be a good thing to have but there is a significant cost and added risk 
to do so.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31577] crash in os.utime() in case of a bad ns argument

2018-09-13 Thread Zachary Ware


Zachary Ware  added the comment:

The crash is fixed, so I've lowered the priority.  Serhiy, are you still 
interested in pursuing an alternative fix in 3.8, or content with what's merged?

--
priority: release blocker -> normal
resolution:  -> fixed
stage: patch review -> commit review
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34653] PyParser_SimpleParseStringFilename should be deleted

2018-09-13 Thread Eric V. Smith


Change by Eric V. Smith :


--
keywords: +patch
pull_requests: +8691
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34660] Remove ableist terms and pejoratives from source code and docs

2018-09-13 Thread 25.45


New submission from 25.45 :

It has come to my attention that CPython's source code contains problematic 
ableist/saneist terms and/or pejoratives, namely

sanity check144
silly   26
insane  13
crazy   13
stupid  6
lame2
lunatic 1

Some of those slipped into the documentation. In an attempt to make Python 
community more inclusive and welcoming, we should clean up these usages and 
replace them with something neutral (where applicable). Unfortunately, to this 
day many developers deem such efforts as "trolling", so please note that the 
precedent has already been set by many major projects. Here're just a few:

https://github.com/unpkg/unpkg.com/pull/81
https://github.com/reduxjs/redux/pull/2335
https://github.com/rtfd/readthedocs.org/pull/3752
https://github.com/krzysztofzablocki/Sourcery/issues/2
https://github.com/google/xi-editor/pull/126

Other resources:

https://english.stackexchange.com/q/282282
http://isthisableism.tumblr.com/sluralternatives

The goal of this issue is not to stir up arguments, but to figure out the 
alternatives and ways to replace those problematic terms.

--
messages: 325260
nosy: 25.45
priority: normal
severity: normal
status: open
title: Remove ableist terms and pejoratives from source code and docs
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34659] Inconsistency between functools.reduce & itertools.accumulate

2018-09-13 Thread Raymond Hettinger


Change by Raymond Hettinger :


--
assignee:  -> rhettinger
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34653] PyParser_SimpleParseStringFilename should be deleted

2018-09-13 Thread miss-islington


miss-islington  added the comment:


New changeset 53c427e839d3e55d4791dca687a2d47534465a7a by Miss Islington (bot) 
(Eric V. Smith) in branch 'master':
bpo-34653: Removed unused function PyParser_SimpleParseStringFilename. (GH-9260)
https://github.com/python/cpython/commit/53c427e839d3e55d4791dca687a2d47534465a7a


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34480] _markupbase.py fails with UnboundLocalError on invalid keyword in marked section

2018-09-13 Thread Ezio Melotti


Change by Ezio Melotti :


--
assignee:  -> ezio.melotti

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1621] Do not assume signed integer overflow behavior

2018-09-13 Thread Benjamin Peterson


Change by Benjamin Peterson :


--
pull_requests: +8692

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1621] Do not assume signed integer overflow behavior

2018-09-13 Thread Benjamin Peterson


Change by Benjamin Peterson :


--
pull_requests: +8692, 8693

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34661] test_shutil fails with busybox unzip

2018-09-13 Thread Benjamin Peterson


New submission from Benjamin Peterson :

BusyBox has a unzip command, but it doesn't support -t.

==
FAIL: test_unzip_zipfile (test.test_shutil.TestShutil)
--
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-alpine/build/Lib/test/test_shutil.py", 
line 1181, in test_unzip_zipfile
subprocess.check_output(zip_cmd, stderr=subprocess.STDOUT)
subprocess.CalledProcessError: Command '['unzip', '-t', 
'/tmp/tmp92zs6lmt/archive.zip']' returned non-zero exit status 1.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-alpine/build/Lib/test/test_shutil.py", 
line 1185, in test_unzip_zipfile
self.fail(msg.format(exc, details))
AssertionError: Command '['unzip', '-t', '/tmp/tmp92zs6lmt/archive.zip']' 
returned non-zero exit status 1.
**Unzip Output**
unzip: unrecognized option: t
BusyBox v1.27.2 (2017-12-12 10:41:50 GMT) multi-call binary.
Usage: unzip [-lnopq] FILE[.zip] [FILE]... [-x FILE...] [-d DIR]
Extract FILEs from ZIP archive
-l  List contents (with -q for short form)
-n  Never overwrite files (default: ask)
-o  Overwrite
-p  Print to stdout
-q  Quiet
-x FILE Exclude FILEs
-d DIR  Extract into DIR

--
components: Tests
messages: 325262
nosy: benjamin.peterson
priority: normal
severity: normal
status: open
title: test_shutil fails with busybox unzip
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34661] test_shutil fails with busybox unzip

2018-09-13 Thread Benjamin Peterson


Change by Benjamin Peterson :


--
keywords: +patch
pull_requests: +8694
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29341] Missing accepting path-like object in docstrings of os module functions

2018-09-13 Thread Farhaan Bukhsh


Farhaan Bukhsh  added the comment:

Hey I would like to make this change which file should I look into?

--
nosy: +fhackdroid

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34661] test_shutil fails with busybox unzip

2018-09-13 Thread Benjamin Peterson


Benjamin Peterson  added the comment:


New changeset a710ebd21b09efe902dde84d4862ce5c6427f7af by Benjamin Peterson in 
branch 'master':
closes bpo-34661: Fix test_shutil if unzip doesn't support -t. (GH-9262)
https://github.com/python/cpython/commit/a710ebd21b09efe902dde84d4862ce5c6427f7af


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34661] test_shutil fails with busybox unzip

2018-09-13 Thread miss-islington


Change by miss-islington :


--
pull_requests: +8696

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34661] test_shutil fails with busybox unzip

2018-09-13 Thread miss-islington


Change by miss-islington :


--
pull_requests: +8695

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34658] subprocess with preexec_fn when fork() fails could corrupt PyErr state

2018-09-13 Thread miss-islington


miss-islington  added the comment:


New changeset b2ff9a9f9298761985aa85aa3f42421ce6effb9e by Miss Islington (bot) 
in branch '3.7':
bpo-34658: Fix rare subprocess prexec_fn fork error. (GH-9255)
https://github.com/python/cpython/commit/b2ff9a9f9298761985aa85aa3f42421ce6effb9e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17239] XML vulnerabilities in Python

2018-09-13 Thread Christian Heimes


Change by Christian Heimes :


--
pull_requests: +8697

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34662] tarfile.TarFile may write corrupt files if not closed

2018-09-13 Thread Daniel Pope


New submission from Daniel Pope :

A tarfile.TarFile object open for writing may silently write corrupt tar files 
if it is destroyed before being closed.

While explicitly calling close() or using the object as a context manager is 
recommended, I would not expect this in basic usage.

There are two steps needed for a TarFile to be closed properly:

* According to https://github.com/python/cpython/blob/3.7/Lib/tarfile.py#L1726, 
two zero blocks must be written (though GNU tar seems to work even if these are 
absent)
* The underlying fileobj (an io.BufferedWriter) must then be flushed

A BufferedWriter is flushed in its __del__(); the problem is that TarFile 
objects form a reference cycle with their TarInfo members due to this line, 
which has the comment "Not Needed": 
https://github.com/python/cpython/blob/3.7/Lib/tarfile.py#L1801

Under PEP-442, when the TarFile becomes unreferenced the following Cycle 
Isolate is formed:

TarInfo <=> TarFile -> BufferedWriter -> FileIO

Finalisers for these objects are run in an undefined order. If the FileIO 
finaliser is run before the BufferedWriter finaliser, then the fd is closed, 
buffered data in the BufferedWriter is not committed to disk, and the tar file 
is corrupt.

Additionally, while ResourceWarning is issued if the BufferedWriter or FileIO 
are left unclosed, no such warning is emitted by the TarFile.

--
components: Library (Lib)
messages: 325266
nosy: lordmauve
priority: normal
severity: normal
status: open
title: tarfile.TarFile may write corrupt files if not closed
type: behavior
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34661] test_shutil fails with busybox unzip

2018-09-13 Thread Benjamin Peterson


Change by Benjamin Peterson :


--
pull_requests: +8698

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34661] test_shutil fails with busybox unzip

2018-09-13 Thread miss-islington


miss-islington  added the comment:


New changeset 1550b7311216082748ddcdc048ee0374ce004513 by Miss Islington (bot) 
in branch '3.7':
closes bpo-34661: Fix test_shutil if unzip doesn't support -t. (GH-9262)
https://github.com/python/cpython/commit/1550b7311216082748ddcdc048ee0374ce004513


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34661] test_shutil fails with busybox unzip

2018-09-13 Thread miss-islington


miss-islington  added the comment:


New changeset 7eeb80b1e0034fd4e6b8d03b2c0fc5c94fe8d8fa by Miss Islington (bot) 
in branch '3.6':
closes bpo-34661: Fix test_shutil if unzip doesn't support -t. (GH-9262)
https://github.com/python/cpython/commit/7eeb80b1e0034fd4e6b8d03b2c0fc5c94fe8d8fa


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34662] tarfile.TarFile may write corrupt files if not closed

2018-09-13 Thread Daniel Pope


Daniel Pope  added the comment:

I have several suggestions for steps to address this:

1. Don't create reference cycles. TarInfo.tarfile does not appear to be a 
documented attribute 
(https://docs.python.org/3/library/tarfile.html#tarinfo-objects) and could 
perhaps be deleted.
2. Issue a ResourceWarning in TarFile.__del__() if the TarFile was not closed 
prior to finalisation. ResourceWarnings are ignored by default but this would 
help when debugging. Given that the file may be corrupted perhaps something 
more visible than a ResourceWarning is required.
3. Make TarFile.__del__() close the TarFile cleanly. This is only possible if 
we can guarantee the underlying fileobj is finalized later (eg. because we have 
eliminated the reference cycle).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34661] test_shutil fails with busybox unzip

2018-09-13 Thread Benjamin Peterson


Change by Benjamin Peterson :


--
pull_requests: +8699

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20047] bytearray partition bug

2018-09-13 Thread Zackery Spytz


Change by Zackery Spytz :


--
pull_requests: +8700

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34661] test_shutil fails with busybox unzip

2018-09-13 Thread miss-islington


Change by miss-islington :


--
pull_requests: +8702

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34661] test_shutil fails with busybox unzip

2018-09-13 Thread miss-islington


Change by miss-islington :


--
pull_requests: +8701

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34661] test_shutil fails with busybox unzip

2018-09-13 Thread Benjamin Peterson


Benjamin Peterson  added the comment:


New changeset e78734d579439861f6d7e12f35d268836b2c1e24 by Benjamin Peterson in 
branch 'master':
bpo-34661: Fix test skipping call. (GH-9266)
https://github.com/python/cpython/commit/e78734d579439861f6d7e12f35d268836b2c1e24


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33239] tempfile module: functions with the 'buffering' option are incorrectly documented

2018-09-13 Thread Antti Haapala


Antti Haapala  added the comment:

This week we were bit by this in production. I foolishly thought that the  docs 
would give me correct default values... It is worse that it didn't actually 
occur until we went over the limit.

--
nosy: +ztane

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34663] Support POSIX_SPAWN_USEVFORK flag in posix_spawn

2018-09-13 Thread Pablo Galindo Salgado


New submission from Pablo Galindo Salgado :

In some systems, posix_spawn has an optional flag (POSIX_SPAWN_USEVFORK) that 
is GNU specific and allows the user to force posix_spawn to spawn the child 
using vfork instead of fork. This is very beneficial as it gives great speedups 
compare with normal fork+execv.

--
components: Extension Modules
messages: 325272
nosy: pablogsal
priority: normal
severity: normal
status: open
title: Support POSIX_SPAWN_USEVFORK flag in posix_spawn
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34663] Support POSIX_SPAWN_USEVFORK flag in posix_spawn

2018-09-13 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
keywords: +patch
pull_requests: +8703
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33649] asyncio docs overhaul

2018-09-13 Thread Carol Willing


Change by Carol Willing :


--
pull_requests: +8704

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34664] test.test_os.MakedirTests.test_mode is too strict

2018-09-13 Thread Benjamin Peterson


New submission from Benjamin Peterson :

If TESTFN is in a directory with S_ISGID set in its mode, test_os will fail:

==
FAIL: test_mode (test.test_os.MakedirTests)
--
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-alpine/build/Lib/test/test_os.py", line 
1134, in test_mode
self.assertEqual(stat.S_IMODE(os.stat(path).st_mode), 0o555)
AssertionError: 1389 != 365

The problem is we're checking the entire file mode when we should just be 
checking the permission bits.

--
components: Tests
messages: 325273
nosy: benjamin.peterson
priority: normal
severity: normal
status: open
title: test.test_os.MakedirTests.test_mode is too strict
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34661] test_shutil fails with busybox unzip

2018-09-13 Thread Benjamin Peterson


Benjamin Peterson  added the comment:


New changeset 18e21883a4ec2a36a02054eb2ff47e3ba9bd1d33 by Benjamin Peterson in 
branch '2.7':
[2.7] closes bpo-34661: Fix test_shutil if unzip doesn't support -t. (GH-9267)
https://github.com/python/cpython/commit/18e21883a4ec2a36a02054eb2ff47e3ba9bd1d33


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34664] test.test_os.MakedirTests.test_mode is too strict

2018-09-13 Thread Benjamin Peterson


Change by Benjamin Peterson :


--
keywords: +patch
pull_requests: +8705
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34665] Py_FinalizeEx() - Bugs & caveats - Add info that NumPy and Pandas don't support reinitialization

2018-09-13 Thread Johannes M.


New submission from Johannes M. :

Since about a decade, it's a know problem that NumPy and Pandas initialization 
function crashes on reinitialization after a call to Py_Finalize() + 
Py_Initialize().

[https://github.com/numpy/numpy/issues/8097]
[https://github.com/numpy/numpy/issues/11925]

It seems to be unlikely that this problem gets fixed soon. Due to the 
popularity of the modules, it would be good to add this information to the 
documentation of Py_FinalizeEx(), such that developers, who are planning to 
embed Python get this information already at the moment when they read the 
documentation.

I would suggest to change the following sentence:

Some extensions may not work properly if their
initialization routine is called more than once;

to

Some extensions, like NumPy and Pandas, may not work properly if their
initialization routine is called more than once;

--
assignee: docs@python
components: Documentation
messages: 325275
nosy: docs@python, jcmuel
priority: normal
severity: normal
status: open
title: Py_FinalizeEx() - Bugs & caveats - Add info that NumPy and Pandas don't 
support reinitialization
type: enhancement
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34639] PYTHONCOERCECLOCALE is ignored when using -E or -I option

2018-09-13 Thread STINNER Victor


STINNER Victor  added the comment:

> Respecting -E and -I isn't a problem per se - the problem is moving the 
> _Py_CoerceLegacyLocale call to a point that's incredibly late in the startup 
> process *just* to get it to respect those flags.

Would you mind to elaborate how it is an issue? The LC_CTYPE is coerced 
*before* the configuration is read a second time. If there is an issue, would 
you mind to show an example where something is decoded from the wrong encoding?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34661] test_shutil fails with busybox unzip

2018-09-13 Thread miss-islington


miss-islington  added the comment:


New changeset 218b4bf47410ff8ab46b68461267fe10db18aee1 by Miss Islington (bot) 
in branch '3.7':
bpo-34661: Fix test skipping call. (GH-9266)
https://github.com/python/cpython/commit/218b4bf47410ff8ab46b68461267fe10db18aee1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34286] lib2to3 tests fail on the 3.7 branch (used to work with 3.7.0)

2018-09-13 Thread Ned Deily


Ned Deily  added the comment:

I can't reproduce this either using a current top of 3.7 branch and installed 
on macOS; I also tried building 3.7 just prior to the fix for Issue21446 that 
Brett mentioned; the test also did not fail.  Let's close this until it can be 
reproduced outside of doko's environment.

--
nosy: +ned.deily
resolution:  -> works for me
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24643] VS 2015 pyconfig.h #define timezone _timezone conflicts with timeb.h

2018-09-13 Thread STINNER Victor


Change by STINNER Victor :


--
nosy:  -vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34666] Implement async write and async close in asyncio StreamWriter

2018-09-13 Thread Andrew Svetlov


New submission from Andrew Svetlov :

Methods are needed for providing consistent stream API with control flow 
switched on by default.

--
components: asyncio
messages: 325279
nosy: asvetlov, yselivanov
priority: normal
severity: normal
status: open
title: Implement async write and async close in asyncio StreamWriter
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34661] test_shutil fails with busybox unzip

2018-09-13 Thread miss-islington


miss-islington  added the comment:


New changeset 81361cdff847f14f6258c0ead17817d6f9e04022 by Miss Islington (bot) 
in branch '3.6':
bpo-34661: Fix test skipping call. (GH-9266)
https://github.com/python/cpython/commit/81361cdff847f14f6258c0ead17817d6f9e04022


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34666] Implement async write and async close in asyncio StreamWriter

2018-09-13 Thread Andrew Svetlov


Change by Andrew Svetlov :


--
keywords: +patch
pull_requests: +8706
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34247] PYTHONOPTIMIZE ignored in 3.7.0 when using custom launcher

2018-09-13 Thread Ned Deily


Ned Deily  added the comment:


New changeset 66755cbb1e529f54c9066639ebbbac81add0affd by Ned Deily in branch 
'master':
bpo-34247: add porting note to 3.7 What's New (GH-9223)
https://github.com/python/cpython/commit/66755cbb1e529f54c9066639ebbbac81add0affd


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34247] PYTHONOPTIMIZE ignored in 3.7.0 when using custom launcher

2018-09-13 Thread miss-islington


Change by miss-islington :


--
pull_requests: +8707

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34589] Py_Initialize() and Py_Main() should not enable C locale coercion

2018-09-13 Thread STINNER Victor


STINNER Victor  added the comment:

> LC_CTYPE=C PYTHONCOERCECLOCALE=0 python3 -E ...

The UTF-8 Mode has the same behavior: PYTHONUTF8 env var is ignored when using 
-E, but enabled by the C locale: you can use -X utf8=0 in that case to ensure 
that the UTF-8 Mode is disabled.

I wanted to propose you to add a new -X option, ex: -X coerce_c_locale=0, which 
would have the priority over the environment variable. I'm not a big fan of env 
vars, it's not always convenient to use them. I prefer an env var, but both are 
even better :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34247] PYTHONOPTIMIZE ignored in 3.7.0 when using custom launcher

2018-09-13 Thread STINNER Victor


STINNER Victor  added the comment:

> (in earlier Python versions, it respected an ill-defined subset of those 
> environment variables, ...)

I'm not aware of the Python 3.6 issue ("ill-defined"): which env vars were not 
properly handled?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1621] Do not assume signed integer overflow behavior

2018-09-13 Thread STINNER Victor


STINNER Victor  added the comment:

Benjamin: what do you think of adding an explicit check after the "new_size <<= 
1;" loop?

if (new_size > (size_t)PY_SSIZE_T_MAX) {
PyErr_NoMemory();
return -1;
}

Technically, PyMem_Malloc() already implements the check, so it's not really 
needed. So I'm not sure if it's needed :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34587] test_socket: testCongestion() hangs on my Fedora 28

2018-09-13 Thread STINNER Victor


Change by STINNER Victor :


--
keywords: +patch
pull_requests: +8708
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34664] test.test_os.MakedirTests.test_mode is too strict

2018-09-13 Thread miss-islington


Change by miss-islington :


--
pull_requests: +8709

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34664] test.test_os.MakedirTests.test_mode is too strict

2018-09-13 Thread Benjamin Peterson


Benjamin Peterson  added the comment:


New changeset 84db4a9978069a98978e9cd7951d1a01d47e5286 by Benjamin Peterson in 
branch 'master':
closes bpo-34664: Only check file permission bits of newly created directories. 
(GH-9273)
https://github.com/python/cpython/commit/84db4a9978069a98978e9cd7951d1a01d47e5286


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34587] test_socket: testCongestion() hangs on my Fedora 28

2018-09-13 Thread STINNER Victor


STINNER Victor  added the comment:

I proposed PR 9277 to remove the test: see the PR for the rationale.

> Neither socket.py nor test_socket.py have changed recently though, so it 
> seems to me that this is either a recent Fedora bug (where the socket is 
> blocking when it shouldn't), or else a Fedora change that has uncovered a 
> latent defect in the socket module code.

IMHO it's a change in the implementation of the RDS protocol in Linux, likely 
in the kernel.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34663] Support POSIX_SPAWN_USEVFORK flag in posix_spawn

2018-09-13 Thread STINNER Victor


STINNER Victor  added the comment:

I suggest to name the parameter "use_vfork", or maybe even "vfork".

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34247] PYTHONOPTIMIZE ignored in 3.7.0 when using custom launcher

2018-09-13 Thread miss-islington


miss-islington  added the comment:


New changeset 305056494d7e1debec3df268b8925725b0110293 by Miss Islington (bot) 
in branch '3.7':
bpo-34247: add porting note to 3.7 What's New (GH-9223)
https://github.com/python/cpython/commit/305056494d7e1debec3df268b8925725b0110293


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34247] PYTHONOPTIMIZE ignored in 3.7.0 when using custom launcher

2018-09-13 Thread Ned Deily


Ned Deily  added the comment:

I've merged Nick's suggested porting note so I'm going to remove the "release 
blocker" status.  Can we also close this now?

--
priority: release blocker -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34651] Disallow fork in a subinterpreter.

2018-09-13 Thread Eric Snow


Change by Eric Snow :


--
keywords: +patch
pull_requests: +8710
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34664] test.test_os.MakedirTests.test_mode is too strict

2018-09-13 Thread miss-islington


miss-islington  added the comment:


New changeset b2a6aa32f34b6d77c15f175a9df7271a05519bf9 by Miss Islington (bot) 
in branch '3.7':
closes bpo-34664: Only check file permission bits of newly created directories. 
(GH-9273)
https://github.com/python/cpython/commit/b2a6aa32f34b6d77c15f175a9df7271a05519bf9


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34660] Remove ableist terms and pejoratives from source code and docs

2018-09-13 Thread Carol Willing


Carol Willing  added the comment:

Thank you for filing an issue. I will be carefully reviewing the Python 
documentation section by section over the next several months. I will open 
individual issues as I go through each section as well as pull requests as I 
thoughtfully review each section.

I'm closing this issue but will be opening individual issues by documentation 
section as time permits my review.

--
assignee:  -> willingc
components: +Documentation
nosy: +willingc
resolution:  -> remind
stage:  -> resolved
status: open -> closed
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34668] test_resource fails if test has CAP_SYS_RESOURCE but isn't root

2018-09-13 Thread Benjamin Peterson


New submission from Benjamin Peterson :

test_prlimit tries to test that raising the hardlimit of an unprivileged 
process. It tries to raise the hardlimit of pid 1, which usually raises a 
PermissionError. However, if the tests are privileged, this test can't work. 
The test tries to avoid this by only running the test if os.geteuid() != 0. 
However, there are other cases. For example, if the test process isn't root but 
has CAP_SYS_RESOURCE. While we could check for these other cases, I think we 
should just delete this test. There's no special logic in the prlimit 
implementation for handling permission errors, so it's not adding much value.

==
FAIL: test_prlimit (test.test_resource.ResourceTest)
--
Traceback (most recent call last):
  File 
"/buildbot/buildarea/3.x.ware-alpine/build/Lib/test/support/__init__.py", line 
587, in wrapper
return func(*args, **kw)
  File "/buildbot/buildarea/3.x.ware-alpine/build/Lib/test/test_resource.py", 
line 152, in test_prlimit
1, resource.RLIMIT_AS)
AssertionError: PermissionError not raised by prlimit

--
components: Tests
messages: 325293
nosy: benjamin.peterson
priority: normal
severity: normal
status: open
title: test_resource fails if test has CAP_SYS_RESOURCE but isn't root
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34667] Review documentation section by section

2018-09-13 Thread Carol Willing


New submission from Carol Willing :

This issue is a placeholder for a comprehensive documentation review by content 
sections. I will develop a more detailed workplan in the coming weeks.

--
assignee: willingc
messages: 325292
nosy: willingc
priority: normal
severity: normal
status: open
title: Review documentation section by section
type: enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34668] test_resource fails if test has CAP_SYS_RESOURCE but isn't root

2018-09-13 Thread Benjamin Peterson


Change by Benjamin Peterson :


--
keywords: +patch
pull_requests: +8711
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34582] VSTS builds should use new YAML syntax and pools

2018-09-13 Thread Steve Dower


New submission from Steve Dower :

Thanks, David!

I'm partway through most of these changes (as well as some other improvements) 
in my PR at https://github.com/python/cpython/pull/9210/files, so if it's all 
the same to you, I'll make sure I've covered everything you've done here and 
then close yours. Sound good?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34663] Support POSIX_SPAWN_USEVFORK flag in posix_spawn

2018-09-13 Thread STINNER Victor


STINNER Victor  added the comment:

We discussed with Gregory P. Smith, and we agreed on the "use_vfork=True" name. 
He is a native english speaker, so I rely on him :-) Moreover, "use_vfork" is 
closer to POSIX_SPAWN_USEVFORK constant than "vfork".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34668] test_resource fails if test has CAP_SYS_RESOURCE but isn't root

2018-09-13 Thread Petr Viktorin


Petr Viktorin  added the comment:

Check also discussion on issue31132.
If you agree, I'm OK with marking that one as duplicate, and removing the test.

--
nosy: +petr.viktorin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34668] test_resource fails if test has CAP_SYS_RESOURCE but isn't root

2018-09-13 Thread Petr Viktorin


Change by Petr Viktorin :


--
resolution:  -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder:  -> test_prlimit from test_resource fails when building python3 
inside systemd-nspawn environment

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31132] test_prlimit from test_resource fails when building python3 inside systemd-nspawn environment

2018-09-13 Thread Benjamin Peterson


Change by Benjamin Peterson :


--
keywords: +patch
pull_requests: +8712
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34662] tarfile.TarFile may write corrupt files if not closed

2018-09-13 Thread Ned Deily


Change by Ned Deily :


--
nosy: +lars.gustaebel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31132] test_prlimit from test_resource fails when building python3 inside systemd-nspawn environment

2018-09-13 Thread miss-islington


Change by miss-islington :


--
pull_requests: +8713

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   >