[issue34280] METH_NOARGS: no longer require that second arg is NULL

2018-07-31 Thread Jeroen Demeyer


Jeroen Demeyer  added the comment:

OK, I closed this without applying the change. It means one extra special case 
in PEP 580, but it's not a big deal.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34287] bufferedio.c uses unused argument of METH_NOARGS functions

2018-07-31 Thread Jeroen Demeyer


New submission from Jeroen Demeyer :

A METH_NOARGS function has a second unused argument which is always NULL (this 
is guaranteed by the documentation).

However, some functions in Modules/_io/bufferedio.c actually that second NULL 
argument. This is technically not a bug, but it looks more clear to explicitly 
mark that second argument as unused.

--
components: Extension Modules
messages: 322736
nosy: jdemeyer, rhettinger, scoder
priority: normal
severity: normal
status: open
title: bufferedio.c uses unused argument of METH_NOARGS functions
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34287] bufferedio.c uses unused argument of METH_NOARGS functions

2018-07-31 Thread Jeroen Demeyer


Change by Jeroen Demeyer :


--
keywords: +patch
pull_requests: +8091
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34276] urllib.parse doesn't round-trip file URI's with multiple leading slashes

2018-07-31 Thread Chris Jerdonek


Chris Jerdonek  added the comment:

> The RFC treats empty authority and no authority as different cases.

I'm not well-versed on this. But I guess this means urllib.parse doesn't 
support this distinction. For example:

  >>> urllib.parse.urlsplit('file:/foo')
  SplitResult(scheme='file', netloc='', path='/foo', query='', fragment='')
  >>> urllib.parse.urlsplit('file:///foo')
  SplitResult(scheme='file', netloc='', path='/foo', query='', fragment='')
  >>> urllib.parse.urlsplit('file:/foo') == \
  urllib.parse.urlsplit('file:///foo')
  True

Both have authority / netloc equal to the empty string, even though in the 
first example the authority isn't present per your comment.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33729] Hashlib/blake2* missing 'data' keyword argument

2018-07-31 Thread Serhiy Storchaka


Serhiy Storchaka  added the comment:


New changeset 47957dab94a4efa2fee61c9a8193f78300950769 by Serhiy Storchaka in 
branch '3.7':
[3.7] bpo-33729: Fix issues with arguments parsing in hashlib. (GH-8346) 
(GH-8581)
https://github.com/python/cpython/commit/47957dab94a4efa2fee61c9a8193f78300950769


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33871] Possible integer overflow in iov_setup()

2018-07-31 Thread Serhiy Storchaka


Serhiy Storchaka  added the comment:


New changeset 9d5727326af53ddd91016d98e16ae7cf829caa95 by Serhiy Storchaka in 
branch 'master':
bpo-33871: Fix os.sendfile(), os.writev(), os.readv(), etc. (GH-7931)
https://github.com/python/cpython/commit/9d5727326af53ddd91016d98e16ae7cf829caa95


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33871] Possible integer overflow in iov_setup()

2018-07-31 Thread miss-islington


Change by miss-islington :


--
pull_requests: +8092

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33729] Hashlib/blake2* missing 'data' keyword argument

2018-07-31 Thread Christian Heimes


Christian Heimes  added the comment:

Your PR changed way to many aspects of the code in one commit. I also don't 
like the fact, that you pushed such a big change without waiting for my 
feedback. For the past two weeks I have been travelling to conferences and had 
no time to review your PR. There was no need to rush it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33729] Hashlib/blake2* missing 'data' keyword argument

2018-07-31 Thread Christian Heimes


Christian Heimes  added the comment:

The backport to 3.6 and 3.7 are breaking backwards compatibility and 
compatibility with PEP 247.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34288] Declare sethostname in socketmodule.c for SOLARIS

2018-07-31 Thread Roy Belio


New submission from Roy Belio :

Following issue 18259 which was solved by extern sethostname I managed to build 
python 3.7 on solaris only after patching away the ifdef for _AIX.
We need to add SOLARIS flag and check for that also in the same line of 
#ifdef _AIX.

This error only appears in 3.7 since a new CFLAG was turned on 
-Werror=no-implicit-declaration. and during build time it fails on sethostname 
function, not build _socket.

--
components: Build
messages: 322742
nosy: rbelio
priority: normal
severity: normal
status: open
title: Declare sethostname in socketmodule.c for SOLARIS
type: compile error
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27671] FAQ: len() is still function for good reason.

2018-07-31 Thread INADA Naoki


Change by INADA Naoki :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33871] Possible integer overflow in iov_setup()

2018-07-31 Thread Serhiy Storchaka


Change by Serhiy Storchaka :


--
pull_requests: +8093

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33089] Add multi-dimensional Euclidean distance function to the math module

2018-07-31 Thread Raymond Hettinger


Raymond Hettinger  added the comment:


New changeset 9c18b1ae527346bc178250ad1ca07bffdacde5dd by Raymond Hettinger in 
branch 'master':
bpo-33089: Add math.dist() for computing the Euclidean distance between two 
points (GH-8561)
https://github.com/python/cpython/commit/9c18b1ae527346bc178250ad1ca07bffdacde5dd


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34276] urllib.parse doesn't round-trip file URI's with multiple leading slashes

2018-07-31 Thread Piotr Dobrogost


Change by Piotr Dobrogost :


--
nosy: +piotr.dobrogost

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33089] Add multi-dimensional Euclidean distance function to the math module

2018-07-31 Thread Raymond Hettinger


Change by Raymond Hettinger :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33729] Hashlib/blake2* missing 'data' keyword argument

2018-07-31 Thread Serhiy Storchaka


Serhiy Storchaka  added the comment:

Sorry. Do you prefer to revert the whole changes or just some parts?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34284] Nonsensical exception message when calling `__new__` on non-instaniable objects

2018-07-31 Thread Vadim Pushtaev


Vadim Pushtaev  added the comment:

> See also issue31506

Okay, I admit, reporting `tuple.__new__` instead of `sys.flags` is misleading.

But what about this?

> `tuple.__new__(NamedTuple)` works, and produces a namedtuple object, so 
> tuple.__new__ is what the error should point to.

Isn't it the same? Why should we say anything about `tuple` if a user wants A? 
This looks similar to 31506:

>>> from collections import namedtuple
>>> class A(namedtuple('x', 'x')):
... pass
...
>>> A.__new__(1, 2)
Traceback (most recent call last):
  File "", line 1, in 
  File "", line 1, in __new__
TypeError: tuple.__new__(X): X is not a type object (int)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14266] pyunit script as shorthand for python -m unittest

2018-07-31 Thread Michael Foord


Change by Michael Foord :


--
resolution:  -> rejected

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14266] pyunit script as shorthand for python -m unittest

2018-07-31 Thread Berker Peksag


Change by Berker Peksag :


--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33871] Possible integer overflow in iov_setup()

2018-07-31 Thread miss-islington


miss-islington  added the comment:


New changeset 3e4b68875917a4605b45918f9e3232730fed9399 by Miss Islington (bot) 
in branch '3.7':
bpo-33871: Fix os.sendfile(), os.writev(), os.readv(), etc. (GH-7931)
https://github.com/python/cpython/commit/3e4b68875917a4605b45918f9e3232730fed9399


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29259] Add tp_fastcall to PyTypeObject: support FASTCALL calling convention for all callable objects

2018-07-31 Thread Jeroen Demeyer


Jeroen Demeyer  added the comment:

> For compatibility with extensions built with older Pythons you should define 
> new type flag and read tp_fastcall only if the flag is set.

Can you comment on https://github.com/python/cpython/pull/4944 why you think 
that such compatibility should be guaranteed? According to PEP 384, the layout 
of PyTypeObject is not part of the stable ABI.

--
nosy: +jdemeyer

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34289] System can't find the path of Python

2018-07-31 Thread Aleksa Bulatovic


New submission from Aleksa Bulatovic :

Before you say,yes,i have python path but the system can't find it.Is it 
because of the installation folder (because i didn't install in the default 
location) or maybe other?

--
components: Windows
messages: 322748
nosy: Cross!Alex21, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: System can't find the path of Python
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33871] Possible integer overflow in iov_setup()

2018-07-31 Thread Serhiy Storchaka


Serhiy Storchaka  added the comment:


New changeset ada5d99306dc8af21c32cefb3d86891e8553dbc6 by Serhiy Storchaka in 
branch '3.6':
[3.6] bpo-33871: Fix os.sendfile(), os.writev(), os.readv(), etc. (GH-7931) 
(GH-8584)
https://github.com/python/cpython/commit/ada5d99306dc8af21c32cefb3d86891e8553dbc6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33083] math.factorial accepts non-integral Decimal instances

2018-07-31 Thread STINNER Victor


STINNER Victor  added the comment:

I looked at Pablo's PR 6149 and I'm surprised by the size of the code just to 
convert a Python object to a C long!
---
if (PyFloat_Check(arg)) {
PyObject *lx;
double dx = PyFloat_AS_DOUBLE((PyFloatObject *)arg);
if (!(Py_IS_FINITE(dx) && dx == floor(dx))) {
PyErr_SetString(PyExc_ValueError,
"factorial() only accepts integral values");
return NULL;
}
lx = PyLong_FromDouble(dx);
if (lx == NULL)
return NULL;
x = PyLong_AsLongAndOverflow(lx, &overflow);
Py_DECREF(lx);
}
else {
pyint_form = PyNumber_Index(arg);
if (pyint_form == NULL) {
return NULL;
}
x = PyLong_AsLongAndOverflow(pyint_form, &overflow);
Py_DECREF(pyint_form);
}

if (x == -1 && PyErr_Occurred()) {
return NULL;
}
else if (overflow == 1) {
PyErr_Format(PyExc_OverflowError,
 "factorial() argument should not exceed %ld",
 LONG_MAX);
return NULL;
}
else if (overflow == -1 || x < 0) {
PyErr_SetString(PyExc_ValueError,
"factorial() not defined for negative values");
return NULL;
}
---
Do we really need 37 lines of C code? Is it really important to accept integral 
float? What's wrong with factorial(int(d)) for example?

PR 6149 LGTM, but since I was not involved in the discussion, I would prefer if 
someone else who has been involved would approve the change: Tal already 
approved it, but I saw some complains, I'm not 100% sure that we reached a full 
agreement.

Note: Pablo is a core developer and so he can merge his PR, I'm only asking to 
*approve* the change, not to merge it ;-)

Thanks in advance.

Note2: I'm still mentoring Pablo after he became a core, and I require him to 
ask me before merging any change.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34289] System can't find the path of Python

2018-07-31 Thread Stéphane Wirtel

Stéphane Wirtel  added the comment:

and about $PATH?

--
nosy: +matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34289] System can't find the path of Python

2018-07-31 Thread Aleksa Bulatovic


Aleksa Bulatovic  added the comment:

No,when i type 'cd Python37',the system can't find the path,but i have the path 
set.
(English is not my first language and i started python about 5 or 6 days ago)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34269] logging in 3.7 behaves different due to caching

2018-07-31 Thread Karthikeyan Singaravelan

Karthikeyan Singaravelan  added the comment:

I think I have found the bug. When we call setLevel then to clear the cache 
value of Logger objects  `logging.Logger.manager.loggerDict.values()` 
(https://github.com/python/cpython/blob/9c18b1ae527346bc178250ad1ca07bffdacde5dd/Lib/logging/__init__.py#L1265)
 is called but since somewhere you have called 
`logging.Logger.manager.loggerDict.clear()` before changing the level and hence 
it doesn't iterate through the dict to clear the logger object cache. This is 
not present in 3.6 since there is no Logger._cache and works fine.

Don't do logging.Logger.manager.loggerDict.clear() and you can see logging 
enabled for error as False because while doing setLevel we clear the cache of 
Logger objects of logging.Logger.manager.loggerDict.values()

➜  cpython git:(master) ✗ cat bpo34269.py
import sys
import logging

logger1 = logging.getLogger('abc')
logger2 = logging.getLogger('cde')

logger1.setLevel(logging.ERROR)
logger2.setLevel(logging.ERROR)

print("logging error : ", logger1.isEnabledFor(logging.ERROR))

print("logger dict : ", logging.Logger.manager.loggerDict)

print("Not clearing logging dict ")
# logging.Logger.manager.loggerDict.clear()
print("logger dict : ", logging.Logger.manager.loggerDict)
print("logging enabled for error : ", logger1.isEnabledFor(logging.ERROR))

if sys.version_info >= (3,7): # Print cache only for python 3.7 and above
# Since we clear logging.Logger.manager.loggerDict.clear() the cache is not 
reset
print("Cache ", logger1._cache)

print("Setting to critical")
logger1.setLevel(logging.CRITICAL)
if sys.version_info >= (3,7):
print("Cache after setting to critical ", logger1._cache)
print("logging enabled for error : ", logger1.isEnabledFor(logging.ERROR))

➜  cpython git:(master) ✗ ./python.exe bpo34269.py
logging error :  True
logger dict :  {'abc': , 'cde': }
Not clearing logging dict
logger dict :  {'abc': , 'cde': }
logging enabled for error :  True
Cache  {40: True}
Setting to critical
Cache after setting to critical  {}
logging enabled for error :  False

call logging.Logger.manager.loggerDict.clear() and you can see logging enabled 
for error as True because while doing setLevel we clear the cache of Logger 
objects of logging.Logger.manager.loggerDict.values() will be empty.

➜  cpython git:(master) ✗ cat bpo34269.py
import sys
import logging

logger1 = logging.getLogger('abc')
logger2 = logging.getLogger('cde')

logger1.setLevel(logging.ERROR)
logger2.setLevel(logging.ERROR)

print("logging error : ", logger1.isEnabledFor(logging.ERROR))

print("logger dict : ", logging.Logger.manager.loggerDict)

print("clearing logging dict ")
logging.Logger.manager.loggerDict.clear()
print("logger dict : ", logging.Logger.manager.loggerDict)
print("logging enabled for error : ", logger1.isEnabledFor(logging.ERROR))

if sys.version_info >= (3,7):
# Since we clear logging.Logger.manager.loggerDict.clear() the cache is not 
reset
print("Cache ", logger1._cache)

print("Setting to critical")
logger1.setLevel(logging.CRITICAL)
if sys.version_info >= (3,7):
print("Cache after setting to critical ", logger1._cache)
print("logging enabled for error : ", logger1.isEnabledFor(logging.ERROR))

➜  cpython git:(master) ✗ ./python.exe bpo34269.py
logging error :  True
logger dict :  {'abc': , 'cde': }
clearing logging dict
logger dict :  {}
logging enabled for error :  True
Cache  {40: True}
Setting to critical
Cache after setting to critical  {40: True} # Cache is not cleared due to 
logging.Logger.manager.loggerDict.clear()
logging enabled for error :  True # True not False

Above script on Python 3.6 there is no Logger._cache and hence there is no 
cache invalidation to be done though logging.Logger.manager.loggerDict.clear() 
is called.

➜  cpython git:(master) ✗ python3.6 bpo34269.py
logging error :  True
logger dict :  {'abc': , 'cde': }
clearing logging dict
logger dict :  {}
logging enabled for error :  True
Setting to critical
logging enabled for error :  False # False since there is no cache


I have attached the test file that reproduces this. I think this is a bug. I 
don't know how to fix it since we can restrict the user from calling 
`logging.Logger.manager.loggerDict.clear()` and depend on it for cache 
invalidation. Either this can be documented but I think there might be old code 
depending on this. I am adding original reviewers to see if they can add some 
thoughts on this. Feel free to unassign yourself. I will check for a fix for 
this in the meantime with the above test case so that it can make it to next 
Python 3.7 bug fix release. @Thomas.Waldmann for the moment I think from the 
above disabling the loggerDict.clear() call will make tests pass.

Thanks

--
nosy: +pitrou, vinay.sajip, vstinner
Added file: https://bugs.python.org/file47721/bpo34269.py

___
Python tracker 

___
___

[issue34269] logging in 3.7 behaves different due to caching

2018-07-31 Thread Karthikeyan Singaravelan


Change by Karthikeyan Singaravelan :


--
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34290] _ctypes PyCField_new doesn't do anything

2018-07-31 Thread Dan Snider


New submission from Dan Snider :

The function is essentially nothing more than a prototype at the moment:

static PyObject *
PyCField_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
{
CFieldObject *obj;
obj = (CFieldObject *)type->tp_alloc(type, 0);
return (PyObject *)obj;
}

--
components: ctypes
messages: 322754
nosy: bup
priority: normal
severity: normal
status: open
title: _ctypes PyCField_new doesn't do anything
type: crash
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34291] UnboundLocalError raised on call to global

2018-07-31 Thread Camille


New submission from Camille :

In the following code :

def g():
return 0

def f():
g = g()

f()

The call to g in f fails due to an UnboundLocalError, while I expected the 
assignment to hide the global definition of g. Note that if it is done in two 
subsequent calls, i.e. with :
def f():
goo = g()
g = 0

The first assignment still fails.

--
messages: 322755
nosy: camshaka
priority: normal
severity: normal
status: open
title: UnboundLocalError raised on call to global
type: behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34276] urllib.parse doesn't round-trip file URI's with multiple leading slashes

2018-07-31 Thread Martin Panter

Martin Panter  added the comment:

Yes urllib doesn’t distinguish a missing authority/netloc from an empty string. 
The same for the ?query and #fragment parts. There is Issue 22852 open about 
that.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34289] System can't find the path of Python

2018-07-31 Thread Stéphane Wirtel

Stéphane Wirtel  added the comment:

So in this case, it's not an issue with the Python interpreter, but I am going 
to close this issue.

Please for the help about Python, you can subscribe this mailing list 
https://mail.python.org/mailman/listinfo/python-list

Have a nice day,

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34291] UnboundLocalError raised on call to global

2018-07-31 Thread Eric V. Smith


Eric V. Smith  added the comment:

Python thinks that `g` inside `f()` is a local variable. See 
https://stackoverflow.com/questions/9264763/unboundlocalerror-in-python#9264845 
for an explanation.

This is working as intended.

--
nosy: +eric.smith
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34285] regrtest: in case of test failure, add "always look on the bright side of life"

2018-07-31 Thread Karthikeyan Singaravelan


Karthikeyan Singaravelan  added the comment:

I was just searching for the line and came to know it's a Monty Python 
reference :) There seems to be a similar example here with reference to this : 
https://docs.python.org/3.8/library/tarfile.html#command-line-interface

python -m tarfile -c monty.tar life-of-brian_1979/

Thanks much for your work on the buildbots :)

--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31506] Improve the error message logic for object_new & object_init

2018-07-31 Thread Karthikeyan Singaravelan


Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27494] 2to3 parser failure caused by a comma after a generator expression

2018-07-31 Thread Jakub Stasiak


Jakub Stasiak  added the comment:

Apologies for only responding now, I've not received any notifications after my 
original pull request had been merged. I only learned about the change being 
reverted from https://github.com/python/cpython/pull/8580, so let me leave my 
two cents here:

I don't think the syntax not being valid (formally - since forever, practically 
- since 3.7) is good enough reason to make (lib)2to3 reject it. 2to3 is 
supposed to handle old syntax, isn't it? I'd argue that since it is (or was) 
possible to use this syntax in Python 2.x it should be handled gracefully.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24218] Also support SMTPUTF8 in smtplib's send_message method.

2018-07-31 Thread Jens Troeger

Jens Troeger  added the comment:

I was about to open an issue when I found this one.

Consider an email message with the following:

message = EmailMessage()
message["From"] = Address(addr_spec="b...@foo.com", display_name="Jens Troeger")
message["To"] = Address(addr_spec="f...@bar.com", display_name="Martín Córdoba")

It’s important here that the email itself is `ascii` encodable, but the names 
are not. With that combination, send_message() falsely assumes plain text 
addresses (see 
https://github.com/python/cpython/blob/master/Lib/smtplib.py#L949 where it 
checks only email addresses, not display names!) and therefore the 
`international` flag stays False.

As a result of that, flattening the email object 
(https://github.com/python/cpython/blob/master/Lib/smtplib.py#L964) incorrectly 
inserts multiple linefeeds, thus breaking the email header, thus mangling the 
entire email:

flatmsg: b'From: Jens Troeger \r\nTo: Fernando 
=?utf-8?q?Mart=C3=ADn_C=C3=B3rdoba?= \r\r\r\r\r\nSubject:\r\n 
Confirmation: …\r\n…'

I think a proper fix would be in line 949, where email addresses and display 
names should be checked for encoding.

The comment to that function should also be adjusted to mention display names?

Note also that the attached patch does not test the above scenario, and should 
probably be extended as well.

--
nosy: +_savage

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34047] IDLE: on macOS, scroll slider 'sticks' at bottom of file

2018-07-31 Thread Kevin Walzer


Kevin Walzer  added the comment:

Not able to reproduce this issue using a recent build of Tk 8.6.8 plus (it's 
been a little while since I pulled the latest updates from core-8-6-branch, but 
is recent enough). Similar behavior was reported on Tk a couple of years ago 
but has been fixed; I closed 
https://core.tcl.tk/tk/tktview/1875c1f30f2d17230a3d6e8fc7c85d244e80b922 to 
indicate this.

--
nosy: +wordtech

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34275] Problems with tkinter and tk8.6 on MacOS

2018-07-31 Thread Kevin Walzer


Kevin Walzer  added the comment:

Please provide a short working Python script that reproduces the problem. Also, 
please point me to the internal implementation of tooltips in idlelib. Tooltips 
work just fine on Tk on the Mac, but there are many different ways to implement 
them and I suspect Python's implementation can likely be tweaked. It also may 
be related to event handling.

--
nosy: +wordtech

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

2018-07-31 Thread Kevin Walzer


Kevin Walzer  added the comment:

I've observed this behavior myself, and wonder if you are hitting some edge 
case in Tk-Mac event processing (there used to be a lot of issues with this and 
we thought we had addressed them). I don't want to code-dive into Python's 
implementation of these dialogs, so can you provide a simple script that 
demonstrates the issue and I'll take a closer look? Often bugs of this sort can 
be addressed at the script level with some tweaks.

--
nosy: +wordtech

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34275] Problems with tkinter and tk8.6 on MacOS

2018-07-31 Thread Ronald Oussoren


Ronald Oussoren  added the comment:

@terry.reed: Kevin Walzer is a maintainer for Tk on macOS.

I know too little of IDLE to answer his questions.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34292] test_compile is hanging im AMD Ubuntu buildbots

2018-07-31 Thread Pablo Galindo Salgado


New submission from Pablo Galindo Salgado :

Test compile is hanging or failing in AMD(64) Ubuntu buildbots. For example:

https://buildbot.python.org/all/#/builders/157/builds/77
https://buildbot.python.org/all/#/builders/154/builds/90

Example errors:

running: test_tools (3 min 49 sec), test_compile (3 min 47 sec)
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.7.einat-ubuntu/build/Lib/runpy.py", line 
193, in _run_module_as_main
"__main__", mod_spec)
  File "/home/buildbot/buildarea/3.7.einat-ubuntu/build/Lib/runpy.py", line 85, 
in _run_code
exec(code, run_globals)
  File "/home/buildbot/buildarea/3.7.einat-ubuntu/build/Lib/test/__main__.py", 
line 2, in 
main()
  File 
"/home/buildbot/buildarea/3.7.einat-ubuntu/build/Lib/test/libregrtest/main.py", 
line 584, in main
Regrtest().main(tests=tests, **kwargs)
  File 
"/home/buildbot/buildarea/3.7.einat-ubuntu/build/Lib/test/libregrtest/main.py", 
line 531, in main
self._main(tests, kwargs)
  File 
"/home/buildbot/buildarea/3.7.einat-ubuntu/build/Lib/test/libregrtest/main.py", 
line 566, in _main
self.run_tests()
  File 
"/home/buildbot/buildarea/3.7.einat-ubuntu/build/Lib/test/libregrtest/main.py", 
line 486, in run_tests
run_tests_multiprocess(self)
  File 
"/home/buildbot/buildarea/3.7.einat-ubuntu/build/Lib/test/libregrtest/runtest_mp.py",
 line 181, in run_tests_multiprocess
faulthandler.dump_traceback_later(test_timeout, exit=True)
RuntimeError: unable to start watchdog thread
command timed out: 1200 seconds without output running [b'make', 
b'buildbottest', b'TESTOPTS=-j2', b'TESTPYTHONOPTS=', b'TESTTIMEOUT=900'], 
attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=2780.229688

and

running: test_multiprocessing_forkserver (3 min 49 sec), test_compile (5 min 16 
sec)
Makefile:1086: recipe for target 'buildbottest' failed
Timeout (0:15:00)!
Thread 0x7ff09bab5700 (most recent call first):
  File "/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/selectors.py", line 
415 in select
  File "/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/subprocess.py", 
line 1675 in _communicate
  File "/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/subprocess.py", 
line 933 in communicate
  File 
"/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/test/libregrtest/runtest_mp.py",
 line 56 in run_test_in_subprocess
  File 
"/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/test/libregrtest/runtest_mp.py",
 line 120 in _runtest
  File 
"/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/test/libregrtest/runtest_mp.py",
 line 144 in run
  File "/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/threading.py", line 
917 in _bootstrap_inner
  File "/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/threading.py", line 
885 in _bootstrap
Thread 0x7ff09c2b6700 (most recent call first):
  File "/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/selectors.py", line 
415 in select
  File "/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/subprocess.py", 
line 1675 in _communicate
  File "/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/subprocess.py", 
line 933 in communicate
  File 
"/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/test/libregrtest/runtest_mp.py",
 line 56 in run_test_in_subprocess
  File 
"/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/test/libregrtest/runtest_mp.py",
 line 120 in _runtest
  File 
"/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/test/libregrtest/runtest_mp.py",
 line 144 in run
  File "/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/threading.py", line 
917 in _bootstrap_inner
  File "/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/threading.py", line 
885 in _bootstrap
Thread 0x7ff0a2ac7080 (most recent call first):
  File 
"/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/test/libregrtest/runtest_mp.py",
 line 181 in run_tests_multiprocess
  File 
"/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/test/libregrtest/main.py", 
line 486 in run_tests
  File 
"/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/test/libregrtest/main.py", 
line 566 in _main
  File 
"/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/test/libregrtest/main.py", 
line 531 in main
  File 
"/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/test/libregrtest/main.py", 
line 584 in main
  File "/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/test/__main__.py", 
line 2 in 
  File "/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/runpy.py", line 85 
in _run_code
  File "/home/buildbot/buildarea/3.x.einat-ubuntu/build/Lib/runpy.py", line 193 
in _run_module_as_main
make: *** [buildbottest] Error 1
program finished with exit code 2
elapsedTime=3446.164951

In subsequent runs of the buildbots test_compile emits a warning because it has 
ben re-ran:

https://buildbot.python.org/all/#/builders/154/builds/91
https://buildbot.python.org/all/#/builders/157/builds/80

The issue could be transient, but it seems that th

[issue34292] test_compile hangs in AMD Ubuntu buildbots

2018-07-31 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
title: test_compile is hanging im AMD Ubuntu buildbots -> test_compile hangs in 
AMD Ubuntu buildbots

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24218] Also support SMTPUTF8 in smtplib's send_message method.

2018-07-31 Thread Jens Troeger

Jens Troeger  added the comment:

(continuing the previous message msg322761)

…unless the addresses should be checked separately from the display names, in 
which case the BytesGenerator’s flatten() function should be fixed.

Without reading the RFC, please let me know how to continue from here.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27494] 2to3 parser failure caused by a comma after a generator expression

2018-07-31 Thread Serhiy Storchaka


Serhiy Storchaka  added the comment:

Sorry, I missed that you didn't receive a notification about creating of the 
reverting PR. I should announce this explicitly.

2to3 handles the old syntax, but a comma after a generator expression was not a 
valid old syntax. With your patch it accepted this syntax and produced invalid 
Python program.

$ ./python -m lib2to3 -w t9.py
RefactoringTool: Skipping optional fixer: buffer
RefactoringTool: Skipping optional fixer: idioms
RefactoringTool: Skipping optional fixer: set_literal
RefactoringTool: Skipping optional fixer: ws_comma
RefactoringTool: Refactored t9.py
--- t9.py   (original)
+++ t9.py   (refactored)
@@ -1 +1 @@
-print(set(x for x in range(2),))
+print((set(x for x in list(range(2)),)))
RefactoringTool: Files that were modified:
RefactoringTool: t9.py
$ ./python t9.py 
  File "t9.py", line 1
print((set(x for x in list(range(2)),)))
  ^
SyntaxError: Generator expression must be parenthesized

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33398] From, To, Cc lines break when calling send_message()

2018-07-31 Thread Jens Troeger


Jens Troeger  added the comment:

See also this issue comment: https://bugs.python.org/issue24218#msg322761

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34293] DOC: Makefile inherits a Sphinx 1.5 bug regarding PAPER envvar

2018-07-31 Thread jfbu


New submission from jfbu :

There has been a bug at Sphinx since release 1.5 
https://github.com/sphinx-doc/sphinx/issues/5234 about wrong handling of PAPER 
environment variable. The Makefile in Doc/ reproduces the error. As a result 
the "A4 latex" and "letter latex" sub targets of "dist" mis-behave.

A bugfix will be released at Sphinx 1.7.7 or 1.8 but the CPython Doc/Makefile 
needs an update, because the bugfix can only solve problems for new projects 
created with sphinx-quickstart (whether or not using the "make-mode" small 
Makefile, or the "no-make-mode" bigger Makefile which was default up to Sphinx 
1.5).

I will send PR next.

--
assignee: docs@python
components: Documentation
messages: 322770
nosy: docs@python, jfbu
priority: normal
severity: normal
status: open
title: DOC: Makefile inherits a Sphinx 1.5 bug regarding PAPER envvar
type: behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34294] re.finditer and lookahead bug

2018-07-31 Thread beardypig


New submission from beardypig :

I am experiencing and issue with the following regex when using finditer. 

(?=<(?P\w+)/?>(?:(?P.+?))?)", "

(I know it's not the best method of dealing with HTML, and this is a simplified 
version)

For example:

[m.groupdict() for m in 
re.finditer(r"(?=<(?P\w+)/?>(?:(?P.+?))?)", 
"")]

In Python 2.7, 3.5, and 3.6 it returns

[{'tag': 'test', 'text': ''}, {'tag': 'foo2', 'text': None}]

But starting with 3.7 it returns

[{'tag': 'test', 'text': ''}, {'tag': 'foo2', 'text': ''}]

The "text" group appears to be a copy of the previous "text" group.


Some other examples:

"Hello" => [{'tag': 'test', 'text': 'Hello'}, {'tag': 
'foo', 'text': 'Hello'}] (expected: [{'tag': 'test', 'text': 'Hello'}, {'tag': 
'foo', 'text': None}])
"Hello" => [{'tag': 'test', 'text': 'Hello'}, 
{'tag': 'foo', 'text': 'Hello'}, {'tag': 'foo', 'text': None}] (expected: 
[{'tag': 'test', 'text': 'Hello'}, {'tag': 'foo', 'text': None}, {'tag': 'foo', 
'text': None}])

--
components: Regular Expressions
messages: 322771
nosy: beardypig, ezio.melotti, mrabarnett
priority: normal
severity: normal
status: open
title: re.finditer and lookahead bug
type: behavior
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24218] Also support SMTPUTF8 in smtplib's send_message method.

2018-07-31 Thread R. David Murray


R. David Murray  added the comment:

Well, posting on a closed issue is generally not the best way :)

The current behavior with regards to the SMTPUTF8 flag is correct (it only 
matters for *addresses*, display names can already be transmitted if they 
contain non-ascii using non SMTPUTF8 methods).

The multiple carriage returns is a bug, and there is an open issue for it, 
though I'm not finding it at the moment.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34294] re.finditer and lookahead bug

2018-07-31 Thread Serhiy Storchaka


Change by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24218] Also support SMTPUTF8 in smtplib's send_message method.

2018-07-31 Thread Stéphane Wirtel

Stéphane Wirtel  added the comment:

Hi David,

What is the related issue with the new lines?

> On 31 Jul 2018, at 15:18, R. David Murray  wrote:
> 
> 
> R. David Murray  added the comment:
> 
> Well, posting on a closed issue is generally not the best way :)
> 
> The current behavior with regards to the SMTPUTF8 flag is correct (it only 
> matters for *addresses*, display names can already be transmitted if they 
> contain non-ascii using non SMTPUTF8 methods).
> 
> The multiple carriage returns is a bug, and there is an open issue for it, 
> though I'm not finding it at the moment.
> 
> --
> 
> ___
> Python tracker 
> 
> ___
> ___
> Python-bugs-list mailing list
> Unsubscribe: 
> https://mail.python.org/mailman/options/python-bugs-list/stephane%40wirtel.be
>

--
nosy: +matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34293] DOC: Makefile inherits a Sphinx 1.5 bug regarding PAPER envvar

2018-07-31 Thread jfbu


Change by jfbu :


--
keywords: +patch
pull_requests: +8094
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34293] DOC: Makefile inherits a Sphinx 1.5 bug regarding PAPER envvar

2018-07-31 Thread jfbu


jfbu  added the comment:

https://github.com/python/cpython/pull/8585

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1764286] inspect.getsource does not work with decorated functions

2018-07-31 Thread Yury Selivanov


Yury Selivanov  added the comment:

> Should `getsourcefile` be changed to match?

I'd say yes. There's no point in getsourcefile returning the file location of 
the topmost decorator. Feel free to open a new issue and submit a PR to fix 
this!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34263] asyncio: "relative *delay* or absolute *when* should not exceed one day"

2018-07-31 Thread Yury Selivanov


Yury Selivanov  added the comment:


New changeset 944451cd8d3e897138f4b43569de13cd081ee251 by Yury Selivanov 
(MartinAltmayer) in branch 'master':
bpo-34263 Cap timeout submitted to epoll/select etc. to one day. (GH-8532)
https://github.com/python/cpython/commit/944451cd8d3e897138f4b43569de13cd081ee251


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34274] Python launcher behavior with "#!/usr/bin/env python" shebang

2018-07-31 Thread Eryk Sun


Eryk Sun  added the comment:

See the discussion in issue 28686 regarding the use of version detection and/or 
versioned executable names with env shebangs. I think the launcher should at 
least support searching PATH for pythonX.exe and pythonX.Y.exe, so users can at 
least manually copy or symlink to python.exe.

--
nosy: +eryksun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34263] asyncio: "relative *delay* or absolute *when* should not exceed one day"

2018-07-31 Thread miss-islington


Change by miss-islington :


--
pull_requests: +8095

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34263] asyncio: "relative *delay* or absolute *when* should not exceed one day"

2018-07-31 Thread miss-islington


Change by miss-islington :


--
pull_requests: +8096

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22852] urllib.parse wrongly strips empty #fragment, ?query, //netloc

2018-07-31 Thread Chris Jerdonek


Chris Jerdonek  added the comment:

I just learned of this issue. Rather than adding has_netloc, etc. attributes, 
why not use None to distinguish missing values as is preferred above, but add a 
new boolean keyword argument to urlparse(), etc. to get the new behavior (e.g. 
"allow_none" to parallel "allow_fragments")?

It seems like this would be more elegant, IMO, because it would lead to the API 
we really want. For example, the ParseResult(), etc. signatures and repr() 
values would be simpler. Changing the default value of the new keyword 
arguments would also provide a clean and simple deprecation pathway in the 
future, if desired.

--
nosy: +chris.jerdonek

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34291] UnboundLocalError raised on call to global

2018-07-31 Thread Tim Peters


Tim Peters  added the comment:

Yes, the assignment does "hide the global definition of g".  But this 
determination is made at compile time, not at run time:  an assignment to `g` 
_anywhere_ inside `f()` makes _every_ appearance of `g` within `f()` local to 
`f`.

--
nosy: +tim.peters

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27494] 2to3 parser failure caused by a comma after a generator expression

2018-07-31 Thread Jakub Stasiak


Jakub Stasiak  added the comment:

I appreciate the example, but I'd claim that's a "missing fixer" issue, not a 
"parser accepts too much" issue. Considering the syntax wasn't ambiguous (I 
think) and had been accepted before 3.7 I'll remain not totally convinced here.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33729] Hashlib/blake2* missing 'data' keyword argument

2018-07-31 Thread STINNER Victor


STINNER Victor  added the comment:

I have no opinion on the change in the master branch, but I agree with 
Christian that the 3.7 change should be reverted since it breaks the backward 
compatibility.

Serhiy modified int() in Python 3.7 to convert its first parameter to 
positional only parameter. IMHO it's ok to do such change. Moreover, the change 
has been documented in What's New in Python 3.7:
https://docs.python.org/dev/whatsnew/3.7.html#api-and-feature-removals

If you decide to keep the change in the master branch, it should be documented 
in What's New in Python 3.8, no?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24809] Add getprotobynumber to socket module

2018-07-31 Thread STINNER Victor


STINNER Victor  added the comment:

I concur with Yury that there is not enough users and use cases needing this 
feature, so it doesn't deserve to pay the maintenance burden in the standard 
library. Start with a project on PyPI.

--
resolution:  -> rejected
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34279] RFC: issue a warning in regrtest when no test have been executed?

2018-07-31 Thread STINNER Victor


STINNER Victor  added the comment:

> I would prefer shorter and totally different from the normal output in case 
> of no tests ran.

That's basically the whole purpose of the issue, yep ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34125] Profiling depends on whether **kwargs is given

2018-07-31 Thread STINNER Victor


STINNER Victor  added the comment:

I opened a wider discussion: bpo-29502. The discussion didn't go anywhere yet.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34035] Several AttributeError in zipfile seek() methods

2018-07-31 Thread STINNER Victor


STINNER Victor  added the comment:

Note: the seek() method has been added by bpo-22908 (commit 
066df4fd454d6ff9be66e80b2a65995b10af174f), and Python 3.6 is not affected.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34263] asyncio: "relative *delay* or absolute *when* should not exceed one day"

2018-07-31 Thread Yury Selivanov


Yury Selivanov  added the comment:


New changeset 172a81e42bc30da1bd4027db9cd3b6172469f7fe by Yury Selivanov (Miss 
Islington (bot)) in branch '3.7':
[3.7] bpo-34263 Cap timeout submitted to epoll/select etc. to one day. 
(GH-8532) (GH-8586)
https://github.com/python/cpython/commit/172a81e42bc30da1bd4027db9cd3b6172469f7fe


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34263] asyncio: "relative *delay* or absolute *when* should not exceed one day"

2018-07-31 Thread Yury Selivanov


Yury Selivanov  added the comment:


New changeset 6f16ffc1879fc934eba297b3e81bd940e32a7e03 by Yury Selivanov (Miss 
Islington (bot)) in branch '3.6':
[3.6] bpo-34263 Cap timeout submitted to epoll/select etc. to one day. 
(GH-8532) (GH-8587)
https://github.com/python/cpython/commit/6f16ffc1879fc934eba297b3e81bd940e32a7e03


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34263] asyncio: "relative *delay* or absolute *when* should not exceed one day"

2018-07-31 Thread Yury Selivanov


Yury Selivanov  added the comment:

Merged. Thank you, hope that you'll keep contributing! :)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24218] Also support SMTPUTF8 in smtplib's send_message method.

2018-07-31 Thread Jens Troeger

Jens Troeger  added the comment:

>  Well, posting on a closed issue is generally not the best way :)

Fair enough ;)

>  The multiple carriage returns is a bug, and there is an open issue for it, 
> though I'm not finding it at the moment.

Oh good, yes that should be fixed!

My current workaround is setting `international = True` _always_, which 
prevents the multiple CRs. Not pretty but it works…

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34244] Add support of check logger

2018-07-31 Thread Vinay Sajip


Vinay Sajip  added the comment:

What is your use case?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34269] logging in 3.7 behaves different due to caching

2018-07-31 Thread Vinay Sajip


Vinay Sajip  added the comment:

Well, loggerDict is an internal implementation detail which shouldn't be 
directly called by the code in borgbackup. Hence I'm not sure you can call it a 
bug. When messing around with internals of objects, caveats apply.

Note that loggerDict isn't mentioned in the documentation: this is deliberate.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29036] logging module: Add `full_module_name` to LogRecord details

2018-07-31 Thread Vinay Sajip


Vinay Sajip  added the comment:

If you use the recommended approach of using

logger = logging.getLogger(__name__),

then the logger's name (the name field in the LogRecord) will be the full 
module path.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34237] faq/design: PEP 572 adds assignment expressions

2018-07-31 Thread Emily Morehouse


Emily Morehouse  added the comment:

This issue was brought to my attention -- I'm helping build the PEP 572 
implementation. I'll make sure the docs get updated (and Jonathan, I didn't 
actually know that assignment expressions were mentioned in the FAQ, so this 
was still helpful!)

--
assignee: docs@python -> emilyemorehouse
nosy: +emilyemorehouse

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34237] faq/design: PEP 572 adds assignment expressions

2018-07-31 Thread Chris Angelico


Chris Angelico  added the comment:

BTW, sorry for sounding a bit snippy in my comment. Jonathan, in future, rather 
than dropping someone an email, it'd be more normal to just ping the person on 
the issue itself.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32947] Support OpenSSL 1.1.1

2018-07-31 Thread Charalampos Stratakis


Charalampos Stratakis  added the comment:

Yes test_poplib and test_ftplib on fedora rawhide when run against openssl 
1.1.1 pre8. Haven't tried the pr7, but assuming that the tests were fine before 
here is the list of changes between pre7 and pre8:

https://github.com/openssl/openssl/compare/OpenSSL_1_1_1-pre7...OpenSSL_1_1_1-pre8

--
nosy: +cstratak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34232] Python3.7.0 exe installers (32 and 64 bit) failing on Windows7

2018-07-31 Thread Wolfgang Maier


Change by Wolfgang Maier :


Added file: https://bugs.python.org/file47723/Python 3.7.0 
(64-bit)_20180731180657.log

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34232] Python3.7.0 exe installers (32 and 64 bit) failing on Windows7

2018-07-31 Thread Wolfgang Maier


Wolfgang Maier  added the comment:

Oh, sorry, I didn't realize there was another file and it seems I did not keep 
it so I just ran the installer again to reproduce.
Attached is the new pair of log files.

--
Added file: https://bugs.python.org/file47722/Python 3.7.0 
(64-bit)_20180731180657_000_core_JustForMe.log

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34269] logging in 3.7 behaves different due to caching

2018-07-31 Thread Karthikeyan Singaravelan


Karthikeyan Singaravelan  added the comment:

Okay, I did some code search on GitHub for 
`logging.Logger.manager.loggerDict.clear()` 
(https://github.com/search?q=logging.Logger.manager.loggerDict.clear%28%29&type=Code)
 and there was some code in the test_logging where it was used in tearDown and 
setUp so I thought it's a public function. My bad on not reading the docs. I 
agree that it's not a bug if it's an undocumented internal implementation 
related change that one should not rely upon. 

Thanks

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34269] logging in 3.7 behaves different due to caching

2018-07-31 Thread STINNER Victor


Change by STINNER Victor :


--
nosy:  -vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34294] re.finditer and lookahead bug

2018-07-31 Thread Karthikeyan Singaravelan


Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33729] Hashlib/blake2* missing 'data' keyword argument

2018-07-31 Thread Serhiy Storchaka


Serhiy Storchaka  added the comment:

In case of int() the name of it's first argument was documented, in both the 
module documentation, and in interactive help. But the documented name of the 
first blake2b() argument was "data", and it never worked. Since help() was not 
worked for blake2b, the user had weak chance to know that the actual name is 
"string". Thus there is much less chance of breaking the user code by making 
this parameter a positional-only than in case of int().

But I think Christian has other concerns.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34294] re.finditer and lookahead bug

2018-07-31 Thread Karthikeyan Singaravelan

Karthikeyan Singaravelan  added the comment:

➜  cpython git:(70d56fb525) ✗ ./python.exe
Python 3.7.0a2+ (tags/v3.7.0a2-341-g70d56fb525:70d56fb525, Jul 31 2018, 
21:58:10)
[Clang 7.0.2 (clang-700.1.81)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>>
➜  cpython git:(70d56fb525) ✗ ./python.exe -c 'import re; print([m.groupdict() 
for m in re.finditer(r"(?=<(?P\w+)/?>(?:(?P.+?))?)", 
"")])'
[{'tag': 'test', 'text': ''}, {'tag': 'foo2', 'text': ''}]


➜  cpython git:(e69fbb6a56) ✗ ./python.exe
Python 3.7.0a2+ (tags/v3.7.0a2-340-ge69fbb6a56:e69fbb6a56, Jul 31 2018, 
22:12:06)
[Clang 7.0.2 (clang-700.1.81)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>>
➜  cpython git:(e69fbb6a56) ✗ ./python.exe -c 'import re; print([m.groupdict() 
for m in re.finditer(r"(?=<(?P\w+)/?>(?:(?P.+?))?)", 
"")])'
[{'tag': 'test', 'text': ''}, {'tag': 'foo2', 'text': None}]

Does this have something to do with 
70d56fb52582d9d3f7c00860d6e90570c6259371(bpo-25054, bpo-1647489) ?


Thanks

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34295] Avoid inefficient way to find start point in deque.index

2018-07-31 Thread Seonggi Kim


Change by Seonggi Kim :


--
components: ctypes
nosy: hacksg
priority: normal
severity: normal
status: open
title: Avoid inefficient way to find start point in deque.index
type: enhancement
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34295] Avoid inefficient way to find start point in deque.index

2018-07-31 Thread Seonggi Kim


Change by Seonggi Kim :


--
keywords: +patch
pull_requests: +8097
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34295] Avoid inefficient way to find start point in deque.index

2018-07-31 Thread Seonggi Kim


Change by Seonggi Kim :


--
components: +Extension Modules -ctypes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34296] Speed up python startup by pre-warming the vm

2018-07-31 Thread Cyker Way


New submission from Cyker Way :

I'm currently writing some shell tools with python3. While python can 
definitely do the job succinctly, there is one problem which made me feel I 
might have to switch to other languages or even pure bash scripts: python 
startup time.

Shell tools are used very often, interactively. users do feel the lag when they 
hit enter after their command. i did 2 implementations in both python and pure 
bash, python takes about 500ms to run while bash is more than 10 times faster.

I'm not saying bash is better than python, but for this task bash, or even 
perl, is a better choice. however, i think there is an easy way to improve 
python as i believe the lag is mostly due to its slow startup: pre-warm its vm. 

I can think of 2 scenarios for python to do a better shell job:

1.  Run a universal python as a daemon, which reads scripts from a socket, runs 
it, and returns the result to a socket. Because it's running as a daemon, the 
startup time is avoided each time user runs a script.

2.  Warm a python zygote during system boot. Every time a python script is run, 
fork from the zygote instead of cold-boot the vm. this is a similar approach to 
android zygote.

I haven't done experiments to see whether there will be obstacles in 
implementing these scenarios. But I think this should become a priority because 
it's real and tangible, and other people may face the slow startup problem as 
well. If there's ongoing work on these, I'd be happy to have a look. But I 
don't think these scenarios have already been put into released versions of 
python.

--
components: Interpreter Core
messages: 322800
nosy: cykerway
priority: normal
severity: normal
status: open
title: Speed up python startup by pre-warming the vm
type: enhancement
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34295] Avoid inefficient way to find start point in deque.index

2018-07-31 Thread Raymond Hettinger


New submission from Raymond Hettinger :

Can you run some timings to show the difference.  Also, you need to sign a CLA.

--
assignee:  -> rhettinger
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34297] Windows py.exe launcher fail to handle quote correctly

2018-07-31 Thread Francois Godin


New submission from Francois Godin :

Using double quote around the version argument will cause a failure.

Ex (failure): "py.exe" "-3" "test.py" 
=> run_child: about to run '3" "...\python.exe" "test.py"'
=> ...\python.exe: can't open file '3 test.py': [Errno 22] Invalid argument

Removing the double quote give (success): "py.exe" -3 "test.py" => run_child: 
about to run '"...\python.exe" "test.py"'

This is mainly problematic when a library or a tool want to be simpler and 
simply add double quotes around every parameters. This is impossible to do with 
the python launcher.

The issue seems to come from the PC/launcher.c file. It is the following line 
in the function process (around line 1622): command += wcslen(p);

This line is suppose to skip the -3 in the command line so that the rest can be 
given to python as-is. The problem is that while command come from 
GetCommandLineW and thus contain quote, p come from __wargv and does not 
contain the double quote. Thus, the 2 characters "- are skipped instead of -3.

--
components: Demos and Tools, Distutils, Windows
messages: 322802
nosy: copelnug, dstufft, eric.araujo, paul.moore, steve.dower, tim.golden, 
zach.ware
priority: normal
severity: normal
status: open
title: Windows py.exe launcher fail to handle quote correctly
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34297] Windows py.exe launcher fail to handle quote correctly

2018-07-31 Thread Francois Godin


Change by Francois Godin :


--
type:  -> behavior
versions: +Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34295] Avoid inefficient way to find start point in deque.index

2018-07-31 Thread Raymond Hettinger


Raymond Hettinger  added the comment:

OP closed the PR.

--
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed
versions:  -Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34298] Avoid inefficient way to find start point in deque.index

2018-07-31 Thread Seonggi Kim


Change by Seonggi Kim :


--
components: Extension Modules
nosy: hacksg
priority: normal
severity: normal
status: open
title: Avoid inefficient way to find start point in deque.index
type: enhancement
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34298] Avoid inefficient way to find start point in deque.index

2018-07-31 Thread Seonggi Kim


Change by Seonggi Kim :


--
keywords: +patch
pull_requests: +8098
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34298] Avoid inefficient way to find start point in deque.index

2018-07-31 Thread Raymond Hettinger


New submission from Raymond Hettinger :

Please run some timings to show whether the improvement is significant.  Also, 
please sign a CLA.

--
components: +Library (Lib) -Extension Modules
nosy: +rhettinger
versions:  -Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34203] documentation: recommend Python 3 over 2 in faq

2018-07-31 Thread Karthikeyan Singaravelan


Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34007] test_gdb fails in s390x SLES buildbots

2018-07-31 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

New failure on s390x SLES 3.7: 

https://buildbot.python.org/all/#/builders/122/builds/540

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34269] logging in 3.7 behaves different due to caching

2018-07-31 Thread Thomas Waldmann


Thomas Waldmann  added the comment:

I agree that we should not dig that deep into logging internals and clear that 
dict from borg code.

But, seems like one has no public api to reinitialize logging to a like-fresh 
state, right? So maybe THAT is the real problem.

Add some .reset() method to do that?

BTW, removing that .clear() from our code made our tests work again. I am not 
sure why that was added in the first place as I could not find regressions 
after removing it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34286] lib2to3 tests fail on the 3.7 branch (used to work with 3.7.0)

2018-07-31 Thread Brett Cannon


Brett Cannon  added the comment:

Could be related to https://bugs.python.org/issue21446 .

--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34299] argparse description formatting

2018-07-31 Thread Phillip M. Feldman


New submission from Phillip M. Feldman :

With `argparse`, I'm providing a triple-quoted string via the `description` 
argument of the constructor.  When I invoke the script with the -h or --help 
argument, all formatting in the triple-quoted string is lost, i.e., all 
paragraphs are run together into one giant paragraph, and the result is rather 
hard to read.

Phillip M. Feldman

--
components: Library (Lib)
messages: 322808
nosy: phillip.m.feld...@gmail.com
priority: normal
severity: normal
status: open
title: argparse description formatting
type: behavior
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34300] gcc 7.3 causes a warning when compiling getpath.c in python 2.7

2018-07-31 Thread tzickel


New submission from tzickel :

When compiling on ubuntu 18.04 the 2.7 branch, I get this warning:

gcc -pthread -c -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -O3 -Wall 
-Wstrict-prototypes  -I. -IInclude -I./Include   -DPy_BUILD_CORE 
-DPYTHONPATH='":plat-linux2:lib-tk:lib-old"' \
-DPREFIX='"/usr/local"' \
-DEXEC_PREFIX='"/usr/local"' \
-DVERSION='"2.7"' \
-DVPATH='""' \
-o Modules/getpath.o ./Modules/getpath.c
In file included from /usr/include/string.h:494:0,
 from Include/Python.h:38,
 from ./Modules/getpath.c:3:
In function 'strncpy',
inlined from 'joinpath' at ./Modules/getpath.c:202:5,
inlined from 'search_for_prefix' at ./Modules/getpath.c:265:9,
inlined from 'calculate_path' at ./Modules/getpath.c:505:8:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: 
'__builtin_strncpy': specified size between 9223372036854779906 and 
18446744073709551615 exceeds maximum object size
9223372036854775807 [-Wstringop-overflow=]
   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
  ^~

I think it's because the compiler can't reason that Py_FatalError aborts the 
program, and thus not overflow strncpy.

Since there are about 3-4 warnings while building, maybe we should add a manual 
return after Py_FatalError in joinpath ?

--
components: Build
messages: 322809
nosy: tzickel
priority: normal
severity: normal
status: open
title: gcc 7.3 causes a warning when compiling getpath.c in python 2.7
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   >