[issue28740] Add sys.getandroidapilevel()

[Chi Hsuan Yen]

Chi Hsuan Yen added the comment:

Maybe time to re-implement android_ver() in issue26855 in C.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28719] zipfile increase in size

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

If the output file is not seekable, zipfile sets bit 3 in file header flags and 
writes 12 or 20 (if ZIP64 extension is used) additional bytes after the 
compressed data. These bytes contain the CRC, compressed and uncompressed 
sizes. Corresponding fields in local file header are set to zero.

In case of writestr() this can be considered as a regression, since the CRC and 
sizes can be calculated before writing compressed data and saved in local file 
header.

But it would be not easy to fix this.

--
assignee:  -> serhiy.storchaka
components: +Library (Lib)
stage:  -> needs patch
type: resource usage -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28740] Add sys.getandroidapilevel()

[Chi Hsuan Yen]

Chi Hsuan Yen added the comment:

I translate the Python version at issue26855 to C. Quite new to the C API, hope 
I'm doing it right :)

Codes only. Docs and tests later

sys.getwindowsversion() uses named tuples. Is there a similar need for Android 
or just plain tuples are fine?

--
Added file: http://bugs.python.org/file45545/sys_getandroidversion.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28745] Python 3.5.2 "from ... import" statement is different from official documentation

[Eric V. Smith]

Changes by Eric V. Smith :


--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28740] Add sys.getandroidapilevel()

[STINNER Victor]

STINNER Victor added the comment:

I didn't know that there are build and runtime versions. If the runtime
version is available, it should be preferred.

Hum, maybe its better to expose the __system_property_get() function in the
os module, something similar to os.confstr()?
https://docs.python.org/dev/library/os.html#os.confstr

If the OS returns a string, I suggest to return a string in Python too. The
caller would be responsible to convert it to integer. What do you think of
that?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10049] Add a "no-op" (null) context manager to contextlib (Rejected: use contextlib.ExitStack())

[Nick Coghlan]

Nick Coghlan added the comment:

No, it wouldn't, as ExitStack() does far more than merely implement a null 
context.

It would be like adding "nulliterable = ()" as a builtin, rather than just 
telling people "If you need a null iterable, use an empty tuple".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28740] Add sys.getandroidapilevel()

[Xavier de Gaye]

Xavier de Gaye added the comment:

__system_property_get() is not a public API, see Android bug report [1].

In this stackoverflow question, an Android developer confirms this point and 
suggests to use the file /system/build.prop instead, noting however that 
"build.prop isn't guaranteed to be stable (or even present)".

This interesting document [3] describes the Android properties management 
design.

I think we must use the reliable build time Android API level and implement 
sys.getandroidapilevel() (Victor patch) for knowing, in the standard library, 
whether we are running on an Android platform, and provide a best effort 
platform.android_ver() for the Android run time version. Things are changing 
very fast with the Android project and the OEM may add their own changes too.

[1] https://code.google.com/p/android/issues/detail?id=143627
[2] 
http://stackoverflow.com/questions/28413530/api-to-get-android-system-properties-is-removed-in-arm64-platforms
[3] http://rxwen.blogspot.fr/2010/01/android-property-system.html

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28743] test_choices_algorithms() in test_random uses lots of memory

[Gareth Rees]

Gareth Rees added the comment:

Couldn't the test case use something like this to avoid allocating so much 
memory?

from collections.abc import Sequence

class RepeatedSequence(Sequence):
"""Immutable sequence of n repeats of elem."""
def __init__(self, elem, n):
self.elem = elem
self.n = n

def __getitem__(self, key):
return self.elem

def __len__(self):
return self.n

and then:

self.gen.choices(range(n), RepeatedSequence(1, n), k=1)

--
nosy: +Gareth.Rees

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28740] Add sys.getandroidapilevel()

[Xavier de Gaye]

Xavier de Gaye added the comment:

The build time Android API level is also a valuable information to Python users 
(application developers), it may be used at installation time or to detect a 
version mismatch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28743] test_choices_algorithms() in test_random uses lots of memory

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The main memory consumer is a list of cumulated weights created inside 
choices().

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28743] test_choices_algorithms() in test_random uses lots of memory

[Gareth Rees]

Gareth Rees added the comment:

In order for this to work, the __getitem__ method needs to be:

def __getitem__(self, key):
if 0 <= key < self.n:
return self.elem
else:
raise IndexError(key)

But unfortunately this is very bad for the performance of the test. The 
original code, with [1]*n:

Ran 1 test in 5.256s

With RepeatedSequence(1, n):

Ran 1 test in 33.620s

So that's no good. However, I notice that although the documentation of choices 
specifies that weights is a sequence, in fact it seems only to require an 
iterable:

cum_weights = list(_itertools.accumulate(weights))

so itertools.repeat works, and is faster than the original code:

Ran 1 test in 4.991s

Patch attached, in case it's acceptable to pass an iterable here.

--
keywords: +patch
Added file: http://bugs.python.org/file45546/issue28743.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28746] cannot set_inheritable() for a file descriptor on Android

[Xavier de Gaye]

New submission from Xavier de Gaye:

test_socket on Android fails with:
FAIL: test_set_inheritable (test.test_socket.InheritanceTest)
--
Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/test/test_socket.py", line 
4936, in test_set_inheritable
self.assertEqual(sock.get_inheritable(), True)
AssertionError: False != True

==
FAIL: test_set_inheritable_cloexec (test.test_socket.InheritanceTest)
--
Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/test/test_socket.py", line 
4965, in test_set_inheritable_cloexec
0)
AssertionError: 1 != 0

Setting a file descriptor with os.set_inheritable() also fails.
Setting directly the file descriptor with fcntl.fcntl() succeeds.

--
assignee: xdegaye
components: Interpreter Core
messages: 281221
nosy: xdegaye
priority: normal
severity: normal
stage: needs patch
status: open
title: cannot set_inheritable() for a file descriptor on Android
type: behavior
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28746] cannot set_inheritable() for a file descriptor on Android

[Xavier de Gaye]

Xavier de Gaye added the comment:

It seems the code path run by Android is not tested by any of the buildbots.
Patch attached.

--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file45547/set_inheritable.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28740] Add sys.getandroidapilevel()

[Chi Hsuan Yen]

Chi Hsuan Yen added the comment:

Both sys.androidapilevel() and platform.android_ver() return information about 
Android's API level. I guess that would be confusing so I hope to get them 
unified.

Techinically it won't be a problem as Chromium is still using it (in a even 
dirty way) and the plan to remove it is stalled. [1]

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=392191

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28729] Exception from sqlite3 adapter masked by sqlite3.InterfaceError

[Aviv Palivoda]

Changes by Aviv Palivoda :


--
nosy: +palaviv

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28746] cannot set_inheritable() for a file descriptor on Android

[Roundup Robot]

Roundup Robot added the comment:

New changeset 2fb2e3dc450e by Xavier de Gaye in branch '3.6':
Issue #28746: Fix the set_inheritable() file descriptor method on platforms
https://hg.python.org/cpython/rev/2fb2e3dc450e

New changeset 3248782c3176 by Xavier de Gaye in branch 'default':
Issue #28746: Merge 3.6
https://hg.python.org/cpython/rev/3248782c3176

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28746] cannot set_inheritable() for a file descriptor on Android

[Xavier de Gaye]

Changes by Xavier de Gaye :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28741] PEP 498: single '}' is not allowed

[Eric V. Smith]

Eric V. Smith added the comment:

Thanks. Fixed in the pep repo in 4e86033.

--
assignee: docs@python -> eric.smith
resolution:  -> fixed
status: open -> closed
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28556] typing.py upgrades

[Roundup Robot]

Roundup Robot added the comment:

New changeset 1e49abb03e0f by Guido van Rossum in branch '3.5':
Issue #28556: two more small upstream changes by Ivan Levkivskyi (#329, #330)
https://hg.python.org/cpython/rev/1e49abb03e0f

New changeset cdddf4ee0e00 by Guido van Rossum in branch '3.6':
Issue #28556: two more small upstream changes by Ivan Levkivskyi (#329, #330) 
(3.5->3.6)
https://hg.python.org/cpython/rev/cdddf4ee0e00

New changeset 1465baaccd84 by Guido van Rossum in branch 'default':
Issue #28556: two more small upstream changes by Ivan Levkivskyi (#329, #330) 
(3.6->3.7)
https://hg.python.org/cpython/rev/1465baaccd84

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25658] PyThread assumes pthread_key_t is an integer, which is against POSIX

[Masayuki Yamamoto]

Masayuki Yamamoto added the comment:

I wrote a patch to avoid compile error for platforms that pthread_key_t is not 
integer.
This patch changes to turn off Py_HAVE_NATIVE_TLS if pthread_key_t is not 
integer. Hence the platforms use TLS functions implemented by CPython self.

And, I would propose new thread local storage API based on C11 thread and 
current TLS functions move to deprecated. C11 tss_t doesn't require defined as 
integer [1]. Therefore I think new API should use tss_t, not hide into integer.

[1] http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1570.pdf (page 394)

I'm thinking of new interfaces. For example, declaration in Include/pythread.h

/* Specialise to each platforms using #if directive */
typedef /* TLS key types or C11 tss_t */ Py_tss_t;

/* Based on C11 threads.h, but destructor doesn't support.
   the delete value function is maintained for the implementation by CPython 
self.
*/
PyAPI_FUNC(int) PyThread_tss_create(Py_tss_t *);
PyAPI_FUNC(void) PyThread_tss_delete(Py_tss_t);
PyAPI_FUNC(void *) PyThread_tss_get(Py_tss_t);
PyAPI_FUNC(int) PyThread_tss_set(Py_tss_t, void *);
PyAPI_FUNC(void) PyThread_tss_delete_value(Py_tss_t);

--
Added file: http://bugs.python.org/file45548/configure-pthread_key_t.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27945] Various segfaults with dict

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Here is a consolidated patch for review.

--
Added file: http://bugs.python.org/file45549/27945-dict-segv-py36.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27945] Various segfaults with dict

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The change to dict_equal() LGTM. It doesn't add an overhead.

For dictiter_iternextitem() I propose other change. It doesn't add an overhead.

There are bugs in the patch for _PyDict_FromKeys().

The change to dictitems_contains() adds an overhead, but it is small and seems 
unavoidable.

I wondering whether it is worth to use PySequence_Tuple() instead of 
PySequence_Fast() in PyDict_MergeFromSeq2(). This would add a cost of creating 
new tuple if items are not tuples, but save increfing/decrefing the key and the 
value in common case.

I have doubts about insertdict(). Additional incref duplicates increfs in 
dict_merge(). Is it worth to move it outside of insertdict()?

I have doubts about _PyDict_FromKeys(). It seems to me that it is safe to use 
_PyDict_Next() in a loop that mutates the dict (not checked _PySet_Next()). 
With guarded insertdict() additional check is not needed (and it doesn't help 
against clearing the dict inside insertdict()).

In updated patch fixed some bugs and used different solution for 
dictiter_iternextitem().

--
Added file: http://bugs.python.org/file45550/27945-dict-segv-py37-2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28747] Expose SSL_CTX_set_cert_verify_callback

[Steve Dower]

New submission from Steve Dower:

As a prerequisite for fixing issues such as issue20916 (dynamic download/update 
of CAs and CRLs), we really need to be able to plug into the certificate 
verification function for OpenSSL.

This patch adds SSLContext._set_cert_verify_callback, which will allow Python 
code to inject its own verification function.

No other functionality is added, but I have proof-of-concept code that uses 
this patch to delegate all certificate handling to Windows and it works 
beautifully (better than I expected :) ).

If possible, I'd like to get this into Python 3.6. I intend to turn that 
proof-of-concept into an actual released library and would like to be able to 
do it sooner rather than later. Targeting 3.6 is the main reason I named the 
function with an underscore, but I'd be happy to drop it.

--
assignee: christian.heimes
components: SSL
messages: 281230
nosy: christian.heimes, ned.deily, steve.dower
priority: normal
severity: normal
stage: patch review
status: open
title: Expose SSL_CTX_set_cert_verify_callback
type: security
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28747] Expose SSL_CTX_set_cert_verify_callback

[Steve Dower]

Steve Dower added the comment:

Patch attached with code changes and basic tests. Doc changes to follow.

--
keywords: +patch
Added file: http://bugs.python.org/file45551/28747_1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27583] configparser: modifying default_section at runtime

[Wolfgang Maier]

Wolfgang Maier added the comment:

Well, you *can* change the value at runtime as you are demonstrating in your 
script, but you are misunderstanding the effect this will have. It *won't* 
cause a reevaluation of an already parsed config file. Instead it will affect 
the writing of the parsed settings to a new config file.
This is explained a bit further up in the documentation of the module:
https://docs.python.org/3/library/configparser.html#customizing-parser-behaviour
where it says: "Its current value can be retrieved using the 
parser_instance.default_section attribute and may be modified at runtime (i.e. 
to convert files from one format to another)."

So maybe this hint could be repeated in the actual parameter description of 
https://docs.python.org/3/library/configparser.html#configparser-objects to 
avoid confusion, but I don't think there is a bug here.

--
nosy: +wolma

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28747] Expose SSL_CTX_set_cert_verify_callback

[Steve Dower]

Steve Dower added the comment:

Oh, I also made the SSL module chain exceptions properly. That's probably the 
biggest and scariest part of the change, but it can't have been overwriting 
exceptions before anyway (because it calls back into Python code to instantiate 
SSLError), so it's only going to chain in the new case of the callback function 
raising.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10049] Add a "no-op" (null) context manager to contextlib (Rejected: use contextlib.ExitStack())

[Martin Blais]

Martin Blais added the comment:

Well that just echoes exactly what I originally thought, but somebody else said 
it was not needed because ExitStack already exists and could be used for that 
purpose.

If this were at work and/or it were all just to me, I'd just implement a brand 
new nullcontext and move on.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28747] Expose SSL_CTX_set_cert_verify_callback

[Christian Heimes]

Christian Heimes added the comment:

Hi Steve,

there is a better approach to fix issue20916. The verify callback is not the 
correct API, because it is called too late. We want to hook into the cert 
resolution mechanism of OpenSSL and get trust anchors and CRLs in before 
OpenSSL builds the verification chain.

Instead of a verify cb we have to implement a X509_LOOKUP_METHOD with a 
get_by_subject(). The function looks up X509_LU_CRL or X509_LU_X509 by 
X509_NAME. The other lookups functions (fingerprint, issuer) aren't used to 
look up root CAs.

Then use some CAPI function like CertFindCertificateInStore() with 
CERT_FIND_SUBJECT_NAME to look up the cert, convert it to OpenSSL X509 object, 
copy the additional trust flags from Windows' cert type to the X509_CERT_AUX 
member of OpenSSL's X509 type.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27583] configparser: modifying default_section at runtime

[R. David Murray]

Changes by R. David Murray :


--
assignee:  -> docs@python
components: +Documentation
nosy: +docs@python
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28740] Add sys.getandroidapilevel()

[STINNER Victor]

STINNER Victor added the comment:

> I think we must use the reliable build time Android API level and
implement sys.getandroidapilevel() (Victor patch) for knowing, in the
standard library, whether we are running on an Android platform, and
provide a best effort platform.android_ver() for the Android run time
version. Things are changing very fast with the Android project and the OEM
may add their own changes too.

Hum, IMO we should at least use a structure with names for the sys function
to be able to return more information later.

Maybe call the function sys.getandroidversion()?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28747] Expose SSL_CTX_set_cert_verify_callback

[Steve Dower]

Steve Dower added the comment:

When I was stepping through, this callback avoided all of those lookups, so I 
don't understand how it's being called too late?

This approach basically takes the entire raw certificate and lets the OS do 
whatever it needs. OpenSSL doesn't ever have to crack it open at all (or at 
least when it does, it can assume the whole chain is trusted).

What am I missing here? I've got no doubt I'm missing something, as OpenSSL is 
possibly the most complicated code I've ever seen :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24459] Mention PYTHONFAULTHANDLER in the man page

[Antony Lee]

Antony Lee added the comment:

PYTHONUSERBASE is also missing.

--
nosy: +Antony.Lee

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24459] Mention PYTHONFAULTHANDLER in the man page

[Antony Lee]

Changes by Antony Lee :


--
nosy:  -Antony.Lee

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28732] spawnl crash on windows7

[Steve Dower]

Changes by Steve Dower :


--
assignee:  -> steve.dower
versions: +Python 3.6, Python 3.7 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28732] spawnl crash on windows7

[Roundup Robot]

Roundup Robot added the comment:

New changeset 02f416441def by Steve Dower in branch '3.5':
Issue #28732: Fix crash in os.spawnv() with no elements in args
https://hg.python.org/cpython/rev/02f416441def

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28732] spawnl crash on windows7

[Eryk Sun]

Eryk Sun added the comment:

A ValueError should also be raised when argv[0] is an empty string.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28732] spawnl crash on windows7

[Roundup Robot]

Roundup Robot added the comment:

New changeset 1a9e4b465497 by Steve Dower in branch '3.6':
Issue #28732: Raise ValueError when os.spawn*() is passed an empty tuple of 
arguments
https://hg.python.org/cpython/rev/1a9e4b465497

New changeset 75824899f0dd by Steve Dower in branch 'default':
Issue #28732: Raise ValueError when os.spawn*() is passed an empty tuple of 
arguments
https://hg.python.org/cpython/rev/75824899f0dd

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28732] spawnl crash on windows7

[Roundup Robot]

Roundup Robot added the comment:

New changeset e076ace7b0ff by Steve Dower in branch '3.5':
Issue #28732: Raise ValueError when argv[0] is empty.
https://hg.python.org/cpython/rev/e076ace7b0ff

New changeset af78b33704af by Steve Dower in branch '3.6':
Issue #28732: Raise ValueError when argv[0] is empty
https://hg.python.org/cpython/rev/af78b33704af

New changeset fc6f757e53de by Steve Dower in branch 'default':
Issue #28732: Raise ValueError when argv[0] is empty
https://hg.python.org/cpython/rev/fc6f757e53de

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28732] spawnl crash on windows7

[Steve Dower]

Steve Dower added the comment:

> ValueError should also be raised when argv[0] is an empty string.

Added that too.

Python 3.5 is missing the tests for these functions completely, so I only added 
those to 3.6 and later. Also the original issue was already resolved in 3.6, 
but I tidied up a few other functions that were missing proper handling.

--
stage:  -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27998] Bytes paths now are supported in os.scandir() on Windows

[Steve Dower]

Steve Dower added the comment:

Doc change looks good to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24459] Mention PYTHONFAULTHANDLER in the man page

[Joshua Jay Herman]

Joshua Jay Herman added the comment:

Thanks for pointing out that wasn't in the latest patch this has been corrected.

--
Added file: http://bugs.python.org/file45552/corrected.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28732] spawnl crash on windows7

[Roundup Robot]

Roundup Robot added the comment:

New changeset 2e1fb851dfb4 by Steve Dower in branch '3.6':
Issue #28732: Adds new errors to spawnv emulation for platforms that only have 
fork and execv
https://hg.python.org/cpython/rev/2e1fb851dfb4

New changeset ac6de11fbd50 by Steve Dower in branch 'default':
Issue #28732: Adds new errors to spawnv emulation for platforms that only have 
fork and execv
https://hg.python.org/cpython/rev/ac6de11fbd50

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28747] Expose SSL_CTX_set_cert_verify_callback

[Steve Dower]

Steve Dower added the comment:

Few patch updates - better tests and some docs.

--
Added file: http://bugs.python.org/file45553/28747_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28732] spawnl crash on windows7

[Steve Dower]

Steve Dower added the comment:

Buildbots seem to be happy now so I'm closing the issue.

Feel free to reopen if anyone spots anything in commit review.

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27998] Bytes paths now are supported in os.scandir() on Windows

[Roundup Robot]

Roundup Robot added the comment:

New changeset ac63c70635db by Serhiy Storchaka in branch '3.6':
Issue #27998: Documented bytes paths support on Windows.
https://hg.python.org/cpython/rev/ac63c70635db

New changeset 26195e07fcc5 by Serhiy Storchaka in branch 'default':
Issue #27998: Documented bytes paths support on Windows.
https://hg.python.org/cpython/rev/26195e07fcc5

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27998] Bytes paths now are supported in os.scandir() on Windows

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thanks Steve.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25996] Add support of file descriptor in os.scandir()

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Resolved conflicts in the documentation.

--
Added file: http://bugs.python.org/file45554/os-scandir-fd-3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28715] Check result of PyUnicode_AsUTF8

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28715] Check result of PyUnicode_AsUTF8

[Roundup Robot]

Roundup Robot added the comment:

New changeset 38f321a6be41 by Serhiy Storchaka in branch '3.5':
Issue #28715: Added error checks for PyUnicode_AsUTF8().
https://hg.python.org/cpython/rev/38f321a6be41

New changeset 0bb8ab158042 by Serhiy Storchaka in branch '3.6':
Issue #28715: Added error checks for PyUnicode_AsUTF8().
https://hg.python.org/cpython/rev/0bb8ab158042

New changeset 9cd42ed64bdb by Serhiy Storchaka in branch 'default':
Issue #28715: Added error checks for PyUnicode_AsUTF8().
https://hg.python.org/cpython/rev/9cd42ed64bdb

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28715] Check result of PyUnicode_AsUTF8

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com