[issue28070] 3.6 regression: re.compile not handling flags with X correctly

2016-09-11 Thread Chi Hsuan Yen

Chi Hsuan Yen added the comment:

Thanks for such a quick fix!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28022] SSL releated deprecation for 3.6

2016-09-11 Thread Nick Coghlan

Nick Coghlan added the comment:

Leaving the option of context caching entirely to the caller would definitely 
make things simpler - my main interest is just in avoiding a hard compatibility 
break for folks that aren't doing anything particularly wrong, by which I mean 
specifically cases where a wrap_socket() implementation like this one would 
continue to work for them:

def wrap_socket(sock, *args, *kwds):
return ssl.get_default_context().wrap_socket(sock, *args, **kwds)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26081] Implement asyncio Future in C to improve performance

2016-09-11 Thread INADA Naoki

INADA Naoki added the comment:

Sorry, again. fixed.
Now this passes `./python -m test.test_asyncio`

--
Added file: http://bugs.python.org/file44547/fastfuture.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28066] [Patch] Fix the ability to cross compile Python when doing a rebuild of importlib.h

2016-09-11 Thread Serhiy Storchaka

Changes by Serhiy Storchaka :


--
keywords: +patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

2016-09-11 Thread STINNER Victor

Changes by STINNER Victor :


--
title: Python crashes on 'from test import support' -> Compact dict bug on 
Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26900] Exclude the private API from the stable API

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset d00f15af75ea by Serhiy Storchaka in branch 'default':
Issue #26900: Excluded underscored names and other private API from limited API.
https://hg.python.org/cpython/rev/d00f15af75ea

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue433028] SRE: (?flag:...) is not supported

2016-09-11 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

There was one bug (issue28070), it is now fixed.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23591] enum: Add Flags and IntFlags

2016-09-11 Thread Vedran Čačić

Vedran Čačić added the comment:

> Which means it has methods such as __getitem__, __setitem__, etc., which 
> means those methods can implement whatever is needed to give the namespace 
> the desired semantics (within Python syntax).

Ah, _that_'s what you had in mind. (All this time, I thought _auto_ was just a 
shorter name for _generate_next_value_.:) I'm ok with that. But aren't we then 
back to square one? (Using magic of the same kind as the "declarative style" 
that Raymond pronounced not Pythonic enough.)

Even Raymond says
> As long as _auto_ has been defined somewhere (i.e. from enum import _auto_), 
> it is normal Python

I'm sure he didn't think of the loophole you're currently exploiting. :-D

But anyway, I'm happy. Parentheses are there, so the intuition of calling a 
function to execute code is respected, and if you get out free with this hack, 
it opens a door a bit wider for complete declarative solution in the future.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27932] platform.win32_ver() leaks in 2.7.12

2016-09-11 Thread STINNER Victor

STINNER Victor added the comment:

> pointer-type cache grows without bound

Maybe we should also fix ctypes to use an LRU cache like
@functools.lru_cache? A cache without limit doesn't seem like a good
idea.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26885] Add parsing support for more types in xmlrpc

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset ef63e1c999bd by Serhiy Storchaka in branch 'default':
Issue #26885: xmlrpc now supports unmarshalling additional data types used
https://hg.python.org/cpython/rev/ef63e1c999bd

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26900] Exclude the private API from the stable API

2016-09-11 Thread STINNER Victor

STINNER Victor added the comment:

I didn't follow this discussion, but thanks for the fix Serhiy :-) By
the way, I started a thread on python-dev to discuss a new
organization of the C API for Python 3.7.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26900] Exclude the private API from the stable API

2016-09-11 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Maybe new private functions was added after writing the patch.

And many new public functions was added without guarding by specific 
Py_LIMITED_API value. This is separate issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27213] Rework CALL_FUNCTION* opcodes

2016-09-11 Thread Berker Peksag

Berker Peksag added the comment:

I'm getting segfaults with a77756e480c2 (thanks to 'hg bisect') on Ubuntu 
12.04. I've checked buildbots, but they seem happy.

In test_sys:

test_recursionlimit_recovery (test.test_sys.SysModuleTest) ... Fatal Python 
error: Segmentation fault

In test_runpy:

test_main_recursion_error (test.test_runpy.RunPathTestCase) ... Fatal Python 
error: Segmentation fault

I'm also getting the following error with Serhiy's latest patch:

python: Objects/abstract.c:2385: _PyStack_AsDict: Assertion 
`PyDict_GetItem(kwdict, key) != ((void *)0)' failed.
Aborted (core dumped)
generate-posix-vars failed
make: *** [pybuilddir.txt] Error 1

--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27213] Rework CALL_FUNCTION* opcodes

2016-09-11 Thread STINNER Victor

STINNER Victor added the comment:

Author: Berker Peksag (berker.peksag) * (Python committer)  Date: 
2016-09-11 08:55

Berker: "I'm getting segfaults with a77756e480c2 (thanks to 'hg bisect') on 
Ubuntu 12.04 (...)
test_recursionlimit_recovery (...) test_main_recursion_error (...)"

We should check if the change counts correctly the number of frames.

In callfunc-10.patch, Serhiy modified a counter related to recursion 
limit/number of frames to fix test_traceback (issue #28050). He wrote on the 
review:

"Seems the number 50 is arbitrary. Now we should increase it. Why? This issue 
needs further investigation. Maybe this is a sign of regression."

To me, it's suspicious that we have to modify an unit test. Changing the opcode 
or internals must not have an impact on unit tests on recursion error.

Note: It might also be related to my FASTCALL changes, but you wrote that "hg 
bisect" pointed you to this change.


Berker: "I'm also getting the following error with Serhiy's latest patch: 
python: Objects/abstract.c:2385: _PyStack_AsDict: Assertion 
`PyDict_GetItem(kwdict, key) != ((void *)0)' failed."

This one might be related to the compact dict change.


Note: Just to make be sure that it is not a local issue, please try a "make 
distclean" and make sure that all .pyc files are removed, and then recompile 
Python.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28075] py35 os.stat behavoir different than python 2.7

2016-09-11 Thread ramson

New submission from ramson:

doing os.stat on the directory c:\config.msi gives different results on my 
Windows 10 machine, when done with py27 and py35
--
Python 2.7.12 (v2.7.12:d33e0cf91556, Jun 27 2016, 15:24:40) [MSC v.1500 64 bit 
(AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> os.stat('c:\\config.msi')
nt.stat_result(st_mode=16895, st_ino=0L, st_dev=0L, st_nlink=0, st_uid=0, 
st_gid=0, st_size=2891776L, st_atime=1473584558L, st_mtime=1473584558L, 
st_ctime=1449228297L)

--
Python 3.5.2 (v3.5.2:4def2a2901a5, Jun 25 2016, 22:18:55) [MSC v.1900 64 bit 
(AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> os.stat('c:\\config.msi')
Traceback (most recent call last):
  File "", line 1, in 
PermissionError: [WinError 5] Zugriff verweigert: 'c:\\config.msi'

-> Access denied

--
components: Windows
messages: 275750
nosy: paul.moore, ramson, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: py35 os.stat behavoir different than python 2.7
type: behavior
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15819] Unable to build Python out-of-tree when source tree is readonly.

2016-09-11 Thread Martin Panter

Martin Panter added the comment:

Perhaps there should be a comment explaining that you can’t write to $(srcdir). 
Or even a buildbot that does an out-of-tree build. Every now and then I seem to 
be defending against patches that want to change targets back to $(srcdir).

Also, Trent’s last change, revision 65b3c41052b6, does not seem to work. 
Apparently $abs_srcdir etc are only valid when substituted in a makefile, and 
are not valid in the configure script: 
. I will try 
to post a patch that addresses this to Issue 28066.

--
dependencies: +[Patch] Fix the ability to cross compile Python when doing a 
rebuild of importlib.h
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27213] Rework CALL_FUNCTION* opcodes

2016-09-11 Thread Berker Peksag

Berker Peksag added the comment:

> [...] please try a "make distclean" and make sure that all .pyc files are 
> removed, and then recompile Python.

I forgot to mention that in my earlier comment. I usually run "make distclean" 
before "./configure --with-pydebug; make -s -j" so unfortunately running "make 
distclean" didn't help.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27932] platform.win32_ver() leaks in 2.7.12

2016-09-11 Thread Eryk Sun

Eryk Sun added the comment:

Limiting the pointer-type cache could be a problem. It's expected that 
POINTER() returns a reference to an existing pointer type. ctypes uses Python 
types to ensure compatible C data types. For example:

LP_c_int = ctypes.POINTER(ctypes.c_int)

class LP_c_int_uncached(ctypes._Pointer):
_type_ = ctypes.c_int

>>> arr = (LP_c_int * 2)()
>>> ctypes.POINTER(ctypes.c_int) is LP_c_int
True
>>> arr[0] = ctypes.POINTER(ctypes.c_int)()
>>> arr[1] = LP_c_int_uncached()
Traceback (most recent call last):
  File "", line 1, in 
TypeError: incompatible types, LP_c_int_uncached instance
instead of LP_c_int instance

The docs could warn users that the cache used by ctypes.POINTER(), and 
implicitly by ctypes.pointer(), will leak memory if it's called with a type 
that's created at function scope instead of at module or class-body scope.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28066] [Patch] Fix the ability to cross compile Python when doing a rebuild of importlib.h

2016-09-11 Thread Martin Panter

Martin Panter added the comment:

There are various tricky cases to be considered with the regenerated files like 
importlib.h. One of them is that you are supposed to be able to build Python 
from a read-only source tree. See Issue 15819. Writing files into $(srcdir) 
would break this.

Also, as I just wrote in that bug, the built Python/importlib.h is already 
supposed to be searchable. However the logic seems to be broken. Can you see if 
this patch helps?

--
stage:  -> patch review
Added file: http://bugs.python.org/file44548/srcdir-check.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28066] [Patch] Fix the ability to cross compile Python when doing a rebuild of importlib.h

2016-09-11 Thread Martin Panter

Changes by Martin Panter :


Removed file: http://bugs.python.org/file44548/srcdir-check.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28066] [Patch] Fix the ability to cross compile Python when doing a rebuild of importlib.h

2016-09-11 Thread Martin Panter

Changes by Martin Panter :


Added file: http://bugs.python.org/file44549/srcdir-check.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

2016-09-11 Thread INADA Naoki

INADA Naoki added the comment:

I built acfe53a (git hash).  Then:

c:\Users\inada-n\work\cpython>PCbuild\win32\python_d.exe -m test.test_dict
..
--
Ran 78 tests in 1.262s

OK

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27364] Deprecate invalid escape sequences in str/bytes

2016-09-11 Thread Chi Hsuan Yen

Chi Hsuan Yen added the comment:

Currently the deprecation message is not so useful when fixing lots of files in 
a large project. For example, I have two files foo.py and bar.py:

# foo.py
import bar

# bar.py
print('\d')

It gives:
$ python3.6 -W error foo.py
Traceback (most recent call last):
  File "foo.py", line 1, in 
import bar
DeprecationWarning: invalid escape sequence '\d'

Things are worse when __import__, imp or importlib are involved. I have to add 
some codes to show which module is imported.

It would be better to have at least filenames and line numbers:
$ ./python -W error foo.py
Traceback (most recent call last):
  File "foo.py", line 1, in 
import bar
  File "/home/yen/Projects/cpython/build/bar.py", line 1
print('\d')
 ^
SyntaxError: (deprecated usage) invalid escape sequence '\d'

I have a naive try that prints more information. Raising SyntaxError may not be 
a good idea, anyway.

--
nosy: +Chi Hsuan Yen
Added file: http://bugs.python.org/file44550/verbose-deprecation.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

2016-09-11 Thread STINNER Victor

STINNER Victor added the comment:

Emanuel Barry: What is your Visual Studio (exact) version? I know that there 
are service packs for VS. What is your Windows version?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22493] Deprecate the use of flags not at the start of regular expression

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 31f8af1c3567 by Serhiy Storchaka in branch 'default':
Issue #22493: Inline flags now should be used only at the start of the
https://hg.python.org/cpython/rev/31f8af1c3567

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

2016-09-11 Thread STINNER Victor

STINNER Victor added the comment:

> Emanuel Barry: What is your Visual Studio (exact) version? I know that there 
> are service packs for VS. What is your Windows version?

Oh, same questions for you Naoki in fact :-) It may help to check if
it's related to VS, Windows or if it's something else.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10740] sqlite3 module breaks transactions and potentially corrupts data

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 284676cf2ac8 by Berker Peksag in branch 'default':
Issue #10740: sqlite3 no longer implicitly commit an open transaction before 
DDL statements
https://hg.python.org/cpython/rev/284676cf2ac8

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28055] pyhash's siphash24 assumes alignment of the data pointer

2016-09-11 Thread Antti Haapala

Antti Haapala added the comment:

There is no need to ifdef anything, the memcpy is the only correct way to do 
it. As memcpy is also a reserved identifier in C, the compiler can and will 
optimize this into a 64-bit access on those platforms where it can be safely 
done so (x86 for example), e.g. GCC compiles

uint64_t func(char *buf) {
uint64_t rv;
memcpy(&rv, buf+3, sizeof(rv));
return rv;
}

into

movq3(%rdi), %rax
ret

On Linux 64-bit ABI.

--
nosy: +ztane

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27991] In the argparse howto there is a misleading sentence about store_true

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 0e45cd7859ec by Berker Peksag in branch '3.5':
Issue #27991: Remove incorrect sentence about store_true
https://hg.python.org/cpython/rev/0e45cd7859ec

New changeset 9a75fa28bd0a by Berker Peksag in branch 'default':
Issue #27991: Merge from 3.5
https://hg.python.org/cpython/rev/9a75fa28bd0a

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27991] In the argparse howto there is a misleading sentence about store_true

2016-09-11 Thread Berker Peksag

Berker Peksag added the comment:

Good catch, thanks!

--
nosy: +berker.peksag
resolution:  -> fixed
stage:  -> resolved
status: open -> closed
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27952] Finish converting fixcid.py from regex to re

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 740e43eb8138 by Martin Panter in branch '2.7':
Issue #27952: Get fixcid.py working with the re module
https://hg.python.org/cpython/rev/740e43eb8138

New changeset ca68bb597df9 by Martin Panter in branch '3.5':
Issue #27952: Get fixcid.py working with the re module
https://hg.python.org/cpython/rev/ca68bb597df9

New changeset 8dde3dcab1e8 by Martin Panter in branch 'default':
Issue #27952: Merge fixcid.py from 3.5
https://hg.python.org/cpython/rev/8dde3dcab1e8

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

2016-09-11 Thread INADA Naoki

INADA Naoki added the comment:

I noticed I tested win32 mode.  I'll rebuild on amd64 mode.

> Oh, same questions for you Naoki in fact :-)

I don't know about how to describe exist version of my Windows environment. Is 
these enough?

Windows 10 Home (with Anniversary Update)
10.0.14393 build 14393

Microsoft Visual Studio Community 2015
Version 14.0.25425.01 Update 3
Microsoft .NET Framework
Version 4.6.01586
Installed Version: Community
Microsoft Visual C++ 2015


>cl /?
Microsoft (R) C/C++ Optimizing Compiler Version 19.00.24213.1 for x86

C:\Users\inada-n\work\cpython>PCbuild\win32\python_d.exe
Python 3.6.0a4+ (default, Sep 11 2016, 18:22:14) [MSC v.1900 32 bit (Intel)] on 
win32

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27213] Rework CALL_FUNCTION* opcodes

2016-09-11 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

> python: Objects/abstract.c:2385: _PyStack_AsDict: Assertion
> `PyDict_GetItem(kwdict, key) != ((void *)0)' failed. Aborted (core dumped)
> generate-posix-vars failed
> make: *** [pybuilddir.txt] Error 1

Ah, it's my fault. I didn't test the latest patch with debug build. Here should 
be == instead of !=. Could you please test updated patch? Unfortunately I can's 
reproduce crashes in test_sys and test_runpy (on 32-bit Linux).

--
Added file: http://bugs.python.org/file44551/callfunc-12.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28022] SSL releated deprecation for 3.6

2016-09-11 Thread Martin Panter

Martin Panter added the comment:

New test failure when using -Werror:

==
ERROR: test_local_bad_hostname (test.test_httplib.HTTPSTest)
--
Traceback (most recent call last):
  File "/media/disk/home/proj/python/cpython/Lib/test/test_httplib.py", line 
1646, in test_local_bad_hostname
check_hostname=True)
  File "/media/disk/home/proj/python/cpython/Lib/http/client.py", line 1373, in 
__init__
DeprecationWarning, 2)
DeprecationWarning: key_file, cert_file and check_hostname are deprecated, use 
a custom context instead.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15819] Unable to build Python out-of-tree when source tree is readonly.

2016-09-11 Thread Kubilay Kocak

Kubilay Kocak added the comment:

@Martin Maybe Zach (nosey'd) can help us get an out-of-tree builder set up?

If this is relevant for 3.5+, versions should be updated accordingly.

--
nosy: +zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

2016-09-11 Thread INADA Naoki

INADA Naoki added the comment:

amd64 result

c:\Users\inada-n\work\cpython>PCbuild\amd64\python_d.exe -m test.test_dict
..
--
Ran 78 tests in 1.498s

OK

c:\Users\inada-n\work\cpython>PCbuild\amd64\python_d.exe
Python 3.6.0a4+ (default, Sep 11 2016, 19:10:48) [MSC v.1900 64 bit (AMD64)] on 
win32
Type "help", "copyright", "credits" or "license" for more information.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27213] Rework CALL_FUNCTION* opcodes

2016-09-11 Thread Berker Peksag

Berker Peksag added the comment:

Thanks, Serhiy.

test_recursionlimit_recovery in test_sys passed, but now I'm getting the 
following failure:

FAIL: test_recursionlimit_fatalerror (test.test_sys.SysModuleTest)

I modified test_recursionlimit_fatalerror to use subTest() and it looks like 
the test passed when sys.setrecursionlimit(50). See i=1000 in the following 
output:

==
FAIL: test_recursionlimit_fatalerror (test.test_sys.SysModuleTest) (i=1000)
--
Traceback (most recent call last):
  File "/home/berker/hacking/cpython/default/Lib/test/test_sys.py", line 283, 
in test_recursionlimit_fatalerror
err)
AssertionError: b'Fatal Python error: Cannot recover from stack overflow' not 
found in b''

--

test_runpy still segfaults:

test_main_recursion_error (test.test_runpy.RunPathTestCase) ... Fatal Python 
error: Segmentation fault

I wrote a quick and dirty reproducer for this. I can attach here if you think 
it would be useful for debugging.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27129] Wordcode, part 2

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset dd046963bd42 by Serhiy Storchaka in branch 'default':
Issue #27129: Replaced wordcode related magic constants with macros.
https://hg.python.org/cpython/rev/dd046963bd42

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28076] Variable annotations should be mangled for private names

2016-09-11 Thread Ivan Levkivskyi

New submission from Ivan Levkivskyi:

Variable annotations for private names are stored in __annotations__ without 
name mangling. This is inconsistent with how function annotations behave:

class C:
   def meth(__x: int): ...

assert C.meth.__annotations__ == {'_C__x': int}

The attached patch fixes variable annotations to behave in the same way:

class C:
__foo: int = 1

assert C.__dict__['_C_foo'] == 1
assert C.__annotations__['_C__foo'] == int

--
components: Interpreter Core
files: mangle-ann.diff
keywords: patch
messages: 275772
nosy: gvanrossum, levkivskyi
priority: normal
severity: normal
status: open
title: Variable annotations should be mangled for private names
type: behavior
versions: Python 3.6
Added file: http://bugs.python.org/file44552/mangle-ann.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27129] Wordcode, part 2

2016-09-11 Thread Berker Peksag

Berker Peksag added the comment:

>From 
>http://buildbot.python.org/all/builders/s390x%20Debian%203.x/builds/1811/steps/compile/logs/stdio
> (I also saw the same compile error on another Linux boxes)

_freeze_importlib: Python/peephole.c:524: PyCode_Optimize: Assertion 
`((codestr[i]) >> 8) == 100' failed.
Makefile:735: recipe for target 'Python/importlib.h' failed
make: *** [Python/importlib.h] Aborted

--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25497] Rewrite test_robotparser

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 2193bd6f020c by Berker Peksag in branch 'default':
Issue #25497: Rewrite test_robotparser to use a class based design
https://hg.python.org/cpython/rev/2193bd6f020c

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25497] Rewrite test_robotparser

2016-09-11 Thread Berker Peksag

Changes by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25671] Fix venv activate.fish to maintain $status

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset f6125944ffb8 by Vinay Sajip in branch '3.5':
Fixes #25671: Updated prompt handling in activate.fish.
https://hg.python.org/cpython/rev/f6125944ffb8

New changeset ed34b93519ba by Vinay Sajip in branch 'default':
Closes #25671: Merged fix from 3.5.
https://hg.python.org/cpython/rev/ed34b93519ba

--
nosy: +python-dev
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25400] robotparser doesn't return crawl delay for default entry

2016-09-11 Thread Berker Peksag

Berker Peksag added the comment:

I've now updated Lib/test/test_robotparser.py (issue 25497) Peter, do you have 
time to update your patch? Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10740] sqlite3 module breaks transactions and potentially corrupts data

2016-09-11 Thread Berker Peksag

Changes by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28075] os.stat fails when access is denied

2016-09-11 Thread Eryk Sun

Eryk Sun added the comment:

Python 3's os.stat tries to open a handle for the file or directory in order to 
call GetFileInformationByHandle. Opening a file handle via CreateFile requests 
at least FILE_READ_ATTRIBUTES and SYNCHRONIZE access when it calls 
NtCreateFile. If access is denied, os.stat is supposed to fall back on the 
basic WIN32_FIND_DATA information from FindFirstFile. However, it's not working 
as intended. For example:

>>> import os
>>> os.mkdir('test')
>>> os.system('icacls test /deny Users:(S,RA)')
processed file: test
Successfully processed 1 files; Failed processing 0 files
0

>>> os.stat('test')
Traceback (most recent call last):
  File "", line 1, in 
PermissionError: [WinError 5] Access is denied: 'test'

The problem is that it's mistakenly checking for ERROR_SHARING_VIOLATION 
instead of ERROR_ACCESS_DENIED. Technically, getting a sharing violation should 
be impossible here. That only applies to requesting execute (traverse), read 
(list), write (add file), append (add subdirectory), or delete access for the 
contents of the file or directory, not its metadata.

After modifying the code to instead check for ERROR_ACCESS_DENIED, os.stat 
correctly falls back on using the file attributes from the WIN32_FIND_DATA:

>>> os.stat('test')
os.stat_result(st_mode=16895, st_ino=0, st_dev=0, st_nlink=0, 
st_uid=0, st_gid=0, st_size=0, st_atime=1473589600, 
st_mtime=1473589600, st_ctime=1473589600)

--
nosy: +eryksun
title: py35 os.stat behavoir different than python 2.7 -> os.stat fails when 
access is denied
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27952] Finish converting fixcid.py from regex to re

2016-09-11 Thread Martin Panter

Changes by Martin Panter :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

2016-09-11 Thread Emanuel Barry

Emanuel Barry added the comment:

Huh, weird. I'm running a win32 build on a 64 bits machine, with VS2015. I 
didn't have time to test on a clean checkout, I will do that first thing when 
I'm back home tonight. I hope I did something wrong and there really isn't any 
issue :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26533] logging.config does not allow disable_existing_loggers=True

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 65a1abf4b432 by Vinay Sajip in branch '3.5':
Closed #26533: expanded on behaviour of logging.config.listen().
https://hg.python.org/cpython/rev/65a1abf4b432

New changeset abd744bf62fb by Vinay Sajip in branch 'default':
Closed #26533: Merged update from 3.5.
https://hg.python.org/cpython/rev/abd744bf62fb

--
nosy: +python-dev
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27129] Wordcode, part 2

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset b49a938eaa31 by Serhiy Storchaka in branch 'default':
Fixed refactoring bug in dd046963bd42 (issue27129).
https://hg.python.org/cpython/rev/b49a938eaa31

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27129] Wordcode, part 2

2016-09-11 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Thanks Berker!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28036] Remove unused pysqlite_flush_statement_cache function

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 0bd7fe9b0bd7 by Berker Peksag in branch 'default':
Issue #28036: Remove unused pysqlite_flush_statement_cache function
https://hg.python.org/cpython/rev/0bd7fe9b0bd7

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28036] Remove unused pysqlite_flush_statement_cache function

2016-09-11 Thread Berker Peksag

Changes by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20100] epoll docs are not clear with regards to CLOEXEC.

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 9023c4f5d467 by Berker Peksag in branch '3.5':
Issue #20100: Clarify that passing flags to epoll() has no effect
https://hg.python.org/cpython/rev/9023c4f5d467

New changeset d2b5806fa770 by Berker Peksag in branch 'default':
Issue #20100: Merge from 3.5
https://hg.python.org/cpython/rev/d2b5806fa770

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27213] Rework CALL_FUNCTION* opcodes

2016-09-11 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Please attach a reproducer Berker. I still can't reproduce crashes. Maybe it 
depends on platform or installed third-party module or Python command line 
options.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24454] Improve the usability of the match object named group API

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset ac0643314d12 by Eric V. Smith in branch 'default':
Issue 24454: Improve the usability of the re match object named group API
https://hg.python.org/cpython/rev/ac0643314d12

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24454] Improve the usability of the match object named group API

2016-09-11 Thread Eric V. Smith

Changes by Eric V. Smith :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28065] Update Windows build to xz-5.2.2

2016-09-11 Thread Tim Golden

Tim Golden added the comment:

Applies, builds & tests ok for me for Win32 Release build (ie build.bat 
-e) on Win 8.1 x64.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20100] epoll docs are not clear with regards to CLOEXEC.

2016-09-11 Thread Berker Peksag

Berker Peksag added the comment:

Here is an updated patch for Modules/selectmodule.c. It would be nice to get a 
code review.

--
Added file: http://bugs.python.org/file44553/selectmodule.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24454] Improve the usability of the match object named group API

2016-09-11 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Please document this feature in What's News Eric.

There is no need to add the __getitem__ method explicitly the the list of 
methods match_methods. It would be added automatically.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24454] Improve the usability of the match object named group API

2016-09-11 Thread Eric V. Smith

Eric V. Smith added the comment:

I added a note in Misc/NEWS. Is that not what you mean?

I'll look at match_methods.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24454] Improve the usability of the match object named group API

2016-09-11 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

I meant Doc/whatsnew/3.6.rst.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

2016-09-11 Thread Steve Dower

Steve Dower added the comment:

It's unlikely, but we also print out the UCRT version at the end of the build 
process (with a warning if you need to update the WinSDK).

I built and tested a number of times with this change though. If suggest hg 
purge and rebuild to make sure everything is clean.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24454] Improve the usability of the match object named group API

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 3265247e08f0 by Eric V. Smith in branch 'default':
Issue 24454: Added whatsnew entry, removed __getitem__ from match_methods. 
Thanks Serhiy Storchaka.
https://hg.python.org/cpython/rev/3265247e08f0

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24454] Improve the usability of the match object named group API

2016-09-11 Thread Eric V. Smith

Eric V. Smith added the comment:

Fixed. Thanks, Serhiy.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24454] Improve the usability of the match object named group API

2016-09-11 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

./Modules/_sre.c:2425:14: warning: ‘match_getitem_doc’ defined but not used [-
Wunused-variable]

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28075] os.stat fails when access is denied

2016-09-11 Thread Eryk Sun

Eryk Sun added the comment:

I overlooked attempting to open a paging-file for any access, which is hard 
coded as a sharing violation. The attached patch checks for both cases.

--
keywords: +patch
Added file: http://bugs.python.org/file44554/issue_28075_01.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23105] os.O_SHLOCK and os.O_EXLOCK are not available on Linux

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 5ca4c545dfe4 by Vinay Sajip in branch '2.7':
Issue #23105: Updated documentation on open() flag constants.
https://hg.python.org/cpython/rev/5ca4c545dfe4

New changeset f1427491a8a5 by Vinay Sajip in branch '3.5':
Issue #23105: Updated documentation on open() flag constants.
https://hg.python.org/cpython/rev/f1427491a8a5

New changeset 64610bcd326f by Vinay Sajip in branch 'default':
Closes #23105: Merged update from 3.5.
https://hg.python.org/cpython/rev/64610bcd326f

--
nosy: +python-dev
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24454] Improve the usability of the match object named group API

2016-09-11 Thread Eric V. Smith

Eric V. Smith added the comment:

On 9/11/2016 10:05 AM, Serhiy Storchaka wrote:
>
> Serhiy Storchaka added the comment:
>
> ./Modules/_sre.c:2425:14: warning: ‘match_getitem_doc’ defined but not used [-
> Wunused-variable]

Not in Visual Studio!

Standby.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24454] Improve the usability of the match object named group API

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 9eb38e0f1cad by Eric V. Smith in branch 'default':
Issue 24454: Removed unused match_getitem_doc.
https://hg.python.org/cpython/rev/9eb38e0f1cad

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28066] [Patch] Fix the ability to cross compile Python when doing a rebuild of importlib.h

2016-09-11 Thread Ed Schouten

Ed Schouten added the comment:

It does. I can now cross build Python for CloudABI by copying importlib.h and 
importlib_external.h from the native build directory to the target build 
directory. Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28077] Fix find_empty_slot in dictobject

2016-09-11 Thread Xiang Zhang

New submission from Xiang Zhang:

find_empty_slot will also do *value_addr = &mp->ma_values[-1] if it encounters 
a split dict.

--
components: Interpreter Core
files: find_empty_slot.patch
keywords: patch
messages: 275800
nosy: haypo, methane, xiang.zhang
priority: normal
severity: normal
stage: patch review
status: open
title: Fix find_empty_slot in dictobject
type: crash
versions: Python 3.6
Added file: http://bugs.python.org/file44555/find_empty_slot.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23591] enum: Add Flags and IntFlags

2016-09-11 Thread Ethan Furman

Ethan Furman added the comment:

>> Which means it has methods such as __getitem__, __setitem__, etc.,
>> which means those methods can implement whatever is needed to give
>> the namespace the desired semantics (within Python syntax).

> Ah, _that_'s what you had in mind. (All this time, I thought _auto_
> was just a shorter name for _generate_next_value_.:) I'm ok with that.
> But aren't we then back to square one? (Using magic of the same kind
> as the "declarative style" that Raymond pronounced not Pythonic enough.)

Not at all.  The concern with that proposal (issue26988: AutoEnum via 
completely omitting values of any kind) was the transformation of a NameError 
into a value.  The current method is taking a unique object and transforming 
that into a value, which is entirely analagous to what Enum already does.

Besides being convenient, it's also necessary to present a cohesive, non-leaky 
abstraction to the user where Flag is concerned: using ints as the flag values 
is entirely an implementation detail, but without auto the user would be forced 
to manage that implementation detail when creating the Flag, which negates much 
of Flag's value.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23591] enum: Add Flags and IntFlags

2016-09-11 Thread Ethan Furman

Ethan Furman added the comment:

Many thanks to everyone for their input and help.

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28078] Silence resource warnings in test_socket

2016-09-11 Thread Xiang Zhang

New submission from Xiang Zhang:

test_aead_aes_gcm (test.test_socket.LinuxKernelCryptoAPI) ... 
/home/angwer/cpython/Lib/unittest/case.py:600: ResourceWarning: unclosed 

  testMethod()
skipped "('[Errno 2] No such file or directory', 'aead', 'gcm(aes)')"
test_sendmsg_afalg_args (test.test_socket.LinuxKernelCryptoAPI) ... 
/home/angwer/cpython/Lib/unittest/case.py:600: ResourceWarning: unclosed 

  testMethod()
ok

Christian, after issue27744, there are 2 resource warnings in test_socket. 
test_socket.patch eliminates them.

--
components: Tests
messages: 275803
nosy: christian.heimes, xiang.zhang
priority: normal
severity: normal
stage: patch review
status: open
title: Silence resource warnings in test_socket
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28078] Silence resource warnings in test_socket

2016-09-11 Thread Xiang Zhang

Changes by Xiang Zhang :


--
keywords: +patch
Added file: http://bugs.python.org/file44556/test_socket.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26331] PEP 515: Tokenizer: allow underscores for grouping in numeric literals

2016-09-11 Thread Georg Brandl

Georg Brandl added the comment:

Thanks Brett!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27715] call-matcher breaks if a method is mocked with spec=True

2016-09-11 Thread Eli_B

Changes by Eli_B :


--
nosy: +Eli_B

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28078] Silence resource warnings in test_socket

2016-09-11 Thread Christian Heimes

Christian Heimes added the comment:

Thanks! The first fix looks good. For the second one I'd rather wrap the test 
body in a with statement:

def test_sendmsg_afalg_args(self):
sock = socket.socket(socket.AF_ALG, socket.SOCK_SEQPACKET, 0)
with sock:
with self.assertRaises(TypeError):
sock.sendmsg_afalg()
...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27213] Rework CALL_FUNCTION* opcodes

2016-09-11 Thread Влад Ключкей

Changes by Влад Ключкей :


--
hgrepos: +354
Added file: http://bugs.python.org/file44557/IMG_20160830_174452.jpg

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28078] Silence resource warnings in test_socket

2016-09-11 Thread Xiang Zhang

Xiang Zhang added the comment:

It's your code. Do what you like. :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27213] Rework CALL_FUNCTION* opcodes

2016-09-11 Thread Serhiy Storchaka

Changes by Serhiy Storchaka :


Removed file: http://bugs.python.org/file44557/IMG_20160830_174452.jpg

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28076] Variable annotations should be mangled for private names

2016-09-11 Thread Guido van Rossum

Guido van Rossum added the comment:

Thanks! I think you have a PEP update already waiting for me?

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28076] Variable annotations should be mangled for private names

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 1c2a4f29e1ab by Guido van Rossum in branch 'default':
Issue #28076: Variable annotations should be mangled for private names.
https://hg.python.org/cpython/rev/1c2a4f29e1ab

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28079] Update typing and test typing from python/typing repo

2016-09-11 Thread Ivan Levkivskyi

New submission from Ivan Levkivskyi:

Here is the patch for 3.5

--
files: typing-patch.diff
keywords: patch
messages: 275809
nosy: gvanrossum, levkivskyi
priority: normal
severity: normal
status: open
title: Update typing and test typing from python/typing repo
Added file: http://bugs.python.org/file44558/typing-patch.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28079] Update typing and test typing from python/typing repo

2016-09-11 Thread Ivan Levkivskyi

Changes by Ivan Levkivskyi :


--
components: +Library (Lib)
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28079] Update typing and test typing from python/typing repo

2016-09-11 Thread Ivan Levkivskyi

Ivan Levkivskyi added the comment:

I have noticed that some code could be simplified, since it is 
backward-compatible even with 3.2, but I think it is easiest to keep the source 
here in sync with what is on python/typing.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28079] Update typing and test typing from python/typing repo

2016-09-11 Thread Guido van Rossum

Guido van Rossum added the comment:

Um, if I apply this to 3.5 it works, but if I then merge forward to 3.6 
(default) I get merge conflicts. I'll have to sort that out tonight.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28079] Update typing and test typing from python/typing repo

2016-09-11 Thread Ivan Levkivskyi

Ivan Levkivskyi added the comment:

I could guess this is because some changes have been already integrated by 
patch that implemented PEP 526.

If this would help here is a separate patch that should apply cleanly to 3.6

--
Added file: http://bugs.python.org/file44559/typing-patch-3.6.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27405] Ability to trace Tcl commands executed by Tkinter

2016-09-11 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Here is more mature patch. Now you can set tracing function with the 
tkinter.Tk.settrace() method. Tracing function takes the single argument -- a 
tuple containing the command and arguments. If set global tkinter.debug to 
True, the tracing function of newly created Tk object will be set to 
tkinter.print_command that prints the command to stdout.

--
Added file: http://bugs.python.org/file44560/tkinter_trace_tcl2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28008] PEP 530, asynchronous comprehensions implementation

2016-09-11 Thread Ned Deily

Changes by Ned Deily :


--
priority: release blocker -> 
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28078] Silence resource warnings in test_socket

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset c515bc3b29bf by Christian Heimes in branch 'default':
Issue #28078: Silence resource warnings in test_socket. Initial patch by Xiang 
Zhang, thanks
https://hg.python.org/cpython/rev/c515bc3b29bf

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28078] Silence resource warnings in test_socket

2016-09-11 Thread Christian Heimes

Christian Heimes added the comment:

Thanks for the report and your patch. Let's watch the build bot.

--
stage: patch review -> commit review
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28022] SSL releated deprecation for 3.6

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 2e541e994927 by Christian Heimes in branch 'default':
Issue 28022: Catch deprecation warning in test_httplib, reported by Martin 
Panter
https://hg.python.org/cpython/rev/2e541e994927

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28022] SSL releated deprecation for 3.6

2016-09-11 Thread Christian Heimes

Christian Heimes added the comment:

Thanks for the report. "./python -Werror -m test -uall test_httplib" is now 
passing for me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28078] Silence resource warnings in test_socket

2016-09-11 Thread Xiang Zhang

Xiang Zhang added the comment:

Christian, you forget a : after else.

--
status: pending -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28078] Silence resource warnings in test_socket

2016-09-11 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 8b655668c04f by Christian Heimes in branch 'default':
Issue #28078: Add missing colon
https://hg.python.org/cpython/rev/8b655668c04f

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28068] Error in freeze.py due to unguarded sys.abiflags usage under Windows

2016-09-11 Thread Gevorg Voskanyan

Gevorg Voskanyan added the comment:

Thanks for the patch! It makes the error go away for me, but only because 
`ishome` is True in my case. Were it False, it would fail the same way on the 
line containing sys.abiflags .
I think this line in the patch:
flagged_version = version + sys.abiflags
should be changed to:
flagged_version = version + abiflags
That way I get no errors regardless of the value of `ishome`.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28078] Silence resource warnings in test_socket

2016-09-11 Thread Christian Heimes

Christian Heimes added the comment:

Oh heck! I'm not sure what happened here. The test was passing locally. I can 
only assume that I accidentally modified the file between test run and commit.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27701] [posixmodule] [Refactoring patch] Simply call into *at() functions unconditionally when present

2016-09-11 Thread Ed Schouten

Ed Schouten added the comment:

Hmmm... Taking a second look at my patch: I still think it's conceptually a 
good idea to pursue this, but I think it may be wiser to first focus on the 
bits that are strictly necessary from my side. The patch that I've posted 
previously has the disadvantage that it's hard to grasp what belongs to gether.

Attached is a trimmed down version of my original patch that only focuses on 
patching up the os_*_impl()s to use the *at() functions exclusively if 
possible. Hopefully this change should be fairly easy to understand.

Any thoughts?

--
Added file: http://bugs.python.org/file44561/patch-issue27701

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   3   >