[issue27342] Clean up some Py_XDECREFs in rangeobject.c and bltinmodule.c

[Xiang Zhang]

New submission from Xiang Zhang:

Some Py_XDECREFs in rangeobject.c and bltinmodule.c are not necessary. 
Py_DECREF is enough. Clean up them.

--
files: cleanup_some_xdecrefs.patch
keywords: patch
messages: 268711
nosy: xiang.zhang
priority: normal
severity: normal
status: open
title: Clean up some Py_XDECREFs in rangeobject.c and bltinmodule.c
Added file: http://bugs.python.org/file43429/cleanup_some_xdecrefs.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

[Christoph Gohlke]

Christoph Gohlke added the comment:

FWIW, this could be a build issue:
1) `_ssl.OPENSSL_VERSION` for the 2.7.12rc1 amd64 binaries is "OpenSSL 1.0.2d 9 
Jul 2015", not OpenSSL 1.0.2g as expected from the changelog at 
.
2) Rebuilding _ssl.pyd against openssl-1.0.2h fixes this issue for me (no 
crash).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27343] Incorrect error message for conflicting initializers of ctypes structure

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

>>> from ctypes import *
>>> class POINT(Structure):
... _fields_ = [("x", c_int), ("y", c_int)]
... 
>>> POINT(2, 3, x=4)
Traceback (most recent call last):
  File "", line 1, in 
TypeError: duplicate values for field '???'

The name of conflicting field is not output correctly because it is expected to 
be bytes.

Proposed patch makes the error message always contain the name of conflicting 
field.

--
components: Library (Lib), ctypes
files: ctypes_conflictin_initializers_error_message.patch
keywords: patch
messages: 268713
nosy: amaury.forgeotdarc, belopolsky, meador.inge, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Incorrect error message for conflicting initializers of ctypes structure
type: behavior
versions: Python 3.5, Python 3.6
Added file: 
http://bugs.python.org/file43430/ctypes_conflictin_initializers_error_message.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27342] Clean up some Py_XDECREFs in rangeobject.c and bltinmodule.c

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27330] Possible leaks in ctypes

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you for your review Martin! Committed with your fixes.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27333] validate_step in rangeobject.c, incorrect code logic but right result

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18751] A manager's server never joins its threads

[Ned Deily]

Changes by Ned Deily :


--
nosy: +davin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27273] subprocess.run(cmd, input='text') should pass universal_newlines=True to Popen

[Ned Deily]

Changes by Ned Deily :


--
nosy: +gregory.p.smith
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27343] Incorrect error message for conflicting initializers of ctypes structure

[Berker Peksag]

Changes by Berker Peksag :


--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12319] [http.client] HTTPConnection.request not support "chunked" Transfer-Encoding to send data

[Martin Panter]

Martin Panter added the comment:

FYI instead of changing the helper into a static method, I think you could have 
just called http.client._get_content_length().

I don’t understand why we need the new encode_chunked=True flag. Can’t 
urllib.request leave the Transfer-Encoding field up to http.client? Yes it does 
set Content-Length in the Request object, but it does not set Accept-Encoding 
nor Connection. Also, it looks like you can still get chunked encoding if you 
set encode_chunked=False, which is confusing.

I left some review comments, and I think some of my earlier comments still 
apply. I still find it confusing the variety of objects accepted, and the 
different levels that the APIs work on. Hopefully it will become less confusing 
if we can figure out all the corner cases. I do think unifying the data types 
accepted by urlopen() and HTTPConnection is good, though I am not sure allowing 
text in urlopen() is the right direction.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27307] string.Formatter does not support key/attribute access on unnumbered fields

[Ned Deily]

Changes by Ned Deily :


--
nosy: +eric.smith
stage:  -> patch review
versions:  -Python 2.7, Python 3.2, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27343] Incorrect error message for conflicting initializers of ctypes structure

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


Removed file: 
http://bugs.python.org/file43430/ctypes_conflictin_initializers_error_message.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27336] --without-threads build fails due to undeclared _PyGILState_check_enabled

[Roundup Robot]

Roundup Robot added the comment:

New changeset 2baaf7e31b13 by Berker Peksag in branch 'default':
Issue #27336: Fix compilation failures --without-threads
https://hg.python.org/cpython/rev/2baaf7e31b13

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27343] Incorrect error message for conflicting initializers of ctypes structure

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


Added file: 
http://bugs.python.org/file43431/ctypes_conflictin_initializers_error_message.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27336] --without-threads build fails due to undeclared _PyGILState_check_enabled

[Berker Peksag]

Berker Peksag added the comment:

Thanks for the report.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27336] --without-threads build fails due to undeclared _PyGILState_check_enabled

[Roundup Robot]

Roundup Robot added the comment:

New changeset cbe977fd306f by Victor Stinner in branch 'default':
Issue #27336: Fix compilation on Windows
https://hg.python.org/cpython/rev/cbe977fd306f

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23360] Content-Type when sending data with urlopen()

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +orsenthil, r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15243] Misleading documentation for __prepare__

[Jaysinh shukla]

Jaysinh shukla added the comment:

Submitting patch according to this 
(http://bugs.python.org/issue15243#msg268356) message. Thanks!

--
keywords: +patch
nosy: +jaysinh.shukla
Added file: 
http://bugs.python.org/file43432/issue15243_diff_python3.5_3.6_v1.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27213] Rework CALL_FUNCTION* opcodes

[Demur Rumed]

Demur Rumed added the comment:

I've been working on this, may have the ceval portion mostly worked out but 
can't test until I finish the compile portion. Haven't had time this week, will 
have time to focus this weekend

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27298] redundant iteration over digits in _PyLong_AsUnsignedLongMask

[Oren Milman]

Oren Milman added the comment:

I did some micro-benchmarking, and it looks like bad news for my patch.

I wrote a simple C extension in order to call PyLong_AsUnsignedLongMask and 
PyLong_AsUnsignedLongLongMask from Python code (attached).
Then I ran the following micro-benchmarks using both the default CPython branch 
and my patched CPython:
1. small ints:
python.exe -m timeit -s "import capiWrapper" "print('bug') if any(i != 
capiWrapper.asUnsignedLongMaskWrapper(i) for i in range(10 ** 6)) else None"
python.exe -m timeit -s "import capiWrapper" "print('bug') if any(i != 
capiWrapper.asUnsignedLongLongMaskWrapper(i) for i in range(10 ** 6)) else None"
with the following results:
asUnsignedLongMaskWrapper:
default: 312 msec, patched: 353 msec
asUnsignedLongLongMaskWrapper:
default: 319 msec, patched: 356 msec

2. big ints:
python.exe -m timeit -s "import capiWrapper; bigInt = 10 ** 1000" "print('bug') 
if any((i & 0x) != capiWrapper.asUnsignedLongMaskWrapper(i) for i in 
range(bigInt, bigInt + 1)) else None"
python.exe -m timeit -s "import capiWrapper; bigInt = 10 ** 1000" "print('bug') 
if any((i & 0x) != capiWrapper.asUnsignedLongLongMaskWrapper(i) 
for i in range(bigInt, bigInt + 1)) else None"
with the following results:
when bigInt = 10 ** 1000:
asUnsignedLongMaskWrapper:
default: 23.1 msec, patched: 21.5 msec
asUnsignedLongLongMaskWrapper:
default: 24.1 msec, patched: 21.7 msec

when bigInt = 10 ** 150:
asUnsignedLongMaskWrapper:
default: 7.72 msec, patched: 7.82 msec
asUnsignedLongLongMaskWrapper:
default: 8.03 msec, patched: 7.99 msec


To sum it up, my patch degrades performance for ints smaller than 
(approximately) 10 ** 150, and improves performance for bigger ints. 

Seems to me like it doesn't worth it. 
I attached the patches diff file anyway, for the sake of documentation.

==

That leaves us with the proposed changes in Modules/_testcapimodule.c.
The diff file for these (hopefully my final diff file for this issue) is also 
attached.

--
Added file: http://bugs.python.org/file43433/capiWrapperModule.c

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27298] redundant iteration over digits in _PyLong_AsUnsignedLongMask

[Oren Milman]

Changes by Oren Milman :


Added file: http://bugs.python.org/file43434/badMicroBenchProposedPatches.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27298] redundant iteration over digits in _PyLong_AsUnsignedLongMask

[Oren Milman]

Changes by Oren Milman :


Added file: http://bugs.python.org/file43435/proposedPatches.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

[Robert Haschke]

Robert Haschke added the comment:

I uploaded a simple example to illustrate the tremendous performance boost. 
Obviously, the example exploits the caching improvement as much as possible: 
The code assembles a XML document by inserting new nodes before the last one...
These are the timing results:
$ python minidom_example.py old new
oldtime for 5000 iterations: 18.422152
newtime for 5000 iterations: 0.129384

$ python minidom_example.py old new
oldtime for 1 iterations: 68.305351
newtime for 1 iterations: 0.142071

You see the quadratic increase of time...
IMHO, this is clearly a (performance) bug and really many people in the ROS 
community are affected. Hence, I hope that this patch will find its way into 
some python versions currently used by standard Linux distributions.

--
Added file: http://bugs.python.org/file43436/minidom_example.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27333] validate_step in rangeobject.c, incorrect code logic but right result

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Current code is valid, since neither PY_SSIZE_MAX nor PY_SSIZE_MIN equal to 0.

But testing on 0 can be simpler. Following patch simplifies the code.

--
nosy: +mark.dickinson
stage:  -> patch review
type: behavior -> enhancement
versions:  -Python 2.7, Python 3.5
Added file: http://bugs.python.org/file43437/range_validate_step.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27342] Clean up some Py_XDECREFs in rangeobject.c and bltinmodule.c

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Mostly good except longrangeiter_dealloc().

--
components: +Interpreter Core
nosy: +mark.dickinson
stage:  -> patch review
type:  -> enhancement
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18373] let code force str(bytes) to raise an exception

[Daniel Holth]

Daniel Holth added the comment:

What if we changed it so that Python code could only disable str_bytes() 
process-wide, editing the original flag? Would that be fatal to debuggers and 
the repl?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you for your example Robert.

If modify your example for inserting new nodes before the first one, it shows 
the slowdown with your patch.

$ ./python minidom_example2.py old new
oldtime for 5000 iterations: 0.189058
newtime for 5000 iterations: 0.254402

The question is whether your case is enough common to compensate the slowdown 
of other cases.

Yest one disadvantage of your patch is increasing memory consumption (this can 
be partly compensated by adding '_index_cache' to slots).

Have you considered the option of using Python 3? In Python 3 your example is 
much faster even without your patch (but still has quadratic complexity).

Python 2.7:
oldtime for 5000 iterations: 68.485284
newtime for 5000 iterations: 0.237943

Python 3.6:
oldtime for 5000 iterations: 0.695023
newtime for 5000 iterations: 0.212854

And the best option is using ElementTree. It accepts an index instead of a 
subelement for insertion.

$ ./python etree_example.py
Python 2.7:
time for 5000 iterations: 0.037805

Python 3.6:
time for 5000 iterations: 0.015566

--
Added file: http://bugs.python.org/file43438/minidom_example2.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


Added file: http://bugs.python.org/file43439/etree_example.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27344] zipfile *does* support utf-8 filenames

[Daniel Holth]

New submission from Daniel Holth:

The zipfile documentation says "There is no official file name encoding for ZIP 
files." However ZIP and zipfile supports utf-8 filenames; this has been true 
for a long time, at least since Python 2.7.

--
assignee: docs@python
components: Documentation
messages: 268727
nosy: dholth, docs@python
priority: normal
severity: normal
status: open
title: zipfile *does* support utf-8 filenames
versions: Python 2.7, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27333] validate_step in rangeobject.c, incorrect code logic but right result

[Xiang Zhang]

Xiang Zhang added the comment:

This looks fine. But maybe code like this looks more clear:

if (step && _PyLong_Sign(step) == 0) {
PyErr_SetString(PyExc_ValueError,
"range() arg 3 must not be zero");
Py_CLEAR(step);
}

I think assert(PyLong_Check(step)) can be left out since _PyLong_Sign also 
checks it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27342] Clean up some Py_XDECREFs in rangeobject.c and bltinmodule.c

[Xiang Zhang]

Xiang Zhang added the comment:

Thanks for review. Eliminate the wrongs ones.

--
Added file: http://bugs.python.org/file43440/cleanup_some_xdecrefs_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

[Steve Dower]

Steve Dower added the comment:

A build issue like that is fairly likely - I don't touch 2.7 apart from 
releases and so all I did was restart my build VM, pull and hit rebuild. There 
may be another clean step required when the OpenSSL version changes.

We're getting another update before the final release, so I'll clean up the 
build VM now in preparation.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

[Robert Haschke]

Robert Haschke added the comment:

Indeed there is a small slow down for insertion at the beginning.
However, this is simply due to the extra function _index() and thus linear in 
the number of insertion operations.

My patch essentially boosts insertions before /any fixed/ node.
If this reference node changes between insertions (as in your "before first" 
example), there is no gain anymore.

Of course, this optimization comes at the cost of an additional integer per 
node. There is no free lunch!

I know, that there are other parsers (e.g. etree) available. However
changing my existing code base from minidom to etree will be a heavy change, 
which isn't easily accepted as well.

I think, my minidom patch is a clean and simple fix to a common performance 
issue. As it mostly effects 2.7, it should primarily go there ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27048] distutils._msvccompiler._get_vc_env() fails with UnicodeDecodeError if an env var is not encodable

[Roundup Robot]

Roundup Robot added the comment:

New changeset 15900c612ca7 by Steve Dower in branch '3.5':
Issue #27048: Prevents distutils failing on Windows when environment variables 
contain non-ASCII characters
https://hg.python.org/cpython/rev/15900c612ca7

New changeset bb22ae1e1bcd by Steve Dower in branch 'default':
Issue #27048: Prevents distutils failing on Windows when environment variables 
contain non-ASCII characters
https://hg.python.org/cpython/rev/bb22ae1e1bcd

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27048] distutils._msvccompiler._get_vc_env() fails with UnicodeDecodeError if an env var is not encodable

[Steve Dower]

Steve Dower added the comment:

I went ahead and updated the subprocess call just in _msvccompiler to use cmd 
/u, as I like that fix.

Not so keen on doing it for all subprocess(shell=True) calls, since we can't 
reliably predict whether the output will actually respect the option.

--
assignee:  -> steve.dower
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27048] distutils._msvccompiler._get_vc_env() fails with UnicodeDecodeError if an env var is not encodable

[Steve Dower]

Steve Dower added the comment:

Oh, and before anyone asks, I used "errors='replace'" because we get all the 
env variables but don't use most of them. If we do end up needing one that 
can't be decoded, this should make it obvious, but there's no point failing 
early because of a variable that we're not going to use.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24294] DeprecationWarnings should be visible by default in the interactive REPL

[Aaron Meurer]

Changes by Aaron Meurer :


--
nosy: +Aaron.Meurer

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

[Steve Dower]

Steve Dower added the comment:

Just made another "release" build from the latest source (with OpenSSL 1.0.2h) 
and can no longer repro this issue, so I'm closing it.

If anyone wants to try with the same build, it will be up at 
https://ptvs.blob.core.windows.net/temp/python-2.7.12.amd64.msi for a little 
while. It's not the final 2.7.12, despite the filename, so please only use it 
for reproducing this issue and then fully uninstall it (otherwise you'll likely 
encounter issues in the future):

>>> sys.version
'2.7.12rc1+ (2.7:dd2cc11bc170, Jun 17 2016, 16:14:27) [MSC v.1500 64 bit 
(AMD64)]'

--
assignee:  -> steve.dower
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

This slow down is not such small -- up to 25% for every insertBefore(). If most 
calls of insertBefore() are not with the same refChild, the benefit from the 
optimization of one special case can be dwarfed. Try to minimize the overhead 
of the optimization. If you succeed the chances of acceptance of the patch will 
increase.

I think that the availability of alternatives (upgrading to Python 3 or using 
ElementTree) plays against the acception of this optimization. Since it looks 
more as new feature to me, you have to convince the maintainer of 2.7 to take 
the patch in 2.7.

--
nosy: +benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27344] zipfile *does* support utf-8 filenames

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +serhiy.storchaka
stage:  -> needs patch
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27048] distutils._msvccompiler._get_vc_env() fails with UnicodeDecodeError if an env var is not encodable

[Eryk Sun]

Eryk Sun added the comment:

vcvarsall.bat is mostly `set` and `echo` statements, which print using UTF-16LE 
with "/u". It also runs reg.exe, but with stdout and stderr redirected to nul, 
so that's no problem. The final `set` command prints cmd's UTF-16LE 
environment. Using errors='replace' shouldn't be necessary. It doesn't hurt, 
however.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26536] Add the SIO_LOOPBACK_FAST_PATH option to socket.ioctl

[Roundup Robot]

Roundup Robot added the comment:

New changeset f8957c755c7a by Steve Dower in branch 'default':
Issue #26536: socket.ioctl now supports SIO_LOOPBACK_FAST_PATH. Patch by Daniel 
Stokes.
https://hg.python.org/cpython/rev/f8957c755c7a

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26536] Add the SIO_LOOPBACK_FAST_PATH option to socket.ioctl

[Steve Dower]

Steve Dower added the comment:

All looked good to me, and as far as I could see all of Berker's feedback was 
addressed, so consider it in!

--
assignee:  -> steve.dower
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

[James Paget]

James Paget added the comment:

The 2.7.12rc1+ build resolves the issue for me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

[Robert Haschke]

Robert Haschke added the comment:

I don't see how to further minimize the checks - all of them are required. I 
think, the most common uses cases to create a document are appendChild(), which 
is not affected, and insertBefore() using the same refChild for a while. In 
that case, the patch gives a tremendous speedup.

If you as maintainers don't want to share this improvement with the community, 
it's your choice and I will be fine with that.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19756] test_nntplib: sporadic failures, network isses? server down?

[Berker Peksag]

Berker Peksag added the comment:

I just saw the same test failures at 
http://buildbot.python.org/all/builders/AMD64%20Debian%20root%203.5/builds/998/steps/test/logs/stdio

I'm attaching the test logs for future reference.

--
nosy: +berker.peksag
stage:  -> needs patch
type:  -> behavior
versions: +Python 3.5, Python 3.6 -Python 3.3, Python 3.4
Added file: http://bugs.python.org/file43441/test_nntplib_logs.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26923] asyncio.gather drops cancellation

[Guido van Rossum]

Guido van Rossum added the comment:

Thanks! I had eventually pieced together the same explanation. So yes, I
think your fix is right, though I would write it like this:

ret = False
for child in self._children:
ret |= child.cancel()
return ret  # True if at least one child.cancel() call returned True

It would also be nice if there was a test for this behavior.

I keep worrying a bit -- a similar bug could exist in other pieces of the
code, or in other libraries. But I guess we can't do much about that.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27342] Clean up some Py_XDECREFs in rangeobject.c and bltinmodule.c

[Raymond Hettinger]

Raymond Hettinger added the comment:

v2 looks correct.

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19756] test_nntplib: sporadic failures, network isses? server down?

[Martin Panter]

Martin Panter added the comment:

Thanks Berker. In this case the previous tests using the same NNTP connection 
object were skipped. First run:

test_unknown_command (test.test_nntplib.NetworkedNNTPTests) ... ok
test_welcome (test.test_nntplib.NetworkedNNTPTests) ... ok
test_with_statement (test.test_nntplib.NetworkedNNTPTests) ... skipped 
"Resource 'news.trigofacile.com' is not available"
test_xhdr (test.test_nntplib.NetworkedNNTPTests) ... skipped "Resource 
'news.trigofacile.com' is not available"
test_xover (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_zlogin (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_zzquit (test.test_nntplib.NetworkedNNTPTests) ... ERROR

Subsequent retry:

test_xover (test.test_nntplib.NNTPv2Tests) ... ok
test_article_head_body (test.test_nntplib.NetworkedNNTPTests) ... skipped 
"Resource 'news.trigofacile.com' is not available"
test_capabilities (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_date (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_description (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_descriptions (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_group (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_help (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_list (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_list_active (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_newgroups (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_over (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_unknown_command (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_welcome (test.test_nntplib.NetworkedNNTPTests) ... ok
test_with_statement (test.test_nntplib.NetworkedNNTPTests) ... ok
test_xhdr (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_xover (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_zlogin (test.test_nntplib.NetworkedNNTPTests) ... ERROR
test_zzquit (test.test_nntplib.NetworkedNNTPTests) ... ERROR

Test_with_statement() is a special case because it starts a fresh NNTP 
connection, rather than reusing self.server. Test_welcome() is also different 
because it does not send any new commands to the server. But I presume the 
other tests all try to reuse the old timed-out self.server object. The skipped 
messages are evidence of this.

The easy solution which I mentioned above would be to change setUpClass() to 
setUp(), although this might slow the tests down a bit, reconnecting to the 
remote server for each test method.

The solution that I prefer would be as Antoine suggested, to run our own 
server. I think expanding the server I created in Issue 25859 with more 
commands would be good enough.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27309] Visual Styles support to tk/tkinter file and message dialogs

[Terry J. Reedy]

Terry J. Reedy added the comment:

tkinter.messagebox is based on tkinter.commondialog, first written in 1997. 
Since it works as originally designed, it does not seem to have been 
significantly altered since before themed widgets. Upgrading would be an 
enhancement for future versions, not a bugfix for all versions.

The SO answer is correct that tkinter does not build the messagebox, but indeed 
calls into tk with, for message boxes, the command "tk_messageBox", to get the 
builtin box.

Since I am converting IDLE on 3.6 to use ttk where appropriate, I would very 
mush like to be able to get the better looking versions of the builtin dialogs 
-- and in 3.6 -- and on all 3 majore systems, not just Windows.  Since tkinter 
still supports 8.4 (should this change?) and ttk requires 8.5, this needs to be 
an option or at least version dependent.

I report this issue in a comment on 'patthoyts' answer.

--
components: +Tkinter
nosy: +serhiy.storchaka, terry.reedy
stage:  -> test needed
title: Visual Styles support -> Visual Styles support to tk/tkinter file and 
message dialogs
type: behavior -> enhancement
versions: +Python 3.6 -Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27312] test_setupapp (idlelib.idle_test.test_macosx.SetupTest) fails on OS X

[Roundup Robot]

Roundup Robot added the comment:

New changeset 90fd1c17214b by Terry Jan Reedy in branch 'default':
Issue #27312: mock out function that fails when called from setupApp during
https://hg.python.org/cpython/rev/90fd1c17214b

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27312] test_setupapp (idlelib.idle_test.test_macosx.SetupTest) fails on OS X

[Terry J. Reedy]

Terry J. Reedy added the comment:

My suggested mock was for the wrong function.  Please let me know what happens 
next time you pull and run test_idle whether alone or with the suite.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27341] mock.patch decorator fails silently on generators

[Terry J. Reedy]

Terry J. Reedy added the comment:

3.2 to 3.4 only get security fixes

please provide a simple test that fails now and that you think should pass or 
at least warn.

--
nosy: +michael.foord, terry.reedy
stage:  -> test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27344] zipfile *does* support utf-8 filenames

[Terry J. Reedy]

Terry J. Reedy added the comment:

There is a difference between 'official' and 'supported', and I don't quite 
know what you mean by the latter.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27312] test_setupapp (idlelib.idle_test.test_macosx.SetupTest) fails on OS X

[Roundup Robot]

Roundup Robot added the comment:

New changeset 61bd6974405f by Berker Peksag in branch 'default':
Issue #27312: Fix TypeError in test_setupapp
https://hg.python.org/cpython/rev/61bd6974405f

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27292] Warn users that os.urandom() can return insecure values

[Martin Panter]

Martin Panter added the comment:

Restored “On Linux” for the changed in 3.5.2 notice. I do think it is better to 
be general and future-proof, but that is a separate, less important issue to 
the main purpose of the patch. (I don’t know if Solaris’s version can block or 
not.)

--
stage: needs patch -> patch review
Added file: http://bugs.python.org/file43442/urandom-doc.v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27337] 3.6.0a2 tarball has weird paths

[Peter Eisentraut]

Peter Eisentraut added the comment:

The affected tar is indeed a BSD-ish tar (OS X).  With GNU tar I can proceed.  
It says "gtar: Removing leading `../' from member names".

So with that I agree that it's not worth rerolling this release.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22636] avoid using a shell in ctypes.util: replace os.popen with subprocess

[Roundup Robot]

Roundup Robot added the comment:

New changeset a09ae70f3489 by Victor Stinner in branch '2.7':
Issue #22636: Avoid using a shell in the ctypes.util module
https://hg.python.org/cpython/rev/a09ae70f3489

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22636] avoid using a shell in ctypes.util: replace os.popen with subprocess

[Martin Panter]

Martin Panter added the comment:

Sorry about impersonating your name as committer Victor. I have been fixing 
this problem in recent patches, but because I imported your patch a while ago I 
forgot about it.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7164] pickle test failure after test_imp/test_import (_make_stat_result is not the same object as os._make_stat_result)

[Peter Williams]

Peter Williams added the comment:

I'm experiencing a variation of this problem on a project where I'm trying to 
make an application that will work with both 2.7.x and 3.4.x
and am mostly successful.  The application uses a number of pickle files
and I want to make it so that it doesn't matter which version created the 
pickle files the other can read it.  By limiting the 3.4 version to
pickle protocol 2 I've succeeded in having 2.7.x read 3.4.x pickle files
but encountered a problem going the other way with the following
error message:

Traceback (most recent call last):
  File "/home/peter/SRC/GITHUB/epygibus.git/epygibus3", line 25, in 
sys.exit(ARGS.run_cmd(ARGS))
  File 
"/home/peter/SRC/GITHUB/epygibus.git/epygibus_pkg/cli/subcmd_restore.py", line 
70, in run_cmd
snapshot.restore_subdir(args.archive_name, os.sep, seln_fn=lambda l: 
l[-1-args.back])
  File "/home/peter/SRC/GITHUB/epygibus.git/epygibus_pkg/snapshot.py", line 
699, in restore_subdir
snapshot_fs = get_snapshot_fs(archive_name, 
seln_fn).get_subdir(abs_subdir_path)
  File "/home/peter/SRC/GITHUB/epygibus.git/epygibus_pkg/snapshot.py", line 
595, in get_snapshot_fs
snapshot = read_snapshot(os.path.join(archive.snapshot_dir_path, 
snapshot_name))
  File "/home/peter/SRC/GITHUB/epygibus.git/epygibus_pkg/snapshot.py", line 
236, in read_snapshot
return pickle.load(fobj)
AttributeError: Can't get attribute '_make_stat_result' on 

I'm pretty sure that this is a result of that pickle file containing
instances of the output from os.lstat() generated by 2.7.x which 3.4.x
is having trouble instantiating.

The source code for the application with the problem is available on
github as repo "epygibus" for user "pwil3058".

--
nosy: +Peter Williams

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27341] mock.patch decorating a generator returns a regular function.

[Robert Collins]

Robert Collins added the comment:

There are two related things here.

Firstly, the generator's body will run without the patch (because the wrapping 
function has 

try:
   return decorated(..)
finally:
   unpwatch()

Secondly, the wrapping function is itself not a generator, and anything that 
introspects functions to see if they are generators will not detect the wrapped 
function as one - which is I suspect whats tripping nose up, but I haven't 
actually checked the nose code to see what its doing/expecting.

--
nosy: +rbcollins
title: mock.patch decorator fails silently on generators -> mock.patch 
decorating a generator returns a regular function.

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27341] mock.patch decorating a generator returns a regular function.

[Robert Collins]

Robert Collins added the comment:

Once fixed in CPython, we'll put the backport in mock, for folk using older 
Python's.

--
versions:  -Python 2.7, Python 3.2, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27258] Exception in BytesGenerator.flatten

[Pedro Lacerda]

Pedro Lacerda added the comment:

Seems that ``token.has_fws`` evaluates to True in the following condition

if token.has_fws:

causing ``token._fold(self)`` where isn't needed and raising the exception. 
Hope it helps!

By the way, why the _header_value_parser.py was removed from the repository?
https://github.com/python/cpython/blob/master/Lib/email/_header_value_parser.py#L144

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25548] Show the address in the repr for class objects

[Peter Eisentraut]

Peter Eisentraut added the comment:

I understand the reasoning here, but I want to say booh to this change in 
3.6.0a2 because it breaks my tests.  It used to be that type(x) returned a 
predictable string, and that was an easy way to verify the result types of 
things.

Perhaps a __str__ implementation could be added that avoids the memory address?

--
nosy: +petere

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27341] mock.patch decorating a generator returns a regular function.

[Shoshana Berleant]

Shoshana Berleant added the comment:

output

--
Added file: http://bugs.python.org/file43444/actual.out

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27341] mock.patch decorating a generator returns a regular function.

[Shoshana Berleant]

Shoshana Berleant added the comment:

I attached a file with 4 tests and the output. nosetests reports that all four 
tests were executed. In reality, only two tests were executed.

--
Added file: http://bugs.python.org/file43443/silentfail.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25548] Show the address in the repr for class objects

[Martin Panter]

Martin Panter added the comment:

There is also Issue 13224 proposing to change __str__() to just return the 
__name__ or __qualname__ if I remember correctly.

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22908] ZipExtFile in zipfile can be seekable

[Jürgen A . Erhard]

Jürgen A. Erhard added the comment:

To add to this (without looking at the patch): I just to my astonishment 
learned that a ZipExtFile doesn't even support tell().  I can understand the 
seek being nontrivial... but the tell?  It's a bytestream, and there is (isn't 
there?) a clear definition of what next byte a read(1) would deliver.  It 
should be trivial to keep track of the (only ever increasing) file position.

--
nosy: +jae

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27337] 3.6.0a2 tarball has weird paths

[Ned Deily]

Ned Deily added the comment:

OK, thanks for the info.  I'm going to close this issue as "won't fix" and try 
real hard not to do it again.

--
resolution:  -> wont fix
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22636] avoid using a shell in ctypes.util: replace os.popen with subprocess

[STINNER Victor]

STINNER Victor added the comment:

No problemo.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7769] SimpleXMLRPCServer.SimpleXMLRPCServer.register_function as decorator

[Xiang Zhang]

Changes by Xiang Zhang :


--
nosy: +loewis, serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22228] Adapt bash readline operate-and-get-next function

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19756] test_nntplib: sporadic failures, network isses? server down?

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

There are different tricks that allow to minimize an overhead. Here is tuned 
patch.

But I still not sure that this special case is worth to be optimized.

--
Added file: http://bugs.python.org/file43445/minidom.insertBefore2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27342] Clean up some Py_XDECREFs in rangeobject.c and bltinmodule.c

[Roundup Robot]

Roundup Robot added the comment:

New changeset 52931189d7ee by Serhiy Storchaka in branch 'default':
Issue #27342: Replaced some Py_XDECREFs with Py_DECREFs.
https://hg.python.org/cpython/rev/52931189d7ee

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27342] Clean up some Py_XDECREFs in rangeobject.c and bltinmodule.c

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27333] validate_step in rangeobject.c, incorrect code logic but right result

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Agreed.

--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27333] validate_step in rangeobject.c, incorrect code logic but right result

[Roundup Robot]

Roundup Robot added the comment:

New changeset 4fbcd58df1a0 by Serhiy Storchaka in branch 'default':
Issue #27333: Simplified testing step on 0.
https://hg.python.org/cpython/rev/4fbcd58df1a0

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27333] validate_step in rangeobject.c, incorrect code logic but right result

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you for your review Xiang.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27343] Incorrect error message for conflicting initializers of ctypes structure

[Roundup Robot]

Roundup Robot added the comment:

New changeset ed81fc7e285b by Serhiy Storchaka in branch '3.5':
Issue #27343: Fixed error message for conflicting initializers of 
ctypes.Structure.
https://hg.python.org/cpython/rev/ed81fc7e285b

New changeset 40e3790c2a00 by Serhiy Storchaka in branch 'default':
Issue #27343: Fixed error message for conflicting initializers of 
ctypes.Structure.
https://hg.python.org/cpython/rev/40e3790c2a00

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com