[issue15002] urllib2 does not download 4 MB file completely using ftp

[Senthil Kumaran]

Senthil Kumaran added the comment:

Christian's patch is good.It helps in setting the socket.makefile file 
descriptor to a well behaving well file close wrapper and thus will help us 
prevent some tricky fd close issues.

I added tests for coverage to ensure that we are asserting the type and 
covering all the methods in urllib.response. Attaching the patch built on top 
of Chritians one.

--
Added file: http://bugs.python.org/file34970/issue15002.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21226] PyImport_ExecCodeModuleObject not setting module attributes

[Eric Snow]

Eric Snow added the comment:

Here's a (currently segfaulting) patch that demonstrates how I'd like to solve 
this.  Feedback on the approach is welcome. :)  When I get a chance I'll debug 
the segfault.

--
assignee:  -> eric.snow
keywords: +patch
stage:  -> patch review
Added file: 
http://bugs.python.org/file34971/fix-PyImport_ExecCodeModuleObject.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10362] AttributeError: addinfourl instance has no attribute 'tell'

[Senthil Kumaran]

Senthil Kumaran added the comment:

I agree. Having tell on a file descriptor of a URL request is not going to be 
of help. You can easily write to a local file and use all the local file 
features, if it is things like .tell is desired.

--
resolution:  -> not a bug
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21305] PEP 466: update os.urandom

[Antoine Pitrou]

Antoine Pitrou added the comment:

Why exactly does it need to be backported? os.urandom under 2.7 works fine.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21292] C API in debug fails

[Martin v . Löwis]

Martin v. Löwis added the comment:

I think the issue is actually slightly different. You can certainly build your 
Python "in debug", and still link with the release mode Python. The question is 
what "in debug" means, and the normal definition would be "with the generation 
of debug symbols by the compiler".

What you cannot do is
1. to build with _DEBUG defined (or whatever the exact spelling of the macro 
is, or
2. to link with the debug version of msvcrt.

We could fix 1, i.e. allowing you to define _DEBUG, and still bind the release 
version. I think we cannot reasonably fix 2; this is a Microsoft issue.

You can work around by simply not defining _DEBUG, and still build "in debug"

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21308] PEP 466: backport ssl changes

[Cory Benfield]

Changes by Cory Benfield :


--
nosy: +Lukasa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21308] PEP 466: backport ssl changes

[Christian Heimes]

New submission from Christian Heimes:

I'm interested to assist with all back port tickets as soon as my internet 
connection is fixed. A technician is going to check my line again on Tuesday.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21308] PEP 466: backport ssl changes

[Antoine Pitrou]

Antoine Pitrou added the comment:

I'm not really interested to assist with backport tickets myself. You may nosy 
me but I may not care at all :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21287] Better support for AF_PACKET on opensolaris (illumos)

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
nosy: +neologix
stage:  -> patch review
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21311] Fix compiler detection when brew's ccache is installed on Mac OS X

[John Szakmeister]

New submission from John Szakmeister:

It's pretty typical for ccache packages to install symlinks for compilers that 
may not be present on the system, such as Homebrew's ccache package.  
Unfortunately, the _osx_support.py file is mislead by the presence of the 
symlink and ends up backtracing.

This issue is present in 2.7 and onwards.  I'm attaching two possible fixes for 
the problem, both created against 2.7.  The issue is that the symlink in 
detected, but _read_output() returns None, which then fails when the output is 
examined (if 'str' in None...).  The first patch does a simple non-empty check. 
 The alternate version makes _read_output() return an empty string instead of 
None.

--
components: Distutils
files: fix-osx-llvm-detection-with-ccache.patch
keywords: patch
messages: 216856
nosy: dstufft, eric.araujo, jszakmeister
priority: normal
severity: normal
status: open
title: Fix compiler detection when brew's ccache is installed on Mac OS X
versions: Python 2.7, Python 3.1, Python 3.2, Python 3.3, Python 3.4, Python 3.5
Added file: 
http://bugs.python.org/file34972/fix-osx-llvm-detection-with-ccache.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21311] Fix compiler detection when brew's ccache is installed on Mac OS X

[John Szakmeister]

John Szakmeister added the comment:

Here's the alternate fix.

--
Added file: 
http://bugs.python.org/file34973/alt-fix-osx-llvm-detection-with-ccache.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21305] PEP 466: update os.urandom

[Nick Coghlan]

Nick Coghlan added the comment:

It was in the list of security fixes Alex and Donald wanted to reduce
vulnerabilities in 2.x network services, and Guido was OK with backporting
it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21305] PEP 466: update os.urandom

[Antoine Pitrou]

Antoine Pitrou added the comment:

> It was in the list of security fixes Alex and Donald wanted to reduce
> vulnerabilities in 2.x network services, and Guido was OK with backporting
> it.

What security issue is there exactly? os.urandom() does a similar thing
in 2.7 and 3.x (it reads from  /dev/urandom).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21305] PEP 466: update os.urandom

[Alex Gaynor]

Alex Gaynor added the comment:

It's not a security issue per-se, but if you're doing many small reads, there's 
such an enormous performance and scalability difference that if users run into 
an issue, they're likely to work around it by using a non-CS PRNG, and 
compromising their application security.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21305] PEP 466: update os.urandom

[Antoine Pitrou]

Antoine Pitrou added the comment:

> It's not a security issue per-se, but if you're doing many small
> reads, there's such an enormous performance and scalability difference
> that if users run into an issue, they're likely to work around it by
> using a non-CS PRNG, and compromising their application security.

Do you have any examples of this or is it just a gratuitous inference?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21305] PEP 466: update os.urandom

[Antoine Pitrou]

Antoine Pitrou added the comment:

Note that the 3.4 scheme is not fully debugged yet: issue21207. There is a 
reason we don't backport new features!

Regardless, I'm not interested in this, so I'll let you take the risk of 
regressions if you want to.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21305] PEP 466: update os.urandom

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
nosy:  -pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21207] urandom persistent fd - not re-openned after fd close

[Alex Gaynor]

Changes by Alex Gaynor :


--
nosy: +alex

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18967] Find a less conflict prone approach to Misc/NEWS

[Senthil Kumaran]

Changes by Senthil Kumaran :


--
nosy:  -orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16827] Remove the relatively advanced content from section 2 in tutorial

[Senthil Kumaran]

Senthil Kumaran added the comment:

For this bug, I think, section 2.2.4 and section 2.2.5 can be moved to section 
13 and inserted between section 13.1 and 13.2 as it seem to be fit in naturally 
there.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2052] Allow changing difflib._file_template character encoding.

[Senthil Kumaran]

Changes by Senthil Kumaran :


--
nosy:  -orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21226] PyImport_ExecCodeModuleObject not setting module attributes

[Benjamin Peterson]

Benjamin Peterson added the comment:

The last argument to _PyObject_CallMethodIdObjArgs needs to be NULL...

--
nosy: +benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9364] some problems with the documentation of pydoc

[Roundup Robot]

Roundup Robot added the comment:

New changeset 16207b8495bf by R David Murray in branch '3.4':
#9364: Improve the text printed by help(pydoc) and help(help).
http://hg.python.org/cpython/rev/16207b8495bf

New changeset 256c782ab078 by R David Murray in branch 'default':
Merge: #9364: Improve the text printed by help(pydoc) and help(help).
http://hg.python.org/cpython/rev/256c782ab078

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9364] some problems with the documentation of pydoc

[R. David Murray]

R. David Murray added the comment:

Thanks, Glenn.  I tweaked the wording further.  If someone thinks it is worth 
the effort to backport this to 2.7, they can do so and reopen the issue.

--
assignee: eric.araujo -> 
nosy: +r.david.murray
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed
versions: +Python 3.4, Python 3.5 -Python 2.7, Python 3.1, Python 3.2, Python 
3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21312] Update thread_foobar.h to include timed locking and TLS support

[Jack McCracken]

New submission from Jack McCracken:

The thread_foobar.h reference for the interface for abstracting the 
platform-specific thread implementation does not include newer features such as 
timed locking and TLS support.

--
components: Interpreter Core
files: update_thread_foobar.diff
keywords: patch
messages: 216867
nosy: Jack.McCracken
priority: normal
severity: normal
status: open
title: Update thread_foobar.h to include timed locking and TLS support
type: enhancement
Added file: http://bugs.python.org/file34974/update_thread_foobar.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21312] Update thread_foobar.h to include timed locking and TLS support

[Jack McCracken]

Jack McCracken added the comment:

Missed a word in a comment

--
Added file: http://bugs.python.org/file34975/update_thread_foobar_v2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21312] Update thread_foobar.h to include timed locking and TLS support

[Antoine Pitrou]

Antoine Pitrou added the comment:

You may want to provide an implementation of PyThread_acquire_lock() that 
simply defers to PyThread_acquire_lock_timed() (see thread_pthread.h, which 
does the same).

--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21312] Update thread_foobar.h to include timed locking and TLS support

[Jack McCracken]

Jack McCracken added the comment:

Added an example of deferring to PyThread_acquire_lock_timed in 
PyThread_acquire_lock. Also fixed a mistake in the string of a dprintf in 
PyThread_acquire_lock_timed.

--
Added file: http://bugs.python.org/file34976/update_thread_foobar_v3.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21312] Update thread_foobar.h to include timed locking and TLS support

[Antoine Pitrou]

Antoine Pitrou added the comment:

Hum, your comment about deferring is wrong, since thread_nt.h also does the 
deferring:

int
PyThread_acquire_lock(PyThread_type_lock aLock, int waitflag)
{
return PyThread_acquire_lock_timed(aLock, waitflag ? -1 : 0, 0);
}

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21312] Update thread_foobar.h to include timed locking and TLS support

[Jack McCracken]

Jack McCracken added the comment:

Oops... I removed that and just put the deferral in there.

--
Added file: http://bugs.python.org/file34977/update_thread_foobar_v4.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21312] Update thread_foobar.h to include timed locking and TLS support

[Antoine Pitrou]

Antoine Pitrou added the comment:

Thanks! The patch looks good to me, I'll let it sleep a bit to see if other 
people have an opinion.

--
nosy: +tim.peters
stage:  -> patch review
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7221] DispatcherWithSendTests_UsePoll with test_asyncore does nothing

[Jessica McKellar]

Jessica McKellar added the comment:

This looks like a copy-paste typo from test_asynchat, which does use `usepoll`.

Attached is a patch that removes `usepoll` and a 
`DispatcherWithSendTests_UsePoll` TestCase that did nothing but set 
`usepoll=True`.

* The diff passes `make patchcheck`.
* The full test suite passes with this diff.

--
keywords: +needs review, patch
nosy: +jesstess
stage: needs patch -> patch review
Added file: http://bugs.python.org/file34978/issue7221.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21311] Fix compiler detection when brew's ccache is installed on Mac OS X

[Ned Deily]

Changes by Ned Deily :


--
assignee:  -> ned.deily
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7221] DispatcherWithSendTests_UsePoll with test_asyncore does nothing

[Roundup Robot]

Roundup Robot added the comment:

New changeset cbe7b5a5a110 by Antoine Pitrou in branch 'default':
Issue #7221: remove redundant tests in test_asyncore.  Patch by Jessica 
McKellar.
http://hg.python.org/cpython/rev/cbe7b5a5a110

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7221] DispatcherWithSendTests_UsePoll with test_asyncore does nothing

[Antoine Pitrou]

Antoine Pitrou added the comment:

Now committed. Thanks for the patch!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.5 -Python 2.7, Python 3.1, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21311] Fix compiler detection when brew's ccache is installed on Mac OS X

[Roundup Robot]

Roundup Robot added the comment:

New changeset e3217efa6edd by Ned Deily in branch '2.7':
Issue #21311: Avoid exception in _osx_support with non-standard compiler
http://hg.python.org/cpython/rev/e3217efa6edd

New changeset 3d1578c705c9 by Ned Deily in branch '3.4':
Issue #21311: Avoid exception in _osx_support with non-standard compiler
http://hg.python.org/cpython/rev/3d1578c705c9

New changeset 2a4401109672 by Ned Deily in branch 'default':
Issue #21311: merge with 3.4
http://hg.python.org/cpython/rev/2a4401109672

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21311] Fix compiler detection when brew's ccache is installed on Mac OS X

[Ned Deily]

Ned Deily added the comment:

Thanks for the report and the patches.  I am not sure exactly what problem 
using ccache is causing but it is clear that, if for whatever reason the call 
to _read_output fails and returns None, the 'llvm-gcc' test will fail so that 
test should be fixed as suggested in your first patch which I've applied for 
release in 2.7.7, 3.4.1, and 3.5.0.

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed
versions:  -Python 3.1, Python 3.2, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21121] -Werror=declaration-after-statement is added even for extension modules through setup.py

[Ned Deily]

Ned Deily added the comment:

Stefan, the patch LGTM although I sure wish we were removing some 
CFLAGS-related configuration variables rather than adding another.  But I don't 
have a better suggestion short of a comprehensive cleanup of all of them.

--
stage:  -> commit review
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4744] asynchat documentation needs to be more precise

[R. David Murray]

R. David Murray added the comment:

The change covered by the patch (which patch rejected as garbage, by the way, I 
have no idea why) has already been applied by Serhiy Storchaka, apparently as a 
blanked change of 'empty string' to 'empty bytes object'.

There are several other places in the asynchat doc page that mention string.  I 
suspect that none of them is correct, but I haven't read through the page to be 
sure.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4744] asynchat documentation needs to be more precise

[R. David Murray]

Changes by R. David Murray :


--
Removed message: http://bugs.python.org/msg216880

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4744] asynchat documentation needs to be more precise

[R. David Murray]

R. David Murray added the comment:

The change covered by the patch (which patch rejected as garbage, by the way, I 
have no idea why) has already been applied by Serhiy Storchaka, apparently as a 
blanket change of 'empty string' to 'empty bytes object'.

There are several other places in the asynchat doc page that mention string.  I 
suspect that none of them is correct, but I haven't read through the page to be 
sure.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13966] Add disable_interspersed_args() to argparse.ArgumentParser

[paul j3]

paul j3 added the comment:

http://bugs.python.org/issue14191
implements the other side of optparse behavior - allowing a complete 
intermixing of optionals and positionals. 

It does that with a new 'ArgumentParser.parse_intermixed_args()'  method.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21313] Py_GetVersion() is broken when using mqueue and a long patch name

[Eric Snow]

New submission from Eric Snow:

Py_GetVersion() (in Python/getversion.c) builds the version string returned by 
sys.version:

  PyOS_snprintf(version, sizeof(version), "%.80s (%.80s) %.80s",
PY_VERSION, Py_GetBuildInfo(), Py_GetCompiler());

In turn, Py_GetBuildInfo() (in Modules/getbuildinfo.c) returns the "build" 
portion of Python's version string.  When available, the tag returned by "hg id 
-t" constitutes part of that build string.

The problem is that when using mqueue the result of "hg id -t" can be pretty 
long.  For example:

  issue21226-fix-PyImport_ExecCodeModuleObject.diff qbase qtip tip

That's 74 characters for just part of a build string that may be well over 100 
characters.  However, Py_GetVersion() truncates it to 80 characters.

The consequence is that this value of sys.version causes 
platform._sys_version() to fail since the version string does not match the 
expected pattern.

So either Py_GetVersion() should relax (-1) or Py_GetBuildInfo() should 
restrict the length of the resulting build string (+1).  Would it work to 
truncate just the hgid part so that the whole string returned by 
Py_GetBuildInfo() is no more than length 80?  E.g.


-PyOS_snprintf(buildinfo, sizeof(buildinfo),
-  "%s%s%s, %.20s, %.9s", hgid, sep, revision, DATE, TIME);
+PyOS_snprintf(buildinfo, 80,
+  "%.43s%.1s%.13s, %.20s, %.9s", hgid, sep, revision, DATE, 
TIME);

--
components: Interpreter Core
messages: 216883
nosy: eric.snow
priority: normal
severity: normal
stage: patch review
status: open
title: Py_GetVersion() is broken when using mqueue and a long patch name
type: behavior
versions: Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21311] Fix compiler detection when brew's ccache is installed on Mac OS X

[John Szakmeister]

John Szakmeister added the comment:

Thank you Ned!  The issue is that you can create symlinks to ccache to and put 
them on your path.  Distros do this for you now, but most create symlinks for a 
bunch of compilers... including ones that may not be installed.  So the 
presence of the name ('gcc', for instance) doesn't mean that the compiler is 
actually installed.  It could be a symlink to the ccache binary and running it 
could fail.  I hope that makes a little more sense.

Thanks again for applying the patch!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10291] Clean-up turtledemo in-package documentation

[Jessica McKellar]

Jessica McKellar added the comment:

Thanks for the bug report and patch, belopolsky!

The original patch no longer applies cleanly, so attached is a regenerated 
version.

* The new patch passes `make patchcheck`.
* The full test suite passes with this patch.
* I manually tested that before the patch, `./python.exe 
Lib/turtledemo/__main__.py` would start the demo window behind the Terminal on 
OSX, and after the patch it starts in front as desired.
* I manually checked the 3 help menu drop-down options in the demo, and they 
have the expected content.

There is a lot of out of date content in the turtle docs, and I think we should 
consider that work separate from this ticket and do a full audit of what needs 
updating in a new ticket.

=> commit review

--
keywords: +needs review
nosy: +jesstess
stage: needs patch -> commit review
Added file: http://bugs.python.org/file34979/issue10291_2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21226] PyImport_ExecCodeModuleObject not setting module attributes

[Eric Snow]

Eric Snow added the comment:

Thanks, Benjamin.  Here's an updated patch that passes all tests.  It should be 
good to go.  And yet again our zipimport implementation was a pain point. :(

--
Added file: 
http://bugs.python.org/file34980/fix-PyImport_ExecCodeModuleObject.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21302] time.sleep (floatsleep()) should use clock_nanosleep() on Linux

[akira]

Changes by akira <4kir4...@gmail.com>:


--
nosy: +akira

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8387] use universal newline mode in csv module examples

[Jessica McKellar]

Jessica McKellar added the comment:

I ran some experiments to see what the state of the world is. I generated a 
test.csv by exporting a CSV file from Numbers on OSX. This generated a file 
with Windows-style \r\n-terminated lines. The attached test_csv.py tries to 
open this CSV file in binary and universal newlines modes. Here's what happens 
on various platforms

Python 3:
* Linux: both binary and universal work
* OSX: binary errors out, universal works
* Windows: binary errors out, universal works

In both cases, the error was:

$ python3 test_csv.py
Traceback (most recent call last):
  File "test_csv.py", line 5, in 
for row in spamreader:
_csv.Error: iterator should return strings, not bytes (did you open the file in 
text mode?)

Python 2:
* Linux: both binary and universal work
* OSX: both binary and universal
* Windows: wasn't readily able to test

If I manually create a CSV file using TextEdit in plaintext mode on OSX, that 
produces a file with Mac-style \r-terminated lines. test_csv.py has the same 
results on this file on OSX (errors out in binary mode in Python 3).

--
nosy: +jesstess
Added file: http://bugs.python.org/file34981/test_csv.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8387] use universal newline mode in csv module examples

[Jessica McKellar]

Changes by Jessica McKellar :


Added file: http://bugs.python.org/file34982/test.csv

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8387] use universal newline mode in csv module examples

[Jessica McKellar]

Jessica McKellar added the comment:

All of the examples from https://docs.python.org/3/library/csv.html run without 
issue on OSX, though.

In summary, the Python 2 examples error out on OSX and switching them to use 
'U' instead of 'b' would fix this. I don't think any action needs to be taken 
for Python 3.

My one remaining question is about binary files on Windows. The Python 2 csv 
docs say "If csvfile is a file object, it must be opened with the ‘b’ flag on 
platforms where that makes a difference." I don't readily have a Windows 
machine to play with this -- do "binary" CSV files exist, or can we eliminate 
the 'b' language entirely and just talk about 'U'?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11571] Turtle window pops under the terminal on OSX

[Roundup Robot]

Roundup Robot added the comment:

New changeset 1f3946b22e64 by Ned Deily in branch '3.4':
Issue #11571: Ensure that the turtle window becomes the topmost window
http://hg.python.org/cpython/rev/1f3946b22e64

New changeset 01228d7b5e01 by Ned Deily in branch 'default':
Issue #11571: merge with 3.4
http://hg.python.org/cpython/rev/01228d7b5e01

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10291] Clean-up turtledemo in-package documentation

[Roundup Robot]

Roundup Robot added the comment:

New changeset 004fe3449193 by Ned Deily in branch 'default':
Issue #10291: Cleanup turtledemo to use docstrings for help.
http://hg.python.org/cpython/rev/004fe3449193

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11571] Turtle window pops under the terminal on OSX

[Ned Deily]

Changes by Ned Deily :


--
versions: +Python 3.4, Python 3.5 -Python 2.7, Python 3.2, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11571] Turtle window pops under the terminal on OSX

[Ned Deily]

Ned Deily added the comment:

The fix for turtle has been applied for release in 3.4.1 and 3.5.0.

--
resolution: wont fix -> fixed
stage: commit review -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8387] use universal newline mode in csv module examples

[Mark Lawrence]

Mark Lawrence added the comment:

I think that it's complete nonsense to talk about binary csv files on Windows.  
They are just plain text files that can be manipulated with any old editor or a 
spreadsheet.

--
nosy: +BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10291] Clean-up turtledemo in-package documentation

[Ned Deily]

Ned Deily added the comment:

Thanks for the refresh, Jessica.  I decided to separate out the turtle window 
raise for OS X and apply that for 3.4.1 and 3.5.0 in Issue11571.  The remainder 
of the patch to use the docstrings, plus removal of the two other obsolete text 
files, is spplied here for 3.5.0.

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed
versions: +Python 3.5 -Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8387] use universal newline mode in csv module examples

[R. David Murray]

R. David Murray added the comment:

The magic of newline='' in python3 is that it *preserves* the line end 
characters, which is the same thing binary mode does on windows.  The place 
that matters, as I remember it, is when there is a newline embedded inside a 
quoted string.  I don't remember *why* that matters, though :(.  But it had 
something to do with how the csv module processes the data internally.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21296] smtplib Sends Commands in Lower-Case

[Luiji Maryo]

Luiji Maryo added the comment:

Apologies, I was tired when I looked into this. It turns out that SMTP is 
explicitly case-insensitive with command names. I still think it'd be nice to 
use upper-case commands for consistency with the FROM: and TO: lines, though, 
or to put the FROM: and TO: lines in lower-case.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21296] smtplib Sends Commands in Lower-Case

[R. David Murray]

Changes by R. David Murray :


--
components: +email
nosy: +barry, r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue837046] pyport.h redeclares gethostname() if SOLARIS is defined

[R. David Murray]

R. David Murray added the comment:

Can you confirm that this is really still a problem, despite the Solaris 
cleanup in issue 1759169?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12220] minidom xmlns not handling spaces in xmlns attribute value field

[Roundup Robot]

Roundup Robot added the comment:

New changeset 13c1c5e3d2ee by R David Murray in branch '3.4':
#12220: improve minidom error when URI contains spaces.
http://hg.python.org/cpython/rev/13c1c5e3d2ee

New changeset 3e67d923a0df by R David Murray in branch 'default':
Merge: #12220: improve minidom error when URI contains spaces.
http://hg.python.org/cpython/rev/3e67d923a0df

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12220] minidom xmlns not handling spaces in xmlns attribute value field

[R. David Murray]

R. David Murray added the comment:

Thanks, amathew and Marek.

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21221] Minor struct_time documentation bug

[R. David Murray]

Changes by R. David Murray :


--
nosy: +belopolsky

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com