[pve-devel] [PATCH docs] qm-cloud-init: make install inside VM more obvious
by making that part bold. While there is already a big note where cloudinit needs to be installed, it is after the actual command. Making it more obvious right before the command will hopefully reduce confusion for more users. Signed-off-by: Aaron Lauterer --- I am aware that we will never get it down to zero, but I just ran ran into a user in the forum who missed it and installed it directly on the PVE host. https://forum.proxmox.com/threads/138772/ qm-cloud-init.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qm-cloud-init.adoc b/qm-cloud-init.adoc index b275d7a..8686ed7 100644 --- a/qm-cloud-init.adoc +++ b/qm-cloud-init.adoc @@ -43,7 +43,7 @@ Preparing Cloud-Init Templates ~~ The first step is to prepare your VM. Basically you can use any VM. -Simply install the Cloud-Init packages inside the VM that you want to +Simply install the Cloud-Init packages *inside the VM* that you want to prepare. On Debian/Ubuntu based systems this is as simple as: -- 2.39.2 ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH pve-manager v4] postinst: filter rbds in lvm
I started testing this and will send a complete mail later, just wanted to mention one thing I've stumbled upon. Consider this pre-upgrade lvm.conf: devices { # added by pve-manager to avoid scanning ZFS zvols global_filter=[ "r|/dev/zd.*|"] } As `lvmconfig` normalizes the linebreak, SET_FILTER is 1 but apparently the `sed` command produces a malformed config (I think it comments out only the first line, but I didn't check). The validity check fails so the pre-upgrade lvm.conf is restored, according to the logs: '/etc/lvm/lvm.conf' -> '/etc/lvm/lvm.conf.bak' (backup: '/etc/lvm/lvm.conf.bak~') Setting 'global_filter' in /etc/lvm/lvm.conf to prevent zvols and rbds from being scanned: global_filter="r|/dev/zd.*|" => global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"] Parse error at byte 103604 (line 2307): unexpected token Failed to load config file /etc/lvm/lvm.conf Invalid LVM config detected - restoring from /etc/lvm/lvm.conf.bak Setting up proxmox-ve (8.1.0) ... This is quite the edge case. So I'm not sure if it worth the hassle to change the logic to handle it properly (especially as the validity check handles it somewhat gracefully)? ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel