Re: Go in poudriere : can't assign requested address

2023-02-02 Thread Jan Beich 
Charlie Li  writes:

> Alexis Praga wrote:
>
>> I've added go as a dependency for the next update of x11/kitty. It
>> builds fine but poudriere fails with :
>> go: downloading github.com/disintegration/imaging
>>  v1.6.2
>> tools/utils/short-uuid.go:10:2:
>> github.com/ALTree/bigfloat@v0.0.0-20220102081255-38c8b72a9924:
>> 
>> Get
>> "https://proxy.golang.org/github.com/%21a%21l%21tree/bigfloat/@v/v0.0.0-20220102081255-38c8b72a9924.zip
>> ":
>> dial tcp: lookup proxy.golang.org  on
>> 192.168.1.254:53: write udp 127.0.0.1:21347->192.168.1.254:53:
>> write: can't assign requested address
>> tools/cmd/icat/native.go:14:2:
>> github.com/disintegration/imaging@v1.6.2:
>>  Get
>> "https://proxy.golang.org/github.com/disintegration/imaging/@v/v1.6.2.zip
>> ":
>> dial tcp: lookup proxy.golang.org  on
>> 192.168.1.254:53: write udp 127.0.0.1:65047->192.168.1.254:53:
>> write: can't assign requested address
>> 
> There is absolutely no network access allowed outside the do-fetch
> phase. You need to specify all your module dependencies and have them
> checksummed beforehand. Take a look at other ports using/written in go
> as examples.

GH_TUPLE is usually generated by "make gomod-vendor" via 
ports-mgmt/modules2tuple.
One can discover this by reading Porter's Handbook[1] or inspecting USES=go
implementation for additional clues.

https://docs.freebsd.org/en/books/porters-handbook/special/#using-go

Warnings about Mk/Uses/go.mk when building INDEX

2023-02-02 Thread Philipp Ost 

Hi everyone,

since at least two days, I'm getting these warning when building the INDEX:

8<
--- describe.www ---
make[4]: "/usr/ports/Mk/Uses/go.mk" line 192: warning: duplicate script 
for target "go-post-fetch" ignored
make[4]: "Makefile" line 35: warning: using previous script for 
"go-post-fetch" defined here
make[4]: "/usr/ports/Mk/Uses/go.mk" line 193: warning: duplicate script 
for target "go-post-fetch" ignored
make[4]: "Makefile" line 35: warning: using previous script for 
"go-post-fetch" defined here

--- describe.x11-clocks ---
>8

Is anyone else seeing these warnings?

Best
Philipp

Re: Warnings about Mk/Uses/go.mk when building INDEX

2023-02-02 Thread Dmitri Goutnik 

On 02/02/2023 14:21, Philipp Ost wrote:

Hi everyone,

since at least two days, I'm getting these warning when building the INDEX:

8<
--- describe.www ---
make[4]: "/usr/ports/Mk/Uses/go.mk" line 192: warning: duplicate script 
for target "go-post-fetch" ignored
make[4]: "Makefile" line 35: warning: using previous script for 
"go-post-fetch" defined here
make[4]: "/usr/ports/Mk/Uses/go.mk" line 193: warning: duplicate script 
for target "go-post-fetch" ignored
make[4]: "Makefile" line 35: warning: using previous script for 
"go-post-fetch" defined here

--- describe.x11-clocks ---
>8

Is anyone else seeing these warnings?

Best
Philipp



I was also getting these warnings when bulk building Go ports in Poudriere:

[00:01:16] Warning: (www/gitlab-pages): make: "/usr/ports/Mk/Uses/go.mk" 
line 192: warning: duplicate script for target "go-post-fetch" ignored
[00:01:16] Warning: (www/gitlab-pages): make: "Makefile" line 35: 
warning: using previous script for "go-post-fetch" defined here
[00:01:16] Warning: (www/gitlab-pages): make: "/usr/ports/Mk/Uses/go.mk" 
line 193: warning: duplicate script for target "go-post-fetch" ignored
[00:01:16] Warning: (www/gitlab-pages): make: "Makefile" line 35: 
warning: using previous script for "go-post-fetch" defined here


www/gitlab-pages/Makefile has a comment on why overriding go-post-fetch 
was needed.


Best regards,

--
Dmitri Goutnik
d...@syrec.org | d...@freebsd.org

Re: Warnings about Mk/Uses/go.mk when building INDEX

2023-02-02 Thread Tomoaki AOKI 
On Thu, 2 Feb 2023 15:09:59 -0500
Dmitri Goutnik  wrote:

> On 02/02/2023 14:21, Philipp Ost wrote:
> > Hi everyone,
> > 
> > since at least two days, I'm getting these warning when building the INDEX:
> > 
> > 8<
> > --- describe.www ---
> > make[4]: "/usr/ports/Mk/Uses/go.mk" line 192: warning: duplicate script 
> > for target "go-post-fetch" ignored
> > make[4]: "Makefile" line 35: warning: using previous script for 
> > "go-post-fetch" defined here
> > make[4]: "/usr/ports/Mk/Uses/go.mk" line 193: warning: duplicate script 
> > for target "go-post-fetch" ignored
> > make[4]: "Makefile" line 35: warning: using previous script for 
> > "go-post-fetch" defined here
> > --- describe.x11-clocks ---
> > >8
> > 
> > Is anyone else seeing these warnings?
> > 
> > Best
> > Philipp
> > 
> 
> I was also getting these warnings when bulk building Go ports in Poudriere:
> 
> [00:01:16] Warning: (www/gitlab-pages): make: "/usr/ports/Mk/Uses/go.mk" 
> line 192: warning: duplicate script for target "go-post-fetch" ignored
> [00:01:16] Warning: (www/gitlab-pages): make: "Makefile" line 35: 
> warning: using previous script for "go-post-fetch" defined here
> [00:01:16] Warning: (www/gitlab-pages): make: "/usr/ports/Mk/Uses/go.mk" 
> line 193: warning: duplicate script for target "go-post-fetch" ignored
> [00:01:16] Warning: (www/gitlab-pages): make: "Makefile" line 35: 
> warning: using previous script for "go-post-fetch" defined here
> 
> www/gitlab-pages/Makefile has a comment on why overriding go-post-fetch 
> was needed.
> 
> Best regards,
> 
> -- 
> Dmitri Goutnik
> d...@syrec.org | d...@freebsd.org

Just a quick check (having not enough time and health):


% ugrep --binary --with-hex --exclude-dir=.git --exclude-dir=distfiles \
--exclude-dir=packages -r -n "USES" /usr/ports/www/ | ugrep " go" | \
cut -f 1 -w | cut -f 1 -d : | xargs fgrep -A 5 -B 5 "go-post-fetch"
/usr/ports/www/gitlab-workhorse/Makefile-ca_root_nss>0:security/ca_root_nss
/usr/ports/www/gitlab-workhorse/Makefile-MASTER_SITES+=
https://gitlab.com/gitlab-org/gitlab-foss/-/raw/v${DISTVERSION}/workhorse/
/usr/ports/www/gitlab-workhorse/Makefile-DISTFILES+=go.mod
/usr/ports/www/gitlab-workhorse/Makefile-DIST_SUBDIR=   go/$
{PKGORIGIN:S,/,_,g}/${DISTNAME}
/usr/ports/www/gitlab-workhorse/Makefile-EXTRACT_ONLY+= $
{DISTFILES:N*.mod\:*:N*.mod:C/:.*//}
/usr/ports/www/gitlab-workhorse/Makefile:_USES_fetch+=
800:go-post-fetch
/usr/ports/www/gitlab-workhorse/Makefile:go-post-fetch: 
/usr/ports/www/gitlab-workhorse/Makefile-
@${ECHO_MSG} "===> Fetching ${GO_MODNAME} dependencies"; 
/usr/ports/www/gitlab-workhorse/Makefile-   @(cd ${DISTDIR}/$
{DIST_SUBDIR}; \ 
/usr/ports/www/gitlab-workhorse/Makefile-   [ -e go.mod ]
|| ${RLN} ${GO_MODFILE} go.mod; \
/usr/ports/www/gitlab-workhorse/Makefile-   ${SETENV} $
{GO_ENV} GOPROXY=${GO_GOPROXY} ${GO_CMD} mod download -x all)
/usr/ports/www/gitlab-workhorse/Makefile-# ---



-- 
Tomoaki AOKI