[Differential] [Accepted] D2496: normalize output positions in setoperation
graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added a comment. This revision is now accepted and ready to land. The logic seems correct to me. REPOSITORY rLIBKSCREEN KScreen Library BRANCH sebas/positionnormalization REVISION DETAIL https://phabricator.kde.org/D2496 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma, graesslin Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: more Kirigami patches
Am 18.08.2016 um 17:52 schrieb Marco Martin: > On Tuesday 16 August 2016 20:23:45 Martin Gysel wrote: >> Hi >> Here are some patches I have in my branch. >> It contains a script to (re)generate the qml file, one the generate a >> resource file with possibly used icons and one to generaste a qmltypes file. >> It adds the icon resource to the pri file and updates the qml resource >> file. Furthermore the library target in the pro file seems to miss a >> kirigami dir level. > > any news on this? > i can take another look at the patches and integrate the ones that are good, > but it's more work for us. > could you consider to do review requests and eventually oush, to see wether > is > a workflow/contribution model that you would be interested in? (even rarely, > or > from time to time, is very valuable for us never the less) > I've just rebased my patches and will create a review request in a couple of minutes
Re: fix Kirigami qrc file
On Thursday 18 August 2016 22:07:08 Dirk Hohndel wrote: > From fb2d355d00011f7ff9a0a7ea69ea93ecc36a5486 Mon Sep 17 00:00:00 2001 > From: Dirk Hohndel > Date: Thu, 18 Aug 2016 22:05:25 -0700 > Subject: [PATCH] Remove reference to Icon.qml under desktop style thanks, pushed -- Marco Martin
[Differential] [Request, 149 lines] D2498: various patches for qmake support
bearsh created this revision.
bearsh added a reviewer: mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
add simple script to generate a qrc containing all qml files
add script to find possible used icons in kirigami
add script to gen a qmltypes file
improve kirigami dir detection
fix target/library path in qmake project file
add kirigami icons as resource
update qml resource file
add dektopicon.{cpp,h} to pri file
this files are only needed for the desktop, so only add them on platform
is not ios and not android
use 'one line per file' style to make diff easier
REPOSITORY
rKIRIGAMI Kirigami
BRANCH
bearsh
REVISION DETAIL
https://phabricator.kde.org/D2498
AFFECTED FILES
kirigami-icons.qrc
kirigami.pri
kirigami.pro
kirigami.qrc
scripts/gen_icons_qrc.sh
scripts/gen_qml_qrc.sh
scripts/gen_qmltypes.sh
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bearsh, mart
Cc: plasma-devel
[Differential] [Closed] D2345: use a separate configuration per look and feel
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEc22f0ce63e64: remove dead code (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2345?vs=6043&id=6058#toc REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2345?vs=6043&id=6058 REVISION DETAIL https://phabricator.kde.org/D2345 AFFECTED FILES shell/scripting/containment.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma, ivan Cc: graesslin, davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Review Request 128707: Add support for captive portals
> On Aug. 19, 2016, 8:23 a.m., Martin Gräßlin wrote: > > I'm not happy with the QWebEngineView as that's going to crash on Wayland. > > Every application using QWebEngine needs to be on xcb unfortunately. So > > that means that we cannot really use anything of QWebEngine in Plasma > > (which is supposed to work on Wayland) Just tried a bit, here is IRC log: [10:07] notmart: [10:07] [0819/100656:ERROR:gl_surface_qt.cpp(187)] GLContextHelper::getXConfig() failed. [10:07] Segmentation fault (core dumped) [10:08] woha [10:08] notmart: that was the demobrowser [10:08] same with minimal [10:08] the qml one as well? [10:08] (which defies a bit the point of qml bindings for the thing) [10:08] quicknanobrowser? [10:09] that or angelfish [10:09] sec, has missing deps [10:10] notmart: yep, also asserts and prints the getXConfig warning [10:10] notmart: adding --platform xcb makes it start, but that's of course no option [10:11] yep, not for stuff inside plasma for sure - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98490 --- On Aug. 18, 2016, 2:47 p.m., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128707/ > --- > > (Updated Aug. 18, 2016, 2:47 p.m.) > > > Review request for Network Management, Plasma, KDE Usability, and Lamarque > Souza. > > > Bugs: 365417 > http://bugs.kde.org/show_bug.cgi?id=365417 > > > Repository: plasma-nm > > > Description > --- > > Adds portal monitor to our kded module, which checks NetworkManager > connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we > are behind a captive portal), then we open a QWebEngineView trying to load > "http://kde.org"; page which is supposed to be redirected to the captive > portal page. Once user logs in and url changes, we re-check the connectivity > again and close the web view if we are no longer behind the captive portal. > > > Diffs > - > > CMakeLists.txt a27c1f2 > kded/CMakeLists.txt 1f0613e > kded/portalmonitor.h PRE-CREATION > kded/portalmonitor.cpp PRE-CREATION > kded/service.cpp 18ffd41 > > Diff: https://git.reviewboard.kde.org/r/128707/diff/ > > > Testing > --- > > Tested with three different captive portals and it worked perfectly. > > > Thanks, > > Jan Grulich > >
plasma-devel@kde.org
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPda07e3f66345: use dbus interface to switch shell l&f (authored by mart). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2448?vs=6038&id=6059 REVISION DETAIL https://phabricator.kde.org/D2448 AFFECTED FILES kcms/lookandfeel/kcm.cpp kcms/lookandfeel/kcm.h kcms/lookandfeel/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: colomar, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: [PATCH 1/7] add simple script to generate a qrc containing all qml files
Am 19.08.2016 um 03:24 schrieb Aleix Pol:
> Can you please upload the patches to phabricator.kde.org or
> reviewboard.kde.org?
>
done
> Thanks!
> Aleix
>
> On Tue, Aug 16, 2016 at 8:23 PM, Martin Gysel wrote:
>> ---
>> scripts/gen_qml_qrc.sh | 39 +++
>> 1 file changed, 39 insertions(+)
>> create mode 100755 scripts/gen_qml_qrc.sh
>>
>> diff --git a/scripts/gen_qml_qrc.sh b/scripts/gen_qml_qrc.sh
>> new file mode 100755
>> index 000..6e1c378
>> --- /dev/null
>> +++ b/scripts/gen_qml_qrc.sh
>> @@ -0,0 +1,39 @@
>> +#!/usr/bin/env bash
>> +
>> +TAB=""
>> +
>> +kirigami_dir="$(dirname $(readlink -f $0))/.."
>> +
>> +case $1 in
>> +-h|--help)
>> + echo "usage: $(basename $0) [QRC_FILE]"
>> + exit 1
>> + ;;
>> +esac
>> +
>> +pushd ${kirigami_dir} > /dev/null
>> +
>> +tmpfile=$(mktemp)
>> +
>> +echo "" > ${tmpfile}
>> +echo "${TAB}" >> ${tmpfile}
>> +
>> +for i in $(find src/controls/ -name *.qml); do
>> + echo -e "${TAB}${TAB}${i}"
>> >> ${tmpfile};
>> +done
>> +for i in $(find src/styles/ -name *.qml); do
>> +echo -e "${TAB}${TAB}${i}" >>
>> ${tmpfile};
>> +done
>> +
>> +echo "${TAB}" >> ${tmpfile}
>> +echo "" >> ${tmpfile}
>> +
>> +if [[ -n $1 ]]; then
>> + cat ${tmpfile} > $1
>> +else
>> + cat ${tmpfile}
>> +fi
>> +
>> +unlink ${tmpfile}
>> +
>> +popd > /dev/null
>> --
>> 2.9.3
>>
>
> Hi
>
[Differential] [Closed] D2449: small utility to create L&F packages
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMASDKa3d6dff738d2: small utility to create L&F packages (authored by mart). REPOSITORY rPLASMASDK Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2449?vs=5983&id=6060 REVISION DETAIL https://phabricator.kde.org/D2449 AFFECTED FILES CMakeLists.txt lookandfeelexplorer/CMakeLists.txt lookandfeelexplorer/Messages.sh lookandfeelexplorer/package/contents/ui/FormField.qml lookandfeelexplorer/package/contents/ui/FormLabel.qml lookandfeelexplorer/package/contents/ui/MetadataEditor.qml lookandfeelexplorer/package/contents/ui/main.qml lookandfeelexplorer/package/metadata.desktop lookandfeelexplorer/src/CMakeLists.txt lookandfeelexplorer/src/lnflistmodel.cpp lookandfeelexplorer/src/lnflistmodel.h lookandfeelexplorer/src/lnflogic.cpp lookandfeelexplorer/src/lnflogic.h lookandfeelexplorer/src/main.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Review Request 128707: Add support for captive portals
> On Aug. 19, 2016, 8:23 a.m., Martin Gräßlin wrote: > > I'm not happy with the QWebEngineView as that's going to crash on Wayland. > > Every application using QWebEngine needs to be on xcb unfortunately. So > > that means that we cannot really use anything of QWebEngine in Plasma > > (which is supposed to work on Wayland) > > Martin Gräßlin wrote: > Just tried a bit, here is IRC log: > [10:07] notmart: > [10:07] [0819/100656:ERROR:gl_surface_qt.cpp(187)] > GLContextHelper::getXConfig() failed. > [10:07] Segmentation fault (core dumped) > [10:08] woha > [10:08] notmart: that was the demobrowser > [10:08] same with minimal > [10:08] the qml one as well? > [10:08] (which defies a bit the point of qml bindings for the > thing) > [10:08] quicknanobrowser? > [10:09] that or angelfish > [10:09] sec, has missing deps > [10:10] notmart: yep, also asserts and prints the > getXConfig warning > [10:10] notmart: adding --platform xcb makes it start, > but that's of course no option > [10:11] yep, not for stuff inside plasma for sure now reported upstream: https://bugreports.qt.io/browse/QTBUG-55384 - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98490 --- On Aug. 18, 2016, 2:47 p.m., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128707/ > --- > > (Updated Aug. 18, 2016, 2:47 p.m.) > > > Review request for Network Management, Plasma, KDE Usability, and Lamarque > Souza. > > > Bugs: 365417 > http://bugs.kde.org/show_bug.cgi?id=365417 > > > Repository: plasma-nm > > > Description > --- > > Adds portal monitor to our kded module, which checks NetworkManager > connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we > are behind a captive portal), then we open a QWebEngineView trying to load > "http://kde.org"; page which is supposed to be redirected to the captive > portal page. Once user logs in and url changes, we re-check the connectivity > again and close the web view if we are no longer behind the captive portal. > > > Diffs > - > > CMakeLists.txt a27c1f2 > kded/CMakeLists.txt 1f0613e > kded/portalmonitor.h PRE-CREATION > kded/portalmonitor.cpp PRE-CREATION > kded/service.cpp 18ffd41 > > Diff: https://git.reviewboard.kde.org/r/128707/diff/ > > > Testing > --- > > Tested with three different captive portals and it worked perfectly. > > > Thanks, > > Jan Grulich > >
[Differential] [Request, 8 lines] D2499: [Plasmashell] Expose isStartupCompleted on DBus
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This would eventually allow KWin effects to react on that and e.g. only do an animation on startup but not when plasma crashed and restarted. TEST PLAN the propertieschanged signal doesn't seem to be emitted :/ I just figured, wouldn't a plain signal work? startupCompleted and kwin connects to it? Kwin just needs to know that plasma started once and then doesn't care if it later restarted etc? Dunno. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2499 AFFECTED FILES shell/dbus/org.kde.PlasmaShell.xml shell/shellcorona.cpp shell/shellcorona.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D2495: Supress QML warning
broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2495 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, broulik Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2488: [Desktop Containment] Animate margin changes due to available screen rect
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP3b212cb8094f: [Desktop Containment] Animate margin changes due to available screen rect (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2488?vs=6042&id=6062 REVISION DETAIL https://phabricator.kde.org/D2488 AFFECTED FILES containments/desktop/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2489: [Containment Actions Configuration] Add labels for Back / Forward mouse buttons
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP6fbb178f03a6: [Containment Actions Configuration] Add labels for Back / Forward mouse buttons (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2489?vs=6044&id=6064 REVISION DETAIL https://phabricator.kde.org/D2489 AFFECTED FILES desktoppackage/contents/configuration/ConfigurationContainmentActions.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2490: [Desktop Toolbox] Animate position change
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP84c9b27b9784: [Desktop Toolbox] Animate position change (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2490?vs=6046&id=6063#toc REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2490?vs=6046&id=6063 REVISION DETAIL https://phabricator.kde.org/D2490 AFFECTED FILES toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2491: [Kickoff] Mirror breadcrumb arrow in right-to-left layout
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPb26c6ed1ef92: [Kickoff] Mirror breadcrumb arrow in right-to-left layout (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2491?vs=6047&id=6065 REVISION DETAIL https://phabricator.kde.org/D2491 AFFECTED FILES applets/kickoff/package/contents/ui/Breadcrumb.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2492: [Panel Containment] Cleanup
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP50dc4358753f: [Panel Containment] Cleanup (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2492?vs=6048&id=6066 REVISION DETAIL https://phabricator.kde.org/D2492 AFFECTED FILES containments/panel/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D2473: Create Cursor instance through Platform
mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> CMakeLists.txt:7
> +include_directories(../../)
> +set (kwinrules_MOC_HDRS yesnobox.h ../../client_machine.h ../../cursor.h
> ../../plugins/platforms/x11/standalone/x11cursor.h)
> qt5_wrap_cpp(kwinrules_MOC_SRCS ${kwinrules_MOC_HDRS})
is ../../ needed for those paths if there is already
include_directories(../../) ?
REPOSITORY
rKWIN KWin
BRANCH
x11cursor-to-platform
REVISION DETAIL
https://phabricator.kde.org/D2473
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: mart, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening,
jensreuterberg, abetts, sebas
[Differential] [Commented On] D2473: Create Cursor instance through Platform
graesslin added inline comments. INLINE COMMENTS > mart wrote in CMakeLists.txt:7 > is ../../ needed for those paths if there is already > include_directories(../../) ? I tried without, but it didn't pick it up. This whole thing is weird and needs to somehow be reworked. REPOSITORY rKWIN KWin BRANCH x11cursor-to-platform REVISION DETAIL https://phabricator.kde.org/D2473 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, mart Cc: mart, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Closed] D2473: Create Cursor instance through Platform
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN2a8ab547e186: Move X11Cursor into the x11standalone platform plugin (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2473?vs=6009&id=6068#toc REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2473?vs=6009&id=6068 REVISION DETAIL https://phabricator.kde.org/D2473 AFFECTED FILES CMakeLists.txt cursor.cpp cursor.h kcmkwin/kwinrules/CMakeLists.txt kcmkwin/kwinrules/detectwidget.cpp kcmkwin/kwinrules/kwinsrc.cpp keyboard_input.h plugins/platforms/x11/standalone/CMakeLists.txt plugins/platforms/x11/standalone/x11_platform.cpp plugins/platforms/x11/standalone/x11_platform.h plugins/platforms/x11/standalone/x11cursor.cpp plugins/platforms/x11/standalone/x11cursor.h plugins/platforms/x11/standalone/xinputintegration.cpp plugins/platforms/x11/standalone/xinputintegration.h utils.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, mart Cc: mart, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Abandoned] D2240: Anchors in a layout item is always wrong
davidedmundson abandoned this revision. davidedmundson added a comment. I merged this a while ago. Closing. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2240 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, sebas Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2495: Supress QML warning
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPe202289ea3d7: Supress QML warning (authored by davidedmundson). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2495?vs=6053&id=6069 REVISION DETAIL https://phabricator.kde.org/D2495 AFFECTED FILES applets/taskmanager/package/contents/ui/ToolTipDelegate.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, broulik Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2499: [Plasmashell] Expose isStartupCompleted on DBus
mart added a comment. > the propertieschanged signal doesn't seem to be emitted :/ so us this working or not? what is the problem? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2499 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D2481: install new header
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2481 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D2498: various patches for qmake support
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH bearsh REVISION DETAIL https://phabricator.kde.org/D2498 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bearsh, mart Cc: plasma-devel
[Differential] [Accepted] D2481: install new header
bshah accepted this revision. bshah added a reviewer: bshah. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2481 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, davidedmundson, bshah Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Changed Subscribers] D2494: Install avatar icons in subfolders
bshah added a subscriber: plasma-devel. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D2494 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel
[Differential] [Closed] D2481: install new header
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE40e5ffbb357b: install new header (authored by sitter). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2481?vs=6027&id=6070 REVISION DETAIL https://phabricator.kde.org/D2481 AFFECTED FILES libtaskmanager/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, davidedmundson, bshah Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Changed Subscribers] D2493: Set uniform icon sizes in UserManager gallery
bshah added a subscriber: plasma-devel. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D2493 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel
[Differential] [Accepted] D2493: Set uniform icon sizes in UserManager gallery
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D2493 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: plasma-devel
[Differential] [Commented On] D2449: small utility to create L&F packages
colomar added a comment. Can you please provide screenshots of the tool? Yes, even developer-centric tools should get a UI review ;) REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: colomar, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D2494: Install avatar icons in subfolders
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rUSERMANAGER User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D2494 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: plasma-devel
[Differential] [Commented On] D2449: small utility to create L&F packages
mart added a comment. http://imgur.com/a/jAKSv REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: colomar, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2498: various patches for qmake support
mart added a comment. the patch is ok for me. can you go forward with the devel account/submission process? REPOSITORY rKIRIGAMI Kirigami BRANCH bearsh REVISION DETAIL https://phabricator.kde.org/D2498 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bearsh, mart Cc: plasma-devel
[Differential] [Abandoned] D2499: [Plasmashell] Expose isStartupCompleted on DBus
broulik abandoned this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2499 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 11 lines] D2500: [Plasmashell] Unload "Scale in Desktop" effect when started
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This ensures the desktop is only animated on login so it doesn't distract when Plasma restarts or a new output is added. TEST PLAN For https://phabricator.kde.org/D2486 Started plasmashell, desktop zoomed in, restarted plasmashell, desktop appeared right away. This avoids plasmashell-specific code in KWin. Of course if kwin restarts this will be reset but this is less likely than Plasma going down :) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2500 AFFECTED FILES shell/shellcorona.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 4 lines] D2501: Make ActionButton expand to fit largest word in the row
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Action button now word wraps at grid unit * 4 but will expand to fit the largest word in that row. ...without making a binding loop. TEST PLAN Added some super long text in one of the buttons. It looks fine. http://imgur.com/a/3evqM REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2501 AFFECTED FILES sddm-theme/ActionButton.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2449: small utility to create L&F packages
colomar added a comment. Thanks! Feedback: - The lineedits should be made long enough to actually hold the whole content (for the comment, maybe a textbox would be better?), because editing in a field which is too small for the content is really annoying. - How does one save changes? - Is it possible to change the thumbnail in there as well? REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: colomar, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2449: small utility to create L&F packages
mart added a comment. In https://phabricator.kde.org/D2449#46735, @colomar wrote: > Thanks! > Feedback: > > - The lineedits should be made long enough to actually hold the whole content (for the comment, maybe a textbox would be better?), because editing in a field which is too small for the content is really annoying. ok > - How does one save changes? it's instant save, some pieces couldn't be done differently at the moment > - Is it possible to change the thumbnail in there as well? yes, click on it or drag and drop (when is empty it shows a label telling this) REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: colomar, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128699/#review98496 --- Ship it! Honoured to oblige. :) - Sebastian Kügler On Aug. 18, 2016, 6:23 p.m., Ken Vermette wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128699/ > --- > > (Updated Aug. 18, 2016, 6:23 p.m.) > > > Review request for Plasma. > > > Repository: breeze > > > Description > --- > > New wallpaper for Plasma 5.8 > > Bringing back some colour to our wallpapers - they kept getting darker and > some people were disappointed at that, so for the 5.8 LTS I think we can > celebrate a bit. > > This wallpaper will also be available in 4K resolution. > > Link to VDG Share download: > https://share.kde.org/index.php/s/M4fzjKibKeZFyMx > > > Diffs > - > > wallpapers/Next/contents/images/1024x768.png 60e1205 > wallpapers/Next/contents/images/1280x1024.png 36a9130 > wallpapers/Next/contents/images/1280x800.png c33e594 > wallpapers/Next/contents/images/1440x900.png 2c75b54 > wallpapers/Next/contents/images/1600x1200.png 5ddaf72 > wallpapers/Next/contents/images/1638x1024.png a3c7492 > wallpapers/Next/contents/images/1680x1050.png eddc47e > wallpapers/Next/contents/images/1920x1080.png ab6d950 > wallpapers/Next/contents/images/2560x1440.png 5c78e9d > wallpapers/Next/contents/images/2560x1600.png eeb08a1 > wallpapers/Next/contents/images/3200x1800.png 7340567 > wallpapers/Next/contents/images/3200x2000.png fd1a62c > wallpapers/Next/contents/screenshot.png a6d2b7b > > Diff: https://git.reviewboard.kde.org/r/128699/diff/ > > > Testing > --- > > > File Attachments > > > 2560x1600.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/d8dc1072-2ad1-4954-b339-a7319e2d765b__2560x1600.png > preview.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/1adec791-1f97-4887-976c-6eb5363b26e3__preview.png > splash.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/ceb0bf36-a476-4725-b0d6-6f7f74d990df__splash.png > 2560x1600-UPDATED.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/18/119c1e58-03bb-45ca-a3e6-13f3fe4c3e6c__2560x1600.png > > > Thanks, > > Ken Vermette > >
[Differential] [Closed] D2465: [kded] correctly restore lidOpened configuration on startup
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENf04d6d3c3c8a: [kded] correctly restore lidOpened configuration on startup (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2465?vs=6024&id=6073 REVISION DETAIL https://phabricator.kde.org/D2465 AFFECTED FILES kded/daemon.cpp kded/serializer.cpp kded/serializer.h tests/kded/serializertest.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma, graesslin Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2496: normalize output positions in setoperation
This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSCREEN90d8ee283f88: normalize output positions in setoperation (authored by sebas). REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2496?vs=6054&id=6074 REVISION DETAIL https://phabricator.kde.org/D2496 AFFECTED FILES autotests/testscreenconfig.cpp src/setconfigoperation.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma, graesslin Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128699/#review98497 --- Ship it! Go go go ;) - Kai Uwe Broulik On Aug. 18, 2016, 6:23 nachm., Ken Vermette wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128699/ > --- > > (Updated Aug. 18, 2016, 6:23 nachm.) > > > Review request for Plasma. > > > Repository: breeze > > > Description > --- > > New wallpaper for Plasma 5.8 > > Bringing back some colour to our wallpapers - they kept getting darker and > some people were disappointed at that, so for the 5.8 LTS I think we can > celebrate a bit. > > This wallpaper will also be available in 4K resolution. > > Link to VDG Share download: > https://share.kde.org/index.php/s/M4fzjKibKeZFyMx > > > Diffs > - > > wallpapers/Next/contents/images/1024x768.png 60e1205 > wallpapers/Next/contents/images/1280x1024.png 36a9130 > wallpapers/Next/contents/images/1280x800.png c33e594 > wallpapers/Next/contents/images/1440x900.png 2c75b54 > wallpapers/Next/contents/images/1600x1200.png 5ddaf72 > wallpapers/Next/contents/images/1638x1024.png a3c7492 > wallpapers/Next/contents/images/1680x1050.png eddc47e > wallpapers/Next/contents/images/1920x1080.png ab6d950 > wallpapers/Next/contents/images/2560x1440.png 5c78e9d > wallpapers/Next/contents/images/2560x1600.png eeb08a1 > wallpapers/Next/contents/images/3200x1800.png 7340567 > wallpapers/Next/contents/images/3200x2000.png fd1a62c > wallpapers/Next/contents/screenshot.png a6d2b7b > > Diff: https://git.reviewboard.kde.org/r/128699/diff/ > > > Testing > --- > > > File Attachments > > > 2560x1600.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/d8dc1072-2ad1-4954-b339-a7319e2d765b__2560x1600.png > preview.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/1adec791-1f97-4887-976c-6eb5363b26e3__preview.png > splash.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/ceb0bf36-a476-4725-b0d6-6f7f74d990df__splash.png > 2560x1600-UPDATED.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/18/119c1e58-03bb-45ca-a3e6-13f3fe4c3e6c__2560x1600.png > > > Thanks, > > Ken Vermette > >
[Differential] [Commented On] D2501: Make ActionButton expand to fit largest word in the row
mart added a comment. better, tough, i guess wether would be possible for this line of buttons to out all buttons at the same space (so using the size of the biggest one) without ending up in horrible binding loops REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2501 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2501: Make ActionButton expand to fit largest word in the row
davidedmundson added a comment. In https://phabricator.kde.org/D2501#46741, @mart wrote: > better, tough, i guess wether would be possible for this line of buttons to out all buttons at the same space (so using the size of the biggest one) without ending up in horrible binding loops Maybe. I'm not sure how without looping through items, or changing/reimplementing Layout and in any case it would need this patch first. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2501 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2449: small utility to create L&F packages
colomar added a comment. In https://phabricator.kde.org/D2449#46736, @mart wrote: > > it's instant save, some pieces couldn't be done differently at the moment Hm, I think that's a problem. 1. Instant apply is not a common pattern in KDE software at all and therefore unexpected 2. Instant save in an edit field cannot really be done predictably, as the user can never tell exactly when it's saved (certainly not with any character typed, right?) Why not just use a save button? >> - Is it possible to change the thumbnail in there as well? > > yes, click on it or drag and drop (when is empty it shows a label telling this) Ah, perfect! REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: colomar, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2501: Make ActionButton expand to fit largest word in the row
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE236b475a1c28: Make ActionButton expand to fit largest word in the row (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2501?vs=6072&id=6075 REVISION DETAIL https://phabricator.kde.org/D2501 AFFECTED FILES sddm-theme/ActionButton.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2494: Install avatar icons in subfolders
This revision was automatically updated to reflect the committed changes. Closed by commit rUSERMANAGERe63e702adf78: Install avatar icons in subfolders (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2494?vs=6050&id=6076#toc REPOSITORY rUSERMANAGER User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2494?vs=6050&id=6076 REVISION DETAIL https://phabricator.kde.org/D2494 AFFECTED FILES src/CMakeLists.txt src/avatargallery.cpp src/pics/Ada Lovelace.png src/pics/Alice in Wonderland.png src/pics/Blackbox.png src/pics/CMakeLists.txt src/pics/Dragon.png src/pics/Grace Hopper.png src/pics/Green.png src/pics/Happy.png src/pics/Kati.png src/pics/Konqui.png src/pics/Leonardo da Vinci.png src/pics/Listening.png src/pics/Logger.png src/pics/Mahatma Gandhi.png src/pics/Mowgli jungle book.png src/pics/Notme.png src/pics/Parley.png src/pics/Rekonqui.png src/pics/TV.png src/pics/User.png src/pics/bluesstyle/Ada Lovelace.png src/pics/bluesstyle/Alice in Wonderland.png src/pics/bluesstyle/Grace Hopper.png src/pics/bluesstyle/Leonardo da Vinci.png src/pics/bluesstyle/Mahatma Gandhi.png src/pics/bluesstyle/Mowgli jungle book.png src/pics/bluesstyle/User.png src/pics/bomb.png src/pics/classic/Blackbox.png src/pics/classic/Bomb.png src/pics/classic/Dragon.png src/pics/classic/Green.png src/pics/classic/Happy.png src/pics/classic/Listening.png src/pics/classic/Notme.png src/pics/classic/TV.png src/pics/konqui/Kati.png src/pics/konqui/Konqui.png src/pics/konqui/Logger.png src/pics/konqui/Parley.png src/pics/konqui/Rekonqui.png src/pics/sources/Ada Lovelace.svg src/pics/sources/Alice in Wonderland.svg src/pics/sources/Dragon.svg src/pics/sources/Grace Hopper.svg src/pics/sources/Kati.svg src/pics/sources/Konqui.svg src/pics/sources/Leonardo da Vinci.svg src/pics/sources/Logger.svg src/pics/sources/Mahatma Gandhi.svg src/pics/sources/Mowgli jungle book.svg src/pics/sources/Parley.svg src/pics/sources/Rekonqui.svg src/pics/sources/User.svg src/pics/sources/blackbox.svgz src/pics/sources/bomb.svgz src/pics/sources/green.svgz src/pics/sources/happy.svgz src/pics/sources/listening.svgz src/pics/sources/notme.svgz src/pics/sources/tv.svgz src/pics_sources/Ada Lovelace.svg src/pics_sources/Alice in Wonderland.svg src/pics_sources/Dragon.svg src/pics_sources/Grace Hopper.svg src/pics_sources/Kati.svg src/pics_sources/Konqui.svg src/pics_sources/Leonardo da Vinci.svg src/pics_sources/Logger.svg src/pics_sources/Mahatma Gandhi.svg src/pics_sources/Mowgli jungle book.svg src/pics_sources/Parley.svg src/pics_sources/Rekonqui.svg src/pics_sources/User.svg src/pics_sources/blackbox.svgz src/pics_sources/bomb.svgz src/pics_sources/green.svgz src/pics_sources/happy.svgz src/pics_sources/listening.svgz src/pics_sources/notme.svgz src/pics_sources/tv.svgz EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: plasma-devel
[Differential] [Commented On] D2449: small utility to create L&F packages
mart added a comment. In https://phabricator.kde.org/D2449#46744, @colomar wrote: > In https://phabricator.kde.org/D2449#46736, @mart wrote: > > > > > > 2. Instant save in an edit field cannot really be done predictably, as the user can never tell exactly when it's saved (certainly not with any character typed, right?) > > Why not just use a save button? bacause the two buttons to take the defaults file and the desktop layout copy files the instant they are clicked. i can try to give it a logic of keeping things in memory until saved, will see how much i have to change REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: colomar, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 434 lines] D2502: New design for logout screen
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY change the logout screen to the new design: user avatar and action buttons shared with SDDM, old custom files removed REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH mart/newLogoutScreen REVISION DETAIL https://phabricator.kde.org/D2502 AFFECTED FILES lookandfeel/contents/components/LogoutOptions.qml lookandfeel/contents/components/LogoutScreen.qml lookandfeel/contents/logout/Logout.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated] D2502: New design for logout screen
mart added a reviewer: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2502 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2502: New design for logout screen
mart added a comment. http://imgur.com/a/B6abc REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2502 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2502: New design for logout screen
mart added a comment. difference from the mockup, only buttons currently supported by the logout screen implemented atm REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2502 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2498: various patches for qmake support
bearsh added a comment. In https://phabricator.kde.org/D2498#46714, @mart wrote: > can you go forward with the devel account/submission process? "Developer account application submitted successfully on KDE Identity" :) REPOSITORY rKIRIGAMI Kirigami BRANCH bearsh REVISION DETAIL https://phabricator.kde.org/D2498 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bearsh, mart Cc: plasma-devel
[Differential] [Commented On] D2500: [Plasmashell] Unload "Scale in Desktop" effect when started
graesslin added a comment. Unfortunately that won't work either. KWin will load the effect again whenever compositing is getting restarted. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2500 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 4 lines] D2503: Don't assume UserDelegate is in a ListView
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This means if it's used elsewhere (for example the logout screen) we don't create a pointless attached QObject. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2503 AFFECTED FILES lookandfeel/contents/components/UserDelegate.qml lookandfeel/contents/components/UserList.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D2503: Don't assume UserDelegate is in a ListView
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. thanks :) REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2503 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland
graesslin added a comment. I would like to see this integrated. But I think a few things need to be done: - I would love to see the example you had in your blog post added to tests - I'm still unhappy about the name KWinQml - it's just not saying what it is. And actually it's not Qml at all. It's a declarative implementation. Might need brainstorming, maybe even broader on the mailinglist. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1989 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, graesslin, #plasma_on_wayland Cc: bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Accepted] D2344: Make linux/input.h compile time optional
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH linux-input-optional REVISION DETAIL https://phabricator.kde.org/D2344 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, tcberner, #plasma_on_wayland, sebas Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Changed Subscribers] D2502: New design for logout screen
broulik added inline comments.
INLINE COMMENTS
> Logout.qml:45
> +function sleepRequested() {
> +suspendRequested(2);
> +}
Can we have an enum for that?
> Logout.qml:67
> +onTriggered: root.cancelRequested()
> +shortcut: "Escape"
> +}
There's no "Return"/"Enter" to accept, is there?
Also, I think the arrow keys should switch between the modes to fully allow
using the dialog with keyboard only.
> Logout.qml:104
> +ColumnLayout {
> +id: prompts
> +anchors {
Unused id
> Logout.qml:122
> +action: root.sleepRequested
> +opacity: 0.6
> +}
Suspend might not be available on the machine, should not be shown then.
Also, what about hibernate?
> Logout.qml:128
> +action: root.rebootRequested
> +opacity: sdtype == ShutdownType.ShutdownTypeReboot ? 1 : 0.6
> +}
Given you already set currentAction based on the sdtype, could be simplified to
opacity: root.currentAction === action ? 1 : 0.6
This would also ease the keyboard nav stuff.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2502
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas
[Differential] [Commented On] D2502: New design for logout screen
broulik added inline comments.
INLINE COMMENTS
> Logout.qml:147
> +text: {
> +switch (sdtype) {
> +case ShutdownType.ShutdownTypeReboot:
Also bind to currentAction insted of sdtype
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2502
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas
[Differential] [Request, 1 line] D2504: add a comment to get a summary in autogenerated appstream data
sitter created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY summary is a required field in appstream data, without one we won't show up in appstream-based stores REPOSITORY rKINFOCENTER KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D2504 AFFECTED FILES org.kde.kinfocenter.desktop EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2503: Don't assume UserDelegate is in a ListView
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEde7c54a6c038: Don't assume UserDelegate is in a ListView (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2503?vs=6078&id=6080 REVISION DETAIL https://phabricator.kde.org/D2503 AFFECTED FILES lookandfeel/contents/components/UserDelegate.qml lookandfeel/contents/components/UserList.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D2504: add a comment to get a summary in autogenerated appstream data
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKINFOCENTER KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D2504 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2504: add a comment to get a summary in autogenerated appstream data
This revision was automatically updated to reflect the committed changes. Closed by commit rKINFOCENTERf7e4966ebd38: add a comment to get a summary in autogenerated appstream data (authored by sitter). REPOSITORY rKINFOCENTER KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2504?vs=6079&id=6081 REVISION DETAIL https://phabricator.kde.org/D2504 AFFECTED FILES org.kde.kinfocenter.desktop EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 229 lines] D2505: Don't do instant save
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY use a save button instead of having instant save on all the fields this is more coherent with the behavior of normal applications REPOSITORY rPLASMASDK Plasma SDK BRANCH phab/savebutton REVISION DETAIL https://phabricator.kde.org/D2505 AFFECTED FILES lookandfeelexplorer/package/contents/ui/FormField.qml lookandfeelexplorer/package/contents/ui/main.qml lookandfeelexplorer/src/lnflogic.cpp lookandfeelexplorer/src/lnflogic.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated] D2505: Don't do instant save
mart added a reviewer: Plasma. REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2505 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2449: small utility to create L&F packages
mart added a comment. https://phabricator.kde.org/D2505 REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: colomar, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2505: Don't do instant save
mart added a comment. http://imgur.com/a/nckJh REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2505 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Selecting a Plasma logo
Il 19-08-2016 16:19 Olivier Churlaud ha scritto: Il 11-08-2016 11:37 Ivan Čukić ha scritto: Hi all, For anyone interested I've also posted the SVG file (Andreas asked for it): https://share.kde.org/index.php/s/0HRcGXCt6UCEWxp Cheers, Ivan I updated it with the last version of my logo (posted on Forums) plus a new version: https://share.kde.org/index.php/s/Jo9ADJYOpWsyxIW In the new version there is a ">" that stands for "shell" and it's in the current Plasma logo too, a gear like the K logo one that looks like Sun, since Sun is made by plasma and the ">" contribute to make it look like a Sun with a sort of "eclipse" effect. I'm surprised, because I really like the "eclipse-like" one you added. I'm surprised specially because I expected to be really cluttered and at the end, I think it plays good and adds a great dynamic. But honestly I wouldn't be able to choose THE one. Several have good qualities: it's tough. Cheers Olivier Cheers, I know what you mean, the submissions are very good but not perfect. I'm currently a bit more for this last one with eclipse effect, I like it in my panel, but still not sure. I hope in new ideas by the others. Cheers, -- Alessandro Longo
[Differential] [Request, 68 lines] D2506: Forward x11 raw pointer buttons to PointerInputRedirection
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The raw pointer button events intercepted in the XInput2 input filter get sent through the Platform to the PointerInputRedirection. This makes the PointerInputRedirection track the pointer button state and emit the signals for button changed and axis changed. These signals are used by the modifier-only shortcut detection to determine whether the shortcut should trigger. On X11 the "normal" input handling doesn't use the InputRedirection and the emitted signals are not consumed by anything else. As PointerInputRedirection is not inited the events are not forwarded to the input filter, thus won't be processed by other parts and won't interfere with the normal event processing on X11. Given that it also doesn't matter that the input filter does not apply the left-handed setting. The internal tracking will have a wrong mouse button, but nothing is going to do decisions based on the value of the pressed mouse button. For the moment all we are interested in is that a button is pressed. TEST PLAN Pressed meta, clicked, scrolled, released meta: launcher did not open. Pressed meta, released meta: launcher opened REPOSITORY rKWIN KWin BRANCH x11-buttons-to-platform REVISION DETAIL https://phabricator.kde.org/D2506 AFFECTED FILES plugins/platforms/x11/standalone/xinputintegration.cpp pointer_input.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
Plasma 5.8 Release Notes
Hi all,I just setup an Etherpad for the Plasma 5.8 Release announcement. Please fill in all the amazing stuff you did in the past months so we can come up with a good story and video for our LTS release. :)https://notes.kde.org/p/plasma_5_8Cheers,Kai Uwe
Re: Review Request 128616: Fix wrong or missing "X-KDE-ParentApp" in desktop file definitions (and fix copy&paste errors in API dox)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128616/#review98498 --- Ship it! it's ok, but can you split the documentation changes and the desktop file changes in 2 separate commits? - Marco Martin On Aug. 15, 2016, 3:01 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128616/ > --- > > (Updated Aug. 15, 2016, 3:01 p.m.) > > > Review request for KDE Frameworks, Plasma and Marco Martin. > > > Repository: plasma-framework > > > Description > --- > > plasma-dataengine.desktop misses at least the definition of "X-KDE-ParentApp" > property. > > plasma-applet.desktop defines a "X-Plasma-ParentApp" property, but in code > and API dox the respective key used is named "X-KDE-ParentApp". > > E.g. `kcoreaddons_desktop_to_json` used with `SERVICE_TYPES` > `plasma-dataengine.desktop` or `plasma-applet.desktop` complains about that > for desktop files with such entries. > > While looking at that property, the related API dox of `Plasma::PluginLoader` > has lots of copy&paste errors (talks about "applets" when dataengines, > containments, etc. are meant). Also inconsistent use of "applets" vs. > "Applets", "dataengines" vs. "DataEngines", etc. This patch also cleans that > up (separate commit). > > > Diffs > - > > src/plasma/data/servicetypes/plasma-applet.desktop e142552 > src/plasma/data/servicetypes/plasma-dataengine.desktop 9280645 > src/plasma/pluginloader.h 80cd1e9 > > Diff: https://git.reviewboard.kde.org/r/128616/diff/ > > > Testing > --- > > > Thanks, > > Friedrich W. H. Kossebau > >
[Differential] [Commented On] D2502: New design for logout screen
mart added inline comments. INLINE COMMENTS > broulik wrote in Logout.qml:45 > Can we have an enum for that? it is an enum coming somewhere from solid, i don't think it has bindings? > broulik wrote in Logout.qml:128 > Given you already set currentAction based on the sdtype, could be simplified > to > > opacity: root.currentAction === action ? 1 : 0.6 > > This would also ease the keyboard nav stuff. doesn't seem to work, apparently comparing a signal and a var that contains the same signal is false :/ REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2502 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated, 498 lines] D2502: New design for logout screen
mart updated this revision to Diff 6084. mart added a comment. - Add new shared session QML files - Avoid installing test data with SDDM - use latest version of ActionButton - Merge branch 'master' into mart/newLogoutScreen - some keyboard navigation REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2502?vs=6077&id=6084 BRANCH mart/newLogoutScreen REVISION DETAIL https://phabricator.kde.org/D2502 AFFECTED FILES lookandfeel/contents/components/ActionButton.qml lookandfeel/contents/components/LogoutOptions.qml lookandfeel/contents/components/LogoutScreen.qml lookandfeel/contents/logout/Logout.qml lookandfeel/contents/logout/LogoutButton.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128699/ --- (Updated Aug. 19, 2016, 4:38 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: breeze Description --- New wallpaper for Plasma 5.8 Bringing back some colour to our wallpapers - they kept getting darker and some people were disappointed at that, so for the 5.8 LTS I think we can celebrate a bit. This wallpaper will also be available in 4K resolution. Link to VDG Share download: https://share.kde.org/index.php/s/M4fzjKibKeZFyMx Diffs - wallpapers/Next/contents/images/1024x768.png 60e1205 wallpapers/Next/contents/images/1280x1024.png 36a9130 wallpapers/Next/contents/images/1280x800.png c33e594 wallpapers/Next/contents/images/1440x900.png 2c75b54 wallpapers/Next/contents/images/1600x1200.png 5ddaf72 wallpapers/Next/contents/images/1638x1024.png a3c7492 wallpapers/Next/contents/images/1680x1050.png eddc47e wallpapers/Next/contents/images/1920x1080.png ab6d950 wallpapers/Next/contents/images/2560x1440.png 5c78e9d wallpapers/Next/contents/images/2560x1600.png eeb08a1 wallpapers/Next/contents/images/3200x1800.png 7340567 wallpapers/Next/contents/images/3200x2000.png fd1a62c wallpapers/Next/contents/screenshot.png a6d2b7b Diff: https://git.reviewboard.kde.org/r/128699/diff/ Testing --- File Attachments 2560x1600.png https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/d8dc1072-2ad1-4954-b339-a7319e2d765b__2560x1600.png preview.png https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/1adec791-1f97-4887-976c-6eb5363b26e3__preview.png splash.png https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/ceb0bf36-a476-4725-b0d6-6f7f74d990df__splash.png 2560x1600-UPDATED.png https://git.reviewboard.kde.org/media/uploaded/files/2016/08/18/119c1e58-03bb-45ca-a3e6-13f3fe4c3e6c__2560x1600.png Thanks, Ken Vermette
[Differential] [Closed] D2498: various patches for qmake support
bearsh closed this revision. bearsh added a comment. pushed REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2498 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bearsh, mart Cc: plasma-devel
