Re: Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/#review95574 --- Ship it! always accept - Marco Martin On May 17, 2016, 6:32 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127947/ > --- > > (Updated May 17, 2016, 6:32 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > With KIOSK restrictions it can happen that a context menu would be empty. In > this case just a shadow would show up. Do nothing in this case. > > > Diffs > - > > src/scriptengines/qml/plasmoid/containmentinterface.cpp f168002 > > Diff: https://git.reviewboard.kde.org/r/127947/diff/ > > > Testing > --- > > AppletInterface already has similar code. > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127946: [KDeclarative] [KCMShell] Add "authorized" wrapper around KAuthorize::authorizeControlModules
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127946/#review95575
---
Ship it!
Ship It!
- Marco Martin
On May 17, 2016, 6:31 p.m., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127946/
> ---
>
> (Updated May 17, 2016, 6:31 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kdeclarative
>
>
> Description
> ---
>
> This allows to hide a configure button if the resulting click would do
> nothing due to KIOSK restrictions.
>
>
> Diffs
> -
>
> src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt be2d534
> src/qmlcontrols/kquickcontrolsaddons/kcmshell.h 7436aba
> src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp af2e639
>
> Diff: https://git.reviewboard.kde.org/r/127946/diff/
>
>
> Testing
> ---
>
> If I disable all kcms for powermanagement I now longer get a "Configure Power
> saving", obviously the applets need to be adjusted but we should do that for
> the default setup.
>
> Not sure about the API, though, makes it a bit cumbersome to use. Perhaps we
> need a shortcut like KAuthorized has where you just do if (authorize("foo"))
> and done? Would also save costly conversions between C++ and QML types. I'm
> open to suggestions :)
>
> Supposedly you can just do foo("bar") instead of foo(["bar"]) for QStringList
> args and it will implicitly convert it for you but I don't trust that
>
> Also all the "Kconfig found" cmake checks all over the place are rather
> superfluous as it's a required dep for kdeclarative
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/
---
(Updated May 18, 2016, 11:07 a.m.)
Review request for kde-workspace and Plasma.
Bugs: 360666
https://bugs.kde.org/show_bug.cgi?id=360666
Repository: plasma-integration
Description
---
The referenced bug says that, by default, there is no file overwrite check when
using QFileDialog to save a file. Indeed, on closer investigating it appears
that there is no way to even explictly force an overwrite check when using the
KDE platform theme, because of this code in
plasma-integration/src/platformtheme/kdeplatformfiledialoghelper.cpp:
// overwrite option
if
(options()->testOption(QFileDialogOptions::FileDialogOption::DontConfirmOverwrite))
{
dialog->m_fileWidget->setConfirmOverwrite(false);
}
The default for KFileWidget is already for no overwrite check (as set in
kio/src/filewidgets/kfilewidget.cpp which initialises
KFileWidgetPrivate::confirmOverwrite to false). There is no way to override
this from the calling application through the platform plugin.
Suggest that the default option should be the same as that defined by Qt for
QFileDialog: always perform an ovewrwrite check on saving, unless the caller
has set the QFileDialog::DontConfirmOverwrite option. This is also a sensible
default to have from the user's point of view. This change does that in the
platform theme plugin, for all saving operations.
Diffs (updated)
-
autotests/kfiledialog_unittest.cpp 59915da
src/platformtheme/kdeplatformfiledialoghelper.cpp 139c35d
tests/qfiledialogtest.cpp 1d69ea1
Diff: https://git.reviewboard.kde.org/r/127944/diff/
Testing
---
Built plasma-intergration with this change, confirmed correct operation of file
dialogues and that confirmation is requested when overwriting an existing file,
unless the QFileDialog::DontConfirmOverwrite option is specified.
Thanks,
Jonathan Marten
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving
> On May 17, 2016, 3:29 p.m., Martin Gräßlin wrote:
> > The test does not verify the problem. I just pulled the patch, undid your
> > change, but the test passed nevertheless.
>
> Martin Gräßlin wrote:
> ah now I see. You adjusted the test application, but not the autotest.
>
> Jonathan Marten wrote:
> Now I see that there are autotests after all. How do I run them?
>
> Martin Gräßlin wrote:
> you can go to the build directory and just do:
> make test
>
> or just run the individial test binary created in build/autotests. The
> relevant one would be kfiledialog_unittest and kfiledialogqml_unittest
>
> Jonathan Marten wrote:
> Ok, found them and how - thanks.
>
> It doesn't appear to be possible to just check that the QFileDialog
> option is passed correctly through to the file widget, because KFileWidget
> has no way to read back the option set by setConfirmOverwrite. So it won't
> be a simple test like the setFileMode tests - it will have to look for the
> message box being shown. Is that worth doing (and reliable enough)?
>
> Martin Gräßlin wrote:
> hmm yeah, tricky. I think it would be ok to check for the messagebox
> being shown as that's kind of also how the autotest for the dialog works in
> general. But I also don't have an idea on how to check whether the messagebox
> got opened. So maybe just push without it.
>
> Btw. please push for the Plasma/5.6 branch.
Ok, have worked out an autotest. It's not pretty, but it does work - passing
with the modified platform theme and failing with the original. It puts up a
save box for a file which already exists, clicks the OK button and checks that
a message box appears or not according to the QFileDialog option. The message
box has to be checked in a QTimer slot because, if it does appear, it runs its
own event loop which halts the test until the user clicks one of its buttons.
Go easy with it - it's my first ever Frameworks autotest :-)
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/#review95535
---
On May 18, 2016, 11:07 a.m., Jonathan Marten wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127944/
> ---
>
> (Updated May 18, 2016, 11:07 a.m.)
>
>
> Review request for kde-workspace and Plasma.
>
>
> Bugs: 360666
> https://bugs.kde.org/show_bug.cgi?id=360666
>
>
> Repository: plasma-integration
>
>
> Description
> ---
>
> The referenced bug says that, by default, there is no file overwrite check
> when using QFileDialog to save a file. Indeed, on closer investigating it
> appears that there is no way to even explictly force an overwrite check when
> using the KDE platform theme, because of this code in
> plasma-integration/src/platformtheme/kdeplatformfiledialoghelper.cpp:
>
> // overwrite option
> if
> (options()->testOption(QFileDialogOptions::FileDialogOption::DontConfirmOverwrite))
> {
> dialog->m_fileWidget->setConfirmOverwrite(false);
> }
>
> The default for KFileWidget is already for no overwrite check (as set in
> kio/src/filewidgets/kfilewidget.cpp which initialises
> KFileWidgetPrivate::confirmOverwrite to false). There is no way to override
> this from the calling application through the platform plugin.
>
> Suggest that the default option should be the same as that defined by Qt for
> QFileDialog: always perform an ovewrwrite check on saving, unless the caller
> has set the QFileDialog::DontConfirmOverwrite option. This is also a
> sensible default to have from the user's point of view. This change does
> that in the platform theme plugin, for all saving operations.
>
>
> Diffs
> -
>
> autotests/kfiledialog_unittest.cpp 59915da
> src/platformtheme/kdeplatformfiledialoghelper.cpp 139c35d
> tests/qfiledialogtest.cpp 1d69ea1
>
> Diff: https://git.reviewboard.kde.org/r/127944/diff/
>
>
> Testing
> ---
>
> Built plasma-intergration with this change, confirmed correct operation of
> file dialogues and that confirmation is requested when overwriting an
> existing file, unless the QFileDialog::DontConfirmOverwrite option is
> specified.
>
>
> Thanks,
>
> Jonathan Marten
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 127954: force icon themes explicitly via new testing helper function
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127954/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: plasma-framework Description --- force icon themes explicitly via new testing helper function Diffs - autotests/iconitemtest.cpp bc97aaea57d39107b4b33c5082cb1c9cf72425bd autotests/themetest.cpp 70fd56acfbc31ee029cb1002d59882cc2783efbd Diff: https://git.reviewboard.kde.org/r/127954/diff/ Testing --- passes in session env. whether it passes in testbeds we'll see on jenkins :O Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127954: force icon themes explicitly via new testing helper function
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127954/#review95587 --- Ship it! Ship It! - Marco Martin On May 18, 2016, 11:40 a.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127954/ > --- > > (Updated May 18, 2016, 11:40 a.m.) > > > Review request for KDE Frameworks, Plasma and Marco Martin. > > > Repository: plasma-framework > > > Description > --- > > force icon themes explicitly via new testing helper function > > > Diffs > - > > autotests/iconitemtest.cpp bc97aaea57d39107b4b33c5082cb1c9cf72425bd > autotests/themetest.cpp 70fd56acfbc31ee029cb1002d59882cc2783efbd > > Diff: https://git.reviewboard.kde.org/r/127954/diff/ > > > Testing > --- > > passes in session env. whether it passes in testbeds we'll see on jenkins :O > > > Thanks, > > Harald Sitter > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127954: force icon themes explicitly via new testing helper function
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127954/ --- (Updated May 18, 2016, 12:53 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Changes --- Submitted with commit 6ad988cb3df6ca3eac302444182b68fef383770f by Harald Sitter to branch master. Repository: plasma-framework Description --- force icon themes explicitly via new testing helper function Diffs - autotests/iconitemtest.cpp bc97aaea57d39107b4b33c5082cb1c9cf72425bd autotests/themetest.cpp 70fd56acfbc31ee029cb1002d59882cc2783efbd Diff: https://git.reviewboard.kde.org/r/127954/diff/ Testing --- passes in session env. whether it passes in testbeds we'll see on jenkins :O Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/ --- (Updated Mai 18, 2016, 1:20 nachm.) Review request for Plasma. Repository: plasma-framework Description --- With KIOSK restrictions it can happen that a context menu would be empty. In this case just a shadow would show up. Do nothing in this case. Diffs (updated) - src/scriptengines/qml/plasmoid/containmentinterface.cpp f168002 Diff: https://git.reviewboard.kde.org/r/127947/diff/ Testing --- AppletInterface already has similar code. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 5,664 lines] D1631: Implement wl_text_input and zwp_text_input_v2 interfaces
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change introduces support for text input. Text input allows to compose text on the server (e.g. through a virtual keyboard) and sent the composed text to the client. There are multiple interfaces for text input. QtWayland 5.6 uses wl_text_input, QtWayland 5.7 uses zwp_text_input_v2. wl_text_input is from pre Wayland-Protocols times and considered as UnstableV0 in this implementation. The other interface is UnstableV2. Unfortunately the V2 variant is not yet part of Wayland-Protocols, but used in Qt. The implementation hides the different interfaces as good as possible. The general idea is the same, the differences are rather minor. This means changes to how interfaces are wrapped normally. On client side in the Registry a manager is factored which represent either of the two interfaces. Similar on the server side Display's factory method takes an argument to decide which interface should be factored. This way a user of the library can expose both interfaces and thus be compatible with Qt 5.6 and Qt 5.7 onwards. REPOSITORY rKWAYLAND KWayland BRANCH graesslin/text-input REVISION DETAIL https://phabricator.kde.org/D1631 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_text_input.cpp autotests/client/test_wayland_registry.cpp src/client/CMakeLists.txt src/client/protocols/text-input-unstable-v2.xml src/client/protocols/text-input.xml src/client/registry.cpp src/client/registry.h src/client/textinput.cpp src/client/textinput.h src/client/textinput_p.h src/client/textinput_v0.cpp src/client/textinput_v2.cpp src/server/CMakeLists.txt src/server/display.cpp src/server/display.h src/server/seat_interface.cpp src/server/seat_interface.h src/server/seat_interface_p.h src/server/textinput_interface.cpp src/server/textinput_interface.h src/server/textinput_interface_p.h src/server/textinput_interface_v0.cpp src/server/textinput_interface_v2.cpp src/tools/mapping.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1631: Implement wl_text_input and zwp_text_input_v2 interfaces
graesslin added a comment. Sorry for the large review. The fact that it supports two interfaces made it rather complex. When reviewing please check whether the exposed methods sound good, are well documented, etc. Please also verify whether the implementation actually matches what is described in the two xml protocols. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1631 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/#review95589 --- Ship it! Ship It! - Marco Martin On May 18, 2016, 1:20 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127947/ > --- > > (Updated May 18, 2016, 1:20 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > With KIOSK restrictions it can happen that a context menu would be empty. In > this case just a shadow would show up. Do nothing in this case. > > > Diffs > - > > src/scriptengines/qml/plasmoid/containmentinterface.cpp f168002 > > Diff: https://git.reviewboard.kde.org/r/127947/diff/ > > > Testing > --- > > AppletInterface already has similar code. > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127947: [ContainmentInterface] Don't try to popup empty QMenu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127947/ --- (Updated May 18, 2016, 8:42 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit f1648148b95f708a23f3d8f81f49680369886c41 by Kai Uwe Broulik to branch master. Repository: plasma-framework Description --- With KIOSK restrictions it can happen that a context menu would be empty. In this case just a shadow would show up. Do nothing in this case. Diffs - src/scriptengines/qml/plasmoid/containmentinterface.cpp f168002 Diff: https://git.reviewboard.kde.org/r/127947/diff/ Testing --- AppletInterface already has similar code. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127946: [KDeclarative] [KCMShell] Add "authorized" wrapper around KAuthorize::authorizeControlModules
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127946/
---
(Updated May 18, 2016, 5:43 p.m.)
Status
--
This change has been marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit cee0c38ca3e11803b2b694300c98a212be6df76f by Kai Uwe
Broulik to branch master.
Repository: kdeclarative
Description
---
This allows to hide a configure button if the resulting click would do nothing
due to KIOSK restrictions.
Diffs
-
src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt be2d534
src/qmlcontrols/kquickcontrolsaddons/kcmshell.h 7436aba
src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp af2e639
Diff: https://git.reviewboard.kde.org/r/127946/diff/
Testing
---
If I disable all kcms for powermanagement I now longer get a "Configure Power
saving", obviously the applets need to be adjusted but we should do that for
the default setup.
Not sure about the API, though, makes it a bit cumbersome to use. Perhaps we
need a shortcut like KAuthorized has where you just do if (authorize("foo"))
and done? Would also save costly conversions between C++ and QML types. I'm
open to suggestions :)
Supposedly you can just do foo("bar") instead of foo(["bar"]) for QStringList
args and it will implicitly convert it for you but I don't trust that
Also all the "Kconfig found" cmake checks all over the place are rather
superfluous as it's a required dep for kdeclarative
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 21 lines] D1632: [Battery/Clock] Offer KCM access only if allowed
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Remove the context menus that would do nothing if access to those KCMs is restricted. TEST PLAN Added the respective KCM desktop file names to [KDE Control Module Restrictions]: - In Battery it is shown if one of the three KCMs is allowed, works - In clock the two entries are treated separately, works Confirmed that KCMShell refused to open and System Settings didn't list; still works when no restriction is set REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1632 AFFECTED FILES applets/batterymonitor/package/contents/ui/PowerManagementItem.qml applets/batterymonitor/package/contents/ui/batterymonitor.qml applets/digital-clock/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 6 lines] D1633: [Kickoff/Trash] Offer KCM access only if allowed
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Remove the context menus that would do nothing if access to those KCMs is restricted. Don't indicate clickable area with pointy cursor for Kickoff user avatar if restricted. Also fix trash desktop file name. TEST PLAN Added the respective KCM desktop file names to [KDE Control Module Restrictions]: - Didn't get a "Configure" entry for Trash - No more pointy finger on Kickoff user avatar Confirmed that KCMShell refused to open and Dolphin / System Settings didn't list; still works when no restriction is set. KTP applet, Printer Manager applet and potentially others would need to be adjusted still. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1633 AFFECTED FILES applets/kickoff/package/contents/ui/Header.qml applets/trash/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 8 lines] D1633: [Kickoff/Trash] Offer KCM access only if allowed
broulik updated this revision to Diff 3863. broulik added a comment. It's kcmtrash, not trash. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1633?vs=3862&id=3863 REVISION DETAIL https://phabricator.kde.org/D1633 AFFECTED FILES applets/kickoff/package/contents/ui/Header.qml applets/trash/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127753: [taskmanager] Fixing typos
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127753/ --- (Updated May 18, 2016, 12:27 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Kai Uwe Broulik and David Rosca. Changes --- Submitted with commit d44faae67cf724987e7838494c5d3b01c4a0db57 by Anthony Fieroni to branch Plasma/5.6. Repository: plasma-desktop Description --- ^^ Diffs - applets/taskmanager/package/contents/ui/Task.qml 25ac039 applets/taskmanager/package/contents/ui/ToolTipDelegate.qml 383c4a4 Diff: https://git.reviewboard.kde.org/r/127753/diff/ Testing --- File Attachments Move mouse pointer fast from here to taskmanager item https://git.reviewboard.kde.org/media/uploaded/files/2016/04/27/382fc7df-83c8-4555-9952-5cc3f4c1a637__Screenshot_20160427_111049.png toolbutton disappear https://git.reviewboard.kde.org/media/uploaded/files/2016/04/27/4459dbb7-83f6-49f1-b412-bd3a3b514044__Screenshot_20160427_111017.png Screenshot_20160428_100159.png https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/84cf7fb4-6b18-40eb-bb8b-8c796375300f__Screenshot_20160428_100159.png Thanks, Anthony Fieroni ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: DWD HIG Draft
Update; After feedback we made some moderately heavy changes to teh DWD requirements, namely removing/changing 'priority groups' in favour of 'layouts'. Instead of the application firing off widgets with a "spray & pray" manner via priority groups, we're using layouts. With layouts the application sets a primary layout, and can switch to contextual layouts later. The primary layout has to be accepted as-is otherwise DWDs will be disabled for that window. Layouts can specify the order and size policies of widgets, but only for the area inside the canvas - an application can't try to scramble user-defined buttons. Applications can swap layouts if there's a contextual need, but the DWD can reject them if there's an issue, telling the app to provide traditional controls. We will specify how things should be laid out by applications in HIGs later (basically, it's what the required layout was before), but this will let applications use discretion if something would be awkward. More information on this can be found under 'Widget Placement" in the doc. Document link: https://docs.google.com/document/d/1mYzHjcuDitWmk99syjC0xzQPPmyUrpL_29_s3-2Yl_g/edit?usp=sharing This upcoming weekend is a long weekend here, so I'll have time to put this on the wiki and make a blog post. If anyone wants me to hold off for more feedback please let me know. Cheers; - Ken On Tue, May 17, 2016 at 10:49 AM, Ken Vermette wrote: > Howdy! > > We have our first serious formal proposal for the DWD HIGs and the > functionality we are looking for; here's a link to the publicly editable > Google doc: > > > https://docs.google.com/document/d/1mYzHjcuDitWmk99syjC0xzQPPmyUrpL_29_s3-2Yl_g/edit?usp=sharing > > I'd like to invite anyone with a stake in this to make edits/suggestions. > Once we have any rapid-fire editing done I'll pretty it up and put it on > the wiki; if editing wrecks the formatting in the doc that's fine. It > contains a general overview of functionality, the first four widgets we're > looking to implement, and a list of widgets which I'll be writing out once > we're satisfied with the current documentation and direction. > > It may also be good to fill in technical or implementation details in the > doc so anyone reading the wiki can be on the same page. If anyone has any > concerns about anything please bring them up so we can hammer it out. > > - Ken > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1291: Add microphone volume OSD
andreaska added a comment. done http://commits.kde.org/breeze-icons/833beda436b64c9b4a692d4b4dbe95c0f7cab35f REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH mic-osd REVISION DETAIL https://phabricator.kde.org/D1291 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, sebas, Plasma, Plasma: Design Cc: andreaska, sebas, colomar, elvisangelaccio, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D1291: Add microphone volume OSD
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEf950f7843e60: Add microphone volume OSD (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1291?vs=3373&id=3867#toc REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1291?vs=3373&id=3867 REVISION DETAIL https://phabricator.kde.org/D1291 AFFECTED FILES shell/osd.cpp shell/osd.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, sebas, Plasma, Plasma: Design Cc: andreaska, sebas, colomar, elvisangelaccio, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 93 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/93/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 20:34:33 + Build duration: 12 min CHANGE SET Revision f950f7843e6006656958421d22dbcde1e51de24b by David Rosca: (Add microphone volume OSD) change: edit shell/osd.h change: edit shell/osd.cpp JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: TestSuite.org.kde.plasma.kickoff-test COBERTURA RESULTS Cobertura Coverage Report PACKAGES 9/9 (100%)FILES 43/49 (88%)CLASSES 43/49 (88%)LINE 1683/2124 (79%)CONDITIONAL 1209/2103 (57%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 37/92 (40%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 26/50 (52%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%)___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 14 lines] D1635: [OSD] Make volume OSD thresholds consistent with Volume Applet
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The volume applet would switch at 26% from low to medium whereas the OSD did that at 25%. Also turn the logic around so it's identical to what plasma-pa does. TEST PLAN As noticed by Andreas. I wonder why we use 0, 25, 75, 100 though and not 0, 33, 66, 100 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1635 AFFECTED FILES shell/osd.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: status of kde/plasma kiosk framework in kf5
first of all... thank you all so much for your engagement.. i can't say it in other words than.. you rock! i tried the toolbars action restriction but... This can be blocked with: action/options_show_toolbar=false ...i still could hide toolbars in dolphin and gwenview for example.. what did i do wrong? thx again! thomas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1635: [OSD] Make volume OSD thresholds consistent with Volume Applet
drosca added a comment. > I wonder why we use 0, 25, 75, 100 though and not 0, 33, 66, 100 Not sure, but the medium threshold looks fine to me because most of the times you keep your volume in lower levels (because >50% is too loud), so it makes sense to show "medium" icon (one bar filled) sooner - over 25% and not 33%. Can you please also change it in microphone volume OSD I just committed? Thanks REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1635 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: drosca, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1583: fix sycoca init to pass in isolated testbeds without pre-existing sycoca
dfaure added a comment. Right. kservicetest was still failing too, but after adding debug output it now passes every time I committed the additional debug output in kdirwatch and enabled kdirwatch debug output in filetypestest. Can you kick a build again and let me know the result? (doesn't seem to happen automatically on build.neon.kde.org) REPOSITORY rKDECLITOOLS KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D1583 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, dfaure Cc: mart, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: DWD HIG Draft
On Wednesday, May 18, 2016 4:21:20 PM CEST Ken Vermette wrote: > Update; > > After feedback we made some moderately heavy changes to teh DWD > requirements, namely removing/changing 'priority groups' in favour of > 'layouts'. > > Instead of the application firing off widgets with a "spray & pray" manner > via priority groups, we're using layouts. With layouts the application sets > a primary layout, and can switch to contextual layouts later. The primary > layout has to be accepted as-is otherwise DWDs will be disabled for that > window. > > Layouts can specify the order and size policies of widgets, but only for > the area inside the canvas - an application can't try to scramble > user-defined buttons. Applications can swap layouts if there's a contextual > need, but the DWD can reject them if there's an issue, telling the app to > provide traditional controls. > > We will specify how things should be laid out by applications in HIGs later > (basically, it's what the required layout was before), but this will let > applications use discretion if something would be awkward. More information > on this can be found under 'Widget Placement" in the doc. > > Document link: > https://docs.google.com/document/d/1mYzHjcuDitWmk99syjC0xzQPPmyUrpL_29_s3-2Y > l_g/edit?usp=sharing > > This upcoming weekend is a long weekend here, so I'll have time to put this > on the wiki and make a blog post. If anyone wants me to hold off for more > feedback please let me know. Maybe give sebas a chance to read over it. I try to remember to mention it in the meeting on Monday. Cheers Martin > > Cheers; > - Ken > > On Tue, May 17, 2016 at 10:49 AM, Ken Vermette wrote: > > Howdy! > > > > We have our first serious formal proposal for the DWD HIGs and the > > functionality we are looking for; here's a link to the publicly editable > > Google doc: > > > > > > https://docs.google.com/document/d/1mYzHjcuDitWmk99syjC0xzQPPmyUrpL_29_s3-> > > > 2Yl_g/edit?usp=sharing > > > > I'd like to invite anyone with a stake in this to make edits/suggestions. > > Once we have any rapid-fire editing done I'll pretty it up and put it on > > the wiki; if editing wrecks the formatting in the doc that's fine. It > > contains a general overview of functionality, the first four widgets we're > > looking to implement, and a list of widgets which I'll be writing out once > > we're satisfied with the current documentation and direction. > > > > It may also be good to fill in technical or implementation details in the > > doc so anyone reading the wiki can be on the same page. If anyone has any > > concerns about anything please bring them up so we can hammer it out. > > > > - Ken signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 5,715 lines] D1631: Implement wl_text_input and zwp_text_input_v2 interfaces
graesslin updated this revision to Diff 3872. graesslin added a comment. More documentation REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1631?vs=3860&id=3872 BRANCH graesslin/text-input REVISION DETAIL https://phabricator.kde.org/D1631 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_text_input.cpp autotests/client/test_wayland_registry.cpp src/client/CMakeLists.txt src/client/protocols/text-input-unstable-v2.xml src/client/protocols/text-input.xml src/client/registry.cpp src/client/registry.h src/client/textinput.cpp src/client/textinput.h src/client/textinput_p.h src/client/textinput_v0.cpp src/client/textinput_v2.cpp src/server/CMakeLists.txt src/server/display.cpp src/server/display.h src/server/seat_interface.cpp src/server/seat_interface.h src/server/seat_interface_p.h src/server/textinput_interface.cpp src/server/textinput_interface.h src/server/textinput_interface_p.h src/server/textinput_interface_v0.cpp src/server/textinput_interface_v2.cpp src/tools/mapping.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 5,715 lines] D1631: Implement wl_text_input and zwp_text_input_v2 interfaces
graesslin updated this revision to Diff 3873. graesslin added a comment. Some method renaming: - on client: activate -> enable, deactivate -> disable - on server: made setters not sound like getters REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1631?vs=3872&id=3873 BRANCH graesslin/text-input REVISION DETAIL https://phabricator.kde.org/D1631 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_text_input.cpp autotests/client/test_wayland_registry.cpp src/client/CMakeLists.txt src/client/protocols/text-input-unstable-v2.xml src/client/protocols/text-input.xml src/client/registry.cpp src/client/registry.h src/client/textinput.cpp src/client/textinput.h src/client/textinput_p.h src/client/textinput_v0.cpp src/client/textinput_v2.cpp src/server/CMakeLists.txt src/server/display.cpp src/server/display.h src/server/seat_interface.cpp src/server/seat_interface.h src/server/seat_interface_p.h src/server/textinput_interface.cpp src/server/textinput_interface.h src/server/textinput_interface_p.h src/server/textinput_interface_v0.cpp src/server/textinput_interface_v2.cpp src/tools/mapping.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
