Re: Review Request 126953: Remove Theme Details KCM

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126953/#review94271
---



Refraining from personal comments, there is a question related to this 
regarding the documentation:

https://mail.kde.org/pipermail/kde-doc-english/2016-April/013341.html

I would add: is there a document that explain how to achive the same (create a 
theme, possibly inheriting the base from existing themes)? Is this enough? 
https://techbase.kde.org/Development/Tutorials/Plasma5/ThemeDetails

- Luigi Toscano


On Feb. 8, 2016, 12:15 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126953/
> ---
> 
> (Updated Feb. 8, 2016, 12:15 a.m.)
> 
> 
> Review request for Plasma, KDE Usability and Andrew Lake.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This removes the theme editor thing in the Desktop Theme KCM.
> 
> Most settings in there are either broken or useless nowadays.
> 
> The only setting I would miss is different Analog Clock faces which could be 
> done in the Analog Clock directly. What I am missing in general is a custom 
> Panel color/texture or something like that which we don't have in here anyway.
> 
> 
> Diffs
> -
> 
>   kcms/desktoptheme/CMakeLists.txt 6168686 
>   kcms/desktoptheme/DesktopTheme.ui f57cdf8 
>   kcms/desktoptheme/DesktopThemeDetails.ui 9df3536 
>   kcms/desktoptheme/desktopthemedetails.h 475d893 
>   kcms/desktoptheme/desktopthemedetails.cpp ce5c856 
>   kcms/desktoptheme/kcm_desktoptheme_debug.h e3363f0 
>   kcms/desktoptheme/kcm_desktoptheme_debug.cpp e09e839 
>   kcms/desktoptheme/kcmdesktoptheme.h ac87862 
>   kcms/desktoptheme/kcmdesktoptheme.cpp 8991990 
>   kcms/desktoptheme/thememodel.cpp bb5bb94 
> 
> Diff: https://git.reviewboard.kde.org/r/126953/diff/
> 
> 
> Testing
> ---
> 
> Tab gone.
> 
> While at it I also replaced the status label with a proper KMessageWidget
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/ddff6657-da2d-4fef-8dc1-872588e967b5__simplifiedthemesettings.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 15 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/15/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 05 Apr 2016 08:02:12 +
Build duration: 6 min 59 sec

CHANGE SET
Revision c3bdcd41a5405b732afc119f5b6a9593c600b7a4 by ivan.cukic: (Fixing 
invalid check for the folder model not being null)
  change: edit containments/desktop/plugins/folder/positioner.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 37/39 (95%)CLASSES 37/39 (95%)LINE 2309/3369 
(69%)CONDITIONAL 1565/2670 (59%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/38 (58%)
kcms.keyboard
FILES 21/23 (91%)CLASSES 21/23 (91%)LINE 782/1521 
(51%)CONDITIONAL 632/1019 (62%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
433/838 (52%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/356 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/178 (61%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 251/342 (73%)CONDITIONAL 
82/137 (60%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 15 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/15/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 05 Apr 2016 08:02:12 +
Build duration: 6 min 59 sec

CHANGE SET
Revision c3bdcd41a5405b732afc119f5b6a9593c600b7a4 by ivan.cukic: (Fixing 
invalid check for the folder model not being null)
  change: edit containments/desktop/plugins/folder/positioner.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 37/39 (95%)CLASSES 37/39 (95%)LINE 2309/3369 
(69%)CONDITIONAL 1565/2670 (59%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/38 (58%)
kcms.keyboard
FILES 21/23 (91%)CLASSES 21/23 (91%)LINE 782/1521 
(51%)CONDITIONAL 632/1019 (62%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
433/838 (52%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/356 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/178 (61%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 251/342 (73%)CONDITIONAL 
82/137 (60%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 357621] Screen cannot be turned on after it has been set to "energy saving" (goes off)

[Simone Gaiarin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357621

--- Comment #3 from Simone Gaiarin  ---
Still have this problem also after updating to Qt 5.6 and Plasma 5.6. I've
disabled the screen energy saving in "energy saving" but still the screen turn
off. What other settings can I change? How can I debug it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 16 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/16/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 05 Apr 2016 08:16:29 +
Build duration: 4 min 48 sec

CHANGE SET
Revision 008d15cafaefe173c13fd95e96209258ff6d42dd by ivan.cukic: (The one who 
creates the Rules object is responsible for deleting it)
  change: edit kcms/keyboard/xkb_rules.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Minutes Monday Plasma Meeting

[kainz.a]

Andreas_K:
* optimize breeze-icons in size and that all icons have the style
information that they all can be styled in the future
* optimize the plasma applet 256 px icons for a faster load of the widget
explorer
* the svg files are easy to read in a text editor (remove 750.000 lines of
"code" and about 40% of the size)
* I hope that the icons can be themed in the future not only for plasma but
also for KDE and GTK applications.

example adress-book-new.svg
-
http://www.w3.org/2000/svg"; viewBox="0 0 22 22">
  

  .ColorScheme-Text {
color:#4d4d4d;
  }
  
  
 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: Enabling users to report issues with Plasma widgets

[Marco Martin]

On Tuesday 05 April 2016, Martin Graesslin wrote:
> Speaking now with the experience from KWin (which has a dedicated info page
> per effect):
> * cannot remember that I ever got contacted directly by a user due to the
> about information
> * bug reports hardly reference an effect plugin directly. Users cannot and
> should not know where the bug is, whether it's in the plugin or in the
> infrastructure
> * our devs don't care about it. I don't know in how many reviews I pointed
> out that I'm not the author of the newly added effect
> 
> So with the experience of the 40 plugins in KWin I think the possible gains
> presented here do not justify the addition of code and UI elements.

^^ this

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: Enabling users to report issues with Plasma widgets

[Kai Uwe Broulik]

Hi,

> So with the experience of the 40 plugins in KWin I think the possible gains 
> presented here do not justify the addition of code and UI elements.

I have to disagree. You can't really compare KWin plug-ins of which users 
usually shouldn't even be aware they are a thing to Plasma applets which are 
user-facing mini applications.

A user might see the network applet shows crap and so they want to report 
specifically that to the network guy, or a minor issue in Kickoff, etc. and we 
usually have a bko component for all applets assigned to the right guy.

Re the honor of third party applets: yes, that too, we used to have that in 
widget explorer but now there's nowhere to see license or author info.

Cheers, 
Kai Uwe 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 16 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/16/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 05 Apr 2016 08:28:27 +
Build duration: 17 min

CHANGE SET
Revision cd7c09b2bb3e94025cd61b14b6c01eca0f6d310f by ivan.cukic: 
(m_interactiveConsole can be null)
  change: edit shell/shellcorona.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 42/47 (89%)CLASSES 42/47 (89%)LINE 1661/2088 
(80%)CONDITIONAL 1206/1802 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 90/131 (69%)CONDITIONAL 
34/50 (68%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: A Plasma Vision draft

[Marco Martin]

On Tuesday 05 April 2016, Sebastian Kügler wrote:
> On Monday 04 April 2016 17:29:58 Thomas Pfeiffer wrote:
> > On Montag, 4. April 2016 15:04:30 CEST Jonathan Riddell wrote:
> > > I'm not convinced performant is a word although it seems to be used
> > > for computer jargon
> > > 
> > > http://english.stackexchange.com/questions/38945/what-is-wrong-with-the
> > > -wo rd -performant
> > 
> > It is clearly jargon. As Jens already said, the question is: Can we
> > afford the  jargon or not? We think we can, but there are certainly also
> > good arguments against it.
> 
> I don't like it. How about "nimble", it expresses power and speed in a
> positively sounding adjective.

to me nimble sounds like "small footprint" while would be a good aim to have 
in the future, i am not sure i could tell that around with a straight face on 
the current state... (and if is so contrary to the current perception it may 
really backfire)

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94273
---



nice :) (and nice to see how they keep improving one after another!)
one thing i am not sure is that particular tonality of green for that diagonal 
line.
could be tried with a warmer orange/yellow-ish instead?

- Marco Martin


On April 5, 2016, 12:27 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Ivan Čukić]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94275
---



Very nice!

Just a small note - you'll need to create the intel-glitch variant as well :)

- Ivan Čukić


On April 5, 2016, 12:27 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Ivan Čukić]

> On April 5, 2016, 8:47 a.m., Marco Martin wrote:
> > nice :) (and nice to see how they keep improving one after another!)
> > one thing i am not sure is that particular tonality of green for that 
> > diagonal line.
> > could be tried with a warmer orange/yellow-ish instead?

> could be tried with a warmer orange/yellow-ish instead?

Sounds interesting


- Ivan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94273
---


On April 5, 2016, 12:27 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94274
---



Go Ken! :)

I'm also not quite sure about the green, I liked the green in the non-Intel 
glitch bar variant of the 5.6 variant better but dunno how well that mixes with 
the blue, perhaps we need a more saturated blue also but that might make it too 
heavy. Just rambling along a bit :)


File Attachment: desktopWallpaper-skylight-1.0-kvermette.png - 
desktopWallpaper-skylight-1.0-kvermette.png


I don't like how this line just ends, the dark line coming from the left 
looks like a glitch to me



File Attachment: desktopWallpaper-skylight-1.0-kvermette.png - 
desktopWallpaper-skylight-1.0-kvermette.png


I think I just spoiled myself by thinking this is an airport runway :(



File Attachment: desktopWallpaper-skylight-1.0-kvermette.png - 
desktopWallpaper-skylight-1.0-kvermette.png


this bump annoys me :D

Ah, I just see that the triangle to the left is raised


- Kai Uwe Broulik


On April 5, 2016, 12:27 vorm., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Marco Martin]

> On April 5, 2016, 8:47 a.m., Marco Martin wrote:
> > nice :) (and nice to see how they keep improving one after another!)
> > one thing i am not sure is that particular tonality of green for that 
> > diagonal line.
> > could be tried with a warmer orange/yellow-ish instead?
> 
> Ivan Čukić wrote:
> > could be tried with a warmer orange/yellow-ish instead?
> 
> Sounds interesting

quick and dirty, just to see how it would look: http://imgur.com/7DMh1hv


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94273
---


On April 5, 2016, 12:27 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Kirigami issues with latest master

[Marco Martin]

On Tuesday 05 April 2016, Dirk Hohndel wrote:

> But now that I have it working I have two concerns.
> a) the back button becomes really small, depending on the settings for
> scaling the title bar. I guess that's to be expected, I just thought I'd
> point it out

on ios you would have to make the titlebar quite taller for it to be really 
usable i guess

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 17 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/17/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 05 Apr 2016 08:46:12 +
Build duration: 49 min

CHANGE SET
Revision f75fb23cc30c33b64c303357f452a30b94b007f7 by ivan.cukic: (No need to 
QStandardPaths::findExecutable if proc is null)
  change: edit libtaskmanager/taskitem.cpp
Revision bd32679df5612dac6ddb88210e80c772209b0da1 by ivan.cukic: (Added the 
comment why a handler must exist)
  change: edit shell/shellmanager.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 42/47 (89%)CLASSES 42/47 (89%)LINE 1661/2088 
(80%)CONDITIONAL 1206/1802 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 90/131 (69%)CONDITIONAL 
34/50 (68%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Ivan Čukić]

> On April 5, 2016, 8:47 a.m., Marco Martin wrote:
> > nice :) (and nice to see how they keep improving one after another!)
> > one thing i am not sure is that particular tonality of green for that 
> > diagonal line.
> > could be tried with a warmer orange/yellow-ish instead?
> 
> Ivan Čukić wrote:
> > could be tried with a warmer orange/yellow-ish instead?
> 
> Sounds interesting
> 
> Marco Martin wrote:
> quick and dirty, just to see how it would look: http://imgur.com/7DMh1hv

Look nice. Ken, thoughts?


- Ivan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94273
---


On April 5, 2016, 12:27 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: A Plasma Vision draft

[Sebastian Kügler]

On Tuesday, April 05, 2016 10:46:55 AM Marco Martin wrote:
> On Tuesday 05 April 2016, Sebastian Kügler wrote:
> > On Monday 04 April 2016 17:29:58 Thomas Pfeiffer wrote:
> > > On Montag, 4. April 2016 15:04:30 CEST Jonathan Riddell wrote:
> > > 
> > > It is clearly jargon. As Jens already said, the question is: Can we
> > > afford the  jargon or not? We think we can, but there are certainly also
> > > good arguments against it.
> >
> > I don't like it. How about "nimble", it expresses power and speed in a
> > positively sounding adjective.
> 
> to me nimble sounds like "small footprint" while would be a good aim to
> have  in the future, i am not sure i could tell that around with a straight
> face on the current state... (and if is so contrary to the current
> perception it may really backfire)

The vision is not about the current state, it's a description of our goal.
-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: A Plasma Vision draft

[Sebastian Kügler]

On Tuesday, April 05, 2016 12:17:59 AM David Edmundson wrote:
> On Mon, Apr 4, 2016 at 11:48 PM, Sebastian Kügler  wrote:
> 
> On Monday 04 April 2016 17:29:58 Thomas Pfeiffer wrote:
> > On Montag, 4. April 2016 15:04:30 CEST Jonathan Riddell wrote:
> > > I'm not convinced performant is a word although it seems to be used
> > > for computer jargon
> > > 
> > > http://english.stackexchange.com/questions/38945/what-is-wrong-with-the-> 
> > > > > wo
> > > rd -performant
> > 
> > It is clearly jargon. As Jens already said, the question is: Can we afford
> > the  jargon or not? We think we can, but there are certainly also good
> > arguments against it.
> 
> I don't like it. How about "nimble", it expresses power and speed in a
> positively sounding adjective.
> 
> What I like about  "performant" is it doesn't just mean fast *.
> It covers a broader range of metrics, and the text beneath it in Detail 3
> goes on about code quality and usability which "nimble" doesn't really
> cover in itself.
> 
> David
> 
> *or at least it would if it was a proper word

I guess that's my gripe: If we create a vision, I'd really like it to be 
written in actually existing proper words, otherwise, that is the thing that 
distracts me from its meat. (And I guess others with language-OCD as well.)

How about "agile"? (Already has connotations in context of software, and is 
overused...)

Otherwise, we can also describe it "... performs well...".
-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Writing to plasma-desktop-appletsrc with init scripts.

[Aleix Pol]

On Thu, Mar 31, 2016 at 11:17 PM, Chris Topel  wrote:
> Hey all,
>
> I'm having a bit of an issue trying to make something work in my
> environment.
>
> Basically, I want widgets to be disabled by default. But if a user chooses
> to do so, they can unlock the widgets and make their changes. Then, on
> logout, the widget will automatically be locked again for them so they don't
> accidentally remove it the next day.
>
> So to do that I'd like to use init scripts
> (/usr/share/kde4/apps/plasma-desktop/init/00-defaultLayout.js) to pass
> something directly into plasma-desktop-appletsrc when a user first logs in.
>
> Specifically, I want to add this to the bottom of the file:
>
> [General]
> immutability[$i]=2
>
> This will lock widgets by default but will allow the users to unlock it
> (immutability=1) temporarily to add/move widgets. Then the next time they
> log back in it will be locked (immutability=2) again for them.
>
> So, is there some way I can easily easily set immutability[$i]=2 under the
> [General] section of plasma-desktop-appletsrc?
>
> Thanks in advance!

Shouldn't it be the same making the containment itself immutable?

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Kai Uwe Broulik]

> On April 5, 2016, 8:47 vorm., Marco Martin wrote:
> > nice :) (and nice to see how they keep improving one after another!)
> > one thing i am not sure is that particular tonality of green for that 
> > diagonal line.
> > could be tried with a warmer orange/yellow-ish instead?
> 
> Ivan Čukić wrote:
> > could be tried with a warmer orange/yellow-ish instead?
> 
> Sounds interesting
> 
> Marco Martin wrote:
> quick and dirty, just to see how it would look: http://imgur.com/7DMh1hv
> 
> Ivan Čukić wrote:
> Look nice. Ken, thoughts?

I like that a lot.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94273
---


On April 5, 2016, 12:27 vorm., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94283
---



Can we also get something more flashy and colorful?

My favorite Plasma 5 wallpaper was the 5.3 one ( 
https://www.kde.org/announcements/plasma-5.3/plasma-5.3.png ), since then, 
they're too toned down for my taste. It's a shame that we don't include that 
wallpaper anymore. I'd like something with stronger and vivid colors like that 
one, not necessarily as default (my taste is odd, I realize it), but would be 
nice to have as option.

- Sebastian Kügler


On April 5, 2016, 12:27 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Ivan Čukić]

> On April 5, 2016, 10:47 a.m., Sebastian Kügler wrote:
> > Can we also get something more flashy and colorful?
> > 
> > My favorite Plasma 5 wallpaper was the 5.3 one ( 
> > https://www.kde.org/announcements/plasma-5.3/plasma-5.3.png ), since then, 
> > they're too toned down for my taste. It's a shame that we don't include 
> > that wallpaper anymore. I'd like something with stronger and vivid colors 
> > like that one, not necessarily as default (my taste is odd, I realize it), 
> > but would be nice to have as option.

I don't think we should have a default wallpaper that is *that* flamboyant - 
IMO wallpapers need to be much less distracting than that.

I would not mind if we had it as an option.


- Ivan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94283
---


On April 5, 2016, 12:27 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 357621] Screen cannot be turned on after it has been set to "energy saving" (goes off)

[Alexey Andreyev via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357621

Alexey Andreyev  changed:

   What|Removed |Added

 CC||aa...@ya.ru

--- Comment #4 from Alexey Andreyev  ---
+1, workaround with closing laptop's cover to suspend it and restoring after
that to turn the backlight on works for me too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Kirigami issues with latest master

[Marco Martin]

On Tuesday 05 April 2016, Dirk Hohndel wrote:
> On Mon, Apr 04, 2016 at 02:51:07PM -0700, Dirk Hohndel wrote:
> > - on iOS the git log of Kirigami tells me I should now have a back button
> > 
> >   but I don't see it on my iPhone. I'm still investigating this one,
> >   though, not sure if this app error or an issue with the code in
> >   Kirigami.
> 
> Does this ever happen to you where you feel like you should try just one
> more thing before sending a bug report, but then you send it anyway. And
> then you try it and of course it turns out you were wrong? Yeah, that one.
> 
> So of course it was app error. I forgot to bundle the new BackButton.qml
> file with the application image.

yeah, this kindof uncovers another problem at the moment..
we should probably try to go from embedding everything as qrc like that (btw I 
just added the EdgeShadow.qml file that will give a similar problem) to using 
proper imports (so building the kirigami repo then package it together with 
the rest at apk creation) that should be possible as similar things are 
already done for the external deps such as libdivecomputer/libgit etc..

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 18 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/18/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 05 Apr 2016 10:32:32 +
Build duration: 59 min

CHANGE SET
Revision 6d7a573e10020873cf6406553ccf85c56d91090b by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit templates/ion-dataengine/src/ion-%{APPNAMELC}.desktop


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 42/47 (89%)CLASSES 42/47 (89%)LINE 1661/2088 
(80%)CONDITIONAL 1206/1802 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 90/131 (69%)CONDITIONAL 
34/50 (68%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 357621] Screen cannot be turned on after it has been set to "energy saving" (goes off)

[Simone Gaiarin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357621

--- Comment #5 from Simone Gaiarin  ---
Yes that workaround works also for me. Very annoying tough.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1289: Use default output device when changing global volume

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1289

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, sebas
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1289: Use default output device when changing global volume

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  > changing volume with wheel and muting with middle click on applet icon no 
longer shows OSD.
  
  Why? This makes it inconsistent with what battery does. Battery does only not 
show the OSD when the popup is opened as then it's obvious.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1289

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, sebas
Cc: broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1289: Use default output device when changing global volume

[drosca (David Rosca)]

drosca added a comment.


  > Why?
  
  The volume is already indicated by the icon (very roughly though), and now it 
also shows the percentage in tooltip. So I think the OSD should be displayed 
only when changing the volume with global shortcuts.
  
  In battery applet, the display brightness is not in icon nor in tooltip which 
makes it different.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1289

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, sebas
Cc: broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 158 lines] D1319: [server] Add a method SurfaceInterface::surfaceAt(const QPointF&) -> SurfaceInterface*

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The new method returns the (child) surface at a given surface position
  taking care of stacking order, whether surfaces are mapped, etc.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  surface-at

REVISION DETAIL
  https://phabricator.kde.org/D1319

AFFECTED FILES
  autotests/client/test_wayland_subsurface.cpp
  autotests/client/test_wayland_surface.cpp
  src/server/surface_interface.cpp
  src/server/surface_interface.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1289: Use default output device when changing global volume

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  Fair enough... it's also what KMix used to do.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1289

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, sebas
Cc: broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1289: Use default output device when changing global volume

[drosca (David Rosca)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAPA1e95d867a629: Use default output device when changing 
global volume (authored by drosca).

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1289?vs=3064&id=3138

REVISION DETAIL
  https://phabricator.kde.org/D1289

AFFECTED FILES
  applet/contents/code/icon.js
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml
  src/pulseaudio.cpp
  src/pulseaudio.h
  src/qml/plugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, sebas
Cc: broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 17 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 05 Apr 2016 13:18:28 +
Build duration: 2 min 11 sec

CHANGE SET
Revision f20e8db65ea8ec54f0b959a666a695a62f6ca3fd by Jonathan Riddell: (Update 
version number for 5.6.2 GIT_SILENT)
  change: edit CMakeLists.txt
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Ken Vermette]

> On April 5, 2016, 10:47 a.m., Sebastian Kügler wrote:
> > Can we also get something more flashy and colorful?
> > 
> > My favorite Plasma 5 wallpaper was the 5.3 one ( 
> > https://www.kde.org/announcements/plasma-5.3/plasma-5.3.png ), since then, 
> > they're too toned down for my taste. It's a shame that we don't include 
> > that wallpaper anymore. I'd like something with stronger and vivid colors 
> > like that one, not necessarily as default (my taste is odd, I realize it), 
> > but would be nice to have as option.
> 
> Ivan Čukić wrote:
> I don't think we should have a default wallpaper that is *that* 
> flamboyant - IMO wallpapers need to be much less distracting than that.
> 
> I would not mind if we had it as an option.

One thing that's constantly been talked about is having all the older 
wallpapers available in a package. Some users have said they prefer older 
wallpapers over newer ones in some cases, and would like them to be easily 
available. I think we always agree on doing it too but it just never happens, 
mostly because I need to work with someone who knows how to put that together. 
We have em' all archived though, so it's just a matter of actually doing it... 
Though I may want to do some touchups and George-Lucas a couple of em' to be 
less bad if we do that.

Next time we do a wallpaper contest/refresh, I'll also try to put together a 
flashy wallpaper and get it in there as well so we have something newer in that 
style.

@Ivan I don't think we'll be going that vibrant again, if for no other reason 
than me dodging the internet hate-train. :P


- Ken


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94283
---


On April 5, 2016, 12:27 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Sebastian Kügler]

> On April 5, 2016, 10:47 a.m., Sebastian Kügler wrote:
> > Can we also get something more flashy and colorful?
> > 
> > My favorite Plasma 5 wallpaper was the 5.3 one ( 
> > https://www.kde.org/announcements/plasma-5.3/plasma-5.3.png ), since then, 
> > they're too toned down for my taste. It's a shame that we don't include 
> > that wallpaper anymore. I'd like something with stronger and vivid colors 
> > like that one, not necessarily as default (my taste is odd, I realize it), 
> > but would be nice to have as option.
> 
> Ivan Čukić wrote:
> I don't think we should have a default wallpaper that is *that* 
> flamboyant - IMO wallpapers need to be much less distracting than that.
> 
> I would not mind if we had it as an option.
> 
> Ken Vermette wrote:
> One thing that's constantly been talked about is having all the older 
> wallpapers available in a package. Some users have said they prefer older 
> wallpapers over newer ones in some cases, and would like them to be easily 
> available. I think we always agree on doing it too but it just never happens, 
> mostly because I need to work with someone who knows how to put that 
> together. We have em' all archived though, so it's just a matter of actually 
> doing it... Though I may want to do some touchups and George-Lucas a couple 
> of em' to be less bad if we do that.
> 
> Next time we do a wallpaper contest/refresh, I'll also try to put 
> together a flashy wallpaper and get it in there as well so we have something 
> newer in that style.
> 
> @Ivan I don't think we'll be going that vibrant again, if for no other 
> reason than me dodging the internet hate-train. :P

That's lovely. Thanks!

I suppose we can just put "older" wallpapers into plasma-workspace-wallpapers?


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94283
---


On April 5, 2016, 12:27 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Ken Vermette]

> On April 5, 2016, 8:47 a.m., Marco Martin wrote:
> > nice :) (and nice to see how they keep improving one after another!)
> > one thing i am not sure is that particular tonality of green for that 
> > diagonal line.
> > could be tried with a warmer orange/yellow-ish instead?
> 
> Ivan Čukić wrote:
> > could be tried with a warmer orange/yellow-ish instead?
> 
> Sounds interesting
> 
> Marco Martin wrote:
> quick and dirty, just to see how it would look: http://imgur.com/7DMh1hv
> 
> Ivan Čukić wrote:
> Look nice. Ken, thoughts?
> 
> Kai Uwe Broulik wrote:
> I like that a lot.

Love it. On a pure colour-theroy level there's no "warm" colours so having the 
strip be orange will help balance the temperature a bit from being too cool. 
So, yes, absolutly it'll be orange. It's also another differentiating factor 
from the previous wallpaper. Good call.

(Though the colour might be adjusted based on what's in the Breeze palette, I 
think you nailed it and I'll try to get close)


- Ken


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94273
---


On April 5, 2016, 12:27 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Ken Vermette]

> On April 5, 2016, 8:52 a.m., Ivan Čukić wrote:
> > Very nice!
> > 
> > Just a small note - you'll need to create the intel-glitch variant as well 
> > :)

I'm glad I read that after waking up, the thought of doing the fiddlybits in 
the glitch bar *with perspective* would give me nightmares. :P


- Ken


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94275
---


On April 5, 2016, 12:27 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Ken Vermette]

> On April 5, 2016, 8:53 a.m., Kai Uwe Broulik wrote:
> > File Attachment: desktopWallpaper-skylight-1.0-kvermette.png - 
> > desktopWallpaper-skylight-1.0-kvermette.png
> > 
> >
> > I don't like how this line just ends, the dark line coming from the 
> > left looks like a glitch to me

Its actually just sunken a bit, the purple isn't perfectly flat. I'll drop it a 
hair more so the effect is more obvious.


- Ken


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94274
---


On April 5, 2016, 12:27 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 13 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/13/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 05 Apr 2016 13:20:11 +
Build duration: 26 min

CHANGE SET
Revision 57aa4023f894e1ec2cab1ca5d2542a7821d19aea by Jonathan Riddell: (Update 
version number for 5.6.2 GIT_SILENT)
  change: edit CMakeLists.txt
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Ken Vermette]

> On April 5, 2016, 10:47 a.m., Sebastian Kügler wrote:
> > Can we also get something more flashy and colorful?
> > 
> > My favorite Plasma 5 wallpaper was the 5.3 one ( 
> > https://www.kde.org/announcements/plasma-5.3/plasma-5.3.png ), since then, 
> > they're too toned down for my taste. It's a shame that we don't include 
> > that wallpaper anymore. I'd like something with stronger and vivid colors 
> > like that one, not necessarily as default (my taste is odd, I realize it), 
> > but would be nice to have as option.
> 
> Ivan Čukić wrote:
> I don't think we should have a default wallpaper that is *that* 
> flamboyant - IMO wallpapers need to be much less distracting than that.
> 
> I would not mind if we had it as an option.
> 
> Ken Vermette wrote:
> One thing that's constantly been talked about is having all the older 
> wallpapers available in a package. Some users have said they prefer older 
> wallpapers over newer ones in some cases, and would like them to be easily 
> available. I think we always agree on doing it too but it just never happens, 
> mostly because I need to work with someone who knows how to put that 
> together. We have em' all archived though, so it's just a matter of actually 
> doing it... Though I may want to do some touchups and George-Lucas a couple 
> of em' to be less bad if we do that.
> 
> Next time we do a wallpaper contest/refresh, I'll also try to put 
> together a flashy wallpaper and get it in there as well so we have something 
> newer in that style.
> 
> @Ivan I don't think we'll be going that vibrant again, if for no other 
> reason than me dodging the internet hate-train. :P
> 
> Sebastian Kügler wrote:
> That's lovely. Thanks!
> 
> I suppose we can just put "older" wallpapers into 
> plasma-workspace-wallpapers?

I'd be worried that it might inflate the size of the package too much. An 
alternative might just be putting them on OpenDesktop; I think some other 
people have done this as well, but it might be good in an 'official' capacity 
maybe. I'll bring it up though, see what everyone wants to do. If the legacy 
wallpapers wouldn't be too much I'd squeeze them into 
plasma-workspace-wallpapers.


- Ken


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94283
---


On April 5, 2016, 12:27 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Ken Vermette]

> On April 5, 2016, 8:47 a.m., Marco Martin wrote:
> > nice :) (and nice to see how they keep improving one after another!)
> > one thing i am not sure is that particular tonality of green for that 
> > diagonal line.
> > could be tried with a warmer orange/yellow-ish instead?
> 
> Ivan Čukić wrote:
> > could be tried with a warmer orange/yellow-ish instead?
> 
> Sounds interesting
> 
> Marco Martin wrote:
> quick and dirty, just to see how it would look: http://imgur.com/7DMh1hv
> 
> Ivan Čukić wrote:
> Look nice. Ken, thoughts?
> 
> Kai Uwe Broulik wrote:
> I like that a lot.
> 
> Ken Vermette wrote:
> Love it. On a pure colour-theroy level there's no "warm" colours so 
> having the strip be orange will help balance the temperature a bit from being 
> too cool. So, yes, absolutly it'll be orange. It's also another 
> differentiating factor from the previous wallpaper. Good call.
> 
> (Though the colour might be adjusted based on what's in the Breeze 
> palette, I think you nailed it and I'll try to get close)

1.1! Now in orange!


- Ken


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94273
---


On April 5, 2016, 12:27 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Ken Vermette]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/#review94304
---



On a side note, the revised 1.1 of the wallpaper uses a slightly brighter 
purple. This is because it was duller than the 5.6 wallpaper (too dull) and 
also because the subtle gradient created very noticable banding because I 
didn't apply noise to the purple.

- Ken Vermette


On April 5, 2016, 12:27 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127575/
> ---
> 
> (Updated April 5, 2016, 12:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.7
> 
> Similar to the 5.6 wallpaper, but using perspective and reflections. Source 
> and Splash also attached.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/127575/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
> desktopWallpaper-skylight-1.0-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
> desktopWallpaper-skylight-1.0-kvermette.svg
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

[Ken Vermette]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127575/
---

(Updated April 5, 2016, 2:32 p.m.)


Review request for Plasma.


Repository: breeze


Description
---

New wallpaper for Plasma 5.7

Similar to the 5.6 wallpaper, but using perspective and reflections. Source and 
Splash also attached.


Diffs
-

  wallpapers/Next/contents/images/1024x768.png 60e1205 
  wallpapers/Next/contents/images/1280x1024.png 36a9130 
  wallpapers/Next/contents/images/1280x800.png c33e594 
  wallpapers/Next/contents/images/1440x900.png 2c75b54 
  wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
  wallpapers/Next/contents/images/1638x1024.png a3c7492 
  wallpapers/Next/contents/images/1680x1050.png eddc47e 
  wallpapers/Next/contents/images/1920x1080.png ab6d950 
  wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
  wallpapers/Next/contents/images/2560x1600.png eeb08a1 
  wallpapers/Next/contents/images/3200x1800.png 7340567 
  wallpapers/Next/contents/images/3200x2000.png fd1a62c 
  wallpapers/Next/contents/screenshot.png a6d2b7b 

Diff: https://git.reviewboard.kde.org/r/127575/diff/


Testing
---


File Attachments (updated)


splash.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/450ecd4d-8bbe-48fe-b22a-578ab1968089__splash.png
desktopWallpaper-skylight-1.0-kvermette.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/41f45619-7a37-45dc-a374-27980227414c__2560x1600.png
desktopWallpaper-skylight-1.0-kvermette.svg
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/b19f3502-0204-44f8-a742-f79ff9701f41__desktopWallpaper-skylight-1.0-kvermette.svg
desktopWallpaper-skylight-1.1-kvermette.svg
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/4e52288a-6a3c-4af3-a764-66cb9b0538af__desktopWallpaper-skylight-1.1-kvermette.svg
desktopWallpaper-skylight-1.1-kvermette.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/05/3723026c-f28a-487f-89b4-8e354f4c2715__desktopWallpaper-skylight-1.1-kvermette.png


Thanks,

Ken Vermette

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma 5.6.2

[Jonathan Riddell]

Plasma 5.6.2 is now released https://www.kde.org/announcements/plasma-5.6.2.php

Adds back BBC weather applet (watch out for a few files being added there).

Simplesystray tar is dropped, it's been merged into master branch and
there's no updates being done for 5.6 branch.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 14 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/14/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 05 Apr 2016 16:49:38 +
Build duration: 13 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 42/47 (89%)CLASSES 42/47 (89%)LINE 1661/2088 
(80%)CONDITIONAL 1206/1802 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 90/131 (69%)CONDITIONAL 
34/50 (68%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 14 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/14/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 05 Apr 2016 16:49:38 +
Build duration: 13 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 42/47 (89%)CLASSES 42/47 (89%)LINE 1661/2088 
(80%)CONDITIONAL 1206/1802 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 90/131 (69%)CONDITIONAL 
34/50 (68%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

[Yoann Laissus]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127540/
---

(Updated avr. 5, 2016, 5:23 après-midi)


Review request for Plasma.


Changes
---

,Thanks for the review.

>From your example, I can't manage to get mapRowFromSource() and get() working 
>in filterCallback. It's probably because, at this time, the filtered model 
>isn't yet filled with data.
I take a more classic approach by calling directly source model methods.
I also define the custom NonVirtualStreamModel in its own QML file to avoid 
duplication in multiple places.

I keep AbstractStreamModel in order to be able to retrieve the PulseObject role 
from the NonVirtualStreamModel qml object.

I also fixed virtual stream names and icons.

The branch has been updated here : 
https://quickgit.kde.org/?p=clones%2Fplasma-pa%2Flaissus%2Fplasma-pa.git&a=shortlog&h=bfe3f9ab7d775511815995f4ea9c1453c63dfbdd


Repository: plasma-pa


Description
---

Virtual streams appear when virtual devices are defined in PulseAudio 
configuration (eg: combined output for classic analog and HDMI)
Those virtual streams aren't properly shown in both the KCM and the applet, 
producing ghost entries.

Screens attached.

I added a new property to the Stream object to identify if a stream is real or 
not.
Then, a proxy model takes care of the filtering in the KCM and the applet.
For now, only real devices are shown. But we could add a combobox later, at 
least in the KCM, to be able to display Virtual, Real or both kind of streams. 
(like pavucontrol)

The branch is here : 
https://quickgit.kde.org/?p=clones%2Fplasma-pa%2Flaissus%2Fplasma-pa.git&a=shortlog&h=014d6925b0911f9db2dc5f55cec5e5a9a84df8c9

PS : Other review requests are coming (sink selection for streams) but needs 
some rebasing with David Rosca's latest patches.


Diffs (updated)
-

  applet/contents/ui/StreamListItem.qml 
a47be1cb65d634e49bb9d97f11853ff667f9aa7d 
  applet/contents/ui/main.qml cbe63ced145cd6e755511d025df84a536976eac4 
  src/kcm/package/contents/ui/StreamListItem.qml 
c9ec36c31ef55dbc0281d9807f45f0e48bb4cc41 
  src/kcm/package/contents/ui/StreamView.qml 
b08c87a2452cadd13bae5b0b94b57c3d8f531b3b 
  src/kcm/package/contents/ui/main.qml 3360201dd8e2a4b5ab03c82c94e5c79d8af9ea4c 
  src/pulseaudio.h 9fc9656e84ee4761d9e8dd9d2a7b8c9d0af9e517 
  src/pulseaudio.cpp 14887849a04ff2fb3ded5d0d5e60ec3ce4c40745 
  src/qml/CMakeLists.txt 0c2edb305d2745fd857a552c058cf1b7e652f3eb 
  src/qml/ClientIcon.qml 83545a1a446c6c07611cb59cdc8a7f11e81407e3 
  src/qml/NonVirtualStreamFilterModel.qml PRE-CREATION 
  src/qml/plugin.cpp 5743253f9a7b8283d2bcbeeb081d0706ba4c7b12 
  src/qml/qmldir 88715cac57d6b8c9c6854caa54b0e3d3f773014a 
  src/stream.h b5e09ebaaa0b812f3db81e269671640c783e7c87 
  src/stream.cpp d8f390805e96bbc2dc69ca02520c049b2ca0a4b6 

Diff: https://git.reviewboard.kde.org/r/127540/diff/


Testing
---


File Attachments


KCM
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/fd74b564-2e56-45e2-88b9-6bf526f98311__Screenshot_20160331_225655.png
Applet
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/44b3c277-ee01-4dbf-99f7-dc27edc592e9__Screenshot_20160331_225554.png
pavucontrol
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/5a872915-dd32-4558-9e4e-947f92f75a70__Screenshot_20160331_231548.png
KCM
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/cdf983ea-032f-4246-95b8-ba9a4d228ccd__Screenshot_20160331_232502.png
Applet
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/1a3d3e3a-6078-445d-84c4-8929cb6243a8__Screenshot_20160331_232444.png


Thanks,

Yoann Laissus

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127540/#review94305
---



Also can you please rebase the review?


applet/contents/ui/StreamListItem.qml (line 28)


This should check for client not being null instead.



src/kcm/package/contents/ui/StreamListItem.qml (line 55)


Same as above: `PulseObject.client ? .. : ..`



src/kcm/package/contents/ui/main.qml (line 38)


I think this is also not needed, you should be able to do:

```
model: NonVirtualStreamFilterModel {
sourceModel: SinkInputModel {}
}
```



src/pulseaudio.h (line 64)


I think this change (adding AbstractStreamModel) is not needed.



src/qml/plugin.cpp (line 34)


This should not be registered.



src/stream.h (line 38)


Unrelated


- David Rosca


On April 5, 2016, 5:23 p.m., Yoann Laissus wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127540/
> ---
> 
> (Updated April 5, 2016, 5:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> ---
> 
> Virtual streams appear when virtual devices are defined in PulseAudio 
> configuration (eg: combined output for classic analog and HDMI)
> Those virtual streams aren't properly shown in both the KCM and the applet, 
> producing ghost entries.
> 
> Screens attached.
> 
> I added a new property to the Stream object to identify if a stream is real 
> or not.
> Then, a proxy model takes care of the filtering in the KCM and the applet.
> For now, only real devices are shown. But we could add a combobox later, at 
> least in the KCM, to be able to display Virtual, Real or both kind of 
> streams. (like pavucontrol)
> 
> The branch is here : 
> https://quickgit.kde.org/?p=clones%2Fplasma-pa%2Flaissus%2Fplasma-pa.git&a=shortlog&h=014d6925b0911f9db2dc5f55cec5e5a9a84df8c9
> 
> PS : Other review requests are coming (sink selection for streams) but needs 
> some rebasing with David Rosca's latest patches.
> 
> 
> Diffs
> -
> 
>   applet/contents/ui/StreamListItem.qml 
> a47be1cb65d634e49bb9d97f11853ff667f9aa7d 
>   applet/contents/ui/main.qml cbe63ced145cd6e755511d025df84a536976eac4 
>   src/kcm/package/contents/ui/StreamListItem.qml 
> c9ec36c31ef55dbc0281d9807f45f0e48bb4cc41 
>   src/kcm/package/contents/ui/StreamView.qml 
> b08c87a2452cadd13bae5b0b94b57c3d8f531b3b 
>   src/kcm/package/contents/ui/main.qml 
> 3360201dd8e2a4b5ab03c82c94e5c79d8af9ea4c 
>   src/pulseaudio.h 9fc9656e84ee4761d9e8dd9d2a7b8c9d0af9e517 
>   src/pulseaudio.cpp 14887849a04ff2fb3ded5d0d5e60ec3ce4c40745 
>   src/qml/CMakeLists.txt 0c2edb305d2745fd857a552c058cf1b7e652f3eb 
>   src/qml/ClientIcon.qml 83545a1a446c6c07611cb59cdc8a7f11e81407e3 
>   src/qml/NonVirtualStreamFilterModel.qml PRE-CREATION 
>   src/qml/plugin.cpp 5743253f9a7b8283d2bcbeeb081d0706ba4c7b12 
>   src/qml/qmldir 88715cac57d6b8c9c6854caa54b0e3d3f773014a 
>   src/stream.h b5e09ebaaa0b812f3db81e269671640c783e7c87 
>   src/stream.cpp d8f390805e96bbc2dc69ca02520c049b2ca0a4b6 
> 
> Diff: https://git.reviewboard.kde.org/r/127540/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> KCM
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/fd74b564-2e56-45e2-88b9-6bf526f98311__Screenshot_20160331_225655.png
> Applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/44b3c277-ee01-4dbf-99f7-dc27edc592e9__Screenshot_20160331_225554.png
> pavucontrol
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/5a872915-dd32-4558-9e4e-947f92f75a70__Screenshot_20160331_231548.png
> KCM
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/cdf983ea-032f-4246-95b8-ba9a4d228ccd__Screenshot_20160331_232502.png
> Applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/1a3d3e3a-6078-445d-84c4-8929cb6243a8__Screenshot_20160331_232444.png
> 
> 
> Thanks,
> 
> Yoann Laissus
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 05 Apr 2016 17:21:00 +
Build duration: 49 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 37/39 (95%)CLASSES 37/39 (95%)LINE 2309/3369 
(69%)CONDITIONAL 1565/2670 (59%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/38 (58%)
kcms.keyboard
FILES 21/23 (91%)CLASSES 21/23 (91%)LINE 782/1521 
(51%)CONDITIONAL 632/1019 (62%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
433/838 (52%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/356 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/178 (61%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 251/342 (73%)CONDITIONAL 
82/137 (60%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 05 Apr 2016 17:21:00 +
Build duration: 49 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 37/39 (95%)CLASSES 37/39 (95%)LINE 2309/3369 
(69%)CONDITIONAL 1565/2670 (59%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/38 (58%)
kcms.keyboard
FILES 21/23 (91%)CLASSES 21/23 (91%)LINE 782/1521 
(51%)CONDITIONAL 632/1019 (62%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
433/838 (52%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/356 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/178 (61%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 251/342 (73%)CONDITIONAL 
82/137 (60%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127571: [taskmanager] Stop parsing executables as .desktop files

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127571/#review94310
---


Ship it!




Ship It!

- Eike Hein


On April 4, 2016, 1:44 p.m., Rob Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127571/
> ---
> 
> (Updated April 4, 2016, 1:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> When a binary is launched via an absolute path, then launcherUrl is not
> empty because of [1], even though it is not a .desktop file.
> Consequently, when a user right-clicks on the task item, plasmashell
> attempts to parse the executable as a .desktop configuration file.
> Since this file is obviously not a .desktop file, parsing it as such
> will fail, and KConfig floods ~/.xsession-errors with lots of errors.
> This can quickly add hundreds of megabytes per right-click...
> 
> This patch resolves the problem by not constructing a KDesktopFile if
> the launcherUrl is not a .desktop file.
> 
> An alternative (and more general) way to get rid of the symptoms is to
> modify KDesktopFile / KConfig to stop parsing on the first error and
> write the launcherUrl to the error log (or at the very least limit the
> number of displayed errors). However, it can be argued that you should
> not pass a non-.desktop file to KDesktopFile.
> 
> [1] 
> https://quickgit.kde.org/?p=kde-workspace.git&a=commit&h=3a4b9c85fc21d14838ceac04bb0a70656ee7c701
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/plugin/backend.cpp 07ddfbe 
> 
> Diff: https://git.reviewboard.kde.org/r/127571/diff/
> 
> 
> Testing
> ---
> 
> The following steps demonstrate the issue, and confirms that the patch fixes 
> the bug.
> 
> 1. Create a simple GUI program, as follows:
> ```
> // Compile: clang++ `pkg-config --cflags --libs Qt5Widgets` app.cpp -o app -g 
> -fPIE
> #include 
> #include 
> 
> int main(int argc, char **argv) {
> QApplication app(argc, argv);
> QLabel label("Some GUI app");
> label.show();
> 
> return app.exec();
> }
> ```
> 2. Run the program via an absolute path: $PWD/app.sh
> 3. Right-click on the task item in the task bar (i.e. the program that you 
> just launched).
> 4. Look at ~/.xsession-errors and observe that the following lines were added.
>>
> "KConfigIni: In file /tmp/some-qt-app/app, line 1: " Invalid entry (missing 
> '=')
> "KConfigIni: In file /tmp/some-qt-app/app, line 2: " Invalid entry (missing 
> '=')
> "KConfigIni: In file /tmp/some-qt-app/app, line 3: " Invalid entry (missing 
> '=')
> "KConfigIni: In file /tmp/some-qt-app/app, line 4: " Invalid entry (missing 
> '=')
> "KConfigIni: In file /tmp/some-qt-app/app, line 5: " Invalid entry (missing 
> ']')
> "KConfigIni: In file /tmp/some-qt-app/app, line 6: " "Invalid escape sequence 
> \"\\A\"."
> "KConfigIni: In file /tmp/some-qt-app/app, line 6: " "Invalid escape sequence 
> \"\\\u0001\"."
> ... hundreds of similar lines
> 
> 
> 5. Compile plasma-desktop with this patch and restart plasmashell.
> 6. Repeat step 2 and 3.
> 7. Look at ~/.xsession-errors and observe that the errors are gone.
> 
> 
> Thanks,
> 
> Rob Wu
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 19 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/19/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 05 Apr 2016 19:22:04 +
Build duration: 19 min

CHANGE SET
Revision c35e82b3f1275ba6db9b737c591d2d2952ee2fdd by aleixpol: (It's not 
necessary to provide a shell plugin for the shell anymore)
  change: edit shell/tests/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 42/47 (89%)CLASSES 42/47 (89%)LINE 1661/2088 
(80%)CONDITIONAL 1206/1802 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 90/131 (69%)CONDITIONAL 
34/50 (68%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma-devel Digest, Vol 94, Issue 30

[Chris Topel]

Date: Tue, 5 Apr 2016 12:12:28 +0200 From: Aleix Pol 
 To: "plasma-devel@kde.org"  
Subject: Re: Writing to plasma-desktop-appletsrc with init scripts. 
Message-ID: 
 
Content-Type: text/plain; charset=UTF-8 On Thu, Mar 31, 2016 at 11:17 
PM, Chris Topel  wrote:

>Hey all,
>
>I'm having a bit of an issue trying to make something work in my
>environment.
>
>Basically, I want widgets to be disabled by default. But if a user chooses
>to do so, they can unlock the widgets and make their changes. Then, on
>logout, the widget will automatically be locked again for them so they don't
>accidentally remove it the next day.
>
>So to do that I'd like to use init scripts
>(/usr/share/kde4/apps/plasma-desktop/init/00-defaultLayout.js) to pass
>something directly into plasma-desktop-appletsrc when a user first logs in.
>
>Specifically, I want to add this to the bottom of the file:
>
>[General]
>immutability[$i]=2
>
>This will lock widgets by default but will allow the users to unlock it
>(immutability=1) temporarily to add/move widgets. Then the next time they
>log back in it will be locked (immutability=2) again for them.
>
>So, is there some way I can easily easily set immutability[$i]=2 under the
>[General] section of plasma-desktop-appletsrc?
>
>Thanks in advance!

Shouldn't it be the same making the containment itself immutable?

Aleix

Aleix,

I suppose I could achieve something similar by making the "General" 
containment immutable. Example:


   [General][$i]
   immutability=2

However, the only thing I'm sure that I need to be immutable under 
General is the "2" value for immutability. I'm not sure what else gets 
written to that containment over time and I don't have an urgent need to 
lock any of it down.


Really all I'm trying to do is have widgets locked when a user logs out. 
So far, setting immutability[$i]=2 is the easiest way I've found to 
accomplish that.


If someone has another idea, I'm open to suggestions.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

[Yoann Laissus]

> On avr. 5, 2016, 5:43 après-midi, David Rosca wrote:
> > Also can you please rebase the review?

Rebased


> On avr. 5, 2016, 5:43 après-midi, David Rosca wrote:
> > applet/contents/ui/StreamListItem.qml, line 28
> > 
> >
> > This should check for client not being null instead.

Yes you're right, I have seen some weird cases where client was null for real 
streams too.


> On avr. 5, 2016, 5:43 après-midi, David Rosca wrote:
> > src/kcm/package/contents/ui/main.qml, line 38
> > 
> >
> > I think this is also not needed, you should be able to do:
> > 
> > ```
> > model: NonVirtualStreamFilterModel {
> > sourceModel: SinkInputModel {}
> > }
> > ```

I agree, it's better to move it outside of the ListView.


> On avr. 5, 2016, 5:43 après-midi, David Rosca wrote:
> > src/pulseaudio.h, line 64
> > 
> >
> > I think this change (adding AbstractStreamModel) is not needed.

I had some issues with rbt which hasn't post the right diff from my branch...
It's actually used in NonVirtualStreamFilterModel to get the PulseObject role. 
(see the lastest patch)

It's better than just retrieving it from SinkInputModel for both SinkInputs and 
SourceOutputs.
Do you have better ideas to avoid the use of AbstractStreamModel ?


> On avr. 5, 2016, 5:43 après-midi, David Rosca wrote:
> > src/qml/plugin.cpp, line 34
> > 
> >
> > This should not be registered.

See my comment above.


> On avr. 5, 2016, 5:43 après-midi, David Rosca wrote:
> > src/stream.h, line 38
> > 
> >
> > Unrelated

Right, deleted in the upcoming patch.


- Yoann


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127540/#review94305
---


On avr. 5, 2016, 5:23 après-midi, Yoann Laissus wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127540/
> ---
> 
> (Updated avr. 5, 2016, 5:23 après-midi)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> ---
> 
> Virtual streams appear when virtual devices are defined in PulseAudio 
> configuration (eg: combined output for classic analog and HDMI)
> Those virtual streams aren't properly shown in both the KCM and the applet, 
> producing ghost entries.
> 
> Screens attached.
> 
> I added a new property to the Stream object to identify if a stream is real 
> or not.
> Then, a proxy model takes care of the filtering in the KCM and the applet.
> For now, only real devices are shown. But we could add a combobox later, at 
> least in the KCM, to be able to display Virtual, Real or both kind of 
> streams. (like pavucontrol)
> 
> The branch is here : 
> https://quickgit.kde.org/?p=clones%2Fplasma-pa%2Flaissus%2Fplasma-pa.git&a=shortlog&h=014d6925b0911f9db2dc5f55cec5e5a9a84df8c9
> 
> PS : Other review requests are coming (sink selection for streams) but needs 
> some rebasing with David Rosca's latest patches.
> 
> 
> Diffs
> -
> 
>   applet/contents/ui/StreamListItem.qml 
> a47be1cb65d634e49bb9d97f11853ff667f9aa7d 
>   applet/contents/ui/main.qml cbe63ced145cd6e755511d025df84a536976eac4 
>   src/kcm/package/contents/ui/StreamListItem.qml 
> c9ec36c31ef55dbc0281d9807f45f0e48bb4cc41 
>   src/kcm/package/contents/ui/StreamView.qml 
> b08c87a2452cadd13bae5b0b94b57c3d8f531b3b 
>   src/kcm/package/contents/ui/main.qml 
> 3360201dd8e2a4b5ab03c82c94e5c79d8af9ea4c 
>   src/pulseaudio.h 9fc9656e84ee4761d9e8dd9d2a7b8c9d0af9e517 
>   src/pulseaudio.cpp 14887849a04ff2fb3ded5d0d5e60ec3ce4c40745 
>   src/qml/CMakeLists.txt 0c2edb305d2745fd857a552c058cf1b7e652f3eb 
>   src/qml/ClientIcon.qml 83545a1a446c6c07611cb59cdc8a7f11e81407e3 
>   src/qml/NonVirtualStreamFilterModel.qml PRE-CREATION 
>   src/qml/plugin.cpp 5743253f9a7b8283d2bcbeeb081d0706ba4c7b12 
>   src/qml/qmldir 88715cac57d6b8c9c6854caa54b0e3d3f773014a 
>   src/stream.h b5e09ebaaa0b812f3db81e269671640c783e7c87 
>   src/stream.cpp d8f390805e96bbc2dc69ca02520c049b2ca0a4b6 
> 
> Diff: https://git.reviewboard.kde.org/r/127540/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> KCM
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/fd74b564-2e56-45e2-88b9-6bf526f98311__Screenshot_20160331_225655.png
> Applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/44b3c277-ee01-4dbf-99f7-dc27edc592e9__Screenshot_2016

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

[Yoann Laissus]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127540/
---

(Updated avr. 5, 2016, 8:08 après-midi)


Review request for Plasma.


Changes
---

Updated with David's suggestions.
We juste need to decide what to do with AbstractStreamModel (used in 
NonVirtualStreamFilterModel)


Repository: plasma-pa


Description
---

Virtual streams appear when virtual devices are defined in PulseAudio 
configuration (eg: combined output for classic analog and HDMI)
Those virtual streams aren't properly shown in both the KCM and the applet, 
producing ghost entries.

Screens attached.

I added a new property to the Stream object to identify if a stream is real or 
not.
Then, a proxy model takes care of the filtering in the KCM and the applet.
For now, only real devices are shown. But we could add a combobox later, at 
least in the KCM, to be able to display Virtual, Real or both kind of streams. 
(like pavucontrol)

The branch is here : 
https://quickgit.kde.org/?p=clones%2Fplasma-pa%2Flaissus%2Fplasma-pa.git&a=shortlog&h=014d6925b0911f9db2dc5f55cec5e5a9a84df8c9

PS : Other review requests are coming (sink selection for streams) but needs 
some rebasing with David Rosca's latest patches.


Diffs (updated)
-

  applet/contents/ui/StreamListItem.qml 
a47be1cb65d634e49bb9d97f11853ff667f9aa7d 
  applet/contents/ui/main.qml b5c9540487255fff567b89aab4c3344ee533618a 
  src/kcm/package/contents/ui/StreamListItem.qml 
d1d72bde7f205e6858a8344927f2c34085db5589 
  src/kcm/package/contents/ui/main.qml 0700910b13089bc515199debee9151990aee1bfc 
  src/pulseaudio.h d534fa7e7067d660de608e43cd94470281af1ed4 
  src/pulseaudio.cpp 958451566ac3160bf9f2033c9a471677338f5495 
  src/qml/CMakeLists.txt 0c2edb305d2745fd857a552c058cf1b7e652f3eb 
  src/qml/ClientIcon.qml 83545a1a446c6c07611cb59cdc8a7f11e81407e3 
  src/qml/NonVirtualStreamFilterModel.qml PRE-CREATION 
  src/qml/plugin.cpp 4e52203a25c19fabe5a097b06e8f6d5e522a8246 
  src/qml/qmldir 88715cac57d6b8c9c6854caa54b0e3d3f773014a 
  src/stream.h b5e09ebaaa0b812f3db81e269671640c783e7c87 
  src/stream.cpp d8f390805e96bbc2dc69ca02520c049b2ca0a4b6 

Diff: https://git.reviewboard.kde.org/r/127540/diff/


Testing
---


File Attachments


KCM
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/fd74b564-2e56-45e2-88b9-6bf526f98311__Screenshot_20160331_225655.png
Applet
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/44b3c277-ee01-4dbf-99f7-dc27edc592e9__Screenshot_20160331_225554.png
pavucontrol
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/5a872915-dd32-4558-9e4e-947f92f75a70__Screenshot_20160331_231548.png
KCM
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/cdf983ea-032f-4246-95b8-ba9a4d228ccd__Screenshot_20160331_232502.png
Applet
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/1a3d3e3a-6078-445d-84c4-8929cb6243a8__Screenshot_20160331_232444.png


Thanks,

Yoann Laissus

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 4 lines] D1326: Fix search keyword "animation speed" pointing to the wrong KCM

[colomar (Thomas Pfeiffer)]

colomar created this revision.
colomar added a reviewer: Plasma.
colomar set the repository for this revision to rKWIN KWin.
colomar added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Searching for "animation speed" now points to the Compositing KCM, where the 
animation speed setting is, instead of the Destkop Effects KCM, where it was 
before.
  Fixes BUG: 361436

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1326

AFFECTED FILES
  kcmkwin/kwincompositing/kcmkwineffects.desktop
  kcmkwin/kwincompositing/kwincompositing.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: colomar, Plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Kirigami issues with latest master

[Thomas Pfeiffer]

On Montag, 4. April 2016 15:00:11 CEST Dirk Hohndel wrote:

> But now that I have it working I have two concerns.
> a) the back button becomes really small, depending on the settings for
> scaling the title bar. I guess that's to be expected, I just thought I'd
> point it out

Indeed there is not much to do about it, as having the back button taller than 
the title bar would be strange.

> b) if you are deeper into the page stack, the bread crumbs reasonably
> scroll horizontally to show the title of the current page; unfortunately
> that pushes the back button out of view :-(
> 
> At least that one should be easy to fix...

Indeed, the back button should stay fixed.
 
> Thanks as always

Thanks for the feedback!


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 20 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/20/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 06 Apr 2016 01:37:39 +
Build duration: 16 min

CHANGE SET
Revision eda736a4bdd44b334e6c159f5ad3b9309e151900 by Friedrich W. H. Kossebau: 
([weather] NULL -> nullptr)
  change: edit dataengines/weather/weatherengine.cpp
  change: edit dataengines/weather/ions/envcan/ion_envcan.h
  change: edit dataengines/weather/ions/ion.h
  change: edit dataengines/weather/ions/envcan/ion_envcan.cpp
Revision 864c1ab186b5f87c3e8a81a875768ba2d2dae625 by Friedrich W. H. Kossebau: 
([weather] remove dead code)
  change: edit dataengines/weather/weatherengine.cpp
Revision dd8de63d808333617074bae98308aea6c5059d88 by Friedrich W. H. Kossebau: 
([weather] less casting from ascii)
  change: edit dataengines/weather/weatherengine.cpp
Revision 2d95f93da8a20d9120250f4fe7672ad14325d933 by Friedrich W. H. Kossebau: 
([weather] inline WeatherEngine::init())
  change: edit dataengines/weather/weatherengine.cpp
  change: edit dataengines/weather/weatherengine.h
Revision ff73fbc508f2fdc3a8d7fcb2e23d5ec67ea37e22 by Friedrich W. H. Kossebau: 
([weather] brush up WeatherEngine header)
  change: edit dataengines/weather/weatherengine.h
Revision c02817e0e05fc5598ea3fd60805a9383af824f7e by Friedrich W. H. Kossebau: 
([weather] Improve signature of WeatherEngine::dataUpdated)
  change: edit dataengines/weather/weatherengine.cpp
  change: edit dataengines/weather/weatherengine.h
Revision 20278c4950bd89930c1f03a2292a61220804664e by Friedrich W. H. Kossebau: 
([weather] Use modern signal/slot connection)
  change: edit dataengines/weather/weatherengine.h
  change: edit dataengines/weather/weatherengine.cpp
Revision 9aaae54a8f10ea4f3cafeb3055b483f0882b7436 by Friedrich W. H. Kossebau: 
([weather] less casting from ascii in bbcukmet, noaa & wetter.com ions)
  change: edit dataengines/weather/ions/noaa/ion_noaa.cpp
  change: edit dataengines/weather/ions/wetter.com/ion_wettercom.cpp
  change: edit dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 42/47 (89%)CLASSES 42/47 (89%)LINE 1661/2088 
(80%)CONDITIONAL 1206/1802 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 90/131 (69%)CONDITIONAL 
34/50 (68%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: Enabling users to report issues with Plasma widgets

[Thomas Pfeiffer]

On Dienstag, 5. April 2016 10:45:28 CEST Kai Uwe Broulik wrote:
> Hi,
> 
> > So with the experience of the 40 plugins in KWin I think the possible
> > gains presented here do not justify the addition of code and UI elements.
> I have to disagree. You can't really compare KWin plug-ins of which users
> usually shouldn't even be aware they are a thing to Plasma applets which
> are user-facing mini applications.
> 
> A user might see the network applet shows crap and so they want to report
> specifically that to the network guy, or a minor issue in Kickoff, etc. and
> we usually have a bko component for all applets assigned to the right guy.
> 
> Re the honor of third party applets: yes, that too, we used to have that in
> widget explorer but now there's nowhere to see license or author info.


I agree with Kai: Plasmoids are much more "standalone" from a user's 
perspective than KWin effects. As he said: They are mini applications, after 
all.
And they are more likely to have bugs which the user can actually associate 
with a specific Plasmoid. If a KWin effect goes wrong, users would first have 
to 
identify which one in the list it is, whereas for a Plasmoid it's clear: You 
just click on the thing that went bad.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1326: Fix search keyword "animation speed" pointing to the wrong KCM

[bshah (Bhushan Shah)]

bshah added a comment.


  +1, but OpenGL,XRender,video settings keywords also should move away?

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1326

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: colomar, Plasma
Cc: bshah, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1326: Fix search keyword "animation speed" pointing to the wrong KCM

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D1326#24768, @bshah wrote:
  
  > +1, but OpenGL,XRender,video settings keywords also should move away?
  
  
  Good point! And while we're at it, "compositing" as well.
  I'll do that tomorrow.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1326

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: colomar, Plasma
Cc: bshah, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 21 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/21/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 06 Apr 2016 02:19:19 +
Build duration: 10 min

CHANGE SET
Revision 799ad2da295716aec164b568f4e8a9ecd9a00bda by Friedrich W. H. Kossebau: 
([weather bbcukmet] parse search result properly as json)
  change: edit dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 42/47 (89%)CLASSES 42/47 (89%)LINE 1661/2088 
(80%)CONDITIONAL 1206/1802 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 90/131 (69%)CONDITIONAL 
34/50 (68%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Simple triangle at the bottom right corner, see screenshot.


Diffs
-

  src/declarativeimports/calendar/daysmodel.h 8ab232e 
  src/declarativeimports/calendar/daysmodel.cpp bf99874 
  src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
  src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 

Diff: https://git.reviewboard.kde.org/r/127586/diff/


Testing
---


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127585: integrate pasma-pa kcm docs properly into helpsystem

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127585/
---

Review request for Documentation and Plasma.


Repository: plasma-pa


Description
---

* install to correct path + fix X-DocPath entry in kcm_pulseaudio.desktop 
accordingly
* enable Help button in kcm
* fix docbook
  use translatable entity
  use author and author mail entity
  make it one page (book -> article, no chapters)


Diffs
-

  doc/CMakeLists.txt d5cd2a7 
  doc/index.docbook 8baac2e 
  src/kcm/kcm_pulseaudio.desktop 048edeb 
  src/kcm/module.cpp a9949f6 

Diff: https://git.reviewboard.kde.org/r/127585/diff/


Testing
---

builds, is in khelpcenter navigation tree, Help action in kcm opens the 
corresponding docbook


Thanks,

Burkhard Lück

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1326: Fix search keyword "animation speed" pointing to the wrong KCM

[Martin Gräßlin]

graesslin added a comment.


  nice catch! I would suggest to fix it all.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1326

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: colomar, Plasma
Cc: graesslin, bshah, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel