[HACKERS] Question about an inconsistency - 1
Hi, I have a question regarding the source code in file pg_proc.h (postgresql-9.4.4). At line 1224 (copied below) why the 28th identifier is timestamp_eq? DATA(insert OID = 1152 ( timestamptz_eq PGNSP PGUID 12 1 0 0 0 f f f t t f i 2 0 16 "1184 1184" _null_ _null_ _null_ _null_ timestamp_eq _null_ _null_ _null_ )); I would expect it to be timestamptz_eq (the same as the 5th identifier from the same line). Shouldn't it be the same like in the line 2940 copied also below having the same identifier in the 28th and 5th positions (timestamp_eq)? DATA(insert OID = 2052 ( timestamp_eq PGNSP PGUID 12 1 0 0 0 f f f t t f i 2 0 16 "1114 1114" _null_ _null_ _null_ _null_ timestamp_eq _null_ _null_ _null_ )); A similar question can be asked for lines 1225 to 1229 (but for their specific identifiers). Regards, Pepi signature.asc Description: Message signed with OpenPGP using GPGMail
[HACKERS] Question about an inconsistency - 2
Hi, In file postgresql-9.4.4/src/backend/utils/adt/format_type.c function format_type_internal line 159, shouldn’t be used array_base_type instead of type_oid? In line 153 it is searched for array_base_type and thus shouldn’t we use it (ie., array_base_type) to report that the type is not found. It is similar to the case of searching for type_oid in lines 129-135. Thanks, Petru Florin Mihancea signature.asc Description: Message signed with OpenPGP using GPGMail
[HACKERS] Question about an inconsistency - 3
Hi, In file postgres/postgresql-9.4.4/src/timezone/zic.c function stringzone line 2091we have if (stringrule(result, stdrp, dstrp->r_stdoff, zp->z_gmtoff) != 0) Is it ok to have as the 3rd argument dstrp->r_stdoff or should we have stdrp->r_stdoff? In line 2085 dstrp is used in both arguments. Not very sure because I do not understand the semantics of the invoked operation, but I thought it would be better to ask. Thanks, Petru Florin Mihancea signature.asc Description: Message signed with OpenPGP using GPGMail
