Re: [ pg_ctl ] Review Request for Adding Pre-check User Script Feature

[Kisoon Kwon]

Hi,

0. For more understanding, can you give me an example about your patch?
1. Instead of using chmod itself, it would be better to
use chmod_recursive().
2. It needs to follow the invent convention - it includes 4 spaces now.

Thank you,

Kisoon Kwon

2024년 7월 16일 (화) 오후 3:40, 김명준 님이 작성:

> Hello,
>
> I have been considering adding a user script that performs pre-checks
> before executing the start, stop, and restart operations in pg_ctl. I
> believe it is necessary for pg_ctl to support an extension that can prevent
> various issues that might occur when using start and stop. To this end, I
> have sought a way for users to define and use their own logic. The existing
> behavior remains unchanged, and the feature can be used optionally when
> needed.
>
> The verification of the code was carried out using the methods described
> below, and I would like to request additional opinions or feedback. Tests
> were conducted using make check and through direct testing under various
> scenarios. As this is my first contribution, there might be aspects I
> missed or incorrectly designed.
>
> I would appreciate it if you could review this.
>
> Thank you.
>
>
> Myoungjun Kim / South Korea
>

Re: First draft of PG 17 release notes

[Kisoon Kwon]

Hi,

In the PG17 release notes, I noticed it is mentioned as
"pg_attribute.stxstattarget" which seems incorrect.
In my opinion, it should be "pg_statistic_ext.stxstattarget" because the
"stxstattarget" column is part of the "pg_statistic_ext" catalog.

Regards,
Kisoon Kwon
Bitnine Global (www.bitnine.net)

2024년 7월 6일 (토) 오전 5:53, Bruce Momjian 님이 작성:

> On Fri, Jul  5, 2024 at 07:51:38PM +0200, Matthias van de Meent wrote:
> > Hi,
> >
> > I noticed that PG17's release note for commit cafe10565 is "Allow psql
> > connections to be canceled with control-C (Tristan Partin)", but this
> > summary seems wrong to me.
> >
> > We already had ^C connection (query) cancellation for quite some time
> > before this patch. What's new with that patch, is that we now also can
> > cancel connection attempts with ^C while we're still connecting (i.e.,
> > we haven't yet authenticated and are trying to move the connection
> > state forward).
> > I think a better wording would be "Allow psql connection attempts to
> > be canceled with control-C (Tristan Partin)", or "Allow psql
> > connections to be canceled with control-C while psql is still
> > connecting (Tristan Partin)".
>
> I see your point.  I committed a change to use this wording:
>
>   Allow psql connection attempts to be canceled with control-C
>   (Tristan Partin)
>
> --
>   Bruce Momjian  https://momjian.us
>   EDB  https://enterprisedb.com
>
>   Only you can decide what is important to you.
>
>
>