Re: [PATCH] GROUP BY ALL

2024-07-23 Thread Andrei Borodin
On 23 Jul 2024, at 00:40, Isaac Morland  wrote:odyssey=> select (uw_term).*, count(*) from uw_term group by uw_term;ERROR:  column "uw_term.term_id" must appear in the GROUP BY clause or be used in an aggregate functionLINE 1: select (uw_term).*, count(*) from uw_term group by uw_term;AFAIR this problem was solved in my implementation [0]On 23 Jul 2024, at 01:29, Tom Lane  wrote:(Personally, I'd wonder exactly what ALL is quantified over: thewhole output of the FROM clause, or only columns mentioned in theSELECT tlist, or what? And why that choice rather than another?)I'd like to have GROUP BY AUTO (I also proposed version GROUP BY SURPRISE ME). But I wouldn't like to open pandora box of syntax sugar extensions which may will be incompatible with future standards.If we could have extensible grammar - I'd be happy to have a lot of such enhancements. My top 2 are FROM table SELECT column and better GROUP BY.Best regards, Andrey Borodin.[0] https://www.postgresql.org/message-id/flat/CAAhFRxjyTO5BHn9y1oOSEp0TtpTDTTTb7HJBNhTG%2Bi3-hXC0XQ%40mail.gmail.com

Re: Using read_stream in index vacuum

2024-10-21 Thread Andrei Borodin
Melanie, thanks for your comments.21.10.2024, 22:34, "Melanie Plageman" :The whole point of the read stream callback provided by the caller isthat the logic to get the next block should be thereWe must get number of blocks after examining last block. But callback returning EOF might be called before. With current API we have to restart.Removing extension lock will not change this.Best regards, Andrey Borodin.




Re: UUID v7

2025-03-26 Thread Andrei Borodin
26.03.2025, 21:06, "Masahiko Sawada" :Agreed. I've done this in the attached patch.Great! The patch looks good to me.Best regards, Andrey Borodin.