Add missing meson arguments in docs

2023-02-21 Thread Jelte Fennema
The -Dcassert and -Db_coverage of the meson build didn't show in the
docs that they needed to be passed true or false. All other options
specified the arguments they expected. This patch fixes that.


0001-Add-missing-meson-arguments-in-docs.patch
Description: Binary data


Re: documentation for PGLOADBALANCEHOSTS environment variable in libpq

2023-04-20 Thread Jelte Fennema
Ah, yeah it seems I forgot to document that one. LGTM

On Thu, 20 Apr 2023 at 17:49, Fujii Masao  wrote:
>
> Hi,
>
> Commit 7f5b19817e introduced the PGLOADBALANCEHOSTS environment
> variable for connection load balancing in libpq. However, I found that
> documentation for this variable was missing.
>
> Attached patch adds documentation for PGLOADBALANCEHOSTS environment
> variable in libpq.
>
> Regards,
>
> --
> Fujii Masao
> Advanced Computing Technology Center
> Research and Development Headquarters
> NTT DATA CORPORATION




Re: substring start position behavior

2024-02-27 Thread Jelte Fennema-Nio
On Tue, 27 Feb 2024 at 19:01, PG Doc comments form
 wrote:
> I'd be happy to write up a patch as a next step -- I'm not sure this would
> count as a "trivial patch that serves an obvious need"
> (https://wiki.postgresql.org/wiki/Submitting_a_Patch).

A patch that adds an example of a negative substring usage, seems useful to me.

> Only thing is, I
> can't seem to find the source repo for the docs.

The sources of the docs are simply in the regular postgres docs:
https://github.com/postgres/postgres/blob/e1724af42c7b0bddad2785f8f7a15c4c123862b2/doc/src/sgml/func.sgml#L2786-L2796

> https://www.postgresql.org/docs/current/docguide-toolsets.html mentions a
> configure script, but I don't know which one.

Also meson+ninja is these days faster and easier to use than the
configure script:

https://www.postgresql.org/docs/current/install-meson.html

After setting up the build directory with meson you can build the docs using
ninja -C build docs




Re: Reorder min/max_protocol_version descriptions in libpq documentation

2025-06-17 Thread Jelte Fennema-Nio
On Tue, 17 Jun 2025 at 18:32, Fujii Masao  wrote:
>
> Hi,
>
> Commit 285613c60a7 added the min_protocol_version and max_protocol_version
> connection options to libpq. However, their descriptions currently appear
> in the middle of the unrelated ssl_min_protocol_version and
> ssl_max_protocol_version entries in libpq.sgml. Is there a reason for
> this placement?

Not that I can remember, probably because I copied the
ssl_min_protocol_version section when writing the initial version
min_protocol_version section.

> To make the documentation more intuitive and easier to navigate,
> I suggest moving these entries after the SSL-related options.
> Attached is a patch that does that.

+1