Re: doc: Fix missing or duplicate closing parentheses in some documents

2025-11-06 Thread Daisuke Higuchi
Thank you for checking!

>"a regular expression (when starting with a slash (/))"
>to this:
>"a regular expression starting with a slash (/)"

Yes, I agree with you. I also think this is easier to read.

Regards,

2025年11月7日(金) 13:08 Erik Wienhold :

> On 2025-11-07 02:40 +0100, Daisuke Higuchi wrote:
> > I found that the parentheses seemed not to be handled correctly in
> > following 3 documents, so I attach the patch for this.
> >
> > - closing parentheses is missing
> >   - doc/src/sgml/client-auth.sgml
> >
> > - closing parentheses is duplicate
> >   - doc/src/sgml/ltree.sgml
> >   - doc/src/sgml/trigger.sgml
>
> All three changes make sense.  Although I would rephrase the part in
> client-auth.sgml from this:
>
> "a regular expression (when starting with a slash (/))"
>
> to this:
>
> "a regular expression starting with a slash (/)"
>
> The latter reads nicer IMO and avoids the double closing parenthesis
> which I find a bit awkward.
>
> --
> Erik Wienhold
>


doc: Fix missing or duplicate closing parentheses in some documents

2025-11-06 Thread Daisuke Higuchi
Hi
I found that the parentheses seemed not to be handled correctly in
following 3 documents, so I attach the patch for this.

- closing parentheses is missing
  - doc/src/sgml/client-auth.sgml

- closing parentheses is duplicate
  - doc/src/sgml/ltree.sgml
  - doc/src/sgml/trigger.sgml

Regards


doc_fix_missing_parentheses_client-auth.patch
Description: Binary data


doc_fix_duplicate_parentheses_trigger.patch
Description: Binary data


doc_fix_duplicate_parentheses_ltree.patch
Description: Binary data


doc: Fix the header file where CompareType is defined in gist.sgml

2025-12-13 Thread Daisuke Higuchi
Hi

I found that the header file where CompareType was actually defined did not
match the header file described in gist.sgml.
CompareType is currently defined at "src/include/access/cmptype.h" instead
of "src/include/nodes/primnodes.h".
This change was made in the commit below, but it seems that documentation
update was missed.

https://github.com/postgres/postgres/commit/119fc30dd5bd918819b864107ddc8baac51f4d22

Regards


gist_doc.patch
Description: Binary data