Background worker docs,

[Dave Cramer]

Why is the last comma there ?

"bgw_restart_time is the interval, in seconds, that postgres should wait
before restarting the process, in case it crashes."





diff --git a/doc/src/sgml/bgworker.sgml b/doc/src/sgml/bgworker.sgml
index d34acfc220..6f13006e25 100644
--- a/doc/src/sgml/bgworker.sgml
+++ b/doc/src/sgml/bgworker.sgml
@@ -130,7 +130,7 @@ typedef struct BackgroundWorker

   
bgw_restart_time is the interval, in
seconds, that
-   postgres should wait before restarting the process,
in
+   postgres should wait before restarting the process in
case it crashes.  It can be any positive value,
or BGW_NEVER_RESTART, indicating not to restart the
process in case of a crash.

Dave Cramer

Re: Background worker docs,

[Daniel Gustafsson]

> On 27 Aug 2021, at 15:17, Dave Cramer  wrote:
> 
> Why is the last comma there ?
> 
> "bgw_restart_time is the interval, in seconds, that postgres should wait 
> before restarting the process, in case it crashes."

> -   postgres should wait before restarting the process, in
> +   postgres should wait before restarting the process in

While not being an native english speaker, I agree that this reads better.

--
Daniel Gustafsson   https://vmware.com/

Re: Background worker docs,

[Dave Cramer]

On Fri, 27 Aug 2021 at 09:24, Daniel Gustafsson  wrote:

> > On 27 Aug 2021, at 15:17, Dave Cramer  wrote:
> >
> > Why is the last comma there ?
> >
> > "bgw_restart_time is the interval, in seconds, that postgres should wait
> before restarting the process, in case it crashes."
>
> > -   postgres should wait before restarting the
> process, in
> > +   postgres should wait before restarting the
> process in
>
> While not being an native english speaker, I agree that this reads better.
>

As a native English speaker, I was left wondering what else the timeout
would be used for.


Dave Cramer

Re: Background worker docs,

[Tom Lane]

Dave Cramer  writes:
>> -   postgres should wait before restarting the
>> process, in
>> +   postgres should wait before restarting the
>> process in

> As a native English speaker, I was left wondering what else the timeout
> would be used for.

Maybe s/in case/if/ ?  Or s/in case/after/ ?  It does seem like this
sentence needs more help than just comma-removal.

regards, tom lane

Re: Background worker docs,

[Dave Cramer]

On Fri, 27 Aug 2021 at 09:50, Tom Lane  wrote:

> Dave Cramer  writes:
> >> -   postgres should wait before restarting the
> >> process, in
> >> +   postgres should wait before restarting the
> >> process in
>
> > As a native English speaker, I was left wondering what else the timeout
> > would be used for.
>
> Maybe s/in case/if/ ?  Or s/in case/after/ ?  It does seem like this
> sentence needs more help than just comma-removal.
>

In my mind "in the event that it crashes" made it clear

>
> regards, tom lane
>

Re: Background worker docs,

[Daniel Gustafsson]

> On 27 Aug 2021, at 15:52, Dave Cramer  wrote:
> On Fri, 27 Aug 2021 at 09:50, Tom Lane  > wrote:

> Maybe s/in case/if/ ?  Or s/in case/after/ ?  It does seem like this
> sentence needs more help than just comma-removal.
> 
> In my mind "in the event that it crashes" made it clear 

That, or “if it crashes” gets my vote.

--
Daniel Gustafsson   https://vmware.com/

Re: Background worker docs,

[Tom Lane]

Daniel Gustafsson  writes:
> On 27 Aug 2021, at 15:52, Dave Cramer  wrote:
>> In my mind "in the event that it crashes" made it clear 

> That, or “if it crashes” gets my vote.

Dave's wording sounds good to me.

regards, tom lane

Re: Background worker docs,

[Dave Cramer]

On Fri, 27 Aug 2021 at 10:15, Tom Lane  wrote:

> Daniel Gustafsson  writes:
> > On 27 Aug 2021, at 15:52, Dave Cramer  wrote:
> >> In my mind "in the event that it crashes" made it clear
>
> > That, or “if it crashes” gets my vote.
>
> Dave's wording sounds good to me.
>
> regards, tom lane
>
> revised diff


bgworker_docs.patch
Description: Binary data

Re: Background worker docs,

[Daniel Gustafsson]

> On 27 Aug 2021, at 16:15, Tom Lane  wrote:
> 
> Daniel Gustafsson  writes:
>> On 27 Aug 2021, at 15:52, Dave Cramer  wrote:
>>> In my mind "in the event that it crashes" made it clear 
> 
>> That, or “if it crashes” gets my vote.
> 
> Dave's wording sounds good to me.

I can go make that happen, backpatched down to 9.6 AFAICT on a quick skim,
unless you’re already on it.

--
Daniel Gustafsson   https://vmware.com/

Re: Background worker docs,

[Tom Lane]

Daniel Gustafsson  writes:
> On 27 Aug 2021, at 16:15, Tom Lane  wrote:
>> Dave's wording sounds good to me.

> I can go make that happen, backpatched down to 9.6 AFAICT on a quick skim,
> unless you’re already on it.

Feel free, I've got other stuff on my plate right now.

regards, tom lane

Re: Background worker docs,

[Daniel Gustafsson]

> On 27 Aug 2021, at 16:31, Tom Lane  wrote:
> 
> Daniel Gustafsson  writes:
>> On 27 Aug 2021, at 16:15, Tom Lane  wrote:
>>> Dave's wording sounds good to me.
> 
>> I can go make that happen, backpatched down to 9.6 AFAICT on a quick skim,
>> unless you’re already on it.
> 
> Feel free, I've got other stuff on my plate right now.

And done, thanks.

--
Daniel Gustafsson   https://vmware.com/