Duplicate "SELECT current_user;"

2021-03-17 Thread PG Doc comments form
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/13/ddl-rowsecurity.html
Description:

On this page I see the following example:
cut
=> SELECT current_user;
 current_user 
--
 admin
(1 row)

=> select inet_client_addr();
 inet_client_addr 
--
 127.0.0.1
(1 row)

=> SELECT current_user;
 current_user 
--
 admin
(1 row)
cut

One of executions of "SELECT current_user;" is redundant and can be removed.


A very confusing line...

2021-03-17 Thread PG Doc comments form
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/13/role-membership.html
Description:

I guess the phrase 
because joe “inherits” admin's privileges

should be changed to
because joe was granted admin's privileges.

The point is, otherwise he inherits something that is not inheritable...


Re: Duplicate "SELECT current_user;"

2021-03-17 Thread Tom Lane
PG Doc comments form  writes:
> One of executions of "SELECT current_user;" is redundant and can be removed.

Yeah, I think you're right.  Done in HEAD.

regards, tom lane




Re: A very confusing line...

2021-03-17 Thread Tom Lane
PG Doc comments form  writes:
> I guess the phrase 
> because joe “inherits” admin's privileges

> should be changed to
> because joe was granted admin's privileges.

> The point is, otherwise he inherits something that is not inheritable...

Sure it's inheritable, according to the terminology being used here
(which is baked into the CREATE/ALTER ROLE syntax, so we're not
going to change it lightly).

regards, tom lane