doc: cosmetic changes in index items

2020-11-16 Thread Fujii Masao

Hi,

I found that only the following three index items have " ,"
(i.e., space + comma) in the docs. This is not harmful and
is very minor issue, but I'd like to get rid of that unnecessary
space character for the sake of consistency. Thought?
Patch attached.

  parallel_leader_participation configuration parameter , Other Planner Options
  pg_trgm.strict_word_similarity_threshold configuration parameter , GUC 
Parameters
  pg_trgm.word_similarity_threshold configuration parameter , GUC Parameters

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index f043433e31..080419806f 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -5647,10 +5647,7 @@ SELECT * FROM parent WHERE key = 2400;
   
parallel_leader_participation (boolean)

-
- parallel_leader_participation configuration
- parameter
-
+parallel_leader_participation 
configuration parameter

   
   
diff --git a/doc/src/sgml/pgtrgm.sgml b/doc/src/sgml/pgtrgm.sgml
index 76806302db..ca97c7ce00 100644
--- a/doc/src/sgml/pgtrgm.sgml
+++ b/doc/src/sgml/pgtrgm.sgml
@@ -377,9 +377,7 @@
 
  pg_trgm.word_similarity_threshold (real)
  
-  
-   pg_trgm.word_similarity_threshold configuration 
parameter
-  
+  pg_trgm.word_similarity_threshold 
configuration parameter
  
 
 
@@ -394,9 +392,7 @@
 
  pg_trgm.strict_word_similarity_threshold 
(real)
  
-  
-   pg_trgm.strict_word_similarity_threshold 
configuration parameter
-  
+  pg_trgm.strict_word_similarity_threshold 
configuration parameter
  
 
 


Re: What does "[backends] should seldom or never need to wait for a write to occur" mean?

2020-11-16 Thread Bruce Momjian
On Thu, Nov 12, 2020 at 12:37:30PM -0500, Bruce Momjian wrote:
> On Thu, Nov 12, 2020 at 05:25:30PM +, Chris Wilson wrote:
> > Hi Bruce,
> > 
> > Thanks, I absolutely agree that this documentation needs to explain properly
> > how the bgwriter works. Your latest patch looks good, it significantly 
> > improves
> > this section of the manual. I would just suggest changing "non-dirty" to
> > "clean" in "When the number of non-dirty shared buffers appears to be
> > insufficient", as this makes the language simpler and avoids introducing
> > another new term (non-dirty, which means the same as clean).
> 
> OK, done.  I wasn't sure 'clean' would be assumed to be non-dirty, but you
> are right the language is clearer with 'clean'.  (I was afraid 'clean'
> would be assumed to be 'empty'.)

Patch applied to all supported versions.

-- 
  Bruce Momjian  https://momjian.us
  EnterpriseDB https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee





timed messages

2020-11-16 Thread PG Doc comments form
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/13/plpgsql-errors-and-messages.html
Description:

Please add an example how to format messages, that they will contain
timestamp. Ideally through global/session configuration format for raise
messages.
Thank you in advance.


Re: timed messages

2020-11-16 Thread David G. Johnston
On Mon, Nov 16, 2020 at 2:08 PM PG Doc comments form 
wrote:

> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/13/plpgsql-errors-and-messages.html
> Description:
>
> Please add an example how to format messages, that they will contain
> timestamp.


The only thing the format string gives you is the ability to specify % in a
location and supply the content to print in that location via the optional
expression list.  If you want to print a timestamp you would need to set it
up yourself, probably using to_char(timestamp) as an expression.

Ideally through global/session configuration format for raise
> messages.
>
>
That isn't a thing in PostgreSQL.

You can set up a log file line format that includes such things, but the
raw message content for RAISED is no more or less than what you either type
literally or it computes from format+expressions.

David J.