Re: Detecting which columns a query will modify in a function called by a trigger

2020-10-02 Thread David G. Johnston
On Tue, Mar 3, 2020 at 4:19 PM David G. Johnston 
wrote:

> On Tue, Mar 3, 2020 at 4:11 PM Adrian Klaver 
> wrote:
>
>> On 3/3/20 3:06 PM, David G. Johnston wrote:
>> > On Tue, Mar 3, 2020 at 3:48 PM Adrian Klaver > > > wrote:
>> >
>> > The link was for automatically updateable views. If you want to do
>> > something more involved then see:
>> >
>> >
>> https://www.postgresql.org/docs/12/rules-views.html#RULES-VIEWS-UPDATE
>> >
>> >
>> > CREATE TRIGGER works with views; I usually see recommendations to start
>> > there and avoid rules if at all possible.
>>
>> The above suggests triggers then rules.
>>
>
> Yeah, I see the buried in there.  The link itself and the page itself is
> something like 95% rules coverage so it still seems worth pointing out even
> in hindsight.
>
> Maybe add a link to the CREATE TRIGGER section in there...
>

Minor doc patch for this attached for consideration.

David J.


v1-notify-doc-fixup.patch
Description: Binary data


Re: Chapter 7. Queries

2020-10-02 Thread David G. Johnston
On Mon, Sep 14, 2020 at 6:03 PM David G. Johnston <
david.g.johns...@gmail.com> wrote:

> Given that 7.6 is named "LIMIT and OFFSET" I don't have an issue with
> adding the relevant keywords (including EXCEPT and INTERSECT) in those two
> places.
>

Patch attached.

David J.


v1-doc-add-select-literals-to-queries-section-headers.patch
Description: Binary data


Re: small clairifcation

2020-10-02 Thread Bruce Momjian
On Mon, Aug 31, 2020 at 08:42:57PM -0400, Bruce Momjian wrote:
> On Thu, Aug 27, 2020 at 09:51:49PM -0700, David G. Johnston wrote:
> > On Thu, Aug 27, 2020 at 6:17 PM Tom Lane  wrote:
> > 
> > PG Doc comments form  writes:
> > > The following documentation comment has been logged on the website:
> > > Page: https://www.postgresql.org/docs/9.5/ssh-tunnels.html
> > > Description:
> > 
> > > "The first number in the -L argument, 6, is the port number of 
> > your
> > end
> > > of the tunnel; it can be any unused port. (IANA reserves ports 49152
> > through
> > > 65535 for private use.) The second number, 5432, is the remote end of 
> > the
> > > tunnel: the port number your server is using. "
> > 
> > > as a beginner This took me some time to understand what do you mean by
> > "your
> > > server" "your end of the tunnel "
> > 
> > Hm, do you have a suggestion for better wording?
> > 
> > 
> > 
> > I agree on the need for a different perspective here since it reads just 
> > fine
> > once you know what it is talking about.
> > 
> > But absent that maybe a slightly more tutorial flow would be good.
> 
> I didn't think a tutorial flow was the right thing to here, so I
> reworded the section to be more details and have a clearer flow ---
> patch attached.

Patch applied to all supported versions.  Thanks for the report.
 
-- 
  Bruce Momjian  https://momjian.us
  EnterpriseDB https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee