Re: Adding xreflable
On 2020-05-22 18:45, Bruce Momjian wrote: Ugh, I see what you mean. I have read doc/src/sgml/README.links many times and still get confused. What you are saying is that if there is no xreflabel on a target, you can get the chapter/section via or specify text via . But, if there is an xreflabel on the target, you can't get the chapter/section anymore --- you can only get the xreflabel via , or specify text via , right? I think that's right. I added 13 xreflabels in commits 85af628da5 and 75fcdd2ae2. What I am thinking of doing is to look at all references to the id's associated with those xreflabels and remove the xreflabel if the chapter/section is required, and if not, convert to where the link text matches the xreflabel. Does that sound like a good plan? Both of those commits should be reverted. I don't quite understand your plan, but if you mean, check whether anyone else links to the id in question, that doesn't sound sustainable. A new link could be added at any time in the future. I think the release notes should either just use a plain to link and use whatever generated text it gets, or if you don't like that, use . Which is basically what it was before, IIRC. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Re: descriptions of pg_stat_user_functions and pg_stat_slru
On 2020/05/25 14:23, Fujii Masao wrote: On 2020/05/22 22:35, Fujii Masao wrote: On 2020/05/21 4:53, Tom Lane wrote: Fujii Masao writes: On 2020/05/20 22:32, Tom Lane wrote: OK by me --- that, too, would be more like the existing catalogs chapter. Yeah, so I'd like to propose the attached patch. Hmmm ... I'm not exactly convinced about sticking xreflabels onto the s as you've done here. Presumably that would make s render like "pg_stat_slru" not "Section 27.2.3", which I think is not consistent with our practice elsewhere. I'd be inclined to leave the id attributes on the s, and add xreflabels there if we want them. I see that catalogs.sgml doesn't really match either of those approaches, though. Not sure if we want to change it. It looks like people have tended to use to substitute text for xref's to the catalog sections, so maybe it would be better to add xreflabels there too and simplify the references. Yeah, since I think that using is simpler than , I added xlabel in . But if we don't do that for the consistency with catalog.sgml, I think that there are two approaches. (1) Replace with when referencing to the monitoring views docs. For example, add and replace with . (2) Leave as it is. In this case, for example, references to the table of pg_stat_replication instead of the section. I prefer (1) because it's better to reference to the section rather than the table. There are thirty for monitoring views in the docs and they need to be updated. Attached (monitoring_docfix_v2.patch) is the patch for (1). Barring any objection, I will commit this patch. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION
wal_init_zero and wal_recycle
Hi, The group of wal_init_zero and wal_recycle is WAL_SETTINGS in guc.c, but their descriptions are located in "19.6. Replication"/"19.6.1. Sending Servers" section. This seems a documentation bug. They should be located in "19.5. Write Ahead Log"/"19.5.1. Settings". Thought? Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION
