ERROR: (host) should be replaced by (hostnogssenc).

2020-05-24 Thread PG Doc comments form
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/12/encryption-options.html
Description:

Chapter 18. Server Setup and Operation
18.8. Encryption Options

Under the topic "Encrypting Data Across A Network", I think there seems to
be a documentation error.

ERROR: (host) should be replaced by (hostnogssenc).

The pg_hba.conf file allows administrators to specify which hosts can use
non-encrypted connections (host) and which require GSSAPI-encrypted
connections (hostgssenc). Also, clients can specify that they connect to
servers only on GSSAPI-encrypted connections (gssencmode=require).

Thanks,
Raj Kumar


Re: ERROR: (host) should be replaced by (hostnogssenc).

2020-05-24 Thread Tom Lane
PG Doc comments form  writes:
> Under the topic "Encrypting Data Across A Network", I think there seems to
> be a documentation error.

> ERROR: (host) should be replaced by (hostnogssenc).

> The pg_hba.conf file allows administrators to specify which hosts can use
> non-encrypted connections (host) and which require GSSAPI-encrypted
> connections (hostgssenc). Also, clients can specify that they connect to
> servers only on GSSAPI-encrypted connections (gssencmode=require).

I think it's correct as it stands.  hostnogssenc would have the semantics
"hosts that MUST use non-encrypted connections".

If that were actually a useful option, maybe it would be worth lengthening
this description to mention all three options ... but it seems OK as-is to
me.

regards, tom lane




Re: descriptions of pg_stat_user_functions and pg_stat_slru

2020-05-24 Thread Fujii Masao



On 2020/05/22 22:35, Fujii Masao wrote:



On 2020/05/21 4:53, Tom Lane wrote:

Fujii Masao  writes:

On 2020/05/20 22:32, Tom Lane wrote:

OK by me --- that, too, would be more like the existing catalogs
chapter.



Yeah, so I'd like to propose the attached patch.


Hmmm ... I'm not exactly convinced about sticking xreflabels onto
the s as you've done here.  Presumably that would make s
render like "pg_stat_slru" not "Section 27.2.3", which I think is
not consistent with our practice elsewhere.  I'd be inclined to
leave the id attributes on the s, and add xreflabels there
if we want them.

I see that catalogs.sgml doesn't really match either of those approaches,
though.  Not sure if we want to change it.  It looks like people have
tended to use  to substitute text for xref's to the catalog
sections, so maybe it would be better to add xreflabels there too
and simplify the references.


Yeah, since I think that using  is simpler than , I added xlabel
in . But if we don't do that for the consistency with catalog.sgml,
I think that there are two approaches.

(1) Replace  with  when referencing to the monitoring views
    docs. For example, add 
    and replace  with
    .

(2) Leave  as it is. In this case, for example,
     references to the table
    of pg_stat_replication instead of the section.

I prefer (1) because it's better to reference to the section rather than
the table. There are thirty  for monitoring views in the docs and
they need to be updated.


Attached (monitoring_docfix_v2.patch) is the patch for (1).

I also attached the patch 
(update_release_note_for_monitoring_stats_views_v1.patch)
that updates the tags referencing to pg_stat_xxx views in release note.
I will propose this to Bruce if we can agree with the changes in 
monitoring.sgml.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
index 9851ef2713..632e6d23f7 100644
--- a/doc/src/sgml/catalogs.sgml
+++ b/doc/src/sgml/catalogs.sgml
@@ -10455,8 +10455,9 @@ SCRAM-SHA-256$:&l
 
   
The pid column can be joined to the
-   pid column of the pg_stat_activity
+   pid column of the
+   
+   pg_stat_activity
view to get more
information on the session holding or awaiting each lock,
for example
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index a2694e548a..4eef970d41 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -3889,9 +3889,9 @@ restore_command = 'copy "C:\\server\\archivedir\\%f" 
"%p"'  # Windows
 The synchronous standbys will be those whose names appear
 in this list, and
 that are both currently connected and streaming data in real-time
-(as shown by a state of streaming in the pg_stat_replication
-view).
+(as shown by a state of streaming in the
+
+pg_stat_replication view).
 Specifying more than one synchronous standby can allow for very high
 availability and protection against data loss.

@@ -4244,8 +4244,8 @@ ANY num_sync 
( pg_stat_replication
+   
+   pg_stat_replication
view.  The standby will report
the last write-ahead log location it has written, the last position it
has flushed to disk, and the last position it has applied.
@@ -6694,8 +6694,10 @@ local0.*/var/log/postgresql
 
  
   The backend type corresponds to the column
-  backend_type in the view , but additional types can appear
+  backend_type in the view
+  
+  pg_stat_activity,
+  but additional types can appear
   in the log that don't show in that view.
  
 
@@ -7191,7 +7193,8 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH 
csv;
 platforms.  You can use the  tool to
 measure the overhead of timing on your system.
 I/O timing information is
-displayed in , in the output of
+displayed in 
+pg_stat_database, in the output of
  when the BUFFERS 
option is
 used, and by .  Only superusers can
 change this setting.
diff --git a/doc/src/sgml/high-availability.sgml 
b/doc/src/sgml/high-availability.sgml
index 805e100055..65c3fc62a9 100644
--- a/doc/src/sgml/high-availability.sgml
+++ b/doc/src/sgml/high-availability.sgml
@@ -895,7 +895,8 @@ primary_conninfo = 'host=192.168.1.50 port=5432 user=foo 
password=foopass'
 
 
  You can retrieve a list of WAL sender processes via the
-  view. Large differences between
+ 
+ pg_stat_replication view. Large differences between
  pg_current_wal_lsn and the view's 
sent_lsn field
  might indicate that the master server is under heavy load, while
  differences between sent_lsn and
@@ -904,7 +905,8 @@ primary_conninfo = 'host=192.168.1.50 port=5432 user=foo 
password=foopass'