Minor error

2020-03-04 Thread PG Doc comments form 
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/12/indexes-partial.html
Description:

A sentence on this page reads:
"The system can recognize simple inequality implications, for example “x <
1” implies “x < 2”; otherwise the predicate condition must exactly match
part of the query's WHERE condition or the index will not be recognized as
usable."

I think it's supposed to read ..."x <=1" implies "x < 2"... ?

ALTER TABLE syntax incomplete

2020-03-04 Thread PG Doc comments form 
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/11/sql-altertable.html
Description:

I believe the documentation page
https://www.postgresql.org/docs/11/sql-altertable.html is missing the action
ADD CONSTRAINT, as it is mentioned in the descriptions of other keywords.

Possible typos in the #12.1.1 examples

2020-03-04 Thread PG Doc comments form 
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/12/textsearch-intro.html
Description:

SELECT title || ' ' ||  author || ' ' ||  abstract || ' ' || body AS
document
FROM messages
WHERE mid = 12;

Seems like here the example missed 'm' as an alias and a dot in the `where`
clause:
... messages m
... m.id = 12;


SELECT m.title || ' ' || m.author || ' ' || m.abstract || ' ' || d.body AS
document
FROM messages m, docs d
WHERE mid = did AND mid = 12;

Possibly, the example missed dots: 
... m.id = d.id AND m.id = 12;

Thanks!

Error in docs

2020-03-04 Thread PG Doc comments form 
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/9.5/explicit-locking.html
Description:

https://www.postgresql.org/docs/12/explicit-locking.html

In the block after this sentence: "This acquires a row-level lock on the row
with the specified account number. Then, the second transaction executes:"
The second update statement has the worng

Re: Possible typos in the #12.1.1 examples

2020-03-04 Thread Michael Paquier 
On Mon, Mar 02, 2020 at 03:38:01PM +, PG Doc comments form wrote:
> Seems like here the example missed 'm' as an alias and a dot in the `where`
> clause:
> ... messages m
> ... m.id = 12;

This query is valid as-is.

> SELECT m.title || ' ' || m.author || ' ' || m.abstract || ' ' || d.body AS
> document
> FROM messages m, docs d
> WHERE mid = did AND mid = 12;
> 
> Possibly, the example missed dots: 
> ... m.id = d.id AND m.id = 12;

This one is actually valid as well, as long as both relations don't
use the same column names, but I can see your point to add the aliases
to the quals of the WHERE clause to bring more clarity.
--
Michael


signature.asc
Description: PGP signature

Re: Error in docs

2020-03-04 Thread Michael Paquier 
On Tue, Mar 03, 2020 at 01:30:15PM +, PG Doc comments form wrote:
> In the block after this sentence: "This acquires a row-level lock on the row
> with the specified account number. Then, the second transaction executes:"
> The second update statement has the worng

What do you think is wrong here?
--
Michael


signature.asc
Description: PGP signature

Re: ALTER TABLE syntax incomplete

2020-03-04 Thread Michael Paquier 
On Fri, Feb 28, 2020 at 04:26:57PM +, PG Doc comments form wrote:
> I believe the documentation page
> https://www.postgresql.org/docs/11/sql-altertable.html is missing the action
> ADD CONSTRAINT, as it is mentioned in the descriptions of other keywords.

The documentation includes this description as part of the subquery
"table_constraint".
--
Michael


signature.asc
Description: PGP signature