auto_explain.log_min_duration is limit for nested statement

2019-11-04 Thread PG Doc comments form
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/12/auto-explain.html
Description:

Hello,

I had problem with setup auto_explain.log_min_duration for COPY command on
table with triggers. I set minimum duration to '2s' but no plan logged
(duration of COPY command was above this limit). I thought that this
extension not working with COPY command. After some testing I investigate
that extension is working becouse duration limit is for nested statement
(query in trigger) not for base statement (COPY) - it will be fine write
somewere in documentation.

Thanks


Re: wal_sender_timeout / wal_receiver_timeout - seconds or milliseconds?

2019-11-04 Thread Bruce Momjian
On Thu, Oct 24, 2019 at 01:06:45PM +, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
> 
> Page: https://www.postgresql.org/docs/12/runtime-config-replication.html
> Description:
> 
> Dear sir or madam!
> 
> The documentation about the parameter wal_sender_timeout refers to an
> integer value in milliseconds in the first sentence. Reading up to the
> default value in the paragraph, it is set to 60 seconds. The same difference
> of milliseconds and seconds is included in postgresql.conf:
> 
> #wal_sender_timeout = 60s   # in milliseconds; 0 disables
> 
> This difference is found in the documentation and postgresql.conf for
> parameter wal_receiver_timeout, too.
> 
> #wal_receiver_timeout = 60s # time that receiver waits for
> # communication from master
> # in milliseconds; 0 disables
> 
> Please check and verify. - Thank you!

The default _value_ is 60 seconds, and we use the 's' to specify
seconds.  What the comment is saying is that if you _don't_ specify any
units, the integer is in milliseconds.  I am not sure how to improve
that.

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+  Ancient Roman grave inscription +




Re: wal_sender_timeout / wal_receiver_timeout - seconds or milliseconds?

2019-11-04 Thread Michael Paquier
On Mon, Nov 04, 2019 at 09:52:34PM -0500, Bruce Momjian wrote:
> The default _value_ is 60 seconds, and we use the 's' to specify
> seconds.  What the comment is saying is that if you _don't_ specify any
> units, the integer is in milliseconds.  I am not sure how to improve
> that.

I do have a suggestion as per the attached, say:
+#wal_sender_timeout = 60s  # in milliseconds if no unit specified;
+   # 0 disables
--
Michael
diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
index 0fc23e3a61..eea017e840 100644
--- a/src/backend/utils/misc/postgresql.conf.sample
+++ b/src/backend/utils/misc/postgresql.conf.sample
@@ -286,7 +286,8 @@
 #max_wal_senders = 10		# max number of walsender processes
 # (change requires restart)
 #wal_keep_segments = 0		# in logfile segments; 0 disables
-#wal_sender_timeout = 60s	# in milliseconds; 0 disables
+#wal_sender_timeout = 60s	# in milliseconds if no unit specified;
+# 0 disables
 
 #max_replication_slots = 10	# max number of replication slots
 # (change requires restart)
@@ -326,7 +327,8 @@
 	# query conflicts
 #wal_receiver_timeout = 60s		# time that receiver waits for
 	# communication from master
-	# in milliseconds; 0 disables
+	# in milliseconds if no unit specified;
+	# 0 disables
 #wal_retrieve_retry_interval = 5s	# time to wait before retrying to
 	# retrieve WAL after a failed attempt
 #recovery_min_apply_delay = 0		# minimum delay for applying changes during recovery


signature.asc
Description: PGP signature