Re: SPITupleTable members missing in docs
> On 15 Jul 2019, at 23:18, Fabien COELHO wrote: >> I quite like this suggestion, so I’ve changed the patch to do this. Removed >> the doc: in the commit message to indicate that this is no longer just >> touching >> documentation. > > About v2: applies cleanly, compiles, make check and doc gen ok. > > However, the documentation does not look right, field comments are not > aligned. Do not use tabs in the sgml file, use spaces only, otherwise the > display layout is left to chance. Of course, that was me fat-fingering. Fixed in the attached v3. Thanks for reviewing! cheers ./daniel spitupletable-v3.patch Description: Binary data
User mapping security
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/10/postgres-fdw.html Description: Regarding the documentation pages https://www.postgresql.org/docs/10/postgres-fdw.html?origin_team=T02HEPYKQ and https://www.postgresql.org/docs/10/sql-createusermapping.html I suppose it should be warned on the pages that foreign credentials with be stored as simple text and will be available for viewing in pg_user_mappings.
Re: SPITupleTable members missing in docs
I quite like this suggestion, so I’ve changed the patch to do this. Removed the doc: in the commit message to indicate that this is no longer just touching documentation. About v2: applies cleanly, compiles, make check and doc gen ok. However, the documentation does not look right, field comments are not aligned. Do not use tabs in the sgml file, use spaces only, otherwise the display layout is left to chance. Of course, that was me fat-fingering. Fixed in the attached v3. Thanks for reviewing! V3 fixes the html display alignment issue. Patch marked as ready. -- Fabien.
Re: SPITupleTable members missing in docs
Daniel Gustafsson writes: >> On 15 Jul 2019, at 23:18, Fabien COELHO wrote: >> However, the documentation does not look right, field comments are not >> aligned. Do not use tabs in the sgml file, use spaces only, otherwise the >> display layout is left to chance. > Of course, that was me fat-fingering. Fixed in the attached v3. Thanks for > reviewing! Pushed with some marginal additional fiddling with the comments. regards, tom lane
