Re: SPITupleTable members missing in docs

[Daniel Gustafsson]

> On 12 Jul 2019, at 17:04, Tom Lane  wrote:
> 
> Fabien COELHO  writes:
>> To take into account Tom's comment, I'd suggest a middle ground by 
>> commenting a public and private part explicitely in the struct, something 
>> like:

Thanks for the review!

>>   typedef struct {
>> /* PUBLIC members to be used by callers ... */
>> ...
>> ...
>> /* PRIVATE members, not intended for external usage ... */
>> ...
>>   } ... ;
> 
> One problem is that the members we've retroactively decided are "public"
> are in the middle of the struct :-(.
> 
> But it occurs to me that there's no good reason we couldn't re-order the
> members, as long as we only do so on HEAD and not in released versions.
> That would make it a bit less inconsistent and easier to add labels
> such as you suggest.

I quite like this suggestion, so I’ve changed the patch to do this.  Removed
the doc: in the commit message to indicate that this is no longer just touching
documentation.

cheers ./daniel



spitupletable-v2.patch
Description: Binary data

Re: Outdated tip in the "Adding a column section"

[Daniel Gustafsson]

> On 14 Jul 2019, at 08:12, Daniel Westermann (DWE) 
>  wrote:

> This is not true anymore since PostgreSQL 11, isn't it? If agreed, I would 
> try to write my first patch to remove that.

Correct, as long as the default isn’t volatile.  This was changed in 16828d5c0,
please go ahead and propose a patch.

cheers ./daniel

Re: SPITupleTable members missing in docs

[Fabien COELHO]

Hello Daniel,

I quite like this suggestion, so I’ve changed the patch to do this. 
Removed the doc: in the commit message to indicate that this is no 
longer just touching documentation.


And it should be posted to .

--
Fabien.

Re: SPITupleTable members missing in docs

[Tom Lane]

Fabien COELHO  writes:
> Hello Daniel,
>> I quite like this suggestion, so I’ve changed the patch to do this. 
>> Removed the doc: in the commit message to indicate that this is no 
>> longer just touching documentation.

> And it should be posted to .

Seems excessive, since there's no actual functional change here.

regards, tom lane

Re: SPITupleTable members missing in docs

[Fabien COELHO]

I quite like this suggestion, so I’ve changed the patch to do this.  Removed
the doc: in the commit message to indicate that this is no longer just touching
documentation.


About v2: applies cleanly, compiles, make check and doc gen ok.

However, the documentation does not look right, field comments are not 
aligned. Do not use tabs in the sgml file, use spaces only, otherwise the 
display layout is left to chance.


--
Fabien.