Re: Ambiguous language in Table 8.13. Special Date/Time Inputs [EXT]

2019-07-11 Thread David Harper
> One really simple way to make it shorter is to say "00:00", leaving
> out the seconds.

That’s a good solution.  It removes the long-standing ambiguity without looking 
too ugly.

Best regards

David Harper

Wellcome Sanger Institute, Cambridge, England

--
 The Wellcome Sanger Institute is operated by Genome Research
 Limited, a charity registered in England with number 1021457 and a
 company registered in England with number 2742969, whose registered
 office is 215 Euston Road, London, NW1 2BE.




Re: Ambiguous language in Table 8.13. Special Date/Time Inputs [EXT]

2019-07-11 Thread Bruce Momjian
On Thu, Jul 11, 2019 at 09:34:58AM +0100, David Harper wrote:
> > One really simple way to make it shorter is to say "00:00", leaving
> > out the seconds.
> 
> That’s a good solution.  It removes the long-standing ambiguity without 
> looking too ugly.

OK, how is this patch?

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+  Ancient Roman grave inscription +
diff --git a/doc/src/sgml/datatype.sgml b/doc/src/sgml/datatype.sgml
index 35ecd48ed5..ce9d2dddf1 100644
--- a/doc/src/sgml/datatype.sgml
+++ b/doc/src/sgml/datatype.sgml
@@ -2174,17 +2174,17 @@ January 8 04:05:06 1999 PST
  
   today
   date, timestamp
-  midnight today
+  midnight (00:00) today
  
  
   tomorrow
   date, timestamp
-  midnight tomorrow
+  midnight (00:00) tomorrow
  
  
   yesterday
   date, timestamp
-  midnight yesterday
+  midnight (00:00) yesterday
  
  
   allballs


misc doc fixes for REL_12_STABLE

2019-07-11 Thread Liudmila Mantrova

Hi,

Please consider a patch that fixes some trivial issues in new doc 
fragments (a couple of typos/ambiguities and some tags that affect 
translation).


--
Liudmila Mantrova
Technical writer at Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

diff --git a/doc/src/sgml/backup.sgml b/doc/src/sgml/backup.sgml
index 9d4c000..2fdbcb4 100644
--- a/doc/src/sgml/backup.sgml
+++ b/doc/src/sgml/backup.sgml
@@ -962,10 +962,10 @@ SELECT * FROM pg_stop_backup(false, true);
  The process for an exclusive backup is mostly the same as for a
  non-exclusive one, but it differs in a few key steps. This type of
  backup can only be taken on a primary and does not allow concurrent
- backups.  Moreover, because it writes a backup_label file on the
- master, it can cause the master to fail to restart automatically after
- a crash.  On the other hand, the erroneous removal of a backup_label
- file from a backup or standby is a common mistake which can result
+ backups.  Moreover, because it creates a backup label file, as
+ described below, it can block automatic restart of the master server
+ after a crash. On the other hand, the erroneous removal of this
+ file from a backup or standby is a common mistake, which can result
  in serious data corruption.  If it is necessary to use this method,
  the following steps may be used.
 
@@ -1025,10 +1025,10 @@ SELECT pg_start_backup('label', true);
 
 
  As noted above, if the server crashes during the backup it may not be
- possible to restart until the backup_label file has
+ possible to restart until the backup_label file has
  been manually deleted from the PGDATA directory.  Note
  that it is very important to never remove the
- backup_label file when restoring a backup, because
+ backup_label file when restoring a backup, because
  this will result in corruption.  Confusion about when it is appropriate
  to remove this file is a common cause of data corruption when using this
  method; be very certain that you remove the file only on an existing
@@ -1075,7 +1075,7 @@ SELECT pg_stop_backup();
  lack of disk space, failure to call pg_stop_backup
  will leave the server in backup mode indefinitely, causing future backups
  to fail and increasing the risk of a restart failure during the time that
- backup_label exists.
+ backup_label exists.
 

   
diff --git a/doc/src/sgml/biblio.sgml b/doc/src/sgml/biblio.sgml
index f06305d..bf3aebd 100644
--- a/doc/src/sgml/biblio.sgml
+++ b/doc/src/sgml/biblio.sgml
@@ -137,14 +137,11 @@

 

-SQL Technical Report
+http://standards.iso.org/ittf/PubliclyAvailableStandards/c067367_ISO_IEC_TR_19075-6_2017.zip";>SQL Technical Report
 Part 6: SQL support for JavaScript Object
   Notation (JSON)
-First Edition.
-
-http://standards.iso.org/ittf/PubliclyAvailableStandards/c067367_ISO_IEC_TR_19075-6_2017.zip";>.
-
-2017.
+First Edition
+2017

 
   
diff --git a/doc/src/sgml/ref/alter_foreign_table.sgml b/doc/src/sgml/ref/alter_foreign_table.sgml
index b27eb6f..0f11897 100644
--- a/doc/src/sgml/ref/alter_foreign_table.sgml
+++ b/doc/src/sgml/ref/alter_foreign_table.sgml
@@ -227,8 +227,8 @@ ALTER FOREIGN TABLE [ IF EXISTS ] name
  
   Backward compatibility syntax for removing the oid
-  system column. As oid system columns cannot be added anymore, this never
-  has an effect.
+  system column. As oid system columns cannot be added
+  anymore, this never has an effect.
  
 

diff --git a/doc/src/sgml/ref/pg_checksums.sgml b/doc/src/sgml/ref/pg_checksums.sgml
index 33706d1..162bafd 100644
--- a/doc/src/sgml/ref/pg_checksums.sgml
+++ b/doc/src/sgml/ref/pg_checksums.sgml
@@ -120,7 +120,7 @@ PostgreSQL documentation
 to be written safely to disk.  This option causes
 pg_checksums to return without waiting, which is
 faster, but means that a subsequent operating system crash can leave
-the updated data folder corrupt.  Generally, this option is useful
+the updated data directory corrupt.  Generally, this option is useful
 for testing but should not be used on a production installation.
 This option has no effect when using --check.

diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml
index 8fa2314..017713f 100644
--- a/doc/src/sgml/ref/pg_dump.sgml
+++ b/doc/src/sgml/ref/pg_dump.sgml
@@ -749,7 +749,7 @@ PostgreSQL documentation
   --extra-float-digits=ndigits
   

-Use the specified value of extra_float_digits when dumping
+Use the specified value of extra_float_digits when dumping
 floating-point data, instead of the maximum available precision.
 Routine dumps made for backup purposes should not use this option.

diff --git a/doc/src/sgml/ref/pg_rewind.sgml b/doc/src/s

Re: misc doc fixes for REL_12_STABLE

2019-07-11 Thread Michael Paquier
On Thu, Jul 11, 2019 at 05:49:26PM +0300, Liudmila Mantrova wrote:
> Please consider a patch that fixes some trivial issues in new doc fragments
> (a couple of typos/ambiguities and some tags that affect translation).

Thanks for the patch.  I have one comment.

> - backups.  Moreover, because it writes a backup_label file on the
> - master, it can cause the master to fail to restart automatically after
> - a crash.  On the other hand, the erroneous removal of a backup_label
> - file from a backup or standby is a common mistake which can result
> + backups.  Moreover, because it creates a backup label file, as
> + described below, it can block automatic restart of the master server
> + after a crash. On the other hand, the erroneous removal of this
> + file from a backup or standby is a common mistake, which can result
>   in serious data corruption.  If it is necessary to use this method,
>   the following steps may be used.

Okay, yes that could be a bit confusing for the reader.  Nit: I would
replace "master" with "primary" while we are in the area.  What do you
think?

But that's the only comment I have, the rest looks good!
--
Michael


signature.asc
Description: PGP signature