`transaction_read_only` GUC undocumented
Hello. I found that `transaction_read_only`GUC is undocumented. The only place where it referenced is Hot Standby section (https://www.postgresql.org/docs/current/hot-standby.html) Can we add description for this GUC, please?
Re: `transaction_read_only` GUC undocumented
On Tue, Jan 22, 2019 at 01:26:40PM +0100, Pavlo Golub wrote: > I found that `transaction_read_only`GUC is undocumented. The only > place where it referenced is Hot Standby section > (https://www.postgresql.org/docs/current/hot-standby.html) > > Can we add description for this GUC, please? That makes sense, now the documentation includes only a short of roughly what it is here for and how hot standby uses it. Would you like to write a patch for config.sgml? -- Michael signature.asc Description: PGP signature
Re: Undocumented behaviour of \s in SIMILAR TO expression
On Thu, Dec 13, 2018 at 12:48:10PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/functions-matching.html > Description: > > SELECT ' ' SIMILAR TO '[\s]'; > returns true > > SELECT ' ' SIMILAR TO '[\q]'; > generates an error: [2201B]: ERROR: invalid regular expression: invalid > escape \ sequence > > \s is not mentioned in the SIMILAR TO section > (https://www.postgresql.org/docs/current/functions-matching.html#FUNCTIONS-SIMILARTO-REGEXP). > If it’s officially supported (which would be useful for my current task), it > should be documented. Otherwise the server should generate an error like for > other invalid escapes. Well in: https://www.postgresql.org/docs/11/functions-matching.html I see \s documented, but not \q: Table 9.19. Regular Expression Class-shorthand Escapes Escape Description \d [[:digit:]] \s [[:space:]] \w [[:alnum:]_] (note underscore is included) \D [^[:digit:]] \S [^[:space:]] \W [^[:alnum:]_] (note underscore is included) Frankly, I can't even guess what you expect \q to do. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
Re: `transaction_read_only` GUC undocumented
On Jan 23, 2019 02:25, Michael Paquier wrote:On Tue, Jan 22, 2019 at 01:26:40PM +0100, Pavlo Golub wrote: > I found that `transaction_read_only`GUC is undocumented. The only > place where it referenced is Hot Standby section > (https://www.postgresql.org/docs/current/hot-standby.html) > > Can we add description for this GUC, please? That makes sense, now the documentation includes only a short of roughly what it is here for and how hot standby uses it. Would you like to write a patch for config.sgml? Yeah, why not. Could you please give me a hint where can I find details about it? Sources or commits? -- Michael
Re: Typo in URL
> URL of OASIS group has been changed from http://www.oasis-open.org/ to > https://www.oasis-open.org/, but there's a place where http is still > used. Attached patch fixes that. Done. -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: `transaction_read_only` GUC undocumented
On Wed, Jan 23, 2019 at 06:18:58AM +0200, Pavlo Golub wrote: > Yeah, why not. Could you please give me a hint where can I find > details about it? Sources or commits? (You may want to avoid HTML..) transaction_read_only is listed in src/backend/utils/misc/guc.c, so we could put a description close to default_transaction_read_only in config.sgml, except that transaction_read_only sets the current transaction's read-only status. -- Michael signature.asc Description: PGP signature
Re: `transaction_read_only` GUC undocumented
Michael Paquier writes: > transaction_read_only is listed in src/backend/utils/misc/guc.c, so we > could put a description close to default_transaction_read_only in > config.sgml, except that transaction_read_only sets the current > transaction's read-only status. Do we really want to document that? It's not the standard-approved way of making a transaction read-only. regards, tom lane
Re: `transaction_read_only` GUC undocumented
On Wed, Jan 23, 2019 at 01:07:31AM -0500, Tom Lane wrote: > Michael Paquier writes: >> transaction_read_only is listed in src/backend/utils/misc/guc.c, so we >> could put a description close to default_transaction_read_only in >> config.sgml, except that transaction_read_only sets the current >> transaction's read-only status. > > Do we really want to document that? It's not the standard-approved > way of making a transaction read-only. i'd rather document them clearly rather than letting them around with users guessing what they actually do (remember the recent thread about replication parameter in connection strings). By the way, I can see that transaction_deferrable and transaction_isolation are not around either... -- Michael signature.asc Description: PGP signature
Re: `transaction_read_only` GUC undocumented
Greetings, Michael. You wrote 23.01.2019, 8:14: > On Wed, Jan 23, 2019 at 01:07:31AM -0500, Tom Lane wrote: >> Michael Paquier writes: >>> transaction_read_only is listed in src/backend/utils/misc/guc.c, so we >>> could put a description close to default_transaction_read_only in >>> config.sgml, except that transaction_read_only sets the current >>> transaction's read-only status. >> >> Do we really want to document that? It's not the standard-approved >> way of making a transaction read-only. > i'd rather document them clearly rather than letting them around with > users guessing what they actually do (remember the recent thread about > replication parameter in connection strings). Exactly my case. Client sent support request stating that changing this parameter doesn't work. Of course, he was doing this outside of transaction. And of course he doesn't find manual reference and was guessing about it's behavior. > By the way, I can see > that transaction_deferrable and transaction_isolation are not around > either... > -- > Michael -- Kind regards, Pavlo mailto:pavlo.go...@cybertec.at
