typo

2018-11-25 Thread PG Doc comments form 
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/11/storage-file-layout.html
Description:

I think I found a typo in the manuals in the below sentence. I have
highlighted the correction within double quotes (") and UPPERCASE text. Does
it sound right ?


URL: https://www.postgresql.org/docs/11/storage-file-layout.html

Typo: A table that has columns with potentially large entries will have an
associated TOAST table, which is used for out-of-line storage of field
values that are too large to keep in the table rows proper

Correction: A table that has columns with potentially large entries will
have an associated TOAST table, which is used for out-of-line storage of
field values that are too large to keep in the table rows "PROPERLY".

Re: typo

2018-11-25 Thread Michael Paquier 
On Mon, Nov 26, 2018 at 12:47:51AM +, PG Doc comments form wrote:
> Correction: A table that has columns with potentially large entries will
> have an associated TOAST table, which is used for out-of-line storage of
> field values that are too large to keep in the table rows "PROPERLY".

Thanks, committed.  I have fixed the docs to reflect your suggestion.
--
Michael


signature.asc
Description: PGP signature

Re: typo

2018-11-25 Thread Magnus Hagander 
On Mon, Nov 26, 2018, 07:56 Michael Paquier  On Mon, Nov 26, 2018 at 12:47:51AM +, PG Doc comments form wrote:
> > Correction: A table that has columns with potentially large entries will
> > have an associated TOAST table, which is used for out-of-line storage of
> > field values that are too large to keep in the table rows "PROPERLY".
>
> Thanks, committed.  I have fixed the docs to reflect your suggestion.
> -
>


Are you sure that's right? To me the original wording of that sentence
seems to convey the message properly, and the update done does not?

/Magnus

>

Re: typo

2018-11-25 Thread Vik Fearing 
On 26/11/2018 08:03, Magnus Hagander wrote:
> 
> 
> On Mon, Nov 26, 2018, 07:56 Michael Paquier   wrote:
> 
> On Mon, Nov 26, 2018 at 12:47:51AM +, PG Doc comments form wrote:
> > Correction: A table that has columns with potentially large
> entries will
> > have an associated TOAST table, which is used for out-of-line
> storage of
> > field values that are too large to keep in the table rows "PROPERLY".
> 
> Thanks, committed.  I have fixed the docs to reflect your suggestion.
> -
> 
> 
> 
> Are you sure that's right? To me the original wording of that sentence
> seems to convey the message properly, and the update done does not? 

Yeah, I just found this on the committers list and I disagree with the
change as well.
-- 
Vik Fearing  +33 6 46 75 15 36
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

Re: typo

2018-11-25 Thread Michael Paquier 
On Mon, Nov 26, 2018 at 08:17:06AM +0100, Vik Fearing wrote:
> On 26/11/2018 08:03, Magnus Hagander wrote:
>> Are you sure that's right? To me the original wording of that sentence
>> seems to convey the message properly, and the update done does not?
>
> Yeah, I just found this on the committers list and I disagree with the
> change as well.

[... checking around ...]
Hm.  I have read the sentence and the surroundings a couple of times
before doing anything, and using an adverb looked clearer than the
adjective.  Is an adjective more appropriate than an adverb here because
it insists more on the fact that each row is involved?  Just trying to
grab the difference.
--
Michael


signature.asc
Description: PGP signature