Re: CREATE/ALTER ROLE with NULL password

2018-11-22 Thread David G. Johnston
On Thursday, November 22, 2018, Michael Paquier  wrote:

> On Wed, Nov 21, 2018 at 11:58:25PM -0700, David G. Johnston wrote:
> > Should tweak the paragraph to point out this exception as well.
> >
> >  The ENCRYPTED keyword has no effect, but is accepted for backwards
> > compatibility[, except in the PASSWORD NULL form.]
>
> The docs list the following with the patch as supported grammar:
> [ ENCRYPTED ] PASSWORD 'password' | PASSWORD NULL
> And it seems to me that '|' has priority over '[]', so ENCRYPTED does
> not apply to PASSWORD NULL if phrased this way.
>
>
Yes, the syntax block is perfectly clear but we still explain said grammer
in words and should be precise there as well, IMO.  Not a big deal though.

David J.


Re: CREATE/ALTER ROLE with NULL password

2018-11-22 Thread Michael Paquier
On Thu, Nov 22, 2018 at 09:54:07AM -0700, David G. Johnston wrote:
> On Thursday, November 22, 2018, Michael Paquier  wrote:
>> The docs list the following with the patch as supported grammar:
>> [ ENCRYPTED ] PASSWORD 'password' | PASSWORD NULL
>> And it seems to me that '|' has priority over '[]', so ENCRYPTED does
>> not apply to PASSWORD NULL if phrased this way.
>
> Yes, the syntax block is perfectly clear but we still explain said grammer
> in words and should be precise there as well, IMO.  Not a big deal though.

Okay, thanks.  I have committed the simplest version.
--
Michael


signature.asc
Description: PGP signature