Re: Global dict name is listed inconsistently
On Fri, Aug 24, 2018 at 08:43:21PM +0200, Adam wrote: > Yes, it does, thank you. > > Now it's clear why there are two different names. Patch backpatched through 9.3. Thanks for the report. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
Re: fix word
On Fri, Aug 24, 2018 at 04:47:28PM -0400, Bruce Momjian wrote: > I see your point. We call 'postgres' binary options 'options' and we > call initdb-mode options 'initdb-options' in the -o title, but not in > the paragraph. I assume we want to keep calling the former simply > 'options'. Patch applied through PG 10, where it first appeared. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
Re: Misc typos in documentation
On Thu, Aug 16, 2018 at 11:25:25AM +0300, Liudmila Mantrova wrote: > On 06/20/2018 05:04 PM, Magnus Hagander wrote: > I have split them in two just in case rn-typos.patch conflicts with > any > current work on release-11.sgml, which seems to be going on in more > than one thread. I'll appreciate your feedback if it should have been > done differently. > > I have bumped into a couple of similar typos in 9.6 and 10 - the patch based > on > REL9_6_STABLE is attached. I have made the adjustments to 9.6 and 10 as you suggested. I added quoting to "two" to match other releases: https://git.postgresql.org/pg/commitdiff/993b5a78adff29fc58e7449cab98bb865b77c663 Thanks. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
Re: Enhancing protocol.sgml
Hi Bradley, Thank your for your follow up. Your patch looks good to me. Can you please re-send your message in pgsql-hackers attaching to this thread? https://www.postgresql.org/message-id/flat/20180730.080748.1152436144966943439.t-is...@sraoss.co.jp I have registered the thread in CommitFest: https://commitfest.postgresql.org/19/1738/ Unfortunately CommitFest app does not allow to handle emails other than posted to pgsql-hackers. So I decided to post to pgsql-hackers after posting to pgsql-docs. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp From: "Bradley DeJong" Subject: Re: Enhancing protocol.sgml Date: Fri, 24 Aug 2018 15:43:28 + Message-ID: > On 2018-07-27, Tatsuo Ishii wrote ... >> ... I think this should be mentioned in protocol.sgml as well. ... > > I agree. It is already mentioned as one of the differences between v2 > and v3 but an implementer should not need to read that section if they > are only implementing v3. (I know I've never looked at it before.) > > Using protocol.diff as a base, I changed the phrasing to be more > prescriptive for v3 protocol implementers (don't send a final line, be > prepared to receive a final line), changed passive voice to active > voice and fixed one COPYData -> CopyData capitalization. > > I also called this out in the description of the CopyData message > format because that is where the termination line would be > transmitted.
