Re: Release note trimming: another modest proposal

[Michael Paquier]

On Mon, Aug 06, 2018 at 08:14:23AM +0100, Dean Rasheed wrote:
> On 5 August 2018 at 23:57, Tom Lane  wrote:
>> Anyway, I'd like to propose a compromise position that I don't think
>> has been discussed before: let's drop release notes for branches
>> that were already EOL when a given branch was released.
> 
> WFM. +1

+1.
--
Michael


signature.asc
Description: PGP signature

Re: Multivariate statistics

[Bruce Momjian]

On Tue, Jul 10, 2018 at 03:57:52PM +, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
> 
> Page: 
> https://www.postgresql.org/docs/10/static/multivariate-statistics-examples.html
> Description:
> 
> Hi All, 
> 
> I'm a little confused by the documentation here: 
> https://www.postgresql.org/docs/10/static/multivariate-statistics-examples.html.
> 
> 
> In particular, the selectivity of the second query doesn't seem to match up
> with what is expected in the notes. I feel like I may be missing something?
> 
> 
> (I am referring to the output of this explain command: EXPLAIN (ANALYZE,
> TIMING OFF) SELECT * FROM t WHERE a = 1 AND b = 1;)

Uh, the first query shows an _estimate_ of rows=1, which does not match
the actual rows=100:

Seq Scan on t  (cost=0.00..195.00 rows=1 width=8) (actual rows=100 
loops=1)

The second query has it right:

Seq Scan on t  (cost=0.00..195.00 rows=100 width=8) (actual rows=100 
loops=1)

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+  Ancient Roman grave inscription +

Re: RETURN NULL in the sample of insert trigger on partitioned table

[Bruce Momjian]

On Wed, Jul 11, 2018 at 09:34:59AM +, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
> 
> Page: https://www.postgresql.org/docs/9.6/static/ddl-partitioning.html
> Description:
> 
> Why in provided samples of "insert" triggers on partitioned table at the end
> of the triggers you provide "return NULL" not "return NEW"?
> 
> This causes, among other things, problems with the GET DIAGNOSTICS clause
> var = ROW_COUNT clause.

Uh, you mean measurement_insert_trigger?  Returning NEW would cause the
row to be inserted into the referenced table.

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+  Ancient Roman grave inscription +

Re: Document the limit on the number of parameters

[Bruce Momjian]

On Tue, Jul 17, 2018 at 01:25:08PM +, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
> 
> Page: https://www.postgresql.org/docs/10/static/sql-prepare.html
> Description:
> 
> The backend protocol limits the number of parameters that can be passed for
> a prepared statement to 32767 (2 byte signed integer).
> 
> As that is something that is independent of the client library, I think this
> should be documented in the user facing manual for the Postgres server
> somewhere. 
> 
> I did not find anything in the chapter about PREPARE
> https://www.postgresql.org/docs/current/static/sql-prepare.html or about the
> backend protocol:
> https://www.postgresql.org/docs/current/static/protocol.html nor on the FAQ
> page: https://wiki.postgresql.org/wiki/FAQ

Uh, is this something people will care about?

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+  Ancient Roman grave inscription +

how to modify the navfooter

[Richard Swagerman]

Where is the content of the navfooter established?
I would like to make some modifications to this footer, but I am unable to
figure out where the source that generates it.

I am building the documentation following the instructions from "Building
The Documentation" in Appendix J, currently on 9.6.

I am using the command:
make STYLE=website html

I can see the generated navfooter div section in the output html. I must be
missing something, because I cannot find a file in the git branch that
includes the class named "navfooter" or or any other words like "Navigation
footer", "Next", or "Prev".

I have limited understanding of stylesheets (whether dsl or xsl), but I am
hoping that I can make the small modifications needed for our use.

I am also curious about the docFooter div section that appears in the
publicly published PostgreSQL documentation pages. It does not appear when
I build the docs.
Is there a reason that the copyright does not appear on each page when I do
the doc build?
Is there some way to get it included when I do the doc build?
What file is used that contains the format (style?) info for that generated
html div section?

I would appreciate any assistance from those in the community that
understand something about these footers.
...Rick Swagerman

Re: how to modify the navfooter

[Tom Lane]

Richard Swagerman  writes:
> Where is the content of the navfooter established?
> I would like to make some modifications to this footer, but I am unable to
> figure out where the source that generates it.

It's not in the XML doc sources, for sure.  I believe our website wraps
the HTML generated from the XML in some other stuff, but I don't know any
details.  If nobody pops up here and answers your question in a reasonable
amount of time, try over at pgsql-www.

regards, tom lane

Re: how to modify the navfooter

[Jonathan S. Katz]

> On Aug 7, 2018, at 6:21 PM, Richard Swagerman  
> wrote:
> 
> Where is the content of the navfooter established?
> I would like to make some modifications to this footer, but I am unable to 
> figure out where the source that generates it.
> 
> I am building the documentation following the instructions from "Building The 
> Documentation" in Appendix J, currently on 9.6.
> 
> I am using the command:
> make STYLE=website html
> 
> I can see the generated navfooter div section in the output html. I must be 
> missing something, because I cannot find a file in the git branch that 
> includes the class named "navfooter" or or any other words like "Navigation 
> footer", "Next", or "Prev".
> 
> I have limited understanding of stylesheets (whether dsl or xsl), but I am 
> hoping that I can make the small modifications needed for our use.

I’m not as familiar with the doc builds but it looks like this is available
in the “stylesheet.xsl” file.

> I am also curious about the docFooter div section that appears in the 
> publicly published PostgreSQL documentation pages. It does not appear when I 
> build the docs.
> Is there a reason that the copyright does not appear on each page when I do 
> the doc build?
> Is there some way to get it included when I do the doc build?
> What file is used that contains the format (style?) info for that generated 
> html div section?

That is in the pgweb[1] project, i.e. this file[2]. My understanding
is that probably will not be included in the doc build, as there is
content in it that is specific to the website :-)

[1] https://git.postgresql.org/gitweb/?p=pgweb.git;a=summary 
[2] 
https://git.postgresql.org/gitweb/?p=pgweb.git;a=blob;f=templates/docs/docspage.html;
 



signature.asc
Description: Message signed with OpenPGP

Re: decimal digits precision for real and double precision types

[Bruce Momjian]

On Tue, Jul 17, 2018 at 07:15:41PM +, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
> 
> Page: https://www.postgresql.org/docs/10/static/datatype-numeric.html
> Description:
> 
> In table 8.2 for numeric types, when the documentation states "6 decimal
> digits precision" for the real type, we are talking about 6 digits after the
> decimal point or 6 digits in total (before and after)?

Well the number is stored as a mantissa and exponent, so it is 6
mantissa digits plus an exponent from 1E-37 to 1E+37.

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+  Ancient Roman grave inscription +

Re: Document the limit on the number of parameters

[Stephen Frost]

Greetings,

* Bruce Momjian (br...@momjian.us) wrote:
> On Tue, Jul 17, 2018 at 01:25:08PM +, PG Doc comments form wrote:
> > The following documentation comment has been logged on the website:
> > 
> > Page: https://www.postgresql.org/docs/10/static/sql-prepare.html
> > Description:
> > 
> > The backend protocol limits the number of parameters that can be passed for
> > a prepared statement to 32767 (2 byte signed integer).
> > 
> > As that is something that is independent of the client library, I think this
> > should be documented in the user facing manual for the Postgres server
> > somewhere. 
> > 
> > I did not find anything in the chapter about PREPARE
> > https://www.postgresql.org/docs/current/static/sql-prepare.html or about the
> > backend protocol:
> > https://www.postgresql.org/docs/current/static/protocol.html nor on the FAQ
> > page: https://wiki.postgresql.org/wiki/FAQ
> 
> Uh, is this something people will care about?

Seems like a limitation in the backend protocol should probably be
documented in the backend protocol section of the docs..

Thanks!

Stephen


signature.asc
Description: PGP signature

Re: Document the limit on the number of parameters

[Tom Lane]

Stephen Frost  writes:
> * Bruce Momjian (br...@momjian.us) wrote:
>> On Tue, Jul 17, 2018 at 01:25:08PM +, PG Doc comments form wrote:
>>> The backend protocol limits the number of parameters that can be passed for
>>> a prepared statement to 32767 (2 byte signed integer).

>> Uh, is this something people will care about?

> Seems like a limitation in the backend protocol should probably be
> documented in the backend protocol section of the docs..

It is: the definition of the Bind message format says that the parameter
count is an int16.

The question is whether this deserves to be cross-referenced from
elsewhere.  I agree with Bruce that it seems unlikely to be helpful.

regards, tom lane

Re: Document the limit on the number of parameters

[Stephen Frost]

Greetings Tom,

* Tom Lane (t...@sss.pgh.pa.us) wrote:
> Stephen Frost  writes:
> > * Bruce Momjian (br...@momjian.us) wrote:
> >> On Tue, Jul 17, 2018 at 01:25:08PM +, PG Doc comments form wrote:
> >>> The backend protocol limits the number of parameters that can be passed 
> >>> for
> >>> a prepared statement to 32767 (2 byte signed integer).
> 
> >> Uh, is this something people will care about?
> 
> > Seems like a limitation in the backend protocol should probably be
> > documented in the backend protocol section of the docs..
> 
> It is: the definition of the Bind message format says that the parameter
> count is an int16.
> 
> The question is whether this deserves to be cross-referenced from
> elsewhere.  I agree with Bruce that it seems unlikely to be helpful.

Ah, I read the original poster as saying that it wasn't in the protocol
docs.  If it's there already then I agree, that's sufficient.

Thanks!

Stephen


signature.asc
Description: PGP signature