Re: uncommon syntax in datatype.sgml

2018-07-17 Thread Peter Eisentraut
On 16.07.18 20:42, Liudmila Mantrova wrote:
> I have noticed uncommon English syntax in datatype.sgml, with two full 
> sentences following a colon in the same paragraph.

I don't understand what's wrong with that.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Re: uncommon syntax in datatype.sgml

2018-07-17 Thread Liudmila Mantrova


On 07/17/2018 01:52 PM, Peter Eisentraut wrote:

On 16.07.18 20:42, Liudmila Mantrova wrote:

I have noticed uncommon English syntax in datatype.sgml, with two full
sentences following a colon in the same paragraph.

I don't understand what's wrong with that.


Hi Peter,

I have brought this up because the backpatch to REL9_6_STABLE and below 
has lost the capital letter after the colon (commit 037768cf), so I 
think this phrase is likely to confuse others in a similar way.


The current syntax in master is indeed acceptable, e.g. Chicago Manual 
of Style says:
"The colon may sometimes be used instead of a period to introduce a 
series of related sentences." However, this wording suggests to me that 
it's not the most common usage, so it can confuse non-native speakers 
(like me).


Alternatively, we could fix the backpatch only. The patch based on 
REL9_6_STABLE is attached if you decide to choose this path.


--
Liudmila Mantrova
Technical writer at Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

diff --git a/doc/src/sgml/datatype.sgml b/doc/src/sgml/datatype.sgml
index 5f45db2..729 100644
--- a/doc/src/sgml/datatype.sgml
+++ b/doc/src/sgml/datatype.sgml
@@ -508,7 +508,7 @@
 
 
 
- We use the following terms below:  the
+ We use the following terms below:  The
  precision of a numeric
  is the total count of significant digits in the whole number,
  that is, the number of digits to both sides of the decimal point.


Document the limit on the number of parameters

2018-07-17 Thread PG Doc comments form
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/10/static/sql-prepare.html
Description:

The backend protocol limits the number of parameters that can be passed for
a prepared statement to 32767 (2 byte signed integer).

As that is something that is independent of the client library, I think this
should be documented in the user facing manual for the Postgres server
somewhere. 

I did not find anything in the chapter about PREPARE
https://www.postgresql.org/docs/current/static/sql-prepare.html or about the
backend protocol:
https://www.postgresql.org/docs/current/static/protocol.html nor on the FAQ
page: https://wiki.postgresql.org/wiki/FAQ


sql-set-session-authorization

2018-07-17 Thread PG Doc comments form
The following documentation comment has been logged on the website:

Page: 
https://www.postgresql.org/docs/9.6/static/sql-set-session-authorization.html
Description:

https://www.postgresql.org/account/comments/new/9.6/sql-set-session-authorization.html/

You should also mention necessary rights required to switch as lower
privileged user.


decimal digits precision for real and double precision types

2018-07-17 Thread PG Doc comments form
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/10/static/datatype-numeric.html
Description:

In table 8.2 for numeric types, when the documentation states "6 decimal
digits precision" for the real type, we are talking about 6 digits after the
decimal point or 6 digits in total (before and after)?