[BUGS] patch to fix configure(.in) on openbsd wrt/ krb5/com_err and readline linking
Hi, the following patch does two things on OpenBSD: 1) Add missing libs to the krb5/com_err check that are required. We have this in our ports tree since 7.4.3 but i can't find any report about it, so here it finally is. 2) Prevent the use of -Wl,--as-needed in the readline case but use -Wl,-Bdynamic instead. This became necessary with 8.4, otherwise psql won't start because lazy binding fails. The good news though is that i'm running 8.4beta2 successfully on -current OpenBSD/amd64 with this. Kind regards, Simon Index: configure.in === RCS file: /projects/cvsroot/pgsql/configure.in,v retrieving revision 1.597 diff -u -p -r1.597 configure.in --- configure.in19 May 2009 22:32:41 - 1.597 +++ configure.in10 Jun 2009 09:14:20 - @@ -913,8 +913,13 @@ fi if test "$with_krb5" = yes ; then if test "$PORTNAME" != "win32"; then - AC_SEARCH_LIBS(com_err, [krb5 'krb5 -lcrypto -ldes -lasn1 -lroken' com_err], [], -[AC_MSG_ERROR([could not find function 'com_err' required for Kerberos 5])]) +if test "$PORTNAME" = "openbsd"; then + AC_SEARCH_LIBS(com_err, [krb5 'krb5 -lcrypto -ldes -lasn1 -lroken' 'com_err -lssl -lcrypto'], [], + [AC_MSG_ERROR([could not find function 'com_err' required for Kerberos 5])]) +else + AC_SEARCH_LIBS(com_err, [krb5 'krb5 -lcrypto -ldes -lasn1 -lroken' com_err], [], + [AC_MSG_ERROR([could not find function 'com_err' required for Kerberos 5])]) +fi AC_SEARCH_LIBS(krb5_sendauth, [krb5 'krb5 -lcrypto -ldes -lasn1 -lroken'], [], [AC_MSG_ERROR([could not find function 'krb5_sendauth' required for Kerberos 5])]) else @@ -1788,7 +1793,9 @@ if test "$with_readline" = yes; then else link_test_func=exit fi -if test "$PORTNAME" != "darwin"; then +if test "$PORTNAME" = "openbsd"; then + PGAC_PROG_CC_LDFLAGS_OPT([-Wl,-Bdynamic], $link_test_func) +elif test "$PORTNAME" != "darwin"; then PGAC_PROG_CC_LDFLAGS_OPT([-Wl,--as-needed], $link_test_func) else # On Darwin it's spelled -Wl,-dead_strip_dylibs, but don't try that elsewhere -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
Re: [BUGS] BUG #4848: Encoding is incompatible with template database
On Wed, Jun 10, 2009 at 09:16:40AM +, Anders Gunnarsson wrote: > > The following bug has been logged online: > > Bug reference: 4848 > Logged by: Anders Gunnarsson > Email address: fsog...@passagen.se > PostgreSQL version: 8.4 > Operating system: Windows XP > Description:Encoding is incompatible with template database > Details: > > So, now I am a member! > > Hey, I had problems with the other versions so you gave me a tip to install > Postgres 8.4 which worked. > > BUT when I tried to create a database it says: " > 22023: new encoding (SQL_ASCII) is incompatible with the encoding of the > template database (UTF8)" > > I've tried to install postgres with "install new template..." and without > during installation > > > Do you know this problem and how to solve it? > Not sure if this is a bug (i've seen it too) but you can solve it by using template0: $ createdb -E UTF8 -T template0 foo Regards, Simon -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
[BUGS] Re: patch to fix configure(.in) on openbsd wrt/ krb5/com_err and readline linking
On Wed, Jun 10, 2009 at 02:19:30PM +0100, Greg Stark wrote: > On Wed, Jun 10, 2009 at 10:25 AM, Simon Bertrang wrote: > > > > the following patch does two things on OpenBSD: > > Thank you. > > > > 1) Add missing libs to the krb5/com_err check that are required. > > We have this in our ports tree since 7.4.3 but i can't find any > > report about it, so here it finally is. > > This seems really weird. Firstly, doesn't OpenBSD use ELF? Shouldn't > the library pull in the indirectly needed libraries automatically? But > more to the point, why on *earth* would com_err depend on -lssl and > -lcrypto? com_err is just a standard error handling library. Why > would it fail to link without ssl and crypto libraries?!?! > We do use ELF on most arches. Those few who don't, aren't relevant to the discussion nor a good choice to run a database on. Anyway, the reason why our com_err depends on libssl and libcrypto is because it is linked into libkrb5; libcom_err is just a link to libkrb5: $ ls -il /usr/lib/libkrb5.so.16.0 /usr/lib/libcom_err.so.16.0 1117313 -r--r--r-- 4 root bin 5427316 Apr 18 18:57 /usr/lib/libcom_err.so.16.0 1117313 -r--r--r-- 4 root bin 5427316 Apr 18 18:57 /usr/lib/libkrb5.so.16.0 > If it is necessary, putting in an "if portname = openbsd" is defeating > the whole purpose of using autoconf here. Surely something like > > AC_SEARCH_LIBS(com_err, [krb5 'krb5 -lcrypto -ldes -lasn1 -lroken' > 'com_err' 'com_err -lssl -lcrypto'], [], > > would be better since it would detect this situation regardless of > what OS it's on. > Makes sense to me even though i'm (obviously) no autoconf expert; updated diff below. Regards, Simon Index: configure.in === RCS file: /projects/cvsroot/pgsql/configure.in,v retrieving revision 1.597 diff -u -p -r1.597 configure.in --- configure.in19 May 2009 22:32:41 - 1.597 +++ configure.in10 Jun 2009 15:04:31 - @@ -913,7 +913,7 @@ fi if test "$with_krb5" = yes ; then if test "$PORTNAME" != "win32"; then - AC_SEARCH_LIBS(com_err, [krb5 'krb5 -lcrypto -ldes -lasn1 -lroken' com_err], [], + AC_SEARCH_LIBS(com_err, [krb5 'krb5 -lcrypto -ldes -lasn1 -lroken' com_err 'com_err -lssl -lcrypto'], [], [AC_MSG_ERROR([could not find function 'com_err' required for Kerberos 5])]) AC_SEARCH_LIBS(krb5_sendauth, [krb5 'krb5 -lcrypto -ldes -lasn1 -lroken'], [], [AC_MSG_ERROR([could not find function 'krb5_sendauth' required for Kerberos 5])]) @@ -1788,7 +1788,9 @@ if test "$with_readline" = yes; then else link_test_func=exit fi -if test "$PORTNAME" != "darwin"; then +if test "$PORTNAME" = "openbsd"; then + PGAC_PROG_CC_LDFLAGS_OPT([-Wl,-Bdynamic], $link_test_func) +elif test "$PORTNAME" != "darwin"; then PGAC_PROG_CC_LDFLAGS_OPT([-Wl,--as-needed], $link_test_func) else # On Darwin it's spelled -Wl,-dead_strip_dylibs, but don't try that elsewhere -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
Re: [BUGS] Re: patch to fix configure(.in) on openbsd wrt/ krb5/com_err and readline linking
On Wed, Jun 10, 2009 at 10:05:36AM -0400, Tom Lane wrote: > Greg Stark writes: > > This seems really weird. Firstly, doesn't OpenBSD use ELF? Shouldn't > > the library pull in the indirectly needed libraries automatically? But > > more to the point, why on *earth* would com_err depend on -lssl and > > -lcrypto? com_err is just a standard error handling library. Why > > would it fail to link without ssl and crypto libraries?!?! > > And you'd also need to explain why the spoonbill buildfarm member > is building just fine without this ... it does have kerberos > enabled ... > Indeed a good question. I'm comparing the config and build logs but nothing jumped into my face yet. I should fire up my sparc64 to have the same arch as spoonbill for comparison... configure flags differ too... i'll let you know when i found out more. Regards, Simon -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
Re: [BUGS] Re: patch to fix configure(.in) on openbsd wrt/ krb5/com_err and readline linking
On Wed, Jun 10, 2009 at 05:20:00PM +0200, Simon Bertrang wrote: > On Wed, Jun 10, 2009 at 10:05:36AM -0400, Tom Lane wrote: > > Greg Stark writes: > > > This seems really weird. Firstly, doesn't OpenBSD use ELF? Shouldn't > > > the library pull in the indirectly needed libraries automatically? But > > > more to the point, why on *earth* would com_err depend on -lssl and > > > -lcrypto? com_err is just a standard error handling library. Why > > > would it fail to link without ssl and crypto libraries?!?! > > > > And you'd also need to explain why the spoonbill buildfarm member > > is building just fine without this ... it does have kerberos > > enabled ... > > > > Indeed a good question. I'm comparing the config and build logs but > nothing jumped into my face yet. I should fire up my sparc64 to have the > same arch as spoonbill for comparison... configure flags differ too... > i'll let you know when i found out more. > Found it: spillboon has --with-gssapi in configure flags which pulls the missing pieces in. We don't build with GSSAPI enabled though, hence the patch. Regards, Simon -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
