Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2012-09-15 Thread Amit kapila
On Saturday, September 15, 2012 11:27 AM Fujii Masao wrote:
On Fri, Sep 14, 2012 at 10:01 PM, Amit kapila  wrote:
>
> On Thursday, September 13, 2012 10:57 PM Fujii Masao
> On Thu, Sep 13, 2012 at 1:22 PM, Amit Kapila  wrote:
>> On Wednesday, September 12, 2012 10:15 PM Fujii Masao
>> On Wed, Sep 12, 2012 at 8:54 PM,   wrote:
> The following bug has been logged on the website:

  I would like to implement such feature for walreceiver, but there is one
 confusion that whether to use
  same configuration parameter(replication_timeout) for walrecevier as for
 master or introduce a new
  configuration parameter (receiver_replication_timeout).
>
>>>I like the latter. I believe some users want to set the different
>>>timeout values,
>>>for example, in the case where the master and standby servers are placed in
>>>the same room, but cascaded standby is placed in other continent.
>
>> Thank you for your suggestion. I have implemented as per your suggestion to 
>> have separate timeout parameter for walreceiver.
>> The main changes are:
>> 1. Introduce a new configuration parameter wal_receiver_replication_timeout 
>> for walreceiver.
>> 2. In function WalReceiverMain(), check if there is no communication till 
>> wal_receiver_replication_timeout, exit the walreceiver.
>> This is same as walsender functionality.
>
>> As this is a feature, So I am uploading the attached patch in coming 
>> CommitFest.
>
>> Suggestions/Comments?

> You also need to change walsender so that it periodically sends the heartbeat
> message, like walreceiver does each wal_receiver_status_interval. Otherwise,
> walreceiver will detect the timeout wrongly whenever there is no traffic in 
> the
> master.

Doesn't current keepalive message from walsender will suffice that need?

With Regards,
Amit Kapila.



-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #7540: Hello. Need Help!

2012-09-15 Thread Kevin Grittner
wrote:
 
> PostgreSQL version: 9.0.1
> Operating system: Windows Server 2012
 
> I have a folder "Data". PG versioned postgresql-9.0.1-1.1C (x64).
> Have installed the same version of Postgres. Substitute for the
> "Data" then Postgres server does not start.
 
I don't think anyone can give you much help based on this little
information other than to strongly recommend that you use the latest
version of 9.0, which at the moment is 9.0.9.
 
http://www.postgresql.org/support/versioning/
 
Further, there is no real indication that this is a bug in
PostgreSQL, rather than an installation or configuration problem.
Please start a new thread on pgsql-general or pgsql-novice after you
read this page:
 
http://wiki.postgresql.org/wiki/Guide_to_reporting_problems
 
Try to use a subject line which describes the problem; there are so
many posts to the lists that many people only look at ones where the
subject line indicates an issue with which they are familiar, and
will skip messages without any clue about the issue.
 
-Kevin


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2012-09-15 Thread Fujii Masao
On Sat, Sep 15, 2012 at 4:26 PM, Amit kapila  wrote:
> On Saturday, September 15, 2012 11:27 AM Fujii Masao wrote:
> On Fri, Sep 14, 2012 at 10:01 PM, Amit kapila  wrote:
>>
>> On Thursday, September 13, 2012 10:57 PM Fujii Masao
>> On Thu, Sep 13, 2012 at 1:22 PM, Amit Kapila  wrote:
>>> On Wednesday, September 12, 2012 10:15 PM Fujii Masao
>>> On Wed, Sep 12, 2012 at 8:54 PM,   wrote:
>> The following bug has been logged on the website:
>
>  I would like to implement such feature for walreceiver, but there is one
> confusion that whether to use
>  same configuration parameter(replication_timeout) for walrecevier as for
> master or introduce a new
>  configuration parameter (receiver_replication_timeout).
>>
I like the latter. I believe some users want to set the different
timeout values,
for example, in the case where the master and standby servers are placed in
the same room, but cascaded standby is placed in other continent.
>>
>>> Thank you for your suggestion. I have implemented as per your suggestion to 
>>> have separate timeout parameter for walreceiver.
>>> The main changes are:
>>> 1. Introduce a new configuration parameter wal_receiver_replication_timeout 
>>> for walreceiver.
>>> 2. In function WalReceiverMain(), check if there is no communication till 
>>> wal_receiver_replication_timeout, exit the walreceiver.
>>> This is same as walsender functionality.
>>
>>> As this is a feature, So I am uploading the attached patch in coming 
>>> CommitFest.
>>
>>> Suggestions/Comments?
>
>> You also need to change walsender so that it periodically sends the heartbeat
>> message, like walreceiver does each wal_receiver_status_interval. Otherwise,
>> walreceiver will detect the timeout wrongly whenever there is no traffic in 
>> the
>> master.
>
> Doesn't current keepalive message from walsender will suffice that need?

No. Though the keepalive interval should be smaller than the timeout,
IIRC there is
no way to specify the keepalive interval now.

Regards,

-- 
Fujii Masao


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2012-09-15 Thread Amit kapila
On Sunday, September 16, 2012 12:14 AM Fujii Masao wrote:
On Sat, Sep 15, 2012 at 4:26 PM, Amit kapila  wrote:
> On Saturday, September 15, 2012 11:27 AM Fujii Masao wrote:
> On Fri, Sep 14, 2012 at 10:01 PM, Amit kapila  wrote:
>>
>> On Thursday, September 13, 2012 10:57 PM Fujii Masao
>> On Thu, Sep 13, 2012 at 1:22 PM, Amit Kapila  wrote:
>>> On Wednesday, September 12, 2012 10:15 PM Fujii Masao
>>> On Wed, Sep 12, 2012 at 8:54 PM,   wrote:
>>> The following bug has been logged on the website:
>
>>  I would like to implement such feature for walreceiver, but there is one
>> confusion that whether to use
>>  same configuration parameter(replication_timeout) for walrecevier as for
>> master or introduce a new
>>  configuration parameter (receiver_replication_timeout).
>>
>I like the latter. I believe some users want to set the different
>timeout values,
>for example, in the case where the master and standby servers are placed in
>the same room, but cascaded standby is placed in other continent.
>>
 Thank you for your suggestion. I have implemented as per your suggestion 
 to have separate timeout parameter for walreceiver.
 The main changes are:
 1. Introduce a new configuration parameter 
 wal_receiver_replication_timeout for walreceiver.
 2. In function WalReceiverMain(), check if there is no communication till 
 wal_receiver_replication_timeout, exit the walreceiver.
>>> >This is same as walsender functionality.
>>
 As this is a feature, So I am uploading the attached patch in coming 
 CommitFest.
>>
 Suggestions/Comments?
>
>>> You also need to change walsender so that it periodically sends the 
>>> heartbeat
>>> message, like walreceiver does each wal_receiver_status_interval. Otherwise,
>>> walreceiver will detect the timeout wrongly whenever there is no traffic in 
>>> the
>>> master.
>
>> Doesn't current keepalive message from walsender will suffice that need?

>No. Though the keepalive interval should be smaller than the timeout,
>IIRC there is
>no way to specify the keepalive interval now.

Currently AFAICS in the code on idle system, it should send keepalive after 10s 
which is hardcoded value as sleeptime.
You are right that if its not configurable, and somebody configures 
replication_timeout as value lower than 10s then the logic will fail.

So is it okay if a new config parameter similar to wal_receiver_status_interval 
be added and map it directly to sleeptime in the current code.
There will be no need for any new heartbeat message, existing keepalive will 
sufice that purpose.

With Regards,
Amit Kapila.


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs