Re: [BUGS] pg_restore silently chokes on object comments/descriptions ending in a backslash

2011-07-27 Thread Tom Lane
Julian Mehnle  writes:
> If the comment/description of a database object (table, function, etc.)
> ends in a backslash (which generally works fine otherwise), then
> pg_restore is unable to completely restore a custom-format dump of the
> schema.

Reproduced here against HEAD.  The problem seems to be that
pg_backup_db.c's _sendSQLLine() contains a mini SQL lexer that is not
cognizant of standard_conforming_strings.  Not sure about a simple fix,
and I rather wonder if we shouldn't try to remove that code entirely
instead of "fix" it.

As a temporary workaround, the SQL text file that pg_restore produces
by default seems to be valid, so you could pipe that into psql.

regards, tom lane

-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] pg_restore silently chokes on object comments/descriptions ending in a backslash

2011-07-27 Thread Julian Mehnle
I'm subscribed to the pgsql-bugs list, so no need to CC me. :-)

Tom Lane wrote:

> Reproduced here against HEAD.  The problem seems to be that
> pg_backup_db.c's _sendSQLLine() contains a mini SQL lexer that is not
> cognizant of standard_conforming_strings.

Oh, right, I forgot to mention I have standard_conforming_strings enabled.  
However, I understand that is to become the new default anyway.

> Not sure about a simple fix, 
> and I rather wonder if we shouldn't try to remove that code entirely
> instead of "fix" it.

What would "removing that code entirely" mean?

> As a temporary workaround, the SQL text file that pg_restore produces
> by default seems to be valid, so you could pipe that into psql.

Hmm, right.  So at least my existing dumps aren't useless.  Thanks.

-Julian


signature.asc
Description: This is a digitally signed message part.


Re: [BUGS] pg_restore silently chokes on object comments/descriptions ending in a backslash

2011-07-27 Thread Tom Lane
Julian Mehnle  writes:
> I'm subscribed to the pgsql-bugs list, so no need to CC me. :-)

cc to people in the thread is the established practice on these lists.
It provides a bit more robustness when the lists are busy or slow.
You can set your subscription so the listserv won't send you an extra
copy, I believe, but I don't know the incantation offhand.

> Tom Lane wrote:
>> Not sure about a simple fix, 
>> and I rather wonder if we shouldn't try to remove that code entirely
>> instead of "fix" it.

> What would "removing that code entirely" mean?

I was wondering why it's necessary to parse the entry in the dump file
at all, rather than just spit it out to PQexec as-is.  There's probably
a reason, but maybe we can find another way to solve whatever the
real problem is.

regards, tom lane

-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


[BUGS] BUG #6132: Cannot install rpm files

2011-07-27 Thread Nivas

The following bug has been logged online:

Bug reference:  6132
Logged by:  Nivas
Email address:  niva...@gmail.com
PostgreSQL version: 9.0
Operating system:   Fedora 15
Description:Cannot install rpm files
Details: 

Hi

I cannot install postgresql on Fedora 15, please provide the installation
procedure for Fedora 15.

Thank you

-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] pg_restore silently chokes on object comments/descriptions ending in a backslash

2011-07-27 Thread Julian Mehnle
Tom Lane wrote:

> Julian Mehnle  writes:
> > I'm subscribed to the pgsql-bugs list, so no need to CC me. :-)
>
> cc to people in the thread is the established practice on these lists.
> It provides a bit more robustness when the lists are busy or slow.

Got it.  I'll try to remember that and CC others when posting, and will 
also not take offense when receiving extra CCs.

> > What would "removing that code entirely" mean?
>
> I was wondering why it's necessary to parse the entry in the dump file
> at all, rather than just spit it out to PQexec as-is.  There's probably
> a reason, but maybe we can find another way to solve whatever the
> real problem is.

I see.  Given that I'm only a Pg user, not a Pg developer, I have no 
opinion on this.  Thanks for the explanation, though!

-Julian


signature.asc
Description: This is a digitally signed message part.


Re: [BUGS] pg_restore silently chokes on object comments/descriptions ending in a backslash

2011-07-27 Thread Alvaro Herrera
Excerpts from Julian Mehnle's message of mié jul 27 13:28:21 -0400 2011:
> Tom Lane wrote:
> 
> > Julian Mehnle  writes:
> > > I'm subscribed to the pgsql-bugs list, so no need to CC me. :-)
> >
> > cc to people in the thread is the established practice on these lists.
> > It provides a bit more robustness when the lists are busy or slow.
> 
> Got it.  I'll try to remember that and CC others when posting, and will 
> also not take offense when receiving extra CCs.

If you're on procmail, you can get very easily use a well-known de-dupe
recipe and it all works wonderfully.

:0 Wh: msgid.lock
| formail -D 65536 $HOME/.msgid.cache

I assume similar tools can use equivalent mechanisms.

Note that CCing others is customary but obviously not mandatory.

-- 
Álvaro Herrera 
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #6132: Cannot install rpm files

2011-07-27 Thread Scott Mead
On Wed, Jul 27, 2011 at 11:19 AM, Nivas  wrote:

>
> The following bug has been logged online:
>
> Bug reference:  6132
> Logged by:  Nivas
> Email address:  niva...@gmail.com
> PostgreSQL version: 9.0
> Operating system:   Fedora 15
> Description:Cannot install rpm files
> Details:
>
> Hi
>
> I cannot install postgresql on Fedora 15, please provide the installation
> procedure for Fedora 15.
>
> A) Where did you download them from (exact URL) ?
B) What is the error you are getting?
C) http://wiki.postgresql.org/wiki/Guide_to_reporting_problems

--Scott



> Thank you
>
> --
> Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-bugs
>


Re: [BUGS] pg_restore silently chokes on object comments/descriptions ending in a backslash

2011-07-27 Thread Julian Mehnle
Alvaro Herrera wrote:

> Note that CCing others is customary but obviously not mandatory.

For the record, CCing posters who haven't explicitly requested it is 
frowned upon on the Debian mailing lists , but apparently those have a 
lower latency than the Pg ones. :-)

I'll shut up now since this is drifting off topic.

-Julian


signature.asc
Description: This is a digitally signed message part.


Re: [BUGS] BUG #6132: Cannot install rpm files

2011-07-27 Thread John R Pierce

On 07/27/11 10:56 AM, Scott Mead wrote:


I cannot install postgresql on Fedora 15, please provide the
installation
procedure for Fedora 15.

A) Where did you download them from (exact URL) ?
B) What is the error you are getting?
C) http://wiki.postgresql.org/wiki/Guide_to_reporting_problems


D) this wasn't a 'bug' by any stretch of the imagination.



--
john r pierceN 37, W 122
santa cruz ca mid-left coast


--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] Ambiguos OPERATOR items in pg_restore manifest file

2011-07-27 Thread Robert Haas
On Wed, Jul 20, 2011 at 8:24 AM, Renzo Kottmann  wrote:
> On 07/18/2011 05:25 PM, Robert Haas wrote:
>> On Tue, Jul 12, 2011 at 9:18 AM, Sandro Santilli  wrote:
>>> Trying to exclude items from dumps of postgis-enabled databases
>>> we use pg_restore -l output and strip what we think belong to PostGIS.
>>>
>>> In doing so, Renzo found that for OPERATOR there are not enough
>>> informations to unambiguosly find it being part of PostGIS (see
>>> included mail snippet).
>>>
>>> Do you think this could be improved on the pg_restore side ?
>> In 9.1, we've added the concept of EXTENSIONs.  I'm not sure whether
>> PostGIS is planning to take advantage of this mechanism, but it's
>> designed to solve exactly this problem.
>>
> The extensions concept will be a big  step forward, no doubt.
>
> I just do not think that it solves the aforementioned problem. AFAIK
> the extension system will be available for 9.1 only. Then it would not
> be available for all kinds of dump/restore scenarios <9.1 (in my case
> from 8.4 to 9.0).

Yeah, that's a problem.  The mechanism does include some magic that's
supposed to help deal with this.  The idea is -- first, you upgrade to
9.1 -- next, you say something like CREATE EXTENSION ename FROM
unpackaged -- finally, you upgrade the extension using ALTER EXTENSION
UPDATE.  However, I'm not sure whether PostGIS is planning to support
this mechanism, or whether it meets their needs.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #5953: pgadmin sql-query text pad doesn't work

2011-07-27 Thread Robert Haas
On Mon, Jul 25, 2011 at 6:43 AM, p.de.waal  wrote:
> Is there already a fix for this, I just installed pgadmin version 1.12.3 on
> windows 7. And I also have a problem with the SQL window. I can open it, but
> can't type any query.
>
> On my XP system it worked fine.

Try your question here:

http://archives.postgresql.org/pgadmin-support/

This list is only for bugs in PostgreSQL itself, and not all of the
pgAdmin developers read it regularly.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


[BUGS] BUG #6133: -lpq frees unallocated memory on exit

2011-07-27 Thread Kurt Mielke

The following bug has been logged online:

Bug reference:  6133
Logged by:  Kurt Mielke
Email address:  k...@it-pilots.com
PostgreSQL version: 8.4.8 + 9.0.4
Operating system:   Centos X86_64 5.5 & 6.0
Description:-lpq frees unallocated memory on exit
Details: 

x.c: is a very simple c-program:

main() { }

When compiled with

gcc -o x -lpq x.c

valgrind ./x

says "invalid free ... Address 0x4029508 is not stack'd, malloc'd or
(recently) free'd"

gcc -o x x.c

does not have this problem

I have tried linking with centos distribution developer versions and tried
making it from 8.4.2 8.4.8 9.0.4 tar balls, using configure with no options
The problem is the same - I found a posting from 2002 which I think is the
same problem, but I found no follow-ups.

I looked at make output to identify other libraries, which might be
responsible - but:

gcc -o x -lcrypt -ldl -lm -lpgport -lpgtypes -lpthread -lreadline -lz x.c

is OK, while linking with either -lpq or -lecpg will give you the valgrind
error.

On the two machines I tried it on I have:
gcc.x86_64 4.4.4-13.el6 / glibc.i686 2.12-1.7.el6_0.5
gcc.x86_64 4.1.2-50.el5 / glibc.i686 2.5-58.el5_6.4

And "Yes!" - the problem is also present if I do some real pg-lib, like
running testlibpq3.c - again there is one free too many.

-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #6133: -lpq frees unallocated memory on exit

2011-07-27 Thread Tom Lane
"Kurt Mielke"  writes:
> PostgreSQL version: 8.4.8 + 9.0.4
> Operating system:   Centos X86_64 5.5 & 6.0

> x.c: is a very simple c-program:

> main() { }

> When compiled with

> gcc -o x -lpq x.c

> valgrind ./x

> says "invalid free ... Address 0x4029508 is not stack'd, malloc'd or
> (recently) free'd"

Can't reproduce this on my own Red Hat machines ...

regards, tom lane

-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs