Re: [BUGS] BUG #5620: PostgreSQL won't accept the word "user" as a valid column name
On 08/14/2010 02:14 AM, Samuel Marinov wrote:
The following bug has been logged online:
Bug reference: 5620
Logged by: Samuel Marinov
Email address: samuel.mari...@gmail.com
PostgreSQL version: 9.0b4
Operating system: Ubuntu Linux 10.04 64-bit
Description:PostgreSQL won't accept the word "user" as a valid
column name
Details:
I haven't tried this bug with any other platform or version. I installed
PostgreSQL from source, using the configure command: "./configure
--prefix=/usr/local/pgsql". I also started the server after the install with
the following command: "/usr/local/pgsql/bin/pg_ctl start -D
/usr/local/pgsql/data" while logged in as a non-root user. Also, I didn't
try creating a test database and user as the INSTALL file says, but creating
databases and users works fine anyway. Other than that, I used all the
defaults found in the INSTALL file for installing and starting PostgreSQL.
After that, I set a password for the postgres user (not the system postgres
user, but the database user) and created another user called ftp. I also
gave the ftp user full ownership to a database named ftp. Then, I logged in
as the ftp user, and tried to run the following query: "create table ftp
(user varchar, password varchar);". I got the following error message:
ERROR: syntax error at or near "user" at character 19
STATEMENT: create table ftp (user varchar, password varchar);
ERROR: syntax error at or near "user"
LINE 1: create table ftp (user varchar, password varchar);
I tried using the name "username" for the first column, and it worked
perfectly.
not sure why you consider this a bug - but "user" is a reserved word in
PostgreSQL and the SQL-Standard (see
http://www.postgresql.org/docs/9.0/static/sql-keywords-appendix.html) so
you would have to quote the keyword like:
create table ftp ("user" varchar, password varchar);
in your code - but I would advise against using reserved words at all
because you will end up having to quote them all over the place in each
and every query.
Stefan
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
Re: [BUGS] BUG #5620: PostgreSQL won't accept the word "user" as a valid column name
Stefan Kaltenbrunner writes:
> On 08/14/2010 02:14 AM, Samuel Marinov wrote:
>> ERROR: syntax error at or near "user"
>> LINE 1: create table ftp (user varchar, password varchar);
> not sure why you consider this a bug - but "user" is a reserved word in
> PostgreSQL and the SQL-Standard (see
> http://www.postgresql.org/docs/9.0/static/sql-keywords-appendix.html) so
> you would have to quote the keyword like:
> create table ftp ("user" varchar, password varchar);
> in your code - but I would advise against using reserved words at all
> because you will end up having to quote them all over the place in each
> and every query.
Yeah. The reason it's reserved is that per spec, USER is equivalent to
CURRENT_USER, ie it's a built-in function that returns the current login
name. So anytime you forgot and wrote
select user from ...
instead of
select "user" from ...
it would still work and you'd get mysteriously wrong output. You
don't want to go there.
regards, tom lane
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
Re: [BUGS] BUG #5608: array_agg() consumes too much memory
Hitoshi Harada writes: > 2010/8/14 Itagaki Takahiro : >> 2010/8/10 Tom Lane : >>> Eventually it might be nice to have some sort of way to specify the >>> estimate to use for any aggregate function --- but for a near-term >>> fix maybe we should just hard-wire a special case for array_agg in >>> count_agg_clauses_walker(). > So, is it better to generalize as it adds ALLOCSET_DEFAULT_INITSIZE if > the transtype is internal, rather than specifying individual function > OID as the patch stands? Seems like a good idea ... it's ugly, but it seems much less likely to need maintenance. regards, tom lane -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
Re: [BUGS] BUG #5608: array_agg() consumes too much memory
Hitoshi Harada writes: > 2010/8/14 Itagaki Takahiro : >> The attached patch is the near-term fix; it adds ALLOCSET_DEFAULT_INITSIZE >> bytes to memory assumption. >> >> We might need the same adjustment for string_agg(), that consumes >> 1024 bytes for the transit condition. array_agg() and string_agg() >> are only aggregates that have "internal" for aggtranstype. > So, is it better to generalize as it adds ALLOCSET_DEFAULT_INITSIZE if > the transtype is internal, rather than specifying individual function > OID as the patch stands? I've applied a patch following Hitoshi-san's idea. BTW, a note about the upthread patch: we don't do manual #define's for OIDs in pg_proc.h. Use fmgroids.h for that. regards, tom lane -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
