[BUGS] BUG #5455: two PGTYPES_NUM_OVERFLOWs

2010-05-08 Thread KOIZUMI Satoru

The following bug has been logged online:

Bug reference:  5455
Logged by:  KOIZUMI Satoru
Email address:  koizumi...@minos.ocn.ne.jp
PostgreSQL version: 9.0beta1
Operating system:   MacOS X
Description:two PGTYPES_NUM_OVERFLOWs
Details: 

There are two PGTYPES_NUM_OVERFLOWs at 33.8.6. errno values of pgtypeslib.
The latter PGTYPES_NUM_OVERFLOW would be PGTYPES_NUM_UNDERFLOW according to
its description.

-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


[BUGS] reference to undefined macro _MSC_VER

2010-05-08 Thread Bryan Henderson
 (a file that gets included in a user's server extension
compilation) contains the line

  # if _MSC_VER > 1400

In the compiler is not Microsoft C at all, _MSC_VER is undefined, and in some
environments, the reference to it is an error (e.g. Gcc with -Wundef -Werror).

So that this header file can work in all environments, it should have an
#ifdef.

I see this in Postgres 8.4.3.

-- 
Bryan Henderson   San Jose, California

-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


[BUGS] bool: symbol name collision

2010-05-08 Thread Bryan Henderson
The interface header files for Postgres server extensions define "bool",
but that name is commonly used by other parts of user code, including
by standards (C99, C++).  That causes, at best, compile failures.

If Postgres has to define a boolean type in public header files, it should
use a name that won't collide, like postgres_bool.  Alternatively, it might
just #include , if it can depend upon a C99 compiler.

Incidentally, this collision is particularly heinous because structures that
are part of the server extension interface have "bool" members, and if the
server and user program are compiled with bools of different sizes,
disaster occurs.  Postgres's bool is one byte; often, bool is 4 bytes.

I saw this in Postgres 8.4.3.

-- 
Bryan Henderson   San Jose, California

-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs