RM5049 Patch

[Yogesh Mahajan]

Hi,

Please find attached patch for  api tests for cast node.This covers -
Added new file (cast_test_cases.json) storing inventory, test, expected
data.
Also covers test cases for all cast node related api,
This increase code coverage for cast from 33% to 68%.

Command to run tests -
--pkg browser.server_groups.servers.databases.casts.tests

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


RM5049.patch
Description: Binary data

Re: RM5049 Patch

[Yogesh Mahajan]

Hi,

Please find updated patch -


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Wed, Jan 15, 2020 at 1:49 PM Neel Patel 
wrote:

> Patch only covers removal of the code and change in "coveragerc.in". I
> guess you missed to add the new files in the patch. Can you please verify ?
>
> Thanks,
> Neel Patel
>
> On Wed, Jan 15, 2020 at 1:16 PM Yogesh Mahajan <
> yogesh.maha...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find attached patch for  api tests for cast node.This covers -
>> Added new file (cast_test_cases.json) storing inventory, test, expected
>> data.
>> Also covers test cases for all cast node related api,
>> This increase code coverage for cast from 33% to 68%.
>>
>> Command to run tests -
>> --pkg browser.server_groups.servers.databases.casts.tests
>>
>> Thanks,
>> Yogesh Mahajan
>> QA - Team
>> EnterpriseDB Corporation
>>
>> Phone: +91-9741705709
>>
>


RM5049_v2.patch
Description: Binary data

Re: [pgAdmin 4 - Housekeeping #5255] Implement Selenium Grid using multi-threading & solenoid using current test framework

[Yogesh Mahajan]

Hi,

Please find the updates patch with above review comments.
Patch adds below functionality to existing framework -
1.Ability to run features in parallel using solenoid(selenium + docker).
 a.Selenoid setup steps are included in /regression/README
 b.'python runtests.py  --pkg feature_tests --parallel' will trigger
parallel feature tests.
2.Removes dependency for pyperclip python module.
3.New script in ../tools/update_selenoid_browsers.py updates browser
images at local selneoid server setup.


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Tue, May 5, 2020 at 3:58 PM Akshay Joshi 
wrote:

> Hi Yogesh
>
> Following are the review comments:
>
>- *pyjq* package is not required as we used it only in one place. A
>result is a normal dictionary that can be easily looped through.
>- Remove "*if (SUPPORT_SSH_TUNNEL is True and ...*" logic from
>config.py, we have already removed that.
>- Remove yarn.lock file.
>- Remove *pyperclip *from the regression/requirements.txt as we are
>not using it.
>- Please mentioned the value of *pgAdmin_default_server *should not be
>'*127.0.0.1*' in the README file even though everything runs on the
>same machine.
>- Please mentioned that if we set the value of the browser version is
>*null* then selenoid will take the latest available browser version.
>- Got the below error if selenoid_url is not provided:
>   - list index out of range
>   Unable to find Selenoid Status
>
> *test_config.json.in <http://test_config.json.in>*:
>
>- "selenoid_info" should be renamed to "selenoid_config". Proper
>alignment is required.
>- "cross_Browsers" should be renamed to "cross_browsers" or
>"run_on_browsers" or "run_tests_on_browsers". Provide entries for supported
>browsers with version set to null so that it will run on the latest browser
>version.
>- "selenoid_url": "Selenoid Url" should be changed to "selenoid_url":
>"http://:/wd/hub".
>
> If you change the names in test_config.json.in then please update the
> same in README as well.
>
>
> On Mon, May 4, 2020 at 4:27 PM Yogesh Mahajan <
> yogesh.maha...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>>
>> Please find the updated patch.
>>
>> Thanks,
>> Yogesh Mahajan
>> QA - Team
>> EnterpriseDB Corporation
>>
>> Phone: +91-9741705709
>>
>>
>> On Mon, May 4, 2020 at 2:51 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Yogesh
>>>
>>> The patch is not applied to the master branch. Can you please rebase and
>>> send the patch again.
>>>
>>> On Fri, May 1, 2020 at 12:28 PM Yogesh Mahajan <
>>> yogesh.maha...@enterprisedb.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find updated patch modified according to review comments -
>>>> Patch implements below things -
>>>> 1.Enable the current framework to provide option to execute Feature
>>>> tests in parallel  on selenium grid set up.
>>>>- Addition of new switch to start parallel features tests.
>>>>- New parameters with respect to selenoid in test_config.json.in
>>>>- Addition of new script to check solenoid updates.
>>>>
>>>>
>>>>
>>>> Thanks,
>>>> Yogesh Mahajan
>>>> QA - Team
>>>> EnterpriseDB Corporation
>>>>
>>>> Phone: +91-9741705709
>>>>
>>>>
>>>> On Tue, Apr 21, 2020 at 1:18 PM Shubham Agarwal <
>>>> shubham.agar...@enterprisedb.com> wrote:
>>>>
>>>>> Hi Yogesh,
>>>>> Below are the review comments-
>>>>>
>>>>> 1. runtests.py
>>>>> a. The exception traceback logic at line number 653 in
>>>>> runtests.py is not correct since it is particular to the thread
>>>>> but there is much more code in that block which can throw some
>>>>> exception.
>>>>> b. line number 447 -> The drop_database function will only try to
>>>>> drop the database with the name which is newly created
>>>>> at 431 line number, its probability is 1% instead of this you can
>>>>> write a logic so that it will drop all the database which starts with name
>>>>> ‘acceptance_test_db'.
>>>>>   c. line 584 - Why we are including resql test case exec

[pgAdmin] : Patch fixing Feature Test failures.

[Yogesh Mahajan]

Hi,

Please find the attached patch which fixes feature tests failure on
chrome caused due to selenium grid implementation changes.


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


fix_selenium_grid_implementation_v1.0.patch
Description: Binary data

[pgAdmin][RM5333] : [Code Coverage] Improve API test cases for Indexes

[Yogesh Mahajan]

Hi,

Please find the attached patch to improve index node code coverage.

Command to run the test cases -
- python runtests.py --pkg
browser.server_groups.servers.databases.schemas.tables.indexes.tests

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


RM5333.patch
Description: Binary data

Re: [pgAdmin][RM5333] : [Code Coverage] Improve API test cases for Indexes

[Yogesh Mahajan]

Hi Akshay,

Please find modified patch fixing above issue.

Command to run the test cases -
- python runtests.py --pkg
browser.server_groups.servers.databases.schemas.tables.indexes.tests

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Mon, May 18, 2020 at 10:53 AM Akshay Joshi 
wrote:

> Hi Yogesh
>
> "Create index: With valid data while the server is down-2" test cases are
> failing for all the database servers (PG/EPAS).
> Please fix and resend the patch.
>
> On Fri, May 15, 2020 at 1:04 PM Yogesh Mahajan <
> yogesh.maha...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to improve index node code coverage.
>>
>> Command to run the test cases -
>> - python runtests.py --pkg
>> browser.server_groups.servers.databases.schemas.tables.indexes.tests
>>
>> Thanks,
>> Yogesh Mahajan
>> QA - Team
>> EnterpriseDB Corporation
>>
>> Phone: +91-9741705709
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


RM5333_v2.patch
Description: Binary data

[pgAdmin]: Patch fixing Feature Tests failures on Selenium Grid

[Yogesh Mahajan]

Hi,

Please find attached patch fixing Feature Tests failures on Selenium
Grid.(Concurrent Execution).
Failures root cause -
- Some selenium actions fail while working in parallel with Query Editor
Tools.
> Added code to stop action failures & retry if still fails.
- Dependents tab does not populate some time.
> Retrying complete check.
- Inputting in the Query-Editor panel throws stale element exception
> Add retry code.


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


fix_selenium_grid_failures_v1.0.patch
Description: Binary data

[pgAdmin4][Patch] - RM 5416 Cannot close/remove a tab/panel without saving

[Yogesh Mahajan]

Hi Hackers,

Please find attached patch fixing 'Cannot close/remove a tab/panel without
saving' issue.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


RM5416_v1.patch
Description: Binary data

[pgAdmin4][Patch] - RM 5539 - /usr/share/pgadmin4/web/pgadmin/utils/preferences.py contains 7 references to current_app.logger.exeception(e) and 1 to current_app.logger.exception(e)

[Yogesh Mahajan]

Hi Hackers,

Please find attached patch fixing exception errors.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


RM5539_v1.patch
Description: Binary data

[pgAdmin4][Patch] - RM #5465 - [Microsoft Edge] Mensagem de Erro Indevida

[Yogesh Mahajan]

Hi Hackers,

Please find the attached patch which shows the actual Edge browser version
when pgAdmin is launched Edge Version <43.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


RM5465_v1.patch
Description: Binary data

Re: [pgAdmin4][Patch] - RM #5465 - [Microsoft Edge] Mensagem de Erro Indevida

[Yogesh Mahajan]

Hi Hackers,

Comparing with 18 also will create the same issue as there are multiple
Edge browser versions mapped to single EdgeHTML engine versions.
Please find modified patch which will show exact detected browser version
till Edge Version 40. For  Edge version < 40, error message will show
 version '<44'.



Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Fri, May 29, 2020 at 11:19 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Yogesh,
>
> Your patch will fail if the edge version is older than 39. I would suggest
> comparing version > 18 directly.
>
> On Fri, May 29, 2020 at 10:57 AM Yogesh Mahajan <
> yogesh.maha...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch which shows the actual Edge browser
>> version when pgAdmin is launched Edge Version <43.
>>
>> Thanks,
>> Yogesh Mahajan
>> QA - Team
>> EnterpriseDB Corporation
>>
>> Phone: +91-9741705709
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


RM5465_v2.patch
Description: Binary data

[pgAdmin4][Patch] - RM 5507 - rel.relhasoids AS has_oids error

[Yogesh Mahajan]

Hi Hackers,

Please find the attached patch which fixes the server old version cache
issue on pg upgrade.

Steps to Reproduce Issue -
1.Install & Start pg11.
2.Create table in database from pgAdmin.
3.Upgrade pg11 to pg12 using pg_upgrade.(Refer link
<https://info.crunchydata.com/blog/how-to-perform-a-major-version-upgrade-using-pg_upgrade-in-postgresql>
)
4.Try accessing the same server & table. Due to the cached version above
error will be shown if you run select command for existing table.
5.Patch will refresh database version after re-connection on pg-upgrade.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


RM5507_v1.patch
Description: Binary data

[pgAdmin][Patch] RM4226 - Table Properties - select all checkbox only selects the first 50 tables

[Yogesh Mahajan]

Hi Hackers,

Please find attached patch fixing behaviour on checking  select-all
checkbox from properties tab for more than 50 entities.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


RM4226_v1.patch
Description: Binary data

[pgAdmin4][Patch] - Issue fixes reported by SonarQube

[Yogesh Mahajan]

Hi,

Please find patching fixing issues related to shadowing variables -

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


SonarQubeFix1_v1.patch
Description: Binary data

Re: [pgAdmin][Patch] RM4226 - Table Properties - select all checkbox only selects the first 50 tables

[Yogesh Mahajan]

Hi Hackers,

Please find an updated patch.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Mon, Jun 15, 2020 at 3:52 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi Yogesh,
>
> this.data.splice is not required as you are adding the entire dataset into 
> collection.
>
> Thanks,
>
> Khushboo
>
>
> On Mon, Jun 15, 2020 at 3:01 PM Yogesh Mahajan <
> yogesh.maha...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find attached patch fixing behaviour on checking  select-all
>> checkbox from properties tab for more than 50 entities.
>>
>> Thanks,
>> Yogesh Mahajan
>> QA - Team
>> EnterpriseDB Corporation
>>
>> Phone: +91-9741705709
>>
>


RM4226_v2.patch
Description: Binary data

[pgAdmin4][Patch] - Issue fixes reported by SonarQube -2

[Yogesh Mahajan]

Hi,

Please find patching fixing issues related to shadowing variables of some
more js file.


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


SonarQubeFix2_v1.patch
Description: Binary data

[pgAdmin4][Patch] - Issue fixes reported by SonarQube -2

[Yogesh Mahajan]

Hi,

Please find patching and fixing issues related to shadowing variables of
some more js files.


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


SonarQubeFix3_v1.patch
Description: Binary data

[pgAdmin4][Patch] - Issue fixes reported by SonarQube - 4 (Rule Comma operator should not be used)

[Yogesh Mahajan]

Hi,

Please find patching and fixing issues related to "Rule  *Comma operator
should not be used*"
across the  project.


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


SonarQubeFix4_v1.patch
Description: Binary data

[pgAdmin] : Patch fixing Feature Test failures.

[Yogesh Mahajan]

Hi Hackers,

Please find the patch which fixes parallel test execution failures.
Also, added capability to pass browser-name via command line for parallel
execution.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


fix_selenium_grid_failures_v2.0.patch
Description: Binary data

[pgAdmin][Patch] RM 3591 - Query tool is not displaying the proper error

[Yogesh Mahajan]

Hi Hackers,

Please find the patch fixing error shown in the query tool while in
progress query execution on session termination from dashboard.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


RM3591_v1.patch
Description: Binary data

[pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used)

[Yogesh Mahajan]

Hi Hackers,

Please find patch fixing sonarqube issues related to below rules -

1.Boolean checks should not be inverted,
2.Comma operator should not be used,
3.Arguments to built-in functions should match documented types,
4.Redundant pairs of parentheses should be removed,

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


SonarQubeFix5_v1.patch
Description: Binary data

[pgAdmin] : Patch fixing Feature Test failures.

[Yogesh Mahajan]

Hi Hackers,

Please find the patch which fixes parallel test execution failures. Handled
slowness when multiple sessions are logged in concurrently.


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


fix_selenium_grid_failures_v3.0.patch
Description: Binary data

Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used)

[Yogesh Mahajan]

Hi,

Please find an updated patch.


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Wed, Jun 24, 2020 at 12:31 PM Akshay Joshi 
wrote:

> Hi Yogesh
>
> After applying your patch a new sonarqube issue has been found "Change
> this argument to the documented type: Number." in sqleditor_utils.js
> Please fix that and resend the patch.
>
> On Mon, Jun 22, 2020 at 4:36 PM Yogesh Mahajan <
> yogesh.maha...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find patch fixing sonarqube issues related to below rules -
>>
>> 1.Boolean checks should not be inverted,
>> 2.Comma operator should not be used,
>> 3.Arguments to built-in functions should match documented types,
>> 4.Redundant pairs of parentheses should be removed,
>>
>> Thanks,
>> Yogesh Mahajan
>> QA - Team
>> EnterpriseDB Corporation
>>
>> Phone: +91-9741705709
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


SonarQubeFix5_v2.patch
Description: Binary data

[pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executed single line should be denoted by indentation, A "while" loop should be used instead of a "for" loop, Variables should be declared exp

[Yogesh Mahajan]

Hi,

Please find patch fixing the issues related to below rules -
1.A conditionally executed single line should be denoted by indentation,
2.A "while" loop should be used instead of a "for" loop, \
3.Variables should be declared explicitly)

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


SonarQubeFix6_v1.patch
Description: Binary data

Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used)

[Yogesh Mahajan]

Hi,

Please find an updated patch.


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Thu, Jun 25, 2020 at 12:26 PM Akshay Joshi 
wrote:

> Hi Yogesh
>
> Jasmin tests are failing, please fix and resend the patch.
>
> On Thu, Jun 25, 2020 at 11:52 AM Yogesh Mahajan <
> yogesh.maha...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find an updated patch.
>>
>>
>> Thanks,
>> Yogesh Mahajan
>> QA - Team
>> EnterpriseDB Corporation
>>
>> Phone: +91-9741705709
>>
>>
>> On Wed, Jun 24, 2020 at 12:31 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Yogesh
>>>
>>> After applying your patch a new sonarqube issue has been found "Change
>>> this argument to the documented type: Number." in sqleditor_utils.js
>>> Please fix that and resend the patch.
>>>
>>> On Mon, Jun 22, 2020 at 4:36 PM Yogesh Mahajan <
>>> yogesh.maha...@enterprisedb.com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find patch fixing sonarqube issues related to below rules -
>>>>
>>>> 1.Boolean checks should not be inverted,
>>>> 2.Comma operator should not be used,
>>>> 3.Arguments to built-in functions should match documented types,
>>>> 4.Redundant pairs of parentheses should be removed,
>>>>
>>>> Thanks,
>>>> Yogesh Mahajan
>>>> QA - Team
>>>> EnterpriseDB Corporation
>>>>
>>>> Phone: +91-9741705709
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


SonarQubeFix5_v3.patch
Description: Binary data

Re: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executed single line should be denoted by indentation, A "while" loop should be used instead of a "for" loop)

[Yogesh Mahajan]

Hi,

Please find patch fixing the issues related to below rules -
1.A conditionally executed single line should be denoted by indentation,
2.A "while" loop should be used instead of a "for" loop.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Thu, Jun 25, 2020 at 12:28 PM Akshay Joshi 
wrote:

> Hi Yogesh
>
> Please fix the linter error and send the patch again.
>
> On Thu, Jun 25, 2020 at 12:26 PM Yogesh Mahajan <
> yogesh.maha...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find patch fixing the issues related to below rules -
>> 1.A conditionally executed single line should be denoted by indentation,
>> 2.A "while" loop should be used instead of a "for" loop, \
>> 3.Variables should be declared explicitly)
>>
>> Thanks,
>> Yogesh Mahajan
>> QA - Team
>> EnterpriseDB Corporation
>>
>> Phone: +91-9741705709
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


SonarQubeFix6_v2.patch
Description: Binary data

[pgAdmin4][Patch] - SonarQube Issues07 (Variables should not be shadowed)

[Yogesh Mahajan]

Hi,

Please find a patch which fixes issues related to rule- 'Variables should
not be shadowed'.


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


SonarQubeFix7_v1.patch
Description: Binary data

[pgAdmin][Patch] RM 5530 - Referenced Table is not displayed on foriegn key constraints property

[Yogesh Mahajan]

Hi,

Please find a patch fixing RM 5530.
Refer Table Name is shown in Foreign Key creation dialogue & properties tab.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


RM5530_v1.patch
Description: Binary data

[pgAdmin4][Patch] - SonarQube Issues - 8 (Variables should not be shadowed)

[Yogesh Mahajan]

Hi,

Please find a patch which fixes issues related to rule- 'Variables should
not be shadowed'.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.js
index 6d8cf7398..3d2b34614 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.js
@@ -347,11 +347,11 @@ define('pgadmin.node.fts_configuration', [
   idx = -1;
 
 // Find if token exists in grid
-self.collection.each(function(m) {
+self.collection.each(function(local_model) {
   _.each(checkVars, function(v) {
-var val = m.get(v);
+var val = local_model.get(v);
 if(val == token) {
-  idx = coll.indexOf(m);
+  idx = coll.indexOf(local_model);
 }
   });
 });
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/foreign_key/static/js/foreign_key.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/foreign_key/static/js/foreign_key.js
index 6ccb59526..0af5ca0b0 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/foreign_key/static/js/foreign_key.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/foreign_key/static/js/foreign_key.js
@@ -203,29 +203,29 @@ define('pgadmin.node.foreign_key', [
   formatter: Backform.ControlFormatter,
   template: headerSelectControlTemplate,
   render: function() {
-var self = this,
-  url = self.field.get('url') || self.defaults.url,
-  m = self.model,
+var self_referenced = this,
+  url = self_referenced.field.get('url') || self_referenced.defaults.url,
+  m = self_referenced.model,
   tid = m.get('references');
 // Store name for selected table
 var a = $('select[name="references"]').find(':selected').text();
 this.model.set('references_table_name', a,{silent: true});
 
 // Clear any existing value before setting new options.
-m.set(self.field.get('name'), null, {silent: true});
+m.set(self_referenced.field.get('name'), null, {silent: true});
 
 if (url && !_.isUndefined(tid) && !_.isNull(tid) && tid != '') {
-  var node = this.field.get('schema_node'),
+  var schema_node = this.field.get('schema_node'),
 node_info = this.field.get('node_info'),
-full_url = node.generate_url.apply(
-  node, [
+full_url = schema_node.generate_url.apply(
+  schema_node, [
 null, url, this.field.get('node_data'),
 this.field.get('url_with_id') || false, node_info,
   ]),
 data = [];
 
   if (this.field.get('version_compatible')) {
-m.trigger('pgadmin:view:fetching', m, self.field);
+m.trigger('pgadmin:view:fetching', m, self_referenced.field);
 $.ajax({
   async: false,
   data : {tid:tid},
@@ -235,24 +235,24 @@ define('pgadmin.node.foreign_key', [
 data = res.data;
   })
   .fail(function() {
-m.trigger('pgadmin:view:fetch:error', m, self.field);
+m.trigger('pgadmin:view:fetch:error', m, self_referenced.field);
   });
-m.trigger('pgadmin:view:fetched', m, self.field);
+m.trigger('pgadmin:view:fetched', m, self_referenced.field);
   }
   /*
  * Transform the data
  */
-  var transform = this.field.get('transform') || self.defaults.transform;
+  var transform = this.field.get('transform') || self_referenced.defaults.transform;
   if (transform && _.isFunction(transform)) {
 // We will transform the data later, when rendering.
  

Re: Reg - [RM-3814] Backup dialog does not show details of error if file name box kept empty

[Yogesh Mahajan]

Hi Akshay,

Patch looks good.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Mon, Jul 6, 2020 at 11:28 AM Akshay Joshi 
wrote:

> Hi Yogesh,
>
> Can you please review it.
>
> On Fri, Jul 3, 2020 at 4:30 PM Satish V  wrote:
>
>> Hi Hackers,
>>
>> Please find the patch in the attachment which resolves the issue of error
>> messages not getting displayed in the dialog boxes of *backup, restore *and
>> *import/export.*
>>
>> Kindly review the patch.
>>
>> Thanks,
>> Sathish V
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

[pgAdmin4][Patch] - SonarQube Issues - 9 (Variables and functions should not be redeclared, Variables should not be shadowed)

[Yogesh Mahajan]

Hi,

Please find a patch which fixes issues related to rule-
   a.Variables should not be shadowed.
   b.Variables and functions should not be redeclared.


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


SonarQubeFix9_v1.patch
Description: Binary data

Re: [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns

[Yogesh Mahajan]

Hello,

Please find an updated patch with the above comment.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Thu, Jul 9, 2020 at 2:27 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Yogesh,
>
> The patch looks good to me except that the newly added import can be
> clubbed with the existing one.
>
> +from psycopg2.extensions import DECIMAL as _DECIMAL
>
>  import psycopg2
>
>  from psycopg2.extensions import encodings
>
> On Thu, Jul 9, 2020 at 1:24 PM Akshay Joshi 
> wrote:
>
>> Hi Aditya
>>
>> Can you please review it.
>>
>> On Wed, Jul 8, 2020 at 4:17 PM Yogesh Mahajan <
>> yogesh.maha...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find a patch which fixes the issue of quoting values of
>>> numeric data types like 'bigint, numeric, double precision & real'.
>>>
>>> The issue was caused because global type caster are registered for
>>> connection in order to avoid javascript compatibility issue for large size
>>> data types like real, numeric, double precision, bigint.
>>> Typcaster used to cast these data type values into String, causing
>>> quotes to numeric data in downloaded CSV files in case of  "CSV quoting =
>>> Strings".
>>>
>>> As part of fix, type caster is temporarily unregistered for these
>>> numeric data types while creating CSV file & registered back after csv file
>>> creation.
>>>
>>>
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> QA - Team
>>> EnterpriseDB Corporation
>>>
>>> Phone: +91-9741705709
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


RM5463_v2.patch
Description: Binary data

Re: [pgAdmin4][RM#5662] [Accessibility] File manager dialog was not rendering properly due to fixed width and height set in the code

[Yogesh Mahajan]

Hi,

Patch looks good to me.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Thu, Jul 9, 2020 at 1:24 PM Akshay Joshi 
wrote:

> Hi Yogesh
>
> Can you please review it.
>
> On Thu, Jul 9, 2020 at 11:56 AM Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch to fix the issue where few dialogs are not rendering properly
>> when we zoomed in browser window 200% and screen resolution is low.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> *EDB*
>> *POWER TO POSTGRES*
>> https://www.edbpostgres.com
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

[pgAdmin4][Patch] - SonarQube Issues - 10 (Variables should not be shadowed)

[Yogesh Mahajan]

Hi,

Please find a patch which fixes issues related to rule -
   a.Variables should not be shadowed.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


SonarQubeFix10_v1.patch
Description: Binary data

[pgAdmin] : Patch fixing Feature Test failures.

[Yogesh Mahajan]

Hi,

Please find a patch to fix feature tests.


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


fix_selenium_grid_failures_v4.0.patch
Description: Binary data

[pgAdmin][Patch] RM5571 - Expression in exclusion constraint is misinterpreted and quoted as column name by mistake

[Yogesh Mahajan]

Hello,

Please find a patch which fixes the issue about SQL tab display for
exclusion constraint.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


RM5571_v1.patch
Description: Binary data

[pgAdmin][Patch] RM4810 - Cannot save new row if table is empty

[Yogesh Mahajan]

Hello,

Please find a patch which enables 'Save button' in SQL editor on defocusing
grid cell in case of a single column table with data type number/integer
etc.


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


RM4810_v1.patch
Description: Binary data

[pgAdmin4][Patch] - SonarQube Issues - 11 (Unused local variables should be removed)

[Yogesh Mahajan]

Hello,

Please find an attached patch fixing 17 sonarqube issues related to below
rule -
 - Unused local variables should be removed.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


SonarQubeFix11_v1.patch
Description: Binary data

[pgadmin-org/pgadmin4] 026334: Removed logging added for feature test failure. Ad...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 026334a71a724b7e77ee9eb607a90899082db17b
  
https://github.com/pgadmin-org/pgadmin4/commit/026334a71a724b7e77ee9eb607a90899082db17b
  Author: Yogesh Mahajan 
  Date:   2023-02-13 (Mon, 13 Feb 2023)

  Changed paths:
M web/regression/feature_tests/browser_tool_bar_test.py
M web/regression/feature_tests/query_tool_journey_test.py
M web/regression/feature_utils/base_feature_test.py
M web/regression/python_test_utils/test_utils.py
M web/regression/runtests.py

  Log Message:
  ---
  Removed logging added for feature test failure. Added more assets to avoid 
false failures.

[pgadmin-org/pgadmin4] 740164: Handle errors occurring during decoding UTF-8 enco...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 740164fbd05ccf34a95a82d9bbca29a3269268cb
  
https://github.com/pgadmin-org/pgadmin4/commit/740164fbd05ccf34a95a82d9bbca29a3269268cb
  Author: Yogesh Mahajan 
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
M web/pgadmin/utils/driver/psycopg3/typecast.py

  Log Message:
  ---
  Handle errors occurring during decoding UTF-8 encoded query result data which 
contains ascii characters. #4784

[pgadmin-org/pgadmin4] 63c7d1: Added capability to deploy PostgreSQL servers on G...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 63c7d1463824d54f784b943ca325cfd076814d0c
  
https://github.com/pgadmin-org/pgadmin4/commit/63c7d1463824d54f784b943ca325cfd076814d0c
  Author: Yogesh Mahajan 
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
M docs/en_US/cloud_aws_rds.rst
A docs/en_US/cloud_azure_database.rst
R docs/en_US/cloud_azure_postgresql.rst
M docs/en_US/cloud_deployment.rst
M docs/en_US/cloud_edb_biganimal.rst
A docs/en_US/cloud_google_cloud_sql.rst
R docs/en_US/images/cloud_aws_provider.png
R docs/en_US/images/cloud_azure_provider.png
R docs/en_US/images/cloud_biganimal_provider.png
A docs/en_US/images/cloud_google_credentials.png
A docs/en_US/images/cloud_google_database.png
A docs/en_US/images/cloud_google_deployment_tree.png
A docs/en_US/images/cloud_google_instance.png
A docs/en_US/images/cloud_google_network.png
A docs/en_US/images/cloud_google_review.png
A docs/en_US/images/cloud_provider_for_postgresql.png
M requirements.txt
A web/pgacloud/providers/google.py
M web/pgadmin/misc/cloud/__init__.py
A web/pgadmin/misc/cloud/google/__init__.py
M web/pgadmin/misc/cloud/static/js/CloudWizard.jsx
M web/pgadmin/misc/cloud/static/js/azure.js
M web/pgadmin/misc/cloud/static/js/cloud.js
M web/pgadmin/misc/cloud/static/js/cloud_components.jsx
M web/pgadmin/misc/cloud/static/js/cloud_constants.js
A web/pgadmin/misc/cloud/static/js/google.js
A web/pgadmin/misc/cloud/static/js/google_schema.ui.js
M web/pgadmin/misc/cloud/utils/__init__.py
M web/pgadmin/static/img/azure.svg
A web/pgadmin/static/img/google-cloud-1.svg
M web/pgadmin/static/js/components/ExternalIcon.jsx
M web/pgadmin/utils/ajax.py

  Log Message:
  ---
  Added capability to deploy PostgreSQL servers on Google Cloud. #5750

[pgadmin-org/pgadmin4] 48f2e2: Fixed feature tests failures occurred due to psyco...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 48f2e2744c57672cf00cb2e554137bd0fb7f4b3d
  
https://github.com/pgadmin-org/pgadmin4/commit/48f2e2744c57672cf00cb2e554137bd0fb7f4b3d
  Author: Yogesh Mahajan 
  Date:   2023-03-14 (Tue, 14 Mar 2023)

  Changed paths:
M web/regression/feature_tests/pg_datatype_validation_test.py
M web/regression/feature_tests/query_tool_journey_test.py
M web/regression/feature_tests/query_tool_tests.py
M web/regression/feature_tests/view_data_dml_queries.py
M web/regression/feature_tests/xss_checks_pgadmin_debugger_test.py
M web/regression/feature_tests/xss_checks_roles_control_test.py
M web/regression/runtests.py

  Log Message:
  ---
  Fixed feature tests failures occurred due to psycopg3 changes.

[pgadmin-org/pgadmin4] 3de2e6: Fix feature test failures caused due to invalid bi...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 3de2e625b5099ee7fc311268dd5797834c66739f
  
https://github.com/pgadmin-org/pgadmin4/commit/3de2e625b5099ee7fc311268dd5797834c66739f
  Author: Yogesh Mahajan 
  Date:   2023-03-15 (Wed, 15 Mar 2023)

  Changed paths:
M web/regression/feature_tests/pg_utilities_backup_restore_test.py
M web/regression/feature_tests/pg_utilities_maintenance_test.py
M web/regression/feature_tests/xss_checks_pgadmin_debugger_test.py
M web/regression/feature_utils/pgadmin_page.py

  Log Message:
  ---
  Fix feature test failures caused due to invalid binary path.

[pgadmin-org/pgadmin4] 6c1282: Validate user inputs provided in configuration fil...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 6c12829cd46258b40abbfa0938b6772f3bf481e4
  
https://github.com/pgadmin-org/pgadmin4/commit/6c12829cd46258b40abbfa0938b6772f3bf481e4
  Author: Yogesh Mahajan 
  Date:   2023-03-17 (Fri, 17 Mar 2023)

  Changed paths:
M web/pgadmin/evaluate_config.py

  Log Message:
  ---
  Validate user inputs provided in configuration files before starting pgadmin 
server. #5907

[pgadmin-org/pgadmin4] 1b327d: Fix issues reported during testing. #5750

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 1b327d199775fcffc51aa2f612aaa4a4e72828b5
  
https://github.com/pgadmin-org/pgadmin4/commit/1b327d199775fcffc51aa2f612aaa4a4e72828b5
  Author: Yogesh Mahajan 
  Date:   2023-03-20 (Mon, 20 Mar 2023)

  Changed paths:
M web/pgAdmin4.py
M web/pgadmin/misc/cloud/google/__init__.py
M web/pgadmin/misc/cloud/static/js/CloudWizard.jsx
M web/pgadmin/misc/cloud/static/js/google.js
M web/pgadmin/misc/cloud/static/js/google_schema.ui.js

  Log Message:
  ---
  Fix issues reported during testing. #5750

[pgadmin-org/pgadmin4] a02635: Fixed the UI related issues reported during testin...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: a026353df8d99121a05f499f36e28059585ce71b
  
https://github.com/pgadmin-org/pgadmin4/commit/a026353df8d99121a05f499f36e28059585ce71b
  Author: Yogesh Mahajan 
  Date:   2023-03-23 (Thu, 23 Mar 2023)

  Changed paths:
M docs/en_US/images/cloud_provider_for_postgresql.png
M web/pgAdmin4.py
M web/pgacloud/providers/rds.py
M web/pgadmin/misc/cloud/static/js/google.js
M web/pgadmin/misc/cloud/static/js/google_schema.ui.js

  Log Message:
  ---
  Fixed the UI related issues reported during testing for Google Cloud SQL 
deployment. #5750

[pgadmin-org/pgadmin4] f1aa82: While restoring the database connections due to lo...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: f1aa82ad3675c1fd8dbdaf5ccb1f939cf678e961
  
https://github.com/pgadmin-org/pgadmin4/commit/f1aa82ad3675c1fd8dbdaf5ccb1f939cf678e961
  Author: Yogesh Mahajan 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M web/pgadmin/utils/heartbeat.py

  Log Message:
  ---
  While restoring the database connections due to lost server connection, 
ensure that the databases which were previously connected are only reconnected. 
#5919

[pgadmin-org/pgadmin4] 58aca5: Fixed error occurring while authentication in Goog...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 58aca506feeb6bdbfc17009dba6944be2d77b6de
  
https://github.com/pgadmin-org/pgadmin4/commit/58aca506feeb6bdbfc17009dba6944be2d77b6de
  Author: Yogesh Mahajan 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M web/pgadmin/misc/cloud/google/__init__.py
M web/pgadmin/misc/cloud/static/js/google_schema.ui.js

  Log Message:
  ---
  Fixed error occurring while authentication in Google Cloud SQL deployment 
wizard in server mode. #5750

[pgadmin-org/pgadmin4] 40013f: Added support of BigAnimal v3 API. #5805

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 40013fb26ccbc6fa411669b534fd4552cfcb0fd9
  
https://github.com/pgadmin-org/pgadmin4/commit/40013fb26ccbc6fa411669b534fd4552cfcb0fd9
  Author: Yogesh Mahajan 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M web/pgacloud/providers/biganimal.py
M web/pgadmin/misc/cloud/biganimal/__init__.py
M web/pgadmin/misc/cloud/static/js/CloudWizard.jsx
M web/pgadmin/misc/cloud/static/js/biganimal.js
M web/pgadmin/misc/cloud/static/js/biganimal_schema.ui.js

  Log Message:
  ---
  Added support of BigAnimal v3 API. #5805

[pgadmin-org/pgadmin4] 97bd41: Fixed intermittent failures for the role related f...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 97bd417ea815eafe03200a55ff5fa652126f5080
  
https://github.com/pgadmin-org/pgadmin4/commit/97bd417ea815eafe03200a55ff5fa652126f5080
  Author: Yogesh Mahajan 
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
M web/regression/feature_tests/xss_checks_roles_control_test.py
M web/regression/feature_utils/pgadmin_page.py

  Log Message:
  ---
  Fixed intermittent failures for the role related feature tests.

[pgadmin-org/pgadmin4] 51c226: Update BigAnimal documentation for BigAnimal v3 AP...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 51c22608b2d128000baf5c32861300bedd2d221d
  
https://github.com/pgadmin-org/pgadmin4/commit/51c22608b2d128000baf5c32861300bedd2d221d
  Author: Yogesh Mahajan 
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
A docs/en_US/cloud_biganimal_cluster.png
M docs/en_US/cloud_edb_biganimal.rst

  Log Message:
  ---
  Update BigAnimal documentation for BigAnimal v3 API changes. #5805

[pgadmin-org/pgadmin4] 501bff: Ensure google authentication can be completed succ...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 501bff6f7acbfdd159895e6c6ffaf4edd01887db
  
https://github.com/pgadmin-org/pgadmin4/commit/501bff6f7acbfdd159895e6c6ffaf4edd01887db
  Author: Yogesh Mahajan 
  Date:   2023-03-28 (Tue, 28 Mar 2023)

  Changed paths:
M web/pgadmin/misc/cloud/google/__init__.py

  Log Message:
  ---
  Ensure google authentication can be completed successfully, while pgAdmin is 
running in behind proxy servers. #5750

[pgadmin-org/pgadmin4] fc0e36: Removed old path library used to validate client s...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: fc0e36b313d04dfa514da0bec835b3699674ade8
  
https://github.com/pgadmin-org/pgadmin4/commit/fc0e36b313d04dfa514da0bec835b3699674ade8
  Author: Yogesh Mahajan 
  Date:   2023-03-28 (Tue, 28 Mar 2023)

  Changed paths:
M web/pgadmin/misc/cloud/google/__init__.py
M web/regression/feature_utils/pgadmin_page.py

  Log Message:
  ---
  Removed old path library used to validate client secret path while google 
authentication. #5750

[pgadmin-org/pgadmin4] a607ab: Another try to fix role related feature tests.

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: a607ab2d943121f86dfc987fe463c7c86d2aea03
  
https://github.com/pgadmin-org/pgadmin4/commit/a607ab2d943121f86dfc987fe463c7c86d2aea03
  Author: Yogesh Mahajan 
  Date:   2023-03-29 (Wed, 29 Mar 2023)

  Changed paths:
M web/regression/feature_tests/xss_checks_roles_control_test.py
M web/regression/feature_utils/pgadmin_page.py

  Log Message:
  ---
  Another try to fix role related feature tests.

[pgadmin-org/pgadmin4] 33953e: Fixed intermittent error "Connection Lost" shown w...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 33953e9119b87e6e821f8d373fa740602e898a70
  
https://github.com/pgadmin-org/pgadmin4/commit/33953e9119b87e6e821f8d373fa740602e898a70
  Author: Yogesh Mahajan 
  Date:   2023-03-31 (Fri, 31 Mar 2023)

  Changed paths:
M web/pgadmin/browser/server_groups/servers/databases/static/js/database.js
M web/regression/feature_tests/pg_utilities_maintenance_test.py
M web/regression/feature_utils/base_feature_test.py

  Log Message:
  ---
  Fixed intermittent error "Connection Lost" shown while connecting to database.

[pgadmin-org/pgadmin4] dfa367: Fixed video recording broken for feature tests due...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: dfa367a127520e368de91e6893ce4e191e18162e
  
https://github.com/pgadmin-org/pgadmin4/commit/dfa367a127520e368de91e6893ce4e191e18162e
  Author: Yogesh Mahajan 
  Date:   2023-04-03 (Mon, 03 Apr 2023)

  Changed paths:
M web/regression/python_test_utils/test_utils.py

  Log Message:
  ---
  Fixed video recording broken for feature tests due to selenium package update.

[pgadmin-org/pgadmin4] 993e1e: Allow on demand record count setting to be changed...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 993e1eb1b6eb9969b08f19d97cb71ba485a62e25
  
https://github.com/pgadmin-org/pgadmin4/commit/993e1eb1b6eb9969b08f19d97cb71ba485a62e25
  Author: Yogesh Mahajan 
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
M docs/en_US/images/preferences_sql_results_grid.png
M docs/en_US/preferences.rst
M web/pgadmin/tools/sqleditor/__init__.py
M web/pgadmin/tools/sqleditor/utils/query_tool_preferences.py
M web/regression/runtests.py

  Log Message:
  ---
  Allow on demand record count setting to be changed per user using 
preferences. #3275

[pgadmin-org/pgadmin4] 64d545: Try to fix feature test failures happening due to ...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 64d5457e2b4e663639b59a4fbe48b91711584c31
  
https://github.com/pgadmin-org/pgadmin4/commit/64d5457e2b4e663639b59a4fbe48b91711584c31
  Author: Yogesh Mahajan 
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
M docs/en_US/images/preferences_sql_results_grid.png
M docs/en_US/release_notes_7_1.rst
M web/pgadmin/tools/sqleditor/utils/query_tool_preferences.py
M web/regression/feature_tests/query_tool_auto_complete_tests.py
M web/regression/feature_tests/query_tool_tests.py
M web/regression/feature_tests/test_copy_sql_to_query_tool.py
M web/regression/feature_tests/xss_checks_panels_and_query_tool_test.py

  Log Message:
  ---
  Try to fix feature test failures happening due to error occurring while 
deleting test databases.

* Try to fix feature test failures happening due to error occurring while 
deleting test databases.

* Updated ON_DEMAND_ROW_COUNT to ON_DEMAND_RECORD_COUNT missed in #3275.

[pgadmin-org/pgadmin4] 686f52: Do not treat database deletion errors as Feature t...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 686f52f63629ac845ff8cdbebd1a7c2b0027a270
  
https://github.com/pgadmin-org/pgadmin4/commit/686f52f63629ac845ff8cdbebd1a7c2b0027a270
  Author: Yogesh Mahajan 
  Date:   2023-04-17 (Mon, 17 Apr 2023)

  Changed paths:
M web/regression/runtests.py

  Log Message:
  ---
  Do not treat database deletion errors as Feature test failures.

[pgadmin-org/pgadmin4] 4ede08: Fixed error occurring while logging out from pgAdm...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 4ede084b8f73860c64befa879d803bc23fc53a20
  
https://github.com/pgadmin-org/pgadmin4/commit/4ede084b8f73860c64befa879d803bc23fc53a20
  Author: Yogesh Mahajan 
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
M web/pgadmin/utils/locker.py

  Log Message:
  ---
  Fixed error occurring while logging out from pgAdmin keeping a query tool 
opened. #6120

[pgadmin-org/pgadmin4] f1e778: Fixed error occurring while dumping the servers fr...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: f1e7782ca279ac1d5f9546a9c7b9e7dc9ec11c59
  
https://github.com/pgadmin-org/pgadmin4/commit/f1e7782ca279ac1d5f9546a9c7b9e7dc9ec11c59
  Author: Yogesh Mahajan 
  Date:   2023-04-19 (Wed, 19 Apr 2023)

  Changed paths:
M docs/en_US/release_notes_7_1.rst
M web/pgadmin/utils/__init__.py

  Log Message:
  ---
  Fixed error occurring while dumping the servers from CLI. #6137

[pgadmin-org/pgadmin4] 39a0f4: Ensure that internal users are able to login when ...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 39a0f46159a7be39f084cdfdcb6235b4715230a4
  
https://github.com/pgadmin-org/pgadmin4/commit/39a0f46159a7be39f084cdfdcb6235b4715230a4
  Author: Yogesh Mahajan 
  Date:   2023-04-24 (Mon, 24 Apr 2023)

  Changed paths:
M web/pgadmin/authenticate/__init__.py
M web/pgadmin/authenticate/internal.py

  Log Message:
  ---
  Ensure that internal users are able to login when auth sources are [ldap, 
internal]. #6151

[pgadmin-org/pgadmin4] 8428df: Fixed the error occurring while postgresql cloud i...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 8428df97ca58e5838b60344bc7eeb0a9ec359cbb
  
https://github.com/pgadmin-org/pgadmin4/commit/8428df97ca58e5838b60344bc7eeb0a9ec359cbb
  Author: Yogesh Mahajan 
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
A web/pgacloud/providers/aws.py
R web/pgacloud/providers/rds.py
M web/pgadmin/misc/cloud/__init__.py
M web/pgadmin/misc/cloud/utils/__init__.py

  Log Message:
  ---
  Fixed the error occurring while postgresql cloud instance deployment on AWS 
RDS.

Re: [pgAdmin4][Patch]- Feature #7012 - disable master password requirement when using alternative auth source

[Yogesh Mahajan]

Hi Dave/Team,

As per the new design, pgAdmin should add a config to specify a path for
script/program to retrieve an encryption key & use it to encrypt the
passwords.
The script/program will be at an application level and not a user level.
This feature will be applicable only in case of server mode as we are going
to use OS level secret storage for the same in Desktop mode.

Thanks,
Yogesh Mahajan
EnterpriseDB


On Fri, Apr 22, 2022 at 4:01 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

>
> On Fri, Apr 22, 2022 at 3:57 PM Dave Page  wrote:
>
>>
>>
>> On Fri, 22 Apr 2022 at 11:16, Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Fri, Apr 22, 2022 at 3:28 PM Dave Page  wrote:
>>>
>>>>
>>>>
>>>> On Fri, 22 Apr 2022 at 10:49, Aditya Toshniwal <
>>>> aditya.toshni...@enterprisedb.com> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> Generally, secure keys like API_KEYS and all are supposed to be set in
>>>>> env and are read by the app. Similar is the alternative encryption key.
>>>>> People can run their scripts to export those config vars.
>>>>>
>>>>
>>>> On the client side, yes. This is server side though. It's not uncommon
>>>> on the server side to include hooks to allow key retrieval from external
>>>> key management systems.
>>>>
>>> Even on the server side. Like the AWS auth keys, or DB passwords. We can
>>> include hooks, not against it. Just discussing.
>>>
>>
>> If you're using an AWS auth key on a server, then you're acting as a
>> client for AWS - and DB passwords are a great example of why using a hook
>> is a good thing; it's a very common request from users to have a secure way
>> to retrieve credentials from an external service. Not to mention that a DB
>> password is needed on the client side of a connection, not on the server
>> side. On the server side, the database would query LDAP/Kerberos/whatever.
>>
>> A better example would be querying a key management service to unlock an
>> encrypted disk or something like the service Bruce wrote for managing
>> pgcrypto keys.
>>
>
> Got it. Thanks.
>
>>
>>
>>
>>>
>>>>
>>>>
>>>>>
>>>>> On Fri, Apr 22, 2022 at 2:38 PM Khushboo Vashi <
>>>>> khushboo.va...@enterprisedb.com> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On Fri, Apr 22, 2022 at 2:34 PM Dave Page  wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Fri, 22 Apr 2022 at 09:57, Khushboo Vashi <
>>>>>>> khushboo.va...@enterprisedb.com> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Fri, Apr 22, 2022 at 2:01 PM Dave Page 
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi
>>>>>>>>>
>>>>>>>>> On Mon, 11 Apr 2022 at 09:20, Akshay Joshi <
>>>>>>>>> akshay.jo...@enterprisedb.com> wrote:
>>>>>>>>>
>>>>>>>>>> Thanks, the patch applied.
>>>>>>>>>>
>>>>>>>>>> On Mon, Apr 11, 2022 at 12:00 PM Khushboo Vashi <
>>>>>>>>>> khushboo.va...@enterprisedb.com> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> Please find the attached patch to implement the feature #7012 -
>>>>>>>>>>> Disable master password requirement when using alternative auth 
>>>>>>>>>>> source
>>>>>>>>>>>
>>>>>>>>>>> When pgAdmin stores a connection password, it encrypts it using
>>>>>>>>>>> a key that is formed either from the master password, or from the 
>>>>>>>>>>> pgAdmin
>>>>>>>>>>> login password for the user. In the case of auth methods such as 
>>>>>>>>>>> OAuth,
>>>>>>>>>>> Kerberos or Webserver, pgAdmin doesn't have access to anything 
>>>>>>>>&

[pgadmin-org/pgadmin4] d6f01b: Ensure user/roles with special characters are quot...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: d6f01b552a081b90ba7b218f8136bc124b3730a3
  
https://github.com/pgadmin-org/pgadmin4/commit/d6f01b552a081b90ba7b218f8136bc124b3730a3
  Author: Yogesh Mahajan 
  Date:   2023-05-03 (Wed, 03 May 2023)

  Changed paths:
M web/pgadmin/browser/server_groups/servers/utils.py

  Log Message:
  ---
  Ensure user/roles with special characters are quoted to avoid syntax 
error.#6234

[pgadmin-org/pgadmin4] 0431cf: Ensure the user is able to log in if the specified...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 0431cf7fc11e7ea70d67bb516eafb1a83b80
  
https://github.com/pgadmin-org/pgadmin4/commit/0431cf7fc11e7ea70d67bb516eafb1a83b80
  Author: Yogesh Mahajan 
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
M web/pgadmin/authenticate/oauth2.py

  Log Message:
  ---
  Ensure the user is able to log in if the specified OAUTH2_USERNAME_CLAIM is 
present in the OAuth2 profile. #6267

Re: Feature tests on M1 Mac fail

[Yogesh Mahajan]

Hi,

Errors occurring for python 3.8, 3.10, 3.11 are due the latest Werkzeug version
2.3.4/2.3.3.
Could you please check Werkzeug version getting downloaded in venv? It
should be Werkzeug 2.2.3

I have seen error occurring with python 3.9, but could not reproduce
locally. My guess is, it is again due to some dependent package version
upgrade.
And both the errors should not be specific to feature tests. It should be
for API/ReSQL tests too.

Thanks,
Yogesh Mahajan
EnterpriseDB


On Wed, May 10, 2023 at 5:38 PM Dave Page  wrote:

> I get the following errors when trying to run the feature tests on an M1
> Mac, with Python 3.8 through 3.11. The Python 3.9 failure seems to be a
> known issue with eventlet (though, our tests should still be able to run),
> and whilst the others can be fixed with the strategic addition of a
> .decode('UTF-8'), it does beg the question "how do these tests pass on our
> buildfarm".
>
> Yogesh, can you take a look please?
>
> 
>
> ~/git/pgadmin4/web  % workon pgadmin4-py38
>
>
> ~/git/pgadmin4/web  % python regression/runtests.py --pkg feature_tests
>
>
> 2023-05-10 12:49:05,666: INFO   pgadmin:
> 
>
> 2023-05-10 12:49:05,666: INFO   pgadmin:Starting pgAdmin 4 v7.1...
>
> 2023-05-10 12:49:05,666: INFO   pgadmin:
> 
>
> 2023-05-10 12:49:05,666: DEBUG  pgadmin:Python syspath:
> ['/Users/dpage/git/pgadmin4/web/regression',
> '/Users/dpage/git/pgadmin4/web',
> '/Users/dpage/git/pgadmin4/web/regression',
> '/Library/Frameworks/Python.framework/Versions/3.8/lib/python38.zip',
> '/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8',
> '/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/lib-dynload',
> '/Users/dpage/.virtualenvs/pgadmin4-py38/lib/python3.8/site-packages']
>
> NOTE: Configuring authentication for SERVER mode.
>
>
> 2023-05-10 12:49:06,738: INFO   pgadmin:Registering blueprint
> module: 
>
> 2023-05-10 12:49:06,739: INFO   pgadmin:Registering blueprint
> module: 
>
> 2023-05-10 12:49:06,740: INFO   pgadmin:Registering blueprint
> module: 
>
> 2023-05-10 12:49:07,662: INFO   pgadmin:Registering blueprint
> module: 
>
> 2023-05-10 12:49:07,668: INFO   pgadmin:Registering blueprint
> module: 
>
> 2023-05-10 12:49:07,668: INFO   pgadmin:Registering blueprint
> module: 
>
> 2023-05-10 12:49:07,668: INFO   pgadmin:Registering blueprint
> module: 
>
> 2023-05-10 12:49:08,769: INFO   pgadmin:Registering blueprint
> module: 
>
> 2023-05-10 12:49:08,771: INFO   pgadmin:Registering blueprint
> module: 
>
> 2023-05-10 12:49:08,771: INFO   pgadmin:Registering blueprint
> module: 
>
> 2023-05-10 12:49:08,774: INFO   pgadmin:Registering blueprint
> module: 
>
> pgAdmin 4 - Application Initialisation
>
> ==
>
>
> Starting pgAdmin 4. Please navigate to http://127.0.0.1:34575 in your
> browser.
>
>  * Serving Flask app 'pgadmin'
>
>  * Debug mode: off
>
>
> =Running the test cases for 'PostgreSQL 15' =
>
> Traceback (most recent call last):
>
>   File "regression/runtests.py", line 486, in execute_test
>
> test_utils.create_parent_server_node(server_passed)
>
>   File
> "/Users/dpage/git/pgadmin4/web/regression/python_test_utils/test_utils.py",
> line 691, in create_parent_server_node
>
> srv_id = create_server(server_info)
>
>   File
> "/Users/dpage/git/pgadmin4/web/regression/python_test_utils/test_utils.py",
> line 634, in create_server
>
> server['type'] = get_server_type(server)
>
>   File
> "/Users/dpage/git/pgadmin4/web/regression/python_test_utils/test_utils.py",
> line 1189, in get_server_type
>
> if "EnterpriseDB" in version_string:
>
> TypeError: a bytes-like object is required, not 'str'
>
> a bytes-like object is required, not 'str'
>
> Exception in 6208811008 Thread-3
>
>
> =Completed the test cases for 'PostgreSQL 15'=
>
>
> ==
>
> Test Result Summary
>
> ==
>
>
> ==
>
>
> Please check output in file:
> /Users/dpage/git/pgadmin4/web/regression/regre

[pgadmin-org/pgadmin4] cad4c6: Fix feature tests for the database versions 11, 12...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: cad4c6b8af4d59fa37213d92b6ee820786e4a612
  
https://github.com/pgadmin-org/pgadmin4/commit/cad4c6b8af4d59fa37213d92b6ee820786e4a612
  Author: Yogesh Mahajan 
  Date:   2023-05-15 (Mon, 15 May 2023)

  Changed paths:
M web/regression/feature_tests/pg_datatype_validation_test.py

  Log Message:
  ---
  Fix feature tests for the database versions 11, 12 and 13, broken due to 
multirange data types support.

[pgadmin-org/pgadmin4] 30107e: Ensure that "pause replay of wal"/"resume replay o...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 30107e38f393aa6d3de43ada6c5b88c7a0f36911
  
https://github.com/pgadmin-org/pgadmin4/commit/30107e38f393aa6d3de43ada6c5b88c7a0f36911
  Author: Yogesh Mahajan 
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
M web/pgadmin/browser/server_groups/servers/__init__.py
M web/pgadmin/browser/server_groups/servers/static/js/server.js

  Log Message:
  ---
  Ensure that "pause replay of wal"/"resume replay of wal" are enabled/disabled 
appropriately. #6026

[pgadmin-org/pgadmin4] 6c7f5d: Ensure that connection heartbeat signals are stopp...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 6c7f5d1a6b0a04acf3326947284b9c69f6972586
  
https://github.com/pgadmin-org/pgadmin4/commit/6c7f5d1a6b0a04acf3326947284b9c69f6972586
  Author: Yogesh Mahajan 
  Date:   2023-05-17 (Wed, 17 May 2023)

  Changed paths:
M web/pgadmin/browser/server_groups/servers/static/js/server.js

  Log Message:
  ---
  Ensure that connection heartbeat signals are stopped on server disconnect. 
#6147

[pgadmin-org/pgadmin4] b6924a: Fixed error occurring while opening query tool aft...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: b6924a84d6fa40e0c7d5ca61fe7db5756b50de6e
  
https://github.com/pgadmin-org/pgadmin4/commit/b6924a84d6fa40e0c7d5ca61fe7db5756b50de6e
  Author: Yogesh Mahajan 
  Date:   2023-05-23 (Tue, 23 May 2023)

  Changed paths:
M web/pgadmin/browser/server_groups/servers/static/js/server.js

  Log Message:
  ---
  Fixed error occurring while opening query tool after togging Resume/Pause wal 
replay. #6026

[pgadmin-org/pgadmin4] 702bc8: Allow pgAdmin to retrieve master password from ext...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 702bc8c8ce630d857f6911e1b2a6994d1e2e1040
  
https://github.com/pgadmin-org/pgadmin4/commit/702bc8c8ce630d857f6911e1b2a6994d1e2e1040
  Author: Yogesh Mahajan 
  Date:   2023-05-25 (Thu, 25 May 2023)

  Changed paths:
M docs/en_US/release_notes_7_2.rst
M web/config.py
M web/pgadmin/browser/__init__.py
M web/pgadmin/static/js/Dialogs/index.jsx
M web/pgadmin/utils/master_password.py

  Log Message:
  ---
  Allow pgAdmin to retrieve master password from external script/program. #4769

[pgadmin-org/pgadmin4] cb070f: Fix error handling to show error when a user enter...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: cb070fc365e6d3955c4eb762ac2396ef5acc2491
  
https://github.com/pgadmin-org/pgadmin4/commit/cb070fc365e6d3955c4eb762ac2396ef5acc2491
  Author: Yogesh Mahajan 
  Date:   2023-05-25 (Thu, 25 May 2023)

  Changed paths:
M web/pgadmin/browser/__init__.py
M web/pgadmin/static/js/Dialogs/index.jsx

  Log Message:
  ---
  Fix error handling to show error when a user enters incorrect Master 
Password. #4769

[pgadmin-org/pgadmin4] eef295: Fixed feature tests failing due to selenium upgrad...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: eef295f9d83d433224cd2fbab943ebfbf17f2a2a
  
https://github.com/pgadmin-org/pgadmin4/commit/eef295f9d83d433224cd2fbab943ebfbf17f2a2a
  Author: Yogesh Mahajan 
  Date:   2023-06-19 (Mon, 19 Jun 2023)

  Changed paths:
M web/regression/python_test_utils/test_utils.py
M web/regression/requirements.txt
M web/regression/runtests.py

  Log Message:
  ---
  Fixed feature tests failing due to selenium upgrade to 4.10.0.

[pgadmin-org/pgadmin4] cb7fd7: Enable cluster deployment with gp3 volume for AWS ...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: cb7fd7106c87a040c37d4ed669dee8af6abef381
  
https://github.com/pgadmin-org/pgadmin4/commit/cb7fd7106c87a040c37d4ed669dee8af6abef381
  Author: Yogesh Mahajan 
  Date:   2023-07-10 (Mon, 10 Jul 2023)

  Changed paths:
M docs/en_US/cloud_edb_biganimal.rst
M docs/en_US/images/cloud_biganimal_instance.png
M web/pgacloud/providers/aws.py
M web/pgacloud/providers/biganimal.py
M web/pgadmin/misc/cloud/biganimal/__init__.py
M web/pgadmin/misc/cloud/rds/__init__.py
M web/pgadmin/misc/cloud/static/js/aws.js
M web/pgadmin/misc/cloud/static/js/aws_schema.ui.js
M web/pgadmin/misc/cloud/static/js/biganimal.js
M web/pgadmin/misc/cloud/static/js/biganimal_schema.ui.js

  Log Message:
  ---
  Enable cluster deployment with gp3 volume for AWS & BigAnimal cloud 
providers. #6323

[pgadmin-org/pgadmin4] d17d29: Pin gunicorn version to 20.0.1 as latest version g...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: d17d291e075deba0738cc7a417beb87bbe6682d6
  
https://github.com/pgadmin-org/pgadmin4/commit/d17d291e075deba0738cc7a417beb87bbe6682d6
  Author: Yogesh Mahajan 
  Date:   2023-07-19 (Wed, 19 Jul 2023)

  Changed paths:
M Dockerfile

  Log Message:
  ---
  Pin gunicorn version to 20.0.1 as latest version gives error - Bad file 
descriptor(Gunicorn Issue #3025).

[pgadmin-org/pgadmin4] 76b0f8: Pin correct gunicorn version to 20.1.0 as latest v...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 76b0f808930ea69bac2934431178d3aeca5d3ebf
  
https://github.com/pgadmin-org/pgadmin4/commit/76b0f808930ea69bac2934431178d3aeca5d3ebf
  Author: Yogesh Mahajan 
  Date:   2023-07-19 (Wed, 19 Jul 2023)

  Changed paths:
M Dockerfile

  Log Message:
  ---
  Pin correct gunicorn version to 20.1.0 as latest version gives error - Bad 
file descriptor. #3025

[pgadmin-org/pgadmin4] 39d70a: Ensure user gets proper error if incorrect credent...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 39d70a94a6498cd14284c913c30cf771f310b946
  
https://github.com/pgadmin-org/pgadmin4/commit/39d70a94a6498cd14284c913c30cf771f310b946
  Author: Yogesh Mahajan 
  Date:   2023-07-20 (Thu, 20 Jul 2023)

  Changed paths:
M web/pgadmin/misc/cloud/rds/__init__.py

  Log Message:
  ---
  Ensure user gets proper error if incorrect credentials are entered while 
authenticating AWS. #6406

[pgadmin-org/pgadmin4] e8fdf0: Fix incorrect redirection URL after authentication...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: e8fdf04e97312f0d6afd25bb5a56b32804f7e100
  
https://github.com/pgadmin-org/pgadmin4/commit/e8fdf04e97312f0d6afd25bb5a56b32804f7e100
  Author: Yogesh Mahajan 
  Date:   2023-08-03 (Thu, 03 Aug 2023)

  Changed paths:
M web/pgAdmin4.wsgi

  Log Message:
  ---
  Fix incorrect redirection URL after authentication by removing fixed value 
set to SCRIPT_NAME environment variable in pgAdmin4.wsgi file.#5454

[pgadmin-org/pgadmin4] ce146b: Add support for TRUNCATE trigger in foreign table....

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: ce146b679c053f2ecc6bec0bfc562d94df8191c9
  
https://github.com/pgadmin-org/pgadmin4/commit/ce146b679c053f2ecc6bec0bfc562d94df8191c9
  Author: Yogesh Mahajan 
  Date:   2023-08-03 (Thu, 03 Aug 2023)

  Changed paths:
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/children/__init__.py
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/static/js/foreign_table.js
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/columns/static/js/column.js
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/__init__.py
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/check_constraint/static/js/check_constraint.js
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/exclusion_constraint/static/js/exclusion_constraint.js
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/foreign_key/static/js/foreign_key.js
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/primary_key.js
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/unique_constraint.js
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/static/js/constraints.js
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/triggers/__init__.py
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/triggers/static/js/trigger.js

  Log Message:
  ---
  Add support for TRUNCATE trigger in foreign table. #6448

Request for inputs on #6208 - MaxQueuePool Issue

[Yogesh Mahajan]

Hi Hackers,

For the #6208 <https://github.com/pgadmin-org/pgadmin4/issues/6208>, below
are the observations about this issue -

On each API request, an application db connection is created with state
'idle in transaction'. Connection state is changed to idle only after a
successful response from the web server. If an exception occurs while
processing a request which is not handled and response is not sent, the
application db connection remains orphaned. This connection is only reset
on application restart.

Issue - In case of pgAdmin, if the user openes 15 query tool tabs & all of
them have long running transactions like pg_sleep(), then opening new query
tool/or any operation on pgAdmin which hits API request to backend will
throw 'QueuePool Limit reached' error. (Because by default, SQLAlchemy
allows 15 connections total: 5 connections in pool & 10 in overflow and
pgAdmin uses default setting.) OR  if the user executes a query in the
query tool & while query execution is in progress, hits F5(keyboard
shortcut to execute query) 16 times continuously, then pgAdmin throws
'QueuePool Limit reached' error. After that, the query tool gives incorrect
responses to the queries.

Solutions -
1.Provide configurable settings for 'pool_size' & 'max_overflow' parameters
for SQLAlchemy.
2.Disable pooling using NullPool.A Pool which does not pool connections.
Instead it literally opens and closes the underlying DB-API connection per
each connection open/close. Using NullPool may impact the performance.

What approach should be followed to fix the issue?

@Nikhil Mohite  Please add if anything is
missed.

Thanks,
Yogesh Mahajan
EnterpriseDB

[pgadmin-org/pgadmin4] 0b24a8: Ensure keyboard shortcut for query execution is di...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 0b24a8f39aad1058e8c94b4b95c4c4c365b9e920
  
https://github.com/pgadmin-org/pgadmin4/commit/0b24a8f39aad1058e8c94b4b95c4c4c365b9e920
  Author: Yogesh Mahajan 
  Date:   2023-08-09 (Wed, 09 Aug 2023)

  Changed paths:
M web/pgadmin/tools/sqleditor/static/js/components/sections/MainToolBar.jsx

  Log Message:
  ---
  Ensure keyboard shortcut for query execution is disabled when query execution 
is in progress. #6664

Re: Request for inputs on #6208 - MaxQueuePool Issue

[Yogesh Mahajan]

Hi Dave

On Fri, Aug 11, 2023 at 2:40 PM Dave Page  wrote:

>
>
> On Wed, 9 Aug 2023 at 08:25, Akshay Joshi 
> wrote:
>
>> Hi Yogesh
>>
>> On Tue, Aug 8, 2023 at 1:48 PM Yogesh Mahajan <
>> yogesh.maha...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> For the #6208 <https://github.com/pgadmin-org/pgadmin4/issues/6208>, below
>>> are the observations about this issue -
>>>
>>> On each API request, an application db connection is created with state
>>> 'idle in transaction'. Connection state is changed to idle only after a
>>> successful response from the web server. If an exception occurs while
>>> processing a request which is not handled and response is not sent, the
>>> application db connection remains orphaned. This connection is only reset
>>> on application restart.
>>>
>>> Issue - In case of pgAdmin, if the user openes 15 query tool tabs & all
>>> of them have long running transactions like pg_sleep(), then opening new
>>> query tool/or any operation on pgAdmin which hits API request to backend
>>> will throw 'QueuePool Limit reached' error. (Because by default, SQLAlchemy
>>> allows 15 connections total: 5 connections in pool & 10 in overflow and
>>> pgAdmin uses default setting.) OR  if the user executes a query in the
>>> query tool & while query execution is in progress, hits F5(keyboard
>>> shortcut to execute query) 16 times continuously, then pgAdmin throws
>>> 'QueuePool Limit reached' error. After that, the query tool gives incorrect
>>> responses to the queries.
>>>
>>> Solutions -
>>> 1.Provide configurable settings for 'pool_size' & 'max_overflow'
>>> parameters for SQLAlchemy.
>>> 2.Disable pooling using NullPool.A Pool which does not pool connections.
>>> Instead it literally opens and closes the underlying DB-API connection per
>>> each connection open/close. Using NullPool may impact the performance.
>>>
>>> What approach should be followed to fix the issue?
>>>
>>
>> If NullPool *may* impact the performance then we should go with
>> Solution 1.
>>
>
> Yes, with a much larger default value I would suggest.
>

Okay.Will proceed with solution 1.

>
> Plus, we should also stop leaving orphaned connections behind...
>

Fix for this is already commited.

>
>
> --
> Dave Page
> Blog: https://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: https://www.enterprisedb.com
>
>

Thanks,
Yogesh Mahajan
EnterpriseDB

[pgadmin-org/pgadmin4] 34f160: Allow changing the POOL_SIZE and MAX_OVERFLOW conf...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 34f160cec77ec416a914506d0f87ee5cefcbef9f
  
https://github.com/pgadmin-org/pgadmin4/commit/34f160cec77ec416a914506d0f87ee5cefcbef9f
  Author: Yogesh Mahajan 
  Date:   2023-08-16 (Wed, 16 Aug 2023)

  Changed paths:
M web/config.py
M web/pgadmin/model/__init__.py
M web/regression/runtests.py

  Log Message:
  ---
  Allow changing the POOL_SIZE and MAX_OVERFLOW config values of the pgAdmin 
config DB connection pool. #6208

[pgadmin-org/pgadmin4] e2f32c: Fix doc build failure due to SQLAlchemy changes. #...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: e2f32c0984a96e36203ea5971dd28ccd1be6d17e
  
https://github.com/pgadmin-org/pgadmin4/commit/e2f32c0984a96e36203ea5971dd28ccd1be6d17e
  Author: Yogesh Mahajan 
  Date:   2023-08-17 (Thu, 17 Aug 2023)

  Changed paths:
M docs/en_US/build_code_snippet.py
M pkg/pip/setup_pip.py

  Log Message:
  ---
  Fix doc build failure due to SQLAlchemy changes. #6208

[pgadmin-org/pgadmin4] 7f5433: Update documentation for OAuth2 authentication red...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 7f5433b307571065280f5bece33d278a10dd37f3
  
https://github.com/pgadmin-org/pgadmin4/commit/7f5433b307571065280f5bece33d278a10dd37f3
  Author: Yogesh Mahajan 
  Date:   2023-08-21 (Mon, 21 Aug 2023)

  Changed paths:
M docs/en_US/oauth2.rst

  Log Message:
  ---
  Update documentation for OAuth2 authentication redirect url.#6644

[pgadmin-org/pgadmin4] cd613d: Ensure user is redirected to login page after fail...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: cd613ded0a12f5566e67d29e510515ca2df61c6b
  
https://github.com/pgadmin-org/pgadmin4/commit/cd613ded0a12f5566e67d29e510515ca2df61c6b
  Author: Yogesh Mahajan 
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
M web/pgadmin/authenticate/__init__.py
M web/pgadmin/authenticate/oauth2.py
M web/pgadmin/utils/__init__.py

  Log Message:
  ---
  Ensure user is redirected to login page after failed login. #6704

Re: pgAdmin4 v7.7 candidate builds

[Yogesh Mahajan]

Hi Akshay,

Installer testing is completed. We can release the version 7.7.

Thanks,
Yogesh Mahajan
EnterpriseDB


On Wed, Sep 20, 2023 at 1:54 PM Akshay Joshi 
wrote:

> Found one issue during testing, so respin the build again.
> The latest candidate builds and source code is available at
> https://developer.pgadmin.org/builds/2023-09-20-2/
> <https://developer.pgadmin.org/builds/2023-09-20-2/>
>
> On Wed, Sep 20, 2023 at 11:52 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi All
>>
>> The latest candidate builds and source code is available at
>> https://developer.pgadmin.org/builds/2023-09-20-1/
>>
>> On Mon, Sep 18, 2023 at 7:49 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi All,
>>>
>>> pgAdmin4 v7.7 candidate builds and source code is available at
>>> https://developer.pgadmin.org/builds/2023-09-18-1/
>>>
>>> Yogesh, could you please verify this for Thursday's release?
>>>
>>> --
>>> Akshay Joshi
>>> Principal Software Architect
>>> www.enterprisedb.com
>>>
>>> *Blog*: https://www.enterprisedb.com/akshay-joshi
>>> *GitHub*: https://github.com/akshay-joshi
>>> *LinkedIn*: https://www.linkedin.com/in/akshay-joshi-086497216
>>>
>>

[pgadmin-org/pgadmin4] 3cd547: Implement column node and its features for foreign...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 3cd547f879ab6679d00564a69b76f76df8cfedcd
  
https://github.com/pgadmin-org/pgadmin4/commit/3cd547f879ab6679d00564a69b76f76df8cfedcd
  Author: Yogesh Mahajan 
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
M docs/en_US/images/foreign_table_columns.png
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/children/__init__.py
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/__init__.py
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/static/img/coll-foreign_table_column.svg
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/static/img/foreign_table_column.svg
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/static/js/foreign_table_column.js
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/alter_column_timestamp_with_default_value_using_function.msql
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/alter_column_timestamp_with_default_value_using_function.sql
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/alter_column_with_integer_generated_always_column_option_variables.msql
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/alter_column_with_integer_generated_always_column_option_variables.sql
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/create_column_timestamp_with_default_value_using_function.msql
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/create_column_timestamp_with_default_value_using_function.sql
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/create_column_with_integer_generated_always_column_option_variables.msql
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/create_column_with_integer_generated_always_column_option_variables.sql
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/test.json
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/__init__.py
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/column_test_data.json
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/alter_column_numeric.msql
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/alter_column_numeric.sql
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/alter_column_text_with_default_value.msql
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/alter_column_text_with_default_value.sql
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/create_column_numeric.msql
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/create_column_numeric.sql
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/create_column_text_with_default_value.msql
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/create_column_text_with_default_value.sql
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/test.json
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/test_ft_column_add.py
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/test_ft_column_delete.py
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/test_ft_column_get.py
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/utils.py
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/static/js/foreign_table.js
M 
web/pgadmin/browser/server_groups/servers/databases/schemas

[pgadmin-org/pgadmin4] f9bbad: Pin the cryptography version to fix PyO3 modules i...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: f9bbadfc6a49ada0269dd5f36b8c0c84e1c9c766
  
https://github.com/pgadmin-org/pgadmin4/commit/f9bbadfc6a49ada0269dd5f36b8c0c84e1c9c766
  Author: Yogesh Mahajan 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M requirements.txt

  Log Message:
  ---
  Pin the cryptography version to fix PyO3 modules initialisation error. #6718

[pgadmin-org/pgadmin4] 7ce07f: Fixed issues reported while testing foreign table ...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 7ce07f7dcfef52ba5a72bd146ce4f05ca67a2ecc
  
https://github.com/pgadmin-org/pgadmin4/commit/7ce07f7dcfef52ba5a72bd146ce4f05ca67a2ecc
  Author: Yogesh Mahajan 
  Date:   2023-10-06 (Fri, 06 Oct 2023)

  Changed paths:
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/pg/12_plus/alter_column_timestamp_with_default_value_using_function.msql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/pg/default/alter_column_numeric.msql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/ppas/12_plus/alter_column_timestamp_with_default_value_using_function.msql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/ppas/default/alter_column_numeric.msql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/static/js/foreign_table.ui.js
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/templates/foreign_table_columns/sql/default/update.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/templates/foreign_tables/sql/default/create.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/templates/foreign_tables/sql/default/foreign_table_schema_diff.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/templates/foreign_tables/sql/default/get_columns.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/templates/foreign_tables/sql/default/update.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/foreign_tables_test_data.json
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/pg/default/alter_add_cons_opts.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/pg/default/alter_add_priv.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/pg/default/alter_col_opts.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/pg/default/alter_col_opts_msql.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/pg/default/alter_comment_add_columns.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/pg/default/alter_comment_add_columns_msql.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/pg/default/alter_remove_opts_priv_cons.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/pg/default/create_foreign_table_with_all_options.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/pg/default/create_foreign_table_with_all_options_msql.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/pg/default/test_foreign_table.json
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/ppas/default/alter_add_cons_opts.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/ppas/default/alter_add_priv.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/ppas/default/alter_col_opts.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/ppas/default/alter_col_opts_msql.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/ppas/default/alter_comment_add_columns.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/ppas/default/alter_comment_add_columns_msql.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/ppas/default/alter_remove_opts_priv_cons.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/ppas/default/create_foreign_table_with_all_options.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/ppas/default/create_foreign_table_with_all_options_msql.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/ppas/default/test_foreign_table.json
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/columns/static/js/column.ui.js
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/columns/utils.py
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/columns/sql/14_plus/properties.sql

  Log Message:
  ---
  Fixed issues reported while testing foreign table node. #640

[pgadmin-org/pgadmin4] 445014: Fixed issues reported while testing foreign table ...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 4450145d31973209deaca8ec78a10e3bdfe4aba2
  
https://github.com/pgadmin-org/pgadmin4/commit/4450145d31973209deaca8ec78a10e3bdfe4aba2
  Author: Yogesh Mahajan 
  Date:   2023-10-11 (Wed, 11 Oct 2023)

  Changed paths:
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/templates/foreign_table_columns/sql/default/create.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/templates/foreign_tables/sql/default/create.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/templates/foreign_tables/sql/default/get_columns.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/templates/foreign_tables/sql/default/properties.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/pg/default/alter_col_opts.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/pg/default/alter_remove_opts_priv_cons.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/ppas/default/alter_col_opts.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/tests/ppas/default/alter_remove_opts_priv_cons.sql

  Log Message:
  ---
  Fixed issues reported while testing foreign table properties. #640

Re: pgAdmin4 v7.8 candidate builds

[Yogesh Mahajan]

Hi Akshay,

One round of installer testing is completed. Version 7.8 can be released.

Thanks,
Yogesh Mahajan
EnterpriseDB


On Wed, Oct 18, 2023 at 3:41 PM Akshay Joshi 
wrote:

> The latest candidate builds and source code is available at
> https://developer.pgadmin.org/builds/2023-10-18-2/
>
> On Tue, Oct 17, 2023 at 5:08 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi All,
>>
>> We have fixed some issues which need a respin. The latest
>> candidate builds and source code is available at
>> https://developer.pgadmin.org/builds/2023-10-17-1/
>>
>> On Mon, Oct 16, 2023 at 4:16 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi All,
>>>
>>> pgAdmin4 v7.8 candidate builds and source code is available at
>>> https://developer.pgadmin.org/builds/2023-10-16-1/
>>>
>>> Yogesh, could you please verify this for Thursday's release?
>>>
>>> --
>>> Akshay Joshi
>>> Principal Software Architect
>>> www.enterprisedb.com
>>>
>>> *Blog*: https://www.enterprisedb.com/akshay-joshi
>>> *GitHub*: https://github.com/akshay-joshi
>>> *LinkedIn*: https://www.linkedin.com/in/akshay-joshi-086497216
>>>
>>

[pgadmin-org/pgadmin4] 1bfd8d: Fix foreign table api test failures for EPAS.

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 1bfd8d7f3ce2779522ed7ff992ed543634188187
  
https://github.com/pgadmin-org/pgadmin4/commit/1bfd8d7f3ce2779522ed7ff992ed543634188187
  Author: Yogesh Mahajan 
  Date:   2023-10-27 (Fri, 27 Oct 2023)

  Changed paths:
M web/pgadmin/authenticate/oauth2.py
A 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/templates/foreign_tables/sql/12_plus/get_columns.sql
M 
web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/templates/foreign_tables/sql/default/get_columns.sql

  Log Message:
  ---
  Fix foreign table api test failures for EPAS.

[pgadmin-org/pgadmin4] a8a757: Fixed circular import error occurring while deploy...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: a8a7574e6912e3dfb7e10d1ac2fbc0ece714
  
https://github.com/pgadmin-org/pgadmin4/commit/a8a7574e6912e3dfb7e10d1ac2fbc0ece714
  Author: Yogesh Mahajan 
  Date:   2023-10-31 (Tue, 31 Oct 2023)

  Changed paths:
M requirements.txt
M web/pgacloud/providers/azure.py
A web/pgacloud/utils/azure_cache.py
M web/pgadmin/misc/cloud/azure/__init__.py
R web/pgadmin/misc/cloud/azure/azure_cache.py

  Log Message:
  ---
  Fixed circular import error occurring while deploying cloud PostgreSQL 
instance from pgAdmin. #6840

Update AWS, Google Cloud lib version.

[pgadmin-org/pgadmin4] 0d8adf: Ensure backup/restore/maintenance works with inval...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 0d8adf9ced6bbcb161340b555141a6e8d9eda6e7
  
https://github.com/pgadmin-org/pgadmin4/commit/0d8adf9ced6bbcb161340b555141a6e8d9eda6e7
  Author: Yogesh Mahajan 
  Date:   2023-11-06 (Mon, 06 Nov 2023)

  Changed paths:
M web/pgadmin/misc/bgprocess/processes.py

  Log Message:
  ---
  Ensure backup/restore/maintenance works with invalid pgpass file parameter. 
#6820

[pgadmin-org/pgadmin4] 370cb6: Clear the password field in the config database on...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 370cb611d791e9c1c9f7e87adfb48b47b2e3262b
  
https://github.com/pgadmin-org/pgadmin4/commit/370cb611d791e9c1c9f7e87adfb48b47b2e3262b
  Author: Yogesh Mahajan 
  Date:   2023-11-09 (Thu, 09 Nov 2023)

  Changed paths:
M web/pgadmin/browser/server_groups/servers/__init__.py

  Log Message:
  ---
  Clear the password field in the config database on clear saved server 
password. #6934

Re: pgAdmin4 v8.0 candidate builds

[Yogesh Mahajan]

Hi Akshay,

One round of installer testing is completed. pgAdmin4 v8.0 can be released.

Thanks,
Yogesh Mahajan
EnterpriseDB


On Mon, Nov 20, 2023 at 7:05 PM Akshay Joshi 
wrote:

> The latest candidate builds and source code is available at
> https://developer.pgadmin.org/builds/2023-11-20-2/
>
> On Mon, Nov 20, 2023 at 1:15 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi All,
>>
>> pgAdmin4 v8.0 candidate builds and source code is available at
>> https://developer.pgadmin.org/builds/2023-11-20-1/
>>
>> Yogesh, could you please verify this for Thursday's release?
>>
>> --
>> Akshay Joshi
>> Principal Software Architect
>> www.enterprisedb.com
>>
>> *Blog*: https://www.enterprisedb.com/akshay-joshi
>> *GitHub*: https://github.com/akshay-joshi
>> *LinkedIn*: https://www.linkedin.com/in/akshay-joshi-086497216
>>
>

[pgadmin-org/pgadmin4] e66cb5: Ensure user is not prompted for password if server...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: e66cb54a5826373d542d17ff02ff147957f48fa3
  
https://github.com/pgadmin-org/pgadmin4/commit/e66cb54a5826373d542d17ff02ff147957f48fa3
  Author: Yogesh Mahajan 
  Date:   2023-11-23 (Thu, 23 Nov 2023)

  Changed paths:
M web/pgadmin/browser/server_groups/servers/__init__.py

  Log Message:
  ---
  Ensure user is not prompted for password if server password is saved and 
server configuration has invalid pgpass file parameter. #6934

[pgadmin-org/pgadmin4] 4e2aa8: Provide a way to bypass the SSL cert verification ...

[Yogesh Mahajan]

  Branch: refs/heads/master
  Home:   https://github.com/pgadmin-org/pgadmin4
  Commit: 4e2aa82ddd3dc9d8096b75d1ac7cc9af4d6072bf
  
https://github.com/pgadmin-org/pgadmin4/commit/4e2aa82ddd3dc9d8096b75d1ac7cc9af4d6072bf
  Author: Yogesh Mahajan 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M docs/en_US/oauth2.rst
M web/config.py
M web/pgadmin/authenticate/oauth2.py

  Log Message:
  ---
  Provide a way to bypass the SSL cert verification for OAuth2 provider. #6095