Re: [pgadmin-hackers] pgAdmin 4 commit: Add support for detachable tabs to the runtime.

[Strauch, Sheldon]

YES!

This changes EVERYTHING!

On Fri, Jun 16, 2017 at 7:47 AM, Robert Eckhardt 
wrote:

> Nice! This is awesome. I didn't see it land.
>
> -- Rob
>
> On Fri, Jun 16, 2017 at 1:57 AM, Dave Page  wrote:
>
>> Add support for detachable tabs to the runtime.
>>
>> This allows the Query Tool, Debugger and web browser tabs to be moved to
>> different monitors as desired.
>>
>> Fixes #1344
>>
>> Branch
>> --
>> master
>>
>> Details
>> ---
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>> f;h=0056a94115416c12690f58af3b77b9ce7c02da95
>> Author: Neel Patel 
>>
>> Modified Files
>> --
>> runtime/BrowserWindow.cpp | 337 +---
>> runtime/BrowserWindow.h   |  15 +-
>> runtime/TabWindow.cpp | 542 ++
>> +---
>> runtime/TabWindow.h   | 151 -
>> runtime/WebViewWindow.cpp |  82 +++
>> runtime/WebViewWindow.h   |  17 +-
>> runtime/back.png  | Bin 448 -> 290 bytes
>> runtime/close.png | Bin 587 -> 346 bytes
>> runtime/forward.png   | Bin 445 -> 270 bytes
>> runtime/pgAdmin4.cpp  |  15 +-
>> runtime/pgAdmin4.qrc  |   1 +
>> runtime/qss/pgadmin4.qss  |   3 +
>> 12 files changed, 937 insertions(+), 226 deletions(-)
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hack...@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>


-- 

Assumptions validated by consistent data from actual experiments enable the
creation of real value.

Sheldon E. Strauch
*Data Architect, Data Services *
*O* 312-676-1556
*M* 224-723-3878

*Enova International, Inc.*
*This transmission is confidential and may be privileged or proprietary. If
you are not the intended recipient, you are not authorized to use the
information in this transmission in any way. Please inform the sender
immediately if you have received this transmission in error and permanently
delete and destroy the original and any copies of the information.*

Re: Tree view icon samples

[Strauch, Sheldon]

Dave et al,

Might I suggest flipping the foreign key icon left for right? That way, the
key "points" to the left, back toward something pre-existing whilst the
primary key "points" to the right, forward towards something new?

Also, for me, the updated index icon loses its intuitiveness as it suggests
an ordinal list or an enumeration. I think the clue in the old icon was the
index tab at the top of the illustration.

Finally, the new trigger icon suggests, to me, that one is trying to do
something with a document, maybe copying it. Whereas the old icon suggests
an action to be taken.

Just my two cents...

On Fri, Jun 30, 2017 at 9:57 AM, Dave Page  wrote:

> Hi
>
> - The Primary Key and Foreign Key icons should have more differentiation
> than just colour. Maybe add a 1 to Primary Key?
>
> - Did you get a list of the other icons that aren't on that sheet yet?
>
> - I'm not sure I like the Casts and Conversions icons (mis-spelt as
> Converts by the previous owner). The text on the makes them seem textual
> than graphical.
>
> Thanks!
>
> On Fri, Jun 30, 2017 at 12:56 PM, Chethana Kumar <
> chethana.ku...@enterprisedb.com> wrote:
>
>> Hi Team,  Attachment was missing.
>>
>>
>>
>> On Fri, Jun 30, 2017 at 5:24 PM, Chethana Kumar <
>> chethana.ku...@enterprisedb.com> wrote:
>>
>>> Hello Team,
>>>
>>> Below are the updates for TreeView Icons -
>>>
>>> 1. Fine tuned the icons - Database, Language, Primary and Foreign key,
>>> Unique Constraint
>>> 2. Designed new concept for - Casts and Converts, Trigger
>>> 3. Attached the color blind test result for "Primary and Foreign key",
>>> now I feel it is pretty evident to differentiate for blind user
>>> 4. Attached "thought_process.png" where I have explained the thought
>>> process for newly proposed icons (referred:www.postgresql.org)
>>> 5. Added little depth to all icons to provide the Afforance of Click
>>>
>>>
>>>
>>>
>>>
>>>
>>> On Thu, Jun 29, 2017 at 10:21 AM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>

 On Thu, Jun 29, 2017 at 9:09 AM, Chethana Kumar <
 chethana.ku...@enterprisedb.com> wrote:

> Hi Ashesh,
>
> I tried to eliminate the colour blind issue which might occur with the
> primary & foregin key icons.
> But still I will use the app to test the colors, just let me know your
> opinion now.
>
 Please do.

 One more point: :-)
 Icons for some nodes are missing here.
 i.e. Partition table (introduced in 'Declarative Partition' patch),
 Materialized View, etc.

 -- Thanks, Ashesh

>
> Regards,
> Chethana kumar
>
> On Wed, Jun 28, 2017 at 11:13 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Jun 28, 2017 22:32, "Robert Eckhardt" 
>> wrote:
>>
>> I like them as well. The only comment I have is that the red icon on
>> disconnected DB and corrupted DB are difficult to make out. They are
>> clearly differentiable but the icon itself is unclear.
>>
>> A colour blind person may not be able to differentiate the primary &
>> foreign key icons.
>>
>> -- Ashesh
>>
>>
>> -- Rob
>>
>> On Wed, Jun 28, 2017 at 12:49 PM, Dave Page 
>> wrote:
>>
>>> Hi
>>>
>>> > On 28 Jun 2017, at 12:41, Chethana Kumar <
>>> chethana.ku...@enterprisedb.com> wrote:
>>> >
>>> > Hi Team,
>>> >
>>> > I am coming up with some sample icons for Tree View Control.
>>> >
>>> > Thought process behind the concept -
>>> >
>>> > 1. Included EDB color brand feel (gray and blue colors)
>>>
>>> You mean pgAdmin colour brand :-). EDB is orange & black.
>>>
>>> > 2. Eliminated the distraction of too many colors and provided
>>> consistency through the icons
>>> > 3. User will recognize the icon shapes rather than recalling it by
>>> their colors (like in existing icons) so focused more on shapes
>>> > 4. It also adds value to the brand since it has EDB color tones in
>>> it
>>> >
>>> >
>>> > So please feel free to share your views on the same
>>>
>>> I like them - they look much more modern and stylish, but still fit
>>> with what they represent.
>>>
>>> Other opinions please?
>>>
>>> Good work!
>>>
>>
>>
>>
>
>
> --
> Chethana Kumar
> Principal UI/UX Designer
> EnterpriseDB Corporation
>
>
> The Postgres Database Company
>
> P: +91 86981 57146 <+91%2086981%2057146>
> www.enterprisedb.com
>


>>>
>>>
>>> --
>>> Chethana Kumar
>>> Principal UI/UX Designer
>>> EnterpriseDB Corporation
>>>
>>>
>>> The Postgres Database Company
>>>
>>> P: +91 86981 57146 <+91%2086981%2057146>
>>> www.enterprisedb.com
>>>
>>
>>
>>
>> --
>> Chethana Kumar
>> Principal UI/UX Designer
>> EnterpriseDB Corporation
>>
>>
>> The Postgres Database Company
>>
>> P: +91 86981 57146 <+91%2086981%2057146>
>> www.e

Re: [pgAdmin][RM3782] Debugger title should show connection and object details

[Strauch, Sheldon]

FWIW:

   - +1 for INDEPENDENTLY configurable tab title AND tooltip
   - I agree that in-place edit of tabs cost/benefit isn't there, unless
   someone wants a personal free-time project


On Wed, Jun 12, 2019 at 4:44 AM Dave Page  wrote:

> Hi
>
> On Wed, Jun 12, 2019 at 10:02 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> On Wed, Jun 12, 2019 at 1:54 PM Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Wed, Jun 12, 2019 at 7:03 AM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Attached is the patch to add more information on connection details to
 debugger panel title and content title similar to Query Tool and View/Edit
 data.
 Adding the object name with arguments is not a good idea for the panel
 title, so I have kept to connection details similar to query tool. The
 content title will have all the details.

 Kindly review.

>>>
>>> I think not having the function name in there is a big limitation.
>>>
>>> With all this hacking going on, I think what we need to do is stop and
>>> make this configurable as has been both requested by users and suggested by
>>> us.
>>>
>>> I propose adding 2 preference options for each tab type. Each of these
>>> would be a string with placeholders, one for the tab title, and one for the
>>> tab tooltip. For example:
>>>
>>> - Query Tool
>>>   * Placeholders: %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST%
>>>   * Tab title default: %DATABASE% on %SERVER%
>>>   * Tooltip title default: Query Tool: %DATABASE% on %USERNAME%@%SERVER%
>>>
>>> - View Data
>>>   * Placeholders: %TABLE%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%,
>>> %PORT%, %HOST%
>>>   * Tab title default: %SCHEMA%.%TABLE% in %DATABASE% on %SERVER%
>>>   * Tooltip title default: View/Edit Data: %SCHEMA%.%TABLE%
>>> in %DATABASE% on %USERNAME%@%SERVER%
>>>
>>> - Script
>>>   * Placeholders: %ACTION%, %OBJECT%, %SCHEMA%, %DATABASE%, %SERVER%,
>>> %USERNAME%, %PORT%, %HOST%
>>>   * Tab title default: %ACTION% %SCHEMA%.%OBJECT% in %DATABASE% on
>>> %SERVER%
>>>   * Tooltip title default: %ACTION% Script: %SCHEMA%.%OBJECT%
>>> in %DATABASE% on %USERNAME%@%SERVER%
>>>
>>> - Debugger
>>>   * Placeholders: %FUNCTION_ARGS%, %FUNCTION_NOARGS%, %SCHEMA%,
>>> %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST%
>>>   * Tab title default: %FUNCTION_NOARGS%.%OBJECT% in %DATABASE% on
>>> %SERVER%
>>>   * Tooltip title default: Debugger: %SCHEMA%.%FUNCTION_ARGS%
>>> in %DATABASE% on %USERNAME%@%SERVER%
>>>
>>> Or something like that. Thoughts?
>>>
>> Yes, this could be a nice feature. I think tooltip title customisation is
>> not needed, we can just set it as  prefix + tab title.
>>
>
> I think having it be separate is useful - you can include full information
> there, but keep the tab minimal so as not to create huge tabs. For example,
> the debugger tab could just be set to %FUNCTION_NOARGS%, whilst the tooltip
> has the full string.
>
>
>> Some users asked for in-place rename of tab title. I'm not sure if it is
>> feasible to implement, but should we consider it also ?
>>
>
> No - I've only seen one request for that, and it seems like a lot of work
> for little gain.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> 
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> 
> The Enterprise PostgreSQL Company
>


-- 

Look after your data, and your database will look after you. -- Simon Riggs

Sheldon E. Strauch
*Data Architect, Data Services *
*O* 312-676-1556
*M* 224-723-3878

*Enova International, Inc.*
*This transmission is confidential and may be privileged or proprietary. If
you are not the intended recipient, you are not authorized to use the
information in this transmission in any way. Please inform the sender
immediately if you have received this transmission in error and permanently
delete and destroy the original and any copies of the information.*