[pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others
Hi Hackers, Attached is the patch to move "Delete/Drop" menu option away from "Disconnect Servers" for server node. Additionally, I have renamed the "Delete/Drop" menu option to "Remove Server" for server node against issue RM3859. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation | Pune. RM3279_3859.patch Description: Binary data
[pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View
Hi Hackers, I have attached the patch for RE-SQL/MSQL test cases for View as well as Materialized View. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM4696.patch Description: Binary data
[RM4396] Definition update of MATERIALIZED VIEW loses indexes
Hi Hackers, Please find the patch for the materialized view as per defined in the bug. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM4396.patch Description: Binary data
[RM3645] Start and End Date does not delete for Schedules in pgAgent Job
Hi Hackers, Please find the patch for pgagents schedules dates issue. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM3645.patch Description: Binary data
[pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure
Hi Hackers, Please find the attached patch which fixes pg/ppas issues listed below: 1. Stored procedure code indentation. 2. Functions code indentation. 3. Trigger Functions code indentation. Please review. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM3851_v1.patch Description: Binary data
Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure
Hi Akshay, I have made the relevant changes for existing and the new procedure, functions & triggers. Please find the patch. On Thu, Jun 25, 2020 at 12:21 PM Akshay Joshi wrote: > Hi Rahul > > I have tested your patch and the issue is not fixed. Create one Procedure, > Function, and Trigger Function using below code *without* applying your > patch: > BEGIN > SELECT 1; > END; > > Then apply your patch and check the SQL tab. > > On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch which fixes pg/ppas issues listed below: >> >>1. Stored procedure code indentation. >>2. Functions code indentation. >>3. Trigger Functions code indentation. >> >> Please review. >> >> -- >> *Rahul Shirsat* >> Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM3851_v2.patch Description: Binary data
Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure
Akshay, Ignore the above patch, reconsider this latest patch with some optimizations. On Sat, Jun 27, 2020 at 1:50 AM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Akshay, > > I have made the relevant changes for existing and the new procedure, > functions & triggers. > > Please find the patch. > > On Thu, Jun 25, 2020 at 12:21 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Rahul >> >> I have tested your patch and the issue is not fixed. Create one >> Procedure, Function, and Trigger Function using below code *without* >> applying your patch: >> BEGIN >> SELECT 1; >> END; >> >> Then apply your patch and check the SQL tab. >> >> On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat < >> rahul.shir...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the attached patch which fixes pg/ppas issues listed below: >>> >>>1. Stored procedure code indentation. >>>2. Functions code indentation. >>>3. Trigger Functions code indentation. >>> >>> Please review. >>> >>> -- >>> *Rahul Shirsat* >>> Software Engineer | EnterpriseDB Corporation. >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM3851_v3.patch Description: Binary data
Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure
Corrected some indentations. Find the patch below. On Sun, Jun 28, 2020 at 9:21 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Akshay, > > Ignore the above patch, reconsider this latest patch with some > optimizations. > > On Sat, Jun 27, 2020 at 1:50 AM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> I have made the relevant changes for existing and the new procedure, >> functions & triggers. >> >> Please find the patch. >> >> On Thu, Jun 25, 2020 at 12:21 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Rahul >>> >>> I have tested your patch and the issue is not fixed. Create one >>> Procedure, Function, and Trigger Function using below code *without* >>> applying your patch: >>> BEGIN >>> SELECT 1; >>> END; >>> >>> Then apply your patch and check the SQL tab. >>> >>> On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat < >>> rahul.shir...@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Please find the attached patch which fixes pg/ppas issues listed below: >>>> >>>>1. Stored procedure code indentation. >>>>2. Functions code indentation. >>>>3. Trigger Functions code indentation. >>>> >>>> Please review. >>>> >>>> -- >>>> *Rahul Shirsat* >>>> Software Engineer | EnterpriseDB Corporation. >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> *Rahul Shirsat* >> Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM3851_v4.patch Description: Binary data
[pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)
Hi Hackers, Please find the attached patch which fixes the issue related to the partition table with storage parameters. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5569.patch Description: Binary data
[pgAdmin4][Patch] - SonarQube Fixes
Hi Hackers, Please find the attached patch to fix the SonarQube Code smells having Rule "Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed". -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. event_trigger_sonar_fixes.patch Description: Binary data
Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)
Hi Hackers, Following patch includes fix for : Storage parameters should be displayed in parent tables's SQL. As the code will be upgraded in feature #5649 <https://redmine.postgresql.org/issues/5649>, so only initial test cases for pg 10, 11 are included in this patch, so later it can be continued with the latest code. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. On Mon, Jul 6, 2020 at 2:27 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Rahul, > > - The storage parameters should be displayed in the parent table's SQL too > - Please write test cases, preferably re-sql test cases > > Thanks, > Khushboo > > On Mon, Jul 6, 2020 at 11:28 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo, >> >> Can you please review it. >> >> On Sat, Jul 4, 2020 at 1:45 AM Rahul Shirsat < >> rahul.shir...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the attached patch which fixes the issue related to the >>> partition table with storage parameters. >>> >>> -- >>> *Rahul Shirsat* >>> Software Engineer | EnterpriseDB Corporation. >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5569_v2.patch Description: Binary data
[pgAdmin][SonarQube] Critical issue fixes - servers
Hi Hackers, Please find the attached patch which includes sonarqube fixes : 1. Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed for *check_ssl_fields* in servers/__init__.py 2. Refactor this function to reduce its Cognitive Complexity from 25 to the 15 allowed for *update *in servers/__init__.py *Note: Changes were tested in both Server mode & Desktop mode respectively.* -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. server-cognitive-comp-part-01.patch Description: Binary data
Re: [pgAdmin][SonarQube] Critical issue fixes - servers
Hi Hackers, Please find the updated patch below which fixes the issue in sslcompression changes. On Thu, Jul 9, 2020 at 4:46 PM Rahul Shirsat wrote: > Hi Hackers, > > Please find the attached patch which includes sonarqube fixes : > > 1. Refactor this function to reduce its Cognitive Complexity from 18 to > the 15 allowed > for *check_ssl_fields* in servers/__init__.py > 2. Refactor this function to reduce its Cognitive Complexity from 25 to > the 15 allowed > for *update *in servers/__init__.py > > *Note: Changes were tested in both Server mode & Desktop mode > respectively.* > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. server-cognitive-comp-part-01_v2.patch Description: Binary data
Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)
Hi Khushboo, I had already corrected the patch as soon as I saw your mail, but couldn't send you as I went out on an urgency. Now sending it. On Fri, Jul 10, 2020 at 10:25 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Rahul, > > I am getting errors while applying the patch, please rebase the patch and > send it again. > > Thanks, > Khushboo > > On Thu, Jul 9, 2020 at 1:25 PM Akshay Joshi > wrote: > >> Hi Khushboo >> >> Can you please review it. >> >> On Wed, Jul 8, 2020 at 6:12 PM Rahul Shirsat < >> rahul.shir...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Following patch includes fix for : >>> >>> Storage parameters should be displayed in parent tables's SQL. >>> >>> As the code will be upgraded in feature #5649 >>> <https://redmine.postgresql.org/issues/5649>, so only initial test >>> cases for pg 10, 11 are included in this patch, so later it can be >>> continued with the latest code. >>> >>> -- >>> *Rahul Shirsat* >>> Software Engineer | EnterpriseDB Corporation. >>> >>> On Mon, Jul 6, 2020 at 2:27 PM Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> >>>> Hi Rahul, >>>> >>>> - The storage parameters should be displayed in the parent table's SQL >>>> too >>>> - Please write test cases, preferably re-sql test cases >>>> >>>> Thanks, >>>> Khushboo >>>> >>>> On Mon, Jul 6, 2020 at 11:28 AM Akshay Joshi < >>>> akshay.jo...@enterprisedb.com> wrote: >>>> >>>>> Hi Khushboo, >>>>> >>>>> Can you please review it. >>>>> >>>>> On Sat, Jul 4, 2020 at 1:45 AM Rahul Shirsat < >>>>> rahul.shir...@enterprisedb.com> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> Please find the attached patch which fixes the issue related to the >>>>>> partition table with storage parameters. >>>>>> >>>>>> -- >>>>>> *Rahul Shirsat* >>>>>> Software Engineer | EnterpriseDB Corporation. >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> >>>>> *Sr. Software Architect* >>>>> *EnterpriseDB Software India Private Limited* >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>> >>> -- >>> *Rahul Shirsat* >>> Software Engineer | EnterpriseDB Corporation. >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5569_v3.patch Description: Binary data
[pgAdmin][RM5646] User can not see RLS policies in the search object
Hi Hackers, Please find the patch below which fixes the issue of searching RLS policies in search objects. It also fixes the additional issue of search objects for RLS policies navigating to appropriate nodes by double clicking the found object. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5646.patch Description: Binary data
Re: [pgAdmin][RM5646] User can not see RLS policies in the search object
Hi Hackers, Just for the information, the additional issue was the *incorrect node path set in RLS policy*, and not the search objects itself. On Tue, Jul 21, 2020 at 9:23 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the patch below which fixes the issue of searching RLS > policies in search objects. > > It also fixes the additional issue of search objects for RLS policies > navigating to appropriate nodes by double clicking the found object. > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation.
[pgAdmin][RM5632] Cannot specify start with value during setup of an identity column
Hi Hackers, Please find the patch below which fixes the issue of Start value while updating the identity column. *Some additional issues were also found during development, which are too fixed now :* 1. While changing of identity (*ALWAYS / BY DEFAULT*) including *sequence options, it only updates identity* - *Fixed* 2. *Cycled option issue - **Fixed* Steps to reproduce : - Update cycled to Yes, save it. - Now change it to No, trying saving, gives error. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5632.patch Description: Binary data
Re: [pgAdmin][RM5632] Cannot specify start with value during setup of an identity column
Hi Hackers, Ignore the previous patch. Find below the rebased patch. On Wed, Jul 29, 2020 at 2:36 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the patch below which fixes the issue of Start value while > updating the identity column. > > *Some additional issues were also found during development, which are too > fixed now :* > > >1. While changing of identity (*ALWAYS / BY DEFAULT*) including *sequence >options, it only updates identity* - *Fixed* >2. *Cycled option issue - **Fixed* >Steps to reproduce : >- Update cycled to Yes, save it. >- Now change it to No, trying saving, gives error. > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5632_v2.patch Description: Binary data
Re: [pgAdmin][RM5632] Cannot specify start with value during setup of an identity column
Hi Akshay, A syntactical error in a jinja template caught yesterday in Yogesh's local setup of pgAdmin by running a test suite for the changes done in this RM. It's strange going through several testings, even on Jenkins, it passed but failed on Yogesh's machine. I have made changes for this issue and rechecked with Yogesh, which seems to be fixed now. Could you please apply these relevant changes for this RM? On Wed, Jul 29, 2020 at 6:31 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Jul 29, 2020 at 3:52 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Ignore the previous patch. Find below the rebased patch. >> >> On Wed, Jul 29, 2020 at 2:36 PM Rahul Shirsat < >> rahul.shir...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the patch below which fixes the issue of Start value while >>> updating the identity column. >>> >>> *Some additional issues were also found during development, which are >>> too fixed now :* >>> >>> >>>1. While changing of identity (*ALWAYS / BY DEFAULT*) including *sequence >>>options, it only updates identity* - *Fixed* >>> 2. *Cycled option issue - **Fixed* >>>Steps to reproduce : >>>- Update cycled to Yes, save it. >>>- Now change it to No, trying saving, gives error. >>> >>> -- >>> *Rahul Shirsat* >>> Software Engineer | EnterpriseDB Corporation. >>> >> >> >> -- >> *Rahul Shirsat* >> Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Sr. Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5632_v3.patch Description: Binary data
Bug #5664 SQL DDL output generator for view
Hi Hackers, Please find the attached patch below which resolves the following issue of SQL DDL output generator for view (preserving default values of columns) Also, when changing VIEW's column's default value, the SQL generates ALTER TABLE, now this would be as ALTER VIEW instead. This fix could not be associated with its test cases, as the changes are related to VIEW's column, in which we cannot add columns to the VIEW and test it. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5664.patch Description: Binary data
[pgAdmin4][Patch] - SonarQube Fixes #2
Hi Hackers, Please find the attached patch to fix the SonarQube Code smells having Rule: 1. Define a constant instead of duplicating this literal "browser/css/node.css" 4 times. 2. Define a constant instead of duplicating this literal "The specified table could not be found." 10 times. 3. Define a constant instead of duplicating this literal 'get_columns_for_table.sql' 3 times. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. sonar_qube_table_init.patch Description: Binary data
Re: [pgAdmin4][Patch] - SonarQube Fixes #2
Hi Akshay, Please find the updated patch attached in this email. On Wed, Aug 19, 2020 at 2:40 PM Akshay Joshi wrote: > Hi Rahul > > I have committed Khushboo's patch where she has introduced a new method > 'not_found_error_msg', so instead of creating a new constant > 'TABLE_NOT_FOUND_MSG' use self.not_found_error_msg. > Done > > Also, instead of > _NODE_CSS = ‘node.css’ > _COLLECTION_CSS = ‘collection.css’ > > We can use the following: > _NODE_CSS = _BROWSER_CSS_PATH + ‘/node.css’ > _COLLECTION_CSS = _BROWSER_CSS_PATH + ‘/collection.css’ > Done > > > Make the above changes and resend the patch. > > On Fri, Aug 14, 2020 at 8:34 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch to fix the SonarQube Code smells having >> Rule: >> >> >>1. Define a constant instead of duplicating this literal >>"browser/css/node.css" 4 times. >>2. Define a constant instead of duplicating this literal "The >> specified table could not be found." 10 times. >>3. Define a constant instead of duplicating this literal >>'get_columns_for_table.sql' 3 times. >> >> -- >> *Rahul Shirsat* >> Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Sr. Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. sonar_qube_table_init_v2.patch Description: Binary data
Re: #4059 Query tool new tab recurrence
*Removing DL not related PG directly.* ++pgadmin-hackers. On Thu, Aug 27, 2020 at 1:48 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Dave, > > Working on one of the features #4059 > <https://redmine.postgresql.org/issues/4059>, assume that query tool is > open in a new tab, and the main application window is closed, with the help > of Nidhi, I was able to write a warning popup message as given below: > > [image: Screen Shot 2020-08-27 at 12.08.58 PM.png] > > Can we go ahead with this message or else could you please suggest if you > have any? > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation.
[pgAdmin][Patch] #5746 setup.py --load-server does not allow loading connections that use pg_services
Hi Hackers, Please find the attached patch below which fixes the issue regarding --load-servers having service based server connection. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5746.patch Description: Binary data
[pgAdmin] Bug #5831 Internal server error displayed if user open query tool window inside view data
Hi Hackers, Please find the attached patch which fixes the open query tool window inside view data. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5831.patch Description: Binary data
Re: [pgAdmin] Bug #5831 Internal server error displayed if user open query tool window inside view data
Hi Hackers, Please find below fixes : 1. Query editor via view/edit data - fixed panel title issue. 2. Fixed Schema diff panel title on new tab. On Mon, Sep 14, 2020 at 2:28 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch which fixes the open query tool window > inside view data. > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5831_v2.patch Description: Binary data
[pgAdmin][RM3318] Download Backup Files
Hi Hackers, Please find the below patch which allows users to download the backup and export files generated on shared drive. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM3318.patch Description: Binary data
Re: [pgAdmin][RM3318] Download Backup Files
Hi Akshay, Please find below comments on review points. On Wed, Oct 21, 2020 at 4:56 PM Akshay Joshi wrote: > Hi Rahul > > Following are the review comments: > >- Add "..." to the Storage Manager menu - *DONE* >- Storage manager icon is not visible on process watcher if we provide >file name without directory. - *DONE* >- Renaming the directory not working from Storage Manager. - As >discussed in scrum update on 23'Oct, this issue would be taken care in >RM5943 <https://redmine.postgresql.org/issues/5943> > > Please fix and send the patch. > > On Tue, Oct 20, 2020 at 9:27 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the below patch which allows users to download the backup and >> export files generated on shared drive. >> >> -- >> *Rahul Shirsat* >> Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Sr. Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM3318_v3.patch Description: Binary data
[pgAdmin][RM5736] Validation error msg showing twice on create table- add column.
Hi Hackers, Please find the below patch which resolves the duplicate error message for create table - add column. The fix made is such that only when Variables, Security tab adds/changes any required field, the whole row (of column) will be highlighted and prompt the user to fulfill the requirements. Row will not be highlighted when the column name and type is added/changed. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5736.patch Description: Binary data
IPV6 setup #RM5582
Hi Dave, Do you have IPV6 setup done on your machine? I wanted to test RM5582 - Cannot SSH tunnel over IPv6 with identity file <https://redmine.postgresql.org/issues/5582> but unable to do so. I had even tried to create the global IPV6 address which is not accessible across the VM (neither Windows nor Ubuntu even after setting up radvd). Even my internet service provider does not provide the global address (only link-local address). For now, I have suggested the author of the issue to test from his end. But to verify from our side, can you give some thought on this? -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation.
SonarQube Fixes #3
Hi Hackers, Please find the attached patch to fix the SonarQube code smells having rules: - Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed. Also, corrected one of the backup test cases which were failing in server mode. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. sonar_issues_process.patch Description: Binary data
Re: SonarQube Fixes #3
Hi Hackers, Minor sonar issues too fixed. Find the updated patch. On Mon, Nov 9, 2020 at 2:53 PM Rahul Shirsat wrote: > Hi Hackers, > > Please find the attached patch to fix the SonarQube code smells having > rules: > >- Refactor this function to reduce its Cognitive Complexity from 24 to >the 15 allowed. > > Also, corrected one of the backup test cases which were failing in server > mode. > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. sonar_bgprocess_issues_v2.patch Description: Binary data
Re: SonarQube Fixes #3 + RM5985[pgAdmin4] Bgprocess watcher dialog box disappers and error occurs after server is removed
Hi Hackers, Please find below attached patch which fixes: 1. Bgprocess watcher dialog box disappearing after server is removed 2. Removed 3 dots on Storage Manager Dialog box (Storage Manager... to Storage Manager) 3. Previous sonarqube issues carry forward in this patch. Rest I haven't got any user_old specific issues while removing the orphan process, I think, programmatically, it is handled. Note: Previous sonarqube issue in this mail trace is also considered in this patch due to many similar file changes. On Tue, Nov 10, 2020 at 1:59 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Minor sonar issues too fixed. Find the updated patch. > > On Mon, Nov 9, 2020 at 2:53 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch to fix the SonarQube code smells having >> rules: >> >>- Refactor this function to reduce its Cognitive Complexity from 24 >>to the 15 allowed. >> >> Also, corrected one of the backup test cases which were failing in server >> mode. >> >> -- >> *Rahul Shirsat* >> Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5985.patch Description: Binary data
[pgAdmin4] RM5943 Implement folder rename in Storage Manager
Hi Hackers, Please find the attached patch which implements renaming a folder in Storage Manager. *Also fixed a minor issue when:* User clicks the rename button (for file & folder both) and without renaming it, clicks anywhere, the file name becomes blank - *Resolved* -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5943.patch Description: Binary data
SameSite issues in Safari Browser (reference #RM5975)
Hi Dave, Due to SameSite security issues in Safari Browser, some of the pgadmin4 functionality isn't working (mostly the new tab functionality). The affected Safari Browser versions (marked in red) currently tested upon are: 1. v11.1.2 2. v12.1 3. v12.1.1 4. 13.1 5. 14.0.1 Since v12, Safari have done some security fixes, due to which this issue has occurred. Strangely, the issue is not reproducible on v13, but reproducible on its successor i.e. v14 Possible solutions could be: 1. Reporting this to Safari & raising an RM for tracking purposes. 2. Suggesting Safari users to make below changes in config.py or config_distro for the work around: *SESSION_COOKIE_SAMESITE = None* *SESSION_COOKIE_SECURE = True* (As we aren't going through any cross-site cookie transfer, this can be a handy option - but still risky..) I would suggest going with the 1st option or combination of both, but with caution. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation.
Re: SameSite issues in Safari Browser (reference #RM5975)
Yes Akshay. I think we should go ahead adding this approach in the pgadmin faqs, we would not be fixing this in our code as we don't know when Apple would fix its issue. On Thu, Nov 26, 2020 at 11:27 AM Akshay Joshi wrote: > Hi Rahul > > On Wed, Nov 25, 2020 at 4:07 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Due to SameSite security issues in Safari Browser, some of the pgadmin4 >> functionality isn't working (mostly the new tab functionality). >> >> The affected Safari Browser versions (marked in red) currently tested >> upon are: >> >>1. v11.1.2 >>2. v12.1 >>3. v12.1.1 >>4. 13.1 >>5. 14.0.1 >> >> Since v12, Safari have done some security fixes, due to which this issue >> has occurred. Strangely, the issue is not reproducible on v13, but >> reproducible on its successor i.e. v14 >> >> Possible solutions could be: >> >>1. Reporting this to Safari & raising an RM for tracking purposes. >>2. Suggesting Safari users to make below changes in config.py or >>config_distro for the work around: >> >> *SESSION_COOKIE_SAMESITE = None* >> >> *SESSION_COOKIE_SECURE = True* >> (As we aren't going through any cross-site cookie transfer, this can be a >> handy option - but still risky..) >> >> I would suggest going with the 1st option or combination of both, but >> with caution. >> > >In my opinion, we should go with both the options, as we have added the > above settings for security purposes. > >> >> -- >> *Rahul Shirsat* >> Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation.
Unable to download macros query results (reference #RM5965)
Hi Team, Users are unable to download macros query results. *Lets look out how download query result button works:* For pgadmin4, always downloads the latest query result when the user makes n-number of sql changes in the query tool, no need to execute, download takes care of it. Does not work with macros as query is needed in the query tool, which macros does not provide (While feature implementation, it was decided that macros query won't be added to the query tool, as users may lose any important queries in it). In pgadmin3, always the last executed query result gets downloaded even if the user makes n-number of sql changes in the query tool. Works with macros. For the latest query change results, the user has to first execute before every download. For Macros, with the pgadmin4 approach, even if we implement a download option, it would be difficult to decide whether to download the already ran macros or to download the query result present in the query tool. Please suggest. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation.
Re: SameSite issues in Safari Browser (reference #RM5975)
Dave, There are issues discussed on Apple forums, check this out: https://developer.apple.com/forums/thread/129064 - The latest comment by the user here is one month ago, meaning the issue is still not fixed yet. https://developer.apple.com/forums/thread/658688 - Users facing this issue in v13.x Even webkit has confirmed about this issue : https://bugs.webkit.org/show_bug.cgi?id=198181 - Users facing this issue in v12.x On Thu, Nov 26, 2020 at 6:57 PM Dave Page wrote: > Hi > > On Wed, Nov 25, 2020 at 10:37 AM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Due to SameSite security issues in Safari Browser, some of the pgadmin4 >> functionality isn't working (mostly the new tab functionality). >> >> The affected Safari Browser versions (marked in red) currently tested >> upon are: >> >>1. v11.1.2 >>2. v12.1 >>3. v12.1.1 >>4. 13.1 >>5. 14.0.1 >> >> Since v12, Safari have done some security fixes, due to which this issue >> has occurred. Strangely, the issue is not reproducible on v13, but >> reproducible on its successor i.e. v14 >> >> Possible solutions could be: >> >>1. Reporting this to Safari & raising an RM for tracking purposes. >>2. Suggesting Safari users to make below changes in config.py or >>config_distro for the work around: >> >> *SESSION_COOKIE_SAMESITE = None* >> >> *SESSION_COOKIE_SECURE = True* >> (As we aren't going through any cross-site cookie transfer, this can be a >> handy option - but still risky..) >> >> I would suggest going with the 1st option or combination of both, but >> with caution. >> > > Others must have come across this issue already. Is it a known bug, > documented somewhere (ideally on apple.com)? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation.
Re: SameSite issues in Safari Browser (reference #RM5975)
This was the part of our internal quality testing, where it got encountered. Currently, none of the users have complained about this on their specific browser versions. On Mon, Nov 30, 2020 at 5:12 PM Dave Page wrote: > Hi > > On Mon, Nov 30, 2020 at 7:12 AM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Dave, >> >> There are issues discussed on Apple forums, check this out: >> >> https://developer.apple.com/forums/thread/129064 - The latest comment by >> the user here is one month ago, meaning the issue is still not fixed yet. >> https://developer.apple.com/forums/thread/658688 - Users facing this >> issue in v13.x >> >> Even webkit has confirmed about this issue : >> https://bugs.webkit.org/show_bug.cgi?id=198181 - Users facing this issue >> in v12.x >> > > In that case, I think the answer (for now at least) is an FAQ, referencing > those issues and explaining how to resolve the issue using config_system.py > or by using a different browser. > > Have we actually seen this issue in wild? > > > >> >> On Thu, Nov 26, 2020 at 6:57 PM Dave Page wrote: >> >>> Hi >>> >>> On Wed, Nov 25, 2020 at 10:37 AM Rahul Shirsat < >>> rahul.shir...@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> Due to SameSite security issues in Safari Browser, some of the pgadmin4 >>>> functionality isn't working (mostly the new tab functionality). >>>> >>>> The affected Safari Browser versions (marked in red) currently tested >>>> upon are: >>>> >>>>1. v11.1.2 >>>>2. v12.1 >>>>3. v12.1.1 >>>>4. 13.1 >>>>5. 14.0.1 >>>> >>>> Since v12, Safari have done some security fixes, due to which this >>>> issue has occurred. Strangely, the issue is not reproducible on v13, but >>>> reproducible on its successor i.e. v14 >>>> >>>> Possible solutions could be: >>>> >>>>1. Reporting this to Safari & raising an RM for tracking purposes. >>>>2. Suggesting Safari users to make below changes in config.py or >>>>config_distro for the work around: >>>> >>>> *SESSION_COOKIE_SAMESITE = None* >>>> >>>> *SESSION_COOKIE_SECURE = True* >>>> (As we aren't going through any cross-site cookie transfer, this can be >>>> a handy option - but still risky..) >>>> >>>> I would suggest going with the 1st option or combination of both, but >>>> with caution. >>>> >>> >>> Others must have come across this issue already. Is it a known bug, >>> documented somewhere (ideally on apple.com)? >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EDB: http://www.enterprisedb.com >>> >>> >> >> -- >> *Rahul Shirsat* >> Software Engineer | EnterpriseDB Corporation. >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation.
Re: SameSite issues in Safari Browser (reference #RM5975)
Hi Dave,
Could you please add below FAQ point for SameSite Safari issue:
Question :
When I set new tab settings for query tool or schema-diff, I get
"Connection to server lost" or "CSRF tokens do not match" on Safari
versions >= 12
Answer:
This has been seen mostly on Safari browser versions >= 12. It's
reported that from v12 of CFNetwork/Safari/Webkit erroneously handle
"Samesite=none" as the equivalent of "Samesite=strict". It means, Safari
recognizes the SameSite option starting with version 12, but their
implementation has a bug: It interprets invalid values as if
SameSite=Strict had been specified, and for it only Strict and Lax are
valid values, as the older specification did not yet specify None
To solve this issue, we need to override the SameSite security settings,
for this, create a file called config_system.py in the web/ directory of
the installation, alongside the existing config.py. This file can be used
to override any of the settings in config.py (which shouldn't be edited).
The config_system.py should have the below code:
import sys
# Targeting only macOS
if sys.platform.startswith('darwin'):
SESSION_COOKIE_SAMESITE = None
SESSION_COOKIE_SECURE = True
Do suggest or add any points if I am missing them.
Also, let me know once this is done, So that I will close the ticket.
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
On Mon, Nov 30, 2020 at 7:30 PM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:
> This was the part of our internal quality testing, where it got
> encountered. Currently, none of the users have complained about this on
> their specific browser versions.
>
> On Mon, Nov 30, 2020 at 5:12 PM Dave Page wrote:
>
>> Hi
>>
>> On Mon, Nov 30, 2020 at 7:12 AM Rahul Shirsat <
>> rahul.shir...@enterprisedb.com> wrote:
>>
>>> Dave,
>>>
>>> There are issues discussed on Apple forums, check this out:
>>>
>>> https://developer.apple.com/forums/thread/129064 - The latest comment
>>> by the user here is one month ago, meaning the issue is still not fixed yet.
>>> https://developer.apple.com/forums/thread/658688 - Users facing this
>>> issue in v13.x
>>>
>>> Even webkit has confirmed about this issue :
>>> https://bugs.webkit.org/show_bug.cgi?id=198181 - Users facing this
>>> issue in v12.x
>>>
>>
>> In that case, I think the answer (for now at least) is an FAQ,
>> referencing those issues and explaining how to resolve the issue using
>> config_system.py or by using a different browser.
>>
>> Have we actually seen this issue in wild?
>>
>>
>>
>>>
>>> On Thu, Nov 26, 2020 at 6:57 PM Dave Page wrote:
>>>
>>>> Hi
>>>>
>>>> On Wed, Nov 25, 2020 at 10:37 AM Rahul Shirsat <
>>>> rahul.shir...@enterprisedb.com> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> Due to SameSite security issues in Safari Browser, some of the
>>>>> pgadmin4 functionality isn't working (mostly the new tab functionality).
>>>>>
>>>>> The affected Safari Browser versions (marked in red) currently tested
>>>>> upon are:
>>>>>
>>>>>1. v11.1.2
>>>>>2. v12.1
>>>>>3. v12.1.1
>>>>>4. 13.1
>>>>>5. 14.0.1
>>>>>
>>>>> Since v12, Safari have done some security fixes, due to which this
>>>>> issue has occurred. Strangely, the issue is not reproducible on v13, but
>>>>> reproducible on its successor i.e. v14
>>>>>
>>>>> Possible solutions could be:
>>>>>
>>>>>1. Reporting this to Safari & raising an RM for tracking purposes.
>>>>>2. Suggesting Safari users to make below changes in config.py or
>>>>>config_distro for the work around:
>>>>>
>>>>> *SESSION_COOKIE_SAMESITE = None*
>>>>>
>>>>> *SESSION_COOKIE_SECURE = True*
>>>>> (As we aren't going through any cross-site cookie transfer, this can
>>>>> be a handy option - but still risky..)
>>>>>
>>>>> I would suggest going with the 1st option or combination of both, but
>>>>> with caution.
>>>>>
>>>>
>>>> Others must have come across this issue already. Is it a known bug,
>>>> documented somewhere (ideally on apple.com)?
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EDB: http://www.enterprisedb.com
>>>>
>>>>
>>>
>>> --
>>> *Rahul Shirsat*
>>> Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
Re: pgAdmin 4 commit: Fixed an issue where the validation error message is
On Thu, Dec 3, 2020 at 11:18 AM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hello,
>
> Another observation,
>
> +if(msg && handler) {
> + msg = msg || _.values(handler.errorModel.attributes)[0];
> +
> + handler.trigger('pgadmin-session:model:invalid', msg, handler);
> + $(parentTr).addClass('error-in-grid');
> +}
> +return this;
> + }, 120);
> +},
>
> Here we are only making the model invalid, there is no logic to make it
> valid again.
>
If there are multiple model errors in the list, and if user changes any of
them, it used to clear every other invalid models in the list. To avoid
this to happen, only invalid models are highlighted, rest others are taken
care of by the child valid events running in parallel.
>
>
>
> On Thu, Dec 3, 2020 at 11:09 AM Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hello,
>>
>> What is the reason for adding delay *setTimeout(, 120)*?
>>
>> This is causing issues in automation testing and makes buttons
>> enable/disable with slight delay.
>>
>> Timeout was added for the reason that, even if the current changed
model is valid, it should also check the rest of the invalid models in the
list. Slight delay was added, so even if the current model becomes valid,
it should highlight the invalid one iterating over the inner model list.
> --
>> Regards,
>> Murtuza Zabuawala
>> *EDB*
>> *POWER TO POSTGRES*
>> https://www.edbpostgres.com
>>
>>
>> On Fri, Oct 30, 2020 at 3:10 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Fixed an issue where the validation error message is shown twice. Fixes
>>> #5736
>>>
>>> Branch
>>> --
>>> master
>>>
>>> Details
>>> ---
>>>
>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=183c83f0d2b2cb8dd33f9e8c41a030bc4cdaa4b2
>>> Author: Rahul Shirsat
>>>
>>> Modified Files
>>> --
>>> docs/en_US/release_notes_4_28.rst | 1 +
>>> web/pgadmin/browser/static/js/datamodel.js | 75
>>> +-
>>> web/pgadmin/static/js/backform.pgadmin.js | 24 --
>>> web/pgadmin/static/scss/_alert.scss| 6 +++
>>> 4 files changed, 90 insertions(+), 16 deletions(-)
>>>
>>>
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
Re: SameSite issues in Safari Browser (reference #RM5975)
Dave,
Please find below corrected faq details.
Category : Troubleshooting
Question :
When I set new tab settings for query tool or schema-diff, I get
"Connection to server lost" or "CSRF tokens do not match" on Safari
versions >= 12
Answer:
This has been seen mostly on Safari browser versions >= 12. It's
reported that from v12 of CFNetwork/Safari/Webkit erroneously handle
"Samesite=none" as the equivalent of "Samesite=strict". It means, Safari
recognizes the SameSite option starting with version 12, but their
implementation has a bug: It interprets invalid values as if
SameSite=Strict had been specified, and for it only Strict and Lax are
valid values, as the older specification did not yet specify None
To solve this issue, we need to override the SameSite security settings,
for this, create a file called config_system.py (for location to create the
file, refer https://www.pgadmin.org/docs/pgadmin4/development/config_py.html";>The
config.py file). This file can be used to override any of the settings
in config.py (which shouldn't be edited). The config_system.py should have
the below code:
SESSION_COOKIE_SAMESITE = None
SESSION_COOKIE_SECURE = True
Note that these changes are not recommended, and we highly recommend
users to use a different browser until the issue gets resolved from
Apple.
Removed the OS specific condition to make it generic for all distributions.
Added a warning note at the last of the faq.
On Wed, Dec 2, 2020 at 4:33 PM Dave Page wrote:
> Hi
>
> On Tue, Dec 1, 2020 at 5:51 PM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Could you please add below FAQ point for SameSite Safari issue:
>>
>> Question :
>> When I set new tab settings for query tool or schema-diff, I get
>> "Connection to server lost" or "CSRF tokens do not match" on Safari
>> versions >= 12
>>
>> Answer:
>> This has been seen mostly on Safari browser versions >= 12. It's
>> reported that from v12 of CFNetwork/Safari/Webkit erroneously handle
>> "Samesite=none" as the equivalent of "Samesite=strict". It means, Safari
>> recognizes the SameSite option starting with version 12, but their
>> implementation has a bug: It interprets invalid values as if
>> SameSite=Strict had been specified, and for it only Strict and Lax are
>> valid values, as the older specification did not yet specify None
>>
>> To solve this issue, we need to override the SameSite security
>> settings, for this, create a file called config_system.py in the web/
>> directory of the installation, alongside the existing config.py. This file
>> can be used to override any of the settings in config.py (which shouldn't
>> be edited). The config_system.py should have the below code:
>>
>
> We could certainly add something like that, though, config_system.py
> doesn't go alongside config.py so that part of the text needs fixing.
>
>
>>
>>
>> import sys
>>
>> # Targeting only macOS
>> if sys.platform.startswith('darwin'):
>> SESSION_COOKIE_SAMESITE = None
>> SESSION_COOKIE_SECURE = True
>>
>>
>> Do suggest or add any points if I am missing them.
>>
>
> And that is not going to work in Server mode, only Desktop.
>
>
>
>>
>> Also, let me know once this is done, So that I will close the ticket.
>>
>> --
>> *Rahul Shirsat*
>> Senior Software Engineer | EnterpriseDB Corporation.
>>
>> On Mon, Nov 30, 2020 at 7:30 PM Rahul Shirsat <
>> rahul.shir...@enterprisedb.com> wrote:
>>
>>> This was the part of our internal quality testing, where it got
>>> encountered. Currently, none of the users have complained about this on
>>> their specific browser versions.
>>>
>>> On Mon, Nov 30, 2020 at 5:12 PM Dave Page wrote:
>>>
>>>> Hi
>>>>
>>>> On Mon, Nov 30, 2020 at 7:12 AM Rahul Shirsat <
>>>> rahul.shir...@enterprisedb.com> wrote:
>>>>
>>>>> Dave,
>>>>>
>>>>> There are issues discussed on Apple forums, check this out:
>>>>>
>>>>> https://developer.apple.com/forums/thread/129064 - The latest comment
>>>>> by the user here is one month ago, meaning the issue is still not fixed
>>>>> yet.
>>>>> https://developer.apple.com/forums/thread/658688 - Users facing this
>>>>> issue in v13.x
>>>>>
>>>>> Even webkit has confirmed about this issue :
>>>>> https://bugs.webkit.
Re: SameSite issues in Safari Browser (reference #RM5975)
Thanks Dave.
I have closed the issue.
On Thu, Dec 3, 2020 at 3:02 PM Dave Page wrote:
> Hi
>
> Please check: https://www.pgadmin.org/faq/#13
>
> On Thu, Dec 3, 2020 at 8:54 AM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Dave,
>>
>> Please find below corrected faq details.
>>
>> Category : Troubleshooting
>>
>> Question :
>> When I set new tab settings for query tool or schema-diff, I get
>> "Connection to server lost" or "CSRF tokens do not match" on Safari
>> versions >= 12
>>
>> Answer:
>> This has been seen mostly on Safari browser versions >= 12. It's
>> reported that from v12 of CFNetwork/Safari/Webkit erroneously handle
>> "Samesite=none" as the equivalent of "Samesite=strict". It means, Safari
>> recognizes the SameSite option starting with version 12, but their
>> implementation has a bug: It interprets invalid values as if
>> SameSite=Strict had been specified, and for it only Strict and Lax are
>> valid values, as the older specification did not yet specify None
>>
>> To solve this issue, we need to override the SameSite security
>> settings, for this, create a file called config_system.py (for location to
>> create the file, refer https://www.pgadmin.org/docs/pgadmin4/development/config_py.html";>The
>> config.py file). This file can be used to override any of the settings
>> in config.py (which shouldn't be edited). The config_system.py should have
>> the below code:
>>
>>
>> SESSION_COOKIE_SAMESITE = None
>> SESSION_COOKIE_SECURE = True
>>
>> Note that these changes are not recommended, and we highly
>> recommend users to use a different browser until the issue gets resolved
>> from Apple.
>>
>> Removed the OS specific condition to make it generic for all
>> distributions.
>> Added a warning note at the last of the faq.
>>
>> On Wed, Dec 2, 2020 at 4:33 PM Dave Page wrote:
>>
>>> Hi
>>>
>>> On Tue, Dec 1, 2020 at 5:51 PM Rahul Shirsat <
>>> rahul.shir...@enterprisedb.com> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> Could you please add below FAQ point for SameSite Safari issue:
>>>>
>>>> Question :
>>>> When I set new tab settings for query tool or schema-diff, I get
>>>> "Connection to server lost" or "CSRF tokens do not match" on Safari
>>>> versions >= 12
>>>>
>>>> Answer:
>>>> This has been seen mostly on Safari browser versions >= 12. It's
>>>> reported that from v12 of CFNetwork/Safari/Webkit erroneously handle
>>>> "Samesite=none" as the equivalent of "Samesite=strict". It means, Safari
>>>> recognizes the SameSite option starting with version 12, but their
>>>> implementation has a bug: It interprets invalid values as if
>>>> SameSite=Strict had been specified, and for it only Strict and Lax are
>>>> valid values, as the older specification did not yet specify None
>>>>
>>>> To solve this issue, we need to override the SameSite security
>>>> settings, for this, create a file called config_system.py in the web/
>>>> directory of the installation, alongside the existing config.py. This file
>>>> can be used to override any of the settings in config.py (which shouldn't
>>>> be edited). The config_system.py should have the below code:
>>>>
>>>
>>> We could certainly add something like that, though, config_system.py
>>> doesn't go alongside config.py so that part of the text needs fixing.
>>>
>>>
>>>>
>>>>
>>>> import sys
>>>>
>>>> # Targeting only macOS
>>>> if sys.platform.startswith('darwin'):
>>>> SESSION_COOKIE_SAMESITE = None
>>>> SESSION_COOKIE_SECURE = True
>>>>
>>>>
>>>> Do suggest or add any points if I am missing them.
>>>>
>>>
>>> And that is not going to work in Server mode, only Desktop.
>>>
>>>
>>>
>>>>
>>>> Also, let me know once this is done, So that I will close the ticket.
>>>>
>>>> --
>>>> *Rahul Shirsat*
>>>> Senior Software Engineer | EnterpriseDB Corporation.
>>>>
>>>> On Mon, Nov 30, 2020 at 7:30 PM Rahul Shirsat <
>>>> rahul.shir...@enterprisedb.com&
Add folder icon issue
Hi Hacker, Please find a minor fix for the add-folder icon issue on select / create file manager. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. add-folder-icon-issue.patch Description: Binary data
[pgAdmin] RM5875 template1 is shown after you use pg_upgrade
Hi Hackers, Please find the attached patch below which resolves the issue of showing template1 after pg_upgrade. Testing of the patch has been done on : 1. Windows Server 2016 (PostgreSQL 12.5, compiled by Visual C++ build 1914, 64-bit & PostgreSQL 13.1, compiled by Visual C++ build 1914, 64-bit) 2. MacOSX -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM5875.patch Description: Binary data
[pgAdmin] RM5973 Option to Never Expire a user account is unintuitive
Hi Hackers, Please find the attached patch which adds more information for letting users know about the account password expiry for Login/Group Role. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM5973.patch Description: Binary data
[pgAdmin] RM6084 Uncaught TypeError exception displayed on schema diff identical option
Hi Hackers, Please find the attached patch which resolves 2 issues: 1. When the user applies the "Identical" filter before hitting the Compare button. (All Browsers) 2. When comparing data is loaded, and when the user selects identical table comparison, infinite loader "Comparing objects..." shows up in Firefox. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6084.patch Description: Binary data
[pgAdmin] RM4892 pgAdmin "Inception"
Hi Hackers, Please find the attached patch which resolves the issue of pgadmin Inception in Firefox browser. The fix is tested on: 1. MacOS 10.13.6 Firefox Browser 84.0 (64-bit) 2. Windows 2016 Firefox Browser 84.0.1 (64-bit) -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM4892.patch Description: Binary data
Re: [pgAdmin] RM4892 pgAdmin "Inception"
Just forgot to mention, patch consists of one more fix of a schema not loading on several refresh of browser or startup of application - *FIXED* [image: image.png] On Wed, Dec 23, 2020 at 8:16 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch which resolves the issue of pgadmin > Inception in Firefox browser. > > The fix is tested on: > >1. MacOS 10.13.6 Firefox Browser 84.0 (64-bit) >2. Windows 2016 Firefox Browser 84.0.1 (64-bit) > > -- > *Rahul Shirsat* > Senior Software Engineer | EnterpriseDB Corporation. > -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation.
[pgAdmin] RM6128 RM6084 datistemplate issue
Hi Hackers, Please find the attached patch below which resolves the issue of datistemplate. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6128_RM6084.patch Description: Binary data
Re: [pgAdmin] RM4892 pgAdmin "Inception"
Hi Hackers, Please find the patch which reverts the previous changes. Code changes do not solve the issue, so a workaround is mentioned in the RM to cater the issue. On Thu, Dec 24, 2020 at 1:15 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Dec 23, 2020 at 8:23 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Just forgot to mention, patch consists of one more fix of a schema not >> loading on several refresh of browser or startup of application - *FIXED* >> >> [image: image.png] >> >> On Wed, Dec 23, 2020 at 8:16 PM Rahul Shirsat < >> rahul.shir...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the attached patch which resolves the issue of pgadmin >>> Inception in Firefox browser. >>> >>> The fix is tested on: >>> >>>1. MacOS 10.13.6 Firefox Browser 84.0 (64-bit) >>>2. Windows 2016 Firefox Browser 84.0.1 (64-bit) >>> >>> -- >>> *Rahul Shirsat* >>> Senior Software Engineer | EnterpriseDB Corporation. >>> >> >> >> -- >> *Rahul Shirsat* >> Senior Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM4892_v2.patch Description: Binary data
[pgAdmin] RM6098 Manually deleting from table view hangs
Hi Hackers, Please find the attached patch which resolves the issue of deleting records when the user tries to delete multiple records step by step. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6098.patch Description: Binary data
SonarQube Fixes #4 Database & Foreign Tables
Hi Hackers, Please find the attached patch which resolves the sonar qube issues relating: 1. *Foreign Tables* -*Refactor this function to reduce its Cognitive Complexity from 67 to the 15 allowed.* 2. *Database* -*Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.* -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. sonar_issues_database_foreign_tables.patch Description: Binary data
Re: SonarQube Fixes #4 Database & Foreign Tables
On Thu, Jan 21, 2021 at 2:47 PM Akshay Joshi wrote: > Hi Rahul > > Following are the review comments: > >- Change the name of the function 'get_pg_db_properties'. The function >returns lastsysoid and datistemplate only and I assume it is applicable for >PG/EPAS both. > > *Done!* > >- Add comments for all the new functions introduce in the patch. > > *Added!* > > On Thu, Jan 21, 2021 at 2:36 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch which resolves the sonar qube issues >> relating: >> >> >>1. *Foreign Tables* -*Refactor this function to reduce its Cognitive >>Complexity from 67 to the 15 allowed.* >>2. *Database* -*Refactor this function to reduce its Cognitive >>Complexity from 17 to the 15 allowed.* >> >> >> -- >> *Rahul Shirsat* >> Senior Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. sonar_issues_database_foreign_tables_v2.patch Description: Binary data
[pgAdmin] RM5871 Show username in 'Connect to Server' pop up when server is created using service & user.
Hi Hackers,
Please find the attached patch for this issue.
diff --git a/web/pgadmin/browser/server_groups/servers/templates/servers/password.html b/web/pgadmin/browser/server_groups/servers/templates/servers/password.html
index 35f4e2a16..5ed1fc4af 100644
--- a/web/pgadmin/browser/server_groups/servers/templates/servers/password.html
+++ b/web/pgadmin/browser/server_groups/servers/templates/servers/password.html
@@ -1,11 +1,11 @@
-{% if service %}
-{{ _('Please enter the password for the user to connect the server - "{0}"').format(server_label) }}
-{% else %}
+{% if username %}
{{ _('Please enter the password for the user \'{0}\' to connect the server - "{1}"').format(username,
server_label) }}
+{% else %}
+{{ _('Please enter the password for the user to connect the server - "{0}"').format(server_label) }}
{% endif %}
[pgAdmin] RM5073 Save button is enabled in properties of Procedure by-default for SQL language
Hi Hackers, Please find the attached patch which resolves the issue of save button getting enabled for procedure, additionally for functions as well. There is no support for Estimated cost in Procedure for PG, which is also taken care of in this fix. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM5073.patch Description: Binary data
[pgAdmin] RM4847 & RM4849 Double % & Relation name issue Explain -> Statistics
Hi Hackers, Please find below patch which resolves: RM4847 <https://redmine.postgresql.org/issues/4847> : If user select timing under explain analyze the % displayed twice for query and table RM4849 <https://redmine.postgresql.org/issues/4849> : Statistic per view and materialized view should display for Explain Analyze -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM4849_RM4847.patch Description: Binary data
[pgAdmin] [patch] RM5319 [Code Coverage] Improve API test cases for Server module
Hi Hackers, Please find the patch for code coverage to improve test cases for server modules. Also a minor issue of server creation when created along with Advanced Tab setting passfile keeping auto connect disable is fixed along with this patch. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM5319.patch Description: Binary data
SonarQube Fixes #5 Roles & Functions
Hi Hackers, Please find the patch which resolves below sonar qube issues: For Roles: Refactor this function to reduce its Cognitive Complexity from 21 to the 15 allowed Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed For Functions: Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. sonar_roles_functions.patch Description: Binary data
[pgAdmin] [patch] RM6333 Help dialog issue if we set "Open in new browser tab" for Query tool & ERD.
Hi Hackers, Please find the attached patch which resolves the issue of help dialogue for Query tool & ERD tool on nwjs app. Also in the flow, verified Schema diff & Debugger where no issues found as these can be opened in the new tab. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6333.patch Description: Binary data
[pgAdmin][patch] [Macro support] RM5908 Shortcut keys should be working with Manage macro & RM6161 Macro SQL input box cursor issue.
Hi Hackers, Please find below patch which resolves the issues : RM5908 <https://redmine.postgresql.org/issues/5908> Shortcut keys should be working with Manage macro. RM6161 <https://redmine.postgresql.org/issues/6161> Macro SQL input box cursor issue. The issue was not only for macro support modal, but also for other models related to sqleditor (description in RM6161 <https://redmine.postgresql.org/issues/6161>) which is resolved in this fix. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM5908_RM6161.patch Description: Binary data
[pgAdmin][patch] RM6107 Check constraint input size flickers when editing it
Hi Hackers, Please find the patch which resolves the flickering issue of the input box on check constraints. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6107.patch Description: Binary data
[pgAdmin][patch] RM6329 [SQL] bad child table DDL
Hi Hackers, Please find below patch which resolves the issue of inherited key constraint getting in partition SQL. Simultaneously, added the partition table's RLS policy, Triggers, Rules, Compound Triggers in the main SQL tab as previously it was not included. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6329.patch Description: Binary data
Re: [pgAdmin][patch] RM6329 [SQL] bad child table DDL
Hello Akshay, Please find the updated patch. On Mon, Apr 26, 2021 at 2:34 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Fri, Apr 23, 2021 at 2:08 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find below patch which resolves the issue of inherited key >> constraint getting in partition SQL. >> >> Simultaneously, added the partition table's RLS policy, Triggers, Rules, >> Compound Triggers in the main SQL tab as previously it was not included. >> >> -- >> *Rahul Shirsat* >> Senior Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6329_v2.patch Description: Binary data
[pgAdmin][patch] RM4064 Window maximize/restore, standardize
Hi Hackers, Please find the attached patch for your reference, which adds the functionality of window maximise/restore currently only for properties dialog. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM4064.patch Description: Binary data
[Patch][pgAdmin] RM4203 Rename Database by another user
Hi Hackers, Please find the attached patch which resolves the issue of renaming the database by another user. A minor issue of navigation button alignment is also fixed in this patch. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM4203.patch Description: Binary data
[Patch] RM6478 Duplicates on SQL tab for table with more than one partition
Hi Hackers, Please find the patch which resolves the mentioned issue of duplicate on sql tab for table. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6478.patch Description: Binary data
[patch][pgAdmin] RM1591 [Web Based] Grant Wizard should also add under package node
Hi Hackers, Please find the attached patch which adds the functionality of grant wizard to packages. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM1591.patch Description: Binary data
Re: [Patch][pgAdmin] RM4203 Rename Database by another user
Hi Akshay,
Please find the updated patch below for your reference. I have added an
extra check for verifying the database rename.
Sorry for the inconvenience caused.
On Tue, Jun 1, 2021 at 8:50 PM Akshay Joshi
wrote:
> Thanks, the patch applied.
>
> On Sun, May 30, 2021 at 12:03 AM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>>
>> On Thu, May 27, 2021 at 12:19 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Rahul
>>>
>>> Following are the review comments:
>>>
>>>- Why you have changed the order of the toolbar button on the
>>>browser tree? It should not.
>>>
>>>Changes were related to the wcDocker issue showing
>> reverse order buttons, so had to change in the pgAdmin app to reflect it
>> correctly.
>>
>>>
>>>- *sqleditor.js (check_db_name_change function)*
>>>- var declaration should be comma-separated instead of writing var,
>>> again and again.
>>>
>>> Done.
>>
>>>
>>>- Add proper comments.
>>>
>>> This too is taken care of.
>>
>>>
>>>- Remove dots from the string "Database moved/renamed.."
>>>
>>> Done.
>>
>>>
>>>- "Please note that the database you are working on has been moved
>>> or renamed to ${data.actual_db_name}. Refresh databases in browser
>>> panel or
>>> click OK to continue.." should be changed to "Current database has
>>> been
>>> moved or renamed to ${data.actual_db_name}. Click on the OK button to
>>> refresh the database name."
>>>
>>> Done.
>> Also have done some code refactoring.
>>
>>>
>>>
>>> On Wed, May 26, 2021 at 2:07 PM Rahul Shirsat <
>>> rahul.shir...@enterprisedb.com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find the attached patch which resolves the issue of renaming the
>>>> database by another user.
>>>>
>>>> A minor issue of navigation button alignment is also fixed in this
>>>> patch.
>>>>
>>>> --
>>>> *Rahul Shirsat*
>>>> Senior Software Engineer | EnterpriseDB Corporation.
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> *Rahul Shirsat*
>> Senior Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web/pgadmin/tools/sqleditor/__init__.py
index 884cc8be0..780c0243f 100644
--- a/web/pgadmin/tools/sqleditor/__init__.py
+++ b/web/pgadmin/tools/sqleditor/__init__.py
@@ -505,6 +505,8 @@ def poll(trans_id):
transaction_status = conn.transaction_status()
data_obj['db_name'] = conn.db
+data_obj['db_id'] = trans_obj.did \
+if trans_obj is not None and hasattr(trans_obj, 'did') else 0
return make_json_response(
data={
diff --git a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
index 33547223e..3e91f424a 100644
--- a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
@@ -5125,9 +5125,10 @@ define('tools.querytool', [
tree_data = pgWindow.default.pgAdmin.Browser.treeMenu.translateTreeNodeIdFromACITree(selected_item),
server_data = pgWindow.default.pgAdmin.Browser.treeMenu.findNode(tree_data.slice(0,2)),
database_data = pgWindow.default.pgAdmin.Browser.treeMenu.findNode(tree_data.slice(0,4)),
- db_name = database_data.data.label;
+ db_name = database_data.data.label,
+ db_did = database_data.data._id;
-if(!_.isEqual(db_name, data.data_obj.db_name)) {
+if(data.data_obj.db_id == db_did && !_.isEqual(db_name, data.data_obj.db_name)) {
var message = `Current database has been moved or renamed to ${data.data_obj.db_name}. Click on the OK button to refresh the database name.`,
title = self.url_params.title;
[patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure
Hi Hackers, Please find the attached patch for fixation of jenkins failure. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. jenkins_failure_fix.patch Description: Binary data
Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure
I feel gettext sometimes won't escape the characters as it should be. I now tried to escape those using some utils. Please find the updated patch. On Mon, Jun 28, 2021 at 9:33 PM Dave Page wrote: > Hi > > On Mon, Jun 28, 2021 at 4:57 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch for fixation of jenkins failure. >> > > That won't work - you can't include variables (or string building > operations) in the first argument to gettext calls, as there won't be any > way to extract a complete message into the catalogs. The way it's being > done at the moment is correct (I don't know why it's failing, but it's the > correct way to structure the gettext calls). > > -- > Dave Page > Blog: https://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: https://www.enterprisedb.com > > -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. jenkins_failure_fix_v2.patch Description: Binary data
Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure
Hi Dave / Aditya,
For a time being, Let's make a call to gettext conditional instead of
passing dynamic parameters for this scenario at least. With this, we won't
be touching the *.po files and translations will do its task smoothly.
I have already checked for the string with weird unprintable characters,
and there were none.
e.g.
Instead of - *title = gettext('%s objects?', obj.label);*
*if (drop) {*
* title = gettext('Drop objects?');*
*}*
*else {*
*title = gettext('Reassign objects?');*
*}*
I have tried the above code and it looks good to me.
Please suggest.
On Tue, Jun 29, 2021 at 7:31 PM Dave Page wrote:
>
>
> On Tue, Jun 29, 2021 at 2:55 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> On Tue, Jun 29, 2021 at 7:14 PM Dave Page wrote:
>>
>>>
>>>
>>> On Tue, Jun 29, 2021 at 2:41 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
>>>> Dave,
>>>>
>>>> Somehow, the new text strings are added to PO with incorrect
>>>> translations. That is causing the issue.
>>>> Either they should be empty or fixed.
>>>>
>>>
>>> Then the source problem should be fixed. There's no point at all in
>>> putting fixes directly in the PO files as they'll be overwritten prior to
>>> release anyway.
>>>
>> The translations submitted by translators are updated in the PO file
>> right ? And then they're compiled to MO ?
>>
>
> Right.
>
>
>> It's the same like Rahul will be submitting the translations. Please
>> correct me if I'm wrong.
>>
>
> That depends if he's changed the original message or the translated
> message. It's impossible to see without reading megabytes of text.
>
> And in any case, he's updated translations that haven't been touched in
> ages - why would they suddenly have broken? (hint: if the upstream message
> has changed, it'll be marked as fuzzy or untranslated - in other words,
> gettext knows how to handle that).
>
>
>>
>>>
>>>>
>>>> On Tue, Jun 29, 2021 at 7:01 PM Dave Page wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> Please send the patch without updates to the po files. Those get
>>>>> updated as part of the release process.
>>>>>
>>>>> Thanks.
>>>>>
>>>>> On Tue, Jun 29, 2021 at 2:00 PM Rahul Shirsat <
>>>>> rahul.shir...@enterprisedb.com> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Thanks Aditya for pointing out the issue. Please find the attached
>>>>>> patch which contains all the .po files corrected with %s.
>>>>>>
>>>>>> Regards,
>>>>>> Rahul Shirsat.
>>>>>>
>>>>>> On Tue, Jun 29, 2021 at 4:31 PM Aditya Toshniwal <
>>>>>> aditya.toshni...@enterprisedb.com> wrote:
>>>>>>
>>>>>>> Hi Rahul,
>>>>>>>
>>>>>>> I did "make msg-extract" and "make msg-update" and looking at the
>>>>>>> PO files I think it is not updated correctly.
>>>>>>> For instance, the below message has msgstr without %s. I corrected
>>>>>>> it and the error was gone.
>>>>>>>
>>>>>>> #: pgadmin/browser/server_groups/servers/roles/static/js/role.js:766
>>>>>>> #, fuzzy, python-format
>>>>>>> msgid "%s Objects"
>>>>>>> msgstr "Obiekty"
>>>>>>>
>>>>>>> The one below had 2 %s in msgstr and I corrected it to fix the error.
>>>>>>>
>>>>>>> #: pgadmin/browser/server_groups/servers/roles/static/js/role.js:767
>>>>>>> #, fuzzy, python-format
>>>>>>> msgid "Are you sure you wish to %s all the objects owned by the
>>>>>>> selected role?"
>>>>>>> msgstr "Czy na pewno skasować %s \"%s\" i wszystkie obiekty zależne
>>>>>>> od niego?"
>>>>>>>
>>>>>>>
>>>>>>> You have to update the .po files to match the total %s and send the
>>>>>>> patch.
>>>>>>>
>>>>>>> On Tue, Jun 29, 2021 at 1:56 PM Dave Page wrote:
>>&g
Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure
Hi All,
Please find the attached patch for resolving this issue wrt above
suggestion.
Let me know if anyone has any queries.
On Tue, Jun 29, 2021 at 9:20 PM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:
> Hi Dave / Aditya,
>
> For a time being, Let's make a call to gettext conditional instead of
> passing dynamic parameters for this scenario at least. With this, we won't
> be touching the *.po files and translations will do its task smoothly.
> I have already checked for the string with weird unprintable characters,
> and there were none.
>
> e.g.
> Instead of - *title = gettext('%s objects?', obj.label);*
>
> *if (drop) {*
> * title = gettext('Drop objects?');*
> *}*
> *else {*
>*title = gettext('Reassign objects?');*
> *}*
>
> I have tried the above code and it looks good to me.
>
> Please suggest.
>
> On Tue, Jun 29, 2021 at 7:31 PM Dave Page wrote:
>
>>
>>
>> On Tue, Jun 29, 2021 at 2:55 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> On Tue, Jun 29, 2021 at 7:14 PM Dave Page wrote:
>>>
>>>>
>>>>
>>>> On Tue, Jun 29, 2021 at 2:41 PM Aditya Toshniwal <
>>>> aditya.toshni...@enterprisedb.com> wrote:
>>>>
>>>>> Dave,
>>>>>
>>>>> Somehow, the new text strings are added to PO with incorrect
>>>>> translations. That is causing the issue.
>>>>> Either they should be empty or fixed.
>>>>>
>>>>
>>>> Then the source problem should be fixed. There's no point at all in
>>>> putting fixes directly in the PO files as they'll be overwritten prior to
>>>> release anyway.
>>>>
>>> The translations submitted by translators are updated in the PO file
>>> right ? And then they're compiled to MO ?
>>>
>>
>> Right.
>>
>>
>>> It's the same like Rahul will be submitting the translations. Please
>>> correct me if I'm wrong.
>>>
>>
>> That depends if he's changed the original message or the translated
>> message. It's impossible to see without reading megabytes of text.
>>
>> And in any case, he's updated translations that haven't been touched in
>> ages - why would they suddenly have broken? (hint: if the upstream message
>> has changed, it'll be marked as fuzzy or untranslated - in other words,
>> gettext knows how to handle that).
>>
>>
>>>
>>>>
>>>>>
>>>>> On Tue, Jun 29, 2021 at 7:01 PM Dave Page wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> Please send the patch without updates to the po files. Those get
>>>>>> updated as part of the release process.
>>>>>>
>>>>>> Thanks.
>>>>>>
>>>>>> On Tue, Jun 29, 2021 at 2:00 PM Rahul Shirsat <
>>>>>> rahul.shir...@enterprisedb.com> wrote:
>>>>>>
>>>>>>> Hi Hackers,
>>>>>>>
>>>>>>> Thanks Aditya for pointing out the issue. Please find the attached
>>>>>>> patch which contains all the .po files corrected with %s.
>>>>>>>
>>>>>>> Regards,
>>>>>>> Rahul Shirsat.
>>>>>>>
>>>>>>> On Tue, Jun 29, 2021 at 4:31 PM Aditya Toshniwal <
>>>>>>> aditya.toshni...@enterprisedb.com> wrote:
>>>>>>>
>>>>>>>> Hi Rahul,
>>>>>>>>
>>>>>>>> I did "make msg-extract" and "make msg-update" and looking at the
>>>>>>>> PO files I think it is not updated correctly.
>>>>>>>> For instance, the below message has msgstr without %s. I corrected
>>>>>>>> it and the error was gone.
>>>>>>>>
>>>>>>>> #: pgadmin/browser/server_groups/servers/roles/static/js/role.js:766
>>>>>>>> #, fuzzy, python-format
>>>>>>>> msgid "%s Objects"
>>>>>>>> msgstr "Obiekty"
>>>>>>>>
>>>>>>>> The one below had 2 %s in msgstr and I corrected it to fix the
>>>>>>>> error.
>>>>>>>>
>>>>>>>> #: pgadmin/browser/
[patch][pgAdmin] RM6550 5.4 running on kubernetes fails to log in even with the right environment variables defined
Hi Hackers, Please find the attached patch which resolves the login issue for a user having a non-existing email id. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6550_RM6560.patch Description: Binary data
Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure
+1 for --no-fuzzy-matching for updating translations.
On Thu, Jul 1, 2021 at 11:18 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
>
>
> On Wed, Jun 30, 2021 at 6:55 PM Dave Page wrote:
>
>> Hi
>>
>> On Wed, Jun 30, 2021 at 9:22 AM Dave Page wrote:
>>
>>> Hi
>>>
>>> On Wed, Jun 30, 2021 at 8:28 AM Rahul Shirsat <
>>> rahul.shir...@enterprisedb.com> wrote:
>>>
>>>> Hi All,
>>>>
>>>> Please find the attached patch for resolving this issue wrt above
>>>> suggestion.
>>>>
>>>
>>> Well that may fix the problem (and is a reasonable change), however, I
>>> think it's important that we understand the root cause. Why is this failing
>>> on Linux only? Why does the following from node.js (which follows the same
>>> pattern) work fine?
>>>
>>> var type_label = gettext('%s Script',stype.toUpperCase());
>>>
>>
>> Rahul and I figured out the root cause. The issue is occuring because the
>> previous string had no parameters (i.e. no %s's). Because fuzzy matching is
>> used for the translations, when updating the catalogs it was matching with
>> the old translation, which at runtime would likely have caused a crash
>> because the catalogs would have contained something like:
>>
>> #: pgadmin/browser/static/js/node.js:209
>> #, fuzzy, python-format
>> msgid "Search %s Objects"
>> msgstr "Typy obiektów"
>>
>> There are a few of ways around this:
>>
>> - Manually fix the translations in each catalog. This is not a good idea
>> because we don't speak all those languages and will probably mess the
>> translations up.
>>
>> - Run something like 'make msg-extract && pybabel update
>> --no-fuzzy-matching -i web/pgadmin/messages.pot -d web/pgadmin/translations
>> && make msg-compile', then commit the results. This will remove all fuzzy
>> matches from the catalogs, which means more work for the translators on the
>> next release, but will likely also result in them becoming much cleaner.
>>
>> +1 for pybabel update with -N option
>
>> - Change the code to use the conditional fix.
>>
>> I'm leaning towards the second option. In the worst case, it'll lose
>> about 58 fuzzy translations (meaning 58 messages to re-translate), but at
>> least we'll know they are clean. See
>> https://www.pgadmin.org/development/translations/ for current stats.
>>
>> Thoughts?
>>
>> --
>> Dave Page
>> Blog: https://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: https://www.enterprisedb.com
>>
>>
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
[pgAdmin][RM6587] [React] Port FTS Template, FTS Parsers nodes to react
Hi Hackers, Please find the below patch which ports fts_template, fts_parsers nodes to react. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6587.patch Description: Binary data
[patch][pgAdmin] RM6580 5.4 throws exception: TypeError: 'NoneType' object is not subscriptable
Hi Hackers, Please find the attached patch which resolves the issue of 'NoneType' object while logging out in Server Mode. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6580.patch Description: Binary data
[patch][pgAdmin] RM6369 CSRF errors for stale sessions
Hi Hackers, Please find the attached patch which increases the session expiration time for desktop mode to 1 week. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6369.patch Description: Binary data
Re: [patch][pgAdmin] RM6369 CSRF errors for stale sessions
@Khushboo Vashi 👍 Please find the updated patch. On Tue, Jul 13, 2021 at 6:33 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Rahul, > > You made this change at the end of the config.py file, so the changes made > by the user for this parameter in config_local or config_system file will > not be reflected. > > Thanks, > Khushboo > > On Tue, Jul 13, 2021 at 6:24 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch which increases the session expiration >> time for desktop mode to 1 week. >> >> -- >> *Rahul Shirsat* >> Senior Software Engineer | EnterpriseDB Corporation. >> > -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6369_v2.patch Description: Binary data
[patch][pgAdmin] RM6643 When Data type 'Range' is selected while creating custom data type, required options are not loaded
Hi Hackers, Please find the patch which resolves the issue of fetching dependent properties in Range type. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6643.patch Description: Binary data
[pgAdmin] RM6602 [React] Port Types node to react
Hi Hackers, Please find the patch which includes the Type node to react patch. I have included non-visibility changes in the FormView & FieldSetView so as to ensure it gets hidden when form passes visible : false or any function returning false. Tested on EPAS 10 for extra types included in it. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6602.patch Description: Binary data
[pgAdmin][patch] RM6655 [React] Port Schema & Catalog node to react
Hi Hackers, Please find the patch which ports schema & catalog node to react. I have also added a disableDialogHelp where if dialogHelp url is not provided or passed as blank, the help dialog button will be disabled. This has even indirectly corrected the button behaviour where dialogHelp url is not provided. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6655.patch Description: Binary data
[pgAdmin][patch] RM6661 [React] Port Index node to react
Hi Hackers, Please find the below attached patch which migrates the Index node to react. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6661.patch Description: Binary data
[pgAdmin][patch] RM6675 Port package and it’s child node to React
Hi Hackers, Please find the attached patch which ports package and its child nodes to react. A minor change of fullTab for sql type is added for the Properties tab. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6675.patch Description: Binary data
Re: [pgAdmin][patch] RM6675 Port package and it’s child node to React
Hello Akshay, My bad. I haven't mentioned that this is a known issue which is mentioned in the "pgAdmin Nodes to React" sheet. So it's a known issue. Also, the changes on the Properties panel made is for only showing fullTab display for Code mirror wherever applicable. On Wed, Aug 18, 2021 at 7:55 PM Akshay Joshi wrote: > Hi Rahul > > On Wed, Aug 18, 2021 at 12:31 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch which ports package and its child nodes to >> react. >> >> A minor change of fullTab for sql type is added for the Properties tab. >> > > The above change broke the visibility of the content of the code > mirror in the Properties panel for all the nodes (wherever applicable). > With your patch select any trigger function, package, edb functions > and verify in the Properties panel. > >> >> -- >> *Rahul Shirsat* >> Senior Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation.
[patch][pgAdmin] RM6625 Smarter closing of Tabs
Hi Hackers, Please find the patch for feature addition of smarter closing of tabs. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6625.patch Description: Binary data
[patch][pgAdmin] RM6712 Collapse & expand arrows are not populating correctly in case of nested if.
Hi Hackers, Please find below patch which resolves the issue of collapse & expand arrows mismatch in case of nested IF. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6712.patch Description: Binary data
[patch][pgAdmin] RM6713 [Debugger] Messages tab hide last message
Hi Hackers, Please find the attached patch which resolves the issue of the messages tab hiding the last message. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6713.patch Description: Binary data
[patch][pgAdmin] RM6743 Security> Privileges is not displayed for catalog nodes
Hi Hackers, Please find the attached patch which resolves the issue of Privileges not shown in catalog nodes for Properties tab. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6743.patch Description: Binary data
[patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue
Hi Hackers, Please find the attached patch which resolves the below issue: 1. Enum Type - Unable to delete rows for Enum type in Create Type dialogue. 2. Range Type - Loading icons are shown in different drop down tabs. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6744.patch Description: Binary data
Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue
Hi Akshay,
Please find the updated patch.
On Fri, Sep 17, 2021 at 8:55 PM Akshay Joshi
wrote:
> Hi Rahul
>
> Patch not applied, rebase and send the patch again.
>
> On Thu, Sep 16, 2021 at 6:39 PM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch which resolves the below issue:
>>
>> 1. Enum Type - Unable to delete rows for Enum type in Create Type
>> dialogue.
>> 2. Range Type - Loading icons are shown in different drop down tabs.
>>
>> --
>> *Rahul Shirsat*
>> Senior Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js
index 16d13816b..d989ce6e2 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js
@@ -54,6 +54,8 @@ function getRangeSchema(nodeObj, treeNodeInfo, itemNodeData) {
}).catch((err)=>{
reject(err);
});
+ } else {
+resolve(data);
}
});
},
@@ -80,6 +82,8 @@ function getRangeSchema(nodeObj, treeNodeInfo, itemNodeData) {
}).catch((err)=>{
reject(err);
});
+ } else {
+resolve(data);
}
});
},
@@ -107,6 +111,8 @@ function getRangeSchema(nodeObj, treeNodeInfo, itemNodeData) {
}).catch((err)=>{
reject(err);
});
+ } else {
+resolve(data);
}
});
},
@@ -157,11 +163,10 @@ class EnumerationSchema extends BaseUISchema {
return [
{
id: 'label', label: gettext('Label'),
-type: 'text', cell: 'text',
-cellHeaderClasses: 'width_percent_99',
-readonly: function (state) {
- return !obj.isNew(state);
-},
+type: 'text', cell: 'text', minWidth: 640,
+editable: (state) => {
+ return _.isUndefined(obj.isNew) ? true : obj.isNew(state);
+}
}
];
}
@@ -1313,6 +1318,24 @@ export default class TypeSchema extends BaseUISchema {
this.nodeInfo = this.fieldOptions.node_info;
}
+ isInvalidColumnAdded(state) {
+
+let tempCol = _.map(state.enum, 'label');
+let dontAddColumn = false;
+
+if(tempCol.length == 1 && tempCol[0] == undefined) {
+ dontAddColumn = true;
+} else {
+ tempCol.forEach(function(enumVal) {
+if(enumVal == undefined) {
+ dontAddColumn = true;
+ return;
+}
+ });
+}
+return dontAddColumn;
+ }
+
schemaCheck(state) {
if(this.fieldOptions.node_info && 'schema' in this.fieldOptions.node_info)
{
@@ -1420,14 +1443,17 @@ export default class TypeSchema extends BaseUISchema {
{
id: 'enum', label: gettext('Enumeration type'),
schema: new EnumerationSchema(),
- editable: true,
type: 'collection',
group: gettext('Definition'), mode: ['edit', 'create'],
- canAdd: true, canEdit: false,
- canDelete: function(state) {
+ canAddRow: function(state) {
+return !obj.isInvalidColumnAdded(state);
+ },
+ canEdit: false,
+ canDeleteRow: function(state) {
// We will disable it if it's in 'edit' mode
-return !obj.isNew(state);
+return obj.isNew(state);
},
+ canEditRow: false,
disabled: () => obj.inCatalog(),
deps: ['typtype'],
uniqueCol : ['label'],
[patch][pgAdmin] RM6806 [Type Node] Schema icon is not visible in the drop-down of General tab
Hi Hackers, Please find the attached patch which resolves the issue of schema icon not visible in drop down of Type Node in General Tab. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6806.patch Description: Binary data
[patch][pgAdmin] RM6791 Index Node - [Create]> Controls for Sort & Nulls should be changed, [Edit]> Definition>Columns sections are editable
Hi Hackers, Please find the attached patch which resolves the issues of sort & nulls in index. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6791.patch Description: Binary data
[patch][pgAdmin] RM6822 User can not expand the server on Windows
Hi Hackers, Please find the attached patch which resolves the tree expanding issue on windows. Fix is tested on Windows 2016 & Mac. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6822.patch Description: Binary data
Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue
Hi Hackers, Please find the attached patch for fixing some additional issues. On Mon, Sep 20, 2021 at 1:13 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Mon, Sep 20, 2021 at 1:06 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> Please find the updated patch. >> >> On Fri, Sep 17, 2021 at 8:55 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Rahul >>> >>> Patch not applied, rebase and send the patch again. >>> >>> On Thu, Sep 16, 2021 at 6:39 PM Rahul Shirsat < >>> rahul.shir...@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Please find the attached patch which resolves the below issue: >>>> >>>> 1. Enum Type - Unable to delete rows for Enum type in Create Type >>>> dialogue. >>>> 2. Range Type - Loading icons are shown in different drop down tabs. >>>> >>>> -- >>>> *Rahul Shirsat* >>>> Senior Software Engineer | EnterpriseDB Corporation. >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres <http://edbpostgres.com>* >>> >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> *Rahul Shirsat* >> Senior Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6744_v3.patch Description: Binary data
Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue
Hi Hackers, Please find the attached patch which resolves one more additional issue reported by Aditya. On Thu, Sep 30, 2021 at 3:32 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Thu, Sep 30, 2021 at 1:46 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch for fixing some additional issues. >> >> On Mon, Sep 20, 2021 at 1:13 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Thanks, the patch applied. >>> >>> On Mon, Sep 20, 2021 at 1:06 PM Rahul Shirsat < >>> rahul.shir...@enterprisedb.com> wrote: >>> >>>> Hi Akshay, >>>> >>>> Please find the updated patch. >>>> >>>> On Fri, Sep 17, 2021 at 8:55 PM Akshay Joshi < >>>> akshay.jo...@enterprisedb.com> wrote: >>>> >>>>> Hi Rahul >>>>> >>>>> Patch not applied, rebase and send the patch again. >>>>> >>>>> On Thu, Sep 16, 2021 at 6:39 PM Rahul Shirsat < >>>>> rahul.shir...@enterprisedb.com> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> Please find the attached patch which resolves the below issue: >>>>>> >>>>>> 1. Enum Type - Unable to delete rows for Enum type in Create Type >>>>>> dialogue. >>>>>> 2. Range Type - Loading icons are shown in different drop down tabs. >>>>>> >>>>>> -- >>>>>> *Rahul Shirsat* >>>>>> Senior Software Engineer | EnterpriseDB Corporation. >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> *pgAdmin Hacker | Principal Software Architect* >>>>> *EDB Postgres <http://edbpostgres.com>* >>>>> >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>>> >>>> -- >>>> *Rahul Shirsat* >>>> Senior Software Engineer | EnterpriseDB Corporation. >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres <http://edbpostgres.com>* >>> >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> *Rahul Shirsat* >> Senior Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6744_v4.patch Description: Binary data
Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue
Hi Hackers, Please find the attached patch which resolves the issues sec label & type changing issue. Additionally, while testing the workflow, fixed one issue related to composite type added with minimum one type and then changing the Type. On Mon, Oct 4, 2021 at 7:41 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Mon, Oct 4, 2021 at 6:34 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch which resolves one more additional issue >> reported by Aditya. >> >> On Thu, Sep 30, 2021 at 3:32 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Thanks, the patch applied. >>> >>> On Thu, Sep 30, 2021 at 1:46 PM Rahul Shirsat < >>> rahul.shir...@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Please find the attached patch for fixing some additional issues. >>>> >>>> On Mon, Sep 20, 2021 at 1:13 PM Akshay Joshi < >>>> akshay.jo...@enterprisedb.com> wrote: >>>> >>>>> Thanks, the patch applied. >>>>> >>>>> On Mon, Sep 20, 2021 at 1:06 PM Rahul Shirsat < >>>>> rahul.shir...@enterprisedb.com> wrote: >>>>> >>>>>> Hi Akshay, >>>>>> >>>>>> Please find the updated patch. >>>>>> >>>>>> On Fri, Sep 17, 2021 at 8:55 PM Akshay Joshi < >>>>>> akshay.jo...@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Rahul >>>>>>> >>>>>>> Patch not applied, rebase and send the patch again. >>>>>>> >>>>>>> On Thu, Sep 16, 2021 at 6:39 PM Rahul Shirsat < >>>>>>> rahul.shir...@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Hackers, >>>>>>>> >>>>>>>> Please find the attached patch which resolves the below issue: >>>>>>>> >>>>>>>> 1. Enum Type - Unable to delete rows for Enum type in Create Type >>>>>>>> dialogue. >>>>>>>> 2. Range Type - Loading icons are shown in different drop down tabs. >>>>>>>> >>>>>>>> -- >>>>>>>> *Rahul Shirsat* >>>>>>>> Senior Software Engineer | EnterpriseDB Corporation. >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Thanks & Regards* >>>>>>> *Akshay Joshi* >>>>>>> *pgAdmin Hacker | Principal Software Architect* >>>>>>> *EDB Postgres <http://edbpostgres.com>* >>>>>>> >>>>>>> *Mobile: +91 976-788-8246* >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Rahul Shirsat* >>>>>> Senior Software Engineer | EnterpriseDB Corporation. >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> *pgAdmin Hacker | Principal Software Architect* >>>>> *EDB Postgres <http://edbpostgres.com>* >>>>> >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>>> >>>> -- >>>> *Rahul Shirsat* >>>> Senior Software Engineer | EnterpriseDB Corporation. >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres <http://edbpostgres.com>* >>> >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> *Rahul Shirsat* >> Senior Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6744_v5.patch Description: Binary data
[patch][pgAdmin] RM6754 Color of query highlighting in query tool should be less intensive
Hi Hackers, Please find the attached patch which resolves the issue of intensive query highlighting in the query tool. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6754.patch Description: Binary data
[patch][pgAdmin] RM6802 Unable to edit trigger for advanced servers
Hi Hackers, Please find the attached patch which resolves the issue of editing triggers for advanced servers. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6802.patch Description: Binary data
[pgaweb][patch] Update style guide WRT RM6754
Hi Hacker, Please find the attached patch which adds a new activeline-light color for standard themes, and minor updates regarding other themes. Also added babel dependency in requirement.txt which was missing. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6754_styleguide_update.patch Description: Binary data
