pgAdmin 4 commit: 1) Edit cellEditing function, in some cases grid obje
1) Edit cellEditing function, in some cases grid object is undefined. 2) Modify SubNodeCollectionControl, so that user can pass custom backgrid row. 3) Handling of visible parameter in SubNodeCollectionControl. 4) Customise title and delete message for Delete Cell. 5) Added Backgrid.Extension.Select2DepCell and moved Backgrid.Extension.StringDepCell from user management to backgrid.pgadmin.js. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c98b64fd828b5030f724a001b8cb8b99cfcee179 Modified Files -- web/pgadmin/static/js/backform.pgadmin.js | 28 ++--- web/pgadmin/static/js/backgrid.pgadmin.js | 71 +++--- .../user_management/js/user_management.js | 31 +- 3 files changed, 84 insertions(+), 46 deletions(-)
pgAdmin 4 commit: Added support of Declarative Partitioning (Range, Lis
Added support of Declarative Partitioning (Range, List) for PostgreSQL 10. This allows the user to create partitioned table and it's partitions. - Edit partitions, Create/Listing of constraints, rules, triggers under partitions. (Implemented by Harshal) - Updating browser tree node when create/attach/detach partitions from table dialog.(Implemented by Ashesh) Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c2fb0394bf4238fde94372bba88fa07330fdafbb Modified Files -- .../servers/databases/schemas/static/js/schema.js | 36 + .../servers/databases/schemas/tables/__init__.py | 2170 +++ .../tables/column/templates/column/js/column.js| 26 +- .../schemas/tables/column/tests/test_column_get.py |2 +- .../check_constraint/js/check_constraint.js| 15 +- .../js/exclusion_constraint.js | 19 +- .../templates/foreign_key/js/foreign_key.js| 19 +- .../index_constraint/js/index_constraint.js| 27 +- .../templates/constraints/js/constraints.js|4 +- .../databases/schemas/tables/indexes/__init__.py | 156 +- .../tables/indexes/templates/index/js/index.js | 31 +- .../schemas/tables/partitions/__init__.py | 583 ++ .../partitions/static/img/coll-partition.png | Bin 0 -> 1433 bytes .../tables/partitions/static/img/partition.png | Bin 0 -> 1264 bytes .../tables/partitions/static/js/partition.js | 1276 .../tables/rules/templates/rules/js/rules.js | 12 +- .../schemas/tables/static/js/partition.utils.js| 323 +++ .../databases/schemas/tables/static/js/table.js| 520 - .../templates/partition/sql/10_plus/attach.sql |2 + .../partition/sql/10_plus/backend_support.sql |9 + .../templates/partition/sql/10_plus/create.sql | 30 + .../templates/partition/sql/10_plus/detach.sql |1 + .../partition/sql/10_plus/get_attach_tables.sql| 23 + .../templates/partition/sql/10_plus/nodes.sql | 15 + .../templates/partition/sql/10_plus/properties.sql | 82 + .../tables/templates/table/sql/10_plus/acl.sql | 46 + .../templates/table/sql/10_plus/get_inherits.sql | 17 + .../tables/templates/table/sql/10_plus/get_oid.sql |5 + .../templates/table/sql/10_plus/get_table.sql |8 + .../tables/templates/table/sql/10_plus/nodes.sql |9 + .../templates/table/sql/10_plus/properties.sql | 73 + .../tables/templates/table/sql/default/create.sql |3 +- .../templates/table/sql/default/get_schema_oid.sql |3 +- .../schemas/tables/tests/test_table_add.py | 61 +- .../schemas/tables/tests/test_table_delete.py |2 +- .../schemas/tables/tests/test_table_put.py | 89 +- .../databases/schemas/tables/tests/utils.py| 150 ++ .../triggers/templates/trigger/js/trigger.js | 37 +- .../servers/databases/schemas/tables/utils.py | 2178 .../browser/templates/browser/js/browser.js| 197 +- web/pgadmin/browser/templates/browser/js/node.js | 22 +- .../tools/backup/templates/backup/js/backup.js |2 +- web/pgadmin/tools/datagrid/__init__.py | 26 +- .../datagrid/templates/datagrid/js/datagrid.js |2 +- .../templates/maintenance/js/maintenance.js| 13 +- .../tools/restore/templates/restore/js/restore.js |3 +- web/pgadmin/utils/__init__.py |3 + web/pgadmin/utils/exception.py |8 + 48 files changed, 6275 insertions(+), 2063 deletions(-)
pgAdmin 4 commit: Fixed issue by adding extra check for 'relkind' colum
Fixed issue by adding extra check for 'relkind' column Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e793413d76a245dfcdb73e37abbf1df6f9676242 Modified Files -- .../browser/server_groups/servers/databases/schemas/tables/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: Partitioned table does not present in grant wizard. F
Partitioned table does not present in grant wizard. Fixes #2543 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fae185ff661e4c29de377446736fb798dc5b352e Modified Files -- .../templates/grant_wizard/pg/10_plus/sql/table.sql | 20 .../grant_wizard/ppas/10_plus/sql/table.sql | 20 2 files changed, 40 insertions(+)
[pgAdmin4][Patch]: Fixed #2545 Partitioned table should be created using 'OF TYPE'
Hi All Attached is the patch file to fix the RM #2545, where user will be able to create partitioned table using 'OF TYPE' feature of table dialog. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_2545.patch Description: Binary data
[pgAdmin4][Patch]: Fixed #2550 declarative partitioning - drop/delete and drop cascade is not working for partition table
Hi All Attached is the patch file to fix the RM #2550, where user will not be able to drop/drop cascade partitions. Apart from that RM this patch contains following fix: - Update the SQL query to fix the jenkins build. - Use AlertifyWrapper in Partition.js - Fix the icon while 'truncate table' and 'reset statistics'. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_2550.patch Description: Binary data
[pgAdmin4][Patch]: Fix RM #2566 Pause/Resume Replay of WAL files are not working with PostgreSQL 10
Hi Attached is the patch file to fix RM #2566 Pause/Resume Replay of WAL files are not working with PostgreSQL 10. Please review it and let me the comments (if any) -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_2566.patch Description: Binary data
Discussion on improving alertify notifications logic
Hi All As in commit "Update alertify alerts to use the styling defined in the style guide": https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff ;h=2a30a86e7d5e562040500f448fbb0d143ff2cff9 https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff ;h=f2d2075d81718ec02550fb592851aa330d327b24 We have introduce new wrapper class "AlertifyWrapper" and replace calls to alertify.success and alertify.error with following two lines in most of the files var alertifyWrapper = new AlertifyWrapper(); alertifyWrapper.success(message); or alertifyWrapper.error(message); For each call we are creating dynamic object of AlertifyWrapper and call the appropriate function. For example there are 20 such calls in a single js file every time are are creating object and call appropriate function. I have tried to improve the logic here and implemented it as below: - Extend alertify and move success, error and info functions from " alertify_wrapper.js" file to "alertify.pgadmin.defaults.js", there will be no use of "alertify_wrapper.js" - Modify only "server.js" as POC, remove 'alertify' and replace 'sources/alerts/alertify_wrapper' with 'pgadmin.alertifyjs' which is nothing but mapping of "alertify.pgadmin.defaults.js" from defines and named the reference object to 'alertify' so no need to change any function call like "alertify.success, alertify.error". One more benefit of the above approach is if in future we want to use the same style for alertify.warning, alertify.info, alertify.message etc.., we will just have to extend that method in "alertify.pgadmin.defaults.js" and no need to change the rest of the function call with AlertifyWrapper. Attached is the POC patch, if it looks good then I'll start working on replacing AlertifyWrapper with the above mentioned approach. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* improved_alertify_wrapper.patch Description: Binary data
Re: Discussion on improving alertify notifications logic
Hi Sara On Fri, Jul 28, 2017 at 9:19 AM, Sarah McAlear wrote: > Hi Akshay! > > That seems like a good idea. When we're using the extended > pgadmin.alerrtify in the codebase it would be beneficial to call it > pgAdminAlertify or something similar so that it is clear that it isn't only > the alertify library, but it's been extended. > Thanks, but If I understand to you correctly calling it pgAdminAlertify will required code changes wherever alertify. is called. > > Rob & Sarah > > On Thu, Jul 27, 2017 at 9:41 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> As in commit "Update alertify alerts to use the styling defined in >> the style guide": >> >> https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff >> ;h=2a30a86e7d5e562040500f448fbb0d143ff2cff9 >> >> https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff >> ;h=f2d2075d81718ec02550fb592851aa330d327b24 >> >> We have introduce new wrapper class "AlertifyWrapper" and replace calls >> to alertify.success and alertify.error with following two lines in most >> of the files >> >> var alertifyWrapper = new AlertifyWrapper(); >> >> alertifyWrapper.success(message); or alertifyWrapper.error(message); >> >> For each call we are creating dynamic object of AlertifyWrapper and call >> the appropriate function. For example there are 20 such calls in a single >> js file every time are are creating object and call appropriate >> function. >> >> I have tried to improve the logic here and implemented it as below: >> >>- Extend alertify and move success, error and info functions from " >>alertify_wrapper.js" file to "alertify.pgadmin.defaults.js", there >>will be no use of "alertify_wrapper.js" >>- Modify only "server.js" as POC, remove 'alertify' and replace >>'sources/alerts/alertify_wrapper' with 'pgadmin.alertifyjs' which is >>nothing but mapping of "alertify.pgadmin.defaults.js" from defines >>and named the reference object to 'alertify' so no need to change any >>function call like "alertify.success, alertify.error". >> >> One more benefit of the above approach is if in future we want to use the >> same style for alertify.warning, alertify.info, alertify.message etc.., >> we will just have to extend that method in "alertify.pgadmin.defaults.js" >> and no need to change the rest of the function call with AlertifyWrapper. >> >> >> Attached is the POC patch, if it looks good then I'll start working on >> replacing AlertifyWrapper with the above mentioned approach. >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 >> <+91%2097678%2088246>* >> > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: Discussion on improving alertify notifications logic
Hi All On Fri, Jul 28, 2017 at 1:51 PM, Dave Page wrote: > > > On Thu, Jul 27, 2017 at 2:41 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> As in commit "Update alertify alerts to use the styling defined in >> the style guide": >> >> https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff >> ;h=2a30a86e7d5e562040500f448fbb0d143ff2cff9 >> >> https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff >> ;h=f2d2075d81718ec02550fb592851aa330d327b24 >> >> We have introduce new wrapper class "AlertifyWrapper" and replace calls >> to alertify.success and alertify.error with following two lines in most >> of the files >> >> var alertifyWrapper = new AlertifyWrapper(); >> >> alertifyWrapper.success(message); or alertifyWrapper.error(message); >> >> For each call we are creating dynamic object of AlertifyWrapper and call >> the appropriate function. For example there are 20 such calls in a single >> js file every time are are creating object and call appropriate >> function. >> >> I have tried to improve the logic here and implemented it as below: >> >>- Extend alertify and move success, error and info functions from " >>alertify_wrapper.js" file to "alertify.pgadmin.defaults.js", there >>will be no use of "alertify_wrapper.js" >>- Modify only "server.js" as POC, remove 'alertify' and replace >>'sources/alerts/alertify_wrapper' with 'pgadmin.alertifyjs' which is >>nothing but mapping of "alertify.pgadmin.defaults.js" from defines >>and named the reference object to 'alertify' so no need to change any >>function call like "alertify.success, alertify.error". >> >> One more benefit of the above approach is if in future we want to use the >> same style for alertify.warning, alertify.info, alertify.message etc.., >> we will just have to extend that method in "alertify.pgadmin.defaults.js" >> and no need to change the rest of the function call with AlertifyWrapper. >> >> >> Attached is the POC patch, if it looks good then I'll start working on >> replacing AlertifyWrapper with the above mentioned approach. >> > > I like the approach - it's definitely cleaner, and saves instantiating a > new object every time. > I have modified the logic to improve the usage of alrtify notification. Attached is the patch file which contains following: - Replace 'alertify' with 'pgadmin.alertifyjs' in define[]. - Remove 'sources/alerts/alertify_wrapper' from define[]. - Replace calls var alertifyWrapper = new AlertifyWrapper(); alertifyWrapper.success(message); or alertifyWrapper*.error(message); *with appropriate (alertify.success/alertify.error..) - Modified test case written for alertify wrapper. Please review it and if it looks good then I'll commit the code. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* Improved_Alertify_Notification.patch Description: Binary data
pgAdmin 4 commit: 1) Added partition module in webpack config.
1) Added partition module in webpack config. 2) Fixed missing logic of partition from primary_key.js and unique_constraint.js as this two files are newly created for webpack. 3) Changed the node name from 'check_constraint' to 'check_constraints'. Also changed the same in test case url. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a7f58e2b929a3c4143f74a3afb0c16aaa198da1e Modified Files -- .../constraints/check_constraint/__init__.py | 2 +- .../tests/test_check_constraint_add.py | 2 +- .../tests/test_check_constraint_delete.py | 2 +- .../tests/test_check_constraint_get.py | 2 +- .../tests/test_check_constraint_put.py | 2 +- .../index_constraint/static/js/primary_key.js | 22 -- .../static/js/unique_constraint.js | 20 ++--- .../tables/partitions/static/js/partition.js | 34 +++--- web/webpack.config.js | 3 +- 9 files changed, 59 insertions(+), 30 deletions(-)
pgAdmin 4 commit: Improved alertify notification logic. Remove Alertify
Improved alertify notification logic. Remove AlertifyWrapper class and extend notification methods in alertify itself. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e506fa1dbea02f4801c1b916ff23e28f2a302911 Modified Files -- .../servers/databases/casts/static/js/cast.js | 10 ++-- .../schemas/synonyms/static/js/synonym.js | 9 ++-- .../check_constraint/static/js/check_constraint.js | 12 ++--- .../foreign_key/static/js/foreign_key.js | 12 ++--- .../tables/partitions/static/js/partition.js | 29 --- .../databases/schemas/tables/static/js/table.js| 24 +++-- .../schemas/tables/triggers/static/js/trigger.js | 17 +++ .../databases/schemas/views/static/js/mview.js | 9 ++-- .../servers/databases/static/js/database.js| 22 +++- .../servers/pgagent/static/js/pga_job.js | 13 ++--- .../server_groups/servers/static/js/server.js | 58 -- .../servers/tablespaces/static/js/tablespace.js| 15 ++ web/pgadmin/browser/static/js/browser.js | 7 ++- web/pgadmin/browser/static/js/node.js | 10 ++-- web/pgadmin/dashboard/static/js/dashboard.js | 24 - .../misc/file_manager/static/js/file_manager.js| 12 ++--- web/pgadmin/misc/file_manager/static/js/utility.js | 37 +- web/pgadmin/static/js/alertify.pgadmin.defaults.js | 56 +++-- web/pgadmin/static/js/alerts/alertify_wrapper.js | 55 web/pgadmin/tools/backup/static/js/backup.js | 13 ++--- web/pgadmin/tools/debugger/static/js/direct.js | 29 --- .../tools/import_export/static/js/import_export.js | 9 ++-- .../tools/maintenance/static/js/maintenance.js | 12 ++--- web/pgadmin/tools/restore/static/js/restore.js | 10 ++-- web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 29 --- .../user_management/static/js/user_management.js | 18 +++ .../javascript/alerts/alertify_wrapper_spec.js | 18 +++ web/webpack.shim.js| 2 +- web/webpack.test.config.js | 1 + 29 files changed, 220 insertions(+), 352 deletions(-)
pgAdmin 4 commit: Domain create dialog do not open and Font size issue
Domain create dialog do not open and Font size issue in Security label control. Fixes #2616 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6717aff8f5f7c782b9d53facb14678b21af9b13e Author: Murtuza Zabuawala Modified Files -- .../servers/databases/schemas/domains/static/js/domain.js| 2 +- web/pgadmin/browser/server_groups/servers/static/js/server.js| 1 + web/pgadmin/static/css/bootstrap.overrides.css | 5 + 3 files changed, 7 insertions(+), 1 deletion(-)
Re: [pgAdmin4][Patch]: Fix the Domain Create dialog issue
Thanks patch applied. On Mon, Jul 31, 2017 at 12:57 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix two issues, > > 1) Domain's Create/Properties dialog do not open due to JS error. > - Global variable issue. > > 2) Security label control's label font size issue. > - Backgrid adds backbone model id(which is 'label' in our case) in as a > class in tag causing font size class collision with Bootstrap's label > class. > > RM#2616 > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fixed collation tests on Windows, replace use of defa
Fixed collation tests on Windows, replace use of default 'POSIX' collation with 'C' collation for testing. Fixes #2501 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bebfc627218eccce596caf8fea69eae14682ca7c Author: Murtuza Zabuawala Modified Files -- .../servers/databases/schemas/collations/tests/test_collation_add.py| 2 +- .../server_groups/servers/databases/schemas/collations/tests/utils.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Re: [pgAdmin4][Patch]: To fix Collation tests
Thanks, patch applied. On Tue, Aug 1, 2017 at 4:26 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the Collation tests on Windows, Instead of default > "POSIX" collation, we have now used default "C" collation for testing, I > have tested it macOS, Linux & Windows platform the tests are working fine. > RM#2501 > > I have also reported bug in Postgres community regarding "POSIX" collation > issue on Windows. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fixed issue in query tool where messages were not dis
Fixed issue in query tool where messages were not displaying from functions/procedures properly. Fixes #2555 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ef48c2ed91b023e4075259c3279484b48f437e49 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/sqleditor/__init__.py| 28 -- web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 5 ++-- 2 files changed, 12 insertions(+), 21 deletions(-)
Re: [pgAdmin4][Patch]: To fix Function/Procedures messages issue in query tool
Thanks patch applied. On Wed, Aug 2, 2017 at 4:10 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where in query tool, messages were not > displaying from functions/procedures properly. > RM#2555 > > Needs to be reviewed with (Success/Fail/Error scenarios): > 1) Table output > 2) Function output > 3) Procedure output (EPAS) > 4) Adhoc query output (like vacuum) > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Added missing pgagent file in webpack.config.js Fixes
Added missing pgagent file in webpack.config.js Fixes #2617 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=06a65ecf71ccbbfb20cce86ebc1ad0b4b4289cdd Author: Surinder Kumar Modified Files -- web/webpack.config.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Re: [Patch][pgAdmin4]: RM_2617 - pgAgent module is not loading after webpacking
Thanks, patch applied. On Tue, Aug 1, 2017 at 11:45 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > Added an entry for pgAgent JS module to imports-loader to fix the issue. > > Please find attached patch and let me know for review comments. > > Thanks, > Surinder > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Set the database name to blank('') when job type is s
Set the database name to blank('') when job type is set to batch, while
creating pgAgent job. Fixes #2620
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=801a05891e94304d267e91adb98a92b5d8ea48cd
Modified Files
--
.../server_groups/servers/pgagent/templates/macros/pga_jobstep.macros | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Re: [pgAdmin4][Patch]: RM_ 2620 - Getting error "Violates check constraint" while creating pgAgent job
Hi Surinder As per discussion, this should be fixed at server side instead of client(js) side. I have fixed and committed the code. On Wed, Aug 2, 2017 at 6:07 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > It gives error because database value is passed in query generated when > jobstep > > kind == 'batch'. > the database value must be ‘’, if jobstep > kind == 'batch' as per check > constraint: > > "pga_jobstep_check1" CHECK (jstdbname <> ''::name AND jstkind = 's'::bpchar > OR jstdbname = ''::name AND (jstkind = 'b'::bpchar OR jstconnstr <> '' > ::text)) > > Please find attached patch and review. > > Thanks, > Surinder > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Changed the mapping of cell from 'numeric' to 'intege
Changed the mapping of cell from 'numeric' to 'integer' for integer control as numeric cell has been removed from the code. Fixes #2631 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e418cb838730ce186c620cdf39c064eca02a7d61 Modified Files -- web/pgadmin/browser/server_groups/servers/roles/static/js/role.js | 2 +- web/pgadmin/static/js/backform.pgadmin.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
pgAdmin 4 commit: Use dict based data instead of 2d-array in Type modul
Use dict based data instead of 2d-array in Type module as we are adding keys on the fly. Reviewed By: Harshal Dhumal Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2c6c4a16cecd8586c9ee5c9fa8456b6074813f46 Author: Murtuza Zabuawala Modified Files -- .../browser/server_groups/servers/databases/schemas/types/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: [pgAdmin4][Patch]: Use the correct resultset type for Type module
Thanks patch applied. On Wed, Aug 9, 2017 at 4:25 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > > On Wed, Aug 9, 2017 at 8:57 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Thu, Aug 3, 2017 at 2:41 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA minor patch to use fetch dict based data instead of 2d-array based >>> in Type module as we are adding keys on the fly. >>> There is no RM just a minor enhancement. >>> >> Harshal, >> >> Please review this one. >> > I tested this and it's working fine. > > > >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> <http://www.enterprisedb.com/> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> <http://www.linkedin.com/in/asheshvashi> >> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: 1) Connection Type cell was not honouring to 'Kind' o
1) Connection Type cell was not honouring to 'Kind' option in Subnode control. 2) Kind option was not saved properly 3) User was not be able to update Kind option in edit mode. Fixes #2633 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2df4625ce01847e840d00661010d8ac130ed093d Author: Murtuza Zabuawala Modified Files -- .../servers/pgagent/steps/static/js/pga_jobstep.js | 43 +- .../pgagent/templates/macros/pga_jobstep.macros| 9 - 2 files changed, 48 insertions(+), 4 deletions(-)
Re: [pgAdmin4][PATCH] To fix pgAgent job step issues
Thanks patch applied with one minor change. On Wed, Aug 16, 2017 at 6:12 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to fix below given issues from pgAgent Jobs > Steps module. > 1) 'Connection Type' cell was not honouring to 'Kind' option in Subnode > control. > 2) Kind option was not saved properly > 3) User was not be able to update Kind option in edit mode. > RM#2633 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > [image: https://community.postgresrocks.net/] > <https://community.postgresrocks.net/> > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fixed the path reference of load-node.gif which was r
Fixed the path reference of load-node.gif which was referencing to vendor directory. Fixes #2646 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bff48e0b2de6ba7e63f1f3ee8ae6cadfabf75938 Author: Surinder Kumar Modified Files -- web/pgadmin/browser/server_groups/servers/templates/css/servers.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Re: [pgAdmin4][Patch]: RM_2646 - Spinner icon not found error when a server node is connected
Thanks patch applied. On Fri, Aug 11, 2017 at 12:35 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Since Acitree is removed from vendor directory, but when a server is > connected, the load-node.gif file is still referencing tovendor directory > instead of referencing to static/js/generated/load-node.gif. > > Fixed the reference path, now it points to static/js/generated/laod-node. > gif. > > Please find attached patch and review. > > Thanks, > Surinder > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: [pgAdmin4][Patch]: RM_ 2582 - Backup : Fix compression value
Thanks patch applied. I have adding server side validation too. On Wed, Aug 16, 2017 at 6:11 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > *Issue:* > In Backup, compression field can only accept values between 0 to 9. But if > the field is clicked, an empty value is set into the model, So, added a > check to remove the model attribute if the field is an empty string before > data is sent to the server. > > Please find attached patch. > > Thanks, > Surinder > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Unset compression ratio if it is an empty string in B
Unset compression ratio if it is an empty string in Backup module. Fixes #2582 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7686dee054ef8a77ace02c1c4e4eed65a475602 Author: Surinder Kumar Modified Files -- web/pgadmin/tools/backup/__init__.py | 4 web/pgadmin/tools/backup/static/js/backup.js | 6 ++ 2 files changed, 10 insertions(+)
pgAdmin 4 commit: Fixed alertify notification messages where checkmark
Fixed alertify notification messages where checkmark box disconnected from frame. Fixes #2644 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dee5186f655b46ac239a504d676c571e1e071d20 Author: Sarah McAlear Modified Files -- web/pgadmin/static/scss/_alertify.overrides.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: [pgAdmin4][patch] update the alert style in the sub-navigation
gt;>>>>>>>> object,
>>>>>>>>>>> great idea!
>>>>>>>>>>>
>>>>>>>>>>> Thanks,
>>>>>>>>>>> Sarah
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Wed, Aug 9, 2017 at 1:42 PM, Surinder Kumar <
>>>>>>>>>>> surinder.ku...@enterprisedb.com> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi Wenlin,
>>>>>>>>>>>>
>>>>>>>>>>>> On Tue, Aug 8, 2017 at 3:15 PM, Wenlin Zhang >>>>>>>>>>> > wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi Surinder,
>>>>>>>>>>>>>
>>>>>>>>>>>>>Thanks for your review.
>>>>>>>>>>>>>
>>>>>>>>>>>>>We have changed the indentation for _dashboard.scss file
>>>>>>>>>>>>> and also removed the style about icon-postgres:before, like
>>>>>>>>>>>>> margin-top,etc, but we are not sure if it is perfectly aligned
>>>>>>>>>>>>> now, you can
>>>>>>>>>>>>> add further change to it.
>>>>>>>>>>>>>
>>>>>>>>>>>>> As the second comment, I'm sorry I'm not sure what's the
>>>>>>>>>>>>> problem, could you please clarify it? Because we replace css with
>>>>>>>>>>>>> scss
>>>>>>>>>>>>> right now, dashboard.css doesn't exist. So maybe you are looking
>>>>>>>>>>>>> at the css
>>>>>>>>>>>>> file that are complied by the scss?
>>>>>>>>>>>>>
>>>>>>>>>>>> Sorry I typed 'dashboard.css' instead of 'dashboard.js'.
>>>>>>>>>>>> In dashboard.js can we change `return DashboardAlert;` to
>>>>>>>>>>>> `return new DashboardAlert();`
>>>>>>>>>>>> and then we can remove the instances being created(var
>>>>>>>>>>>> alertDashboard = new AlertDashboard();) from dashboard.js, and
>>>>>>>>>>>> simply
>>>>>>>>>>>> use `AlertDashboard.info('message')`.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> For the fourth comment, we tried the steps you suggested
>>>>>>>>>>>>> on master branch, the error is not shown either. So it should be
>>>>>>>>>>>>> an
>>>>>>>>>>>>> existing issue. But if you want to see the error message,
>>>>>>>>>>>>> navigate to
>>>>>>>>>>>>> "Servers" at the top of browser, then navigate back to postgresql
>>>>>>>>>>>>> server,
>>>>>>>>>>>>> then you will see the error message.
>>>>>>>>>>>>>
>>>>>>>>>>>> The error in console will appear when you selected a database
>>>>>>>>>>>> which is connected and stop the backend Python server because the
>>>>>>>>>>>> request
>>>>>>>>>>>> for graphs for database level will fail and there is no response
>>>>>>>>>>>> returned
>>>>>>>>>>>> from server.
>>>>>>>>>>>> It might be not reproducible to you If you set the refresh rate
>>>>>>>>>>>> to higher value (i.e. Preferences > Graphs) in preferences. Just
>>>>>>>>>>>> set
>>>>>>>>>>>> refresh rate to 1 for all dashboard graphs and repeat the steps.
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
pgAdmin 4 commit: User can not add New Server through Quick links. Fixe
User can not add New Server through Quick links. Fixes #2634 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e9b80dae9c0dc3e054512c16b4c38a98c8980c93 Author: Murtuza Zabuawala Modified Files -- .../browser/server_groups/servers/roles/static/js/role.js | 3 +-- web/pgadmin/browser/templates/browser/js/utils.js | 2 +- web/pgadmin/dashboard/static/js/dashboard.js | 10 ++ web/pgadmin/static/js/check_node_visibility.js | 2 +- 4 files changed, 9 insertions(+), 8 deletions(-)
Re: [pgAdmin4][PATCH] To fix the add New Server through Quick links on Dashboard
Thanks patch applied. On Tue, Aug 8, 2017 at 1:55 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for the same. > > Thanks Surinder for pointing that out, I assumed that we had a typo in > that file. > > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > [image: https://community.postgresrocks.net/] > <https://community.postgresrocks.net/> > > On Tue, Aug 8, 2017 at 12:18 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi Murtuza, >> >> As type server-group is renamed to server_group, I can see there are >> other occurrences of string server-group which needs to be replaced when >> I perform search in pgAdmin4. >> >> Can you please take care of those occurrences? >> >> Thanks, >> Surinder >> >> On Tue, Aug 8, 2017 at 12:02 PM, Murtuza Zabuawala >> [murtuza.zabuaw...@enterprisedb.com](mailto:murtuza. >> zabuaw...@enterprisedb.com) >> <http://mailto:%5bmurtuza.zabuaw...@enterprisedb.com%5D(mailto:murtuza.zabuaw...@enterprisedb.com)> >> wrote: >> >> Hi, >>> >>> PFA minor patch to fix the issue where add new server functionality >>> through Quick link on Dashboard is broken. >>> RM#2634 >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> [image: https://community.postgresrocks.net/] >>> <https://community.postgresrocks.net/> >>> >> >> > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Datetimepicker will expand from bottom instead of Top
Datetimepicker will expand from bottom instead of Top, because of that user won't be able to select start and end time properly. Fixes #2656 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb9a05a7e7fb09b39afffb016b8824074eb325aa Author: Surinder Kumar Modified Files -- web/pgadmin/static/js/backform.pgadmin.js | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)
Re: [Patch][pgAdmin4][pgAgent]: RM_2656 - Unable to select start and end time for scheduler from calendar
Thanks patch applied. On Wed, Aug 23, 2017 at 10:16 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Adding more info... > > Before this patch, when Datetimepicker is selected, it expands from the > top, so it was impossible to scroll and hence the user cannot select the > date. > > Now, after applying this patch, the Datetimepicker will expand to bottom > and the subgrid will be scrollable, so the user can easily select the date > time and other options as well. > > Thanks, > Surinder > > > On Wed, Aug 23, 2017 at 10:08 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> *Issue:* >> >> When a user tries to select start and end time using the calendar, the >> calendar gets hidden and inaccessible to the user. >> >> *Solution:* >> >> Set `Backform.DatetimepickerControl` option `widget positioning > >> vertical` to `bottom` which ensures Datepicker widget expands to bottom >> whenever it is opened. >> >> Please find attached patch and review. >> >> Thanks, >> Surinder >> >> > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Syntax error while saving changes for start/end time,
Syntax error while saving changes for start/end time, weekdays, monthdays, month, hours, minutes while updating the pgAgent Job. Fixes #2657. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee20a10e9410f2ce5024a7b8e4fa758706dc52d0 Author: Surinder Kumar Modified Files -- .../servers/pgagent/schedules/static/js/pga_schedule.js | 10 +- .../servers/pgagent/templates/macros/pga_schedule.macros| 13 +++-- 2 files changed, 12 insertions(+), 11 deletions(-)
Re: [pgAdmin4] [pgAgent] [Patch]: RM_ 2657 - Syntax error while saving changes when start/end time is changed from scheduler
Thanks patch applied. While reviewing the patch I have found one more issue where user won't be able to update Week Days, Month Days, Months, Hours and Minutes as well, so I have fixed it as well. On Tue, Aug 22, 2017 at 1:12 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > *Issues fixed:* > > - Syntax error while saving changes when start/end time is updating in > Edit mode. > - The data type of `jscstart` should be `timestamptz` not `text`. > > Please find attached patch and review. > > Thanks, > Surinder > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Unable to add/update variables for columns of a table
Unable to add/update variables for columns of a table. Fixes #2659 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe6e4686a2bf5d9d7db438d209d4d4d6783543ce Modified Files -- .../schemas/tables/column/static/js/column.js | 1 + .../servers/databases/schemas/tables/utils.py | 18 +- 2 files changed, 10 insertions(+), 9 deletions(-)
pgAdmin 4 commit: Greenplum specific DDL and Dashboard display changes.
Greenplum specific DDL and Dashboard display changes. Initial patch by Sarah McAlear. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=46c5df4e7bb7abba6896cfb86eed43914a74850a Author: Teng Zhang Modified Files -- web/config.py | 3 +- .../templates/table/sql/gpdb_5.0_plus/create.sql | 168 + .../table/sql/gpdb_5.0_plus/properties.sql | 82 ++ .../servers/databases/schemas/tables/utils.py | 7 +- web/pgadmin/browser/server_groups/servers/gpdb.py | 20 +++ web/pgadmin/dashboard/__init__.py | 7 +- .../dashboard/sql/gpdb_5.0_plus/activity.sql | 14 ++ .../dashboard/sql/gpdb_5.0_plus/locks.sql | 22 +++ .../dashboard/sql/gpdb_5.0_plus/session_stats.sql | 4 + .../gpdb_5.0_plus/some_action_with_gpdb_5_0.sql| 1 + .../utils/tests/test_versioned_template_loader.py | 36 - web/pgadmin/utils/versioned_template_loader.py | 39 +++-- 12 files changed, 385 insertions(+), 18 deletions(-)
Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display
t;>> On Mon, Aug 21, 2017 at 8:50 AM, Jing Li >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi Dave, >>>>>>>>>> >>>>>>>>>> Since we're hoping to get this change working for GPDB we've >>>>>>>>>> currently using this method to detect if it's gpdb and show the >>>>>>>>>> appropriate >>>>>>>>>> graphs. Right now it displays errors on the dashboard if it's >>>>>>>>>> connected to >>>>>>>>>> a gpdb server. >>>>>>>>>> For this patch specifically, the goal is to improve the >>>>>>>>>> experience for greenplum users so they can get the same information >>>>>>>>>> as >>>>>>>>>> someone connected to a postgres server. >>>>>>>>>> >>>>>>>>>> I do agree that this is a bigger discussion about how we handle >>>>>>>>>> behavior change overall if it's regular postgres or something else. >>>>>>>>>> Let's >>>>>>>>>> talk about how we can restructure this behavior in a wider context. >>>>>>>>>> Are you >>>>>>>>>> open to meeting about it? >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> ~Jing >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Violet. >>>>>>>>>>> >>>>>>>>>>> I don't really like the way this has been implemented. It adds a >>>>>>>>>>> variable which is only used for gpdb. >>>>>>>>>>> >>>>>>>>>>> There are other places in the code where the behaviour is >>>>>>>>>>> changed if the server is ppas or regular postgres. >>>>>>>>>>> >>>>>>>>>>> Candidly I think all of this needs restructuring. >>>>>>>>>>> >>>>>>>>>>> Dave Cramer >>>>>>>>>>> >>>>>>>>>>> On 15 August 2017 at 23:29, Violet Cheng >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> Any comment on this patch? If no, will it be committed soon? >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Violet >>>>>>>>>>> >>>>>>>>>>> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear < >>>>>>>>>>> smcal...@pivotal.io> wrote: >>>>>>>>>>> >>>>>>>>>>> Hi Hackers! >>>>>>>>>>> >>>>>>>>>>> This patch enables Greenplum users to see the same charts on the >>>>>>>>>>> dashboard as postgres users. It also adds some additional >>>>>>>>>>> information to >>>>>>>>>>> the DDL that is Greenplum specific and necessary to create a new >>>>>>>>>>> table. >>>>>>>>>>> >>>>>>>>>>> Thanks! >>>>>>>>>>> Sarah >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Dave Page >>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>> Twitter: @pgsnake >>>>>>>>> >>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >>> >> > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: pgAdmin 4 commit: Update docs to more accurately reflect the SERVER_MOD
Hi Dave Changes looks good to me, only one thing is that I also override 'DATA_DIR' and 'TEST_SQLITE_PATH' parameter in my config_local.py, so we should include both the parameters in 'desktop_deployment.rst' file. On Fri, Aug 25, 2017 at 4:45 PM, Dave Page wrote: > Akshay, Ashesh, > > I've committed these doc changes to reflect the paths/SERVER_MODE changes. > Could you both please review them and let me know if I missed anything of > importance, or if anything isn't clear? > > Thanks. > > On Fri, Aug 25, 2017 at 12:13 PM, Dave Page wrote: > >> Update docs to more accurately reflect the SERVER_MODE config >> requirements. >> >> Branch >> -- >> master >> >> Details >> --- >> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif >> f;h=5c016f0993fb557052cce7e11cd6ad818bd7c3a3 >> >> Modified Files >> -- >> docs/en_US/desktop_deployment.rst | 39 ++ >> - >> docs/en_US/server_deployment.rst | 18 -- >> 2 files changed, 18 insertions(+), 39 deletions(-) >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fixed issue where 'backend_type' column is exist for
Fixed issue where 'backend_type' column is exist for database server version greater than 10. Issue is regression of RM #2597. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=401e13ca650e06f2ee9c2220d0c7b7dcbbcf6dd6 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/dashboard/static/js/dashboard.js| 21 ++--- .../templates/dashboard/sql/10_plus/activity.sql| 19 +++ .../templates/dashboard/sql/9.6_plus/activity.sql | 3 +-- 3 files changed, 34 insertions(+), 9 deletions(-)
Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard
gt;>> >>>>> >>>>> >>>>>> >>>>>> Regards, >>>>>> Chethana kumar >>>>>> >>>>>> >>>>>> >>>>>> On Fri, Jul 28, 2017 at 4:11 PM, Dave Page wrote: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> I took a quick look at this and have a couple of thoughts: >>>>>>> >>>>>>> - Instead of the "edit" icon to open the subnode, we should use >>>>>>> something more appropriate - a "properties" icon perhaps. >>>>>>> >>>>>>> - There seems to be a lot of different shades of grey on there >>>>>>> (maybe a subnode design in general that just shows up with the disabled >>>>>>> controls), and the subnode control looks a bit messy as a result. >>>>>>> >>>>>>> Can you work with Chethana to improve the look and feel please? >>>>>>> >>>>>>> Input from others welcome of course - screenshot attached. >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> On Fri, Jul 28, 2017 at 11:33 AM, Murtuza Zabuawala < >>>>>>> murtuza.zabuaw...@enterprisedb.com> wrote: >>>>>>> >>>>>>>> ++ Attaching the patch >>>>>>>> >>>>>>>> -- >>>>>>>> Regards, >>>>>>>> Murtuza Zabuawala >>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>>> On Fri, Jul 28, 2017 at 4:02 PM, Murtuza Zabuawala < >>>>>>>> murtuza.zabuaw...@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi Dave, >>>>>>>>> >>>>>>>>> PFA patch to display additional information from pg_stat_activity >>>>>>>>> table using subnode control. >>>>>>>>> RM#2597 >>>>>>>>> >>>>>>>>> Please review. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Regards, >>>>>>>>> Murtuza Zabuawala >>>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>>> On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> >>>>>>>>>>> On Mon, Jul 24, 2017 at 8:11 PM, Dave Page >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang >>>>>>>>>>> > wrote: >>>>>>>>>>>> >>>>>>>>>>>>> 2-3 days is a lot of valuable engineering time. Is this a >>>>>>>>>>>>> 'drop everything now' kind of feature or can this wait for some >>>>>>>>>>>>> user >>>>>>>>>>>>> validation on a mock up first? >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Most of the time will likely be on the infrastructure to change >>>>>>>>>>>> the display to a subnode control. If you have some cycles to mockup >>>>>>>>>>>> potential layouts for the subnode view and have them validated, >>>>>>>>>>>> please feel >>>>>>>>>>>> free, however, that seems like an awful lot of work to me to >>>>>>>>>>>> display some >>>>>>>>>>>> missing SQL using a standard control. >>>>>>>>>>>> >>>>>>>>>>> Regarding SQL display: Developing simple control to show >>>>>>>>>>> codemirror in disabled state (for now) wont take that much time. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> Part of a product designer's job is to make sure there is a >>>>>>>>>> definitive need for a feature and that the interface for the feature >>>>>>>>>> is >>>>>>>>>> designed in such a way that the user gets all intended value from >>>>>>>>>> it. Time >>>>>>>>>> spent validating now will decrease the time spent later on >>>>>>>>>> redesigning / >>>>>>>>>> reimplementing. >>>>>>>>>> >>>>>>>>>> If everyone is aware of what that value is and confident that how >>>>>>>>>> it'll be displayed is right, there's little risk in starting to >>>>>>>>>> develop it. >>>>>>>>>> If we're wrong, it'll add to feature bloat and detract from the >>>>>>>>>> experience. >>>>>>>>>> >>>>>>>>>> Would Chethana be able to take on some of the design work? It >>>>>>>>>> would be valuable for the dev team to also be part of design process. >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Chethana Kumar >>>>>> Principal UI/UX Designer >>>>>> EnterpriseDB Corporation >>>>>> >>>>>> >>>>>> The Postgres Database Company >>>>>> >>>>>> P: +91 86981 57146 <+91%2086981%2057146> >>>>>> www.enterprisedb.com >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: 1) Fixed error in alertify.pgNotifier when server con
1) Fixed error in alertify.pgNotifier when server connection is lost. 2) Change styling of alertify.pgNotifier as we did for success, error and info. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=47cf874460dd0fcd0f39af1772e4ba3913020ee1 Modified Files -- web/pgadmin/static/js/alertify.pgadmin.defaults.js | 59 +- 1 file changed, 34 insertions(+), 25 deletions(-)
Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor
On Mon, Sep 11, 2017 at 5:34 PM, Dave Page wrote: > Akshay, can you review/commit this please? > Sure Dave. > > Thanks. > > On Mon, Sep 11, 2017 at 10:38 AM, Teng Zhang wrote: > >> Hi Hackers, >> >> Attached is a patch that makes SQL editor show syntax highlighting with >> Greenplum keywords. >> >> - Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql" >> - Use "x-gpsql" mode for sql editor when connecting database is greenplum >> - No behavior change to pg and ppas, still use "x-pgsql" >> >> Regards, >> Hao Wang & Teng Zhang >> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Highlighting greenplum keywords in sql editor
Highlighting greenplum keywords in sql editor Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=512afd66182f463e6ce9515910205dcf0221e58c Author: Teng Zhang Modified Files -- web/package.json | 2 +- web/pgadmin/tools/datagrid/__init__.py | 7 +++ web/pgadmin/tools/datagrid/static/js/datagrid.js | 11 ++- web/pgadmin/tools/datagrid/templates/datagrid/index.html | 2 +- web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 7 --- web/yarn.lock| 6 +++--- 6 files changed, 22 insertions(+), 13 deletions(-)
Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor
Code looks good to me. Thanks patch applied. On Mon, Sep 11, 2017 at 5:40 PM, Akshay Joshi wrote: > > > On Mon, Sep 11, 2017 at 5:34 PM, Dave Page wrote: > >> Akshay, can you review/commit this please? >> > > Sure Dave. > >> >> Thanks. >> >> On Mon, Sep 11, 2017 at 10:38 AM, Teng Zhang wrote: >> >>> Hi Hackers, >>> >>> Attached is a patch that makes SQL editor show syntax highlighting with >>> Greenplum keywords. >>> >>> - Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql" >>> - Use "x-gpsql" mode for sql editor when connecting database is greenplum >>> - No behavior change to pg and ppas, still use "x-pgsql" >>> >>> Regards, >>> Hao Wang & Teng Zhang >>> >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]
On Tue, Sep 12, 2017 at 2:34 PM, Dave Page wrote: > Adding Akshay... > Sure. > > On Tue, Sep 12, 2017 at 10:04 AM, Dave Page wrote: > >> Akshay, can you review/commit this please? >> >> On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find attached patch to represent array data in datagrid with >>> curly braces and >>> also allow user to save array with values like , , >>> '*""*' and "*''*" >>> >>> -- >>> *Harshal Dhumal* >>> *Sr. Software Engineer* >>> >>> EnterpriseDB India: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]
Harshal, Can you please rebase the patch, it's not applied with the latest code. On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi wrote: > > > On Tue, Sep 12, 2017 at 2:34 PM, Dave Page wrote: > >> Adding Akshay... >> > > Sure. > >> >> On Tue, Sep 12, 2017 at 10:04 AM, Dave Page wrote: >> >>> Akshay, can you review/commit this please? >>> >>> On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal < >>> harshal.dhu...@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> Please find attached patch to represent array data in datagrid with >>>> curly braces and >>>> also allow user to save array with values like , >>> string>, '*""*' and "*''*" >>>> >>>> -- >>>> *Harshal Dhumal* >>>> *Sr. Software Engineer* >>>> >>>> EnterpriseDB India: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]
It works, sorry for the noise. On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi wrote: > Harshal, > > Can you please rebase the patch, it's not applied with the latest code. > > On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Tue, Sep 12, 2017 at 2:34 PM, Dave Page wrote: >> >>> Adding Akshay... >>> >> >> Sure. >> >>> >>> On Tue, Sep 12, 2017 at 10:04 AM, Dave Page wrote: >>> >>>> Akshay, can you review/commit this please? >>>> >>>> On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal < >>>> harshal.dhu...@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please find attached patch to represent array data in datagrid with >>>>> curly braces and >>>>> also allow user to save array with values like , >>>> string>, '*""*' and "*''*" >>>>> >>>>> -- >>>>> *Harshal Dhumal* >>>>> *Sr. Software Engineer* >>>>> >>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Changed array representation and formatting for the d
Changed array representation and formatting for the data types in Query Tool and View Data. Fixes #2671 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=30e701607713edc1ba43173556c911c98fc09eb5 Author: Harshal Dhumal Modified Files -- web/pgadmin/feature_tests/test_data.json | 13 +- web/pgadmin/feature_tests/view_data_dml_queries.py | 23 +-- web/pgadmin/static/js/slickgrid/editors.js | 165 + web/pgadmin/static/js/slickgrid/formatters.js | 151 ++- web/pgadmin/tools/sqleditor/command.py | 70 + web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 72 ++--- .../templates/sqleditor/sql/default/insert.sql | 12 +- .../templates/sqleditor/sql/default/update.sql | 12 +- web/pgadmin/utils/driver/psycopg2/__init__.py | 77 +++--- 9 files changed, 424 insertions(+), 171 deletions(-)
Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]
Thanks patch applied.
On Fri, Sep 15, 2017 at 6:16 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi Akshay,
>
> It's not issue; Try without quotes. As char data type stores only one
> character so it's storing only leading quote (') and
> truncating remaining characters (a').
> Only exception is when you want to store empty string (char) use two
> quotes (either single or double)
> they will translated before sending to server.
>
> Apart from this I found that data types "char" and "char"[] (alias to
> character and character[] respectively)
> were not taken into consideration in sqleditor.js. I have attached updated
> patch which fixes this issue.
>
>
>
>
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Sep 14, 2017 at 5:31 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Harshal
>>
>> I have reviewed your patch it looks good to me. Only one issue I have
>> found with char[], when I store {'a','b','c'} it gets stored and when I
>> refreshed it shows {',','}. Please look into this issue.
>>
>> On Thu, Sep 14, 2017 at 3:54 PM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> It works, sorry for the noise.
>>>
>>> On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
>>>> Harshal,
>>>>
>>>> Can you please rebase the patch, it's not applied with the latest code.
>>>>
>>>> On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <
>>>> akshay.jo...@enterprisedb.com> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Tue, Sep 12, 2017 at 2:34 PM, Dave Page wrote:
>>>>>
>>>>>> Adding Akshay...
>>>>>>
>>>>>
>>>>> Sure.
>>>>>
>>>>>>
>>>>>> On Tue, Sep 12, 2017 at 10:04 AM, Dave Page
>>>>>> wrote:
>>>>>>
>>>>>>> Akshay, can you review/commit this please?
>>>>>>>
>>>>>>> On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal <
>>>>>>> harshal.dhu...@enterprisedb.com> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Please find attached patch to represent array data in datagrid with
>>>>>>>> curly braces and
>>>>>>>> also allow user to save array with values like , >>>>>>> string>, '*""*' and "*''*"
>>>>>>>>
>>>>>>>> --
>>>>>>>> *Harshal Dhumal*
>>>>>>>> *Sr. Software Engineer*
>>>>>>>>
>>>>>>>> EnterpriseDB India: http://www.enterprisedb.com
>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>> Twitter: @pgsnake
>>>>>>>
>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Akshay Joshi*
>>>>> *Principal Software Engineer *
>>>>>
>>>>>
>>>>>
>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> *Akshay Joshi*
>>>> *Principal Software Engineer *
>>>>
>>>>
>>>>
>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>>
>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>> *Principal Software Engineer *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
[pgAdmin4][Patch] RM 2691 View data option is missing from pgAdmin4 2.0 version
Hi Attached is the patch file to fix RM 2691 View data option is missing from pgAdmin4 2.0 version. Apart from the RM this patch includes following fixes: 1) Fixed issue in foreign_table where variable is not declare so it throws an error. 2) Columns and Constraints tab are empty, remove "visible: false" from js file. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_2691.patch Description: Binary data
pgAdmin 4 commit: Filtered Rows dialog not opened from the context menu
Filtered Rows dialog not opened from the context menu. Fixes #2699 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe757c384bac26ca97e7a6c5d735d0b787ad0796 Modified Files -- web/pgadmin/tools/datagrid/static/js/datagrid.js | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)
[pgAdmin4][Patch] RM 2673 Error not displaying in proper format in User management and Grant Wizard
Hi Attached is the patch file to fix RM 2673 "Error not displaying in proper format in User management and Grant Wizard". Patch contains fix for Grant Wizard, as fix for user management is already committed. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_2673.patch Description: Binary data
[pgAdmin4][Patch] RM 2742 Unable to connect to database server with different user and role
Hi Attached is the patch to fix RM 2742 "Unable to connect to database server with different user and role". -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_2742.patch Description: Binary data
[pgAdmin4][Patch]: Fixed RM 2830 Corrupts type CHAR(4) data
Hi All Attached is the patch file to fix RM #2830 "Corrupts type CHAR(4) data". During that I found one more issue where message "Data saved successfully." popped up even if there is an error while saving the data. I have fixed that too. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_2830.patch Description: Binary data
pgAdmin 4 commit: Updated colours of tree view icons, which is to be mo
Updated colours of tree view icons, which is to be more comfortable in identifying. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2be418706dd2ba86d79d2431b67d47cfd133c6fb Author: Chethana Kumar Modified Files -- .../browser/server_groups/servers/databases/casts/static/img/cast.svg | 2 +- .../server_groups/servers/databases/casts/static/img/coll-cast.svg | 2 +- .../servers/databases/event_triggers/static/img/coll-event_trigger.svg | 2 +- .../servers/databases/event_triggers/static/img/event_trigger.svg | 2 +- .../servers/databases/event_triggers/static/img/triggerbad.svg | 2 +- .../servers/databases/extensions/static/img/coll-extension.svg | 2 +- .../server_groups/servers/databases/extensions/static/img/extension.svg | 2 +- .../foreign_servers/static/img/coll-foreign_server.svg | 2 +- .../foreign_data_wrappers/foreign_servers/static/img/foreign_server.svg | 2 +- .../foreign_servers/user_mapping/static/img/coll-user_mapping.svg | 2 +- .../foreign_servers/user_mapping/static/img/user_mapping.svg| 2 +- .../foreign_data_wrappers/static/img/coll-foreign_data_wrapper.svg | 2 +- .../databases/foreign_data_wrappers/static/img/foreign_data_wrapper.svg | 2 +- .../servers/databases/languages/static/img/coll-language.svg| 2 +- .../server_groups/servers/databases/languages/static/img/language.svg | 2 +- .../catalog_objects/columns/static/img/catalog_object_column.svg| 2 +- .../catalog_objects/columns/static/img/coll-catalog_object_column.svg | 2 +- .../databases/schemas/catalog_objects/static/img/catalog_object.svg | 2 +- .../schemas/catalog_objects/static/img/coll-catalog_object.svg | 2 +- .../servers/databases/schemas/collations/static/img/coll-collation.svg | 2 +- .../servers/databases/schemas/collations/static/img/collation.svg | 2 +- .../domains/domain_constraints/static/img/coll-domain_constraints.svg | 2 +- .../domains/domain_constraints/static/img/domain_constraints-bad.svg| 2 +- .../domains/domain_constraints/static/img/domain_constraints.svg| 2 +- .../servers/databases/schemas/domains/static/img/coll-domain.svg| 2 +- .../servers/databases/schemas/domains/static/img/domain.svg | 2 +- .../databases/schemas/foreign_tables/static/img/coll-foreign_table.svg | 2 +- .../databases/schemas/foreign_tables/static/img/foreign_table.svg | 2 +- .../schemas/fts_configurations/static/img/coll-fts_configuration.svg| 2 +- .../schemas/fts_configurations/static/img/fts_configuration.svg | 2 +- .../databases/schemas/fts_dictionaries/static/img/fts_dictionary.svg| 2 +- .../servers/databases/schemas/fts_parser/static/img/coll-fts_parser.svg | 2 +- .../servers/databases/schemas/fts_parser/static/img/fts_parser.svg | 2 +- .../databases/schemas/fts_templates/static/img/coll-fts_template.svg| 2 +- .../servers/databases/schemas/fts_templates/static/img/fts_template.svg | 2 +- .../servers/databases/schemas/functions/static/img/coll-function.svg| 2 +- .../servers/databases/schemas/functions/static/img/coll-procedure.svg | 2 +- .../databases/schemas/functions/static/img/coll-trigger_function.svg| 2 +- .../servers/databases/schemas/functions/static/img/function.svg | 2 +- .../servers/databases/schemas/functions/static/img/procedure.svg| 2 +- .../servers/databases/schemas/functions/static/img/trigger_function.svg | 2 +- .../databases/schemas/packages/edbfuncs/static/img/coll-edbfunc.svg | 2 +- .../databases/schemas/packages/edbfuncs/static/img/coll-edbproc.svg | 2 +- .../servers/databases/schemas/packages/edbfuncs/static/img/edbfunc.svg | 2 +- .../servers/databases/schemas/packages/edbfuncs/static/img/edbproc.svg | 2 +- .../databases/schemas/packages/edbvars/static/img/coll-edbvar.svg | 2 +- .../servers/databases/schemas/packages/edbvars/static/img/edbvar.svg| 2 +- .../servers/databases/schemas/packages/static/img/coll-package.svg | 2 +- .../servers/databases/schemas/packages/static/img/package.svg | 2 +- .../servers/databases/schemas/sequences/static/img/coll-sequence.svg| 2 +- .../servers/databases/schemas/sequences/static/img/sequence.svg | 2 +- .../server_groups/servers/databases/schemas/static/img/catalog.svg | 2 +- .../server_groups/servers/databases/schemas/static/img/coll-catalog.svg | 2 +- .../server_groups/servers/databases/schemas/static/img/coll-schema.svg | 2 +- .../server_groups/servers/databases/schemas/static/img/schema.svg | 2 +- .../servers/databases/schemas/synonyms/static/img/coll-synonym.svg | 2 +- .../servers/databases/schemas/synonyms/static/img/synonym.svg | 2 +- .../servers/databases/schemas/tables/column/static/img/coll-column.svg | 2 +- .../servers/databases/schemas/tables/column/static/img/column.svg | 2 +- .../constraints/check_constraint/static/img/check-cons
Re: [pgAdmin4][Patch]: Fixed RM 2844 Tree View Icons
Thanks patch applied. On Fri, Nov 3, 2017 at 10:22 PM, Dave Page wrote: > Akshay, can you review/commit this please? > > On Fri, Nov 3, 2017 at 1:07 PM, Chethana Kumar < > chethana.ku...@enterprisedb.com> wrote: > >> Hello Team, >> >> I am sharing you some updates in response to the feedback received from >> the customers side for the "tree view icons". >> >> *Issue Raised* - >> - User mental model is more comfortable in identifying the tree view >> icons by their colours. >> - User feels difficulty and takes time in identifying the icons with the >> blue theme icons >> >> *Solution* - >> - As a solution we just applied the older colour themes to the new blue >> theme icons. >> - There is no changes in the new concept of icons. >> >> I have attached the *screenshots and patch file as well*. >> >> *Note*: Please note that the *RM #2844* is the bug raised against to it. >> >> >> Regards, >> >> Chethana Kumar >> Principal UI/UX Designer >> EnterpriseDB Corporation >> >> >> The Postgres Database Company >> >> P: +91 86981 57146 <+91%2086981%2057146> >> www.enterprisedb.com >> > > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317
Sporadically crashes on Windows when exit. Fixes #3177 1) Shutdown the python server properly. 2) Disabled "Shutdown server" menu till server is not successfully started. Initial patch sent by Maxim, modified by Akshay Joshi. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=54b1a79cb6f90ac9b26db57e616dc750fb2c6b54 Author: Maxim Zakharov Modified Files -- runtime/Server.cpp | 11 +++ runtime/Server.h | 3 +++ runtime/TrayIcon.cpp | 11 +++ runtime/TrayIcon.h | 4 runtime/pgAdmin4.cpp | 46 runtime/pgAdmin4.h | 1 + web/pgadmin/misc/__init__.py | 16 ++- 7 files changed, 91 insertions(+), 1 deletion(-)
pgAdmin 4 commit: Fixed PEP8 issue
Fixed PEP8 issue Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=faf243db713970ef6267c972d504e8a64b1df340 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/misc/__init__.py | 1 + 1 file changed, 1 insertion(+)
Re: pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317
Thanks patch applied On Thu, Mar 15, 2018 at 4:03 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Akshay, > > Given commit introduce PEP8 issue, PFA minor patch to fix the issue. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Thu, Mar 15, 2018 at 1:27 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Sporadically crashes on Windows when exit. Fixes #3177 >> 1) Shutdown the python server properly. >> 2) Disabled "Shutdown server" menu till server is not successfully >> started. >> >> Initial patch sent by Maxim, modified by Akshay Joshi. >> >> Branch >> -- >> master >> >> Details >> --- >> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif >> f;h=54b1a79cb6f90ac9b26db57e616dc750fb2c6b54 >> Author: Maxim Zakharov >> >> Modified Files >> -- >> runtime/Server.cpp | 11 +++ >> runtime/Server.h | 3 +++ >> runtime/TrayIcon.cpp | 11 +++ >> runtime/TrayIcon.h | 4 >> runtime/pgAdmin4.cpp | 46 ++++++ >> ++ >> runtime/pgAdmin4.h | 1 + >> web/pgadmin/misc/__init__.py | 16 ++- >> 7 files changed, 91 insertions(+), 1 deletion(-) >> >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed
Hi Joao It seems that this fix broke the functionality of RM #2815. It is mentioned in the RM what needs to be fixed now and I am currently working on it. While fixing the issue following problem that I found - In "start_running_query.py" file, we need to remove check "if conn.connected()" from "__execute_query" function as we required exception to be thrown while executing the query to identify the ConnectionLost. - In "execute_query.js" we have used *axios* to execute the query and in case of exception, object is different then normal javascript response object. - We call following functions when exception or error comes and send the "*.response.data*" as parameter - wasConnectionLostToServer(): Check for the readyState parameter, which is not the part of ".response.data". - extractErrorMessage(): Check for the "responseJSON" and " responseJSON.info", which is not the part of ".response.data". - is_pga_login_required(): Check for the "responseJSON" and " responseJSON.info", which is not the part of ".response.data". - is_new_transaction_required(): Check for the "responseJSON" and " responseJSON.info", which is not the part of ".response.data". >From the above list, some of the function calls are generic where they need "responseJSON" and "responseJSON.info", so we can't change that. Possible solution could be pass one extra flag as parameter to identify the object is a axios response or javascript response to above functions and change the logic accordingly. Please let me know your thoughts or any other suggestion. On Fri, Feb 9, 2018 at 8:17 PM, Dave Page wrote: > Thanks, applied. > > On Fri, Feb 9, 2018 at 2:35 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello, >> Attached you can find the fix for the current pronlem >> >> >> On Fri, Feb 9, 2018 at 7:29 AM Dave Page wrote: >> >>> Hi Joao, >>> >>> It looks like Jenkins has taken umbrage to this change, at least with >>> Python 3.x. Can you take a look please? >>> >>> https://jenkins.pgadmin.org/ >>> >>> Thanks. >>> >>> On Fri, Feb 9, 2018 at 11:54 AM, Dave Page wrote: >>> >>>> Thanks, patches applied. >>>> >>>> On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira < >>>> jdealmeidapere...@pivotal.io> wrote: >>>> >>>>> Hi Hackers, >>>>> This is quite a big patch in order to solve the problem with the >>>>> Explain Plan. >>>>> >>>>> We sent 2 patches that have the following: >>>>> *- update-javascript-packages.diff * >>>>> Add package: >>>>> is-docker to select a specific setting when running the Chrome >>>>> tests in >>>>> Docker >>>>> >>>>> Upgrade the version of: >>>>> - babel-loader >>>>> - extract-text-webpack-plugin >>>>> - jasmine-core >>>>> - jasmine-enzyme >>>>> - moment >>>>> *- explain-plan-greenplum.diff* >>>>> Extract SQLEditor.execute and SQLEditor._poll into their own files >>>>> and add test around them >>>>> Extract SQLEditor backend functions that start executing query to >>>>> their own files and add tests around it >>>>> Move the Explain SQL from the front-end and now pass the Explain >>>>> plan parameters as a JSON object in the start query call. >>>>> Extract the compile_template_name into a function that can be used >>>>> by the different places that try to select the version of the template and >>>>> the server type >>>>> >>>>> >>>>> Thanks >>>>> Joao >>>>> >>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed
On Tue, Mar 20, 2018 at 3:06 PM, Dave Page wrote: > I'm a little concerned that noone mentioned this earlier; I'm supposed to > be building the release this afternoon, and I expect this change to at the > very least be complex to fully test and verify. What's the ETA on the > patch? What steps are being taken to ensure it's correct and doesn't cause > regressions? > Harshal has already mentioned in the RM. Currently I am changing the logic, but it may take time to complete, fully test and verify. I'll try my best to do it asap. > > On Tue, Mar 20, 2018 at 7:51 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Joao >> >> It seems that this fix broke the functionality of RM #2815. It is >> mentioned in the RM what needs to be fixed now and I am currently working >> on it. >> While fixing the issue following problem that I found >> >>- In "start_running_query.py" file, we need to remove check "if >> conn.connected()" >>from "__execute_query" function as we required exception to be thrown >> while >>executing the query to identify the ConnectionLost. >>- In "execute_query.js" we have used *axios* to execute the query and >>in case of exception, object is different then normal javascript response >>object. >>- We call following functions when exception or error comes and send >>the "*.response.data*" as parameter >> - wasConnectionLostToServer(): Check for the readyState parameter, >> which is not the part of ".response.data". >> - extractErrorMessage(): Check for the "responseJSON" and " >> responseJSON.info", which is not the part of >> ".response.data". >> - is_pga_login_required(): Check for the "responseJSON" and " >> responseJSON.info", which is not the part of >> ".response.data". >> - is_new_transaction_required(): Check for the "responseJSON" and " >> responseJSON.info", which is not the part of >> ".response.data". >> >> From the above list, some of the function calls are generic where they >> need "responseJSON" and "responseJSON.info", so we can't change that. >> Possible solution could be pass one extra flag as parameter to identify the >> object is a axios response or javascript response to above functions and >> change the logic accordingly. >> >> Please let me know your thoughts or any other suggestion. >> >> >> On Fri, Feb 9, 2018 at 8:17 PM, Dave Page wrote: >> >>> Thanks, applied. >>> >>> On Fri, Feb 9, 2018 at 2:35 PM, Joao De Almeida Pereira < >>> jdealmeidapere...@pivotal.io> wrote: >>> >>>> Hello, >>>> Attached you can find the fix for the current pronlem >>>> >>>> >>>> On Fri, Feb 9, 2018 at 7:29 AM Dave Page wrote: >>>> >>>>> Hi Joao, >>>>> >>>>> It looks like Jenkins has taken umbrage to this change, at least with >>>>> Python 3.x. Can you take a look please? >>>>> >>>>> https://jenkins.pgadmin.org/ >>>>> >>>>> Thanks. >>>>> >>>>> On Fri, Feb 9, 2018 at 11:54 AM, Dave Page wrote: >>>>> >>>>>> Thanks, patches applied. >>>>>> >>>>>> On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira < >>>>>> jdealmeidapere...@pivotal.io> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> This is quite a big patch in order to solve the problem with the >>>>>>> Explain Plan. >>>>>>> >>>>>>> We sent 2 patches that have the following: >>>>>>> *- update-javascript-packages.diff * >>>>>>> Add package: >>>>>>> is-docker to select a specific setting when running the Chrome >>>>>>> tests in >>>>>>> Docker >>>>>>> >>>>>>> Upgrade the version of: >>>>>>> - babel-loader >>>>>>> - extract-text-webpack-plugin >>>>>>> - jasmine-core >>>>>>> - jasmine-enzyme >>>>>>> - moment >>>>>>> *- explain-plan-greenplum.diff* >>>>>&g
Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed
Hi Hackers Attached is the patch file to fix the RM #2815. On Tue, Mar 20, 2018 at 3:24 PM, Dave Page wrote: > > > On Tue, Mar 20, 2018 at 9:48 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Tue, Mar 20, 2018 at 3:06 PM, Dave Page >> wrote: >> >>> I'm a little concerned that noone mentioned this earlier; I'm supposed >>> to be building the release this afternoon, and I expect this change to at >>> the very least be complex to fully test and verify. What's the ETA on the >>> patch? What steps are being taken to ensure it's correct and doesn't cause >>> regressions? >>> >> >> Harshal has already mentioned in the RM. Currently I am changing the >> logic, but it may take time to complete, fully test and verify. I'll try my >> best to do it asap. >> > > Sure, but how many of us are watching every comment on every RM? I know > I'm not (I currently average ~400 emails/day). > > >> >>> On Tue, Mar 20, 2018 at 7:51 AM, Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> >>>> Hi Joao >>>> >>>> It seems that this fix broke the functionality of RM #2815. It is >>>> mentioned in the RM what needs to be fixed now and I am currently working >>>> on it. >>>> While fixing the issue following problem that I found >>>> >>>>- In "start_running_query.py" file, we need to remove check "if >>>> conn.connected()" >>>>from "__execute_query" function as we required exception to be thrown >>>> while >>>>executing the query to identify the ConnectionLost. >>>>- In "execute_query.js" we have used *axios* to execute the query >>>>and in case of exception, object is different then normal javascript >>>>response object. >>>>- We call following functions when exception or error comes and >>>>send the "*.response.data*" as parameter >>>> - wasConnectionLostToServer(): Check for the readyState >>>> parameter, which is not the part of ".response.data". >>>> - extractErrorMessage(): Check for the "responseJSON" and " >>>> responseJSON.info", which is not the part of >>>> ".response.data". >>>> - is_pga_login_required(): Check for the "responseJSON" and " >>>> responseJSON.info", which is not the part of >>>> ".response.data". >>>> - is_new_transaction_required(): Check for the "responseJSON" >>>> and "responseJSON.info", which is not the part of >>>> ".response.data". >>>> >>>> From the above list, some of the function calls are generic where they >>>> need "responseJSON" and "responseJSON.info", so we can't change that. >>>> Possible solution could be pass one extra flag as parameter to identify the >>>> object is a axios response or javascript response to above functions >>>> and change the logic accordingly. >>>> >>>> Please let me know your thoughts or any other suggestion. >>>> >>>> >>>> On Fri, Feb 9, 2018 at 8:17 PM, Dave Page wrote: >>>> >>>>> Thanks, applied. >>>>> >>>>> On Fri, Feb 9, 2018 at 2:35 PM, Joao De Almeida Pereira < >>>>> jdealmeidapere...@pivotal.io> wrote: >>>>> >>>>>> Hello, >>>>>> Attached you can find the fix for the current pronlem >>>>>> >>>>>> >>>>>> On Fri, Feb 9, 2018 at 7:29 AM Dave Page wrote: >>>>>> >>>>>>> Hi Joao, >>>>>>> >>>>>>> It looks like Jenkins has taken umbrage to this change, at least >>>>>>> with Python 3.x. Can you take a look please? >>>>>>> >>>>>>> https://jenkins.pgadmin.org/ >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> On Fri, Feb 9, 2018 at 11:54 AM, Dave Page >>>>>>> wrote: >>>>>>> >>>>>>>> Thanks, patches applied. >>>>>>>> >>>>>>>> On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Per
Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed
uery_spec.js:12809:56 >> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 395 of 486 (18 FAILED) >> (0 secs / 0 secs) >> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >> SQL statement is not empty when error is returned by the server when a new >> transaction is not required should add new entry to history and update the >> Messages tab FAILED >> Expected spy SqlEditor.update_msg_history to have been called with [ >> false, 'some error message' ] but it was never called. >> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >> SQL statement is not empty when error is returned by the server when a new >> transaction is required should add new entry to history and update the >> Messages tab FAILED >> Expected spy SqlEditor.update_msg_history to have been called with [ >> false, 'some error message' ] but it was never called. >> at regression/javascript/sqleditor/execute_query_spec.js:12874:56 >> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 403 of 486 (19 FAILED) >> (0 secs / 0 secs) >> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >> SQL statement is not empty when error is returned by the server when a new >> transaction is required should add new entry to history and update the >> Messages tab FAILED >> Expected spy SqlEditor.update_msg_history to have been called with [ >> false, 'some error message' ] but it was never called. >> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >> SQL statement is not empty when error is returned by the server when a new >> transaction is required should save the state FAILED >> Expected spy SqlEditor.save_state to have been called with [ 'execute', [ >> '' ] ] but it was never called. >> at regression/javascript/sqleditor/execute_query_spec.js:12897:48 >> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 406 of 486 (20 FAILED) >> (0 secs / 0 secs) >> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >> SQL statement is not empty when error is returned by the server when a new >> transaction is required should save the state FAILED >> Expected spy SqlEditor.save_state to have been called with [ 'execute', [ >> '' ] ] but it was never called. >> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >> SQL statement is not empty when error is returned by the server when a new >> transaction is required should initialize a new transaction FAILED >> Expected spy SqlEditor.init_transaction to have been called. >> at regression/javascript/sqleditor/execute_query_spec.js:12909:54 >> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 408 of 486 (21 FAILED) >> (0 secs / 0 secs) >> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >> SQL statement is not empty when error is returned by the server when a new >> transaction is required should initialize a new transaction FAILED >> Expected spy SqlEditor.init_transaction to have been called. >> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 486 of 486 (21 FAILED) >> (7.05 secs / 0 secs) >> error Command failed with exit code 1. >> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about >> this command. >> make: *** [check-js] Error 1 >> >> >> On Tue, Mar 20, 2018 at 1:12 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers >>> >>> Attached is the patch file to fix the RM #2815. >>> >>> On Tue, Mar 20, 2018 at 3:24 PM, Dave Page >>> wrote: >>> >>>> >>>> >>>> On Tue, Mar 20, 2018 at 9:48 AM, Akshay Joshi < >>>> akshay.jo...@enterprisedb.com> wrote: >>>> >>>>> >>>>> >>>>> On Tue, Mar 20, 2018 at 3:06 PM, Dave Page >>>> > wrote: >>>>> >>>>>> I'm a little concerned that noone mentioned this earlier; I'm >>>>>> supposed to be building the release this afternoon, and I expect this >>>>>> change to at the very least be complex to fully test and verify. What's >>>>>> the >>>>>> ETA on the patch? What steps are being taken to ensure it's correct and >>>>>> doesn't cause regressions? >>>>>> >>>>> >>>>> Harshal has already mentioned in the RM. Currently I am changing >>>>> the logic, but it may take time to complete, fu
Re: v3.0 release on hold
On 21 Mar 2018 21:05, "Dave Page" wrote: We've run into a number of unexpected issues with the v3.0 release that I think we need to resolve before moving forwards. For the time being, only patches critical to fix these issues should be committed. I'll try to look at 1, though I do have another deadline I need to meet. Akshay, can you look at 2 please? Sure. I'll Fahar is already looking at 3. Khushboo, can you look at 4 please? Thanks all. 1) There is no longer a system tray in Gnome 3.26 and later, and thus the runtime won't initialise in Fedora 27 and later. We need an alternative for this, either a tray replacement that the RPM can depend on, or better yet, support whatever it is Gnome expect such apps to use these days. 2) Starting a second instance of the app bundle on Mac doesn't always open a new pgAdmin window as it should. It works fine in the debugger, or if you start the app with a command like: "/Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you double-click the appbundle or use a command like "open /Applications/pgAdmin\ 4.app" 3) Fahar saw a crash on Windows 7. I couldn't reproduce this on my copy, but apparently his is a fresh installation. 4) On my Windows 7 machine, after running a backup I get no status window, and see the following in the logs: Traceback (most recent call last): File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line 209, in run_wsgi execute(self.server.app) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line 197, in execute application_iter = app(environ, start_response) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1997, in __call__ return self.wsgi_app(environ, start_response) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1985, in wsgi_app response = self.handle_exception(e) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1540, in handle_exception reraise(exc_type, exc_value, tb) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1982, in wsgi_app response = self.full_dispatch_request() File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1614, in full_dispatch_request rv = self.handle_user_exception(e) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1517, in handle_user_exception reraise(exc_type, exc_value, tb) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1612, in full_dispatch_request rv = self.dispatch_request() File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1598, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args) File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask_login.py", line 792, in decorated_view return func(*args, **kwargs) File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\__init__.py", line 62, in index return make_response(response=BatchProcess.list()) File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\processes.py", line 584, in list details = desc.details(p.command, args) File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\tools\backup\__init__.py", line 190, in details res += html.safe_str(cmd + self.cmd) AttributeError: 'BackupMessage' object has no attribute 'cmd' -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: v3.0 release on hold
Hi Dave On Wed, Mar 21, 2018 at 9:05 PM, Dave Page wrote: > We've run into a number of unexpected issues with the v3.0 release that I > think we need to resolve before moving forwards. For the time being, only > patches critical to fix these issues should be committed. > > I'll try to look at 1, though I do have another deadline I need to meet. > Akshay, can you look at 2 please? > Fahar is already looking at 3. > Khushboo, can you look at 4 please? > > Thanks all. > > 1) There is no longer a system tray in Gnome 3.26 and later, and thus the > runtime won't initialise in Fedora 27 and later. We need an alternative for > this, either a tray replacement that the RPM can depend on, or better yet, > support whatever it is Gnome expect such apps to use these days. > > 2) Starting a second instance of the app bundle on Mac doesn't always open > a new pgAdmin window as it should. It works fine in the debugger, or if you > start the app with a command like: "/Applications/pgAdmin\ > 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you double-click the > appbundle or use a command like "open /Applications/pgAdmin\ 4.app" > Still working on this, not found any solution yet. > > 3) Fahar saw a crash on Windows 7. I couldn't reproduce this on my copy, > but apparently his is a fresh installation. > I have tried on Windows 7 and Windows 8.1 64 bit clean VM (created using ISO file) and pgAdmin4 is working fine on both. I have given the same ISO file to Khushboo and she has created VM for both the OS and it is crashed on her machine (seems strange behaviour), only difference is version of VMWare fusion. I have 6.0.6 and she has 7.0.1 > > 4) On my Windows 7 machine, after running a backup I get no status window, > and see the following in the logs: > > Traceback (most recent call last): > File "C:\Program Files (x86)\pgAdmin > 4\v3\venv\Lib\site-packages\werkzeug\serving.py", > line 209, in run_wsgi > execute(self.server.app) > File "C:\Program Files (x86)\pgAdmin > 4\v3\venv\Lib\site-packages\werkzeug\serving.py", > line 197, in execute > application_iter = app(environ, start_response) > File "C:\Program Files (x86)\pgAdmin > 4\v3\venv\Lib\site-packages\flask\app.py", > line 1997, in __call__ > return self.wsgi_app(environ, start_response) > File "C:\Program Files (x86)\pgAdmin > 4\v3\venv\Lib\site-packages\flask\app.py", > line 1985, in wsgi_app > response = self.handle_exception(e) > File "C:\Program Files (x86)\pgAdmin > 4\v3\venv\Lib\site-packages\flask\app.py", > line 1540, in handle_exception > reraise(exc_type, exc_value, tb) > File "C:\Program Files (x86)\pgAdmin > 4\v3\venv\Lib\site-packages\flask\app.py", > line 1982, in wsgi_app > response = self.full_dispatch_request() > File "C:\Program Files (x86)\pgAdmin > 4\v3\venv\Lib\site-packages\flask\app.py", > line 1614, in full_dispatch_request > rv = self.handle_user_exception(e) > File "C:\Program Files (x86)\pgAdmin > 4\v3\venv\Lib\site-packages\flask\app.py", > line 1517, in handle_user_exception > reraise(exc_type, exc_value, tb) > File "C:\Program Files (x86)\pgAdmin > 4\v3\venv\Lib\site-packages\flask\app.py", > line 1612, in full_dispatch_request > rv = self.dispatch_request() > File "C:\Program Files (x86)\pgAdmin > 4\v3\venv\Lib\site-packages\flask\app.py", > line 1598, in dispatch_request > return self.view_functions[rule.endpoint](**req.view_args) > File "C:\Program Files (x86)\pgAdmin > 4\v3\venv\Lib\site-packages\flask_login.py", > line 792, in decorated_view > return func(*args, **kwargs) > File "C:\Program Files (x86)\pgAdmin > 4\v3\web\pgadmin\misc\bgprocess\__init__.py", > line 62, in index > return make_response(response=BatchProcess.list()) > File "C:\Program Files (x86)\pgAdmin > 4\v3\web\pgadmin\misc\bgprocess\processes.py", > line 584, in list > details = desc.details(p.command, args) > File "C:\Program Files (x86)\pgAdmin > 4\v3\web\pgadmin\tools\backup\__init__.py", > line 190, in details > res += html.safe_str(cmd + self.cmd) > AttributeError: 'BackupMessage' object has no attribute 'cmd' > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: Showstopper desktop runtime issue
On Thu, Mar 22, 2018 at 3:19 PM, Dave Page wrote: > All, > > As you know, the 3.0 release is currently on hold as we discovered late > yesterday that the re-vamped desktop runtime will not run on Gnome 3.26 and > later. This is because the GTK project, and later Gnome, have removed > support for the System Tray on which the new runtime relies. > > They have replaced it with a notification mechanism, however this doesn't > really meet our needs as what we want is a place (the tray icon) to attach > a menu to control the pgAdmin server; we don't really use notifications as > such. > > I see a number of possible ways around this: > > 1) Return to the previous runtime. I think this is at best a short-term > solution, as the re-visited Annulen version of the QtWebKit seems to be > getting little attention at the moment, and this would re-introduce many > known bugs caused by WebKit. > > 2) Re-work the current runtime code to remove the tray icon, and utilise > desktop/start menu items to signal the running instance to show the logs, > configure the server, exit etc. This should work, but will be kinda klunky. > > 3) Put effort into polishing Joao's Electron based runtime. This might be > a good long term solution as it would remove the need to have any C++ code > of our own, and might allow us to use Electron's update mechanism to do > software updates. The downsides are that we would lose support for dockable > tabs (new windows only), and it wouldn't work on CentOS/RHEL 6 which we > currently support. > > Thoughts and comments please folks? How do we want to proceed? I'm > currently leaning towards 2 for v3, and possibly moving to 3 in the long > term. > Option 2 seems good to me. > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: v3.0 release on hold
On Thu, Mar 22, 2018 at 3:22 PM, Dave Page wrote: > Hi > > On Thu, Mar 22, 2018 at 9:21 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Wed, Mar 21, 2018 at 9:05 PM, Dave Page wrote: >> >>> We've run into a number of unexpected issues with the v3.0 release that >>> I think we need to resolve before moving forwards. For the time being, only >>> patches critical to fix these issues should be committed. >>> >>> I'll try to look at 1, though I do have another deadline I need to meet. >>> Akshay, can you look at 2 please? >>> Fahar is already looking at 3. >>> Khushboo, can you look at 4 please? >>> >>> Thanks all. >>> >>> 1) There is no longer a system tray in Gnome 3.26 and later, and thus >>> the runtime won't initialise in Fedora 27 and later. We need an alternative >>> for this, either a tray replacement that the RPM can depend on, or better >>> yet, support whatever it is Gnome expect such apps to use these days. >>> >>> 2) Starting a second instance of the app bundle on Mac doesn't always >>> open a new pgAdmin window as it should. It works fine in the debugger, or >>> if you start the app with a command like: "/Applications/pgAdmin\ >>> 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you double-click the >>> appbundle or use a command like "open /Applications/pgAdmin\ 4.app" >>> >> >> Still working on this, not found any solution yet. >> > Not able to figure out the solution yet. I have tried to debug the code, but every time it will create a new instance(tray icon). Do I need to look into the code or something related to app bundle may be some settings in info.plist or any other pointer? > >>> 3) Fahar saw a crash on Windows 7. I couldn't reproduce this on my copy, >>> but apparently his is a fresh installation. >>> >> >> I have tried on Windows 7 and Windows 8.1 64 bit clean VM (created >> using ISO file) and pgAdmin4 is working fine on both. I have given the same >> ISO file to Khushboo and she has created VM for both the OS and it is >> crashed on her machine (seems strange behaviour), only difference is >> version of VMWare fusion. I have 6.0.6 and she has 7.0.1 >> > > Is it possible that on one virtual machine VMware Tools were installed, > but not on the other? I ask because I believe they install a version of the > MSVC runtime. > On both machine VMware tools were installed. > > >> >>> 4) On my Windows 7 machine, after running a backup I get no status >>> window, and see the following in the logs: >>> >>> Traceback (most recent call last): >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\werkzeug\serving.py", >>> line 209, in run_wsgi >>> execute(self.server.app) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\werkzeug\serving.py", >>> line 197, in execute >>> application_iter = app(environ, start_response) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\flask\app.py", >>> line 1997, in __call__ >>> return self.wsgi_app(environ, start_response) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\flask\app.py", >>> line 1985, in wsgi_app >>> response = self.handle_exception(e) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\flask\app.py", >>> line 1540, in handle_exception >>> reraise(exc_type, exc_value, tb) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\flask\app.py", >>> line 1982, in wsgi_app >>> response = self.full_dispatch_request() >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\flask\app.py", >>> line 1614, in full_dispatch_request >>> rv = self.handle_user_exception(e) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\flask\app.py", >>> line 1517, in handle_user_exception >>> reraise(exc_type, exc_value, tb) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\flask\app.py", >>> line 1612, in full_dispatch_request >>> rv = self.dispatch_request() >>> File "C:\Program Files (x86)\pgAdmin
Re: v3.0 release on hold
On Thu, Mar 22, 2018 at 10:24 PM, Dave Page wrote: > Hi > > On Thu, Mar 22, 2018 at 1:13 PM, Dave Page wrote: > >> >>>>>> 2) Starting a second instance of the app bundle on Mac doesn't always >>>>>> open a new pgAdmin window as it should. It works fine in the debugger, or >>>>>> if you start the app with a command like: "/Applications/pgAdmin\ >>>>>> 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you double-click >>>>>> the appbundle or use a command like "open /Applications/pgAdmin\ 4.app" >>>>>> >>>>> >>>>> Still working on this, not found any solution yet. >>>>> >>>> >>> Not able to figure out the solution yet. I have tried to debug >>> the code, but every time it will create a new instance(tray icon). Do I >>> need to look into the code or something related to app bundle may be some >>> settings in info.plist or any other pointer? >>> >> >> Have a look at the code around line 85 an onwards of pgAdmin4.cpp. It >> creates the shared memory interlock (and log/address files) based on the >> current username and a hash of the executable name/path. My suspicion is >> that the path hash (which is calculated from argv[0] on line 72) is for >> some reason getting a different value each time when launched via the >> Finder or "open", thus the interlock is failing. >> > > So I took a look at this, and it seems the code is just fine. What is > happening is that macOS only allows a single instance of an app to run at > once. Whilst that is what we want of course, macOS is causing the new > instance to exit before it has a change to open a new pgAdmin window. Using > "open -n ..." or calling the embedded executable directly resolves that > issue. > > So, there's another challenge to figure out... :-( > OK. Will try to figure that out. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: v3.0 release on hold
Hi Dave On Fri, Mar 23, 2018 at 11:06 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > > > On Thu, Mar 22, 2018 at 10:24 PM, Dave Page wrote: > >> Hi >> >> On Thu, Mar 22, 2018 at 1:13 PM, Dave Page wrote: >> >>> >>>>>>> 2) Starting a second instance of the app bundle on Mac doesn't >>>>>>> always open a new pgAdmin window as it should. It works fine in the >>>>>>> debugger, or if you start the app with a command like: >>>>>>> "/Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". It doesn't >>>>>>> work if you double-click the appbundle or use a command like "open >>>>>>> /Applications/pgAdmin\ 4.app" >>>>>>> >>>>>> >>>>>> Still working on this, not found any solution yet. >>>>>> >>>>> >>>> Not able to figure out the solution yet. I have tried to debug >>>> the code, but every time it will create a new instance(tray icon). Do I >>>> need to look into the code or something related to app bundle may be some >>>> settings in info.plist or any other pointer? >>>> >>> >>> Have a look at the code around line 85 an onwards of pgAdmin4.cpp. It >>> creates the shared memory interlock (and log/address files) based on the >>> current username and a hash of the executable name/path. My suspicion is >>> that the path hash (which is calculated from argv[0] on line 72) is for >>> some reason getting a different value each time when launched via the >>> Finder or "open", thus the interlock is failing. >>> >> >> So I took a look at this, and it seems the code is just fine. What is >> happening is that macOS only allows a single instance of an app to run at >> once. Whilst that is what we want of course, macOS is causing the new >> instance to exit before it has a change to open a new pgAdmin window. Using >> "open -n ..." or calling the embedded executable directly resolves that >> issue. >> >> So, there's another challenge to figure out... :-( >> > > OK. Will try to figure that out. > After googled I have tried following solution: 1. Create a shell script "launch.sh" and kept it in "/Applications/pgAdmin\ 4.app/Contents/MacOS" folder. That shell script will contain the command "open -n /Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". Change the "CFBundleExecutable" parameter of Info.plist from "pgAdmin4" to "launch.sh". It didn't work, shall script didn't launch. 2. Create one apple script with command like "do shell execute "/Applications/pgAdmin\ 4.app", compile it and save it as Application. It create the app bundle, copy contents of pgAdmin4 app to this newly created application. But the problem is it opens and having icon in the dock and no response on double click (second time). Will continue to figure out some other solutions tomorrow. > >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
[pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL
Hi Hackers, Please find the attached patch to fix RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3090.patch Description: Binary data
Re: [pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL
Hi Joao
On Tue, Mar 27, 2018 at 12:01 AM, Joao De Almeida Pereira wrote:
> Hello,
> We tried to reproduce the issue but we were not capable to reproduce it.
> What it is strange on the fix is that python is complaining about a
> different line then the one that was fixed. Maybe this is just a Python
> thing
>
I have mentioned the steps in RM and I have tried it on Ubuntu 16.
Python is complaining the exact line where I have fixed the logic.
ex_diag_message = u"{0}: {1}".format(
self.decode_to_utf8(exception_obj.diag.severity), #
exception_obj.diag.severity is not decoded before my fix.
self.decode_to_utf8(exception_obj.diag.message_primary)
)
>
> I assume that the fix works, but I would love to see some tests to ensure
> it is working. Another issue that looks more problematic is the fact that,
> as per the Redmine issue, when an exception is thrown it sends back a
> Successful Query message. If this is the case then this fix doesn't look
> like it is enough to solve the problem.
>
Yes it works. With the latest code I didn't see Successful Query
message, it is showing "Not connected to the server .", but the stack
trace is same that was mentioned in the RM.
>
> Thanks
> Victoria & Joao
>
> On Mon, Mar 26, 2018 at 9:00 AM Dave Page wrote:
>
>> Thanks, applied.
>>
>> On Mon, Mar 26, 2018 at 11:43 AM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch to fix RM #3090 pgadmin shows misleading
>>> "Query returned successfully" with incorrect SQL.
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>> 976-788-8246 <+91%2097678%2088246>*
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: [pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL
Hi Joao
On Tue, Mar 27, 2018 at 6:53 PM, Joao De Almeida Pereira wrote:
> Hi Akshay,
>
> We were not trying to imply that your fix did not solve the problem, we
> were trying to understand the root cause of the problem.
>
As per my understanding root cause of the problem is "exception_obj.
diag.severity" variable was not decoded and used directly, when I debug the
code that variable contains the encoded string, so I have just use the
function "*self.decode_to_utf8()*" and it works. If you can see the code
below to this fix will have all the variables decoded to utf8.
>
> 1. We were not able to reproduce the problem
> We followed your directions in RM, removed your fix but we could not
> reproduce the problem. So we could not make sure that the application is in
> fact working. This maybe have been because we missed something.
> 2. The fix does not tackle the big problem
> From what we read on the RM the big problem is "when we throw an exception
> the front end is displaying the query successful message". Did you also
> understood that from the RM?
>
We believe this is the real problem behind the RM.
> Were you able replicate this behavior? If so we need to address the root
> of this.
>
Yes I understood that from RM, but as I mentioned in my previous email
that I haven't encounter that problem while trying to reproduce this. I got
"*Not connected to the server*..." error not the "Query returned
successfully". This bug has been log 2 months ago, I am not sure but it may
possible that we have fixed/change some logic because of that I have seen
"Not connected to the server.." error instead of "Query returned
successfully".
>
>
> As an aside sniping bugs is fine in some situations but as a general rule
> of thumb is a bad approach and creates a blob of code that no one can
> manage. A situation like this look like a very promising candidate for
> extraction/refactoring in our point of view. In which situation do you
> normally refactor or extract code?
>
> Thanks
> Joao
>
>
> On Tue, Mar 27, 2018, 1:31 AM Akshay Joshi
> wrote:
>
>> Hi Joao
>>
>> On Tue, Mar 27, 2018 at 12:01 AM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hello,
>>> We tried to reproduce the issue but we were not capable to reproduce it.
>>> What it is strange on the fix is that python is complaining about a
>>> different line then the one that was fixed. Maybe this is just a Python
>>> thing
>>>
>>
>> I have mentioned the steps in RM and I have tried it on Ubuntu 16.
>> Python is complaining the exact line where I have fixed the logic.
>>
>>ex_diag_message = u"{0}: {1}".format(
>> self.decode_to_utf8(exception_obj.diag.severity), #
>> exception_obj.diag.severity is not decoded before my fix.
>> self.decode_to_utf8(exception_obj.diag.message_primary)
>>)
>>
>>
>>
>>>
>>> I assume that the fix works, but I would love to see some tests to
>>> ensure it is working. Another issue that looks more problematic is the fact
>>> that, as per the Redmine issue, when an exception is thrown it sends back a
>>> Successful Query message. If this is the case then this fix doesn't look
>>> like it is enough to solve the problem.
>>>
>>
>> Yes it works. With the latest code I didn't see Successful Query
>> message, it is showing "Not connected to the server .", but the stack
>> trace is same that was mentioned in the RM.
>>
>>>
>>> Thanks
>>> Victoria & Joao
>>>
>>> On Mon, Mar 26, 2018 at 9:00 AM Dave Page wrote:
>>>
>>>> Thanks, applied.
>>>>
>>>> On Mon, Mar 26, 2018 at 11:43 AM, Akshay Joshi <
>>>> akshay.jo...@enterprisedb.com> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Please find the attached patch to fix RM #3090 pgadmin shows
>>>>> misleading "Query returned successfully" with incorrect SQL.
>>>>>
>>>>> --
>>>>> *Akshay Joshi*
>>>>>
>>>>> *Sr. Software Architect *
>>>>>
>>>>>
>>>>>
>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>>>> 976-788-8246 <+91%2097678%2088246>*
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
>> <+91%2097678%2088246>*
>>
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: Bug #3083 fix
Hi On Fri, Mar 2, 2018 at 3:40 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Neethu, > We passed the patch through our CI pipeline and all tests pass. > The code looks good, but we are trying to decouple files as much as we > can so that we do not end up with files with over 1000 lines, that are hard > to read and to maintain. Also we are trying to create Unit Tests to have > more coverage in our Javascript code. > > Can you split the new implementation code into it's own file and create > some tests to ensure the behavior will not be broken in the future?iYou > have some examples on: pgadmin/browser/server_groups/servers/databases/ > external_tables/* > I have spilt the new implementation into different file. Its' been hard to write jasmine/feature test case as it requires drag event and exact co-ordinate to resize the slickgrid cell. Attached is the modified patch. > > Thanks > Joao > > On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy < > neethumariya...@gmail.com> wrote: > >> Hi, >> I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science >> at BITS Pilani. >> >> I've attempted to fix https://redmine.postgresql.org/issues/3083. Since >> the textarea resize feature is the default HTML feature, I have not changed >> it. Instead, I've added draggable borders to the wrapper which expands the >> textarea inside it. >> >> I'm attaching my patch as bug3083.diff below as per the contribution >> guidelines. >> >> Hope this helps. Thank you for your consideration! >> >> Sincerely, >> Neethu Mariya Joy >> GitHub <https://github.com/Roboneet> | Linkedin >> <https://www.linkedin.com/in/neethu-mariya-joy-653655128/> >> >> >> -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3083_v2.patch Description: Binary data
Re: Bug #3083 fix
Thanks Joao. On Wed, Mar 28, 2018 at 11:36 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hey Akshay and Neethu > > We refactored the patch to add tests for the resize feature. We were able > to write test cases for the drag event by using spies and setting the rect > dimensions. In cases like this, we can just test some components in order > to have enough confidence in the code. So we isolated the function that > implements the behavior of this feature and tested that it was performing > as expected. > > We ran the patch through the pipelines and all of the tests passed. > > Sincerely, > > Joao and Victoria > > On Wed, Mar 28, 2018 at 8:03 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi >> >> On Fri, Mar 2, 2018 at 3:40 AM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hello Neethu, >>> We passed the patch through our CI pipeline and all tests pass. >>> The code looks good, but we are trying to decouple files as much as we >>> can so that we do not end up with files with over 1000 lines, that are hard >>> to read and to maintain. Also we are trying to create Unit Tests to have >>> more coverage in our Javascript code. >>> >>> Can you split the new implementation code into it's own file and create >>> some tests to ensure the behavior will not be broken in the future?iYou >>> have some examples on: pgadmin/browser/server_groups/servers/databases/ >>> external_tables/* >>> >> >> I have spilt the new implementation into different file. Its' been >> hard to write jasmine/feature test case as it requires drag event and exact >> co-ordinate to resize the slickgrid cell. >> Attached is the modified patch. >> >> >>> >>> Thanks >>> Joao >>> >>> On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy < >>> neethumariya...@gmail.com> wrote: >>> >>>> Hi, >>>> I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer >>>> Science at BITS Pilani. >>>> >>>> I've attempted to fix https://redmine.postgresql.org/issues/3083. >>>> Since the textarea resize feature is the default HTML feature, I have not >>>> changed it. Instead, I've added draggable borders to the wrapper which >>>> expands the textarea inside it. >>>> >>>> I'm attaching my patch as bug3083.diff below as per the contribution >>>> guidelines. >>>> >>>> Hope this helps. Thank you for your consideration! >>>> >>>> Sincerely, >>>> Neethu Mariya Joy >>>> GitHub <https://github.com/Roboneet> | Linkedin >>>> <https://www.linkedin.com/in/neethu-mariya-joy-653655128/> >>>> >>>> >>>> >> >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 >> <+91%2097678%2088246>* >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
[pgAdmin4][Patch]: RM #3180 Index node is missing from the tree view of the table node
Hi Hackers, Please find the attached patch to fix RM #3180 Index node is missing from the tree view of the table node. This is a regression of one of the older commit. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3180.patch Description: Binary data
Regarding RM #2214 SCRAM Authentication for Change Password
Hi Hackers,
As a part of RM #2214, we will have to support SCRAM authentication. User
will be able to login, but the problem is with "Change Password" of
database server won't work, as we are encrypting new password using md5 and
set the new password using "*ALTER USER WITH ENCRYPTED PASSWORD
*" query.
If password_encryption = scram-sha-256 in postgresql.conf file then it will
change the password with md5 encryption which is not correct and user won't
be able to login using changed password. I have tried previously (almost
12 months ago) and tried following again
from passlib.hash import scram
scram.default_rounds = 4096
digest_info = scram.extract_digest_info(scram.encrypt(password), 'sha-256')
salt = digest_info[0]
rounds = digest_info[1]
secret = digest_info[2]
salted_password = hashlib.pbkdf2_hmac('sha256', secret, salt, rounds)
but not able to encrypt the password for SCRAM.
There is new method introduce in PostgreSQL 10 to encrypt the password:
char *PQencryptPasswordConn(PGconn *conn, const char *passwd, const
char *user, const char *algorithm);
As we are using psycopg2, so the support for the above method should be
available in psycopg2. *Ashesh* *Vashi* has already send the patch to
support for preparing encrypted password and they are planning to merge his
patch in version 2.8. Following is the link of his patch
https://github.com/psycopg/psycopg2/pull/576
So when the above patch will be merged and released by psycopg2, we will
work on this feature again and modified the code. I'll update the RM
accordingly.
Suggestion/ Comments?
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: pgAdmin 4 commit: Fix a number of broken connection detection scenarios
Hi Neel This issue is not due to the above fix, if you can see the error it is showing in dashboard.js line no 454 "err = JSON.parse(xhr.responseText);" that code is from long time. I have just added an extra check of the readyState in case of server is down in the above commit. Though it is a bug can you please create a new RM for this. On Thu, Apr 5, 2018 at 10:52 AM, Neel Patel wrote: > Hi Akshay, > > Due to above commit, when user "Drop" any database it gives exception in > browser console. > Check attached screenshot. > > Thanks, > Neel Patel > > > > On Wed, Mar 21, 2018 at 2:08 PM, Dave Page wrote: > >> Fix a number of broken connection detection scenarios. >> >> Branch >> -- >> master >> >> Details >> --- >> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif >> f;h=637f3b9d1a54df8b9a1bfad9e26f27fdea407683 >> Author: Akshay Joshi >> >> Modified Files >> -- >> web/pgadmin/dashboard/static/js/dashboard.js | 58 >> >> web/pgadmin/static/js/sqleditor/execute_query.js | 62 >> +++-- >> .../js/sqleditor/is_new_transaction_required.js| 9 >> web/pgadmin/tools/sqleditor/__init__.py| 4 +- >> web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 20 --- >> .../tools/sqleditor/tests/test_start_query_tool.py | 2 +- >> .../tools/sqleditor/utils/start_running_query.py | 63 >> ++ >> .../utils/tests/test_start_running_query.py| 15 +- >> .../user_management/static/js/user_management.js | 13 - >> .../utils/driver/psycopg2/server_manager.py| 1 + >> .../javascript/sqleditor/execute_query_spec.js | 48 - >> .../sqleditor/is_new_transaction_required_spec.js | 14 ++--- >> 12 files changed, 195 insertions(+), 114 deletions(-) >> >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
[pgAdmin4][patch]: RM #3227 pgadmin4 crashed on Windows If admin user name contains spaces
Hi Hackers, Please find the attached patch to fix RM #3227 pgadmin4 crashed on Windows If admin user name contains spaces. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3227.patch Description: Binary data
[pgAdmin4][Patch] Feature #1447 SSH Tunnel
Hi Hackers I have implemented the SSH Tunnel support using https://pypi.org/project/sshtunnel/ python package. Added "SSH Tunnel" Tab in server dialog. This implementation supports user name /password and private/public key combination with Passphrase to crate SSH Tunnel. I have added regression test case to add server using SSH Tunnel options. The given python package(https://pypi.org/project/sshtunnel/) support Python version *2.7, 3.4+*. It uses Paramiko (Python implementation of SSHv2 protocol) which actually drops support for Python 2.6. So I have added *SUPPORT_SSH_TUNNEL* parameter in config.py which checks the python version and set the flag accordingly. In case of Python 2.6, 3.0, 3.1, 3.2 and 3.3 control on the "SSH Tunnel" tab of server dialog will be disabled. Please review it, and if looks good please commit the code. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* SSH_Tunnel_v1.patch Description: Binary data
Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel
On Mon, Apr 23, 2018 at 1:30 PM, Dave Page wrote: > Hi > > On Thu, Apr 19, 2018 at 6:56 PM, Anthony Emengo > wrote: > >> Hey Akshay >> >> This patch passed our test pipelines. >> > > Did you test the feature and//or review the code and tests? Passing the > tests is great, *if* the whole feature is covered (and the nature of this > patch will make that quite difficult, maybe impossible to do without > external infrastructure and config). > Agreed, it's been difficult to write test case to test the complete feature. > > >> >> Anthony and Victoria >> >> On Thu, Apr 19, 2018 at 1:48 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers >>> >>> I have implemented the SSH Tunnel support using https://pypi.org/project >>> /sshtunnel/ python package. Added "SSH Tunnel" Tab in server dialog. >>> This implementation supports user name /password and private/public key >>> combination with Passphrase to crate SSH Tunnel. I have added regression >>> test case to add server using SSH Tunnel options. >>> >>> The given python package(https://pypi.org/project/sshtunnel/) support >>> Python version *2.7, 3.4+*. >>> It uses Paramiko (Python implementation of SSHv2 protocol) which >>> actually drops support for Python 2.6. So I have added >>> *SUPPORT_SSH_TUNNEL* parameter in config.py which checks the python >>> version and set the flag accordingly. In case of Python 2.6, 3.0, 3.1, 3.2 >>> and 3.3 control on the "SSH Tunnel" tab of server dialog will be disabled. >>> >>> Please review it, and if looks good please commit the code. >>> >>> -- >>> *Akshay Joshi* >>> >>> *Sr. Software Architect * >>> >>> >>> >>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
[pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox
Hi Hackers, I have added support for running feature tests against FireFox. For that user will have to download gecko driver from https://github.com/mozilla/ geckodriver/releases and follow the below steps: - Extract the gecko driver. - Run chmod +x geckodriver. - Either copy the geckodriver to /usr/local/bin or the path of the geckodriver must be specified in PATH. - Apply the attached patch. - Change the parameter "DEFAULT_TEST_BROWSER = 'Firefox' " - Start the feature test. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3270.patch Description: Binary data
Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox
Hi Hackers, On Mon, Apr 23, 2018 at 9:07 PM, Anthony Emengo wrote: > We also tried running the tests with this patch. It didn't launch without > some code changes and several tests were failing. We should really defer > pulling this in until we have more robust results on Firefox > > In order to have the tests running we had to do the following change: > > diff --git a/web/regression/feature_utils/app_starter.py > b/web/regression/feature_utils/app_starter.py > index 77b0400c..50d3e307 100644 > --- a/web/regression/feature_utils/app_starter.py > +++ b/web/regression/feature_utils/app_starter.py > @@ -42,10 +44,18 @@ class AppStarter: > ) > > self.driver.set_window_size(1280, 1024) > -self.driver.get( > -"http://"; + self.app_config.DEFAULT_SERVER + ":" + > -random_server_port > -) > +# self.driver.implicitly_wait(60) > + > +def launch_browser(): > +try: > +self.driver.get( > +"http://"; + self.app_config.DEFAULT_SERVER + ":" + > +random_server_port > +) > +except WebDriverException as e: > +time.sleep(5) > +launch_browser() > +launch_browser() > > This change was required because firefox was throwing an exception when we > tried to get the address and the server was not running. We saw this > behavior in Ubuntu. > Yes I have faced the same problem in Ubuntu. As per suggestion by Dave I have added parameter in test_config.json.in and also include the above code given by Anthony. Attached is the modified patch. > > > - Anthony and Joao > > On Mon, Apr 23, 2018 at 9:12 AM, Dave Page wrote: > >> Hi >> >> On Mon, Apr 23, 2018 at 2:05 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> I have added support for running feature tests against FireFox. For that >>> user will have to download gecko driver from https://github.com/mozilla/ >>> geckodriver/releases and follow the below steps: >>> >>>- Extract the gecko driver. >>>- Run chmod +x geckodriver. >>>- Either copy the geckodriver to /usr/local/bin or the path of the >>>geckodriver must be specified in PATH. >>>- Apply the attached patch. >>>- Change the parameter "DEFAULT_TEST_BROWSER = 'Firefox' " >>>- Start the feature test. >>> >>> The config option needs to be in test_config.json. We don't really want >> test-specific config options in config.py (arguably, TEST_SQLITE_PATH >> shoudn't be there either, as it's useless for end users). >> >> I'm surprised to not see any updates to tests. When I tried firefox >> manually a few weeks back, it was failing at lot. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3270_v2.patch Description: Binary data
Re: [pgAdmin4][RM#3155] Allow user to lock the Layout
to see this in at >>>>>>>>>>>>> least 2 commits, one that is related to the preference issue and >>>>>>>>>>>>> another >>>>>>>>>>>>> one that is related to this story. >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> All the tests are working, but he linter is failing: >>>>>>>>>>>>> >>>>>>>>>>>>> /tmp/build/4a5630c2/pivotal-rm-3155/web /tmp/build/4a5630c2 >>>>>>>>>>>>> >>>>>>>>>>>>> <https://gpdb-dev.bosh.pivotalci.info/teams/main/pipelines/pgadmin-feature-branches/jobs/pivotal-rm-3155-python-linter/builds/3#L5ab982d1:9> >>>>>>>>>>>>> ./pgadmin/misc/__init__.py:78: [E303] too many blank lines (2) >>>>>>>>>>>>> >>>>>>>>>>>>> <https://gpdb-dev.bosh.pivotalci.info/teams/main/pipelines/pgadmin-feature-branches/jobs/pivotal-rm-3155-python-linter/builds/3#L5ab982d1:10> >>>>>>>>>>>>> 1 E303 too many blank lines (2) >>>>>>>>>>>>> >>>>>>>>>>>>> <https://gpdb-dev.bosh.pivotalci.info/teams/main/pipelines/pgadmin-feature-branches/jobs/pivotal-rm-3155-python-linter/builds/3#L5ab982d1:11> >>>>>>>>>>>>> >>>>>>>>>>>>> 1 >>>>>>>>>>>>> >>>>>>>>>>>> Fixed >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>> @Dave/Pivotal team, >>>>>>>>>>>>>> The given patch is working fine for all the Tabs/Panels (all >>>>>>>>>>>>>> the panels from main window as well as from Query tool and >>>>>>>>>>>>>> Debugger) but >>>>>>>>>>>>>> I'm facing an issue while handling the Browser tree section, It >>>>>>>>>>>>>> is a wcDocer >>>>>>>>>>>>>> frame <http://docker.api.webcabin.org/module-wcFrame.html> >>>>>>>>>>>>>> and not a wcDocker panel >>>>>>>>>>>>>> <http://docker.api.webcabin.org/module-wcPanel.html>. Like >>>>>>>>>>>>>> wcDocker panel, wcDocker frame do not provide any API so that a >>>>>>>>>>>>>> developer >>>>>>>>>>>>>> can prevent drag-drop functionality on it. >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>> It's not working fine for me. For example, if I put the SQL >>>>>>>>>>> Panel on it's own below the properties/stats panels (so it looks >>>>>>>>>>> like >>>>>>>>>>> pgAdmin 3 used to by default), and then lock the layout, I can >>>>>>>>>>> un-dock the >>>>>>>>>>> SQL panel into a dialogue, but then cannot re-dock it. I can do >>>>>>>>>>> weird >>>>>>>>>>> things with the browser tree as well, probably because it's a frame >>>>>>>>>>> as you >>>>>>>>>>> say. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> That is expected behaviour because once you drag the panel out >>>>>>>>>> of the group of Panels then it becomes individual Frame, That is >>>>>>>>>> what the >>>>>>>>>> author of the wcDocker replied on my question, >>>>>>>>>> *"A panel must either be initialized as movable or non-movable >>>>>>>>>> from the beginning and never changed because it generates a different >>>>>>>>>> arrangement of elements depending. This feature should only ever be >>>>>>>>>> used >>>>>>>>>> within the onCreate method of the panel. I should probably have been >>>>>>>>>> more >>>>>>>>>> clear about this limitation in the documentation."* >>>>>>>>>> >>>>>>>>>> >>>>>>>>> So does it become a panel again if a second panel is added to the >>>>>>>>> new tab group? >>>>>>>>> >>>>>>>> No, it stays Frame. >>>>>>>> >>>>>>>> As far as I understand Panel needs a Frame to render itself if it >>>>>>>> is not attached to the main docker instance. >>>>>>>> >>>>>>>>> >>>>>>>>> There must be some way we can lock a tab that's not part of a >>>>>>>>> group. >>>>>>>>> >>>>>>>> At a moment there is no way of >>>>>>>> locking frames out of the box :( >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> Hmm, so the question becomes: do we include the lock feature, but >>>>>>> rename it to "Lock Tabs" or something similar, or leave it out >>>>>>> altogether? >>>>>>> It clearly doesn't do everything we want right now. >>>>>>> >>>>>> I would say lets include the feature by adding warning note that >>>>>> this feature works with default layout only, And I don't think most user >>>>>> will try to drag drop Browser panel >>>>>> anyway, meanwhile I'll check what changes are required in main source >>>>>> code to make the Frame lock. >>>>>> >>>>> >>>>> Anyone else have any thoughts on this? Personally I don't like >>>>> including half-baked features. >>>>> >>>>> +1, but we need to find out the way as this feature is requested by >>>> many users. >>>> >>> >>> 100% agree. I can convince my self that this feature request has to do >>> with locking panels into a certain layout. I can also convince myself that >>> the same request is simple because users are frustrated with the fact that >>> the tabs and panes move around and they find that behavior annoying. >>> >>> -- Rob >>> >>> >>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: [PATCH] [RM# 3290] Close button missing for the message window from the backend server
On Tue, Apr 24, 2018 at 1:47 PM, Dave Page wrote: > Akshay, can you review/commit this please? > Sure. > > Thanks. > > On Mon, Apr 23, 2018 at 3:34 PM, Anthony Emengo > wrote: > >> Just manually verified that this worked, and the patch successfully went >> through our pipelines. >> >> Thanks so much for fixing this issue! >> >> - Joao and Anthony >> >> On Mon, Apr 23, 2018 at 3:40 AM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> Please find the patch for fixing the RM #3290. >>> The 'Close button' was missing in the message box, which shows the error >>> in the backend server. >>> >>> This patch also fixes some of the missing keycode 'ESCAPE' on 'Cancel' >>> buttons in different modules. >>> >>> Please review. >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> <http://www.enterprisedb.com> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> <http://www.linkedin.com/in/asheshvashi> >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: [pgadmin4][patch] [GreenPlum] Display SQL of table with index #3306
On Tue, Apr 24, 2018 at 1:19 PM, Dave Page wrote: > Akshay, can you review/commit this please? (and update the release notes) > Sure. > > On Mon, Apr 23, 2018 at 2:49 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Hackers, >> Attached you can find the patch that corrects the rm - 3306. >> Also adds some tests around the behavior of the wrapping function of the >> table controller. >> >> Thanks >> Anthony & Joao >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Close button added to the alertify message box, which
Close button added to the alertify message box, which pops up in case of backend error. Fixes #3290 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b653b742ede0e6d30ebb4ec03b8cbb2e0f993478 Author: Ashesh Vashi Modified Files -- web/pgadmin/browser/server_groups/servers/static/js/server.js | 7 --- web/pgadmin/browser/static/js/error.js| 2 +- web/pgadmin/static/js/alertify.pgadmin.defaults.js| 9 ++--- web/pgadmin/tools/datagrid/static/js/datagrid.js | 2 ++ web/pgadmin/tools/sqleditor/static/js/sqleditor.js| 1 + 5 files changed, 14 insertions(+), 7 deletions(-)
Re: [PATCH] [RM# 3290] Close button missing for the message window from the backend server
Thanks patch applied On Tue, Apr 24, 2018 at 2:29 PM, Akshay Joshi wrote: > > > On Tue, Apr 24, 2018 at 1:47 PM, Dave Page wrote: > >> Akshay, can you review/commit this please? >> > >Sure. > >> >> Thanks. >> >> On Mon, Apr 23, 2018 at 3:34 PM, Anthony Emengo >> wrote: >> >>> Just manually verified that this worked, and the patch successfully went >>> through our pipelines. >>> >>> Thanks so much for fixing this issue! >>> >>> - Joao and Anthony >>> >>> On Mon, Apr 23, 2018 at 3:40 AM, Ashesh Vashi < >>> ashesh.va...@enterprisedb.com> wrote: >>> >>>> Hi Team, >>>> >>>> Please find the patch for fixing the RM #3290. >>>> The 'Close button' was missing in the message box, which shows the >>>> error in the backend server. >>>> >>>> This patch also fixes some of the missing keycode 'ESCAPE' on 'Cancel' >>>> buttons in different modules. >>>> >>>> Please review. >>>> >>>> -- >>>> >>>> Thanks & Regards, >>>> >>>> Ashesh Vashi >>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>> <http://www.enterprisedb.com> >>>> >>>> >>>> *http://www.linkedin.com/in/asheshvashi* >>>> <http://www.linkedin.com/in/asheshvashi> >>>> >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel
Hi Hackers As per suggestion by Dave, I have moved "Advanced" tab at the last for Server dialog. Attached is the modified patch. On Mon, Apr 23, 2018 at 7:32 PM, Anthony Emengo wrote: > For what it is worth, I manually verified that the feature worked, as well > as looked through the code. > > I'd like to see end-to-end testing for regression sake, but it's hard to > so at this moment. > > - Anthony and Joao. > > On Mon, Apr 23, 2018 at 5:09 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Mon, Apr 23, 2018 at 1:30 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, Apr 19, 2018 at 6:56 PM, Anthony Emengo >>> wrote: >>> >>>> Hey Akshay >>>> >>>> This patch passed our test pipelines. >>>> >>> >>> Did you test the feature and//or review the code and tests? Passing the >>> tests is great, *if* the whole feature is covered (and the nature of this >>> patch will make that quite difficult, maybe impossible to do without >>> external infrastructure and config). >>> >> >> Agreed, it's been difficult to write test case to test the complete >> feature. >> >>> >>> >>>> >>>> Anthony and Victoria >>>> >>>> On Thu, Apr 19, 2018 at 1:48 AM, Akshay Joshi < >>>> akshay.jo...@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers >>>>> >>>>> I have implemented the SSH Tunnel support using >>>>> https://pypi.org/project/sshtunnel/ python package. Added "SSH >>>>> Tunnel" Tab in server dialog. This implementation supports user name >>>>> /password and private/public key combination with Passphrase to crate SSH >>>>> Tunnel. I have added regression test case to add server using SSH Tunnel >>>>> options. >>>>> >>>>> The given python package(https://pypi.org/project/sshtunnel/) support >>>>> Python version *2.7, 3.4+*. >>>>> It uses Paramiko (Python implementation of SSHv2 protocol) which >>>>> actually drops support for Python 2.6. So I have added >>>>> *SUPPORT_SSH_TUNNEL* parameter in config.py which checks the python >>>>> version and set the flag accordingly. In case of Python 2.6, 3.0, 3.1, 3.2 >>>>> and 3.3 control on the "SSH Tunnel" tab of server dialog will be disabled. >>>>> >>>>> Please review it, and if looks good please commit the code. >>>>> >>>>> -- >>>>> *Akshay Joshi* >>>>> >>>>> *Sr. Software Architect * >>>>> >>>>> >>>>> >>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* SSH_Tunnel_v2.patch Description: Binary data
Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel
Hi Joao On Tue, Apr 24, 2018 at 10:04 PM, Joao De Almeida Pereira wrote: > Hi Akshay, > > After looking through the patch we found some one letter variable names > and this is a regression on what we have been trying to accomplish in the > last year. > > An objective that we have for pgAdmin source code is to increase the > testability of it and make it more readable. If we keep on adding one > letter variables and if we continue adding code to already convoluted > source files it is going to be very hard to achieve this objective. > At my level I have tried not to give one letter variable names. Are you talking about the variable "m" in server.js file which represents the Model? If yes then I have followed the code written for whole schema and I thought we have to maintain the consistency, so use that as it is. Apart from that I haven't seen any other one letter variable, please correct me so that I'll rename it. > > Our recommendations for this change are: > - Name the variables with comprehensive names > Can you please suggest from the patch. > - Extract functions where we can and try to wrap some tests around them > (ex: the javascript disabled functions) > I have tried to do that too, if you can see the "server/__init__.py" file I have created "*get_response_for_password" function to remove redundant code. Based on the condition it will return the json response.* > - We really need to find a better pattern than templated Javascript to > pass information from the backend to the frontend > - When changing a piece of code, if we see code that is confusing or that > is hard to read, we should refactor instead of adding to the pattern. > Please elaborate more with respect to my patch, which part of code should required modification? > > Thanks > Victoria & Joao > > > On Tue, Apr 24, 2018 at 10:13 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers >> >> As per suggestion by Dave, I have moved "Advanced" tab at the last for >> Server dialog. Attached is the modified patch. >> >> On Mon, Apr 23, 2018 at 7:32 PM, Anthony Emengo >> wrote: >> >>> For what it is worth, I manually verified that the feature worked, as >>> well as looked through the code. >>> >>> I'd like to see end-to-end testing for regression sake, but it's hard to >>> so at this moment. >>> >>> - Anthony and Joao. >>> >>> On Mon, Apr 23, 2018 at 5:09 AM, Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> >>>> >>>> >>>> On Mon, Apr 23, 2018 at 1:30 PM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Thu, Apr 19, 2018 at 6:56 PM, Anthony Emengo >>>>> wrote: >>>>> >>>>>> Hey Akshay >>>>>> >>>>>> This patch passed our test pipelines. >>>>>> >>>>> >>>>> Did you test the feature and//or review the code and tests? Passing >>>>> the tests is great, *if* the whole feature is covered (and the nature of >>>>> this patch will make that quite difficult, maybe impossible to do without >>>>> external infrastructure and config). >>>>> >>>> >>>> Agreed, it's been difficult to write test case to test the complete >>>> feature. >>>> >>>>> >>>>> >>>>>> >>>>>> Anthony and Victoria >>>>>> >>>>>> On Thu, Apr 19, 2018 at 1:48 AM, Akshay Joshi < >>>>>> akshay.jo...@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Hackers >>>>>>> >>>>>>> I have implemented the SSH Tunnel support using https://pypi.org/ >>>>>>> project/sshtunnel/ python package. Added "SSH Tunnel" Tab in server >>>>>>> dialog. This implementation supports user name /password and >>>>>>> private/public >>>>>>> key combination with Passphrase to crate SSH Tunnel. I have added >>>>>>> regression test case to add server using SSH Tunnel options. >>>>>>> >>>>>>> The given python package(https://pypi.org/project/sshtunnel/) support >>>>>>> Python version *2.7, 3.4+*. >>>>>>> It uses Paramiko (Python implementation of SSHv2 protocol) which >>>>>>> actually drops support for Pyt
pgAdmin 4 commit: Fixed display SQL of table with index for GreenPlum d
Fixed display SQL of table with index for GreenPlum database. Fixes #3306 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ace6a60f3d16a0202b8ef8fdeb5218846e2bc0e Author: Joao De Almeida Pereira Modified Files -- docs/en_US/release_notes_3_1.rst | 4 +- .../databases/schemas/tables/tests/test_utils.py | 72 ++ .../servers/databases/schemas/tables/utils.py | 33 +- web/pgadmin/utils/compile_template_name.py | 1 - .../utils/tests/test_compile_template_name.py | 6 +- 5 files changed, 92 insertions(+), 24 deletions(-)
Re: [pgadmin4][patch] [GreenPlum] Display SQL of table with index #3306
Thanks patch applied. On Tue, Apr 24, 2018 at 2:29 PM, Akshay Joshi wrote: > > > On Tue, Apr 24, 2018 at 1:19 PM, Dave Page wrote: > >> Akshay, can you review/commit this please? (and update the release notes) >> > >Sure. > >> >> On Mon, Apr 23, 2018 at 2:49 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hi Hackers, >>> Attached you can find the patch that corrects the rm - 3306. >>> Also adds some tests around the behavior of the wrapping function of the >>> table controller. >>> >>> Thanks >>> Anthony & Joao >>> >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fixed issue where icon for Partitioned tables was the
Fixed issue where icon for Partitioned tables was the same as Non Partitioned tables for GreenPlum database. Fixes #3308 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=966279c1b3cc9137ed6bb7ba21e76d0981178b3c Author: Joao De Almeida Pereira Modified Files -- docs/en_US/release_notes_3_1.rst | 3 +- .../servers/databases/schemas/tables/__init__.py | 34 +++ .../schemas/tables/base_partition_table.py | 23 + .../schemas/tables/partitions/__init__.py | 2 +- .../templates/table/sql/gpdb_5.0_plus/nodes.sql| 3 +- .../tables/tests/test_base_partition_table.py | 107 + .../servers/databases/schemas/tables/utils.py | 13 +-- 7 files changed, 152 insertions(+), 33 deletions(-)
Re: [pgadmin4][patch] [GreenPlum] Partitioned table icon is the same as non partitioned tables
Thanks Patch applied. On Wed, Apr 25, 2018 at 2:17 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > Attached you can find 2 patches that correct the Redmine: #3308 > <https://redmine.postgresql.org/issues/3308> A > Patches: > 0001 - In this patch we update the SQL to retrieve the is_partitioned flag > from the database > 0002 - Extract and refactor the icon css class retrieval. It was scattered > around the code and we moved it into it's own small class > > We also realize that the class was present in some places in the > javascript world. What it is strange is that we only override the icon with > the partition one after a successful truncation or successful reset of > statistics. > Why was this behavior added? Can we remove that? > Are you referring to "partition.js"? If yes then according to me it's valid because for partitions we only override the icon with the partition one. Please correct me if I am wrong. > > > Thanks > Victoria & Joao > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently
Hi Joao Linter fails for 'parse_shortcut_value_spec.js' file: $ node pga_eslint.js /Users/akshay/Development/pgadmin4/web/regression/javascript/parse_shortcut_value_spec.js 13:4 error Expected indentation of 2 spaces but found 3 indent 14:7 error Expected indentation of 5 spaces but found 6 indent 21:26 error Missing trailing commacomma-dangle 22:12 error Missing trailing commacomma-dangle 26:4 error Expected indentation of 2 spaces but found 3 indent 27:7 error Expected indentation of 5 spaces but found 6 indent 34:26 error Missing trailing commacomma-dangle 35:12 error Missing trailing commacomma-dangle 39:4 error Expected indentation of 2 spaces but found 3 indent 40:7 error Expected indentation of 5 spaces but found 6 indent 47:25 error Missing trailing commacomma-dangle 48:12 error Missing trailing commacomma-dangle 52:4 error Expected indentation of 2 spaces but found 3 indent 53:7 error Expected indentation of 5 spaces but found 6 indent 60:25 error Missing trailing commacomma-dangle 61:12 error Missing trailing commacomma-dangle 65:4 error Expected indentation of 2 spaces but found 3 indent 66:7 error Expected indentation of 5 spaces but found 6 indent 73:25 error Missing trailing commacomma-dangle 74:12 error Missing trailing commacomma-dangle 78:4 error Expected indentation of 2 spaces but found 3 indent 79:7 error Expected indentation of 5 spaces but found 6 indent 86:25 error Missing trailing commacomma-dangle 87:12 error Missing trailing commacomma-dangle 91:4 error Expected indentation of 2 spaces but found 3 indent 92:7 error Expected indentation of 5 spaces but found 6 indent 99:25 error Missing trailing commacomma-dangle 100:12 error Missing trailing commacomma-dangle 104:4 error Expected indentation of 2 spaces but found 3 indent 105:7 error Expected indentation of 5 spaces but found 6 indent 112:25 error Missing trailing commacomma-dangle 113:12 error Missing trailing commacomma-dangle *✖ 32 problems (32 errors, 0 warnings)* On Mon, Apr 30, 2018 at 8:10 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi there, > > We weren't able to see these functions get called. Perhaps we're missing > something. > > Thanks, > Joao && Anthony > > On Mon, Apr 30, 2018 at 2:48 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Joao, >> >> The patches look good however I have noticed that you >> deleted attachShortcut and attachDialogTabNavigatorShortcut functions >> from keyboard.js, any specific reason for that? >> >> Thanks, >> Khushboo >> >> On Fri, Apr 27, 2018 at 3:11 AM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hi Khushboo, >>> >>> I did some changes on your patch: >>> 0001 - Your original patch >>> 0002 - Convert keyboard.js to ES6 >>> 0003 - Refactoring of the keyboard.js file(some one letter variables >>> and other code) >>> >>> >>> >>> Thanks >>> Joao >>> >>> On Thu, Apr 26, 2018 at 5:34 AM Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> Please find the attached patch to fix the RM #3284 : F5 key not working >>>> consistently. >>>> >>>> - Added the configurable keyboard shortcut (default F5) to refresh the >>>> browser tree nodes. >>>> >>>> >>>> Thanks, >>>> Khushboo >>>> >>> >> -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: F5 key should work to refresh Browser tree. Fixes #32
F5 key should work to refresh Browser tree. Fixes #3284 Refactoring by: Joao Pedro De Almeida Pereira Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=732d8d903dc76eef22b83a8eb01ed754ba877f31 Author: Khushboo Vashi Modified Files -- .../browser/register_browser_preferences.py| 15 + web/pgadmin/browser/static/js/keyboard.js | 458 ++--- web/pgadmin/static/js/utils.js | 2 +- .../javascript/parse_shortcut_value_spec.js| 117 ++ 4 files changed, 357 insertions(+), 235 deletions(-)
