Re: [pgAdmin][RM-6916]: Allow disabling GPU hardware acceleration

[Dave Page]

Hi

On Tue, Jan 18, 2022 at 6:20 AM Akshay Joshi 
wrote:

> Hi Dave/Nikhil
>
> On Thu, Jan 13, 2022 at 1:31 PM Dave Page  wrote:
>
>>
>>
>> On Thu, 13 Jan 2022 at 07:38, Akshay Joshi 
>> wrote:
>>
>>> Thanks, the patch applied.
>>>
>>
>> Should we really hard code this? I’m not sure the GPU would actually be
>> used much, but I really don’t know for sure. It might be, for example, for
>> videos on our website.
>>
>> I wonder if this should be a runtime config option (if possible), or a
>> command line option.
>>
>
> We can make it configurable by performing the following changes:
>
>- Add a switch control in the configure dialog labeled 'Disable
>GPU hardware acceleration'. By default its value is False.
>- Will create a config option in "runtime_config.json" like other
>options port, timeout, etc...
>- When the user would like to disable the GPU, they will update
>the switch control and it needs a restart of pgAdmin anyway.
>- We will update the *package.json* file like "chromium-args": 
> "--disable-popup-blocking
>--disable-gpu", and restart the pgAdmin.
>
>  If the above seems OK then @Nikhil you can start working on the above
> changes.
>

Hmm, no, we can't do that. First, it would invalidate the appbundle
signature on macOS, and secondly, on most OS's it would require root
privileges to modify an installed file.

Is there no way of setting it from code at startup?


>
>>
>>
>>> On Thu, Jan 13, 2022 at 11:53 AM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Please find the attached patch for RM-6916:
   Allow disabling GPU
 hardware acceleration


 --
 *Thanks & Regards,*
 *Nikhil Mohite*
 *Senior Software Engineer.*
 *EDB Postgres* 
 *Mob.No: +91-7798364578.*

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>> --
>> --
>> Dave Page
>> https://pgsnake.blogspot.com
>>
>> EDB Postgres
>> https://www.enterprisedb.com
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com

pgAdmin 4 commit: Fixed feature test cases for maintenance dialog.

[Akshay Joshi]

Fixed feature test cases for maintenance dialog.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e7e4d5cf0a82773f10b2ec58ae981ce6642cc41b
Author: Nikhil Mohite 

Modified Files
--
web/pgadmin/feature_tests/pg_utilities_maintenance_test.py | 2 +-
web/pgadmin/tools/maintenance/static/js/maintenance.js | 4 
web/regression/feature_utils/pgadmin_page.py   | 2 +-
3 files changed, 6 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Fixed following code smells reported by SonarQube:

[Akshay Joshi]

Fixed following code smells reported by SonarQube:
 1) Immediately return this expression instead of assigning it to the temporary 
variable.
 2) Extract this nested ternary operation into an independent statement.
 3) Expected a `for-of` loop instead of a `for` loop with this simple iteration.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9f836f54334ec0752a79f34d5527a695ed83476a

Modified Files
--
runtime/src/js/misc.js |  8 +--
.../index_constraint/static/js/primary_key.js  |  6 +-
web/pgadmin/browser/static/js/browser.js   | 35 ++-
web/pgadmin/browser/static/js/collection.js|  5 +-
web/pgadmin/browser/static/js/node.js  | 17 --
.../browser/static/js/quick_search/online_help.js  |  4 +-
.../static/js/quick_search/trigger_search.js   |  1 -
web/pgadmin/dashboard/static/js/Graphs.jsx |  8 +--
.../misc/dependencies/static/js/dependencies.js| 11 ++--
.../misc/dependents/static/js/dependents.js| 11 ++--
web/pgadmin/misc/static/explain/js/explain.js  | 50 
.../misc/statistics/static/js/statistics.js|  8 ++-
web/pgadmin/static/js/SchemaView/DataGridView.jsx  |  6 +-
web/pgadmin/static/js/SchemaView/FormView.jsx  | 10 +++-
web/pgadmin/static/js/alertify.pgadmin.defaults.js | 13 ++--
web/pgadmin/static/js/api_instance.js  |  3 +-
web/pgadmin/static/js/backform.pgadmin.js  | 39 
web/pgadmin/static/js/backgrid.pgadmin.js  | 37 +++-
web/pgadmin/static/js/check_node_visibility.js |  4 +-
.../codemirror/addon/fold/pgadmin-sqlfoldcode.js   |  3 +-
.../static/js/components/FormComponents.jsx| 10 +++-
web/pgadmin/static/js/components/PgTable.jsx   |  3 +-
.../static/js/selection/active_cell_capture.js |  4 +-
web/pgadmin/static/js/selection/clipboard.js   |  3 +-
web/pgadmin/static/js/selection/column_selector.js |  3 +-
web/pgadmin/static/js/selection/grid_selector.js   |  4 +-
web/pgadmin/static/js/selection/row_selector.js|  4 +-
web/pgadmin/static/js/selection/set_staged_rows.js |  6 +-
.../static/js/selection/xcell_selection_model.js   | 11 ++--
web/pgadmin/static/js/size_prettify.js |  4 +-
.../js/slickgrid/plugins/slick.autocolumnsize.js   |  4 +-
web/pgadmin/static/js/sqleditor/execute_query.js   |  3 +-
.../static/js/sqleditor/filter_dialog_model.js |  3 +-
web/pgadmin/static/js/sqleditor/geometry_viewer.js |  3 +-
web/pgadmin/static/js/sqleditor/macro_model.js |  7 +--
.../static/js/sqleditor/query_tool_actions.js  |  2 +-
web/pgadmin/static/js/tree/tree.js |  5 +-
web/pgadmin/static/vendor/backgrid/backgrid.js | 70 +++---
web/pgadmin/tools/backup/static/js/backup.js   |  6 +-
web/pgadmin/tools/datagrid/static/js/datagrid.js   | 18 +++---
.../datagrid/static/js/datagrid_panel_title.js |  4 +-
web/pgadmin/tools/datagrid/static/js/show_data.js  |  5 +-
.../tools/datagrid/static/js/show_query_tool.js|  3 +-
web/pgadmin/tools/debugger/static/js/debugger.js   |  8 +--
.../tools/debugger/static/js/debugger_ui.js|  8 +--
.../tools/debugger/static/js/debugger_utils.js | 12 
web/pgadmin/tools/debugger/static/js/direct.js | 46 +++---
web/pgadmin/tools/erd/static/js/erd_module.js  |  3 +-
.../js/erd_tool/ui_components/BodyWidget.jsx   |  7 +--
.../tools/grant_wizard/static/js/GrantWizard.jsx   |  7 ++-
.../tools/grant_wizard/static/js/grant_wizard.js   |  6 +-
.../tools/maintenance/static/js/maintenance.js |  8 +--
web/pgadmin/tools/psql/static/js/psql_module.js|  4 +-
web/pgadmin/tools/restore/static/js/restore.js |  7 +--
.../tools/schema_diff/static/js/schema_diff_ui.js  | 26 
.../static/js/search_objects_dialog_wrapper.js |  6 +-
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 32 +-
web/regression/javascript/browser/layout_spec.js   | 12 ++--
web/regression/javascript/fake_theme.js|  4 +-
web/regression/javascript/tree/tree_fake.js|  8 ++-
web/webpack.config.js  | 14 ++---
web/webpack.shim.js|  4 +-
62 files changed, 367 insertions(+), 319 deletions(-)

Re: [pgAdmin]: Fix test cases for maintenance dialog.

[Akshay Joshi]

Thanks, the patch applied.

On Mon, Jan 17, 2022 at 3:00 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch to fix the feature test case falling for
> the Maintenance dialog.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Senior Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

[pgAdmin][patch] Form Input Select enhancements

[Aditya Toshniwal]

Hi Hackers,

Attached will add support for grouping in input select boxes and allow
setting default selected options.
Please review.

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


inputselect.enhance.patch
Description: Binary data

Re: [pgAdmin][RM-6916]: Allow disabling GPU hardware acceleration

[Aditya Toshniwal]

Hi,

The only ways to pass flags are using cli or putting it in package.json.
If we want to keep it configurable then we need to spawn in from the main
process and pass the flags.

On Tue, Jan 18, 2022 at 2:21 PM Dave Page  wrote:

> Hi
>
> On Tue, Jan 18, 2022 at 6:20 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Dave/Nikhil
>>
>> On Thu, Jan 13, 2022 at 1:31 PM Dave Page  wrote:
>>
>>>
>>>
>>> On Thu, 13 Jan 2022 at 07:38, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Thanks, the patch applied.

>>>
>>> Should we really hard code this? I’m not sure the GPU would actually be
>>> used much, but I really don’t know for sure. It might be, for example, for
>>> videos on our website.
>>>
>>> I wonder if this should be a runtime config option (if possible), or a
>>> command line option.
>>>
>>
>> We can make it configurable by performing the following changes:
>>
>>- Add a switch control in the configure dialog labeled 'Disable
>>GPU hardware acceleration'. By default its value is False.
>>- Will create a config option in "runtime_config.json" like other
>>options port, timeout, etc...
>>- When the user would like to disable the GPU, they will update
>>the switch control and it needs a restart of pgAdmin anyway.
>>- We will update the *package.json* file like "chromium-args": 
>> "--disable-popup-blocking
>>--disable-gpu", and restart the pgAdmin.
>>
>>  If the above seems OK then @Nikhil you can start working on the
>> above changes.
>>
>
> Hmm, no, we can't do that. First, it would invalidate the appbundle
> signature on macOS, and secondly, on most OS's it would require root
> privileges to modify an installed file.
>
> Is there no way of setting it from code at startup?
>
>
>>
>>>
>>>
 On Thu, Jan 13, 2022 at 11:53 AM Nikhil Mohite <
 nikhil.moh...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-6916:
>   Allow disabling GPU
> hardware acceleration
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Senior Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


 --
 *Thanks & Regards*
 *Akshay Joshi*
 *pgAdmin Hacker | Principal Software Architect*
 *EDB Postgres *

 *Mobile: +91 976-788-8246*

>>> --
>>> --
>>> Dave Page
>>> https://pgsnake.blogspot.com
>>>
>>> EDB Postgres
>>> https://www.enterprisedb.com
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Dave Page
> Blog: https://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: https://www.enterprisedb.com
>
>

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"

Re: [pgAdmin][patch] Form Input Select enhancements

[Aditya Toshniwal]

Hi Hackers,

Please ignore the previous patch. Attached is the updated version.

On Tue, Jan 18, 2022 at 4:21 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached will add support for grouping in input select boxes and allow
> setting default selected options.
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


inputselect.enhance.v2.patch
Description: Binary data

pgAdmin 4 commit: Fixed context menu issue.

[Akshay Joshi]

Fixed context menu issue.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6adc1bfd4268b227c10cce95329537fa5dd3c786

Modified Files
--
web/pgadmin/browser/static/js/browser.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Added support for grouping in input select boxes and

[Akshay Joshi]

Added support for grouping in input select boxes and allow setting default 
selected options.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fbc3b1a3185fbc1dd16de14f31f5c0280d5d547d
Author: Aditya Toshniwal 

Modified Files
--
.../static/js/components/FormComponents.jsx| 45 ++
1 file changed, 37 insertions(+), 8 deletions(-)

Re: [pgAdmin][patch] Form Input Select enhancements

[Akshay Joshi]

Thanks, the patch applied.

On Tue, Jan 18, 2022 at 6:39 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please ignore the previous patch. Attached is the updated version.
>
> On Tue, Jan 18, 2022 at 4:21 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached will add support for grouping in input select boxes and allow
>> setting default selected options.
>> Please review.
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>> 
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM-6916]: Allow disabling GPU hardware acceleration

[Dave Page]

Hi

On Tue, Jan 18, 2022 at 12:24 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi,
>
> The only ways to pass flags are using cli or putting it in package.json.
> If we want to keep it configurable then we need to spawn in from the main
> process and pass the flags.
>

Urgh. In that case, back to my original question: would unconditionally
disabling the GPU actually affect pgAdmin?


>
> On Tue, Jan 18, 2022 at 2:21 PM Dave Page  wrote:
>
>> Hi
>>
>> On Tue, Jan 18, 2022 at 6:20 AM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Dave/Nikhil
>>>
>>> On Thu, Jan 13, 2022 at 1:31 PM Dave Page  wrote:
>>>


 On Thu, 13 Jan 2022 at 07:38, Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Thanks, the patch applied.
>

 Should we really hard code this? I’m not sure the GPU would actually be
 used much, but I really don’t know for sure. It might be, for example, for
 videos on our website.

 I wonder if this should be a runtime config option (if possible), or a
 command line option.

>>>
>>> We can make it configurable by performing the following changes:
>>>
>>>- Add a switch control in the configure dialog labeled 'Disable
>>>GPU hardware acceleration'. By default its value is False.
>>>- Will create a config option in "runtime_config.json" like other
>>>options port, timeout, etc...
>>>- When the user would like to disable the GPU, they will update
>>>the switch control and it needs a restart of pgAdmin anyway.
>>>- We will update the *package.json* file like "chromium-args": 
>>> "--disable-popup-blocking
>>>--disable-gpu", and restart the pgAdmin.
>>>
>>>  If the above seems OK then @Nikhil you can start working on the
>>> above changes.
>>>
>>
>> Hmm, no, we can't do that. First, it would invalidate the appbundle
>> signature on macOS, and secondly, on most OS's it would require root
>> privileges to modify an installed file.
>>
>> Is there no way of setting it from code at startup?
>>
>>
>>>


> On Thu, Jan 13, 2022 at 11:53 AM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch for RM-6916:
>>   Allow disabling GPU
>> hardware acceleration
>>
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Senior Software Engineer.*
>> *EDB Postgres* 
>> *Mob.No: +91-7798364578.*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>
 --
 --
 Dave Page
 https://pgsnake.blogspot.com

 EDB Postgres
 https://www.enterprisedb.com

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Dave Page
>> Blog: https://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: https://www.enterprisedb.com
>>
>>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com

pgAdmin 4 commit: Fixed enable/disable menu issue introduced by SonarQu

[Akshay Joshi]

Fixed enable/disable menu issue introduced by SonarQube fix.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dabe64a8df1a22095d63dade37025e64c8339394

Modified Files
--
web/pgadmin/browser/static/js/browser.js | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)

[pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.

[Yogesh Mahajan]

Hi Hackers,

Please find the patch which port import/export data dialogue to react.
Thanks,
Yogesh Mahajan
EnterpriseDB


RM_7017_v1.patch
Description: Binary data

[pgAdmin][RM-7035]: v6.2 keeps opening connections to (closed) connections on initial connection to database server/cluster

[Nikhil Mohite]

Hi Hackers,

Please find the attached patch for RM-7035:
 v6.2 keeps opening connections
to (closed) connections on the initial connection to the database
server/cluster


-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Senior Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*


RM-7035.patch
Description: Binary data